Skip to content
  1. May 25, 2020
  2. May 22, 2020
    • pscott's avatar
      Add JSON format to import blocks and set it as default (#5816) · 9aa7b8f8
      pscott authored
      
      
      * Add BlockStream Enum and utility fn
      
      * WIP: Modify import closure to work with BlockStream
      
      * Fix trait bounds
      
      * Working prototype
      
      * Revamp block importing
      
      * Add export_import_flow tests
      
      * Add comments and clean code
      
      * Add more comments in the import fn
      
      * Add link code to import function
      
      * Add condition when returning Ready(Ok(()) to make sure we've imported every block
      
      * Add check for imported blocks in JSON case
      
      * Use rest pattern
      
      * Fix compilation error for undeclared variable
      
      * Add polling and waker before pending
      
      * Print read_block_count instead of count
      
      * Simplify binary cli option with structopt
      
      * Update test to reflect changes in CLI api
      
      * Change Stream to take SignedBlock<B> instead of B
      
      * Add comments to BlockStream
      
      * Move out logic to smaller functions for clearer code
      
      * Remove result over import_blocks return type
      
      * Check for error in command output rather than simply checking command exit status
      
      * Revamp export/import/revert testing
      
      * Fix minor typos and formatting errors
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Remove unnecessary if condition in terminating condition
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Explicit error instead of returning it as a string
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Pass BlockStream to log_importing_status_updates and simplify matching arms for block stream
      
      * Use .contains() instead of regex match
      
      * Line break in match block; return future::ready instead of poll_fn
      
      * Update Cargo.lock
      
      * Add check so that queue doesn't grow too big
      
      * Use Iterator instead of Stream
      
      * Remove allow dead_code
      
      * Remove outdated comments
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Return Errors instead of logging them
      
      * Simplify match arms
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Remove check before terminating block import
      
      * Apply suggestions from code review
      
      * Check that queue is not full BEFORE calling
      
      * Revert "Remove check before terminating block import"
      
      This reverts commit 377823c0
      
      .
      
      * Improve unit tests to make sure we actually import blocks
      
      * Remove Unpin implementation for BlockIter
      
      * Add prototype of enum for ImportStates
      
      * Add working prototype for StateMachine
      
      * Add comments for clearer code
      
      * Add sleep before calling Waker when waiting for import queue
      
      * Add Speedometer
      
      * add dbg!(&log) for test debugging
      
      * Fix lines with more than 100 cols
      
      * Fix regex capture for test
      
      * Update regexes to take to capture the whole number
      
      * Rename Cmd to Command
      
      Co-authored-by: default avatarGavin Wood <[email protected]>
      
      * Actually rename Cmd to Command
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarGavin Wood <[email protected]>
      
      * Fix compilation errors for tests
      
      * Fix compilation errors from code review suggestion
      
      * Update bin/node/cli/tests/export_import_flow.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: default avatarGavin Wood <[email protected]>
      Co-authored-by: default avatarBenjamin Kampmann <[email protected]>
      9aa7b8f8
  3. May 21, 2020
  4. May 20, 2020
  5. May 18, 2020
  6. May 16, 2020
  7. May 15, 2020
  8. May 14, 2020
  9. May 13, 2020
    • Bastian Köcher's avatar
      Handle clap errors manually and don't reset `SIGPIPE` (#6012) · 525dc61d
      Bastian Köcher authored
      Instead of resetting `SIGPIPE` to the system default handler, we now
      handle a clap error manually and ignore any error when writing to
      `stdout`/`stderr`. In this way, the node does not silently stops when it
      encounters a `SIGPIPE` in normal mode and we still support piping of the
      cli output.
      525dc61d
  10. May 12, 2020
  11. May 07, 2020
  12. May 06, 2020
    • Igor Matuszewski's avatar
      client: Replace `unsafe_rpc_expose` with an `RpcMethods` enum (#5729) · 24486f52
      Igor Matuszewski authored
      
      
      * client: Replace `unsafe_rpc_expose` with an `RpcMethods` enum
      
      which can be either Default, Safe or Unsafe. The idea is to have the
      following:
      |                       | --rpc-external=false  | --rpc-external=true   |
      |---------------------  |-------------------    |-----------------      |
      | --rpc-methods=Default |                       | unsafe calls denied   |
      | --rpc-methods=Safe    | unsafe calls denied   | unsafe calls denied   |
      | --rpc-methods=Unsafe  |                       |                       |
      Since the previous `unsafe-rpc-expose` option was confusing.
      
      * client: Only warn against exposing externally unsafe RPC method set
      
      * Apply suggestions from code review
      
      Co-Authored-By: default avatarCecile Tonglet <[email protected]>
      
      * cli: Rephrase doc comment for rpc_methods config
      
      * Improve debuggability of build_spec_works
      
      ...by printing to stderr the stderr of the command. This is normally
      suppressed for succesful tests but not for failing ones - if that's the
      case then it's useful to see the test failure reason inline rather than
      having to execute the command separately ourselves.
      
      * Rename RpcMethods::{Default => Auto} variant
      
      * Update bin/node/cli/tests/build_spec_works.rs
      
      Co-authored-by: default avatarBenjamin Kampmann <[email protected]>
      Co-authored-by: default avatarCecile Tonglet <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      24486f52
  13. May 05, 2020
  14. Apr 30, 2020
  15. Apr 29, 2020
  16. Apr 28, 2020
    • Web3 Philosopher's avatar
      Move sc-client into sc-service (#5502) · fc6d55c9
      Web3 Philosopher authored
      * Drop client from sc-network and sc-client-db, move LongestChain to sc-client-api
      
      * move leaves, cht, in_mem to sc-client-api, drop client from sc-finality-grandpa
      
      * drop sc-service from sc-rpc
      
      * drop sc-service from sc-consensus-aura
      
      * drop sc-client from manual-seal and babe
      
      * drop sc-client from utils/frame/rpc/system and utils/frame/benchmarking-cli
      
      * drop sc-client from bin/node and bin/node-template
      
      * drop sc-client
      
      * fix tests
      
      * remove check -p sc-client from gitlab.yml
      
      * fix warnings
      
      * fixes ui test
      
      * fix light client tests
      
      * adds associated Client type to AbstractService
      
      * adds UsageProvider to Client
      
      * fixed ui test, again
      
      * tried and failed to get node-cli to compile for wasm
      
      * thanks to tomaka for helping me get node-cli to compile for wasmm
      
      * ui test pls pas 🙏🏾
      
      
      
      * all tests passing 🪄
      
      * no_run documentation code
      
      * rm -f documentation code
      
      * ClientProvider
      
      * fix mega trait
      
      * move LongestChain to sc-consensus, use adds minimal bounds to AbstractService::Client
      
      * adds license to sc-consensus
      
      Co-authored-by: default avatarBenjamin Kampmann <[email protected]>
      fc6d55c9
    • Cecile Tonglet's avatar
      Fix remaining issues with unsafe_pruning (#5810) · 952d5755
      Cecile Tonglet authored
      * Initial commit
      
      Forked at: c13ad416
      Parent branch: origin/master
      
      * Fix remaining issues with unsafe_pruning
      
      * Revert "Fix remaining issues with unsafe_pruning"
      
      This reverts commit 9c42c2f9.
      
      * Just remove is_dev
      952d5755
  17. Apr 27, 2020
  18. Apr 24, 2020
  19. Apr 23, 2020
    • Toralf Wittner's avatar
      network: Only insert global addresses into the DHT. (#5735) · 435a7108
      Toralf Wittner authored
      * network: Only insert global addresses into the DHT.
      
      Currently every address reported via libp2p-identify is inserted into
      the DHT which thus contains a multitude of unreachable addresses such
      as from 127.0.0.0/8 or 10.0.0.0/8.
      
      Issue #5099 suggested a dedicated service over UDP to gauge the
      reachability of an address, which would however incur extra I/O costs
      and be of limited use.
      
      As an alternative and simpler tactic, this PR only allows global IP
      addresses to be inserted into the DHT unless an explicit command-line
      flag `--allow-non-global-addresses-in-dht` is given or a node is
      started with `--dev`. This opt-in behaviour is meant to allow
      site-local networks to still make use of a DHT.
      
      * Enable non-global in more test setups.
      
      * Replace command-line option with different name.
      
      * Another test fix.
      435a7108
  20. Apr 22, 2020
  21. Apr 20, 2020
    • Igor Matuszewski's avatar
      Allow to expose a subset of unsafe RPCs (#5233) · 58d32c13
      Igor Matuszewski authored
      * sc-cli: Use type-safe constructors for RPC/Prometheus interfaces
      
      * service: Simplify rpc handler creation
      
      Could probably be further simplifies once [this][commit] lands.
      
      [commit]: https://github.com/paritytech/jsonrpc/commit/20485387ed06a48f1a70bf4d609a7cde6cf0accf
      
      * service: Streamline some HTTP & WS server start logic
      
      * client: Introduce a simple RPC policy mechanism
      
      * rpc/system: Check unsafe RPCs
      
      * rpc/offchain: Check unsafe RPCs
      
      * rpc/author: Check unsafe RPCs
      58d32c13
  22. Apr 17, 2020
  23. Apr 16, 2020
  24. Apr 15, 2020
  25. Apr 14, 2020
  26. Apr 13, 2020