Skip to content
  1. Aug 12, 2020
  3. Aug 11, 2020
  5. Aug 10, 2020
    • Alexander Theißen's avatar
      seal: Change prefix and module name from "ext_" to "seal_" for contract callable functions (#6798) · 5f9e3553
      Alexander Theißen authored 
      * seal: Change prefix "ext_" to "seal_" for contract callable functions

The word Ext is a overloaded term in the context of substrate. It usually
is a trait which abstracts away access to external resources usually in order
to mock them away for the purpose of tests. The contract module has its own
`Ext` trait in addition the the substrate `Ext` which makes things even more
confusing.

In order to differentiate the contract callable functions more clearly from
this `Ext` concept we rename them to use the "seal_" prefix instead.

This should change no behaviour at all. This is a pure renaming commit.

* seal: Rename import module from "env" to "seal0"

* seal: Fixup integration test

* seal: Add more tests for new import module names
      5f9e3553
    • Hernando Castano's avatar
      Add Subscription RPC for Grandpa Finality (#5732) · eb0e05e1
      Hernando Castano authored 
      

* Rough skeleton for what I think the RPC should look like

* Create channel for sending justifications

Sends finalized header and justification from Grandpa to the
client. This lays the groundwork for hooking into the RPC module.

* WIP: Add subscribers for justifications to Grandpa

Adds the Sender end of a channel into Grandpa, through which notifications
about block finality events can be sent.

* WIP: Add a struct for managing subscriptions

Slightly different approach from the last commit, but same
basic idea. Still a rough sketch, very much doesn't compile yet.

* Make naming more clear and lock data in Arc

* Rough idea of what RPC would look like

* Remove code from previous approach

* Missed some things

* Update client/rpc-api/src/chain/mod.rs

Co-Authored-By: default avatarTomasz Drwięga <[email protected]>

* Update client/rpc-api/src/chain/mod.rs

Co-Authored-By: default avatarTomasz Drwięga <[email protected]>

* Split justification subscription into sender and receiver halves

* Replace RwLock with a Mutex

* Add sample usage from the Service's point of view

* Remove code that referred to "chain_" RPC

* Use the Justification sender/receivers from Grandpa LinkHalf

* Add some PubSub boilerplate

* Add guiding comments

* TMP: comment out to fix compilation

* Return MetaIoHandler from PubSubHandler in create_full

* Uncomment pubsub methods in rpc handler (fails to build)

* node/rpc: make Metadata concrete in create_full to fix compilation

* node: pass in SubscriptionManger to grandpa rpc handler

* grandpa-rpc: use SubscriptionManger to add subscriber

* grandpa-rpc: attempt at setting up the justification stream (fails to build)

* grandpa-rpc: fix compilation of connecting stream to sink

* grandpa-rpc: implement unsubscribe

* grandpa-rpc: update older tests

* grandpa-rpc: add full prefix to avoid confusing rust-analyzer

* grandpa-rpc: add test for pubsub not available

* grandpa-rpc: tidy up leftover code

* grandpa-rpc: add test for sub and unsub of justifications

* grandpa-rpc: minor stylistic changes

* grandpa-rpc: split unit test

* grandpa-rpc: minor stylistic changes in test

* grandpa-rpc: skip returning future when cancelling

* grandpa-rpc: reuse testing executor from sc-rpc

* grandpa-rpc: don't need to use PubSubHandler in tests

* node-rpc: use MetaIoHandler rather than PubSubHandler

* grandpa: log if getting header failed

* grandpa: move justification channel creation into factory function

* grandpa: make the justification sender optional

* grandpa: fix compilation warnings

* grandpa: move justification notification types to new file

* grandpa-rpc: move JustificationNotification to grandpa-rpc

* grandpa-rpc: move JustificationNotification to its own file

* grandpa: rename justification channel pairs

* grandpa: rename notifier types

* grandpa: pass justification as GrandpaJustification to the rpc module

* Move Metadata to sc-rpc-api

* grandpa-rpc: remove unsed error code

* grandpa: fix bug for checking if channel is closed before sendind

* grandpa-rpc: unit test for sending justifications

* grandpa-rpc: update comments for the pubsub test

* grandpa-rpc: update pubsub tests with more steps

* grandpa-rpc: fix pubsub test

* grandpa-rpc: minor indendation

* grandpa-rpc: decode instead of encode in test

* grandpa: fix review comments

* grandpa: remove unused serde dependency

Co-authored-by: default avatarTomasz Drwięga <[email protected]>
Co-authored-by: default avatarJon Häggblad <[email protected]>
Co-authored-by: default avatarTomasz Drwięga <[email protected]>
      eb0e05e1
    • Joshy Orndorff's avatar
      Update pinned wasm-bindgen dependency (#6861) · 6f31766f
      Joshy Orndorff authored 
      * Update dependency.

* Update readme docs

* update python webserver command
      6f31766f
  7. Aug 06, 2020
    • Hamza Tokuchi's avatar
      Add RPC Builder to Substrate Node Template (#6808) · bcf9dc57
      Hamza Tokuchi authored 
      

* Pulled RPC from node and populated the node-template's RPC builder with one example implementation

* surpress build errror

* dead_code

* Fixed module usage, removed copyright, removed rpc builder for light client + some comments

* added a comment for rpc extension

* Update bin/node-template/node/src/rpc.rs

Co-authored-by: default avatarShawn Tabrizi <[email protected]>

* Update rpc.rs

* fix spacing

* more space to tabs

* more space to tabs

* Documenation nitpick

* Documentation nitpick

* Documentation nitpick

* Documentation nitpick

* Documentation nitpick

* pre-format

* Updated transaction payment API implemented for node template

* fix space and commented code

* fix long line

Co-authored-by: default avatarShawn Tabrizi <[email protected]>
Co-authored-by: default avatarDan Forbes <[email protected]>
      bcf9dc57
  9. Aug 05, 2020
  11. Aug 03, 2020
    • Shawn Tabrizi's avatar
      Improve Benchmark Writer: Remove Unused Components, Remove Multiply by Zero,... · 2bd4f451
      Shawn Tabrizi authored 
      Improve Benchmark Writer: Remove Unused Components, Remove Multiply by Zero, Files Split by Pallet (#6785)

* initial improvements

* better file management, ignore unused components

* Output warning when components unused

* update comment

* Write even when base weight is zero

* remove unwrap where possible

* Dont sort components to dedup

* undo delete

* improve clarity of unused components

* remove unused dep

* Update Process.json
      2bd4f451
  13. Jul 31, 2020
  15. Jul 30, 2020
  17. Jul 29, 2020
    • Alexander Theißen's avatar
      seal: Add benchmarks for dispatchables (#6715) · 4e832cdb
      Alexander Theißen authored 
      * seal: Fix syntax that confuses rust-analyzer

* seal: Add benchmarks for Dispatchables

These are only the benchmarks for the dispatchables of
the pallet. Those are not listed in the Schedule because
we do not want to pull the Schedule from storage before
dispatching.

This OK because those costs are not related to actual contract
execution. Those costs (instruction costs, ext_* costs) will
be benchmarked seperatly and entered into the default Schedule.

* seal: Add a maximum code size

* Fix comments from review

* Removed SEED constant
      4e832cdb
  19. Jul 28, 2020
  21. Jul 27, 2020
  23. Jul 26, 2020
  25. Jul 24, 2020
  27. Jul 22, 2020
    • Pierre Krieger's avatar
      Remove clear_on_drop from browser util crate (#6710) · edb48cfd
      Pierre Krieger authored
      edb48cfd
    • Wei Tang's avatar
      Better handling of stable-only build (#6569) · 17922fe4
      Wei Tang authored 
      

* Better handling of stable-only build

* Fix node template build

* Fix wasm builder node-template version mismatch

* Fix load_spec error

* Add , in parameter

* Add descrptive panic messages in tests

* Add descriptive tests in node/executor benches

* Fix missing compact_code_unwrap

* Add missing wasm_binary_unwrap function for executor integration test

* Only define import_sp_io in no_std

* Small Cargo.toml styling fix

* Bump wasm-builder to 2.0.0

* Fix all `with_wasm_builder_from_crates` version in Substrate

* Use `with_wasm_builder_from_crates` for node-template

Co-authored-by: default avatarGavin Wood <[email protected]>
      17922fe4
    • Ashley's avatar
      Remove the service builder (#6557) · 08c3d65c
      Ashley authored 
      

* :)

* Slight tidy

* Remove ServiceBuilderCommand

* Remove whitespace

* Keep task manager alive for check_block/import_blocks

* Pass task_manager to run_until_exit

* WIP

* WIP

* Get rid of the macros

* Simplify a few chain components creation APIs related to the service

* Fix basic-authorship doc tests

* Remove DefaultQueue

* Update client/service/src/builder.rs

Co-authored-by: default avatarAndré Silva <[email protected]>

* Move ExecutionExtensions comment around

* Remove unused BlakeTwo256

* Add sc-prelude

* Rename sc-prelude to sc-service-prelude

* Rename to sc-service-types

* Improve service types

* Fix line widths

* Remove sc-service-types and move type definitions to crates

* Update bin/node-template/node/src/service.rs

Co-authored-by: default avatarSeun Lanlege <[email protected]>

* Add TLightClientWithHash

* Rework types

Co-authored-by: default avatarAndré Silva <[email protected]>
Co-authored-by: default avatarSeun Lanlege <[email protected]>
      08c3d65c
    • Nikolay Volf's avatar
      Update wasmtime to (almost) lastest master (#6662) · 909559ca
      Nikolay Volf authored 
      * update wasmtime to (almost) lastest master

* bump lock

* bump once more
      909559ca
    • Benjamin Kampmann's avatar
      Update to latest sysinfo prevents leaking fd-handlers (#6708) · 065b0f32
      Benjamin Kampmann authored 
      * Ensure we close old file handles hold by sysinfo

* Dropping is needed unfortunately

* enable process refreshing, ignore result from refresh_process

* jumping to proposed patch

* switch to latest sysinfo
      065b0f32
    • Cecile Tonglet's avatar
      Graceful shutdown for the task manager (#6654) · 64d4a4da
      Cecile Tonglet authored 
      * Initial commit

Forked at: 60e3a693


Parent branch: origin/master

* Move task_manager.rs to mod.rs

* Graceful shutdown for the task manager

* Await all background task JoinHandle at the same time

* Add tests

* Make future() wait also for exit signal + fix essential task failed

Probably related to https://github.com/paritytech/cumulus/issues/111

* add comments for non-obvious code

* Use clean_shutdown() in sc-cli

* Adapt code and upgrade tokio in sc-cli

* cleanup spacing in doc

* Add license

* I guess actually running the clean shutdown would be a good idea

* fix tests

* Update client/cli/src/runner.rs

Co-authored-by: default avatarBenjamin Kampmann <[email protected]>

* Improve error logging

* disable other tests (can't reproduce on my machine)

* Revert "disable other tests (can't reproduce on my machine)"

This reverts commit c133c590.

* It is possible that the tasks are ended first

* Revert "It is possible that the tasks are ended first"

This reverts commit 502aba4a.

* Use single threaded scheduler for more predictability

* enable_time

* Revert "enable_time"

This reverts commit 4e152140.

* Revert "Use single threaded scheduler for more predictability"

This reverts commit ee5e13c5.

* Revert "Revert "It is possible that the tasks are ended first""

This reverts commit 1b91a8ca

.

* This cannot be verified either with a threaded pool

* Apply suggestions from code review

Co-authored-by: default avatarBastian Köcher <[email protected]>

Co-authored-by: default avatarBenjamin Kampmann <[email protected]>
Co-authored-by: default avatarBenjamin Kampmann <[email protected]>
Co-authored-by: default avatarBastian Köcher <[email protected]>
      64d4a4da
  29. Jul 21, 2020
  31. Jul 20, 2020
  33. Jul 19, 2020
  35. Jul 17, 2020
  37. Jul 15, 2020
  39. Jul 14, 2020
  41. Jul 10, 2020
  43. Jul 09, 2020