Skip to content
  1. Jul 22, 2020
    • Cecile Tonglet's avatar
      Graceful shutdown for the task manager (#6654) · 64d4a4da
      Cecile Tonglet authored 
      * Initial commit

Forked at: 60e3a693


Parent branch: origin/master

* Move task_manager.rs to mod.rs

* Graceful shutdown for the task manager

* Await all background task JoinHandle at the same time

* Add tests

* Make future() wait also for exit signal + fix essential task failed

Probably related to https://github.com/paritytech/cumulus/issues/111

* add comments for non-obvious code

* Use clean_shutdown() in sc-cli

* Adapt code and upgrade tokio in sc-cli

* cleanup spacing in doc

* Add license

* I guess actually running the clean shutdown would be a good idea

* fix tests

* Update client/cli/src/runner.rs

Co-authored-by: default avatarBenjamin Kampmann <[email protected]>

* Improve error logging

* disable other tests (can't reproduce on my machine)

* Revert "disable other tests (can't reproduce on my machine)"

This reverts commit c133c590.

* It is possible that the tasks are ended first

* Revert "It is possible that the tasks are ended first"

This reverts commit 502aba4a.

* Use single threaded scheduler for more predictability

* enable_time

* Revert "enable_time"

This reverts commit 4e152140.

* Revert "Use single threaded scheduler for more predictability"

This reverts commit ee5e13c5.

* Revert "Revert "It is possible that the tasks are ended first""

This reverts commit 1b91a8ca

.

* This cannot be verified either with a threaded pool

* Apply suggestions from code review

Co-authored-by: default avatarBastian Köcher <[email protected]>

Co-authored-by: default avatarBenjamin Kampmann <[email protected]>
Co-authored-by: default avatarBenjamin Kampmann <[email protected]>
Co-authored-by: default avatarBastian Köcher <[email protected]>
      64d4a4da
  3. Jul 21, 2020
  5. Jul 19, 2020
  7. Jul 17, 2020
  9. Jul 16, 2020
  11. Jul 15, 2020
  13. Jul 14, 2020
  15. Jul 13, 2020
    • Bastian Köcher's avatar
      Check that `serde` is present in `sc-chain-spec-derive` (#6636) · 60e3a693
      Bastian Köcher authored 
      We should check that `serde` is present when using
`sc-chains-spec-derive`, because we require this for the generated
struct. This also switches the generated `derive` instruction to import
`Serialize`/`Deserialize` by path to not require the user to import
these derive macros.
      60e3a693
  17. Jul 10, 2020
  19. Jul 09, 2020
  21. Jul 08, 2020
    • Bastian Köcher's avatar
      Improve transaction submission (#6599) · d076f470
      Bastian Köcher authored 
      * Improve transaction submission

Before this pr the transaction pool validated each transaction, even if
the transaction was already known to the pool. This pr changes the
behavior to first check if we are already aware of a transaction and
thus, to only validate them if we don't know them yet. However, there is
still the possibility that a given transaction is validated multiple
times. This can happen if the transaction is added the first time, but
is not yet validated and added to the validated pool.

Besides that, this pr fixes the wrong metrics of gossiped transactions
in the network. It also moves some metrics to the transaction pool api,
to better track when a transaction actually is scheduled for validation.

* Make sure we don't submit the same transaction twice from the network concurrently

* Remove added listener call

* Feedback

* Ignore banned on resubmit
      d076f470
    • Max Inden's avatar
      *: Update to libp2p v0.21.1 (#6559) · 59ee76a0
      Max Inden authored 
      

* *Cargo.toml: Update versions

* client/network/src/discovery: Adjust to Kademlia  API changes

* client/network: Adjust to one_shot.rs changes

* client/network/discovery: Log address list on trace level

* client/network/discovery: Ignore RoutablePeer and PendingRoutablePeer

* Commit Cargo.lock

* Finish update

Co-authored-by: default avatarPierre Krieger <[email protected]>
      59ee76a0
    • Pierre Krieger's avatar
      Send Status message on all newly-opened legacy substreams (#6593) · 83b06a29
      Pierre Krieger authored 
      * Send Status message on all newly-opened legacy substreams

* Fix tests
      83b06a29
    • pscott's avatar
      Add log rotation (#6564) · 802a0d0b
      pscott authored 
      

* Use flexi_logger; Add log rotation

* Add default rotation; Add FlexiLogger error

* Fix compilation error

* Remove logging to stdout if it's not a tty

* Fix formatting

Co-authored-by: default avatarKian Paimani <[email protected]>

* Remove needless debug statement

* Default to unlimited size for log rotation

* Add more comments about log-age option

* Remove unused variable

* Fix typo in comment

Co-authored-by: default avatarKian Paimani <[email protected]>
      802a0d0b
    • Max Inden's avatar
      client/network: Rename DebugInfoBehaviour to PeerInfoBehaviour (#6556) · 1aef0435
      Max Inden authored 
      Information retrieved via `DebugInfoBehaviour` is not only used for
debugging purposes, e.g. disconnecting from nodes not responding to
pings, using external addresses retrieved via indentify, ...

In order for the name to reflect the usage of the module this commit
renames it.
      1aef0435
    • Bastian Köcher's avatar
      Upgrade `kvdb-*`, `trie-db` and `memory-db` (#6584) · 660ca271
      Bastian Köcher authored 
      

* Upgrade `kvdb-*`, `trie-db` and `memory-db`

The updates of `trie-db` and `memory-db` are important, as they fix the
non-deterministic build of Polkadot/Substrate.

* Change `trie-db` version

* Update test-utils/runtime/Cargo.toml

Co-authored-by: default avatarAndronik Ordian <[email protected]>

* Update primitives/trie/Cargo.toml

Co-authored-by: default avatarAndronik Ordian <[email protected]>

* Update `Cargo.lock` and `trie-bench`

* Fix UI tests

* Switch to fixed version of memory-db

Co-authored-by: default avatarAndronik Ordian <[email protected]>
      660ca271
  23. Jul 07, 2020
  25. Jul 04, 2020
    • André Silva's avatar
      babe: report equivocations (#6362) · 18334ee1
      André Silva authored 
      * slots: create primitives crate for consensus slots

* offences: add method to check if an offence is unknown

* babe: initial equivocation reporting implementation

* babe: organize imports

* babe: working equivocation reporting

* babe: add slot number to equivocation proof

* session: move duplicate traits to session primitives

* babe: move equivocation stuff to its own file

* offences: fix test

* session: don't have primitives depend on frame_support

* babe: use opaque type for key owner proof

* babe: cleanup client equivocation reporting

* babe: cleanup equivocation code in pallet

* babe: allow sending signed equivocation reports

* node: fix compilation

* fix test compilation

* babe: return bool on check_equivocation_proof

* babe: add test for equivocation reporting

* babe: add more tests

* babe: add test for validate unsigned

* babe: take slot number in generate_key_ownership_proof API

* babe: add benchmark for equivocation proof checking

* session: add benchmark for membership proof checking

* offences: fix babe benchmark

* babe: add weights based on benchmark results

* babe: adjust weights after benchmarking on reference hardware

* babe: reorder checks in check_and_report_equivocation
      18334ee1
  27. Jul 03, 2020
  29. Jul 02, 2020
  31. Jul 01, 2020
    • cheme's avatar
      Restrict `Protected` to some heap types. (#6471) · 8ef1ac0e
      cheme authored 
      * Restrict `Protected` to some heap types.

* Comment abut Protected usage.

* Remove Protected from crypto, use secrecy crate for existing uses.

* use a parse function

* fix error convert

* Rename and move secretY string function.

* std result
      8ef1ac0e
    • David's avatar
      Fix mocking multiple http calls in the same function call (#6510) · d855a5e9
      David authored 
      

* Fix mocking multiple http calls in the same function call

Fixes an issue where a function call would perform more than one http request and wait for each to complete before proceeding. The `RequestId` comes from the length of the `requests` collection in the `OffchainState` and if a request is completed before the next one starts it will be removed and the "next expected" will be off by one. This PR tries to fix that by using a request counter that tracks how many requests have been performed so that we can `remove()` items from the `expected_requests` at the right index.

I suspect that this is a sub-optimal soluton and perhaps requests and their mocks should live side by side in the same collection, e.g. in a tuple of `(PendingRequest, Option<ExpectedRequest>)`.

* Update primitives/core/src/offchain/testing.rs

Co-authored-by: default avatarBernhard Schuster <[email protected]>

* Update primitives/core/src/offchain/testing.rs

Co-authored-by: default avatarBernhard Schuster <[email protected]>

* Panic on overflow

* Update primitives/core/src/offchain/testing.rs

Co-authored-by: default avatarBastian Köcher <[email protected]>

* Use a Deque and push/pop expected requests

* fix test

Co-authored-by: default avatarBernhard Schuster <[email protected]>
Co-authored-by: default avatarBastian Köcher <[email protected]>
      d855a5e9
  33. Jun 30, 2020
    • André Silva's avatar
      grandpa: minor cleanups in communication module (#6371) · 996a86ca
      André Silva authored 
      * grandpa: replace Result<(), ()> with Option<()>

* grandpa: replace &Option<T> with Option<&T>

* grandpa: cleanup local id and keystore usages

* grandpa: return bool on check_message_signature

* grandpa: fix erroneous log message on startup

* grandpa: fix test
      996a86ca