Skip to content
Snippets Groups Projects
  • Frank Bell's avatar
    fix(chain-spec): adjust hrmp channels json structure (#244) · b1aac0ea
    Frank Bell authored
    When testing `zombienet-sdk` with cross-chain calls with Asset Hub, we
    found that the hrmp channels passed to the chainspec caused the
    following issue:
    
    `Error: "Invalid JSON blob: invalid type: map, expected a tuple of size
    4 at line 1 column 2794"`
    
    This is because the values of `HrmpChannelConfig` serialise to a map
    instead of a tuple, as expected by
    https://github.com/paritytech/polkadot-sdk/blob/fc906d5d0fb7796ef54ba670101cf37b0aad6794/polkadot/runtime/parachains/src/hrmp.rs#L492.
    Tests were updated accordingly to facilitate this fix.
    
    Additional commits were also added to enable some of Asset Hub on
    Polkadot functionality observed in the classic Zombienet repo, so that
    we are able to launch a local Polkadot network with Asset Hub should
    anyone require. Example configuration files can be found at the bottom
    of https://github.com/r0gue-io/pop-cli/pull/278/files for anyone
    interested, although that PR is still a work in progress and dependent
    on this one being accepted.
    
    PS - I added tests where I could, but additional tests might require
    some minor refactoring to make it easier to test only the logic that is
    changed by this PR, which I am not sure what the appetite is? An example
    would be refactoring the file name generation in `keystore.rs` into its
    own function to more easily test the outputs without the `scoped_fs`.
    Unverified
    b1aac0ea
Code owners
Assign users and groups as approvers for specific file changes. Learn more.
spawner.rs 8.48 KiB