Skip to content
Snippets Groups Projects
  1. Mar 14, 2025
  2. Mar 13, 2025
    • tmpolaczyk's avatar
      Remove clones from block seal function (#7917) · 363bd6bd
      tmpolaczyk authored
      Shouldn't matter much, but this is run on every produced block so free
      performance
      363bd6bd
    • PG Herveou's avatar
      [pallet-revive] precompiles 2->9 (#7810) · 4c74a109
      PG Herveou authored
      
      Add missing pre-compiles 02 -> 09
      
      [weights
      changes](https://weights.tasty.limo/compare?repo=polkadot-sdk&threshold=10&path_pattern=substrate%2Fframe%2F**%2Fsrc%2Fweights.rs%2Cpolkadot%2Fruntime%2F*%2Fsrc%2Fweights%2F**%2F*.rs%2Cpolkadot%2Fbridges%2Fmodules%2F*%2Fsrc%2Fweights.rs%2Ccumulus%2F**%2Fweights%2F*.rs%2Ccumulus%2F**%2Fweights%2Fxcm%2F*.rs%2Ccumulus%2F**%2Fsrc%2Fweights.rs&method=asymptotic&ignore_errors=true&unit=time&old=master&new=pg%2Fprecompiles02_09&pallet=revive)
      
      ---------
      
      Co-authored-by: default avatarcmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
      4c74a109
    • Francisco Aguirre's avatar
      Use non-native token to benchmark xcm on asset hub (#7893) · c4b8ec12
      Francisco Aguirre authored
      
      Asset Hub was using the native token for benchmarking xcm instructions.
      This is not the best since it's cheaper than using something in
      `pallet-assets` for example.
      Had to remove some restrictive checks from `pallet-xcm-benchmarks`.
      
      I'll bring back the checks with a better framework in the future that
      allows for handling multiple assets (`fungibles::*` traits).
      
      ---------
      
      Co-authored-by: default avatarcmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
      c4b8ec12
    • Javier Viola's avatar
      [CI] bump timeout wait for build in zombienet workflows. (#7871) · 425d6188
      Javier Viola authored
      
      Set timeout to 60mins. Prevent failures like this one
      https://github.com/paritytech/polkadot-sdk/actions/runs/13651327605/job/38160444244?pr=7790
      
      
      Thanks!
      
      ---------
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      425d6188
    • Iulian Barbu's avatar
      taplo: split long array line to multiline array (#7905) · d4155b6c
      Iulian Barbu authored
      
      # Description
      
      It is difficult to spot changes to umbrella features when reviewing,
      when defined on a long line, so made sure tomls formatting will be
      applied to long array lines by splitting them on multiple lines. This
      will be applied to any tomls in the monorepo that is not excluded from
      taplo.
      
      ## Integration
      
      N/A
      
      ## Review Notes
      
      Set global taplo config `array_auto_expand` to true.
      
      ---------
      
      Signed-off-by: default avatarIulian Barbu <iulian.barbu@parity.io>
      d4155b6c
    • PG Herveou's avatar
      [pallet-revive] fixture as dev dep (#7844) · 8265c65f
      PG Herveou authored
      
      Update pallet-revive-fixtures so that it can build without looking up
      dependencies from the workspace
      
      ---------
      
      Co-authored-by: default avatarcmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
      8265c65f
    • Alexandru Vasile's avatar
      notifications/libp2p: Punish notification protocol misbehavior on outbound substreams (#7781) · aa67d2ae
      Alexandru Vasile authored
      
      This PR punishes behaviors that deviate from the notification spec. When
      a peer misbehaves by writing data on an unidirectional read stream, the
      peer is banned and disconnected immediately.
      
      In this PR:
      - The `NotificationOutError` is enriched with termination reason and
      made publically available for higher levels
      - The protocol misbehavior is propagated through the `CloseDesired`
      events
      - The network behavior of the protocol is responsible for banning the
      peer.
      - The peer is banned immediately and, as a result, the reputation system
      disconnects the malicious / misbehaving peer
      - Logs are enriched with protocol names
      
      Closes: https://github.com/paritytech/polkadot-sdk/issues/7722
      
      
      cc @paritytech/networking
      
      ---------
      
      Signed-off-by: default avatarAlexandru Vasile <alexandru.vasile@parity.io>
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      aa67d2ae
    • Egor_P's avatar
    • Matteo Muraca's avatar
      Remove `pallet::getter` usage from bridges/modules (#7120) · 66e3196a
      Matteo Muraca authored
      
      # Description
      
      Part of #3326 
      
      As per title, the `pallet:getter` usage has been removed from:
      - `pallet-bridge-beefy`
      - `pallet-bridge-grandpa`
      - `pallet-bridge-messages`
      - `pallet-bridge-relayers`
      - `pallet-xcm-bridge-hub-router`
      
      
      polkadot address: 12poSUQPtcF1HUPQGY3zZu2P8emuW9YnsPduA4XG3oCEfJVp
      
      ---------
      
      Co-authored-by: default avatarBranislav Kontur <bkontur@gmail.com>
      Co-authored-by: default avatarcmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
      66e3196a
    • PG Herveou's avatar
      [pallet-revive] Support blocktag in eth_getLogs RPC (#7879) · ab7c6080
      PG Herveou authored
      
      Support "latest" blocktag in ethGetLogs from_block and to_block
      parameters
      This is not in specs
      (https://github.com/ethereum/execution-apis/blob/main/src/schemas/filter.yaml#L17)
      
      but defined and used by 3rd parties and in some other reference docs 
      
      See 
      
      https://docs.metamask.io/services/reference/ethereum/json-rpc-methods/eth_getlogs/
      
      ---------
      
      Co-authored-by: default avatarcmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
      ab7c6080
    • thiolliere's avatar
      Improve error message in benchmark macro (#7873) · a71a701c
      thiolliere authored
      
      giving the wrong origin in `extrinsic_call` would result in:
      ```
         |
      43 | #[benchmarks]
         | ^^^^^^^^^^^^^
         | |
         | expected associated type, found `Result<RawOrigin<...>, ...>`
         | arguments to this function are incorrect
         |
         = note: expected associated type `<T as frame_system::Config>::RuntimeOrigin`
                               found enum `Result<RawOrigin<<T as frame_system::Config>::AccountId>, <T as frame_system::Config>::RuntimeOrigin>`
      note: method defined here
        --> $WORKSPACE/substrate/frame/support/src/traits/dispatch.rs
         |
         |     fn dispatch_bypass_filter(self, origin: Self::RuntimeOrigin) -> DispatchResultWithPostInfo;
         |        ^^^^^^^^^^^^^^^^^^^^^^
         = note: this error originates in the attribute macro `benchmarks` (in Nightly builds, run with -Z macro-backtrace for more info)
      ```
      
      Now it results in an error message with good span.
      
      ---------
      
      Co-authored-by: default avatarcmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
      a71a701c
    • ordian's avatar
      staking: add `manual_slash` extrinsic (#7805) · f8c90b2a
      ordian authored
      This PR adds a convenience extrinsic `manual_slash` for the governance
      to slash a validator manually.
      
      ## Changes
      
      * The `on_offence` implementation for the Staking pallet accepts a slice
      of `OffenceDetails` including the full validator exposure, however, it
      simply
      [ignores](https://github.com/paritytech/polkadot-sdk/blob/c8d33396
      
      /substrate/frame/staking/src/pallet/impls.rs#L1864)
      that part. I've extracted the functionality into an inherent
      `on_offence` method that takes `OffenceDetails` without the full
      exposure and this is called directly in `manual_slash`
      * `manual_slash` creates an offence for a validator with a given slash
      percentange
      
      ## Questions
      
      - [x] should `manual_slash` accept session instead of an era when the
      validator was in the active set? staking thinks in terms of eras and we
      can check out of bounds this way, which is why it was chosen for this
      implementation, but if there are arguments against, happy to change to
      session index
      - [X] should the accepted origin be something more than just root?
      Changed to `T::AdminOrigin` to align with `cancel_deferred_slash`
      - [X] should I adapt this PR also against
      https://github.com/paritytech/polkadot-sdk/pull/6996? looking at the
      changes, it should apply mostly without conflicts
      
      ---------
      
      Co-authored-by: default avatarTsvetomir Dimitrov <tsvetomir@parity.io>
      Co-authored-by: default avatarAnkan <10196091+Ank4n@users.noreply.github.com>
      f8c90b2a
  3. Mar 12, 2025
  4. Mar 11, 2025
    • Alexandru Vasile's avatar
      network: Make litep2p the default backend in Kusama (#7866) · bcc272a1
      Alexandru Vasile authored
      This PR makes the litep2p backend the default network backend in Kusama.
      
      We performed a gradual rollout in Kusama by asking validators to
      manually switch to litep2p. The rollout went smoothly, with 250
      validators running litep2p without issues. This PR represents the next
      step in testing the backend at scale.
      
      Thanks to everyone who contributed to making this happen! A special
      shoutout to the validators for their prompt support and cooperation :pray:
      
      
      
      While at it, the litep2p release is bumped to the latest 0.9.2, which
      downgrades a spamming log to debug.
      
      
      ### CLI Testing Done
      
      
      ```
      ### Kusama without network backend specified
      RUST_LOG=info ./target/release/polkadot --chain kusama --pruning=1000 --in-peers 50 --out-peers 50 --sync=warp --detailed-log-output
      2025-03-10 14:24:18.503  INFO main sub-libp2p: Running litep2p network backend
      
      ### Kusama with libp2p
      RUST_LOG=info ./target/release/polkadot --chain kusama --pruning=1000 --in-peers 50 --out-peers 50 --sync=warp --detailed-log-output --network-backend libp2p
      INFO main sub-libp2p: Running libp2p network backend
      
      ### Kusama with litep2p
      RUST_LOG=info ./target/release/polkadot --chain kusama --pruning=1000 --in-peers 50 --out-peers 50 --sync=warp --detailed-log-output --network-backend litep2p
      INFO main sub-libp2p: Running litep2p network backend
      
      ### Polkadot without network backend specified
      RUST_LOG=info ./target/release/polkadot --chain polkadot --pruning=1000 --in-peers 50 --out-peers 50 --sync=warp --detailed-log-output
      2025-03-10 14:27:03.762  INFO main sub-libp2p: Running libp2p network backend 
      
       ```
      
      cc @paritytech/networking
      
      ---------
      
      Signed-off-by: default avatarAlexandru Vasile <alexandru.vasile@parity.io>
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      bcc272a1
    • Egor_P's avatar
      [Release|CI/CD] Fixes for the promote rc to final flow (#7877) · 544fefac
      Egor_P authored
      This PR contains few fixes for the Promote RC to final flow:
      - Now the `polkadot-preapre-worker` and `polkadot-execute-worker`
      artefacts will be uploaded alongside with the `polakdot` artefact (it
      was missing before)
      - Added missing upload of the deb package 
      - Few typos fixed
      
      Closes: https://github.com/paritytech/release-engineering/issues/241
      544fefac
    • Egor_P's avatar
    • PG Herveou's avatar
      [pallet-revive] Add support for eip1898 block notation (#7848) · fb98291e
      PG Herveou authored
      
      [pallet-revive] Add support for eip1898 block notation
      https://eips.ethereum.org/EIPS/eip-1898
      
      ---------
      
      Co-authored-by: default avatarcmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
      fb98291e
    • Serban Iorga's avatar
      Fix XCM decoding inconsistencies (#7856) · 2a239206
      Serban Iorga authored
      This PR includes:
      
      - deduplicating some XCM decoding logic
      - making use of `decode_with_depth_limit` consistently for
      `VersionedXcm`
      - some cleanup
      2a239206
    • Sebastian Kunert's avatar
      slot-based-collator: Allow multiple blocks per slot (#7569) · 8ddb0714
      Sebastian Kunert authored
      **Summary:** This PR enables authoring of multiple blocks in one AURA
      slot in the slot-based collator and stabilizes the slot-based collator.
      
      ## CLI Changes
      The flag `--experimental-use-slot-based` is now marked as deprecated. I
      opted to introduce `--authoring slot-based` instead of just removing the
      `experimental` prefix. By introducing the `authoring` variant, we get
      some future-proofing in case we want to introduce further options.
      
      ## Change Description
      With elastic-scaling, we are able to author multiple blocks with a
      single relay-chain parent. In the initial iteration, the interval
      between two blocks was determined by the `slot_duration` of the
      parachain. This PR introduces a more flexible model, where we try to
      author multiple blocks in a single slot if the runtime allows it.
      
      The block authoring loop is largely the same. The
      [`SlotTimer`](https://github.com/paritytech/polkadot-sdk/blob/f1935bd9/cumulus/client/consensus/aura/src/collators/slot_based/slot_timer.rs#L48-L48)
      now lives in a separate module and is updated with the last seen [core
      count](https://github.com/paritytech/polkadot-sdk/blob/f1935bd9
      
      /cumulus/client/consensus/aura/src/collators/slot_based/block_builder_task.rs#L231-L231).
      It will then trigger rounds in the block-building loop based on the core
      count.
      
      This allows some flexibility where elastic-scaling chains can run on a
      single core in quiet times. Previously, running on 1 core with a 3-core
      elastic-scaling chain would result in authors getting skipped because
      the `slot_duration` was too low.
      
      ## Parameter Considerations
      The core logic does not change, so there are a few things to consider:
      - The `ConsensusHook` implementation still determines how many blocks
      are allowed per relay-chain block. So if you add arbitrary cores to an
      async-backing, 6-second parachain, `can_build_upon` in the runtime will
      deny block-building of additional blocks.
      - The `MINIMUM_PERIOD` in the runtime needs to be configured to allow
      enough blocks in the slot. A "classic" configuration of
      `SLOT_DURATION/2` will lead to slot mismatches when running with 3
      cores.
      - We fetch available cores at least once every relay chain block. So if
      a parachain runs with a 12-second slot duration and 1 fixed core, we
      would still author 2 blocks if the parachain runtime allows it.
      
      ---------
      
      Co-authored-by: default avatarcmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
      Co-authored-by: default avatarMichal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
      Co-authored-by: default avatarJavier Viola <javier@parity.io>
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      8ddb0714
  5. Mar 10, 2025
  6. Mar 07, 2025
  7. Mar 06, 2025
    • thiolliere's avatar
      Improve metadata for `SkipCheckIfFeeless` (#7813) · 9dbcc0e4
      thiolliere authored
      
      If the inner transaction extension used inside `SkipCheckIfFeeless` are
      multiples then the metadata is not correct, it is now fixed.
      
      E.g. if the transaction extension is `SkipCheckIfFeeless::<Runtime,
      (Payment1, Payment2)>` then the metadata was wrong.
      
      ---------
      
      Co-authored-by: default avatarcmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      9dbcc0e4
    • Utkarsh Bhardwaj's avatar
      add poke_deposit extrinsic to pallet-proxy (#7801) · 4f7a9388
      Utkarsh Bhardwaj authored
      
      # Description
      
      * This PR adds a new extrinsic `poke_deposit` to `pallet-proxy`. This
      extrinsic will be used to re-adjust the deposits made in the pallet to
      create a proxy or to create an announcement.
      * Part of #5591 
      
      ## Review Notes
      
      * Added a new extrinsic `poke_deposit` in `pallet-proxy`.
      * This extrinsic checks and adjusts the deposits made for either
      creating a proxy or creating an announcement or both.
      * Added a new event `DepositPoked` to be emitted upon a successful call
      of the extrinsic.
      * Although the immediate use of the extrinsic will be to give back some
      of the deposit after the AH-migration, the extrinsic is written such
      that it can work if the deposit decreases or increases (both).
      * The call to the extrinsic would be `free` if an actual adjustment is
      made to the deposit for creating a proxy or to the deposit for creating
      an announcement or both and `paid` otherwise (when no deposit is
      changed).
      * Added a new enum `DepositKind` to differentiate between proxy deposit
      adjusted and announcement deposit adjusted when emitting events.
      * Added tests to test all scenarios.
      
      ## TO-DOs
      * [ ] Run CI cmd bot to benchmark
      
      ---------
      
      Co-authored-by: default avatarcmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
      4f7a9388
    • Alexander Samusev's avatar
      cmd-bot: divide workflow into 2 steps (#7711) · 312b5b40
      Alexander Samusev authored
      More details
      [here](https://github.com/paritytech/security/issues/103#issuecomment-2682362253)
      
      cc https://github.com/paritytech/security/issues/103
      312b5b40