Skip to content
  1. Aug 29, 2022
    • Mara Broda's avatar
      version bumps (0.9.28) (#5933) · fc97080c
      Mara Broda authored 
      * Bump crate versions

* Bump spec_version to 9280 for kusama

* Bump spec_version to 9280 for polkadot

* Bump spec_version to 9280 for rococo

* Bump spec_version to 9280 for westend

* update Cargo.lock

Co-authored-by: parity-processbot <>
      fc97080c
  3. Aug 24, 2022
  5. Aug 16, 2022
    • Robert Klotzner's avatar
      Break cycle collator-procol - backing (#5883) · 16a35652
      Robert Klotzner authored
      16a35652
    • Robert Klotzner's avatar
      Don't request votes if there is nothing to request. (#5888) · 05a79665
      Robert Klotzner authored 
      * Don't request votes if there is nothing to request.

* Add trace log
      05a79665
    • Robert Klotzner's avatar
      Reduce dispute coordinator load (#5785) · ca6297c8
      Robert Klotzner authored 
      * Don't import backing statements directly

into the dispute coordinator. This also gets rid of a redundant
signature check. Both should have some impact on backing performance.
In general this PR should make us scale better in the number of parachains.

Reasoning (aka why this is fine):

For the signature check: As mentioned, it is a redundant check. The
signature has already been checked at this point. This is even made
obvious by the used types. The smart constructor is not perfect as
discussed [here](https://github.com/paritytech/polkadot/issues/3455

),
but is still a reasonable security.

For not importing to the dispute-coordinator: This should be good as the
dispute coordinator does scrape backing votes from chain. This suffices
in practice as a super majority of validators must have seen a backing
fork in order for a candidate to get included and only included
candidates pose a threat to our system. The import from chain is
preferable over direct import of backing votes for two reasons:

1. The import is batched, greatly improving import performance. All
   backing votes for a candidate are imported with a single import.
   And indeed we were able to see in metrics that importing votes
   from chain is fast.
2. We do less work in general as not every candidate for which
   statements are gossiped might actually make it on a chain. The
   dispute coordinator as with the current implementation would still
   import and keep those votes around for six sessions.

While redundancy is good for reliability in the event of bugs, this also
comes at a non negligible cost. The dispute-coordinator right now is the
subsystem with the highest load, despite the fact that it should not be
doing much during mormal operation and it is only getting worse
with more parachains as the load is a direct function of the number of statements.

We'll see on Versi how much of a performance improvement this PR

* Get rid of dead code.

* Dont send approval vote

* Make it pass CI

* Bring back tests for fixing them later.

* Explicit signature check.

* Resurrect approval-voting tests (not fixed yet)

* Send out approval votes in dispute-distribution.

Use BTreeMap for ordered dispute votes.

* Bring back an important warning.

* Fix approval voting tests.

* Don't send out dispute message on import + test

+ Some cleanup.

* Guide changes.

Note that the introduced complexity is actually redundant.

* WIP: guide changes.

* Finish guide changes about dispute-coordinator

conceputally. Requires more proof read still.

Also removed obsolete implementation details, where the code is better
suited as the source of truth.

* Finish guide changes for now.

* Remove own approval vote import logic.

* Implement logic for retrieving approval-votes

into approval-voting and approval-distribution subsystems.

* Update roadmap/implementers-guide/src/node/disputes/dispute-coordinator.md

Co-authored-by: default avatarasynchronous rob <[email protected]>

* Review feedback.

In particular: Add note about disputes of non included candidates.

* Incorporate Review Remarks

* Get rid of superfluous space.

* Tidy up import logic a bit.

Logical vote import is now separated, making the code more readable and
maintainable.

Also: Accept import if there is at least one invalid signer that has not
exceeded its spam slots, instead of requiring all of them to not exceed
their limits. This is more correct and a preparation for vote batching.

* We don't need/have empty imports.

* Fix tests and bugs.

* Remove error prone redundancy.

* Import approval votes on dispute initiated/concluded.

* Add test for approval vote import.

* Make guide checker happy (hopefully)

* Another sanity check + better logs.

* Reasoning about boundedness.

* Use `CandidateIndex` as opposed to `CoreIndex`.

* Remove redundant import.

* Review remarks.

* Add metric for calls to request signatures

* More review remarks.

* Add metric on imported approval votes.

* Include candidate hash in logs.

* More trace log

* Break cycle.

* Add some tracing.

* Cleanup allowed messages.

* fmt

* Tracing + timeout for get inherent data.

* Better error.

* Break cycle in all places.

* Clarified comment some more.

* Typo.

* Break cycle approval-distribution - approval-voting.

Co-authored-by: default avatarasynchronous rob <[email protected]>
      ca6297c8
  7. Aug 09, 2022
  9. Jul 28, 2022
  11. Jul 20, 2022
    • Sebastian Kunert's avatar
      Introduce async runtime calling trait for runtime-api subsystem (#5782) · 72bde288
      Sebastian Kunert authored 
      

* Implement OverseerRuntimeClient

* blockchainevents

* Update patches

* Finish merging rntime-api subsystem

* First version that is able to produce blocks

* Make OverseerRuntimeClient async

* Move overseer notification stream forwarding to cumulus

* Remove unused imports

* Add more logging to collator-protocol

* Lockfile

* Use hashes in OverseerRuntimeClient

* Move OverseerRuntimeClient into extra module

* Fix old session info call and make HeadSupportsParachain async

* Improve naming of trait

* Cleanup

* Remove unused From trait implementation

* Remove unwanted debug print

* Move trait to polkadot-node-subsystem-types

* Add sections to runtime client

Co-authored-by: default avatarDavide Galassi <[email protected]>

* Reorder methods

* Fix spelling

* Fix spacing in Cargo.toml

Co-authored-by: default avatarBastian Köcher <[email protected]>

* Remove unused babe methods

Co-authored-by: default avatarDavide Galassi <[email protected]>
Co-authored-by: default avatarBastian Köcher <[email protected]>
      72bde288
  13. Jul 09, 2022
    • Vsevolod Stakhov's avatar
      Implement prune only stagnant check mode (#5761) · c11c1f38
      Vsevolod Stakhov authored 
      

* Limit number of elements loaded from the stagnant key

This will likely be required if we enable stagnant prunning as currently database has way
too many entries to be prunned in a single iteration

* Fmt run

* Slightly improve logging

* Some more debug nits

* Fmt pass

* Add stagnant prunning delay

* Enable stagnant check worker

* Implement stagnant pruning without stagnant checks

* Update node/core/chain-selection/src/tree.rs

Co-authored-by: default avatarAndronik <[email protected]>

* Apply suggestions from code review

Co-authored-by: default avatarAndronik <[email protected]>

Co-authored-by: default avatarAndronik <[email protected]>
      c11c1f38
  15. Jul 06, 2022
  17. Jul 04, 2022
    • Vsevolod Stakhov's avatar
      Limit stagnant checks to a certain amount of entries (#5742) · 9dc99f02
      Vsevolod Stakhov authored 
      * Limit number of elements loaded from the stagnant key

This will likely be required if we enable stagnant prunning as currently database has way
too many entries to be prunned in a single iteration

* Fmt run

* Slightly improve logging

* Some more debug nits

* Fmt pass
      9dc99f02
  19. Jun 27, 2022
  21. Jun 24, 2022
  23. Jun 23, 2022
  25. Jun 21, 2022
    • Mara Broda's avatar
      bump versions to 0.9.25 (#5684) · 97f9b840
      Mara Broda authored 
      * kusama: bump spec_version to 9250

* polkadot: bump spec_version to 9250

* rococo: bump spec_version to 9250

* westend: bump spec_version to 9250

* bump version to 0.9.25

* bump transaction version (polkadot & kusama) (#5690)

* kusama: bump transaction_version to 12

* polkadot: bump transaction_version to 13
      97f9b840
  27. Jun 16, 2022
  29. Jun 14, 2022
  31. Jun 13, 2022
  33. May 30, 2022
    • Robert Klotzner's avatar
      Request backed candidates unbounded. (#5610) · 72723c8a
      Robert Klotzner authored 
      We are awaiting on the oneshot anyways, so we have back pressure. By
using the unbounded channel make log messages like the following less
likely (due to higher priority):

	2022-05-30 13:46:38
2022-05-30 11:46:38.565  WARN tokio-runtime-worker parachain::provisioner: failed to assemble or send inherent data err=CanceledBackedCandidates(Canceled)
      72723c8a
    • Gavin Wood's avatar
      Companion to Substrate #11490 (#5603) · 026848c9
      Gavin Wood authored 
      * Fix warnings

* Bump
      026848c9
  35. May 27, 2022
  37. May 23, 2022
  39. May 19, 2022
  41. May 18, 2022
  43. May 16, 2022
  45. May 12, 2022
  47. May 11, 2022
    • Bernhard Schuster's avatar
      polkadot-node-subsystem package rename mish mash cleanup (#5502) · d437a33e
      Bernhard Schuster authored 
      * unify to polkadot-node-subsystem{,-test-helpers}

* chore: fmt
      d437a33e
    • Davide Galassi's avatar
      Revert approval voting (#5438) · 8837dc7e
      Davide Galassi authored 
      * Revert approval-voting subsystem

* Approval voting revert encapsulated within 'ops' module

* use 'get_stored_blocks' to get lower block height

* Fix error message

* Optionally shrink/delete stored blocks range

* range end number is last block number plus 1

* Apply code review suggestions

* Use tristate enum for block range in backend overlay

* Add clarification comment

* Add comments to private struct
      8837dc7e
  49. May 09, 2022
  51. May 08, 2022
  53. May 06, 2022
  55. May 04, 2022