Skip to content
Snippets Groups Projects
  1. Nov 04, 2024
    • s0me0ne-unkn0wn's avatar
      Silent annoying log (#6351) · f1e416a5
      s0me0ne-unkn0wn authored
      The logline in question doesn't indeed present any interest for a node
      operator (I mean, there is not much he can do about that warning), but
      in a heavy transaction load situation, when each of 5000 transactions in
      txpool produces a warning, it's really annoying. Still, it's useful for
      a developer, so I propose to log it at the `debug` level.
    • Cyrill Leutwiler's avatar
      [pallet-revive] rework balance transfers (#6187) · d69a80e6
      Cyrill Leutwiler authored
      
      This PR removes the `transfer` syscall and changes balance transfers to
      make the existential deposit (ED) fully transparent for contracts.
      
      The `transfer` API is removed since there is no corresponding EVM opcode
      and transferring via a call introduces barely any overhead.
      
      We make the ED transparent to contracts by transferring the ED from the
      call origin to nonexistent accounts. Without this change, transfers to
      nonexistant accounts will transfer the supplied value minus the ED from
      the contracts viewpoint, and consequentially fail if the supplied value
      lies below the ED. Changing this behavior removes the need for contract
      code to handle this rather annoying corner case and aligns better with
      the EVM. The EVM charges a similar deposit from the gas meter, so
      transferring the ED from the call origin is practically the same as the
      call origin pays for gas.
      
      ---------
      
      Signed-off-by: default avatarxermicus <cyrill@parity.io>
      Signed-off-by: default avatarCyrill Leutwiler <bigcyrill@hotmail.com>
      Co-authored-by: command-bot <>
      Co-authored-by: default avatarGitHub Action <action@github.com>
      Co-authored-by: default avatarPG Herveou <pgherveou@gmail.com>
    • Andrei Sandu's avatar
      `statement-distribution`: RFC103 implementation (#5883) · 38cd03c5
      Andrei Sandu authored
      
      Part of https://github.com/paritytech/polkadot-sdk/issues/5047
      On top of https://github.com/paritytech/polkadot-sdk/pull/5679
      
      ---------
      
      Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>
      Co-authored-by: default avatarGitHub Action <action@github.com>
    • Javier Viola's avatar
      Disable flaky tests reported in #6343 / #6345 (#6346) · 028e61be
      Javier Viola authored
      
      test: zombienet-polkadot-functional-0018-shared-core-idle-parachain
      Disable flaky test reported in
      https://github.com/paritytech/polkadot-sdk/issues/6343
      
      test: zombienet-polkadot-functional-0016-approval-voting-parallel
      Disable flaky test reported in
      https://github.com/paritytech/polkadot-sdk/issues/6345
      
      Co-authored-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
    • clangenb's avatar
      migrate pallet-recovery to benchmark V2 syntax (#6299) · b1084e7a
      clangenb authored
      
      Part of:
      * #6202
      
      ---------
      
      Co-authored-by: default avatarGitHub Action <action@github.com>
      Co-authored-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
    • Andrei Sandu's avatar
      inclusion emulator: correctly handle UMP signals (#6178) · b3265401
      Andrei Sandu authored
      
      Changes inclusion emulator to not count the UMP signals when checking
      ump message constraints.
      
      ---------
      
      Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>
      Co-authored-by: default avatarGitHub Action <action@github.com>
    • dependabot[bot]'s avatar
      Bump the ci_dependencies group across 1 directory with 3 updates (#6340) · 8b6f8157
      dependabot[bot] authored
      
      Bumps the ci_dependencies group with 3 updates in the / directory:
      [docker/build-push-action](https://github.com/docker/build-push-action),
      [actions/setup-node](https://github.com/actions/setup-node) and
      [lycheeverse/lychee-action](https://github.com/lycheeverse/lychee-action).
      
      Updates `docker/build-push-action` from 5 to 6
      <details>
      <summary>Release notes</summary>
      <p><em>Sourced from <a
      href="https://github.com/docker/build-push-action/releases">docker/build-push-action's
      releases</a>.</em></p>
      <blockquote>
      <h2>v6.0.0</h2>
      <ul>
      <li>Export build record and generate <a
      href="https://docs.docker.com/build/ci/github-actions/build-summary/">build
      summary</a> by <a
      href="https://github.com/crazy-max"><code>@​crazy-max</code></a> in <a
      href="https://redirect.github.com/docker/build-push-action/pull/1120">docker/build-push-action#1120</a></li>
      <li>Bump <code>@​docker/actions-toolkit</code> from 0.24.0 to 0.26.0 in
      <a
      href="https://redirect.github.com/docker/build-push-action/pull/1132">docker/build-push-action#1132</a>
      <a
      href="https://redirect.github.com/docker/build-push-action/pull/1136">docker/build-push-action#1136</a>
      <a
      href="https://redirect.github.com/docker/build-push-action/pull/1138">docker/build-push-action#1138</a></li>
      <li>Bump braces from 3.0.2 to 3.0.3 in <a
      href="https://redirect.github.com/docker/build-push-action/pull/1137">docker/build-push-action#1137</a></li>
      </ul>
      <blockquote>
      <p>[!NOTE]
      This major release adds support for generating <a
      href="https://docs.docker.com/build/ci/github-actions/build-summary/">Build
      summary</a> and exporting build record for your build. You can disable
      this feature by setting <a
      href="https://docs.docker.com/build/ci/github-actions/build-summary/#disable-job-summary">
      <code>DOCKER_BUILD_NO_SUMMARY: true</code> environment variable in your
      workflow</a>.</p>
      </blockquote>
      <p><strong>Full Changelog</strong>: <a
      href="https://github.com/docker/build-push-action/compare/v5.4.0...v6.0.0">https://github.com/docker/build-push-action/compare/v5.4.0...v6.0.0</a></p>
      <h2>v5.4.0</h2>
      <ul>
      <li>Show builder information before building by <a
      href="https://github.com/crazy-max"><code>@​crazy-max</code></a> in <a
      href="https://redirect.github.com/docker/build-push-action/pull/1128">docker/build-push-action#1128</a></li>
      <li>Handle attestations correctly with provenance and sbom inputs by <a
      href="https://github.com/crazy-max"><code>@​crazy-max</code></a> in <a
      href="https://redirect.github.com/docker/build-push-action/pull/1086">docker/build-push-action#1086</a></li>
      <li>Bump <code>@​docker/actions-toolkit</code> from 0.19.0 to 0.24.0 in
      <a
      href="https://redirect.github.com/docker/build-push-action/pull/1088">docker/build-push-action#1088</a>
      <a
      href="https://redirect.github.com/docker/build-push-action/pull/1105">docker/build-push-action#1105</a>
      <a
      href="https://redirect.github.com/docker/build-push-action/pull/1121">docker/build-push-action#1121</a>
      <a
      href="https://redirect.github.com/docker/build-push-action/pull/1127">docker/build-push-action#1127</a></li>
      <li>Bump undici from 5.28.3 to 5.28.4 in <a
      href="https://redirect.github.com/docker/build-push-action/pull/1090">docker/build-push-action#1090</a></li>
      </ul>
      <p><strong>Full Changelog</strong>: <a
      href="https://github.com/docker/build-push-action/compare/v5.3.0...v5.4.0">https://github.com/docker/build-push-action/compare/v5.3.0...v5.4.0</a></p>
      <h2>v5.3.0</h2>
      <ul>
      <li>Bump <code>@​docker/actions-toolkit</code> from 0.18.0 to 0.19.0 in
      <a
      href="https://redirect.github.com/docker/build-push-action/pull/1080">docker/build-push-action#1080</a></li>
      </ul>
      <p><strong>Full Changelog</strong>: <a
      href="https://github.com/docker/build-push-action/compare/v5.2.0...v5.3.0">https://github.com/docker/build-push-action/compare/v5.2.0...v5.3.0</a></p>
      <h2>v5.2.0</h2>
      <ul>
      <li>Disable quotes detection for <code>outputs</code> input by <a
      href="https://github.com/crazy-max"><code>@​crazy-max</code></a> in <a
      href="https://redirect.github.com/docker/build-push-action/pull/1074">docker/build-push-action#1074</a></li>
      <li>Warn about ignored inputs by <a
      href="https://github.com/favonia"><code>@​favonia</code></a> in <a
      href="https://redirect.github.com/docker/build-push-action/pull/1019">docker/build-push-action#1019</a></li>
      <li>Bump <code>@​docker/actions-toolkit</code> from 0.14.0 to 0.18.0 in
      <a
      href="https://redirect.github.com/docker/build-push-action/pull/1070">docker/build-push-action#1070</a></li>
      <li>Bump undici from 5.26.3 to 5.28.3 in <a
      href="https://redirect.github.com/docker/build-push-action/pull/1057">docker/build-push-action#1057</a></li>
      </ul>
      <p><strong>Full Changelog</strong>: <a
      href="https://github.com/docker/build-push-action/compare/v5.1.0...v5.2.0">https://github.com/docker/build-push-action/compare/v5.1.0...v5.2.0</a></p>
      <h2>v5.1.0</h2>
      <ul>
      <li>Add <code>annotations</code> input by <a
      href="https://github.com/crazy-max"><code>@​crazy-max</code></a> in <a
      href="https://redirect.github.com/docker/build-push-action/pull/992">docker/build-push-action#992</a></li>
      <li>Add <code>secret-envs</code> input by <a
      href="https://github.com/elias-lundgren"><code>@​elias-lundgren</code></a>
      in <a
      href="https://redirect.github.com/docker/build-push-action/pull/980">docker/build-push-action#980</a></li>
      <li>Bump <code>@​babel/traverse</code> from 7.17.3 to 7.23.2 in <a
      href="https://redirect.github.com/docker/build-push-action/pull/991">docker/build-push-action#991</a></li>
      <li>Bump <code>@​docker/actions-toolkit</code> from 0.13.0-rc.1 to
      0.14.0 in <a
      href="https://redirect.github.com/docker/build-push-action/pull/990">docker/build-push-action#990</a>
      <a
      href="https://redirect.github.com/docker/build-push-action/pull/1006">docker/build-push-action#1006</a></li>
      </ul>
      <p><strong>Full Changelog</strong>: <a
      href="https://github.com/docker/build-push-action/compare/v5.0.0...v5.1.0">https://github.com/docker/build-push-action/compare/v5.0.0...v5.1.0</a></p>
      </blockquote>
      </details>
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/docker/build-push-action/commit/4f58ea79222b3b9dc2c8bbdd6debcef730109a75"><code>4f58ea7</code></a>
      Merge pull request <a
      href="https://redirect.github.com/docker/build-push-action/issues/1234">#1234</a>
      from docker/dependabot/npm_and_yarn/docker/actions-t...</li>
      <li><a
      href="https://github.com/docker/build-push-action/commit/49b5ea61c60477d214908bb6e23ce05c074ef04e"><code>49b5ea6</code></a>
      chore: update generated content</li>
      <li><a
      href="https://github.com/docker/build-push-action/commit/13c9fddd72db0ce3cd9d87eb53e0480d2a32a77b"><code>13c9fdd</code></a>
      chore(deps): Bump <code>@​docker/actions-toolkit</code> from 0.38.0 to
      0.39.0</li>
      <li><a
      href="https://github.com/docker/build-push-action/commit/e44afff3590e1d4f93b6adc72376512edb012a7c"><code>e44afff</code></a>
      Merge pull request <a
      href="https://redirect.github.com/docker/build-push-action/issues/1232">#1232</a>
      from docker/dependabot/npm_and_yarn/path-to-regexp-6...</li>
      <li><a
      href="https://github.com/docker/build-push-action/commit/67ebad331f4ca45e39184b280dbacb11eb3beae0"><code>67ebad3</code></a>
      chore(deps): Bump path-to-regexp from 6.2.2 to 6.3.0</li>
      <li><a
      href="https://github.com/docker/build-push-action/commit/32945a339266b759abcbdc89316275140b0fc960"><code>32945a3</code></a>
      Merge pull request <a
      href="https://redirect.github.com/docker/build-push-action/issues/1230">#1230</a>
      from docker/dependabot/npm_and_yarn/docker/actions-t...</li>
      <li><a
      href="https://github.com/docker/build-push-action/commit/e0fe9cf0f26132beab7b62929bd647eef9e7df31"><code>e0fe9cf</code></a>
      chore: update generated content</li>
      <li><a
      href="https://github.com/docker/build-push-action/commit/8f1ff6bf9a836299c21b10f942be49efb52a832c"><code>8f1ff6b</code></a>
      chore(deps): Bump <code>@​docker/actions-toolkit</code> from 0.37.1 to
      0.38.0</li>
      <li><a
      href="https://github.com/docker/build-push-action/commit/5cd11c3a4ced054e52742c5fd54dca954e0edd85"><code>5cd11c3</code></a>
      Merge pull request <a
      href="https://redirect.github.com/docker/build-push-action/issues/1211">#1211</a>
      from crazy-max/summary-info-message</li>
      <li><a
      href="https://github.com/docker/build-push-action/commit/0aba704831628413787ada4cf0e8f04d977f1d21"><code>0aba704</code></a>
      chore: update generated content</li>
      <li>Additional commits viewable in <a
      href="https://github.com/docker/build-push-action/compare/v5...v6">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      Updates `actions/setup-node` from 4.0.4 to 4.1.0
      <details>
      <summary>Release notes</summary>
      <p><em>Sourced from <a
      href="https://github.com/actions/setup-node/releases">actions/setup-node's
      releases</a>.</em></p>
      <blockquote>
      <h2>v4.1.0</h2>
      <h2>What's Changed</h2>
      <ul>
      <li>Resolve High Security Alerts by upgrading Dependencies by <a
      href="https://github.com/aparnajyothi-y"><code>@​aparnajyothi-y</code></a>
      in <a
      href="https://redirect.github.com/actions/setup-node/pull/1132">actions/setup-node#1132</a></li>
      <li>Upgrade IA Publish by <a
      href="https://github.com/Jcambass"><code>@​Jcambass</code></a> in <a
      href="https://redirect.github.com/actions/setup-node/pull/1134">actions/setup-node#1134</a></li>
      <li>Revise <code>isGhes</code> logic by <a
      href="https://github.com/jww3"><code>@​jww3</code></a> in <a
      href="https://redirect.github.com/actions/setup-node/pull/1148">actions/setup-node#1148</a></li>
      <li>Add architecture to cache key by <a
      href="https://github.com/pengx17"><code>@​pengx17</code></a> in <a
      href="https://redirect.github.com/actions/setup-node/pull/843">actions/setup-node#843</a>
      This addresses issues with caching by adding the architecture (arch) to
      the cache key, ensuring that cache keys are accurate to prevent
      conflicts.
      Note: This change may break previous cache keys as they will no longer
      be compatible with the new format.</li>
      </ul>
      <h2>New Contributors</h2>
      <ul>
      <li><a href="https://github.com/jww3"><code>@​jww3</code></a> made their
      first contribution in <a
      href="https://redirect.github.com/actions/setup-node/pull/1148">actions/setup-node#1148</a></li>
      <li><a href="https://github.com/pengx17"><code>@​pengx17</code></a> made
      their first contribution in <a
      href="https://redirect.github.com/actions/setup-node/pull/843">actions/setup-node#843</a></li>
      </ul>
      <p><strong>Full Changelog</strong>: <a
      href="https://github.com/actions/setup-node/compare/v4...v4.1.0">https://github.com/actions/setup-node/compare/v4...v4.1.0</a></p>
      </blockquote>
      </details>
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/actions/setup-node/commit/39370e3970a6d050c480ffad4ff0ed4d3fdee5af"><code>39370e3</code></a>
      fix: add arch to cached path (<a
      href="https://redirect.github.com/actions/setup-node/issues/843">#843</a>)</li>
      <li><a
      href="https://github.com/actions/setup-node/commit/abb238b1313d8ef4d3e3a96d204e08329cafbf85"><code>abb238b</code></a>
      Revise <code>isGhes</code> logic (<a
      href="https://redirect.github.com/actions/setup-node/issues/1148">#1148</a>)</li>
      <li><a
      href="https://github.com/actions/setup-node/commit/aca7b64a59c0063db8564e0ffdadd3887f1cbae5"><code>aca7b64</code></a>
      Merge pull request <a
      href="https://redirect.github.com/actions/setup-node/issues/1134">#1134</a>
      from actions/Jcambass-patch-1</li>
      <li><a
      href="https://github.com/actions/setup-node/commit/88de2a3d99c13aa734c49200e8bc673fb0a80ab8"><code>88de2a3</code></a>
      Resolve High Security Alerts by upgrading Dependencies (<a
      href="https://redirect.github.com/actions/setup-node/issues/1132">#1132</a>)</li>
      <li><a
      href="https://github.com/actions/setup-node/commit/d6ebc7b438e9cf1b22a3c440a164b179ed0e37d6"><code>d6ebc7b</code></a>
      Upgrade IA Publish</li>
      <li>See full diff in <a
      href="https://github.com/actions/setup-node/compare/v4.0.4...v4.1.0">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      Updates `lycheeverse/lychee-action` from 2.0.1 to 2.0.2
      <details>
      <summary>Release notes</summary>
      <p><em>Sourced from <a
      href="https://github.com/lycheeverse/lychee-action/releases">lycheeverse/lychee-action's
      releases</a>.</em></p>
      <blockquote>
      <h2>Version 2.0.2</h2>
      <h2>What's Changed</h2>
      <ul>
      <li>Fix a typos by <a
      href="https://github.com/szepeviktor"><code>@​szepeviktor</code></a> in
      <a
      href="https://redirect.github.com/lycheeverse/lychee-action/pull/257">lycheeverse/lychee-action#257</a></li>
      <li>Document and use correct permissions in the GitHub workflows by <a
      href="https://github.com/dscho"><code>@​dscho</code></a> in <a
      href="https://redirect.github.com/lycheeverse/lychee-action/pull/258">lycheeverse/lychee-action#258</a></li>
      <li>Add security policy by <a
      href="https://github.com/mondeja"><code>@​mondeja</code></a> in <a
      href="https://redirect.github.com/lycheeverse/lychee-action/pull/259">lycheeverse/lychee-action#259</a></li>
      </ul>
      <h2>New Contributors</h2>
      <ul>
      <li><a
      href="https://github.com/szepeviktor"><code>@​szepeviktor</code></a>
      made their first contribution in <a
      href="https://redirect.github.com/lycheeverse/lychee-action/pull/257">lycheeverse/lychee-action#257</a></li>
      <li><a href="https://github.com/mondeja"><code>@​mondeja</code></a> made
      their first contribution in <a
      href="https://redirect.github.com/lycheeverse/lychee-action/pull/259">lycheeverse/lychee-action#259</a></li>
      </ul>
      <p><strong>Full Changelog</strong>: <a
      href="https://github.com/lycheeverse/lychee-action/compare/v2...v2.0.2">https://github.com/lycheeverse/lychee-action/compare/v2...v2.0.2</a></p>
      </blockquote>
      </details>
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/lycheeverse/lychee-action/commit/7cd0af4c74a61395d455af97419279d86aafaede"><code>7cd0af4</code></a>
      Merge commit from fork</li>
      <li><a
      href="https://github.com/lycheeverse/lychee-action/commit/8ad54d3568ac3176a9fb57a0233cf04410b55cde"><code>8ad54d3</code></a>
      fix link</li>
      <li><a
      href="https://github.com/lycheeverse/lychee-action/commit/762333c18963fc10db515e32000e2e4dbcb11f5f"><code>762333c</code></a>
      Create SECURITY.md (<a
      href="https://redirect.github.com/lycheeverse/lychee-action/issues/259">#259</a>)</li>
      <li><a
      href="https://github.com/lycheeverse/lychee-action/commit/71a38a3bd757f6306a6c14206219391d4e5807ed"><code>71a38a3</code></a>
      Document and use correct permissions in the GitHub workflows (<a
      href="https://redirect.github.com/lycheeverse/lychee-action/issues/258">#258</a>)</li>
      <li><a
      href="https://github.com/lycheeverse/lychee-action/commit/f141760066406690a7f54a23762e3d146ea0d721"><code>f141760</code></a>
      Fix a typos (<a
      href="https://redirect.github.com/lycheeverse/lychee-action/issues/257">#257</a>)</li>
      <li>See full diff in <a
      href="https://github.com/lycheeverse/lychee-action/compare/2bb232618be239862e31382c5c0eaeba12e5e966...7cd0af4c74a61395d455af97419279d86aafaede">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      
      Dependabot will resolve any conflicts with this PR as long as you don't
      alter it yourself. You can also trigger a rebase manually by commenting
      `@dependabot rebase`.
      
      [//]: # (dependabot-automerge-start)
      [//]: # (dependabot-automerge-end)
      
      ---
      
      <details>
      <summary>Dependabot commands and options</summary>
      <br />
      
      You can trigger Dependabot actions by commenting on this PR:
      - `@dependabot rebase` will rebase this PR
      - `@dependabot recreate` will recreate this PR, overwriting any edits
      that have been made to it
      - `@dependabot merge` will merge this PR after your CI passes on it
      - `@dependabot squash and merge` will squash and merge this PR after
      your CI passes on it
      - `@dependabot cancel merge` will cancel a previously requested merge
      and block automerging
      - `@dependabot reopen` will reopen this PR if it is closed
      - `@dependabot close` will close this PR and stop Dependabot recreating
      it. You can achieve the same result by closing it manually
      - `@dependabot show <dependency name> ignore conditions` will show all
      of the ignore conditions of the specified dependency
      - `@dependabot ignore <dependency name> major version` will close this
      group update PR and stop Dependabot creating any more for the specific
      dependency's major version (unless you unignore this specific
      dependency's major version or upgrade to it yourself)
      - `@dependabot ignore <dependency name> minor version` will close this
      group update PR and stop Dependabot creating any more for the specific
      dependency's minor version (unless you unignore this specific
      dependency's minor version or upgrade to it yourself)
      - `@dependabot ignore <dependency name>` will close this group update PR
      and stop Dependabot creating any more for the specific dependency
      (unless you unignore this specific dependency or upgrade to it yourself)
      - `@dependabot unignore <dependency name>` will remove all of the ignore
      conditions of the specified dependency
      - `@dependabot unignore <dependency name> <ignore condition>` will
      remove the ignore condition of the specified dependency and ignore
      conditions
      
      
      </details>
      
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    • Alin Dima's avatar
      fix claim queue size (#6257) · f4133b08
      Alin Dima authored
      Reported in
      https://github.com/paritytech/polkadot-sdk/issues/6161#issuecomment-2432097120
      
      Fixes a bug introduced in
      https://github.com/paritytech/polkadot-sdk/pull/5461, where the claim
      queue would contain entries even if the validator groups storage is
      empty (which happens during the first session).
      
      This PR sets the claim queue core count to be the minimum between the
      num_cores param and the number of validator groups
      
      TODO:
      - [x] prdoc
      - [x] unit test
    • Xavier Lau's avatar
    • Xavier Lau's avatar
      Migrate pallet-glutton benchmark to v2 (#6296) · f4ded5c4
      Xavier Lau authored
      
      Part of:
      
      - #6202.
      
      ---------
      
      Co-authored-by: default avatarGitHub Action <action@github.com>
      Co-authored-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
      Co-authored-by: default avatarDónal Murray <donalm@seadanda.dev>
      Co-authored-by: default avatarGiuseppe Re <giuseppe.re@parity.io>
      Co-authored-by: default avatarDónal Murray <donal.murray@parity.io>
    • Iulian Barbu's avatar
      templates: make node compilation optional (#5954) · 2a849174
      Iulian Barbu authored
      # Description
      
      Closes #5940  
      
      ## Integration
      
      Node devs that rely on templates' nodes binaries for minimal or
      parachain would need to follow the updated templates' README.mds again
      to find how to build the nodes' binaries.
      
      ## Review Notes
      
      Conditional compilation of virtual workspaces would compile the
      `members` list as if we passed `--workspace` flag to `cargo build` ,
      except when adding a `default-members` list which will be used for any
      cargo command executed in the virtual workspace root. To build the full
      members list needs passing `--workspace` flag.
      
      Other options investigated:
      - feature guard the `node` crate by defining a feature in the `node`
      crate, but it feels too complex since all code needs to be feature
      guarded. I haven't tried it but technically speaking it might work. I
      think though it looks awkward and my opinion is that the alternative is
      better.
      - defining features in the virtual workspace's Cargo.toml doesn't work
      (thought that I might create a feature that will have a dependency on
      the `node` crate and then not passing the feature to cargo build results
      in ignoring the `node` crate)
      - skipping compilation by using an environment variable, read in the
      build script, that will exit compilation abruptly if not set, but I
      couldn't make it work.
      - exclude the crate from the members list and build it specifically by
      passing `--package minimal-template-node` flag to the `cargo build`
      command. This has the disadvantage of not allowing IDEs based on rust
      analyzer to index/compile the node crate.
      
      My conclusion is that any option would require two commands to build the
      template, one with the node and one without, and both must be included
      in the README or templates usage documentation. If it comes which ones
      to pick I am in favor of the `default-members` option, which requires
      minimal intervention and expresses how cargo commands are executed on
      top of the workspace members, and what's left out from regular usage.
      
      ### Testing
      
      Testing was conducted as described bellow:
      
      - [x] zombienet with `minimal-template-node` , `parachain-template-node`
      and `polkadot-omni-node`. Things work as expected.
      - [x] no chopsticks testing was conducted - feels a bit out of scope for
      OmniNode related docs and overall testing when promoting it over the
      templates' nodes.
      - [x] testing the changes for the sync templates workflow (ignore the
      added comment from the Cargo.tomls, it was removed here on this branch:
      [99bff3e2](https://github.com/paritytech/polkadot-sdk/pull/5954/commits/99bff3e2
      
      )):
      [minimal](https://github.com/paritytech-stg/polkadot-sdk-minimal-template/pull/22/files#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542R9),
      [parachain](https://github.com/paritytech-stg/polkadot-sdk-parachain-template/pull/19/files#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542R9),
      [solochain](https://github.com/paritytech-stg/polkadot-sdk-solochain-template/pull/17/files#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542R9).
      The links correspond to PRs opened by a bot after manually starting the
      sync-templates workflow on `paritytech-stg` org to test the end result
      of the `Cargo.toml` changes.
      
      ---------
      
      Signed-off-by: default avatarIulian Barbu <iulian.barbu@parity.io>
      Co-authored-by: default avatarKian Paimani <5588131+kianenigma@users.noreply.github.com>
    • Giuseppe Re's avatar
      Refactor pallet `claims` (#6318) · 657b5503
      Giuseppe Re authored
      
      - [x] Removing `without_storage_info` and adding bounds on the stored
      types for pallet `claims` - issue
      https://github.com/paritytech/polkadot-sdk/issues/6289
      - [x] Migrating to benchmarking V2 -
      https://github.com/paritytech/polkadot-sdk/issues/6202
      
      ---------
      
      Co-authored-by: default avatarGuillaume Thiolliere <gui.thiolliere@gmail.com>
    • PG Herveou's avatar
      [eth-rpc] Fixes (#6317) · 7f80f452
      PG Herveou authored
      
      Various fixes for the release of eth-rpc & ah-westend-runtime
      
      - Bump asset-hub westend spec version
      - Fix the status of the Receipt to properly report failed transactions
      - Fix value conversion between native and eth decimal representation
      
      ---------
      
      Co-authored-by: default avatarGitHub Action <action@github.com>
    • Alin Dima's avatar
      collation-generation: use v2 receipts (#5908) · 68e05636
      Alin Dima authored
      
      Part of https://github.com/paritytech/polkadot-sdk/issues/5047
      
      Plus some cleanups
      
      ---------
      
      Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>
      Co-authored-by: default avatarAndrei Sandu <andrei-mihail@parity.io>
      Co-authored-by: default avatarAndrei Sandu <54316454+sandreim@users.noreply.github.com>
      Co-authored-by: default avatarGitHub Action <action@github.com>
  2. Nov 01, 2024
  3. Oct 31, 2024
  4. Oct 30, 2024
  5. Oct 29, 2024
  6. Oct 28, 2024