Skip to content
Snippets Groups Projects
  1. Nov 05, 2024
    • Adrian Catangiu's avatar
      Remove leftover references of Wococo (#6361) · ec61396e
      Adrian Catangiu authored
      Remove references of now defunct Wococo network.
      
      The XCM `NetworkId::Wococo` will also be removed with [XCMv5
      PR](https://github.com/paritytech/polkadot-sdk/pull/4826)
    • Adrian Catangiu's avatar
      snowbridge: allow account conversion for Ethereum accounts (#6221) · 6969be36
      Adrian Catangiu authored
      Replace `GlobalConsensusEthereumConvertsFor` with
      `EthereumLocationsConverterFor` that allows `Location` to `AccountId`
      conversion for the Ethereum network root as before, but also for
      Ethereum contracts and accounts.
      
      The new converter only matches explicit `parents: 2` Ethereum locations,
      meaning it should be used only on/by parachains.
    • Alexandru Vasile's avatar
      authority-discovery: Populate DHT records with public listen addresses (#6298) · 762f824c
      Alexandru Vasile authored
      
      This PR's main goal is to add public listen addresses to the DHT
      authorities records. This change improves the discoverability of
      validators that did not provide the `--public-addresses` flag.
      
      This PR populates the authority DHT records with public listen addresses
      if any.
      
      The change effectively ensures that addresses are added to the DHT
      record in following order:
       1. Public addresses provided by CLI `--public-addresses`
       2. Maximum of 4 public (global) listen addresses (if any)
      3. Any external addresses discovered from the network (ie from
      `/identify` protocol)
      
      
      While at it, this PR adds the following constraints on the number of
      addresses:
      - Total number of addresses cached is bounded at 16 (increased from 10).
      - A maximum number of 32 addresses are published to DHT records
      (previously unbounded).
        - A maximum of 4 global listen addresses are utilized.
            
      This PR also removes the following warning:
      `WARNING: No public address specified, validator node may not be
      reachable.`
      
      ### Next Steps
      - [ ] deploy and monitor in versi network
      
      Closes: https://github.com/paritytech/polkadot-sdk/issues/6280
      Part of: https://github.com/paritytech/polkadot-sdk/issues/5266
      
      cc @paritytech/networking
      
      ---------
      
      Signed-off-by: default avatarAlexandru Vasile <alexandru.vasile@parity.io>
      Co-authored-by: default avatarDmitry Markin <dmitry@markin.tech>
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
    • davidk-pt's avatar
      Bounty Pallet: add `approve_bounty_with_curator` call to `bounties` pallet (#5961) · 2ae79be8
      davidk-pt authored
      
      Resolves issue https://github.com/paritytech/polkadot-sdk/issues/5928
      
      Adds `approve_bounty_with_curator` call to the `bounties` pallet to
      combine functions of `approve_bounty` and `propose_curator` into one
      call. Also adds a new status `ApprovedWithCurator` required to
      distinguish if bounty was approved with curator when skipping through
      `Funded` status and moving to `CuratorProposed` status.
      
      If `unassign_curator` is called after `approve_bounty_with_curator` the
      process will fall back to the old flow of calling `propose_curator`
      separately.
      
      ---------
      
      Co-authored-by: default avatarDavidK <davidk@parity.io>
      Co-authored-by: command-bot <>
      Co-authored-by: default avatarAnkan <10196091+Ank4n@users.noreply.github.com>
  2. Nov 04, 2024
    • s0me0ne-unkn0wn's avatar
      Silent annoying log (#6351) · f1e416a5
      s0me0ne-unkn0wn authored
      The logline in question doesn't indeed present any interest for a node
      operator (I mean, there is not much he can do about that warning), but
      in a heavy transaction load situation, when each of 5000 transactions in
      txpool produces a warning, it's really annoying. Still, it's useful for
      a developer, so I propose to log it at the `debug` level.
    • Cyrill Leutwiler's avatar
      [pallet-revive] rework balance transfers (#6187) · d69a80e6
      Cyrill Leutwiler authored
      
      This PR removes the `transfer` syscall and changes balance transfers to
      make the existential deposit (ED) fully transparent for contracts.
      
      The `transfer` API is removed since there is no corresponding EVM opcode
      and transferring via a call introduces barely any overhead.
      
      We make the ED transparent to contracts by transferring the ED from the
      call origin to nonexistent accounts. Without this change, transfers to
      nonexistant accounts will transfer the supplied value minus the ED from
      the contracts viewpoint, and consequentially fail if the supplied value
      lies below the ED. Changing this behavior removes the need for contract
      code to handle this rather annoying corner case and aligns better with
      the EVM. The EVM charges a similar deposit from the gas meter, so
      transferring the ED from the call origin is practically the same as the
      call origin pays for gas.
      
      ---------
      
      Signed-off-by: default avatarxermicus <cyrill@parity.io>
      Signed-off-by: default avatarCyrill Leutwiler <bigcyrill@hotmail.com>
      Co-authored-by: command-bot <>
      Co-authored-by: default avatarGitHub Action <action@github.com>
      Co-authored-by: default avatarPG Herveou <pgherveou@gmail.com>
    • Andrei Sandu's avatar
      `statement-distribution`: RFC103 implementation (#5883) · 38cd03c5
      Andrei Sandu authored
      
      Part of https://github.com/paritytech/polkadot-sdk/issues/5047
      On top of https://github.com/paritytech/polkadot-sdk/pull/5679
      
      ---------
      
      Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>
      Co-authored-by: default avatarGitHub Action <action@github.com>
    • Javier Viola's avatar
      Disable flaky tests reported in #6343 / #6345 (#6346) · 028e61be
      Javier Viola authored
      
      test: zombienet-polkadot-functional-0018-shared-core-idle-parachain
      Disable flaky test reported in
      https://github.com/paritytech/polkadot-sdk/issues/6343
      
      test: zombienet-polkadot-functional-0016-approval-voting-parallel
      Disable flaky test reported in
      https://github.com/paritytech/polkadot-sdk/issues/6345
      
      Co-authored-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
    • clangenb's avatar
      migrate pallet-recovery to benchmark V2 syntax (#6299) · b1084e7a
      clangenb authored
      
      Part of:
      * #6202
      
      ---------
      
      Co-authored-by: default avatarGitHub Action <action@github.com>
      Co-authored-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
    • Andrei Sandu's avatar
      inclusion emulator: correctly handle UMP signals (#6178) · b3265401
      Andrei Sandu authored
      
      Changes inclusion emulator to not count the UMP signals when checking
      ump message constraints.
      
      ---------
      
      Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>
      Co-authored-by: default avatarGitHub Action <action@github.com>
    • dependabot[bot]'s avatar
      Bump the ci_dependencies group across 1 directory with 3 updates (#6340) · 8b6f8157
      dependabot[bot] authored
      Bumps the ci_dependencies group with 3 updates in the / directory:
      [docker/build-push-action](https://github.com/docker/build-push-action),
      [actions/setup-node](https://github.com/actions/setup-node) and
      [lycheeverse/lychee-action](https://github.com/lycheeverse/lychee-action).
      
      Updates `docker/build-push-action` from 5 to 6
      <details>
      <summary>Release notes</summary>
      <p><em>Sourced from <a
      href="https://github.com/docker/build-push-action/releases">docker/build-push-action's
      releases</a>.</em></p>
      <blockquote>
      <h2>v6.0.0</h2>
      <ul>
      <li>Export build record and generate <a
      href="https://docs.docker.com/build/ci/github-actions/build-summary/">build
      summary</a> by <a
      href="https://github.com/crazy-max"><code>@​crazy-max</code></a> in <a
      href="https://redirect.github.com/docker/build-push-action/pull/1120">docker/build-push-action#1120</a></li>
      <li>Bump <code>@​docker/actions-toolkit</code> from 0.24.0 to 0.26.0 in
      <a
      href="https://red...
    • Alin Dima's avatar
      fix claim queue size (#6257) · f4133b08
      Alin Dima authored
      Reported in
      https://github.com/paritytech/polkadot-sdk/issues/6161#issuecomment-2432097120
      
      Fixes a bug introduced in
      https://github.com/paritytech/polkadot-sdk/pull/5461, where the claim
      queue would contain entries even if the validator groups storage is
      empty (which happens during the first session).
      
      This PR sets the claim queue core count to be the minimum between the
      num_cores param and the number of validator groups
      
      TODO:
      - [x] prdoc
      - [x] unit test
    • Xavier Lau's avatar
    • Xavier Lau's avatar
      Migrate pallet-glutton benchmark to v2 (#6296) · f4ded5c4
      Xavier Lau authored
      
      Part of:
      
      - #6202.
      
      ---------
      
      Co-authored-by: default avatarGitHub Action <action@github.com>
      Co-authored-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
      Co-authored-by: default avatarDónal Murray <donalm@seadanda.dev>
      Co-authored-by: default avatarGiuseppe Re <giuseppe.re@parity.io>
      Co-authored-by: default avatarDónal Murray <donal.murray@parity.io>
    • Iulian Barbu's avatar
      templates: make node compilation optional (#5954) · 2a849174
      Iulian Barbu authored
      # Description
      
      Closes #5940  
      
      ## Integration
      
      Node devs that rely on templates' nodes binaries for minimal or
      parachain would need to follow the updated templates' README.mds again
      to find how to build the nodes' binaries.
      
      ## Review Notes
      
      Conditional compilation of virtual workspaces would compile the
      `members` list as if we passed `--workspace` flag to `cargo build` ,
      except when adding a `default-members` list which will be used for any
      cargo command executed in the virtual workspace root. To build the full
      members list needs passing `--workspace` flag.
      
      Other options investigated:
      - feature guard the `node` crate by defining a feature in the `node`
      crate, but it feels too complex since all code needs to be feature
      guarded. I haven't tried it but technically speaking it might work. I
      think though it looks awkward and my opinion is that the alternative is
      better.
      - defining features in the virtual workspace's Cargo.toml doesn't work
      (thought that I might create a feature that will have a dependency on
      the `node` crate and then not passing the feature to cargo build results
      in ignoring the `node` crate)
      - skipping compilation by using an environment variable, read in the
      build script, that will exit compilation abruptly if not set, but I
      couldn't make it work.
      - exclude the crate from the members list and build it specifically by
      passing `--package minimal-template-node` flag to the `cargo build`
      command. This has the disadvantage of not allowing IDEs based on rust
      analyzer to index/compile the node crate.
      
      My conclusion is that any option would require two commands to build the
      template, one with the node and one without, and both must be included
      in the README or templates usage documentation. If it comes which ones
      to pick I am in favor of the `default-members` option, which requires
      minimal intervention and expresses how cargo commands are executed on
      top of the workspace members, and what's left out from regular usage.
      
      ### Testing
      
      Testing was conducted as described bellow:
      
      - [x] zombienet with `minimal-template-node` , `parachain-template-node`
      and `polkadot-omni-node`. Things work as expected.
      - [x] no chopsticks testing was conducted - feels a bit out of scope for
      OmniNode related docs and overall testing when promoting it over the
      templates' nodes.
      - [x] testing the changes for the sync templates workflow (ignore the
      added comment from the Cargo.tomls, it was removed here on this branch:
      [99bff3e2](https://github.com/paritytech/polkadot-sdk/pull/5954/commits/99bff3e2
      
      )):
      [minimal](https://github.com/paritytech-stg/polkadot-sdk-minimal-template/pull/22/files#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542R9),
      [parachain](https://github.com/paritytech-stg/polkadot-sdk-parachain-template/pull/19/files#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542R9),
      [solochain](https://github.com/paritytech-stg/polkadot-sdk-solochain-template/pull/17/files#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542R9).
      The links correspond to PRs opened by a bot after manually starting the
      sync-templates workflow on `paritytech-stg` org to test the end result
      of the `Cargo.toml` changes.
      
      ---------
      
      Signed-off-by: default avatarIulian Barbu <iulian.barbu@parity.io>
      Co-authored-by: default avatarKian Paimani <5588131+kianenigma@users.noreply.github.com>
    • Giuseppe Re's avatar
      Refactor pallet `claims` (#6318) · 657b5503
      Giuseppe Re authored
      
      - [x] Removing `without_storage_info` and adding bounds on the stored
      types for pallet `claims` - issue
      https://github.com/paritytech/polkadot-sdk/issues/6289
      - [x] Migrating to benchmarking V2 -
      https://github.com/paritytech/polkadot-sdk/issues/6202
      
      ---------
      
      Co-authored-by: default avatarGuillaume Thiolliere <gui.thiolliere@gmail.com>
    • PG Herveou's avatar
      [eth-rpc] Fixes (#6317) · 7f80f452
      PG Herveou authored
      
      Various fixes for the release of eth-rpc & ah-westend-runtime
      
      - Bump asset-hub westend spec version
      - Fix the status of the Receipt to properly report failed transactions
      - Fix value conversion between native and eth decimal representation
      
      ---------
      
      Co-authored-by: default avatarGitHub Action <action@github.com>
    • Alin Dima's avatar
      collation-generation: use v2 receipts (#5908) · 68e05636
      Alin Dima authored
      
      Part of https://github.com/paritytech/polkadot-sdk/issues/5047
      
      Plus some cleanups
      
      ---------
      
      Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>
      Co-authored-by: default avatarAndrei Sandu <andrei-mihail@parity.io>
      Co-authored-by: default avatarAndrei Sandu <54316454+sandreim@users.noreply.github.com>
      Co-authored-by: default avatarGitHub Action <action@github.com>
  3. Nov 01, 2024
  4. Oct 31, 2024
  5. Oct 30, 2024
  6. Oct 29, 2024
  7. Oct 28, 2024