1. Mar 18, 2021
  2. Mar 17, 2021
  3. Mar 16, 2021
    • Kian Paimani's avatar
      Companion for sub/8176 (#2622) · 6b0c56b8
      Kian Paimani authored
      
      
      * Merge
      
      * Fixes
      
      * Fix build
      
      * remove dep.
      
      * undo dep.
      
      * upadte substrate
      
      * cargo run --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/
      
      * Fix lock
      
      * revert lock; cargo update -p sp-io
      
      * from_rational_approx -> from_rational
      
      * Silence more warnings
      
      Co-authored-by: default avatarGav Wood <[email protected]>
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarParity Benchmarking Bot <[email protected]>
      6b0c56b8
  4. Mar 14, 2021
    • Gavin Wood's avatar
      New slots/auctions architecture (#2294) · edd81bf6
      Gavin Wood authored
      
      
      * TODOs
      
      * Add auctions.rs, comment on changes needed.
      
      * Remove cruft from slots
      
      * Remove more from auctions.rs
      
      * More logic drafting in slots.
      
      * More logic in slots.rs
      
      * patch some errors
      
      * more fixes
      
      * last nit
      
      * Cleanups in slots.rs
      
      * Cleanups in slots.rs
      
      * patches
      
      * make build
      
      * crowdloan to new api
      
      * auction compile
      
      * Use ParaId instead of FundIndex in Crowdloan (#2303)
      
      * use paraid instead of fundindex
      
      * Update crowdloan.rs
      
      * check caller is manager
      
      * Auction tests and fix build warnings.
      
      * Configurable origin for initiating auctions
      
      * Remove on_finalize
      
      * #2303 (manual merge)
      
      * Tests for Slots
      
      * some registrar tests
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Update runtime/common/src/slots.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Slots uses Registrar for CurrentChains
      
      * swap works test
      
      * on swap impl
      
      * traitify parachain cleanup
      
      * explicit lifecycle tracking for paras
      
      * initial implementation of lifecycles and upgrades
      
      * clean up a bit
      
      * Update runtime/common/src/slots.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * fix doc comment
      
      * more rigid lifecycle checks
      
      * include paras which are transitioning, and lifecycle query
      
      * format guide
      
      * update api
      
      * update guide
      
      * explicit outgoing state, fix genesis
      
      * handle outgoing with transitioning paras
      
      * Revert "explicit lifecycle tracking for paras"
      
      This reverts commit 4177af7ba473bbd9c26bccd861793f25265b6657.
      
      * remove lifecycle tracking from registrar
      
      * do not include transitioning paras in identifier
      
      * Update paras_registrar.rs
      
      * final patches to registrar
      
      * Fix test
      
      * use noop in test
      
      * clean up pending swap on deregistration
      
      * finish registrar tests
      
      * Update roadmap/implementers-guide/src/runtime/paras.md
      
      * Update roadmap/implementers-guide/src/runtime/paras.md
      
      * Update roadmap/implementers-guide/src/runtime/paras.md
      
      * Apply suggestions from code review
      
      * Use matches macro
      
      * Correct terms
      
      * Apply suggestions from code review
      
      * Remove direct need for Slots and Registrar from Crowdloan
      
      * Rejig things slightly
      
      * actions queue
      
      * Revert "actions queue"
      
      This reverts commit b2e9011ec8937d6c73e99292416c9692aeb30f73.
      
      * Traitify Auction interface.
      
      * Mockups and initial code for Crowdloan testing
      
      * One test...
      
      * collapse onboarding state
      
      * fix some crowdloan tests
      
      * one more
      
      * start benchmarks for auctions
      
      * benchmark bid
      
      * fix more crowdloan tests
      
      * onboard and begin retirement no longer exist
      
      * Revert "onboard and begin retirement no longer exist"
      
      This reverts commit 2e100fd94e3540bff5f172328b5d917896f1c6fc.
      
      * Simplify crowdloan and make it work.
      
      * Fixes
      
      * fix some
      
      * finish merge fixes
      
      * fix refund bug in auctions
      
      * Add traits to Registrar for tests and benchmarks
      
      * fix more auction benchmarks
      
      * Fix TestAuctioneer
      
      * finish crowdloan benchmarks
      
      * start setting up full integration tests
      
      * expand integration tests
      
      * finish basic integration test
      
      * add more integration tests
      
      * begin slots benchmarks
      
      * start paras registrar benchmarks
      
      * fix merge
      
      * fix tests
      
      * clean up paras registrar
      
      * remove println
      
      * remove outdated cleanup config
      
      * update benchmarks
      
      * Add WeightInfo
      
      * enable runtime-benchmarks feature flag
      
      * complete swap benchmark
      
      * add parachains and onboarding into westend
      
      * add benchmarks and genesis
      
      * cargo run --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=auctions --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/
      
      * cargo run --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=slots --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/
      
      * fix benchmark execution
      
      * cargo run --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=crowdloan --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/
      
      * cargo run --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=paras_registrar --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/
      
      * Use `new_raise_len` in crowdloan on_initialize
      
      * Update paras_registrar.rs
      
      * fix westend merge
      
      * impl on_swap for crowdloan
      
      * Check fund exists before create
      
      * update for crowdloan sig
      
      * cargo run --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=crowdloan --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/
      
      * slots on_initialize
      
      * use integration tests environment for benchmarks
      
      * fix hrmp event
      
      * auction on_initialize
      
      * cargo run --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=auctions --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/
      
      * fix storage name in auctions
      
      * add auction_index to winning data
      
      * winning data takes into account current auction index
      
      * remove println
      
      * cargo run --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=auctions --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/
      
      * cargo run --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=slots --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/
      
      * Revert "add auction_index to winning data"
      
      * PastRandomness.
      
      * Fixes
      
      * Use new randomness
      
      * fix use of randomness in auctions and runtime config
      
      * expose consts
      
      * fix auction test
      
      * add deposit per byte for para registration
      
      * basic swap integration test
      
      * make swap test more comprehensive
      
      * Add WinningVec for easier retrieval in the front-end.
      
      * clean up `WinningVec` at the end
      
      * Add event for when a new best bid comes in
      
      * Fix propagation of winners in ending period
      
      * fix benchmarks, refund weight in dissolve
      
      * fix unused
      
      * remove some TODOs
      
      * setup opaque keys for paras in westend
      
      * cargo run --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=crowdloan --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/
      
      * remove unused
      
      * cargo run --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=auctions --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/
      
      * back to regular runtime config
      
      * use saturating math where user input can be
      
      * better first slot check
      
      * Update runtime/common/src/claims.rs
      
      * update westend onswap impl
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      Co-authored-by: default avatarParity Benchmarking Bot <[email protected]>
      edd81bf6
  5. Mar 10, 2021
    • André Silva's avatar
      runtime: use babe as randomness source (#2504) · b3603605
      André Silva authored
      * runtime: use babe as randomness source
      
      * runtime: fix randomness api
      
      * bridges: fix random_seed
      
      * parachains: use mock TestRandomness from frame_support_test
      
      * parachains: use mock TestRandomness from frame_support_test
      
      * runtime: update randomness source in test-runtime
      
      * runtime: remove unused import
      
      * parachains: add todo to audit usage of randomness api
      
      * "Update Substrate"
      
      Co-authored-by: parity-processbot <>
      b3603605
  6. Mar 09, 2021
  7. Mar 01, 2021
  8. Feb 27, 2021
  9. Feb 26, 2021
    • Xiliang Chen's avatar
      Add an optional verifier to crowdloan (#2248) · 69734bb8
      Xiliang Chen authored
      
      
      * Add an optional verifier to crowdloan
      
      * add tests
      
      * verify signatures
      
      * benchmark with signatures
      
      * update crowdloan benchmark
      
      * try to get keystore working in test
      
      * rewrite to avoid traits
      
      * Use MultiSignature and MultiSigner
      
      * refactor and update benchmarks
      
      * optimize check order
      
      * fix no_std build
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      69734bb8
  10. Feb 24, 2021
    • Martin Pugh's avatar
      [release] Prep for v0.8.29 (#2497) · 5ffb8cb4
      Martin Pugh authored
      
      
      * bump version and substrate
      
      * update weights
      
      * bump substrate
      
      * cargo run --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=frame_system --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/
      
      * cargo run --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/
      
      * cargo run --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/
      
      * cargo run --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/
      
      Co-authored-by: default avatarParity Benchmarking Bot <[email protected]>
      5ffb8cb4
  11. Feb 23, 2021
  12. Feb 22, 2021
  13. Feb 19, 2021
    • Shawn Tabrizi's avatar
      Session Delayed Para Changes / Actions Queue (#2406) · a5defa7c
      Shawn Tabrizi authored
      
      
      * initial implementation of lifecycles and upgrades
      
      * clean up a bit
      
      * fix doc comment
      
      * more rigid lifecycle checks
      
      * include paras which are transitioning, and lifecycle query
      
      * format guide
      
      * update api
      
      * update guide
      
      * explicit outgoing state, fix genesis
      
      * handle outgoing with transitioning paras
      
      * do not include transitioning paras in identifier
      
      * Update roadmap/implementers-guide/src/runtime/paras.md
      
      * Update roadmap/implementers-guide/src/runtime/paras.md
      
      * Update roadmap/implementers-guide/src/runtime/paras.md
      
      * Apply suggestions from code review
      
      * Use matches macro
      
      * Correct terms
      
      * Apply suggestions from code review
      
      * actions queue
      
      * Revert "actions queue"
      
      This reverts commit b2e9011ec8937d6c73e99292416c9692aeb30f73.
      
      * collapse onboarding state
      
      * starting actions queue
      
      * consolidate actions queue
      
      * schedule para initialize result
      
      * more actions queue for upgrade/downgrade
      
      * clean up with fully implemented actions queue
      
      * fix tests
      
      * fix scheduler tests
      
      * fix hrmp tests
      
      * fix test
      
      * doc fixes
      
      * fix hrmp test w/ valid para
      
      * Update paras.md
      
      * fix paras registrar
      
      * Update propose_parachain.rs
      
      * fix merge
      
      * Introduce "shared" module
      
      * fix rococo build
      
      * fix up and use shared
      
      * guide updates
      
      * add shared config to common tests
      
      * add shared to test-runtime
      
      * remove println
      
      * fix note
      
      Co-authored-by: default avatarGavin Wood <[email protected]>
      a5defa7c
  14. Feb 10, 2021
  15. Feb 09, 2021
  16. Feb 06, 2021
  17. Feb 02, 2021
    • Liu-Cheng Xu's avatar
      Conpanion for Substrate#7127 (#1865) · d353c76e
      Liu-Cheng Xu authored
      * Conpanion for Substrate#7127
      
      * Use sp_session::OneSessionHandler
      
      * .
      
      * Fix pallet_session::OneSessionHandler
      
      * OneSessionHandler is in frame_support now
      
      * "Update Substrate"
      
      Co-authored-by: parity-processbot <>
      d353c76e
  18. Jan 29, 2021
  19. Jan 28, 2021
  20. Jan 27, 2021
  21. Jan 26, 2021
  22. Jan 20, 2021
  23. Jan 17, 2021
  24. Jan 16, 2021
  25. Jan 13, 2021
    • Sergey Pepyakin's avatar
      HRMP channel deposits (#2225) · c644c39f
      Sergey Pepyakin authored
      * Drive by fixes
      
      The visibility modifiers are remnants of the previous structure where
      HRMP wasn't a standalone module, by rather a submodule of the router
      module.
      
      * Add Currency assoc type to Config
      
      This would allow us to reserve balance for deposits. This commit also
      integrates the HRMP module in rococo, test-runtime and mocks to use the
      balances pallet.
      
      * Fix a bug that doesn't increment the age
      
      In case the request is not confirmed, the age would be incremented but
      not persisted.
      
      * Fix cleaning the indexes
      
      Before that change, the cleaning of the channel indexes was wrong, because it
      naively removed entire rows that was pertaining to the para we delete.
      This approach is flawed because it doesn't account for the rows that are
      pertaining to other paras that contain the outgoing one.
      
      This clearly violates the invariant imposed on the indexes, that all
      the index rows must contain alive paras, but apart from that it also
      lead to the situation where ingress index would contain the a different
      set of channels that an egress have.
      
      * Reserve currency for opening the channels
      
      Note the ugly `unique_saturated_into` calls. The reason for them is the
      currency trait accepts and defines the `Balance` associated type and the
      deposit values are coming from the `HostConfiguration` where they are
      defined using the `Balance`.
      
      I figured that parameterising `HostConfiguration` would be annoying. On
      the other hand, I don't expect these `unique_saturated_into` calls to
      give us problems since it seems to be a reasonable assumption that this
      module will be instantiated within a runtime where the Currency provided
      will have a Balance that matches the one used in the configuration.
      
      * Tests: Adapt `run_to_block` so that it submits a proper config
      
      * Tests: exercise the deposit logic
      c644c39f
  26. Jan 12, 2021
  27. Jan 11, 2021
    • thiolliere's avatar
      bump codec minor version (#2247) · a3682f8d
      thiolliere authored
      a3682f8d
    • Shawn Tabrizi's avatar
      Crowdloan Updates (#2166) · 9aebac3c
      Shawn Tabrizi authored
      
      
      * Rename crowdfund -> crowdloan
      
      * allow contribution on behalf of another user
      
      * starting some benchmarks
      
      * optimization: use append api
      
      * Use on_initialize instead of on_finalize
      
      * More benchmarks
      
      * try to implement partial child storage removal
      
      * partial dissolve test
      
      * onboard benchmark
      
      * begin retirement
      
      * on_initialize
      
      * remove _ { }
      
      * Revert "allow contribution on behalf of another user"
      
      This reverts commit b7dd7d1ec751495cee3ddb57133a13c390b020e5.
      
      * finish undo of "allow contribution on behalf of another user"
      
      * Allow any user to trigger withdraw on closed crowdloan
      
      * use transfer instead of withdraw/create pattern
      
      * unused warning
      
      * Update runtime/common/src/crowdloan.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * dont need to assign to empty variable
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      9aebac3c
  28. Jan 06, 2021
  29. Dec 30, 2020
    • Alexander Theißen's avatar
      Companion for #7810 (Define ss58 prefix inside the runtime) (#2182) · 2c1f43a9
      Alexander Theißen authored
      * Companion for #7810
      
      * Added missing trait items for tests
      
      * Add another missing trait item
      
      * fixup
      
      * "Update Substrate"
      
      Co-authored-by: parity-processbot <>
      2c1f43a9
    • Shawn Tabrizi's avatar
      Migrate Claims Pallet to WeightInfo (#2171) · 0d363248
      Shawn Tabrizi authored
      
      
      * migrate claims to weightinfo
      
      * fix up
      
      * fix benchmark
      
      * cargo run --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=claims --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/
      
      * fix test runtime
      
      * cargo run --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=claims --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/
      
      * Update runtime/kusama/src/weights/claims.rs
      
      * use path for pallet
      
      * Update Cargo.lock
      
      * cargo run --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_common::claims --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/
      
      * Delete runtime_common::claims.rs
      
      * cargo run --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_common::claims --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_common_claims.rs
      
      * cargo run --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_common::claims --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_common_claims.rs
      
      * use full automation file
      
      * patch import
      
      * consolidate benchmark logic
      
      * fix
      
      * cargo run --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_common::claims --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_common_claims.rs
      
      * cargo run --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_common::claims --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_common_claims.rs
      
      * update weight comments
      
      Co-authored-by: default avatarParity Benchmarking Bot <[email protected]>
      0d363248
  30. Dec 29, 2020
  31. Dec 21, 2020
    • Sergey Pepyakin's avatar
      Do not use rely on the block initialization when calling runtime APIs (#2123) · 4405f52e
      Sergey Pepyakin authored
      
      
      * Don't initialize block when calling runtime APIs
      
      * Adapt check_validation_outputs
      
      We split the code path for the inclusion and for the commitments checking.
      
      * Slap #[skip_initialize_block] on safe runtime APIs
      
      That is, those that should not be affected by this attribute
      
      * Make `Scheduled` not ephemeral
      
      So that it is persisted in the storage and ready to be inspected
      by the runtime APIs. This is in contrast to what was before, where we
      would remove the storage entry and then rely on the scheduling performed
      by `on_initialize` again.
      
      * Add a big fat comment
      
      * Typos
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * Move session change to the end of the current block
      
      Previously, it was the beginning of the next block. This allows us to
      put #[skip_initialize_block]
      
      * Update tests
      
      * Fix a test in paras registrar
      
      Also refactor it a bit so the next time there are more chances this kind
      of issue is diagnosed quicker.
      
      * Add for_runtime_api to inclusion's check_validation_outputs
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      4405f52e
  32. Dec 16, 2020
    • asynchronous rob's avatar
      Reward validators for participating in parachains (#2089) · f4e93052
      asynchronous rob authored
      * plumbing for rewarding backers
      
      * give validators reward points for participating
      
      * fix tests
      
      * add bitfield rewarding
      
      * add mocks for backing rewards
      
      * add testing for backing & availability rewards
      
      * implement RewardValidators on top of staking
      
      * add to test-runtime and rococo
      
      * add to test-runtime & rococo
      
      * point to source on rewards values
      
      * fix common tests
      
      * do not reward availability anymore
      f4e93052
    • RK's avatar
      Companion for #7536 (Pallet Treasury Refactor) (#2025) · 1ecc2e03
      RK authored
      
      
      * wk2048 | D6 | issue-7143-treasury-refactor | integration
      
      * wk2048 | D6 | issue-7143-treasury-refactor | integration | p2
      
      * trait -> config
      
      * fix weight files and import
      
      * missed some
      
      * fix import
      
      * fix imports
      
      * alphabetize
      
      * fix config traits
      
      * fix trait
      
      * update traits
      
      * update weights
      
      * "Update Substrate"
      
      * fix features
      
      * Update runtime/kusama/src/lib.rs
      
      * Update runtime/polkadot/src/lib.rs
      
      * add bounties and tips in proxy filters
      
      * remove unused
      
      * remove unused
      
      * remove unused
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: parity-processbot <>
      Co-authored-by: default avatarthiolliere <[email protected]>
      1ecc2e03
  33. Dec 14, 2020