Skip to content
Snippets Groups Projects
  1. Nov 06, 2021
  2. Nov 05, 2021
  3. Nov 04, 2021
  4. Nov 03, 2021
  5. Nov 02, 2021
  6. Nov 01, 2021
  7. Oct 31, 2021
  8. Oct 30, 2021
    • Bastian Köcher's avatar
      pallet-utility: Fix possible mismatch between native/wasm (#10121) · 2237b43f
      Bastian Köcher authored
      * pallet-utility: Fix possible mismatch between native/wasm
      
      The `batched_calls_limit` constant value includes the `size_of` of the runtime `Call`. As we compile
      the runtime for native/wasm, we need to align the call size to ensure that it is the same on
      wasm/native. This also solves the problem of different metadata outputs for the same runtime.
      
      * Review feedback
      2237b43f
    • Shawn Tabrizi's avatar
      Add Baseline FRAME Benchmarks (#9691) · 2d556c44
      Shawn Tabrizi authored
      
      * create and add baseline
      
      * fix import
      
      * try a different name
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_benchmarking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/benchmarking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_benchmarking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/benchmarking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_benchmarking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/benchmarking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * increase repeats
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_benchmarking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/benchmarking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Update baseline.rs
      
      * Update baseline.rs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_benchmarking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/benchmarking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_benchmarking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/benchmarking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_benchmarking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/benchmarking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_benchmarking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/benchmarking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * improve hash benchmark
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_benchmarking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/benchmarking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_benchmarking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/benchmarking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_benchmarking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/benchmarking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_benchmarking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/benchmarking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      Co-authored-by: default avatarParity Bot <admin@parity.io>
      2d556c44
    • Squirrel's avatar
      Removal of light client from substrate (#9684) · 744bc44d
      Squirrel authored
      
      * Removal of light client from substrate
      
      * add missing import
      
      * These tests relate to there being light and non light clients.
      
      * removing lightnodes from test
      
      * cargo fmt
      
      * not needed
      
      * LightDataChecker not needed any longer
      
      * cargo fmt
      
      * Update client/service/test/src/lib.rs
      
      Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
      
      * Update client/service/test/src/lib.rs
      
      Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
      
      * cargo fmt
      
      Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
      744bc44d
    • Alexander Theißen's avatar
      contracts: Fix account counter isn't persisted (#10112) · 0fd67659
      Alexander Theißen authored
      
      * Add test to check account counter persistence
      
      * Fix bug that account counter wasn't properly persited
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_contracts --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/contracts/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      Co-authored-by: default avatarParity Bot <admin@parity.io>
      0fd67659
  9. Oct 29, 2021
    • Bastian Köcher's avatar
      pallet-scheduler: Introduce `OriginPrivilegeCmp` (#10078) · 95b8fd61
      Bastian Köcher authored
      
      * pallet-scheduler: Introduce `OriginPrivilegeCmp`
      
      When a scheduled task should be canceled, the origin that tries to
      cancel the task is compared to the origin the task should be executed
      with. Before this pr this check only allowed that both origins are
      equal. However, this is problematic as this means that for example a
      council origin it needs to be have the same amount of yes votes to
      cancel the scheduled task. While a council origin with more yes votes
      should be able to cancel this task. This happened recently on Kusama and
      lead to a failed cancelation of a scheduled task. With this pr the two
      origins are compared and the cancelling origin needs to have greater or
      equal privileges as the origin that scheduled the task. What a greater,
      equal or less privilege is, can be configured in the runtime.
      
      For simplicity, a `EqualPrivilegeOnly` implementation is provided that
      only checks if two origins are equal. So, this mimics the old behaviour.
      
      * FMT
      
      * fix import
      
      * Small optimizations
      
      Co-authored-by: default avatarShawn Tabrizi <shawntabrizi@gmail.com>
      95b8fd61
    • Liu-Cheng Xu's avatar
      c30233ab
    • dependabot[bot]'s avatar
      Bump libc from 0.2.103 to 0.2.105 (#10115) · 277d74fb
      dependabot[bot] authored
      
      Bumps [libc](https://github.com/rust-lang/libc) from 0.2.103 to 0.2.105.
      - [Release notes](https://github.com/rust-lang/libc/releases)
      - [Commits](https://github.com/rust-lang/libc/compare/0.2.103...0.2.105)
      
      ---
      updated-dependencies:
      - dependency-name: libc
        dependency-type: direct:production
        update-type: version-update:semver-patch
      ...
      
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      277d74fb
  10. Oct 26, 2021
  11. Oct 25, 2021
    • Luke Schoen's avatar
      Offchain-worker: Update example-offchain-worker with implementation for TestAuthId (#10096) · 9eb0a392
      Luke Schoen authored
      * Update example-offchain-worker to include missing implementation for TestAuthId
      
      i tried to incorporate the off-chain worker callback demo as a custom pallet of my own Substrate-based blockchain implementation that's provided at the following links
      * https://www.parity.io/blog/substrate-off-chain-workers-secure-and-efficient-computing-intensive-tasks/
      * https://gnunicorn.github.io/substrate-offchain-cb/
      but when i build the code with `cargo build --release`, it gave me an error:
      ```
      error[E0277]: the trait bound `AuthorityId: AppCrypto<MultiSigner, MultiSignature>` is not satisfied
      --> /Users/me/my_repo/node/runtime/src/lib.rs:1172:5
      |
      1172 |     type AuthorityId = AuthorityId;
      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `AppCrypto<MultiSigner, MultiSignature>` is not implemented for `AuthorityId`
      |
      note: required by a bound in `offchaincb::Config::AuthorityId`
      --> /Users/me/my_repo/node/pallets/offchaincb/src/lib.rs:169:21
      |
      169  |         type AuthorityId: AppCrypto<Self::Public, Self::Signature>;
      |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `offchaincb::Config::AuthorityId`
      ```
      
      where in my custom pallet i have:
      
      pallets/offchaincb/src/lib.rs
      
      ```
      ...
      
      use offchaincb::{
          crypto::{
              TestAuthId,
          },
      };
      
      ...
      
      parameter_types! {
      	pub const GracePeriod: BlockNumber = 1 * MINUTES;
      	pub const UnsignedInterval: BlockNumber = 1 * MINUTES;
              pub const UnsignedPriority: BlockNumber = 1 * MINUTES;
      }
      
      impl offchaincb::Config for Runtime {
          type AuthorityId = TestAuthId;
          type Call = Call;
          type Currency = Balances;
          type Event = Event;
          type GracePeriod = GracePeriod;
          type UnsignedInterval = UnsignedInterval;
          type UnsignedPriority = UnsignedPriority;
      }
      
      ...
      ```
      
      then i found another different off-chain workers Substrate Recipe demo from Jimmy Chu https://github.com/jimmychu0807/recipes/blob/master/pallets/ocw-demo/src/lib.rs#L73 which had an extra implementation for TestAuthId here https://github.com/jimmychu0807/recipes/blob/master/pallets/ocw-demo/src/lib.rs#L73, and when i added that it overcame the error.
      
      so i think this change should be included in the Substrate repository
      
      * Fix indentation
      
      * Fix formatting
      
      * Swap order
      9eb0a392
    • Bastian Köcher's avatar
      pallet-multisig: Improve opaque call handling (#10060) · 6cfb0c7e
      Bastian Köcher authored
      * pallet-multisig: Improve opaque call handling
      
      Before the opaque call was just a type redefinition of `Vec<u8>`. With metadata v14 that was
      breaking external tools, as they stopped looking at the type name. To improve the situation the
      `WrapperKeepOpaque` type is introduced that communicates to the outside the correct type info.
      
      * Cleanup
      
      * Fix benchmarks
      
      * FMT
      6cfb0c7e