Skip to content
  1. May 02, 2023
  3. Apr 28, 2023
  5. Apr 27, 2023
    • Liam Aharon's avatar
      ci: update check-runtime-migration fixme issues (#7141) · 1fbf37f9
      Liam Aharon authored 
      * update configs for check-runtime-migration tasks

* update fixme issues

* fix indentation
      1fbf37f9
    • Keith Yeung's avatar
      XCM: Implement a blocking barrier (#7098) · d20e3c11
      Keith Yeung authored 
      * Move XCM matcher to xcm-builder

* Use ProcessMessageError as the error type in MatchXcm and ShouldExecute

* Implement a blocking barrier

* Fixes

* Add benchmarking for force_suspension

* ".git/.scripts/commands/bench/bench.sh" runtime westend pallet_xcm

* ".git/.scripts/commands/bench/bench.sh" runtime rococo pallet_xcm

* ".git/.scripts/commands/bench/bench.sh" runtime kusama pallet_xcm

* ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm

* ".git/.scripts/commands/bench/bench.sh" runtime westend pallet_xcm

* ".git/.scripts/commands/bench/bench.sh" runtime rococo pallet_xcm

---------

Co-authored-by: command-bot <>
      d20e3c11
    • dependabot[bot]'s avatar
      Bump chevdor/srtool-actions from 0.6.0 to 0.7.0 (#7135) · 11256550
      dependabot[bot] authored 
      

Bumps [chevdor/srtool-actions](https://github.com/chevdor/srtool-actions) from 0.6.0 to 0.7.0.
- [Release notes](https://github.com/chevdor/srtool-actions/releases)
- [Commits](https://github.com/chevdor/srtool-actions/compare/v0.6.0...v0.7.0)

---
updated-dependencies:
- dependency-name: chevdor/srtool-actions
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: default avatardependabot[bot] <[email protected]>
Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      11256550
    • gupnik's avatar
      Clears Old Storage for Session pallet (#7132) · 9ed28d07
      gupnik authored 
      * Fixes migration for Session pallet

* Moves migration to polkadot

* Minor change

* Fixes test

* ".git/.scripts/commands/fmt/fmt.sh"

* Allow dead_code for test

* removes test

* Minor change

* Fixes build

* Import vec for try-runtime

* Addresses review comment

* ".git/.scripts/commands/fmt/fmt.sh"

* Addresses review comment

---------

Co-authored-by: command-bot <>
      9ed28d07
  7. Apr 26, 2023
  9. Apr 25, 2023
  11. Apr 24, 2023
    • Andrei Sandu's avatar
      Fix rolling session window (#7126) · 634b2f6a
      Andrei Sandu authored 
      * Use stored sessions 🤦



Signed-off-by: default avatarAndrei Sandu <[email protected]>

* Add test

Signed-off-by: default avatarAndrei Sandu <[email protected]>

* remove redundant

Signed-off-by: default avatarAndrei Sandu <[email protected]>

---------

Signed-off-by: default avatarAndrei Sandu <[email protected]>
      634b2f6a
    • Alexander Samusev's avatar
      [ci] Update buildah command and version (#7128) · 25d557f9
      Alexander Samusev authored
      25d557f9
    • Alejandro Martinez Andres's avatar
      Bump assigned_slots params (#6991) · 63d354ae
      Alejandro Martinez Andres authored
      63d354ae
    • Frederik Gartenmeister's avatar
      XCM: Remote account converter (#6662) · 3f3a0416
      Frederik Gartenmeister authored 
      * Draft remote account converter

* Tests and doc comments

* Adapt naming, tests fix

* Try with prefix in account

* Revert "Try with prefix in account"

This reverts commit 461759794cc9f59f768aad0e0899df6dc8cba747.

* Adapt code and test to review suggestions

* adapt to take into account parent in conversion

* fix: docs

* fix: try doc fix v2
      3f3a0416
    • Tsvetomir Dimitrov's avatar
      Rework `dispute-coordinator` to use `RuntimeInfo` for obtaining session... · 3f4ce632
      Tsvetomir Dimitrov authored 
      
Rework `dispute-coordinator` to use `RuntimeInfo` for obtaining session information instead of `RollingSessionWindow` (#6968)

* Pass `SessionInfo` directly to `CandidateEnvironment::new` otherwise it should be an async function

* Replace calls to `RollingSessionWindow` with `RuntimeInfo`

Adjust `dispute-coordinator` initialization to use `RuntimeInfo`

* Modify `dispute-coordinator` initialization

* Pass `Hash` to `process_on_chain_votes` so that `RuntimeInfo` calls can be made

Remove some fixmes

* Pass `Hash` to `handle_import_statements` to perform `RuntimeInfo` calls

* remove todo comments

* Remove `error` from `Initialized`

Rework new session handling code

* Remove db code which is no longer used

* Update stale comment and remove unneeded type specification

* Cache SessionInfo on startup

* Use `DISPUTE_WINDOW` from primitives

* Fix caching in `process_active_leaves_update`

* handle_import_statements: leaf_hash -> block_hash

* Restore `ensure_available_session_info`

* Don't interrupt `process_on_chain_votes` if SessionInfo can't be fetched

* Small style improvements in logging

* process_on_chain_votes: leaf_hash -> block_hash

* Restore `note_earliest_session` - it is required to prune disputes and votes

* Cache new sessions only when there is an actual session change

* Fix tests

* `CandidateEnvironment::new` gets `session_idx` and fetches SessionInfo by itself to avoid the invariant where the input SessionIndex and SessionInfo parameters don't match

* Fix handling of missing session info

* Move sessions caching in `handle_startup` and fix tests

* Load `relay_parent` from db in `handle_import_statements` instead of passing it as a parameter via two functions

* Don't do two db reads

* Fix the twisted logic in `handle_import_statements`

* fixup

* Small style fix

* Decrease log levels for caching errors to debug and fix a typo

* Update outdated comment

* Remove `ensure_available_session_info`

* Load relay parent from db in `process_on_chain_votes`

* Revert "Load relay parent from db in `process_on_chain_votes`"

This reverts commit 978ad4f223d517faa7a7fbad96e3f8de4fa17501.

* Keep track of highest seen session and last session cached without gaps.

* Apply suggestions from code review

Co-authored-by: default avatarordian <[email protected]>

* Handle session caching failure on startup correctly

* Update node/core/dispute-coordinator/src/initialized.rs

Co-authored-by: default avatarordian <[email protected]>

* Simplify session caching retries

* Update stale comment

* Fix lower bound calculation for session caching

---------

Co-authored-by: default avatarordian <[email protected]>
      3f4ce632
    • Keith Yeung's avatar
      Revert default proof size back to 64 KB (#7115) · a8d80532
      Keith Yeung authored 
      * Revert default proof size back to 64 KB

* Fix test expectations

* Enhance unit test

* cargo fmt

* Fix comment
      a8d80532
  13. Apr 21, 2023
  15. Apr 20, 2023
    • Marcin S.'s avatar
      PVF: Don't dispute on missing artifact (#7011) · 0940cdd1
      Marcin S. authored 
      * PVF: Don't dispute on missing artifact

A dispute should never be raised if the local cache doesn't provide a certain
artifact. You can not dispute based on this reason, as it is a local hardware
issue and not related to the candidate to check.

Design:

Currently we assume that if we prepared an artifact, it remains there on-disk
until we prune it, i.e. we never check again if it's still there.

We can change it so that instead of artifact-not-found triggering a dispute, we
retry once (like we do for AmbiguousWorkerDeath, except we don't dispute if it
still doesn't work). And when enqueuing an execute job, we check for the
artifact on-disk, and start preparation if not found.

Changes:

- [x] Integration test (should fail without the following changes)
- [x] Check if artifact exists when executing, prepare if not
- [x] Return an internal error when file is missing
- [x] Retry once on internal errors
- [x] Document design (update impl guide)

* Add some context to wasm error message (it is quite long)

* Fix impl guide

* Add check for missing/inaccessible file

* Add comment referencing Substrate issue

* Add test for retrying internal errors

---------

Co-authored-by: parity-processbot <>
      0940cdd1
    • Keith Yeung's avatar
      XCM: Properly set the pricing for the DMP router (#6843) · 023d4598
      Keith Yeung authored 
      

* Properly set the pricing for the DMP router

* Publicize price types

* Use FixedU128 instead of Percent

* Add sp-arithmetic as a dependency for rococo runtime

* Add sp-arithmetic as a dependency to all runtimes

* Remove duplicate import

* Add missing import

* Fix tests

* Create an appropriate QueueDownwardMessageError variant

* Recalculate delivery fee factor based on past queue sizes

* Remove unused error variant

* Fixes

* Fixes

* Remove unused imports

* Rewrite fee factor update mechanism

* Remove unused imports

* Fixes

* Update runtime/parachains/src/dmp.rs

Co-authored-by: default avatarSquirrel <[email protected]>

* Make DeliveryFeeFactor be a StorageMap keyed on ParaIds

* Fixes

* introduce limit for fee increase on dmp queue

* add message_size based fee factor to increment_fee_factor

* change message_size fee rate to correct value

* fix div by 0 error

* bind limit to variable

* fix message_size_factor and add DeliveryFeeFactor test

* add test for ExponentialPrice implementation

* make test formula based

* make delivery fee factor test formula based

* add max value test for DeliveryFeeFactor and move limit to config

* change threshold back to dynamic value and fix tests

* fmt

* suggested changes and fmt

* small stylistic change

* fmt

* change to tokenlocation

* small fixes

* fmt

* remove sp_arithmetic dependency

* Update runtime/parachains/src/dmp.rs

Co-authored-by: default avatarKian Paimani <[email protected]>

---------

Co-authored-by: default avatarSquirrel <[email protected]>
Co-authored-by: default avatarJust van Stam <[email protected]>
Co-authored-by: default avatarJust van Stam <[email protected]>
Co-authored-by: default avatarKian Paimani <[email protected]>
      023d4598
  17. Apr 19, 2023
  19. Apr 18, 2023
  21. Apr 17, 2023
  23. Apr 14, 2023
    • s0me0ne-unkn0wn's avatar
      Enable changing executor params through governance (#6934) · 0211c4b2
      s0me0ne-unkn0wn authored 
      * Add a pallet call to change executor params

* Use `OptionQuery`; Avoid runtime panic

* Move pending executor params to `configuration`

* Move `ExecutorParams` to `HostConfiguration` structure

* Add executor params to the v5 migration

* Add an `ExecutorParams` benchmark

* ".git/.scripts/commands/bench/bench.sh" runtime polkadot runtime_parachains::configuration

* Add to `WeightInfo`

* Add dummy weights to other networks

* ".git/.scripts/commands/bench/bench.sh" runtime kusama runtime_parachains::configuration

* ".git/.scripts/commands/bench/bench.sh" runtime rococo runtime_parachains::configuration

* ".git/.scripts/commands/bench/bench.sh" runtime westend runtime_parachains::configuration

* Use real weight

* Fix comment

---------

Co-authored-by: command-bot <>
      0211c4b2
    • Oliver Tale-Yazdi's avatar
      Fix try-runtime CI (#7078) · f0c50736
      Oliver Tale-Yazdi authored 
      

* Fix try-runtime CI

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

* Actually fix it

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

---------

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      f0c50736