Skip to content
Snippets Groups Projects
  1. Aug 30, 2024
    • Maksym H's avatar
      fix cmd bot PR context (#5531) · d34f6878
      Maksym H authored
      - restore update-ui.sh (accidentally removed with bunch of bash :sweat_smile:
      - fix empty context and pushing to dev branch (supporting forks)
      tested fork here: https://github.com/paritytech-stg/polkadot-sdk/pull/45
    • zjb0807's avatar
      Add more logs for AcceptanceCheckErr (#5513) · 9cdf3d99
      zjb0807 authored
      # Description
      
      The error message should be logged out when the check method returns an
      error.
      
      Because specific information is lost when `UmpAcceptanceCheckErr`,
      `ProcessedDownwardMessagesAcceptanceErr`, `HrmpWatermarkAcceptanceErr`,
      `OutboundHrmpAcceptanceErr` are converted to `AcceptanceCheckErr`, a log
      is added to each check.
      
      ## Integration
      
      ## Review Notes
      
      # Checklist
      
      * [ ] My PR includes a detailed description as outlined in the
      "Description" and its two subsections above.
      * [ ] My PR follows the [labeling requirements](
      
      https://github.com/paritytech/polkadot-sdk/blob/master/docs/contributor/CONTRIBUTING.md#Process
      ) of this project (at minimum one label for `T` required)
      * External contributors: ask maintainers to put the right label on your
      PR.
      * [ ] I have made corresponding changes to the documentation (if
      applicable)
      * [ ] I have added tests that prove my fix is effective or that my
      feature works (if applicable)
    • Andrei Sandu's avatar
      Polkadot Primitives v8 (#5525) · 09035a7d
      Andrei Sandu authored
      
      As Runtime release 1.3.0 includes all of the remaining staging
      primitives and APIs we can now release primitives version 8.
      No other changes other than renaming/moving done here.
      
      ---------
      
      Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>
    • Liu-Cheng Xu's avatar
      Simplify `SyncingEngine::new()` a bit (#5396) · 3d4a3355
      Liu-Cheng Xu authored
      
      Tiny changes to simplify the code:
      
      - Remove an unnecessary `collect`.
      - Reduce the code duplication a little bit.
      
      ---------
      
      Co-authored-by: default avatarAlexandru Vasile <60601340+lexnv@users.noreply.github.com>
    • Javyer's avatar
      Added `mac-setup` script (#5528) · 18e95040
      Javyer authored
      This is used for the steps that use the `macos` runner.
      
      It installs the Rust version that we are using in the [`forklift`
      image](https://github.com/paritytech/polkadot-sdk/blob/master/.github/env).
      
      To be used in #5386.
    • Alexandru Gheorghe's avatar
      Add support for memory-profiling on subsystem-bench (#5522) · c32160e3
      Alexandru Gheorghe authored
      
      Add support in subsystem-benchmarks to profile memory usage using the
      jemalloc builting profiler, this allows us to run each benchmark with
      profiling enabled and determine if the memory usage patters are in
      conformance with our expectations.
      
      ---------
      
      Signed-off-by: default avatarAlexandru Gheorghe <alexandru.gheorghe@parity.io>
  2. Aug 29, 2024
    • Alexander Samusev's avatar
      [ci] Move check-runtime-migration to GHA (#5519) · f7504cec
      Alexander Samusev authored
      PR moves rococo and wococo check-runtime-migration jobs to GHA
      
      cc https://github.com/paritytech/ci_cd/issues/1006
    • dharjeezy's avatar
      Add new try-state check invariant for nomination-pools (points >= stake) (#5465) · 61bfcb84
      dharjeezy authored
      
      closes https://github.com/paritytech/polkadot-sdk/issues/5448
      
      ---------
      
      Co-authored-by: default avatarGonçalo Pestana <g6pestana@gmail.com>
      Co-authored-by: default avatarAnkan <10196091+Ank4n@users.noreply.github.com>
    • ordian's avatar
      inclusion: bench `enact_candidate` weight (#5270) · ddd58c15
      ordian authored
      On top of #5082.
      
      ## Background
      
      Previously, before #3479, we would
      [include](https://github.com/paritytech/polkadot-sdk/blame/75074952/polkadot/runtime/parachains/src/builder.rs#L508C12-L508C44)
      the cost enacting the candidate into the cost of processing a single
      bitfield.
      [Now](https://github.com/paritytech/polkadot-sdk/blame/dd48544a/polkadot/runtime/parachains/src/builder.rs#L529)
      it is different, although the benchmarks seems to be not-up-to date.
      Including the cost of enacting a candidate into a processing a single
      bitfield cost was incorrect, since we multiple that by the number of
      bitfields we have. Instead, we should separate calculate the cost of
      processing a single bitfield without enactment, and multiple the cost of
      enactment by the actual number of processed candidates (which is limited
      by the number cores, not validators).
      
      ## Bench
      
      Previously, the weight of `enact_candidate` was calculated manually
      (without a benchmark) and then neglected:
      https://github.com/paritytech/polkadot-sdk/blob/dd48544a
      
      /polkadot/runtime/parachains/src/inclusion/mod.rs#L584
      
      In this PR, we have a benchmark for it and it's based on the number of
      ump and sent hrmp messages as well as whether the candidate has a
      runtime upgrade (new_validation_code).
      The differences from the previous attempt
      https://github.com/paritytech/polkadot/pull/6929 are that
      * we don't include the cost of enactment into the cost of processing a
      backed candidate.
      The reason for it is that enactment happens not in the same block as
      backing (typically the next one), since we process bitfields before
      backing votes.
      * we don't take into account the size of the runtime upgrade, the
      benchmark weight doesn't seem to depend much on it, but rather whether
      there was one or not.
      
      Similarly to the previous attempt, we don't account for dmp messages
      (fixed cost). Also we don't account properly for received hrmp messages
      (hrmp_watermark) because the cost of it depends on the runtime state and
      can't be statically deduced in the benchmark (unless we pass the
      information about channels as benchmark u32 arguments).
      
      The total weight cost of processing a parainherent now includes the cost
      of enactment of each candidate, but we don't do filtering based on that
      (because we enact after processing bitfields and making other changes to
      the storage).
      
      ## Numbers
      
      ```
      Reads = 7 + (0 * u) + (3 * h) + (8 * c)
      Writes = 10 + (1 * u) + (3 * h) + (7 * c)
      ```
      In addition, there is a fixed cost of a few of ms (!) per candidate. 
      
      This might result a full block slightly overflowing its weight with 200
      enacted candidates, which in turn could prevent non-mandatory
      transactions from being included in a block.
      
      Given our modest limits on max ump and hrmp messages:
      ```
        maxUpwardMessageNumPerCandidate: 16
        hrmpMaxMessageNumPerCandidate: 10
      ```
      and the fact that runtime upgrades are can't happen very frequently
      (`validation_upgrade_cooldown`), we might only go over the limits in
      case of many disputes.
      
      TODOs:
      - [x] Fix the overweight test
      - [x] Generate the weights for Westend and Rococo
      - [x] PRDoc
      
      ---------
      
      Co-authored-by: command-bot <>
      Co-authored-by: default avatarAlin Dima <alin@parity.io>
    • Oliver Tale-Yazdi's avatar
      [CI] Fixup backport bot (#5517) · ba48e4b8
      Oliver Tale-Yazdi authored
      Changes:
      - Backport bot should just commit merge conflicts instead of failing.
    • Lech Głowiak's avatar
      Add an utility function to get the first timestamp of a slot (#5316) · 9374643b
      Lech Głowiak authored
      
      # Description
      
      Add `starting_timestamp` function for `Slot` type.
      
      ## Integration
      
      This is an addition of public function to a type, so integration should
      be seamless for idiomatic use of Rust.
      
      ## Review Notes
      
      Since `Slot` is just a slot number, the it's starting timestamp depends
      on `SlotDuration` which is a parameter to the added function. This
      function can be seen as dual to existing `fn from_timestamp`.
      Because there is a potential for overflow, the return type is `Option`.
      
      Q1: should I introduce tests for in this crate and add cases for both
      case: overflow (`None`) and no overflow (`Some`)?
      
      Q2: How can I add labels? IMO they should be `T0-node` and `D0-easy` but
      I cannot add them using GH interface.
      
      # Checklist
      
      * [x] My PR includes a detailed description as outlined in the
      "Description" and its two subsections above.
      * [ ] My PR follows the [labeling requirements](CONTRIBUTING.md#Process)
      of this project (at minimum one label for `T`
        required)
      * External contributors: ask maintainers to put the right label on your
      PR.
      * [ ] I have made corresponding changes to the documentation (if
      applicable)
      * [ ] I have added tests that prove my fix is effective or that my
      feature works (if applicable)
      
      ---------
      
      Co-authored-by: default avatarSquirrel <giles.cope@iohk.io>
      Co-authored-by: default avatarDavide Galassi <davxy@datawok.net>
    • Alexander Samusev's avatar
      [ci] Migrate checks to GHA (#5511) · a67d6232
      Alexander Samusev authored
      
      PR migrates jobs `quick-benchmarks`, `cargo-clippy`, `check-try-runtime`
      and `check-core-crypto-features` from Gitlab to GitHub
      
      cc https://github.com/paritytech/ci_cd/issues/1006
      
      ---------
      
      Co-authored-by: default avatarMaksym H <1177472+mordamax@users.noreply.github.com>
    • ordian's avatar
      short-term fix for para inherent weight overestimation (#5082) · cc7ebe05
      ordian authored
      closes #849
      
      ## Context
      
      For the background on this and the long-term fix, see
      https://github.com/paritytech/polkadot-sdk/issues/849#issuecomment-2247895862.
      
      ## Changes
      
      * The weigh files are renamed from `runtime_(parachains|common).*` to
      `polkadot_runtime_(parachains|common).*`. The reason for it is the
      renaming introduced in #4633. The new weight command and files are
      generated now include `polkadot_` prefix.
      * The WeightInfo for `paras_inherent` now includes `enter_empty` which
      calculates the cost of processing an empty parachains inherent. This
      cost is subtracted dynamically when calculating other weights (so the
      other weights remain the same)
      
      ## Benefits
      
      See
      https://github.com/paritytech/polkadot-sdk/issues/849#issuecomment-2247895862,
      but TL;DR is that we are not blocked on weights for scaling the number
      of validators and cores further.
      
      Resolved questions:
      - [x] why new benchmarks for westend are doing fewer db IOPS?
      Is it due polka...
  3. Aug 28, 2024
    • Oliver Tale-Yazdi's avatar
      CI: Add backporting bot (#4795) · 56201964
      Oliver Tale-Yazdi authored
      
      Adds a bot that automatically opens MRs into the `stable2407` branch
      when the `A4-needs-backport` label is applied to a merged MR.
      
      TODO:
      - [x] ~~Settle on label vs error message trade-off~~ (resolved)
      
      docs:
      
      # Backporting
      
      This document explains how to backport a merged PR from `master` to one
      of the `stable*` branches. Backports should only be used to fix bugs or
      security issues - never to introduce new features.
      
      ## Steps
      
      1. Fix a bug through a PR that targets `master`.
      2. Add label `A4-needs-backport` to the PR.
      4. Merge the PR into `master`.
      5. Wait for the bot to open the backport PR.
      6. Ensure the change is audited or does not need audit.
      7. Merge the backport PR. 
      
      The label can also be added after the PR is merged.
      
      ## Example
      
      For example here where the dev triggered the process by adding the label
      after merging:
      
      
      ![backport-ex2](https://github.com/user-attachments/assets/c7b686db-a0fe-41f1-9d6f-959a5a7097b1)
      
      ---------
      
      Signed-off-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
    • Tarek Mohamed Abdalla's avatar
      Fix benchmark failures when using `insecure_zero_ed` flag (#5354) · 1c4141ab
      Tarek Mohamed Abdalla authored
      Currently, when the pallet is compiled with the `insecure_zero_ed flag`,
      benchmarks fail because the minimum balance is set to zero.
      
      The PR aims to resolve this issue by implementing a placeholder value
      for the minimum balance when the `insecure_zero_ed` flag is active. it
      ensures that benchmarks run successfully regardless of whether this flag
      is used or not
    • Maksym H's avatar
      Command bot GHA v2 - /cmd <cmd> (#5457) · 8e0cefc8
      Maksym H authored
      Closes https://github.com/paritytech/product-engineering/issues/93
      
      - Deprecates old command bot bash scripts. New cmd implementation is
      re-written on Python
      - Deprecates `sync` command, which was never used
      - Benchmarks:
      - Uses new
      [frame-omni-bencher](https://crates.io/crates/frame-omni-bencher)
      - Simplifies usage to only providing a runtime and/or pallet name (even
      multiple runtimes or pallets)
      - Supports sub-modules (like `/cmd bench --runtime dev --pallet
      pallet_asset_conversion_ops`)
      - Can regenerate all weights with one command (substrate, polkadot,
      cumulus) for provided pallet(s) name
      - Adds [subweight](https://crates.io/crates/subweight-core) diff as a
      result of bench command
    • Pankaj's avatar
      Remove pallet::getter usage from treasury (#4962) · 4096ad7f
      Pankaj authored
      
      ISSUE
      Link to the issue:
      https://github.com/paritytech/polkadot-sdk/issues/3326
      
      Deliverables
      
      [Deprecation] remove pallet::getter usage from pallet-treasury
      
      ---------
      
      Co-authored-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
      Co-authored-by: default avatarDónal Murray <donal.murray@parity.io>
      Co-authored-by: default avatarDónal Murray <donalm@seadanda.dev>
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
    • dependabot[bot]'s avatar
      Bump blake2b_simd from 1.0.1 to 1.0.2 (#5404) · 94237181
      dependabot[bot] authored
      
      Bumps [blake2b_simd](https://github.com/oconnor663/blake2_simd) from
      1.0.1 to 1.0.2.
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/oconnor663/blake2_simd/commit/1dfcf325200cf281d9313ae79734c828d914d241"><code>1dfcf32</code></a>
      version 1.0.2</li>
      <li><a
      href="https://github.com/oconnor663/blake2_simd/commit/b66d6b5124e7568bbb92f8a1f22e043ac8cded25"><code>b66d6b5</code></a>
      Bump constant_time_eq to 0.3 and MSRV to 1.66</li>
      <li><a
      href="https://github.com/oconnor663/blake2_simd/commit/d9ce189cb98e00b0a0653d8a9586ff12e5774202"><code>d9ce189</code></a>
      stop using MIPS for big-endian testing</li>
      <li><a
      href="https://github.com/oconnor663/blake2_simd/commit/9d338b55992a5e6a0411e2da7153ec654f70b213"><code>9d338b5</code></a>
      use <code>avoid-dev-deps</code> for the MSRV test</li>
      <li><a
      href="https://github.com/oconnor663/blake2_simd/commit/c347f493365a82bc4472a05609c68a1152439b44"><code>c347f49</code></a>
      update the assert_cmd test dependency to v2.0.8</li>
      <li>See full diff in <a
      href="https://github.com/oconnor663/blake2_simd/compare/1.0.1...1.0.2">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      
      [![Dependabot compatibility
      score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=blake2b_simd&package-manager=cargo&previous-version=1.0.1&new-version=1.0.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
      
      Dependabot will resolve any conflicts with this PR as long as you don't
      alter it yourself. You can also trigger a rebase manually by commenting
      `@dependabot rebase`.
      
      [//]: # (dependabot-automerge-start)
      [//]: # (dependabot-automerge-end)
      
      ---
      
      <details>
      <summary>Dependabot commands and options</summary>
      <br />
      
      You can trigger Dependabot actions by commenting on this PR:
      - `@dependabot rebase` will rebase this PR
      - `@dependabot recreate` will recreate this PR, overwriting any edits
      that have been made to it
      - `@dependabot merge` will merge this PR after your CI passes on it
      - `@dependabot squash and merge` will squash and merge this PR after
      your CI passes on it
      - `@dependabot cancel merge` will cancel a previously requested merge
      and block automerging
      - `@dependabot reopen` will reopen this PR if it is closed
      - `@dependabot close` will close this PR and stop Dependabot recreating
      it. You can achieve the same result by closing it manually
      - `@dependabot show <dependency name> ignore conditions` will show all
      of the ignore conditions of the specified dependency
      - `@dependabot ignore this major version` will close this PR and stop
      Dependabot creating any more for this major version (unless you reopen
      the PR or upgrade to it yourself)
      - `@dependabot ignore this minor version` will close this PR and stop
      Dependabot creating any more for this minor version (unless you reopen
      the PR or upgrade to it yourself)
      - `@dependabot ignore this dependency` will close this PR and stop
      Dependabot creating any more for this dependency (unless you reopen the
      PR or upgrade to it yourself)
      
      
      </details>
      
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    • dependabot[bot]'s avatar
      Bump rustversion from 1.0.14 to 1.0.17 (#5405) · f7e0ecc5
      dependabot[bot] authored
      
      Bumps [rustversion](https://github.com/dtolnay/rustversion) from 1.0.14
      to 1.0.17.
      <details>
      <summary>Release notes</summary>
      <p><em>Sourced from <a
      href="https://github.com/dtolnay/rustversion/releases">rustversion's
      releases</a>.</em></p>
      <blockquote>
      <h2>1.0.17</h2>
      <ul>
      <li>Support Windows builds that have OUT_DIR prefixed with
      <code>\\?\</code> (<a
      href="https://redirect.github.com/dtolnay/rustversion/issues/51">#51</a>)</li>
      </ul>
      <h2>1.0.16</h2>
      <ul>
      <li>Resolve unexpected_cfgs warning (<a
      href="https://redirect.github.com/dtolnay/rustversion/issues/48">#48</a>)</li>
      </ul>
      <h2>1.0.15</h2>
      <ul>
      <li>Recognize $RUSTC_WRAPPER environment variable (<a
      href="https://redirect.github.com/dtolnay/rustversion/issues/47">#47</a>)</li>
      </ul>
      </blockquote>
      </details>
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/dtolnay/rustversion/commit/adb11fa32295a5d3df7b742e545f4e9b776f9bb3"><code>adb11fa</code></a>
      Release 1.0.17</li>
      <li><a
      href="https://github.com/dtolnay/rustversion/commit/875982000ea11f59a67564bf34c6f3255935b6e2"><code>8759820</code></a>
      Merge pull request <a
      href="https://redirect.github.com/dtolnay/rustversion/issues/51">#51</a>
      from dtolnay/windows</li>
      <li><a
      href="https://github.com/dtolnay/rustversion/commit/cfafcd5906e6020ae67014e33a84446824301c95"><code>cfafcd5</code></a>
      Support OUT_DIR located in \?\ path on Windows</li>
      <li><a
      href="https://github.com/dtolnay/rustversion/commit/c7bc274d96fbde0fe3b3fd5a4a9ea1e0215b0ddb"><code>c7bc274</code></a>
      Release 1.0.16</li>
      <li><a
      href="https://github.com/dtolnay/rustversion/commit/746bf5af0dc5423574982ba2f479190b643c98fe"><code>746bf5a</code></a>
      Merge pull request <a
      href="https://redirect.github.com/dtolnay/rustversion/issues/48">#48</a>
      from dtolnay/checkcfg</li>
      <li><a
      href="https://github.com/dtolnay/rustversion/commit/84f01fa8d731c51842848a4e4d27750cefd879e0"><code>84f01fa</code></a>
      Resolve unexpected_cfgs warning</li>
      <li><a
      href="https://github.com/dtolnay/rustversion/commit/70ca5ad8a2aba79053be803a4e70156b46e44028"><code>70ca5ad</code></a>
      Release 1.0.15</li>
      <li><a
      href="https://github.com/dtolnay/rustversion/commit/0fa74f583b1fff92ed6f48acad6509428f44ed1a"><code>0fa74f5</code></a>
      Merge pull request <a
      href="https://redirect.github.com/dtolnay/rustversion/issues/47">#47</a>
      from dtolnay/rustcwrapper</li>
      <li><a
      href="https://github.com/dtolnay/rustversion/commit/51f46e2d2281dce75a8e4d46c0ed55f2ae3c4e33"><code>51f46e2</code></a>
      Apply RUSTC_WRAPPER</li>
      <li><a
      href="https://github.com/dtolnay/rustversion/commit/df7e51d0f01e06b2212c96f26cd04af5c59e1e39"><code>df7e51d</code></a>
      Explicitly install a Rust toolchain for cargo-outdated job</li>
      <li>Additional commits viewable in <a
      href="https://github.com/dtolnay/rustversion/compare/1.0.14...1.0.17">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      
      [![Dependabot compatibility
      score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=rustversion&package-manager=cargo&previous-version=1.0.14&new-version=1.0.17)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
      
      Dependabot will resolve any conflicts with this PR as long as you don't
      alter it yourself. You can also trigger a rebase manually by commenting
      `@dependabot rebase`.
      
      [//]: # (dependabot-automerge-start)
      [//]: # (dependabot-automerge-end)
      
      ---
      
      <details>
      <summary>Dependabot commands and options</summary>
      <br />
      
      You can trigger Dependabot actions by commenting on this PR:
      - `@dependabot rebase` will rebase this PR
      - `@dependabot recreate` will recreate this PR, overwriting any edits
      that have been made to it
      - `@dependabot merge` will merge this PR after your CI passes on it
      - `@dependabot squash and merge` will squash and merge this PR after
      your CI passes on it
      - `@dependabot cancel merge` will cancel a previously requested merge
      and block automerging
      - `@dependabot reopen` will reopen this PR if it is closed
      - `@dependabot close` will close this PR and stop Dependabot recreating
      it. You can achieve the same result by closing it manually
      - `@dependabot show <dependency name> ignore conditions` will show all
      of the ignore conditions of the specified dependency
      - `@dependabot ignore this major version` will close this PR and stop
      Dependabot creating any more for this major version (unless you reopen
      the PR or upgrade to it yourself)
      - `@dependabot ignore this minor version` will close this PR and stop
      Dependabot creating any more for this minor version (unless you reopen
      the PR or upgrade to it yourself)
      - `@dependabot ignore this dependency` will close this PR and stop
      Dependabot creating any more for this dependency (unless you reopen the
      PR or upgrade to it yourself)
      
      
      </details>
      
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    • Serban Iorga's avatar
      Bridge zombienet tests: remove old command (#5434) · edd6f717
      Serban Iorga authored
      Related to: https://github.com/paritytech/polkadot-sdk/issues/3176
      
      This PR:
      - migrates test 0003 to the new bridges zombienet tests command
      **This test didn't work before and it still doesn't work. It was added
      at a time when we couldn't run it because we didn't have the scafolding.
      It needs to be fixed. For the moment we keep it in the repo as it is
      since the idea has value. But we don't run it in the CI. We can also
      decide to remove it in the future**
      - removes the old command for running bridge zombienet tests
      - updates the README
    • Serban Iorga's avatar
      polkadot-parachain: Add omni-node variant with u64 block number (#5269) · c4ced11f
      Serban Iorga authored
      Related to https://github.com/paritytech/polkadot-sdk/issues/4787
      
      The main changes in this PR are the following:
      - making the NodeSpec logic generic on the Block type
      - adding an omni-node variant with u64 block number
      
      Apart from this, the PR also moves some of the logic in `service.rs` to
      the `common` subfolder
      
      The omni-node variant with u64 block number is not used yet. We have to
      either expose the option in the CLI or to read the block number from the
      chain spec somehow. Will do it in a future PR.
    • thiolliere's avatar
      Refactor verbose test (#5506) · 97fa922c
      thiolliere authored
      A test is triggering a log error. But is correct and successful. This is
      a refactor without triggering the log error.
    • PG Herveou's avatar
    • A Ahmad's avatar
      IBP Coretime Polkadot bootnodes (#5499) · ef3a0d8f
      A Ahmad authored
      ✄
      -----------------------------------------------------------------------------
      
      Thank you for your Pull Request! :pray:
      
       Please make sure it follows the
      contribution guidelines outlined in [this
      
      document](https://github.com/paritytech/polkadot-sdk/blob/master/docs/contributor/CONTRIBUTING.md)
      and fill out the
      sections below. Once you're ready to submit your PR for review, please
      delete this section and leave only the text under
      the "Description" heading.
      
      # Description
      
      *A concise description of what your PR is doing, and what potential
      issue it is solving. Use [Github semantic
      
      linking](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)
      to link the PR to an issue that must be closed once this is merged.*
      
      ## Integration
      
      *In depth notes about how this PR should be integrated by downstream
      projects. This part is mandatory, and should be
      reviewed by reviewers, if the PR does NOT have the `R0-Silent` label. In
      case of a `R0-Silent`, it can be ignored.*
      
      ## Review Notes
      
      *In depth notes about the **implementation** details of your PR. This
      should be the main guide for reviewers to
      understand your approach and effectively review it. If too long, use
      
      [`<details>`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details)*.
      
      *Imagine that someone who is depending on the old code wants to
      integrate your new code and the only information that
      they get is this section. It helps to include example usage and default
      value here, with a `diff` code-block to show
      possibly integration.*
      
      *Include your leftover TODOs, if any, here.*
      
      # Checklist
      
      * [ ] My PR includes a detailed description as outlined in the
      "Description" and its two subsections above.
      * [ ] My PR follows the [labeling requirements](
      
      https://github.com/paritytech/polkadot-sdk/blob/master/docs/contributor/CONTRIBUTING.md#Process
      ) of this project (at minimum one label for `T` required)
      * External contributors: ask maintainers to put the right label on your
      PR.
      * [ ] I have made corresponding changes to the documentation (if
      applicable)
      * [ ] I have added tests that prove my fix is effective or that my
      feature works (if applicable)
      
      You can remove the "Checklist" section once all have been checked. Thank
      you for your contribution!
      
      ✄
      -----------------------------------------------------------------------------
      
      Co-authored-by: default avatarDónal Murray <donal.murray@parity.io>
    • Niklas Adolfsson's avatar
      rpc server: listen to `ipv6 socket` if available and... · 09254eb9
      Niklas Adolfsson authored
      rpc server: listen to `ipv6 socket` if available and `--experimental-rpc-endpoint` CLI option (#4792)
      
      Close https://github.com/paritytech/polkadot-sdk/issues/3488,
      https://github.com/paritytech/polkadot-sdk/issues/4331
      
      This changes/adds the following:
      
      1. The default setting is that substrate starts a rpc server that
      listens to localhost both Ipv4 and Ipv6 on the same port. Ipv6 is
      allowed to fail because some platforms may not support it
      2. A new RPC CLI option `--experimental-rpc-endpoint` which allow to
      configure arbitrary listen addresses including the port, if this is
      enabled no other interfaces are enabled.
      3. If the local addr is not found for any of the sockets the server is
      not started throws an error.
      4. Remove the deny_unsafe from the RPC implementations instead this is
      an extension to allow different polices for different interfaces/sockets
      such one may enable unsafe on local interface and safe on only the
      external interface.
      
      So for instance in this PR it's now possible to start up three RPC...
    • Alexandru Gheorghe's avatar
      Update approval-voting-regression-bench (#5504) · f0fd083e
      Alexandru Gheorghe authored
      
      The accepted divergence rate of 1/1000 is excessive and leads to false
      positives especially after
      https://github.com/paritytech/polkadot-sdk/pull/4772 and
      https://github.com/paritytech/polkadot-sdk/pull/5042, so let's increase
      it to 1/100 since we do have some randomness in the system and there is
      no point in being that strict.
      
      Fixes: https://github.com/paritytech/polkadot-sdk/issues/5463
      
      ---------
      
      Signed-off-by: default avatarAlexandru Gheorghe <alexandru.gheorghe@parity.io>
    • Arsham Teymouri's avatar
      change try-runtime rpc domains (#5443) · f4be48cf
      Arsham Teymouri authored
      
      as part of paritytech/devops/3502, try-runtime nodes were migrated to a
      new provider with a new domain address. The PR fixes all the references
      to try-runtime nodes on rococo, westend, kusama and polkadot networks.
      
      ---------
      
      Co-authored-by: default avatarArshamTeymouri <ArshamTeymouri@users.noreply.github.com>
      Co-authored-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
      Co-authored-by: default avatarNiklas Adolfsson <niklasadolfsson1@gmail.com>
    • Serban Iorga's avatar
      polkadot-parachain-bin: Remove contracts parachain (#5471) · 38fce088
      Serban Iorga authored
      Related to: https://github.com/paritytech/polkadot-sdk/issues/5210
      
      Follow-up for https://github.com/paritytech/polkadot-sdk/pull/5288, as
      per this comment:
      https://github.com/paritytech/polkadot-sdk/pull/5288#discussion_r1711157476
      
      I hope I understood this correctly.
  4. Aug 27, 2024
    • s0me0ne-unkn0wn's avatar
      Add feature to allow Aura collator to use full PoV size (#5393) · f90bfa6a
      s0me0ne-unkn0wn authored
      
      This PR introduces a feature that allows to optionally enable using the
      full PoV size.
      
      Technically, we're ready to enable it by default, but as corresponding
      runtime changes have not been propagated to the system parachain
      runtimes yet, doing so could put them at risk. On the other hand, there
      are teams that could benefit from it right now, and it makes no sense
      for them to wait for the fellowship release and everything.
      
      ---------
      
      Co-authored-by: default avatarAndrei Sandu <54316454+sandreim@users.noreply.github.com>
    • Frazz's avatar
      Adding stkd bootnodes (#5470) · 7a2c5375
      Frazz authored
      Opening this PR to add our bootnodes for the IBP. These nodes are
      located in Santiago Chile, we own and manage the underlying hardware. If
      you need any more information please let me know.
      
      
      Commands to test:
      
      ```
      ./polkadot --tmp --name "testing-bootnode" --chain kusama --reserved-only --reserved-nodes "/dns/kusama.bootnode.stkd.io/tcp/30633/wss/p2p/12D3KooWJHhnF64TXSmyxNkhPkXAHtYNRy86LuvGQu1LTi5vrJCL" --no-hardware-benchmarks
      
      ./polkadot --tmp --name "testing-bootnode" --chain paseo --reserved-only --reserved-nodes "/dns/paseo.bootnode.stkd.io/tcp/30633/wss/p2p/12D3KooWMdND5nwfCs5M2rfp5kyRo41BGDgD8V67rVRaB3acgZ53" --no-hardware-benchmarks
      
      ./polkadot --tmp --name "testing-bootnode" --chain polkadot --reserved-only --reserved-nodes "/dns/polkadot.bootnode.stkd.io/tcp/30633/wss/p2p/12D3KooWEymrFRHz6c17YP3FAyd8kXS5gMRLgkW4U77ZJD2ZNCLZ" --no-hardware-benchmarks
      
      ./polkadot --tmp --name "testing-bootnode" --chain westend --reserved-only --reserved-nodes "/dns/westend.bootnode.stkd.io/tcp/30633/wss/p2p/12D3KooWHaQKkJiTPqeNgqDcW7dfYgJxYwT8YqJMtTkueSu6378V" --no-hardware-benchmarks
      ```
    • Parth's avatar
      Make `PendingConfigs` storage item public (#5467) · 0d7becf2
      Parth authored
      
      ## Description
      This PR changes `PendingConfigs` storage item's visibility from crate to
      public. This enable us to read it in our runtime.
      
      ---------
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
    • Oliver Tale-Yazdi's avatar
      frame-omni-bencher maintenance (#5466) · 7e7c3345
      Oliver Tale-Yazdi authored
      
      Changes:
      - Set default level to `Info` again. Seems like a dependency update set
      it to something higher.
      - Fix docs to not use `--locked` since we rely on dependency bumps via
      cargo.
      - Add README with rust docs.
      - Fix bug where the node ignored `--heap-pages` argument.
      
      You can test the `--heap-pages` bug by running this command on master
      and then on this branch. Note that it should fail because of the very
      low heap pages arg:
      `cargo run --release --bin polkadot --features=runtime-benchmarks --
      benchmark pallet --chain=dev --steps=10 --repeat=30
      --wasm-execution=compiled --heap-pages=8 --pallet=frame-system
      --extrinsic="*"`
      
      ---------
      
      Signed-off-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
      Co-authored-by: default avatarggwpez <ggwpez@users.noreply.github.com>
    • dependabot[bot]'s avatar
      Bump the ci_dependencies group across 1 directory with 2 updates (#5401) · 33010098
      dependabot[bot] authored
      
      Bumps the ci_dependencies group with 2 updates in the / directory:
      [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action)
      and
      [docker/build-push-action](https://github.com/docker/build-push-action).
      
      Updates `docker/setup-buildx-action` from 3.5.0 to 3.6.1
      <details>
      <summary>Release notes</summary>
      <p><em>Sourced from <a
      href="https://github.com/docker/setup-buildx-action/releases">docker/setup-buildx-action's
      releases</a>.</em></p>
      <blockquote>
      <h2>v3.6.1</h2>
      <ul>
      <li>Check for malformed docker context by <a
      href="https://github.com/crazy-max"><code>@​crazy-max</code></a> in <a
      href="https://redirect.github.com/docker/setup-buildx-action/pull/347">docker/setup-buildx-action#347</a></li>
      </ul>
      <p><strong>Full Changelog</strong>: <a
      href="https://github.com/docker/setup-buildx-action/compare/v3.6.0...v3.6.1">https://github.com/docker/setup-buildx-action/compare/v3.6.0...v3.6.1</a></p>
      <h2>v3.6.0</h2>
      <ul>
      <li>Create temp docker context if default one has TLS data loaded before
      creating a container builder by <a
      href="https://github.com/crazy-max"><code>@​crazy-max</code></a> in <a
      href="https://redirect.github.com/docker/setup-buildx-action/pull/341">docker/setup-buildx-action#341</a></li>
      </ul>
      <p><strong>Full Changelog</strong>: <a
      href="https://github.com/docker/setup-buildx-action/compare/v3.5.0...v3.6.0">https://github.com/docker/setup-buildx-action/compare/v3.5.0...v3.6.0</a></p>
      </blockquote>
      </details>
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/docker/setup-buildx-action/commit/988b5a0280414f521da01fcc63a27aeeb4b104db"><code>988b5a0</code></a>
      Merge pull request <a
      href="https://redirect.github.com/docker/setup-buildx-action/issues/347">#347</a>
      from crazy-max/skip-malformed-context</li>
      <li><a
      href="https://github.com/docker/setup-buildx-action/commit/2c215620b8bfc319fa4c45228e004e292677fd33"><code>2c21562</code></a>
      chore: update generated content</li>
      <li><a
      href="https://github.com/docker/setup-buildx-action/commit/3382292cd51ea1cda5852caf2e65d8e7b3f1c2ca"><code>3382292</code></a>
      check for malformed docker context</li>
      <li><a
      href="https://github.com/docker/setup-buildx-action/commit/3d68780484996aa9d417bb9016193885cdf1f299"><code>3d68780</code></a>
      Merge pull request <a
      href="https://redirect.github.com/docker/setup-buildx-action/issues/341">#341</a>
      from crazy-max/docker-context-tls</li>
      <li><a
      href="https://github.com/docker/setup-buildx-action/commit/d069e98648dcd5f11d3f726983a778dcf30aeca0"><code>d069e98</code></a>
      chore: update generated content</li>
      <li><a
      href="https://github.com/docker/setup-buildx-action/commit/8b850f86dc46ba7eb11e02c7d3db66aeb2b0f022"><code>8b850f8</code></a>
      create docker context if default one has TLS data loaded</li>
      <li>See full diff in <a
      href="https://github.com/docker/setup-buildx-action/compare/aa33708b10e362ff993539393ff100fa93ed6a27...988b5a0280414f521da01fcc63a27aeeb4b104db">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      Updates `docker/build-push-action` from 6.5.0 to 6.7.0
      <details>
      <summary>Release notes</summary>
      <p><em>Sourced from <a
      href="https://github.com/docker/build-push-action/releases">docker/build-push-action's
      releases</a>.</em></p>
      <blockquote>
      <h2>v6.7.0</h2>
      <ul>
      <li>Print info message for build summary support checks by <a
      href="https://github.com/crazy-max"><code>@​crazy-max</code></a> in <a
      href="https://redirect.github.com/docker/build-push-action/pull/1211">docker/build-push-action#1211</a></li>
      </ul>
      <p><strong>Full Changelog</strong>: <a
      href="https://github.com/docker/build-push-action/compare/v6.6.1...v6.7.0">https://github.com/docker/build-push-action/compare/v6.6.1...v6.7.0</a></p>
      <h2>v6.6.1</h2>
      <ul>
      <li>Bump <code>@​docker/actions-toolkit</code> from 0.37.0 to 0.37.1 in
      <a
      href="https://redirect.github.com/docker/build-push-action/pull/1205">docker/build-push-action#1205</a></li>
      </ul>
      <p><strong>Full Changelog</strong>: <a
      href="https://github.com/docker/build-push-action/compare/v6.6.0...v6.6.1">https://github.com/docker/build-push-action/compare/v6.6.0...v6.6.1</a></p>
      <h2>v6.6.0</h2>
      <ul>
      <li>Generate GitHub annotations for <a
      href="https://docs.docker.com/build/checks/">build checks</a> by <a
      href="https://github.com/crazy-max"><code>@​crazy-max</code></a> in <a
      href="https://redirect.github.com/docker/build-push-action/pull/1197">docker/build-push-action#1197</a></li>
      <li>Bump <code>@​docker/actions-toolkit</code> from 0.35.0 to 0.37.0 in
      <a
      href="https://redirect.github.com/docker/build-push-action/pull/1196">docker/build-push-action#1196</a>
      <a
      href="https://redirect.github.com/docker/build-push-action/pull/1198">docker/build-push-action#1198</a></li>
      </ul>
      <p><strong>Full Changelog</strong>: <a
      href="https://github.com/docker/build-push-action/compare/v6.5.0...v6.6.0">https://github.com/docker/build-push-action/compare/v6.5.0...v6.6.0</a></p>
      </blockquote>
      </details>
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/docker/build-push-action/commit/5cd11c3a4ced054e52742c5fd54dca954e0edd85"><code>5cd11c3</code></a>
      Merge pull request <a
      href="https://redirect.github.com/docker/build-push-action/issues/1211">#1211</a>
      from crazy-max/summary-info-message</li>
      <li><a
      href="https://github.com/docker/build-push-action/commit/0aba704831628413787ada4cf0e8f04d977f1d21"><code>0aba704</code></a>
      chore: update generated content</li>
      <li><a
      href="https://github.com/docker/build-push-action/commit/23c657a01f105567f668c7596ce8e5a038da2555"><code>23c657a</code></a>
      print info message for build summary support checks</li>
      <li><a
      href="https://github.com/docker/build-push-action/commit/16ebe778df0e7752d2cfcbd924afdbbd89c1a755"><code>16ebe77</code></a>
      Merge pull request <a
      href="https://redirect.github.com/docker/build-push-action/issues/1205">#1205</a>
      from docker/dependabot/npm_and_yarn/docker/actions-t...</li>
      <li><a
      href="https://github.com/docker/build-push-action/commit/646a62b4f2189bfb0b46bfa1676692e7bff6e4d7"><code>646a62b</code></a>
      chore: update generated content</li>
      <li><a
      href="https://github.com/docker/build-push-action/commit/d92ab1347f14b597b6d4a546737ec663aef4a184"><code>d92ab13</code></a>
      chore(deps): Bump <code>@​docker/actions-toolkit</code> from 0.37.0 to
      0.37.1</li>
      <li><a
      href="https://github.com/docker/build-push-action/commit/4f7cdeb0f05278b464e71357394bf2c61f94138e"><code>4f7cdeb</code></a>
      Merge pull request <a
      href="https://redirect.github.com/docker/build-push-action/issues/1198">#1198</a>
      from docker/dependabot/npm_and_yarn/docker/actions-t...</li>
      <li><a
      href="https://github.com/docker/build-push-action/commit/ad3cd774a4f620adb18ba3ba3fa178c73b624bd2"><code>ad3cd77</code></a>
      chore: update generated content</li>
      <li><a
      href="https://github.com/docker/build-push-action/commit/3efbc133663acf954bb07c2ab14201de1e1733a4"><code>3efbc13</code></a>
      chore(deps): Bump <code>@​docker/actions-toolkit</code> from 0.36.0 to
      0.37.0</li>
      <li><a
      href="https://github.com/docker/build-push-action/commit/2dbe91db48e489c125002fbd97678eaf1e0e563e"><code>2dbe91d</code></a>
      Merge pull request <a
      href="https://redirect.github.com/docker/build-push-action/issues/1197">#1197</a>
      from crazy-max/build-checks</li>
      <li>Additional commits viewable in <a
      href="https://github.com/docker/build-push-action/compare/5176d81f87c23d6fc96624dfdbcd9f3830bbe445...5cd11c3a4ced054e52742c5fd54dca954e0edd85">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      
      Dependabot will resolve any conflicts with this PR as long as you don't
      alter it yourself. You can also trigger a rebase manually by commenting
      `@dependabot rebase`.
      
      [//]: # (dependabot-automerge-start)
      [//]: # (dependabot-automerge-end)
      
      ---
      
      <details>
      <summary>Dependabot commands and options</summary>
      <br />
      
      You can trigger Dependabot actions by commenting on this PR:
      - `@dependabot rebase` will rebase this PR
      - `@dependabot recreate` will recreate this PR, overwriting any edits
      that have been made to it
      - `@dependabot merge` will merge this PR after your CI passes on it
      - `@dependabot squash and merge` will squash and merge this PR after
      your CI passes on it
      - `@dependabot cancel merge` will cancel a previously requested merge
      and block automerging
      - `@dependabot reopen` will reopen this PR if it is closed
      - `@dependabot close` will close this PR and stop Dependabot recreating
      it. You can achieve the same result by closing it manually
      - `@dependabot show <dependency name> ignore conditions` will show all
      of the ignore conditions of the specified dependency
      - `@dependabot ignore <dependency name> major version` will close this
      group update PR and stop Dependabot creating any more for the specific
      dependency's major version (unless you unignore this specific
      dependency's major version or upgrade to it yourself)
      - `@dependabot ignore <dependency name> minor version` will close this
      group update PR and stop Dependabot creating any more for the specific
      dependency's minor version (unless you unignore this specific
      dependency's minor version or upgrade to it yourself)
      - `@dependabot ignore <dependency name>` will close this group update PR
      and stop Dependabot creating any more for the specific dependency
      (unless you unignore this specific dependency or upgrade to it yourself)
      - `@dependabot unignore <dependency name>` will remove all of the ignore
      conditions of the specified dependency
      - `@dependabot unignore <dependency name> <ignore condition>` will
      remove the ignore condition of the specified dependency and ignore
      conditions
      
      
      </details>
      
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    • thiolliere's avatar
      Remove deprecated calls in cumulus-parachain-system (#5439) · f0323d52
      thiolliere authored
      Calls were written to be removed after June 2024. This PR removes them.
      
      This PR will break users using those calls. The call won't be decodable
      by the runtime, so it should fail early with no consequences. The
      functionality must be same as before, users will just need to use the
      calls in `System`.
    • Przemek Rzad's avatar
      Make the PR template a default for new PRs (#5462) · 5a84374f
      Przemek Rzad authored
      A follow-up to https://github.com/paritytech/polkadot-sdk/pull/5447
      
      Instead of having an option to select a PR template (like is the case
      with issues), this change will make the one PR template we have the
      default, it will show up for every new PR.
      
      Also updated one link so it works properly in the PR body.
    • Liu-Cheng Xu's avatar
      Only log the propagating transactions when they are not empty (#5424) · 6ecbde33
      Liu-Cheng Xu authored
      This can make the log cleaner, especially when you specify `--log
      sync=debug`.
  5. Aug 26, 2024
    • Oliver Tale-Yazdi's avatar
      [CI] Fix SemVer check base commit (#5361) · b34d4a08
      Oliver Tale-Yazdi authored
      
      After seeing some cases of reported changes that did not happen by the
      merge request proposer (like
      https://github.com/paritytech/polkadot-sdk/pull/5339), it became clear
      that [this](https://github.com/orgs/community/discussions/59677) is
      probably the issue.
      The base commit of the SemVer check CI is currently using the *latest*
      master commit, instead of the master commit at the time when the MR was
      created.
      
      Trying to get the correct base commit now. For this to be debugged, i
      have to wait until another MR is merged into master.
      
      ---------
      
      Signed-off-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
    • Nazar Mokrynskyi's avatar
      Sync status refactoring (#5450) · dd1aaa47
      Nazar Mokrynskyi authored
      
      As I was looking at the coupling between `SyncingEngine`,
      `SyncingStrategy` and individual strategies I noticed a few things that
      were unused, redundant or awkward.
      
      The awkward change comes from
      https://github.com/paritytech/substrate/pull/13700 where
      `num_connected_peers` property was added to `SyncStatus` struct just so
      it can be rendered in the informer. While convenient, the property
      didn't really belong there and was annoyingly set to `0` in some
      strategies and to `num_peers` in others. I have replaced that with a
      property on `SyncingService` that already stored necessary information
      internally.
      
      Also `ExtendedPeerInfo` didn't have a working `Clone` implementation due
      to lack of perfect derive in Rust and while I ended up not using it in
      the refactoring, I included fixed implementation for it in this PR
      anyway.
      
      While these changes are not strictly necessary for
      https://github.com/paritytech/polkadot-sdk/issues/5333, they do reduce
      coupling of syncing engine with syncing strategy, which I thought is a
      good thing.
      
      Reviewing individual commits will be the easiest as usual.
      
      ---------
      
      Co-authored-by: default avatarDmitry Markin <dmitry@markin.tech>
    • Egor_P's avatar
      Add build options to the srtool build step (#4956) · 3cbefaf1
      Egor_P authored
      
      This PR adds possibility to set BUILD_OPTIONS to the "Srtool Build" step
      in the release pipeline while building runtimes.
      
      Colses: https://github.com/paritytech/release-engineering/issues/213
      
      ---------
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      Co-authored-by: default avatarEgorPopelyaev <EgorPopelyaev@users.noreply.github.com>
    • Muharem Ismailov's avatar
      `MaybeConsideration` extension trait for `Consideration` (#5384) · ad0de749
      Muharem Ismailov authored
      Introduce `MaybeConsideration` extension trait for `Consideration`.
      
      The trait allows for the management of tickets that may represent no
      cost. While the `MaybeConsideration` still requires proper handling, it
      introduces the ability to determine if a ticket represents no cost and
      can be safely forgotten without any side effects.
      
      The new trait is particularly useful when a consumer expects the cost to
      be zero under certain conditions (e.g., when the proposal count is below
      a threshold N) and does not want to store such consideration tickets in
      storage. The extension approach allows us to avoid breaking changes to
      the existing trait and to continue using it as a non-optional version
      for migrating pallets that utilize the `Currency` and `fungible` traits
      for `holds` and `freezes`, without requiring any storage migration.