Skip to content
  1. Dec 15, 2021
  2. Dec 14, 2021
    • Bastian Köcher's avatar
      Remove cargo unleash CI job (#10482) · bc0ecf8d
      Bastian Köcher authored
      * Remove cargo unleash CI job
      
      The CI job is currently breaking, because we released some crates. We also don't need the job
      currently because releases are not done. So, the job currently just annoys people and eats CPU time.
      This brings us to the conclusion that this job is currently not required and can be readded at a
      later point when we are sure that we need it.
      
      * Hopefully fix UI test
      
      * Another try
      
      * Remove `reserved_keyword` ui
      bc0ecf8d
    • Bastian Köcher's avatar
      Prepare code for rust 1.57 (#10471) · 187663e1
      Bastian Köcher authored
      * Prepare code for rust 1.57
      
      * CI: revert me; staging image with stable 1.57
      
      * Revert "CI: revert me; staging image with stable 1.57 [skip CI]"
      
      This reverts commit f3c3b8a9e877ef7126ffce6ebc4822bb4ace0379.
      
      Co-authored-by: CI system <>
      187663e1
    • Koute's avatar
      Statically register host WASM functions (#10394) · 7711f526
      Koute authored
      * Statically register host WASM functions
      
      * Fix `substrate-test-client` compilation
      
      * Move `ExtendedHostFunctions` to `sp-wasm-interface`
      
      * Fix `sp-runtime-interface` tests' compilation
      
      * Fix `sc-executor-wasmtime` tests' compilation
      
      * Use `runtime_interface` macro in `test-runner`
      
      * Fix `sc-executor` tests' compilation
      
      * Reformatting/`rustfmt`
      
      * Add an extra comment regarding the `H` generic arg in `create_runtime`
      
      * Even more `rustfmt`
      
      * Depend on `wasmtime` without default features in `sp-wasm-interface`
      
      * Bump version of `sp-wasm-interface` to 4.0.1
      
      * Bump `sp-wasm-interface` in `Cargo.lock` too
      
      * Bump all of the `sp-wasm-interface` requirements to 4.0.1
      
      Maybe this will appease cargo-unleash?
      
      * Revert "Bump all of the `sp-wasm-interface` requirements to 4.0.1"
      
      This reverts commit 0f7ccf8e0f371542861121b145ab87af6541ac30.
      
      * Make `cargo-unleash` happy (maybe)
      
      * Use `cargo-unleash` to bump the crates' versions
      
      * Align to review comments
      7711f526
  3. Dec 13, 2021
  4. Dec 11, 2021
    • Gavin Wood's avatar
      Make Preimage WeightInfo public (#10474) · ca0b816f
      Gavin Wood authored
      ca0b816f
    • Gavin Wood's avatar
      Preimage registrar and Scheduler integration (#10356) · 5e50e0bc
      Gavin Wood authored
      
      
      * initial idea
      
      * more
      
      * fix compile
      
      * add clear and request logic
      
      * improve some docs
      
      * Add and implement trait
      
      * continuing to improve
      
      * refcount type
      
      * infallible system preimage upload
      
      * fmt
      
      * fix requests
      
      * Make it simple
      
      * Make it simple
      
      * Formatting
      
      * Initial draft
      
      * request when scheduled
      
      * Docs
      
      * Scheduler good
      
      * Scheduler good
      
      * Scheduler tests working
      
      * Add new files
      
      * Missing stuff
      
      * Repotting, add weights.
      
      * Add some tests to preimage pallet
      
      * More tests
      
      * Fix benchmarks
      
      * preimage benchmarks
      
      * All preimage benchmarks
      
      * Tidy cargo
      
      * Update weights.rs
      
      * Allow hash provision in benchmarks
      
      * Initial work on new benchmarks for Scheduler
      
      * Tests working, refactor looks good
      
      * Tests for new Scheduler functionality
      
      * Use real weight, make tests work with runtimes without Preimage
      
      * Rename
      
      * Update benchmarks
      
      * Formatting
      
      * Formatting
      
      * Fix weird formatting
      
      * Update frame/preimage/src/lib.rs
      
      * Fix try-runtime build
      
      * Fixes
      
      * Fixes
      
      * Update frame/support/src/traits/tokens/currency.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/support/src/traits/tokens/currency/reservable.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/support/src/traits/tokens/imbalance.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/preimage/src/mock.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Update frame/scheduler/src/lib.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Update frame/preimage/src/lib.rs
      
      * Fixes
      
      * Fixes
      
      * Formatting
      
      * Fixes
      
      * Fixes
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_scheduler --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/scheduler/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_preimage --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/preimage/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarKian Paimani <[email protected]>
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      Co-authored-by: default avatarParity Bot <[email protected]>
      5e50e0bc
    • Bastian Köcher's avatar
      `inspect-key`: Adds support for `expect-public` (#10430) · f6f58f95
      Bastian Köcher authored
      * Introduce `SecretUri`
      
      * `inspect-key`: Adds support for `expect-public`
      
      `expect-public` can be used to check that a given secret uri corresponds to the given public key.
      This is mainly useful when the secret uri is protected by a password and a new derived account
      should be generated. With `--expect-public` the user can pass the public key/account-id of the
      "base" secret uri aka the one without any derivation to ensure the correct password was inserted.
      
      * Fixes
      
      * 🤦
      
      
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarAndré Silva <[email protected]>
      
      * Review feedback
      
      * FMT
      
      * Bump the versions
      
      Co-authored-by: default avatarAndré Silva <[email protected]>
      f6f58f95
  5. Dec 10, 2021
  6. Dec 09, 2021
    • Gautam Dhameja's avatar
    • Gavin Wood's avatar
      Insufficient asset quota and deposits (#10382) · 3dd8f83a
      Gavin Wood authored
      
      
      * Allow asset accounts to exist by deposit
      
      * Place limit on consumers (and therefore freebie asset accounts)
      
      * Maximum number of assets
      
      * Fixes
      
      * Fixes
      
      * Formatting
      
      * Docs
      
      * Formatting
      
      * Destroyed assets are properly tidied
      
      * Update frame/assets/src/types.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Docs
      
      * Docs
      
      * Formatting
      
      * Docs
      
      * Docs
      
      * Fixes
      
      * Fixes
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      3dd8f83a
    • Alexander Theißen's avatar
      Run contract benchmarks (#10452) · 667dec91
      Alexander Theißen authored
      
      
      * Trigger benchmarks
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_contracts --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/contracts/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      Co-authored-by: default avatarParity Bot <[email protected]>
      667dec91
    • thiolliere's avatar
      improve doc (#10431) · 7f6f3322
      thiolliere authored
      7f6f3322
    • remzrn's avatar
      Fixed logic of the storage migration to triple reference counting. (#10337) · af643832
      remzrn authored
      * Fixed logic of the storage migration to triple reference counting. The previous behaviour made it impossible for any chain not already upgraded to dual reference counting to upgrade the runtime.
      
      * +Removed the on_runtime_upgrade() function from frame-system.
      +Removed the specific migration .anciallaries from the frame-system pallet level.
      +Introducted a new module that hosts self-contained ancillary functions and logic to perform the storage migration. The current logic attempts to infer the state of the storage based on whether or not a given migration can be conducted.
      
      * Formatting.
      
      * + Removed specific AccountData struct. AccountData must now be provided during the runtime implementation of the trait V2ToV3.
      + Removed apply function.
      + Made the individual translation function self-sufficient.
      
      * + Removed unused decorators.
      af643832
  7. Dec 08, 2021
    • David's avatar
      Release sp-core 4.0.0 (#10447) · 92dc635f
      David authored
      * Bump versions of sp-core and dependencies to v4.0.0
      
      * Update references from `4.0.0-dev` –> `4.0.0`
      
      * Funny whitespace
      
      * Funny whitespace 2
      92dc635f
    • Gavin Wood's avatar
      Introduce CheckNonZeroSender (#10413) · 4b34b041
      Gavin Wood authored
      
      
      * Introduce CheckNonZeroSender
      
      * Missing file
      
      * Formatting
      
      * Fixes
      
      * Formatting
      
      * some fixes to compile
      
      * Update frame/system/src/extensions/check_non_zero_sender.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Fixes
      
      * Fixes
      
      * another fix
      
      * Formatting
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      4b34b041
    • Zeke Mostov's avatar
      Add extrinsic to improve position in a bag of bags-list (#9829) · 4855eb6c
      Zeke Mostov authored
      
      
      * pallet-bags-list: Add `put_in_front_of` extrinsic
      
      This PR adds the extrinsic `put_in_front_of` which allows the user to specify a `lighter` and `heavier` account within the same bag. The extrinsic will move `heavier` directly in front of `lighter`.  The parameter names refer to the fact that `lighter` must have a lower `VoteWeight` then `heavier`. 
      
      In the ideal use case, where a user wants to improve the position of their account within a bag, the user would iterate the bag, starting from the head, and find the first node who's `VoteWeight` is less than theirs. They would then supply the `id` of the node as the `lighter` argument and their own `id` as the `heavier` argument.
      
      * Test & Benchmarks
      
      * Respect line width
      
      * Remove List::put_in_fron_of tests; Remove AlreadyHigher error
      
      * The dispatch origin for this call must be ...
      
      * Add some periods
      
      * Add back test to list module: put_in_front_of_exits_early_if_bag_not_found
      
      * add test tests::pallet::heavier_is_head_lighter_is_not_terminal
      
      * Cater for edge case of heavier being head
      
      * Add ExtBuilder::add_aux_data; try to make some tests use simpler data
      
      * Update frame/bags-list/src/list/tests.rs
      
      * make insert_at_unchecked infallible
      
      * Make it permissioned - only callable by heavier
      
      * Add test cases for insert_at_unchecked
      
      * Move counter update to insert_at; fix comments
      
      * Address some feedback
      
      * Make voteweight constructed with parameter_types
      
      * Always set vote weight for Ids in build
      
      * Add skip_genesis_ids
      
      * Do not pass weight fn to List put_in_front_of
      
      * Remove remants of CounterForListNodes
      
      * fmt
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Delete messed up weights file
      
      * Some place holder stuff so we can run bench in CI
      
      * Fix
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Update frame/bags-list/src/list/mod.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * fmt
      
      * Log + debug assert when refetching an Id
      
      Co-authored-by: default avatarParity Bot <[email protected]>
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      4855eb6c
  8. Dec 07, 2021
    • Gautam Dhameja's avatar
      Add child-bounties pallet. (#10309) · 752e050c
      Gautam Dhameja authored
      
      
      * Extract child-bounties as a separate pallet.
      
      * Initial tests added.
      
      * More tests.
      
      * Tests complete. Fixed curator fee issue.
      
      * Fixed comments.
      
      * Added benchmarks for child-bounties pallet.
      
      * Added weights.
      
      * Fixed formatting.
      
      * Fixed comments.
      
      * Re-run benchmarks for bounties pallet.
      
      * Make cargo fmt happy again
      
      * add max encoded len
      
      * use event structs
      
      * fmt
      
      * fix compile
      
      * Addressed review comments.
      
      * Use config type instead of const in benchmarking.
      
      * Addressed more review comments.
      
      * Use ensure_can_withdraw instead of just checking min balance.
      
      * fmt.
      
      * Introduce ChildBountyCuratorDepositBase to avoid zero curator deposits for child bounties.
      
      * Fix unassign curator logic for child-bounties.
      
      * Added more tests for unassign curator.
      
      * Reduce bounty description max length in node runtime.
      
      * Updated weights for child bounties pallet.
      
      * reduce indentation of unassign_curator
      
      * more indentation reduction
      
      * deduplicate slashing arms
      
      * reintroduce ensure check
      
      * add assertion to check that bad unassign origin fails
      
      * formatting
      
      * Updated comments.
      
      Co-authored-by: default avatarRicardo Rius <[email protected]>
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarAlexander Popiak <[email protected]>
      752e050c
    • Alexander Theißen's avatar
      Clean up `pallet-contracts` documentation (#10438) · 35b82f91
      Alexander Theißen authored
      * Update CHANGELOG.md
      
      * Remove COMPLEXITY.md
      35b82f91
    • Alexander Theißen's avatar
      contracts: Add storage deposits (#10082) · 68634766
      Alexander Theißen authored
      
      
      * Frame no longer needs to be mutable (refactoring artifact)
      
      * Remove Contract/Tombstone deposit
      
      * Add StorageMeter
      
      * cargo fmt
      
      * Fix weight annotation
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_contracts --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/contracts/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Simplify keep check for contract accounts
      
      - Make sure that the "base deposit" for each contract >= ed
      - Remove now obsolete checks when sneding away free balance
      
      * Remove unused imports and functions
      
      * Rename storage_limit to storage_deposit_limit
      
      * cargo fmt
      
      * Fix typo
      
      Co-authored-by: default avatarMichael Müller <[email protected]>
      
      * Finish up rename of storage_limit
      
      * Fix rpc tests
      
      * Make use of `StorageDepositLimitTooHigh`
      
      * Add tests and fix bugs discovered by tests
      
      * Add storage migration
      
      * Don't use u128 in RPC
      
      * Fix weight of migration
      
      * Rename `endowment` to `value`
      
      * Fix bug where contract couldn't get funded by a storage deposit
      
      - Make sure that contract gets funded from deposits before value is transferred
      - Don't reserve value at origin because otherwise funding isn't possible
      	- Just transfer free balance and reserve it after the transfer
      - When refunding make sure that this refund can't dust the contract
      	- Can only happen after a runtime upgrade where costs where upped
      - Add more tests
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarAndrew Jones <[email protected]>
      
      * Remove unused `fn storage_meter`
      
      * Fix copy pasta doc error
      
      * Import `MaxEncodeLen` from codec
      
      * Beautify RPC trait bounds
      
      * Add re-instrument behaviour to dispatchable doc
      
      * Make sure a account won't be destroyed a refund after a slash
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarAndrew Jones <[email protected]>
      
      * Update `Storage::write` docs
      
      * Improve doc
      
      * Remove superflous conditional
      
      * Typos
      
      * Remove superflous clone (refactoring artifact)
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarAndrew Jones <[email protected]>
      
      Co-authored-by: default avatarParity Bot <[email protected]>
      Co-authored-by: default avatarMichael Müller <[email protected]>
      Co-authored-by: default avatarAndrew Jones <[email protected]>
      68634766
    • Ayevbeosa Iyamu's avatar
      Used CountedStorageMap in pallet-staking (#10233) · 56fb1cfb
      Ayevbeosa Iyamu authored
      
      
      * Removed counters and used CountedStorageMap instead.
      
      * Little refactoring
      
      * Update frame/staking/src/migrations.rs
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * Removed redundant code to update counter for validator & nominator.
      
      * Removed redundant code to update counter for validator & nominator.
      
      * Removed unreachable code to inject the hashed prefix for nominator & validator.
      
      * Removed redundant check for nominator & validator count.
      
      * Generated `fn prefix_hash` for `CountedStorageMap`.
      
      * Applied changes from `cargo fmt`
      
      * Possible correct implementation of migration code
      
      * Implemented fn module_prefix, storage_prefix and prefix_hash.
      
      * Removed counted_map.rs
      
      * Renamed `fn storage_prefix` to `storage_counter_prefix`.
      
      * Update frame/support/src/storage/types/counted_map.rs
      
      * Update frame/bags-list/remote-tests/src/snapshot.rs
      
      * Update frame/support/src/storage/types/counted_map.rs
      
      * Fixed errors.
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      56fb1cfb
  9. Dec 06, 2021
  10. Dec 03, 2021
  11. Dec 02, 2021
    • Kian Paimani's avatar
      Minimum commission for validators (#10347) · e9a7dc3c
      Kian Paimani authored
      
      
      * Minimum commission for validators
      
      * rename
      
      * Fix benchmakrs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Update frame/staking/src/pallet/mod.rs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      Co-authored-by: default avatarParity Bot <[email protected]>
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      e9a7dc3c
  12. Dec 01, 2021
  13. Nov 30, 2021
    • Enoch Chejieh's avatar
      Add pallet names to Events (#10296) · d58aeb04
      Enoch Chejieh authored
      * chore: add pallet names to events
      
      * chore: add pallet names to events
      
      * chore: add pallet names to events
      
      * chore: add pallet names to events
      
      * chore: add pallet names to events
      
      * chore: add pallet names to events
      
      * chore: add pallet names to events
      
      * chore: add pallet names to events
      
      * chore: add pallet names to events
      
      * chore: add pallet names to events
      
      * chore: add pallet names to events
      
      * chore: add pallet names to events
      
      * chore: add pallet names to events
      
      * chore: add pallet names to events
      
      * chore: formatted pallet name changes in events
      
      * chore: formatted pallet name changes in events
      
      * chore: formatted pallet name changes in events
      
      * chore: formatted pallet name changes in events
      
      * chore: formatted pallet name changes in events
      
      * chore: formatted pallet name changes in events
      
      * chore: formatted pallet name changes in events
      
      * chore: formatted pallet name changes in events
      
      * chore: formatted pallet name changes in events
      
      * fix: add fix to tests for event variants
      
      * chore: modified comments for event variants
      
      * chore: modified comments for event variants
      
      * chore: modified comments for event variants
      
      * chore: modified comments for event variants
      
      * chore: modified system pallet event variants
      
      * chore: modified system pallet event variants
      
      * chore: modified system pallet event variants
      
      * chore: modified system pallet event variants
      
      * chore: modified system pallet event variants
      
      * chore: modified system pallet event variants
      
      * chore: modified system pallet event variants
      
      * chore: modified system pallet event variants
      
      * chore: modified system pallet event variants
      
      * chore: updated transaction-storage pallet event variants
      
      * chore: updated transaction-storage pallet event variants
      
      * chore: formatted contracts pallet
      
      * chore: update treasury event variants
      d58aeb04
    • zjb0807's avatar
      Add runtime-benchmarks for frame-benchmarking (#10324) · b5ed6468
      zjb0807 authored
      * update frame/benchmarking/src/baseline.rs
      
      * add runtime-benchmarks feature
      
      * add runtime-benchmarks for frame-benchmarking
      
      * update frame-benchmarking/runtime-benchmarks
      
      * trigger GitHub actions
      b5ed6468
    • Joshy Orndorff's avatar
      Add `vote` and `seconded` events to Democracy pallet. (#10352) · a01004e1
      Joshy Orndorff authored
      
      
      * add the events
      
      * spec_version
      
      * Update bin/node/runtime/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      Co-authored-by: default avatarAlan Sapede <[email protected]>
      Co-authored-by: default avatarKian Paimani <[email protected]>
      a01004e1
  14. Nov 29, 2021
  15. Nov 28, 2021
  16. Nov 26, 2021
  17. Nov 25, 2021