- Dec 13, 2024
-
-
Alexandru Gheorghe authored
Approval voting canonicalize is off by one that means if we are finalizing blocks one by one, approval-voting cleans it up every other block for example: - With 1, 2, 3, 4, 5, 6 blocks created, the stored range would be StoredBlockRange(1,7) - When block 3 is finalized the canonicalize works and StoredBlockRange is (4,7) - When block 4 is finalized the canonicalize exists early because of the `if range.0 > canon_number` break clause, so blocks are not cleaned up. - When block 5 is finalized the canonicalize works and StoredBlockRange becomes (6,7) and both block 4 and 5 are cleaned up. The consequences of this is that sometimes we keep block entries around after they are finalized, so at restart we consider this blocks and send them to approval-distribution. In most cases this is not a problem, but in the case when finality is lagging on restart approval-distribution will receive 4 as being the oldest block it needs to work on, and since BlockFinalized is never resent for block 4 after restart it won't get the opportunity to clean that up. Therefore it will end running approval-distribution aggression on block 4, because that is the oldest block it received from approval-voting for which it did not see a BlockFinalized signal. --------- Signed-off-by:
Alexandru Gheorghe <alexandru.gheorghe@parity.io> (cherry picked from commit 2dd2bb5a)
-
- Dec 11, 2024
-
-
EgorPopelyaev authored
-
EgorPopelyaev authored
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #6459 into `stable2409` from franciscoaguirre. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md ) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by:
Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by:
Branislav Kontur <bkontur@gmail.com> Co-authored-by:
Egor_P <egor@parity.io>
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #6506 into `stable2409` from Dinonard. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md ) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by:
Dino Pačandi <3002868+Dinonard@users.noreply.github.com> Co-authored-by:
EgorPopelyaev <egor@parity.io>
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #6696 into `stable2409` from alexggh. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md ) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Signed-off-by:
Alexandru Gheorghe <alexandru.gheorghe@parity.io> Co-authored-by:
Alexandru Gheorghe <49718502+alexggh@users.noreply.github.com> Co-authored-by:
Alexandru Gheorghe <alexandru.gheorghe@parity.io>
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #6729 into `stable2409` from alexggh. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md ) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Signed-off-by:
Alexandru Gheorghe <alexandru.gheorghe@parity.io> Co-authored-by:
Alexandru Gheorghe <49718502+alexggh@users.noreply.github.com> Co-authored-by:
Alexandru Gheorghe <alexandru.gheorghe@parity.io>
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #6781 into `stable2409` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md ) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by:
Branislav Kontur <bkontur@gmail.com>
-
- Dec 10, 2024
-
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #5311 into `stable2409` from Doordashcon. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md ) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by:
Doordashcon <jesse.chejieh@gmail.com>
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #6662 into `stable2409` from eskimor. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md ) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by:
eskimor <eskimor@users.noreply.github.com> Co-authored-by:
Andrei Sandu <54316454+sandreim@users.noreply.github.com>
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #6690 into `stable2409` from alexggh. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md ) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by:
Alexandru Gheorghe <49718502+alexggh@users.noreply.github.com>
-
- Dec 09, 2024
-
-
Niklas Adolfsson authored
Co-authored-by:
Tarek Mohamed Abdalla <tarekkma@gmail.com>
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #6540 into `stable2409` from Ank4n. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md ) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by:
Ankan <10196091+Ank4n@users.noreply.github.com> Co-authored-by:
Ankan <ankan.anurag@gmail.com>
-
- Nov 28, 2024
-
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #6684 into `stable2409` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md ) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by:
Branislav Kontur <bkontur@gmail.com>
-
- Nov 27, 2024
-
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #6603 into `stable2409` from lexnv. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md ) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by:
Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #6579 into `stable2409` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md ) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by:
Branislav Kontur <bkontur@gmail.com> Co-authored-by:
Egor_P <egor@parity.io>
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #6645 into `stable2409` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md ) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by:
Branislav Kontur <bkontur@gmail.com>
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #6536 into `stable2409` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md ) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by:
Branislav Kontur <bkontur@gmail.com>
-
- Nov 21, 2024
-
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #6526 into `stable2409` from bkchr. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by:
Bastian Köcher <git@kchr.de>
-
- Nov 14, 2024
-
-
Morgan Adamiec authored
-
- Nov 13, 2024
-
-
EgorPopelyaev authored
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #6454 into `stable2409` from niklasad1. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md ) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by:
Niklas Adolfsson <niklasadolfsson1@gmail.com>
-
Egor_P authored
This PR addresses an issue mentioned [here](https://github.com/paritytech/polkadot-sdk/issues/6424#issuecomment-2467042441). The problem was that when the prdoc file has two audiences, but only one description like in [prdoc_5660](https://github.com/paritytech/polkadot-sdk/blob/master/prdoc/1.16.0/pr_5660.prdoc) it was ignored by the template.
-
Oliver Tale-Yazdi authored
Seems to also need actions permission otherwise it error when trying to backport a change to the yml files liker [here](https://github.com/paritytech/polkadot-sdk/actions/runs/11143649431/job/30969199054).
-
- Nov 12, 2024
-
-
EgorPopelyaev authored
-
EgorPopelyaev authored
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #6080 into `stable2409` from franciscoaguirre. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by:
Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by:
Egor_P <egor@parity.io>
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #6205 into `stable2409` from bkchr. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md ) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by:
Bastian Köcher <git@kchr.de> Co-authored-by:
Egor_P <egor@parity.io>
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #6417 into `stable2409` from alindima. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md ) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by:
Alin Dima <alin@parity.io>
-
- Nov 05, 2024
-
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #6148 into `stable2409` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md ) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by:
Branislav Kontur <bkontur@gmail.com>
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #5924 into `stable2409` from AndreiEres. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md ) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by:
Andrei Eres <eresav@me.com>
-
- Oct 18, 2024
-
-
EgorPopelyaev authored
-
Morgan Adamiec authored
-
EgorPopelyaev authored
-
Morgan Adamiec authored
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #6031 into `stable2409` from drewstone. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by:
drewstone <drewstone329@gmail.com>
-
- Oct 17, 2024
-
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #4803 into `stable2409` from gotnoshoeson. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by:
Miles Patterson <miles_patterson@icloud.com>
-
- Oct 16, 2024
-
-
EgorPopelyaev authored
-
EgorPopelyaev authored
-
EgorPopelyaev authored
-