Skip to content
Snippets Groups Projects
  1. Apr 01, 2020
    • Gavin Wood's avatar
      A few missing emojies (#5490) · b86c7e87
      Gavin Wood authored
      * A few missing emojies
      
      * P2p message emojis
      
      * Add a bit of colour
      
      * format
      
      * Introduce a couple of spaces
      
      * Some spaces
      b86c7e87
  2. Mar 31, 2020
  3. Mar 29, 2020
  4. Mar 27, 2020
  5. Mar 26, 2020
    • Kian Paimani's avatar
      Offchain Phragmén BREAKING. (#4517) · 970c5f94
      Kian Paimani authored
      * Initial skeleton for offchain phragmen
      
      * Basic compact encoding decoding for results
      
      * add compact files
      
      * Bring back Self::ensure_storage_upgraded();
      
      * Make staking use compact stuff.
      
      * First seemingly working version of reduce, full of todos
      
      * Everything phragmen related works again.
      
      * Signing made easier, still issues.
      
      * Signing from offchain compile fine :sunglasses:
      
      * make compact work with staked asssignment
      
      * Evaluation basics are in place.
      
      * Move reduce into crate. Document stuff
      
      * move reduce into no_std
      
      * Add files
      
      * Remove other std deps. Runtime compiles
      
      * Seemingly it is al stable; cycle implemented but not integrated.
      
      * Add fuzzing code.
      
      * Cleanup reduce a bit more.
      
      * a metric ton of tests for staking; wip :hammer:
      
      * Implement a lot more of the tests.
      
      * wip getting the unsigned stuff to work
      
      * A bit gleanup for unsigned debug
      
      * Clean and finalize compact code.
      
      * Document reduce.
      
      * Still problems with signing
      
      * We officaly duct taped the transaction submission stuff. :nerd:
      
      * Deadlock with keys again
      
      * Runtime builds
      
      * Unsigned test works :raised_hands:
      
      * Some cleanups
      
      * Make all the tests compile and stuff
      
      * Minor cleanup
      
      * fix more merge stuff
      
      * Most tests work again.
      
      * a very nasty bug in reduce
      
      * Fix all integrations
      
      * Fix more todos
      
      * Revamp everything and everything
      
      * Remove bogus test
      
      * Some review grumbles.
      
      * Some fixes
      
      * Fix doc test
      
      * loop for submission
      
      * Fix cli, keyring etc.
      
      * some cleanup
      
      * Fix staking tests again
      
      * fix per-things; bring patches from benchmarking
      
      * better score prediction
      
      * Add fuzzer, more patches.
      
      * Some fixes
      
      * More docs
      
      * Remove unused generics
      
      * Remove max-nominator footgun
      
      * Better fuzzer
      
      * Disable it :x:
      
      
      
      * Bump.
      
      * Another round of self-review
      
      * Refactor a lot
      
      * More major fixes in perThing
      
      * Add new fuzz file
      
      * Update lock
      
      * fix fuzzing code.
      
      * Fix nominator retain test
      
      * Add slashing check
      
      * Update frame/staking/src/tests.rs
      
      Co-Authored-By: default avatarJoshy Orndorff <JoshOrndorff@users.noreply.github.com>
      
      * Some formatting nits
      
      * Review comments.
      
      * Fix cargo file
      
      * Almost all tests work again
      
      * Update frame/staking/src/tests.rs
      
      Co-Authored-By: default avatarthiolliere <gui.thiolliere@gmail.com>
      
      * Fix review comments
      
      * More review stuff
      
      * Some nits
      
      * Fix new staking / session / babe relation
      
      * Update primitives/phragmen/src/lib.rs
      
      Co-Authored-By: default avatarthiolliere <gui.thiolliere@gmail.com>
      
      * Update primitives/phragmen/src/lib.rs
      
      Co-Authored-By: default avatarthiolliere <gui.thiolliere@gmail.com>
      
      * Update primitives/phragmen/compact/src/lib.rs
      
      Co-Authored-By: default avatarthiolliere <gui.thiolliere@gmail.com>
      
      * Some doc updates to slashing
      
      * Fix derive
      
      * Remove imports
      
      * Remove unimplemented tests
      
      * nits
      
      * Remove dbg
      
      * Better fuzzing params
      
      * Remove unused pref map
      
      * Deferred Slashing/Offence for offchain Phragmen  (#5151)
      
      * Some boilerplate
      
      * Add test
      
      * One more test
      
      * Review comments
      
      * Fix build
      
      * review comments
      
      * fix more
      
      * fix build
      
      * Some cleanups and self-reviews
      
      * More minor self reviews
      
      * Final nits
      
      * Some merge fixes.
      
      * opt comment
      
      * Fix build
      
      * Fix build again.
      
      * Update frame/staking/fuzz/fuzz_targets/submit_solution.rs
      
      Co-Authored-By: default avatarGavin Wood <gavin@parity.io>
      
      * Update frame/staking/src/slashing.rs
      
      Co-Authored-By: default avatarGavin Wood <gavin@parity.io>
      
      * Update frame/staking/src/offchain_election.rs
      
      Co-Authored-By: default avatarGavin Wood <gavin@parity.io>
      
      * Fix review comments
      
      * fix test
      
      * === :key:
      
       Revamp without staking key.
      
      * final round of changes.
      
      * Fix cargo-deny
      
      * Update frame/staking/src/lib.rs
      
      Co-Authored-By: default avatarGavin Wood <gavin@parity.io>
      
      Co-authored-by: default avatarJoshy Orndorff <JoshOrndorff@users.noreply.github.com>
      Co-authored-by: default avatarthiolliere <gui.thiolliere@gmail.com>
      Co-authored-by: default avatarGavin Wood <gavin@parity.io>
      970c5f94
    • pscott's avatar
      TelemetryEndpoints must be valid MutliAddr URL (#5069) · 73c99eec
      pscott authored
      
      * Check for url validity when creating TelemetryEndpoints
      
      * Update code that used TelemetryEndpoints::new()
      
      * Update commennts that referred to TelemetryEndpoints::new()
      
      * Add tests for telemetry
      
      * Fix typo and fix code in docs
      
      * Return error on failing to override telemetry
      
      * Use expect instead of suppressing errors on must-be-valid telemetry endpoints
      
      * Update telemetry unit tests to use expect instead of unwrap
      
      * Implement custom deserializer for TelemetryEndpoints
      
      * Fix typo
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
      73c99eec
  6. Mar 17, 2020
  7. Mar 16, 2020
    • Wei Tang's avatar
      epoch-changes: separate epoch header with epoch data (#4881) · 846a9ce8
      Wei Tang authored
      
      * fork-tree: prune returns all pruned node data
      
      * epoch-changes: split EpochHeader vs epoch data
      
      * EpochChanges::viable_epoch and add missing comments
      
      * Incoperate the new epoch_changes interface for BABE
      
      * Fix BABE tests
      
      * Fix fork-tree pruning issue
      
      * Fix tests
      
      * Fix pruning algorithm
      
      * fork-tree: implement map function for mapping one value type to another
      
      * Add migration script for new epoch changes scheme
      
      * Update utils/fork-tree/src/lib.rs
      
      Co-Authored-By: default avatarAndré Silva <andre.beat@gmail.com>
      
      * Update client/consensus/slots/src/lib.rs
      
      Co-Authored-By: default avatarAndré Silva <andre.beat@gmail.com>
      
      * Remove authorities_len.is_none check, which is duplicate of unwrap_or(false)
      
      * Update client/consensus/epochs/src/lib.rs
      
      Co-Authored-By: default avatarAndré Silva <andre.beat@gmail.com>
      
      * Update client/consensus/epochs/src/lib.rs
      
      Co-Authored-By: default avatarAndré Silva <andre.beat@gmail.com>
      
      * No trailing ; for return statement
      
      * Use VERSION_KEY for migration
      
      * Fix issues that removed nodes are not properly added into removed list
      
      * Add comments indicating end_slot is non-inclusive
      
      * fork-tree: use &mut F for map type declaration
      
      * Add tests for v0 epoch_changes migration
      
      * Fix babe RPC tests
      
      Co-authored-by: default avatarAndré Silva <andre.beat@gmail.com>
      846a9ce8
  8. Mar 12, 2020
  9. Mar 11, 2020
  10. Mar 10, 2020
  11. Mar 05, 2020
  12. Mar 03, 2020
    • Gavin Wood's avatar
      Lazy payouts (#4474) · 619f64ef
      Gavin Wood authored
      
      * TODOs
      
      * Remove superfluous:
      
      * partial implementation
      
      * full implementation
      
      * fix preferences
      
      * update comments
      
      * upgrade test WIP
      
      * fix more tests
      
      * fix cutoff
      
      * fix saturation
      
      * comment
      
      * upgrade mock
      
      * upgrade test
      
      * WIP migration
      
      * WIP migration
      
      * remove slot stake stuff
      
      * fix merge
      
      * migration of ledger
      
      * remove equalize from test
      
      * add test
      
      * fix
      
      * update doc
      
      * fix compilation
      
      * improve test readibility
      
      * improve doc
      
      * fix most todo
      
      * fix migration and test
      
      * remove println
      
      * WIP
      
      * add test and spec
      
      * weight
      
      * update doc
      
      * safer end_era
      
      * fix exposure of conversion
      
      * Revert "safer end_era"
      
      This reverts commit 72ff737d27be67d87308514b13e2574bc5f09fce.
      
      * fix useless put
      
      * exposure clipped
      
      * doc
      
      * fix payout with clipped
      
      * fix node runtime
      
      * add doc
      
      * pluggable and generalized staking module
      
      * remove print
      
      * update doc
      
      * refactor
      
      * improve documentation and implementation
      
      * fix test
      
      * Fix test
      
      * fix test
      
      * fix test
      
      * fix remove lowest stake from exposure, not biggest.
      
      * nomination index arguments in nominator_payout
      
      * add test
      
      * try to fix offence
      
      * apply slashed and bond eras until active era
      
      * doc
      
      * update spec version
      
      * add test upgrade from previous test environment
      
      * Apply suggestions from code review
      
      Co-Authored-By: default avatarShawn Tabrizi <shawntabrizi@gmail.com>
      
      * nominators upgrade has been cleaned
      
      * dynamic history depth implementation
      
      * make current_era - history_depth included
      
      * Change equality check to start era to less than or equal
      
      * Use era specific validator prefs
      
      * Add print statement and comment about start era if <
      
      * fix next_reward overflow
      
      * make more check for bad era claim for zero cost
      
      * small refactor
      
      * code refactor + fix use of deprecated storage
      
      * fix wasm build
      
      * add comment
      
      * Fix tests
      
      * remove outdated comment
      
      * Apply suggestions from code review
      
      Co-Authored-By: default avatarShawn Tabrizi <shawntabrizi@gmail.com>
      
      * gather active era information into one storage
      
      Co-authored-by: default avatarthiolliere <gui.thiolliere@gmail.com>
      Co-authored-by: default avatarShawn Tabrizi <shawntabrizi@gmail.com>
      619f64ef
    • Ashley's avatar
      Add more metrics to prometheus (#5034) · 883ddfc8
      Ashley authored
      * Add a few things
      
      * Add finality_grandpa_round
      
      * fix fg tests
      
      * Nitpicks
      
      * Nitpicks
      
      * Fix name of prometheus crate
      883ddfc8
  13. Feb 27, 2020
  14. Feb 24, 2020
  15. Feb 21, 2020
    • asynchronous rob's avatar
      Remove `NetworkSpecialization` (#4665) · 0090fe97
      asynchronous rob authored
      
      * remove networkspecialization
      
      * Fix most of the fallout
      
      * get all tests compiling
      
      Co-authored-by: default avatarPierre Krieger <pierre.krieger1708@gmail.com>
      0090fe97
    • Cecile Tonglet's avatar
      Add tests & Service's Configuration has optional fields that shouldn't be optional (#4842) · e8000e74
      Cecile Tonglet authored
      Related to #4776 
      Related to https://github.com/paritytech/polkadot/pull/832
      
      To summarize the changes:
      1. I did not manage to validate with types the service's Configuration. But I did reduce the possibility of errors by moving all the "fill" functions to their respective structopts
      2. I split params.rs to multiple modules: one module params for just CLI parameters and one module commands for CLI subcommands (and RunCmd). Every command and params are in their own file so things are grouped better together and easier to remove
      3. I removed the run and run_subcommand helpers as they are not helping much anymore. Running a command is always a set of 3 commands: 1. init 2. update config 3. run. This still allow the user to change the config before arguments get parsed or right after.
      4. I added tests for all subcommands.
      5. [deleted]
      
      Overall the aim is to improve the situation with the Configuration and the optional parameters, add tests, make the API more consistent and simpler.
      e8000e74
    • Web3 Philosopher's avatar
      Removes use of sc_client::Client from sc_consensus_babe (#5014) · 832b2ef6
      Web3 Philosopher authored
      
      * removes use of sc_client::Client from sc_consensus_babe
      
      * Update client/consensus/babe/src/lib.rs
      
      Co-authored-by: default avatarBenjamin Kampmann <ben.kampmann@googlemail.com>
      832b2ef6
    • André Silva's avatar
      node, node-template: disable GRANDPA observer (#5011) · f0043055
      André Silva authored
      * node-template: disable grandpa observer
      
      * node: disable grandpa observer
      
      * node: add doc about grandpa-voter infallible task
      
      * grandpa: remove grandpa observer from public API
      
      * grandpa: ignore observer_enabled field in config
      f0043055
  16. Feb 20, 2020
  17. Feb 19, 2020
    • Bastian Köcher's avatar
      Consolidate frame benchmarking into a frame crate (#4977) · b4ebd41c
      Bastian Köcher authored
      This prs cleans up some of the frame benchmarking stuff:
      - Move CLI into `frame-benchmarking-cli`. No frame related CLI should
      exists in the default Substrate CLI.
      - Move all traits and types related to frame benchmarking into the
      `frame-benchmarking` trait. Frame types should be isolated in Frame.
      b4ebd41c
  18. Feb 18, 2020
    • Tomasz Drwięga's avatar
      Inspection extension to node CLI (#4697) · a14d2815
      Tomasz Drwięga authored
      * Initial inspect.
      
      * WiP
      
      * Add parsing tests.
      
      * Finalize CLI.
      
      * Update to latest substrate.
      
      * Remove unused imports.
      
      * Support ImportParams as well, to get the right pruning setting.
      
      * Mention in docs that hash is no 0x.
      
      * Move bytes above extrinsics.
      
      * Switch to fill helper from sc_cli.
      
      * Remove overwrite.
      
      * Fix error.
      
      * Fix error message.
      
      * Remove extra allow.
      
      * init_config
      a14d2815
  19. Feb 17, 2020
  20. Feb 14, 2020
    • Gavin Wood's avatar
      Composite accounts (#4820) · 5b7512e2
      Gavin Wood authored
      
      * Basic account composition.
      
      * Add try_mutate_exists
      
      * De-duplicate
      
      * Refactor away the UpdateBalanceOutcome
      
      * Expunge final UpdateBalanceOutcome refs
      
      * Refactor transfer
      
      * Refactor reservable currency stuff.
      
      * Test with the alternative setup.
      
      * Fixes
      
      * Test with both setups.
      
      * Fixes
      
      * Fix
      
      * Fix macros
      
      * Make indices opt-in
      
      * Remove CreationFee, and make indices opt-in.
      
      * Fix construct_runtime
      
      * Fix last few bits
      
      * Fix tests
      
      * Update trait impls
      
      * Don't hardcode the system event
      
      * Make tests build and fix some stuff.
      
      * Pointlessly bump runtime version
      
      * Fix benchmark
      
      * Another fix
      
      * Whitespace
      
      * Make indices module economically safe
      
      * Migrations for indices.
      
      * Fix
      
      * Whilespace
      
      * Trim defunct migrations
      
      * Remove unused storage item
      
      * More contains_key fixes
      
      * Docs.
      
      * Bump runtime
      
      * Remove unneeded code
      
      * Fix test
      
      * Fix test
      
      * Update frame/balances/src/lib.rs
      
      Co-Authored-By: default avatarShawn Tabrizi <shawntabrizi@gmail.com>
      
      * Fix ED logic
      
      * Repatriate reserved logic
      
      * Typo
      
      * Fix typo
      
      * Update frame/system/src/lib.rs
      
      Co-Authored-By: default avatarShawn Tabrizi <shawntabrizi@gmail.com>
      
      * Update frame/system/src/lib.rs
      
      Co-Authored-By: default avatarShawn Tabrizi <shawntabrizi@gmail.com>
      
      * Last few fixes
      
      * Another fix
      
      * Build fix
      
      Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
      Co-authored-by: default avatarJaco Greeff <jacogr@gmail.com>
      Co-authored-by: default avatarShawn Tabrizi <shawntabrizi@gmail.com>
      5b7512e2
  21. Feb 13, 2020
  22. Feb 12, 2020
    • Max Inden's avatar
      client/network-gossip: Integrate GossipEngine tasks into Future impl (#4767) · 3f3910cc
      Max Inden authored
      `GossipEngine` spawns two tasks, one for a periodic tick, one to forward
      messages from the network to subscribers. These tasks hold an `Arc` to a
      `GossipEngineInner`.
      
      To reduce the amount of shared ownership (locking) this patch integrates
      the two tasks into a `Future` implementation on the `GossipEngine`
      struct. This `Future` implementation can now be called from a single
      owner, e.g. the `finality-grandpa` `NetworkBridge`.
      
      As a side effect this removes the requirement on the `network-gossip`
      crate to spawn tasks and thereby removes the requirement on the
      `finality-grandpa` crate to spawn any tasks.
      
      This is part of a greater effort to reduce the number of owners of
      components within `finality-grandpa`, `network` and `network-gossip` as
      well as to reduce the amount of unbounded channels. For details see
      d9837d7d, 5f80929d and 597c0a6c.
      3f3910cc
  23. Feb 11, 2020
  24. Feb 10, 2020
    • Ashley's avatar
      Fix timer panics in the wasm light client (#4561) · ead6815a
      Ashley authored
      
      * Make WASM browser thing compile
      
      * Fix
      
      * updated exit-future (github repo)
      
      * Switch to broadcast crate
      
      * Migrate client/cli
      
      * Switch exit-future to modernize branch
      
      * Small changes
      
      * Switch to cargo version and fix fg tests
      
      * fix basic-authorship
      
      * Fix crash on grafana macro
      
      * Fix grafana macro
      
      * Switch node python version
      
      * Disable record_metrics_slice in grafana macro on wasm
      
      * Update client/grafana-data-source/src/lib.rs
      
      * Revert "Update client/grafana-data-source/src/lib.rs"
      
      This reverts commit 888009a8e0b7051bd4bfbbfdb0448bcf2e2aae93.
      
      * Add wasm support for state machine
      
      * Switch to my own libp2p version
      
      * Revert "Switch to my own libp2p version"
      
      This reverts commit ce613871b59264b3165b45c37943e6560240daa7.
      
      * Revert "Add wasm support for state machine"
      
      This reverts commit de7eaa0694d9534fc3b164621737968e9a6a7c5f.
      
      * Add sc-browser
      
      * Squash
      
      * remove sc-browser
      
      * Fix keystore on wasm
      
      * stubs for removed functions to make env compatible with old runtimes
      
      * Add test (that doesn't work)
      
      * Fix build scripts
      
      * Revert basic-authorship due to no panics
      
      * Revert cli/informant
      
      * Revert consensus
      
      * revert offchain
      
      * Update utils/browser/Cargo.toml
      
      Co-Authored-By: default avatarBenjamin Kampmann <ben@gnunicorn.org>
      
      * export console functions
      
      * Add new chainspec
      
      * Fix ws in chain spec
      
      * revert chainspec
      
      * Fix chainspec
      
      * Use an Option<PathBuf> in keystore instead of cfg flags
      
      * Remove crud
      
      * Only use wasm-timer for instant and systemtime
      
      * Remove telemetry changes
      
      * Assuming this is ok
      
      * Add a KeystoreConfig
      
      * Add stubs back in
      
      * Update libp2p
      
      * Revert "Add stubs back in"
      
      This reverts commit 4690cf1882aa0f99f7f00a58c4080c8aa9b77c36.
      
      * Remove commented js again
      
      * Bump kvdb-web version
      
      * Fix cli
      
      * Switch branch on futures-timer
      
      * Fix tests
      
      * Remove sc-client test build in check-web-wasm because there isn't a good way to build futures-timer with wasm-bindgen support in the build
      
      * Remove more things ^^
      
      * Switch branch on futures-timer back
      
      * Put DB io stats behind a cfg flag
      
      * Fix things
      
      * Don't timeout transports on wasm
      
      * Update branch of futures-timer and fix bad merge
      
      * Spawn informant
      
      * Fix network test
      
      * Fix delay resets
      
      * Changes
      
      * Fix tests
      
      * use wasm_timer for transaction pool
      
      * Fixes
      
      * Switch futures-timer to crates
      
      * Only diagnose futures on native
      
      * Fix sc-network-test tests
      
      * Select log level in js
      
      * Fix syncing ;^)
      
      * Allow disabling colours in the informant
      
      * Use OutputFormat enum for informant
      
      * MallocSizeOf impl on transaction pool broke stuff because wasm_timer::Instant doesnt impl it so just revert the transaction pool to master
      
      * Update futures-diagnose
      
      * Revert "MallocSizeOf impl on transaction pool broke stuff because wasm_timer::Instant doesnt impl it so just revert the transaction pool to master"
      
      This reverts commit baa4ffc94fd968b6660a2c17ba8113e06af15548.
      
      * Pass whole chain spec in start_client
      
      * Get Instant::now to work in transaction pool again
      
      * Informant dep reordering
      
      Co-authored-by: default avatarPierre Krieger <pierre.krieger1708@gmail.com>
      Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
      Co-authored-by: default avatarSvyatoslav Nikolsky <svyatonik@gmail.com>
      Co-authored-by: default avatarBenjamin Kampmann <ben.kampmann@googlemail.com>
      Co-authored-by: default avatarDemi Obenour <48690212+DemiMarie-parity@users.noreply.github.com>
      ead6815a
  25. Feb 07, 2020
  26. Feb 06, 2020
    • Wei Tang's avatar
      babe: pass epoch data via intermediates (#4807) · 14b0c9a7
      Wei Tang authored
      * babe: pass epoch data via intermediates
      
      * Switch to use Box<dyn Any> for intermediates
      
      * Set intermediate.epoch to be Option
      
      * Fix proposer should put out an empty intermediate
      
      * Remove unnecessary encode/decode
      
      * Add EpochData to block_import_params in slot worker
      
      * Fix aura compile
      
      * Fix integration test
      14b0c9a7
    • Cecile Tonglet's avatar
      CLI improvements & fixes (#4812) · be075893
      Cecile Tonglet authored
      These are a few changes I missed during the refactoring.
      
      1. Initialization issue and boilerplate
      
          Most importantly: part of the `Configuration` initialization was done in `sc_cli::init`. This means the user can not benefit from this initialization boilerplate if they have multiple `Configuration` since `sc_cli::init` can only be called once.
      
      2. Boilerplate for `VersionInfo` and `Configuration`
      
          I'm also answering to the critic of @bkchr on the initialization using version: https://github.com/paritytech/substrate/pull/4692/files/bea809d4c14a2ede953227ac885e3b3f9771c548#r372047238 This will allow initializing a `Configuration` and provide the version by default.
      
      3. Loading the `chain_spec` explicitly
      
          In the past it was done automatically but in some cases we want to delay this. I moved the code to `Configuration.load_spec()` so it can be called later on. `chain_spec` can also be written directly to the `Configuration` without using this `load_spec` helper.
      
      4. [deleted]
      
      5. Fixing issue that prevents the user to override the port
      
          In the refactoring I introduced a bug by mistake that could potentially prevent the CLI user to override the ports if defaults where provided for these ports (only on cumulus).
      
      6. Change task_executor from Box to Arc
      
          This is useful for cumulus where we have 2 nodes with 2 separate Configuration that need to spawn tasks to the same runtime.
      
      7. Renamed TasksExecutorRequired to TaskExecutor
      
          For consistency.
      
      This is related to https://github.com/paritytech/cumulus/issues/24
      
      This is the continuation (and hopefully the end of) #4692 
      be075893
    • Marcio Diaz's avatar
      f891342f