CLI improvements & fixes (#4812)
These are a few changes I missed during the refactoring. 1. Initialization issue and boilerplate Most importantly: part of the `Configuration` initialization was done in `sc_cli::init`. This means the user can not benefit from this initialization boilerplate if they have multiple `Configuration` since `sc_cli::init` can only be called once. 2. Boilerplate for `VersionInfo` and `Configuration` I'm also answering to the critic of @bkchr on the initialization using version: https://github.com/paritytech/substrate/pull/4692/files/bea809d4c14a2ede953227ac885e3b3f9771c548#r372047238 This will allow initializing a `Configuration` and provide the version by default. 3. Loading the `chain_spec` explicitly In the past it was done automatically but in some cases we want to delay this. I moved the code to `Configuration.load_spec()` so it can be called later on. `chain_spec` can also be written directly to the `Configuration` without using this `load_spec` helper. 4. [deleted] 5. Fixing issue that prevents the user to override the port In the refactoring I introduced a bug by mistake that could potentially prevent the CLI user to override the ports if defaults where provided for these ports (only on cumulus). 6. Change task_executor from Box to Arc This is useful for cumulus where we have 2 nodes with 2 separate Configuration that need to spawn tasks to the same runtime. 7. Renamed TasksExecutorRequired to TaskExecutor For consistency. This is related to https://github.com/paritytech/cumulus/issues/24 This is the continuation (and hopefully the end of) #4692
Showing
- substrate/.gitlab-ci.yml 0 additions, 9 deletionssubstrate/.gitlab-ci.yml
- substrate/.maintain/check_for_exit.sh 0 additions, 16 deletionssubstrate/.maintain/check_for_exit.sh
- substrate/Cargo.lock 73 additions, 1 deletionsubstrate/Cargo.lock
- substrate/bin/node-template/node/src/command.rs 1 addition, 2 deletionssubstrate/bin/node-template/node/src/command.rs
- substrate/bin/node/cli/Cargo.toml 2 additions, 0 deletionssubstrate/bin/node/cli/Cargo.toml
- substrate/bin/node/cli/src/command.rs 3 additions, 4 deletionssubstrate/bin/node/cli/src/command.rs
- substrate/bin/node/cli/tests/running_the_node_and_interrupt.rs 58 additions, 0 deletions...rate/bin/node/cli/tests/running_the_node_and_interrupt.rs
- substrate/client/cli/src/lib.rs 118 additions, 75 deletionssubstrate/client/cli/src/lib.rs
- substrate/client/cli/src/params.rs 3 additions, 2 deletionssubstrate/client/cli/src/params.rs
- substrate/client/cli/src/runtime.rs 4 additions, 2 deletionssubstrate/client/cli/src/runtime.rs
- substrate/client/service/src/builder.rs 3 additions, 3 deletionssubstrate/client/service/src/builder.rs
- substrate/client/service/src/config.rs 45 additions, 11 deletionssubstrate/client/service/src/config.rs
- substrate/client/service/src/error.rs 1 addition, 1 deletionsubstrate/client/service/src/error.rs
- substrate/client/service/src/lib.rs 1 addition, 1 deletionsubstrate/client/service/src/lib.rs
- substrate/client/service/test/src/lib.rs 6 additions, 6 deletionssubstrate/client/service/test/src/lib.rs
- substrate/utils/browser/src/lib.rs 3 additions, 3 deletionssubstrate/utils/browser/src/lib.rs
Please register or sign in to comment