Skip to content
  1. Feb 23, 2023
    • Gonçalo Pestana's avatar
      Abstracts elections-phragmen pallet to use NposSolver (#12588) · b793666c
      Gonçalo Pestana authored
      
      
      * Abstracts elections-phragmen pallet to use NposSolver
      
      * Update frame/elections-phragmen/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/elections-phragmen/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * changes the name of the pallet; adds changelog
      
      * update changelog
      
      * Adds weight testing
      
      * Adds log macro_rules
      
      * renames elections-phragment dir to elections
      
      * weights rename
      
      * fixes typo in cargo toml
      
      * pre/post solve weight scafolding
      
      * refactor do_post_election
      
      * refactors into pre and post election solve for independent benchmarking
      
      * deconstructs PreElectionResults struct
      
      * updates benchmarking pre and post election solve; mock weights
      
      * Update frame/elections/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/elections/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * addresses PR comments
      
      * adds pre_solve and post_sove weights
      
      * Adds comments on election pallet id param name change
      
      * ".git/.scripts/bench-bot.sh" pallet dev pallet_elections
      
      * Finishes pre-post solve weights
      
      * Update frame/elections/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/elections/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Addresses PR comments: no panic in on_init path; nits
      
      * Fixes node build
      
      * Implements approval voting to use as a `NposSolver` (#13367)
      
      * Implements the approval voting methods in sp_npos_elections
      
      * fmt
      
      * remove unecessary file
      
      * comment clarification
      
      * re-run weights
      
      * fix typo
      
      * updates MaxVoters in tests for integrity_tests to pass
      
      * Refactors election provider support benchmarks outside its own crate (#13431)
      
      * Refactors election provider support benchmarks outside its own crate
      ---------
      
      Co-authored-by: command-bot <>
      
      ---------
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      Co-authored-by: parity-processbot <>
      Co-authored-by: default avatarRoss Bulat <[email protected]>
      b793666c
  2. Feb 21, 2023
  3. Feb 20, 2023
    • Michal Kucharczyk's avatar
      `BlockId` removal: `runtime-api` refactor (#13255) · 7a101541
      Michal Kucharczyk authored
      
      
      * BlockId removal: refactor of runtime API
      
      It changes the arguments of:
      - `ApiExt` methods:  `has_api`, `has_api_with`, `api_version`
      - `CallApiAt` method: `runtime_version_at`
      from: `BlockId<Block>` to: `Block::Hash`
      
      It also changes the first argument of all generated runtime API calls from: `BlockId<Block>` to: `Block::Hash`
      
      This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292)
      
      * BlockId removal: refactor of runtime API - tests
      
      - tests adjusted to new runtime API,
      - some tests migrated from block number to block hash
      
      * benchmarking-cli: BlockId(0) migrated to info().genesis_hash
      
      `runtime_api.call()` now requires the block hash instead of BlockId::Number.
      To access the genesis hash widely used in benchmarking engine the Client
      was constrained to satisfy `sp_blockchain::HeaderBackend<Block>` trait
      which provides `info().genesis_hash`.
      
      * trivial: api.call(BlockId) -> api.call(Hash)
      
      - Migrated all `runtime_api.calls` to use Hash
      - Noteworthy (?):
      -- `validate_transaction_blocking` in transaction pool,
      
      * CallApiAtParams::at changed to Block::Hash
      
      * missed doc updated
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * ".git/.scripts/commands/fmt/fmt.sh"
      
      * BlockId removal: Benchmark::consumed_weight
      
      Little refactor around `Benchmark::consumed_weight`: `BlockId` removed.
      
      * at_hash renamed
      
      * wrong merge fixed
      
      * beefy worker: merged with master
      
      * beefy: tests: missing block problem fixed
      
      * Apply review suggestion
      
      * fix
      
      ---------
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: command-bot <>
      7a101541
  4. Feb 17, 2023
    • Piotr Mikołajczyk's avatar
      `try-runtime::fast-forward` (#12896) · 3595d871
      Piotr Mikołajczyk authored
      * try-runtime::fast-forward
      
      * Revert un`pub`ing command's fields
      
      * Handle storage change failure
      
      * Adjust Substrate node
      
      * Feature-gated imports
      
      * doc link
      
      * Feature-gated imports in node-template
      
      * Move trait, blanket implementation and auxiliary functions to a new module
      
      * Distinguish between plain babe+timestamp and substrate enhanced info
      
      * Remove uncles inherents
      
      * Missing argument
      
      * Add doc comment about `blocktime_millis`
      
      * Add licenses
      3595d871
  5. Feb 16, 2023
  6. Feb 14, 2023
  7. Feb 13, 2023
  8. Feb 12, 2023
  9. Feb 08, 2023
  10. Feb 06, 2023
  11. Jan 30, 2023
  12. Jan 29, 2023
  13. Jan 28, 2023
  14. Jan 27, 2023
  15. Jan 26, 2023
  16. Jan 25, 2023
    • Kian Paimani's avatar
      reduce exec time of fast-unstake benchmarks (#13120) · 451a13c6
      Kian Paimani authored
      * reduce exec time of fast-unstake benchmarks
      
      * fix test
      
      * fmt
      
      * fix patch the tests
      
      * fix patch the tests
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
      
      * add batch size as well
      
      * update some benches to be better
      
      * fix one last test
      
      * fix
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
      
      * reduce time even more
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
      
      * fix tests
      
      * nit
      
      * remove
      
      * improve the weight calc further
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
      
      * fix benchmarks
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
      
      * update
      
      * fix
      
      * fix
      
      * fmt
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
      
      * lots of changes again...
      
      * smaller input
      
      * update
      
      * fmt
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
      
      * cleanup
      
      * small simplification
      
      * fmt
      
      * reduce exec time a bit
      
      * fix
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
      
      * test
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
      
      * increase again
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
      
      * review comments
      
      * fmt
      
      * fix
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
      
      Co-authored-by: command-bot <>
      451a13c6
  17. Jan 24, 2023
  18. Jan 21, 2023
  19. Jan 20, 2023
  20. Jan 19, 2023
  21. Jan 18, 2023
    • Sasha Gryaznov's avatar
      [contracts] Add integrity checks by pallet hook (#12993) · 549637d9
      Sasha Gryaznov authored
      
      
      * integrity test for MaxCodeLen and CallStack::len()
      
      * integrity test for MaxDebugBufferLen
      
      * addressed review comments
      
      * fix append_debug_buffer()
      
      * ci fix
      
      * updated code_len_limit formula after further discussion
      
      * enlarged mem safe margin after discussion
      
      * +doc to Config trait associated types
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarAlexander Theißen <[email protected]>
      
      * more lil fixes from code review feedback
      
      * lowered max call depth to satisfy mem limits
      
      * fix node runtime pallet params to satisfy integrity check
      
      * fix max call depth value calc
      
      Co-authored-by: default avatarAlexander Theißen <[email protected]>
      549637d9
  22. Jan 17, 2023
  23. Jan 06, 2023
  24. Jan 04, 2023
  25. Jan 03, 2023
  26. Dec 27, 2022
  27. Dec 26, 2022
    • Bastian Köcher's avatar
      Make CLI state pruning optional again (#13017) · 9f5ed21f
      Bastian Köcher authored
      * Make CLI state pruning optional again
      
      The state pruning setting is stored in the database when it is created. In later runs it is fine to
      drop the `--state-pruning` CLI argument as the setting is stored in the database. The state db will
      only return an error if the stored state pruning doesn't match the state pruning given via CLI.
      
      Recently we improved the state pruning CLI handling and accidentally made the state pruning value
      always present (as we set some default value for the clap). If we could find out if a user has
      passed a value or the default value was taken, we could keep the default value in the CLI interface,
      but clap isn't supporting this right now. So, we need to go back and make `state_pruning` an
      optional with the default written into the docs.
      
      It also adds a test to ensure that we don't break this behavior again.
      
      * More docs
      9f5ed21f
    • Ankan's avatar
      Allow StakingAdmin to set `min_commission` (#13018) · 9726a10d
      Ankan authored
      * staking admin can set min commission
      
      * ".git/.scripts/bench-bot.sh" pallet dev pallet_staking
      
      * fmt
      
      * fix for pr comments
      
      Co-authored-by: command-bot <>
      9726a10d