Skip to content
Snippets Groups Projects
  1. Jun 10, 2024
    • Alexandru Gheorghe's avatar
      Remove unncessary call remove_from_peers_set (#4742) · b65313e8
      Alexandru Gheorghe authored
      ... this is superfluous because set_reserved_peers implementation
      already calls this method here:
      
      https://github.com/paritytech/polkadot-sdk/blob/cdb297b1
      
      /substrate/client/network/src/protocol_controller.rs#L571,
      so the call just ends producing this warnings whenever we manipulate the
      peers set.
      
      ```
      Trying to remove unknown reserved node 12D3KooWRCePWvHoBbz9PSkw4aogtdVqkVDhiwpcHZCqh4hdPTXC from SetId(3)
      peerset warnings (from different peers)
      ```
      
      Signed-off-by: default avatarAlexandru Gheorghe <alexandru.gheorghe@parity.io>
    • Alin Dima's avatar
      add pov-recovery unit tests and support for elastic scaling (#4733) · a3472c44
      Alin Dima authored
      - unit tests for pov-recovery
      - elastic scaling support (recovering multiple candidates in a single
      relay chain block)
      - also some small cleanups
      - also switches to candidates_pending_availability in
      `handle_empty_block_announce_data`
      
      Fixes https://github.com/paritytech/polkadot-sdk/issues/3577
      
      After https://github.com/paritytech/polkadot-sdk/pull/4097 is merged, we
      should also add a zombienet test, similar to the existing
      `0002-pov_recovery.toml` but which has a single collator using elastic
      scaling on multiple cores.
    • Alexandru Gheorghe's avatar
      approval-voting: Add no shows debug information (#4726) · 2869fd6a
      Alexandru Gheorghe authored
      
      Add some debug logs to be able to identify the validators and parachains
      that have most no-shows, this metric is valuable because it will help us
      identify validators and parachains that regularly have this problem.
      
      From the validator_index we can then query the on-chain information and
      identify the exact validator that is causing the no-shows.
      
      ---------
      
      Signed-off-by: default avatarAlexandru Gheorghe <alexandru.gheorghe@parity.io>
    • Przemek Rzad's avatar
      Revamp the Readme of the parachain template (#4713) · 497d64ef
      Przemek Rzad authored
      - Addresses
      [this](https://github.com/paritytech/polkadot-sdk/issues/3155#issuecomment-2126934939).
      - Revamps the Readme, very similar to [the minimal
      template](https://github.com/paritytech/polkadot-sdk/pull/4649).
      - Changed `polkadot-launch` to `zombienet`, with instructions how to run
      it.
      - See the [rendered
      version](https://github.com/paritytech/polkadot-sdk/blob/rzadp/parachain-template-readme/templates/parachain/README.md).
  2. Jun 08, 2024
  3. Jun 07, 2024
  4. Jun 06, 2024
  5. Jun 05, 2024
    • Adrian Catangiu's avatar
      fix build on MacOS: bump secp256k1 and secp256k1-sys to patched versions (#4709) · 2460cddf
      Adrian Catangiu authored
      `secp256k1 v0.28.0` and `secp256k1-sys v0.9.0` were yanked because
      building them fails for `aarch64-apple-darwin` targets.
      
      Use the `secp256k1 v0.28.2` and `secp256k1-sys v0.9.2` patched versions
      that build fine on ARM chipset MacOS.
    • Oliver Tale-Yazdi's avatar
      Unify dependency aliases (#4633) · d2fd5364
      Oliver Tale-Yazdi authored
      
      Inherited workspace dependencies cannot be renamed by the crate using
      them (see [1](https://github.com/rust-lang/cargo/issues/12546),
      [2](https://stackoverflow.com/questions/76792343/can-inherited-dependencies-in-rust-be-aliased-in-the-cargo-toml-file)).
      Since we want to use inherited workspace dependencies everywhere, we
      first need to unify all aliases that we use for a dependency throughout
      the workspace.
      The umbrella crate is currently excluded from this procedure, since it
      should be able to export the crates by their original name without much
      hassle.
      
      For example: one crate may alias `parity-scale-codec` to `codec`, while
      another crate does not alias it at all. After this change, all crates
      have to use `codec` as name. The problematic combinations were:
      - conflicting aliases: most crates aliases as `A` but some use `B`.
      - missing alias: most of the crates alias a dep but some dont.
      - superfluous alias: most crates dont alias a dep but some do.
      
      The script that i used first determines whether most crates opted to
      alias a dependency or not. From that info it decides whether to use an
      alias or not. If it decided to use an alias, the most common one is used
      everywhere.
      
      To reproduce, i used
      [this](https://github.com/ggwpez/substrate-scripts/blob/master/uniform-crate-alias.py)
      python script in combination with
      [this](https://github.com/ggwpez/zepter/blob/38ad10585fe98a5a86c1d2369738bc763a77057b/renames.json)
      error output from Zepter.
      
      ---------
      
      Signed-off-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
    • ordian's avatar
      statement-distribution: prep for re-enabling (#4431) · 0d661eac
      ordian authored
      In preparation for launching re-enabling
      (https://github.com/paritytech/polkadot-sdk/issues/2418), we need to
      adjust the disabling strategy of statement-distribution to use the relay
      parent's state instead of the latest state (union of active leaves).
      This will also ensure no raciness of getting the latest state vs
      accepting statements from disabling validators at the cost of being more
      lenient/potentially accepting more statements from disabled validators.
      
      - [x] PRDoc
    • Oliver Tale-Yazdi's avatar
      Rococo AH: cleanup storage (#4444) · d1299683
      Oliver Tale-Yazdi authored
      
      Follow up on #4414 to clean up the old storage.
      
      ---------
      
      Signed-off-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
    • Michal Kucharczyk's avatar
      chain-spec-doc: some minor fixes (#4700) · f65beb7f
      Michal Kucharczyk authored
      some minor text fixes.
    • Przemek Rzad's avatar
      Update the `polkadot_builder` Dockerfile (#4638) · 8ffe2290
      Przemek Rzad authored
      
      This Dockerfile seems outdated - it currently fails to build (on my
      machine).
      I don't see it being built anywhere on CI.
      
      I did a couple of tweaks to make it build.
      
      ---------
      
      Co-authored-by: default avatarAlexander Samusev <41779041+alvicsam@users.noreply.github.com>
    • georgepisaltu's avatar
      [Identity] Remove double encoding username signature payload (#4646) · 3977f389
      georgepisaltu authored
      In order to receive a username in `pallet-identity`, users have to,
      among other things, provide a signature of the desired username. Right
      now, there is an [extra encoding
      step](https://github.com/paritytech/polkadot-sdk/blob/4ab078d6
      
      /substrate/frame/identity/src/lib.rs#L1119)
      when generating the payload to sign.
      
      Encoding a `Vec` adds extra bytes related to the length, which changes
      the payload. This is unnecessary and confusing as users expect the
      payload to sign to be just the username bytes. This PR fixes this issue
      by validating the signature directly against the username bytes.
      
      ---------
      
      Signed-off-by: default avatargeorgepisaltu <george.pisaltu@parity.io>
  6. Jun 04, 2024
  7. Jun 03, 2024
  8. Jun 02, 2024