Skip to content
Snippets Groups Projects
Unverified Commit b65313e8 authored by Alexandru Gheorghe's avatar Alexandru Gheorghe Committed by GitHub
Browse files

Remove unncessary call remove_from_peers_set (#4742)

... this is superfluous because set_reserved_peers implementation
already calls this method here:

https://github.com/paritytech/polkadot-sdk/blob/cdb297b1

/substrate/client/network/src/protocol_controller.rs#L571,
so the call just ends producing this warnings whenever we manipulate the
peers set.

```
Trying to remove unknown reserved node 12D3KooWRCePWvHoBbz9PSkw4aogtdVqkVDhiwpcHZCqh4hdPTXC from SetId(3)
peerset warnings (from different peers)
```

Signed-off-by: default avatarAlexandru Gheorghe <alexandru.gheorghe@parity.io>
parent a3472c44
No related merge requests found
Pipeline #480681 waiting for manual action with stages
in 1 hour, 13 minutes, and 4 seconds
......@@ -88,16 +88,6 @@ impl<N: Network, AD: AuthorityDiscovery> Service<N, AD> {
{
gum::warn!(target: LOG_TARGET, err = ?e, "AuthorityDiscoveryService returned an invalid multiaddress");
}
// the addresses are known to be valid
//
// for peer-set management, the main protocol name should be used regardless of
// the negotiated version.
let _ = network_service
.remove_from_peers_set(
self.peerset_protocol_names.get_main_name(peer_set),
peers_to_remove,
)
.await;
network_service
}
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment