Skip to content
Snippets Groups Projects
  1. Apr 15, 2022
    • Georges's avatar
      Adding benchmarking for new `frame_election_provider_support` (#11149) · ae75a371
      Georges authored
      * First stab at adding benchmarking for
      `election-provider-support` onchain
      
      * Adding `BoundedPhragMMS` and fixing stuff
      
      * Fixing node runtime
      
      * Fixing tests
      
      * Finalising all benchmarking stuff
      
      * better comments
      
      * Better benchmarking config
      
      * Better `WeightInfo` and benchmarking
      
      * Fixing tests
      
      * Adding some documentation
      
      * Fixing some typos
      
      * Incorporating review feedback
      
      * cleanup of rustdocs
      
      * rustdoc changes
      
      * changes after code review
      
      * Fixing some errors.
      
      * Fixing dependencies post merge
      
      * Bringing back `UnboundedExecution`
      
      * Better rustdoc and naming
      
      * Cargo.toml formatting
      ae75a371
  2. Apr 13, 2022
    • Adrian Catangiu's avatar
      Expose MMR root through runtime API - use it in BEEFY client (#11183) · 80ce5c57
      Adrian Catangiu authored
      * beefy-gadget: allow custom runtime api provider
      
      * beefy-gadget: use mock runtime api in tests
      
      * pallet-mmr: expose mmr root from state through runtime API
      
      * beefy-gadget: get mmr root from runtime state
      
      * pallet-beefy-mmr: remove MmrRoot from header digests
      
      * frame/mmr: move mmr primitives out of frame
      
      * frame/mmr: completely move primitives out of frame
      
      * address review comments
      
      * beefy-mmr: bring back mmr root from header digest
      
      * clippy fixes for rustc 1.60
      
      * address review comments
      80ce5c57
  3. Apr 11, 2022
    • Koute's avatar
      Add new hardware and software metrics (#11062) · 8351ada6
      Koute authored
      * Add new hardware and software metrics
      
      * Move sysinfo tests into `mod tests`
      
      * Correct a typo in a comment
      
      * Remove unnecessary `nix` dependency
      
      * Fix the version tests
      
      * Add a `--disable-hardware-benchmarks` CLI argument
      
      * Disable hardware benchmarks in the integration tests
      
      * Remove unused import
      
      * Fix benchmarks compilation
      
      * Move code to a new `sc-sysinfo` crate
      
      * Correct `impl_version` comment
      
      * Move `--disable-hardware-benchmarks` to the chain-specific bin crate
      
      * Move printing out of hardware bench results to `sc-sysinfo`
      
      * Move hardware benchmarks to a separate messages; trigger them manually
      
      * Rename some of the fields in the `HwBench` struct
      
      * Revert changes to the telemetry crate; manually send hwbench messages
      
      * Move sysinfo logs into the sysinfo crate
      
      * Move the `TARGET_OS_*` constants into the sysinfo crate
      
      * Minor cleanups
      
      * Move the `HwBench` struct to the sysinfo crate
      
      * Derive `Clone` for `HwBench`
      
      * Fix broken telemetry connection notification stream
      
      * Prevent the telemetry connection notifiers from leaking if they're disconnected
      
      * Turn the telemetry notification failure log into a debug log
      
      * Rename `--disable-hardware-benchmarks` to `--no-hardware-benchmarks`
      8351ada6
  4. Mar 16, 2022
    • cheme's avatar
      State migration rpc (#10981) · 800cc1d4
      cheme authored
      
      * setting flag
      
      * flag in storage struct
      
      * fix flagging to access and insert.
      
      * added todo to fix
      
      * also missing serialize meta to storage proof
      
      * extract meta.
      
      * Isolate old trie layout.
      
      * failing test that requires storing in meta when old hash scheme is used.
      
      * old hash compatibility
      
      * Db migrate.
      
      * runing tests with both states when interesting.
      
      * fix chain spec test with serde default.
      
      * export state (missing trie function).
      
      * Pending using new branch, lacking genericity on layout resolution.
      
      * extract and set global meta
      
      * Update to branch 4
      
      * fix iterator with root flag (no longer insert node).
      
      * fix trie root hashing of root
      
      * complete basic backend.
      
      * Remove old_hash meta from proof that do not use inner_hashing.
      
      * fix trie test for empty (force layout on empty deltas).
      
      * Root update fix.
      
      * debug on meta
      
      * Use trie key iteration that do not include value in proofs.
      
      * switch default test ext to use inner hash.
      
      * small integration test, and fix tx cache mgmt in ext.
      test  failing
      
      * Proof scenario at state-machine level.
      
      * trace for db upgrade
      
      * try different param
      
      * act more like iter_from.
      
      * Bigger batches.
      
      * Update trie dependency.
      
      * drafting codec changes and refact
      
      * before removing unused branch no value alt hashing.
      more work todo rename all flag var to alt_hash, and remove extrinsic
      replace by storage query at every storage_root call.
      
      * alt hashing only for branch with value.
      
      * fix trie tests
      
      * Hash of value include the encoded size.
      
      * removing fields(broken)
      
      * fix trie_stream to also include value length in inner hash.
      
      * triedbmut only using alt type if inner hashing.
      
      * trie_stream to also only use alt hashing type when actually alt hashing.
      
      * Refactor meta state, logic should work with change of trie treshold.
      
      * Remove NoMeta variant.
      
      * Remove state_hashed trigger specific functions.
      
      * pending switching to using threshold, new storage root api does not
      make much sense.
      
      * refactoring to use state from backend (not possible payload changes).
      
      * Applying from previous state
      
      * Remove default from storage, genesis need a special build.
      
      * rem empty space
      
      * Catch problem: when using triedb with default: we should not revert
      nodes: otherwhise thing as trie codec cannot decode-encode without
      changing state.
      
      * fix compilation
      
      * Right logic to avoid switch on reencode when default layout.
      
      * Clean up some todos
      
      * remove trie meta from root upstream
      
      * update upstream and fix benches.
      
      * split some long lines.
      
      * UPdate trie crate to work with new design.
      
      * Finish update to refactored upstream.
      
      * update to latest triedb changes.
      
      * Clean up.
      
      * fix executor test.
      
      * rust fmt from master.
      
      * rust format.
      
      * rustfmt
      
      * fix
      
      * start host function driven versioning
      
      * update state-machine part
      
      * still need access to state version from runtime
      
      * state hash in mem: wrong
      
      * direction likely correct, but passing call to code exec for genesis
      init seem awkward.
      
      * state version serialize in runtime, wrong approach, just initialize it
      with no threshold for core api < 4 seems more proper.
      
      * stateversion from runtime version (core api >= 4).
      
      * update trie, fix tests
      
      * unused import
      
      * clean some TODOs
      
      * Require RuntimeVersionOf for executor
      
      * use RuntimeVersionOf to resolve genesis state version.
      
      * update runtime version test
      
      * fix state-machine tests
      
      * TODO
      
      * Use runtime version from storage wasm with fast sync.
      
      * rustfmt
      
      * fmt
      
      * fix test
      
      * revert useless changes.
      
      * clean some unused changes
      
      * fmt
      
      * removing useless trait function.
      
      * remove remaining reference to state_hash
      
      * fix some imports
      
      * Follow chain state version management.
      
      * trie update, fix and constant threshold for trie layouts.
      
      * update deps
      
      * Update to latest trie pr changes.
      
      * fix benches
      
      * Verify proof requires right layout.
      
      * update trie_root
      
      * Update trie deps to  latest
      
      * Update to latest trie versioning
      
      * Removing patch
      
      * update lock
      
      * extrinsic for sc-service-test using layout v0.
      
      * Adding RuntimeVersionOf to CallExecutor works.
      
      * fmt
      
      * error when resolving version and no wasm in storage.
      
      * use existing utils to instantiate runtime code.
      
      * migration pallet
      
      * Patch to delay runtime switch.
      
      * Revert "Patch to delay runtime switch."
      
      This reverts commit 67e55fee468f1a0cda853f5362b22e0d775786da.
      
      * fix test
      
      * fix child migration calls.
      
      * useless closure
      
      * remove remaining state_hash variables.
      
      * Fix and add more tests
      
      * Remove outdated comment
      
      * useless inner hash
      
      * fmt
      
      * remote tests
      
      * finally ksm works
      
      * batches are broken
      
      * clean the benchmarks
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarGuillaume Thiolliere <gui.thiolliere@gmail.com>
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarGuillaume Thiolliere <gui.thiolliere@gmail.com>
      
      * Update frame/state-trie-migration/src/lib.rs
      
      Co-authored-by: default avatarJoshy Orndorff <JoshOrndorff@users.noreply.github.com>
      
      * Update frame/state-trie-migration/src/lib.rs
      
      * brand new version
      
      * fix build
      
      * Update frame/state-trie-migration/src/lib.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <gui.thiolliere@gmail.com>
      
      * Update frame/state-trie-migration/src/lib.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <gui.thiolliere@gmail.com>
      
      * Update primitives/storage/src/lib.rs
      
      Co-authored-by: default avatarcheme <emericchevalier.pro@gmail.com>
      
      * Update frame/state-trie-migration/src/lib.rs
      
      Co-authored-by: default avatarcheme <emericchevalier.pro@gmail.com>
      
      * Update frame/state-trie-migration/src/lib.rs
      
      Co-authored-by: default avatarcheme <emericchevalier.pro@gmail.com>
      
      * fmt and opt-in feature to apply state change.
      
      * feature gate core version, use new test feature for node and test node
      
      * Use a 'State' api version instead of Core one.
      
      * fix merge of test function
      
      * use blake macro.
      
      * Fix state api (require declaring the api in runtime).
      
      * Opt out feature, fix macro for io to select a given version
      instead of latest.
      
      * run test nodes on new state.
      
      * fix
      
      * new test structure
      
      * new testing stuff from emeric
      
      * Add commit_all, still not working
      
      * Fix all tests
      
      * add comment
      
      * we have PoV tracking baby
      
      * document stuff, but proof size is still wrong
      
      * FUCK YEAH
      
      * a big batch of review comments
      
      * add more tests
      
      * tweak test
      
      * update config
      
      * some remote-ext stuff
      
      * delete some of the old stuff
      
      * sync more files with master to minimize the diff
      
      * Fix all tests
      
      * make signed migration a bit more relaxed
      
      * add witness check to signed submissions
      
      * allow custom migration to also go above limit
      
      * Fix these pesky tests
      
      * ==== removal of the unsigned stuff ====
      
      * Make all tests work again
      
      * separate the tests from the logic so it can be reused easier
      
      * fix overall build
      
      * Update frame/state-trie-migration/src/lib.rs
      
      Co-authored-by: default avatarcheme <emericchevalier.pro@gmail.com>
      
      * Update frame/state-trie-migration/src/lib.rs
      
      Co-authored-by: default avatarcheme <emericchevalier.pro@gmail.com>
      
      * Slightly better termination
      
      * some final tweaks
      
      * Fix tests
      
      * Restrict access to signed migrations
      
      * mig rpc
      
      * fix
      
      * better rpc name
      
      * Make rpc unsafe
      
      * address most of the review comments
      
      * fix defensive
      
      * New simplified code
      
      * Fix weights
      
      * fmt
      
      * Update frame/state-trie-migration/src/lib.rs
      
      Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
      
      * make the tests correctly fail
      
      * Fix build
      
      * Fix build
      
      * try and fix the benchmarks
      
      * fix build
      
      * Fix cargo file
      
      * Fix runtime deposit
      
      * make rustdoc happy
      
      * cargo run --quiet --profile=production  --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_state_trie_migration --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/state-trie-migration/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * update rpc deps, try to process empty keys.
      
      * move rpc crate
      
      * move check backend out of state machine
      
      * Add primitive crate.
      
      * module code
      
      * fix runtime test
      
      * StateMigrationStatusProvider
      
      * Pass backend to rpc.
      
      * fmt
      
      * review changes
      
      * move rpc crate
      
      * try remove primitive crate
      
      * Update utils/frame/rpc/state-trie-migration-rpc/Cargo.toml
      
      Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
      
      * review changes.
      
      Co-authored-by: default avatarkianenigma <kian@parity.io>
      Co-authored-by: default avatarKian Paimani <5588131+kianenigma@users.noreply.github.com>
      Co-authored-by: default avatarGuillaume Thiolliere <gui.thiolliere@gmail.com>
      Co-authored-by: default avatarJoshy Orndorff <JoshOrndorff@users.noreply.github.com>
      Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
      Co-authored-by: default avatarParity Bot <admin@parity.io>
      800cc1d4
  5. Mar 14, 2022
  6. Mar 01, 2022
  7. Feb 26, 2022
    • Davide Galassi's avatar
      Replace libsecp256k1 with secp256k1 (#10798) · 4aab84cc
      Davide Galassi authored
      * Replace libsecp256k1 with secp256k1
      
      * Wipe ecdsa secret key from memory on drop
      
      * Some comments for a known issue
      
      * Safer core crypto primitives `from_slice` constructor
      
      Previous version panics if slice lenght is not the expected one.
      
      * Unit test fix
      
      * Enable use of global secp256k1 context
      
      * Better comments for ecdsa `Pair` drop
      
      * Replace `libsecp256k1` with `seco256k1` in `beefy-mmr`
      
      Used to convert ecdsa public key to ETH address
      
      * Replace `libsecp256k1` with `secp256k1` in FRAME `contracts`benchmarks
      
      * Temporary rollback of `beefy-mmr` to libsecp256k1
      
      Check for detected build issues
      
      * Cargo fmt
      
      * Rollback of FRAME `contracts` benchmarks to `libsecp256k1`
      
      * Rollback for unrelated changes
      
      * Typo fix
      
      * Add comments for deprecated `ecdsa_verify` and `secp256k1_ecdsa_recover`
      4aab84cc
  8. Feb 23, 2022
    • Davide Galassi's avatar
      Replace libsecp256k1 with k256 in FRAME related code (#10883) · a2b80edf
      Davide Galassi authored
      * Replace libsecp256k1 with k256 in beefy-mmr
      
      * Port of FRAME `contracts` benchmarking from `libsecp256k1` to `k256`
      
      * Newtype to allow `Pcg32` rng usage with `k256` in contracts benchmarks
      
      * Use `sp-io::crypto` to generate dummy keys in `contracts` bechmarks
      
      * More compact code
      
      * Cargo fmt
      
      * Build `sp-keystore` only for dev profile
      
      * Move public key generation back to the `map`
      a2b80edf
  9. Feb 06, 2022
    • Gavin Wood's avatar
      Referenda and Conviction Voting pallets (#10195) · a6891951
      Gavin Wood authored
      * Initial draft of new referendum state machine.
      
      * Docs
      
      * Fixes
      
      * Fixes
      
      * Add conviction-voting pallet
      
      * Basic build
      
      * Building
      
      * Some TODOs
      
      * Tests building
      
      * Add missing file
      
      * Basic lifecycle test
      
      * Add couple of tests
      
      * Another test
      
      * More tests
      
      * Fixes
      
      * Fixes
      
      * Formatting
      
      * Fixes
      
      * Tests
      
      * Fixes
      
      * Fixes
      
      * More tests
      
      * Formatting
      
      * First few benchmarks
      
      * First few benchmarks
      
      * Defered queue servicing
      
      * More testing
      
      * Benchmarks
      
      * Fiddly benchmark
      
      * Final nudge benchmarks
      
      * Formatting
      
      * Formatting
      
      * Finished up benchmarks
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_referenda --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/referenda/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Events finished
      
      * Missing file
      
      * No GenesisConfig for Referenda
      
      * Formatting
      
      * Docs
      
      * Docs
      
      * Docs
      
      * Per-class conviction voting
      
      * New test & mock utils
      
      * More tests
      
      * Tests
      
      * Tests finished :tada:
      
      
      
      * Benchmarking stuff
      
      * Fixes
      
      * Test harness
      
      * Test harness
      
      * Benchmarks for Conviction=Voting
      
      * Benchmarking pipeline complete
      
      * Docs
      
      * Formatting
      
      * Remove unneeded warning
      
      * Fix UI tests
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_conviction_voting --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/conviction-voting/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Docs
      
      * Update frame/conviction-voting/src/vote.rs
      
      Co-authored-by: default avatarShawn Tabrizi <shawntabrizi@gmail.com>
      
      * update sp-runtime version
      
      * MEL Fixes for Referenda and Conviction Voting (#10725)
      
      * free maxencodedlen
      
      * more maxencodedlen
      
      * more MEL
      
      * more mel
      
      * disable storage info
      
      * More Referenda Patches (#10760)
      
      * basic fixes
      
      * fix benchmarking
      
      * fix license
      
      * prevent panic in curve math
      
      * fmt
      
      * bump crate versions
      
      * Update mock.rs
      
      Co-authored-by: default avatarParity Bot <admin@parity.io>
      Co-authored-by: default avatarShawn Tabrizi <shawntabrizi@gmail.com>
      a6891951
  10. Jan 24, 2022
  11. Jan 10, 2022
  12. Dec 13, 2021
  13. Dec 11, 2021
    • Gavin Wood's avatar
      Preimage registrar and Scheduler integration (#10356) · 5e50e0bc
      Gavin Wood authored
      
      * initial idea
      
      * more
      
      * fix compile
      
      * add clear and request logic
      
      * improve some docs
      
      * Add and implement trait
      
      * continuing to improve
      
      * refcount type
      
      * infallible system preimage upload
      
      * fmt
      
      * fix requests
      
      * Make it simple
      
      * Make it simple
      
      * Formatting
      
      * Initial draft
      
      * request when scheduled
      
      * Docs
      
      * Scheduler good
      
      * Scheduler good
      
      * Scheduler tests working
      
      * Add new files
      
      * Missing stuff
      
      * Repotting, add weights.
      
      * Add some tests to preimage pallet
      
      * More tests
      
      * Fix benchmarks
      
      * preimage benchmarks
      
      * All preimage benchmarks
      
      * Tidy cargo
      
      * Update weights.rs
      
      * Allow hash provision in benchmarks
      
      * Initial work on new benchmarks for Scheduler
      
      * Tests working, refactor looks good
      
      * Tests for new Scheduler functionality
      
      * Use real weight, make tests work with runtimes without Preimage
      
      * Rename
      
      * Update benchmarks
      
      * Formatting
      
      * Formatting
      
      * Fix weird formatting
      
      * Update frame/preimage/src/lib.rs
      
      * Fix try-runtime build
      
      * Fixes
      
      * Fixes
      
      * Update frame/support/src/traits/tokens/currency.rs
      
      Co-authored-by: default avatarKian Paimani <5588131+kianenigma@users.noreply.github.com>
      
      * Update frame/support/src/traits/tokens/currency/reservable.rs
      
      Co-authored-by: default avatarKian Paimani <5588131+kianenigma@users.noreply.github.com>
      
      * Update frame/support/src/traits/tokens/imbalance.rs
      
      Co-authored-by: default avatarKian Paimani <5588131+kianenigma@users.noreply.github.com>
      
      * Update frame/preimage/src/mock.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <gui.thiolliere@gmail.com>
      
      * Update frame/scheduler/src/lib.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <gui.thiolliere@gmail.com>
      
      * Update frame/preimage/src/lib.rs
      
      * Fixes
      
      * Fixes
      
      * Formatting
      
      * Fixes
      
      * Fixes
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_scheduler --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/scheduler/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_preimage --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/preimage/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      Co-authored-by: default avatarShawn Tabrizi <shawntabrizi@gmail.com>
      Co-authored-by: default avatarKian Paimani <5588131+kianenigma@users.noreply.github.com>
      Co-authored-by: default avatarGuillaume Thiolliere <gui.thiolliere@gmail.com>
      Co-authored-by: default avatarParity Bot <admin@parity.io>
      5e50e0bc
  14. Dec 07, 2021
    • Gautam Dhameja's avatar
      Add child-bounties pallet. (#10309) · 752e050c
      Gautam Dhameja authored
      
      * Extract child-bounties as a separate pallet.
      
      * Initial tests added.
      
      * More tests.
      
      * Tests complete. Fixed curator fee issue.
      
      * Fixed comments.
      
      * Added benchmarks for child-bounties pallet.
      
      * Added weights.
      
      * Fixed formatting.
      
      * Fixed comments.
      
      * Re-run benchmarks for bounties pallet.
      
      * Make cargo fmt happy again
      
      * add max encoded len
      
      * use event structs
      
      * fmt
      
      * fix compile
      
      * Addressed review comments.
      
      * Use config type instead of const in benchmarking.
      
      * Addressed more review comments.
      
      * Use ensure_can_withdraw instead of just checking min balance.
      
      * fmt.
      
      * Introduce ChildBountyCuratorDepositBase to avoid zero curator deposits for child bounties.
      
      * Fix unassign curator logic for child-bounties.
      
      * Added more tests for unassign curator.
      
      * Reduce bounty description max length in node runtime.
      
      * Updated weights for child bounties pallet.
      
      * reduce indentation of unassign_curator
      
      * more indentation reduction
      
      * deduplicate slashing arms
      
      * reintroduce ensure check
      
      * add assertion to check that bad unassign origin fails
      
      * formatting
      
      * Updated comments.
      
      Co-authored-by: default avatarRicardo Rius <ricardo@parity.io>
      Co-authored-by: default avatarShawn Tabrizi <shawntabrizi@gmail.com>
      Co-authored-by: default avatarAlexander Popiak <alexander.popiak@parity.io>
      752e050c
  15. Nov 19, 2021
    • Georges's avatar
      Moving `pallet-asset-tx-payment` from cumulus to substrate (#10127) · 439af98e
      Georges authored
      
      * Moving `pallet-asset-tx-payment` from cumulus
      
      * move pallet-asset-tx-payment into transaction payment directory
      
      * cargo +nightly fmt
      
      * Adding `pallet-asset-tx-payment` to node runtime
      I had to change the Balance type to u128.
      Also harmonised that pallet's version
      
      * Updating cargo.lock after merge
      
      * forgot this
      
      * Adding tx-payment signature
      
      * Missed one more
      
      * `transaction-payment` replaced in`SignedExtension`
      by `asset-tx-payment` and not added
      
      * Fixing benches
      
      * add test to verify that we don't charge on post-dispatch if we didn't on pre-dispatch
      
      * add (failing) test for asset tx payment of unsigned extrinsics
      
      * fix test by removing debug_assert
      
      * cargo +nightly fmt
      
      * typo in `Cargo.lock`
      
      * Object defined twice in lock file
      
      * cargo update
      
      * remove todo
      
      * Apply formatting suggestions from code review
      
      Co-authored-by: default avatarKian Paimani <5588131+kianenigma@users.noreply.github.com>
      
      * Refactoring `post_dispatch` of `asset-tx-payment`
      to reuse `post_dispatch` of `transaction-payment` if the fee asset is
      native
      Removing unneeded imports.
      
      * Removing redundant `TODO`
      
      * Reverting an accidental bump of `impl-serde`
       from `0.3.1` to `0.3.2`
      
      * Revert unneeded changes to `cargo.lock`
      
      * Update frame/transaction-payment/asset-tx-payment/src/payment.rs
      
      Co-authored-by: default avatarKian Paimani <5588131+kianenigma@users.noreply.github.com>
      
      * Fixing cargo fmt
      
      Reverting changes which broke cargo fmt
      
      Co-authored-by: default avatarAlexander Popiak <alexander.popiak@parity.io>
      Co-authored-by: default avatarAlexander Popiak <alexander.popiak@gmail.com>
      Co-authored-by: default avatarKian Paimani <5588131+kianenigma@users.noreply.github.com>
      439af98e
  16. Nov 12, 2021
  17. Nov 10, 2021
  18. Nov 08, 2021
    • David's avatar
      Remove the RPC client example (#10217) · 3c624174
      David authored
      * Remove the RPC client example
      
      Might be slightly contentious but I think we want to migrate this example to `subxt` and redirect the community to use that for things like this.
      
      * Remove rpc-client example code from workspace
      3c624174
  19. Nov 02, 2021
  20. Nov 01, 2021
  21. Oct 31, 2021
    • Zeke Mostov's avatar
      Fuzzer for Pallet Bags List (#9851) · 21c8d18c
      Zeke Mostov authored
      
      * Fuzzer for Pallet Bags List
      
      * Some small updates
      
      * Fuzzer for Pallet Bags List
      
      This PR adds a fuzzer for the `SortedListProvider` API exposed by pallet-bags-list.
      
      * Feature gate code NOT used by fuzz feature
      
      * Create Enum for list actions
      
      * fix some small mistakes
      
      * try and make CI happy
      
      * fmt
      
      * Do not insert before updating
      
      * clean up some misc. comments
      
      * marginally improve Node::sanity_check
      
      * Change ID_RANGE to 25_000
      
      * comma
      
      * try improve correct feature gating so no unused code
      
      Co-authored-by: default avatarthiolliere <gui.thiolliere@gmail.com>
      21c8d18c
    • thiolliere's avatar
      Automatic pallet parts in construct_runtime (#9681) · 4292e18e
      thiolliere authored
      
      * implement automatic parts
      
      * ui tests
      
      * rename
      
      * remove unnecessary exclude
      
      * better doc
      
      * better doc
      
      * fix genesis config
      
      * fix UI tests
      
      * fix UI test
      
      * Revert "fix UI test"
      
      This reverts commit a910351c0b24cfe42195cfd97d83a416640e3259.
      
      * implemented used_parts
      
      * Update frame/support/procedural/src/construct_runtime/mod.rs
      
      Co-authored-by: default avatarKeith Yeung <kungfukeith11@gmail.com>
      
      * doc + fmt
      
      * Update frame/support/procedural/src/construct_runtime/parse.rs
      
      Co-authored-by: default avatarKeith Yeung <kungfukeith11@gmail.com>
      
      * add doc in the macro
      
      * remove yet some more parts
      
      * fix ui test
      
      * more determnistic error message + fix ui tests
      
      * fix ui test
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarKeith Yeung <kungfukeith11@gmail.com>
      
      * do refactor + fix ui tests
      
      * fmt
      
      * fix test
      
      * fix test
      
      * fix ui test
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarKeith Yeung <kungfukeith11@gmail.com>
      
      * refactor
      
      * remove even more part in node-runtime
      
      * fix test
      
      * Add flow chart for the construct_runtime! execution flow
      
      * Fix typo
      
      * Ignore snippets that don't contain code
      
      * Refactor some code in expand_after
      
      * Rename expand_after to match_and_insert
      
      * cargo fmt
      
      * Fix rename
      
      * Remove frame_support argument to construct_runtime_parts
      
      * Make use of tt-call to simplify intermediate expansions
      
      * cargo fmt
      
      * Update match_and_insert documentation
      
      * Reset cursor to 0 when no matching patterns are found
      
      * Reorder struct fields on MatchAndInsertDef
      
      * Add test for dependency renames and fix frame-support import
      
      * Add more doc comments
      
      * Update frame/support/test/compile_pass/src/lib.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <gui.thiolliere@gmail.com>
      
      Co-authored-by: default avatarKeith Yeung <kungfukeith11@gmail.com>
      Co-authored-by: default avatarShawn Tabrizi <shawntabrizi@gmail.com>
      4292e18e
  22. Sep 23, 2021
    • Andreas Doerr's avatar
      Integrate BEEFY (#9833) · 283c8daa
      Andreas Doerr authored
      
      * Initial project setup and skeleton (#4)
      
      * initial project setup for beefy gadget client
      
      * update editorconfig
      
      * update gitignore
      
      * add initial skeleton for beefy gadget worker
      
      * add skeleton for gossip processing
      
      * add app crypto
      
      * move around some code
      
      * add basic flow for voting
      
      * add logic for picking blocks to sign
      
      * add rustfmt config
      
      * add example node with beefy gadget
      
      * use u32::next_power_of_two
      
      * make maximum periodicity configurable
      
      * add copyright header
      
      * rename max_periodicity to min_interval
      
      * CI stuff (#5)
      
      * CI stuff.
      
      * Fix workspace.
      
      * cargo fmt --all
      
      * Add license for beefy-gadget
      
      * One toolchain to rule them all.
      
      * Clippy.
      
      * Fix clippy.
      
      * Clippy in the runtime.
      
      * Fix clippy grumbles.
      
      * cargo fmt --all
      
      * Primitives & Light Client examples (#8)
      
      * Primitives.
      
      * Docs.
      
      * Document primitives.
      
      * Simple tests.
      
      * Light client examples.
      
      * Fix stuff.
      
      * cargo fmt --all
      
      * Add a bunch of tests for imports.
      
      * Add more examples.
      
      * cargo fmt --all
      
      * Fix clippy.
      
      * cargo fmt --all
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarAndré Silva <123550+andresilva@users.noreply.github.com>
      
      * Add GRANDPA / FG clarifications.
      
      * Fix min number of signatures.
      
      Co-authored-by: default avatarAndré Silva <123550+andresilva@users.noreply.github.com>
      
      * Update to substrate master (#22)
      
      * update to substrate master
      
      * update dependencies
      
      * fix clippy issues
      
      Co-authored-by: default avatarTomasz Drwięga <tomasz@parity.io>
      
      * Add beefy pallet (#25)
      
      * move beefy application crypto to primitives
      
      * make primitives compile under no_std
      
      * add beefy pallet that maintains authority set
      
      * add beefy pallet to node example runtime
      
      * tabify node-example cargo.toml files
      
      * use double quotes in Cargo.toml files
      
      * add missing hex-literal dependency
      
      * add runtime api to fetch BEEFY authorities
      
      * fix clippy warnings
      
      * rename beefy-pallet to pallet-beefy
      
      * sort dependencies in node-example/runtime/Cargo.toml
      
      * Signed commitments rpc pubsub (#26)
      
      * move beefy application crypto to primitives
      
      * make primitives compile under no_std
      
      * add beefy pallet that maintains authority set
      
      * add beefy pallet to node example runtime
      
      * tabify node-example cargo.toml files
      
      * use double quotes in Cargo.toml files
      
      * add missing hex-literal dependency
      
      * add runtime api to fetch BEEFY authorities
      
      * fix clippy warnings
      
      * gadget: use commitment and signedcommitment
      
      * gadget: send notifications for signed commitments
      
      * gadget: add rpc pubsub for signed commitments
      
      * node-example: enable beefy rpc
      
      * gadget: fix clippy warnings
      
      * rename beefy-pallet to pallet-beefy
      
      * sort dependencies in node-example/runtime/Cargo.toml
      
      * gadget: add documentation on SignedCommitment rpc wrapper type
      
      * gadget: add todos about dummy beefy commitments
      
      * gadget: remove redundant closure
      
      Co-authored-by: default avatarTomasz Drwięga <tomusdrw@users.noreply.github.com>
      
      Co-authored-by: default avatarTomasz Drwięga <tomusdrw@users.noreply.github.com>
      
      * Integrate MMR and deposit root into the digest. (#24)
      
      * Add basic MMR.
      
      * Deposit digest item.
      
      * cargo fmt --all
      
      * Merge with primitives.
      
      * cargo fmt --all
      
      * Fix extra spaces.
      
      * cargo fmt --all
      
      * Switch branch.
      
      * remove stray whitespace
      
      * update to latest td-mmr commit
      
      * fix clippy error
      
      Co-authored-by: default avatarAndré Silva <andrerfosilva@gmail.com>
      
      * use new mmr root as commitment payload (#27)
      
      * use new mmr root as commitment payload
      
      * fix mmr root codec index
      
      * warn on MMR root digest not found
      
      Co-authored-by: default avatarTomasz Drwięga <tomusdrw@users.noreply.github.com>
      
      * add type alias for MMR root hash
      
      Co-authored-by: default avatarTomasz Drwięga <tomusdrw@users.noreply.github.com>
      
      * Bump serde_json from 1.0.59 to 1.0.60 (#28)
      
      * Update to latest substrate. (#32)
      
      * Update to latest substrate.
      
      * Fix tests.
      
      * cargo fmt --all
      
      * Switch to master.
      
      * Bump serde from 1.0.117 to 1.0.118 (#29)
      
      * Bump serde from 1.0.117 to 1.0.118
      
      Bumps [serde](https://github.com/serde-rs/serde) from 1.0.117 to 1.0.118.
      - [Release notes](https://github.com/serde-rs/serde/releases)
      - [Commits](https://github.com/serde-rs/serde/compare/v1.0.117...v1.0.118)
      
      Signed-off-by: default avatardependabot-preview[bot] <support@dependabot.com>
      
      * Bump arc-swap.
      
      Co-authored-by: default avatardependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
      Co-authored-by: default avatarTomasz Drwięga <tomusdrw@users.noreply.github.com>
      Co-authored-by: default avatarTomasz Drwięga <tomasz@parity.io>
      
      * Remove transition flag (#35)
      
      * Get rid of is_set_transition_flag
      
      * Fix tests.
      
      * cargo fmt --all
      
      * Bump futures from 0.3.9 to 0.3.12 (#50)
      
      * Bump log from 0.4.11 to 0.4.13 (#52)
      
      * Bump Substrate and Deps (#57)
      
      * Update README (#58)
      
      * Update README
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarTomasz Drwięga <tomusdrw@users.noreply.github.com>
      
      * address review comments
      
      * missed a typo
      
      Co-authored-by: default avatarTomasz Drwięga <tomusdrw@users.noreply.github.com>
      
      * Add validator set to the pallet. (#65)
      
      * Bump Substrate and Deps (#71)
      
      * Bump Substrate and Deps
      
      * pin serde and syn
      
      * bump Substrate again for '__Nonexhaustive' fix
      
      * add cargo deny ignore
      
      * Beefy pallet test (#74)
      
      * setup mock
      
      * test session change
      
      * silence beefy
      
      * clippy still
      
      * no change - no log
      
      * clippy again
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarTomasz Drwięga <tomusdrw@users.noreply.github.com>
      
      * code review changes, added additional test
      
      Co-authored-by: default avatarTomasz Drwięga <tomusdrw@users.noreply.github.com>
      
      * Beefy node cleanup (#75)
      
      * bump serde
      
      * bump substrate, scale-codec 2.0.0
      
      * we need a proper beefy node
      
      * rename primitives as well
      
      * Sort members.
      
      Co-authored-by: default avatarTomasz Drwięga <tomasz@parity.io>
      
      * Migrate beefy-pallet to FRAMEv2 (#76)
      
      * migrate beefy-pallet to FRAMEv2
      
      * Code review
      
      Co-authored-by: default avatarHernando Castano <HCastano@users.noreply.github.com>
      
      Co-authored-by: default avatarHernando Castano <HCastano@users.noreply.github.com>
      
      * Run BEEFY worker as non-validator (#77)
      
      * run BEEFY worker as non-validator
      
      * don't check for roloe.is_authority
      
      * change enum type name
      
      * Bump Substrate and Deps (#79)
      
      * Add BEEFY gadget as extra peer set (#80)
      
      * Add BEEFY gadget as extra peer set
      
      * use BEEFY protocol
      
      * Add ValidatorSetId to BEEFY digest (#85)
      
      * add ValidatorSetId to BEEFY digest
      
      * apply review changes
      
      * Bump Substrate and Deps (#91)
      
      * Bump Substrate and Deps
      
      * Bump Substrate again in order to include a hot-fix
      
      * redo again
      
      * use CryptoStore issue
      
      * cargo fmt
      
      * Bump serde_json from 1.0.63 to 1.0.64 (#93)
      
      * Track BEEFY validator set (#94)
      
      * Track BEEFY validator set
      
      * Add validator_set_id to BeefyWorker
      
      * Make validattor_set_id optional
      
      * Ad 92 (#97)
      
      * sign_commitment()
      
      * Error handling todo
      
      * Add error type (#99)
      
      * Add error type
      
      * Address review
      
      * Extract worker and round logic (#104)
      
      * Bump serde from 1.0.123 to 1.0.124 (#106)
      
      * Rework BeefyAPI (#110)
      
      * Initialize BeefyWorker with current validator set (#111)
      
      * Update toolchain (#115)
      
      * Use nightly toolchain
      
      * dongradde to latest clippy stable
      
      * GH workflow trail and error
      
      * next try
      
      * use stable for clippy
      
      * update wasm builder
      
      * yet another try
      
      * fun with CI
      
      * no env var
      
      * and one more
      
      * allow from_over_into bco contruct_runtime
      
      * back to start
      
      * well ...
      
      * full circle
      
      * old version was still used
      
      * Bump Substrate and Deps (#117)
      
      * Bump Substrate and Deps
      
      * cargo fmt should enforce uniform imports
      
      * merge some imports
      
      * Delayed BEEFY worker initialization (#121)
      
      * lifecycle state
      
      * add Client convenience trait
      
      * rework trait identifiers
      
      * WIP
      
      * rework BeefyWorker::new() signature
      
      * Delayed BEEFY gadget initialization
      
      * address review
      
      * Bump substrate. (#123)
      
      * Bump substrate.
      
      * Fix tests.
      
      * Lower log-level for a missing validator set (#124)
      
      * lower log-level for a missing validator set
      
      * move best_finalized_block initialization
      
      * Setup Prometheus metrics (#125)
      
      * setup Prometheus metrics
      
      * expose validator set id
      
      * cargo fmt
      
      * Update beefy-gadget/src/lib.rs
      
      Co-authored-by: default avatarTomasz Drwięga <tomusdrw@users.noreply.github.com>
      
      * add vote messages gossiped metric
      
      * track authorities change, before checking for MMR root digest
      
      Co-authored-by: default avatarTomasz Drwięga <tomusdrw@users.noreply.github.com>
      
      * Make Client convenience trait public (#126)
      
      * Bump serde from 1.0.124 to 1.0.125 (#131)
      
      * Reset rounds on new validator set. (#133)
      
      * Re-set rounds on new validator set.
      
      * Fix docs.
      
      * Bump Substrate and Deps (#134)
      
      * beefy: authority set changes fixes (#139)
      
      * node: fix grandpa peers set config
      
      * gadget: update best finalized number only when finalized with beefy
      
      * gadget: process authorities changes regardless of vote status
      
      * gadget: remove superfluous signature type (#140)
      
      * node: fix grandpa peers set config
      
      * gadget: update best finalized number only when finalized with beefy
      
      * gadget: process authorities changes regardless of vote status
      
      * gadget: remove superfluous signature type
      
      Co-authored-by: default avatarTomasz Drwięga <tomasz@parity.io>
      
      * gadget: reduce gossip spam (#141)
      
      * node: fix grandpa peers set config
      
      * gadget: update best finalized number only when finalized with beefy
      
      * gadget: process authorities changes regardless of vote status
      
      * gadget: remove superfluous signature type
      
      * gadget: only gossip last 5 rounds
      
      * gadget: note round to gossip validator before gossiping message
      
      * gadget: fix clippy warnings
      
      * gadget: update docs
      
      Co-authored-by: default avatarTomasz Drwięga <tomusdrw@users.noreply.github.com>
      
      Co-authored-by: default avatarTomasz Drwięga <tomusdrw@users.noreply.github.com>
      Co-authored-by: default avataradoerr <0xad@gmx.net>
      
      * gadget: verify SignedCommitment message signature (#142)
      
      * gadget: verify SignedCommitment message signature
      
      * gadget: log messages with bad sigs
      
      * gadget: move todo comment
      
      * Bump futures from 0.3.13 to 0.3.14 (#145)
      
      * Milestone 1 (#144)
      
      * use best_finalized, prevent race
      
      * make best_finalized_block an Option, should_vote_on bails on None
      
      * Bump futures from 0.3.13 to 0.3.14
      
      * Revert futures bump
      
      * Revert "Revert futures bump"
      
      This reverts commit a1b5e7e9bac526f2897ebfdfee7f02dd29a13ac5.
      
      * Revert "Bump futures from 0.3.13 to 0.3.14"
      
      This reverts commit a4e508b118ad2c4b52909d24143c284073961458.
      
      * debug msg if the bail voting
      
      * validator_set()
      
      * local_id()
      
      * get rid of worker state
      
      * Apply review suggestions
      
      * fix should_vote_on()
      
      * Extract BeefyGossipValidator (#147)
      
      * Extract BeefyGossipValidator
      
      * Apply review suggestions
      
      * Add block_delta parameter to start_beefy_gadget (#151)
      
      * Add block_delta parameter
      
      * rename to min_block_delta
      
      * Add additional metrics (#152)
      
      * Add additional metrics
      
      * add skipped session metric
      
      * add some comment for temp metric
      
      * don't log under info for every concluded round (#156)
      
      * don't log error on missing validator keys (#157)
      
      * don't log error on missing validator keys
      
      * remove unused import
      
      * Fix validator set change handling (#158)
      
      * reduce some logs from debug to trace
      
      * fix validator set changes handling
      
      * rename validator module to gossip
      
      * run rustfmt
      
      * Fix should_vote_on() (#160)
      
      * Fix should_vote_on()
      
      * by the textbook
      
      * fix the algorithm
      
      * Apply review suggestions
      
      * don't use NumberFor in vote_target
      
      Co-authored-by: default avatarAndré Silva <andrerfosilva@gmail.com>
      
      * Make KeyStore optional (#173)
      
      * Use builder pattern for NonDefaultSetConfig (#178)
      
      Co-authored-by: default avataradoerr <0xad@gmx.net>
      
      * Append SignedCommitment to block justifications (#177)
      
      * Append SignedCommitment
      
      * add BeefyParams
      
      * add WorkerParams
      
      * use warn
      
      * versioned variant for SignedCommitment
      
      * Bump serde from 1.0.125 to 1.0.126 (#184)
      
      Bumps [serde](https://github.com/serde-rs/serde) from 1.0.125 to 1.0.126.
      - [Release notes](https://github.com/serde-rs/serde/releases)
      - [Commits](https://github.com/serde-rs/serde/compare/v1.0.125...v1.0.126)
      
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      
      * Bump strum from 0.20.0 to 0.21.0 (#195)
      
      * Bump strum from 0.20.0 to 0.21.0
      
      Bumps [strum](https://github.com/Peternator7/strum) from 0.20.0 to 0.21.0.
      - [Release notes](https://github.com/Peternator7/strum/releases)
      - [Changelog](https://github.com/Peternator7/strum/blob/master/CHANGELOG.md)
      - [Commits](https://github.com/Peternator7/strum/commits)
      
      ---
      updated-dependencies:
      - dependency-name: strum
        dependency-type: direct:production
        update-type: version-update:semver-minor
      ...
      
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      
      * use dervie feature for strum; clippy and deny housekeeping
      
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      Co-authored-by: default avataradoerr <0xad@gmx.net>
      
      * Make concluded round an info log (#200)
      
      * Remove external crypto trait bounds (#207)
      
      * BeefyKeystore newtype
      
      * WIP
      
      * remove mod ecdsa
      
      * WIP
      
      * fix tests
      
      * some polishing
      
      * Rename AuthorityId to BeefyId to avoid type conflict in UI (#211)
      
      * Add trace points; Reduce MAX_LIVE_GOSSIP_ROUNDS (#210)
      
      * Add trace points; Reduce MAX_LIVE_GOSSIP_ROUNDS
      
      * log local authority id
      
      * Additional initial authority id's (#217)
      
      * Scratch concluded rounds
      
      * adjust testnet doc
      
      * fix authority key typo
      
      * We don't want no scratches
      
      * address review comments
      
      * Fix note_round() (#219)
      
      * rename BeefyGossipValidator
      
      * Fix note_round()
      
      * use const for assert
      
      * put message trace points back in
      
      * test case note_same_round_twice()
      
      * address review comments
      
      * remove redundant check
      
      * Use LocalKeystore for tests (#224)
      
      * private_keys()
      
      * Use LocalKeystore for tests
      
      * Use keystore helper
      
      * Address review
      
      * some reformatting
      
      * Cache known votes in gossip (#227)
      
      * Implement known messages cache.
      
      * Add tests.
      
      * Appease clippy.
      
      * More clippy
      
      Co-authored-by: default avataradoerr <0xad@gmx.net>
      
      * Some key store sanity checks (#232)
      
      * verify vote message
      
      * verify_validator_set()
      
      * rework logging
      
      * some rework
      
      * Tone down warnings.
      
      * Add signature verification.
      
      * Tone down more.
      
      * Fix clippy
      
      Co-authored-by: default avatarTomasz Drwięga <tomasz@parity.io>
      
      * Use Binary Merkle Tree instead of a trie (#225)
      
      * Binary tree merkle root.
      
      * Add proofs and verification.
      
      * Clean up debug.
      
      * Use BEEFY addresses instead of pubkeys.
      
      * Use new merkle tree.
      
      * Optimize allocations.
      
      * Add test for larger trees.
      
      * Add tests for larger cases.
      
      * Appease clippy
      
      * Appease clippy2.
      
      * Fix proof generation & verification.
      
      * Add more test data.
      
      * Fix CLI.
      
      * Update README
      
      * Bump version.
      
      * Update docs.
      
      * Rename beefy-merkle-root to beefy-merkle-tree
      
      Co-authored-by: default avataradoerr <0xad@gmx.net>
      
      * Bump Substrate and Deps (#235)
      
      * BEEFY+MMR pallet (#236)
      
      * Add MMR leaf format to primitives.
      
      * Fix tests
      
      * Initial work on the BEEFY-MMR pallet.
      
      * Add tests to MMR pallet.
      
      * Use eth addresses.
      
      * Use binary merkle tree.
      
      * Bump libsecp256k1
      
      * Fix compilation.
      
      * Bump deps.
      
      * Appease cargo deny.
      
      * Re-format.
      
      * Module-level docs.
      
      * no-std fix.
      
      * update README
      
      Co-authored-by: default avataradoerr <0xad@gmx.net>
      
      * Fix noting rounds for non-authorities (#238)
      
      * Bump env_logger from 0.8.4 to 0.9.0 (#242)
      
      Bumps [env_logger](https://github.com/env-logger-rs/env_logger) from 0.8.4 to 0.9.0.
      - [Release notes](https://github.com/env-logger-rs/env_logger/releases)
      - [Changelog](https://github.com/env-logger-rs/env_logger/blob/main/CHANGELOG.md)
      - [Commits](https://github.com/env-logger-rs/env_logger/compare/v0.8.4...v0.9.0)
      
      ---
      updated-dependencies:
      - dependency-name: env_logger
        dependency-type: direct:production
        update-type: version-update:semver-minor
      ...
      
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      
      * gadget: add global timeout for rebroadcasting messages (#243)
      
      * gadget: add global timeout for rebroadcasting messages
      
      * update rustfmt.toml
      
      * make message_allowed() a debug trace
      
      Co-authored-by: default avataradoerr <0xad@gmx.net>
      
      * Bump Substrate and Deps (#245)
      
      * Bump Substrate and Deps
      
      * Bump Substrate again
      
      * Bump futures from 0.3.15 to 0.3.16 (#247)
      
      Bumps [futures](https://github.com/rust-lang/futures-rs) from 0.3.15 to 0.3.16.
      - [Release notes](https://github.com/rust-lang/futures-rs/releases)
      - [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md)
      - [Commits](https://github.com/rust-lang/futures-rs/compare/0.3.15...0.3.16)
      
      ---
      updated-dependencies:
      - dependency-name: futures
        dependency-type: direct:production
        update-type: version-update:semver-patch
      ...
      
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      
      * Bump libsecp256k1 from 0.5.0 to 0.6.0 (#249)
      
      * Bump libsecp256k1 from 0.5.0 to 0.6.0
      
      Bumps [libsecp256k1](https://github.com/paritytech/libsecp256k1) from 0.5.0 to 0.6.0.
      - [Release notes](https://github.com/paritytech/libsecp256k1/releases)
      - [Changelog](https://github.com/paritytech/libsecp256k1/blob/master/CHANGELOG.md)
      - [Commits](https://github.com/paritytech/libsecp256k1/commits)
      
      ---
      updated-dependencies:
      - dependency-name: libsecp256k1
        dependency-type: direct:production
        update-type: version-update:semver-minor
      ...
      
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      
      * use correct crate name
      
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      Co-authored-by: default avataradoerr <0xad@gmx.net>
      
      * Derive `scale_info::TypeInfo` for types used in polkadot (#218)
      
      * Add scale-info TypeInfo derives
      
      * Update scale-info
      
      * Add crates.io patches
      
      * Use substrate aj-metadata-vnext branch
      
      * Revert master branch substrate deps
      
      * Add scale-info to beefy-pallet
      
      * scale-info v0.9.0
      
      * Remove github dependencies and patches
      
      * More TypeInfo derives
      
      * Update scale-info to 0.10.0
      
      * Add missing scale-info dependency
      
      * Add missing TypeInfo derive
      
      * Hide TypeInfo under a feature.
      
      Co-authored-by: default avatarTomasz Drwięga <tomasz@parity.io>
      
      * Bump serde from 1.0.126 to 1.0.127 (#260)
      
      Bumps [serde](https://github.com/serde-rs/serde) from 1.0.126 to 1.0.127.
      - [Release notes](https://github.com/serde-rs/serde/releases)
      - [Commits](https://github.com/serde-rs/serde/compare/v1.0.126...v1.0.127)
      
      ---
      updated-dependencies:
      - dependency-name: serde
        dependency-type: direct:production
        update-type: version-update:semver-patch
      ...
      
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      
      * Bump Substrate and Deps (#262)
      
      * Update jsonrpc (#265)
      
      * Update jsonrpc
      
      * Update Substrate
      
      * bump Substrate and Deps (#268)
      
      * Bump serde from 1.0.127 to 1.0.128 (#272)
      
      Bumps [serde](https://github.com/serde-rs/serde) from 1.0.127 to 1.0.128.
      - [Release notes](https://github.com/serde-rs/serde/releases)
      - [Commits](https://github.com/serde-rs/serde/compare/v1.0.127...v1.0.128)
      
      ---
      updated-dependencies:
      - dependency-name: serde
        dependency-type: direct:production
        update-type: version-update:semver-patch
      ...
      
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      
      * Fix spelling (#271)
      
      * Bump serde from 1.0.128 to 1.0.130 (#276)
      
      Bumps [serde](https://github.com/serde-rs/serde) from 1.0.128 to 1.0.130.
      - [Release notes](https://github.com/serde-rs/serde/releases)
      - [Commits](https://github.com/serde-rs/serde/compare/v1.0.128...v1.0.130)
      
      ---
      updated-dependencies:
      - dependency-name: serde
        dependency-type: direct:production
        update-type: version-update:semver-patch
      ...
      
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      
      * Bump scale-info from 0.10.0 to 0.12.0 (#275)
      
      Bumps [scale-info](https://github.com/paritytech/scale-info) from 0.10.0 to 0.12.0.
      - [Release notes](https://github.com/paritytech/scale-info/releases)
      - [Changelog](https://github.com/paritytech/scale-info/blob/master/CHANGELOG.md)
      - [Commits](https://github.com/paritytech/scale-info/commits)
      
      ---
      updated-dependencies:
      - dependency-name: scale-info
        dependency-type: direct:production
        update-type: version-update:semver-minor
      ...
      
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      Co-authored-by: default avataradoerr <0xad@gmx.net>
      
      * Update to scale-info 1.0 (#278)
      
      * bump substrate (#282)
      
      * bump Substrate and Deps
      
      * cargo fmt
      
      Co-authored-by: default avatarWenfeng Wang <kalot.wang@gmail.com>
      
      * Update worker.rs (#287)
      
      * Bump anyhow from 1.0.43 to 1.0.44 (#290)
      
      * Bump anyhow from 1.0.43 to 1.0.44
      
      Bumps [anyhow](https://github.com/dtolnay/anyhow) from 1.0.43 to 1.0.44.
      - [Release notes](https://github.com/dtolnay/anyhow/releases)
      - [Commits](https://github.com/dtolnay/anyhow/compare/1.0.43...1.0.44)
      
      ---
      updated-dependencies:
      - dependency-name: anyhow
        dependency-type: direct:production
        update-type: version-update:semver-patch
      ...
      
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      
      * derive Default
      
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      Co-authored-by: default avataradoerr <0xad@gmx.net>
      
      * Remove optional `scale-info` feature (#292)
      
      * Make scale-info dependency non-optional
      
      * Remove feature gated TypeInfo derives
      
      * Import TypeInfo
      
      * Update substrate
      
      * Fix up runtime
      
      * prune .git suffix (#294)
      
      * remove unused deps (#295)
      
      * remove unused deps
      
      * update lock file
      
      * Bump libsecp256k1 from 0.6.0 to 0.7.0 (#296)
      
      * Bump libsecp256k1 from 0.6.0 to 0.7.0
      
      Bumps [libsecp256k1](https://github.com/paritytech/libsecp256k1) from 0.6.0 to 0.7.0.
      - [Release notes](https://github.com/paritytech/libsecp256k1/releases)
      - [Changelog](https://github.com/paritytech/libsecp256k1/blob/master/CHANGELOG.md)
      - [Commits](https://github.com/paritytech/libsecp256k1/commits)
      
      ---
      updated-dependencies:
      - dependency-name: libsecp256k1
        dependency-type: direct:production
        update-type: version-update:semver-minor
      ...
      
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      
      * update sec advisories
      
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      Co-authored-by: default avataradoerr <0xad@gmx.net>
      
      * clean compile
      
      * use path dependencies
      
      * beefy-gadget license header
      
      * pallet-beefy license header
      
      * pallet-beefy-mmr license header
      
      * beefy-primitves license header
      
      * carg fmt
      
      * more formatting
      
      * shorten line
      
      * downgrade parity-scale-codec to 2.2.0
      
      * use path dependency for Prometheus endpoint
      
      * remove clippy annotations
      
      Co-authored-by: default avatarAndré Silva <123550+andresilva@users.noreply.github.com>
      Co-authored-by: default avatarTomasz Drwięga <tomusdrw@users.noreply.github.com>
      Co-authored-by: default avatarTomasz Drwięga <tomasz@parity.io>
      Co-authored-by: default avatarAndré Silva <andrerfosilva@gmail.com>
      Co-authored-by: default avatardependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
      Co-authored-by: default avatarHernando Castano <HCastano@users.noreply.github.com>
      Co-authored-by: default avatarPierre Krieger <pierre.krieger1708@gmail.com>
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      Co-authored-by: default avatarAndrew Jones <ascjones@gmail.com>
      Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
      Co-authored-by: default avatardrewstone <drewstone329@gmail.com>
      Co-authored-by: default avatarAndronik Ordian <write@reusable.software>
      Co-authored-by: default avatarWenfeng Wang <kalot.wang@gmail.com>
      Co-authored-by: default avatarJoshy Orndorff <JoshOrndorff@users.noreply.github.com>
      Co-authored-by: default avatarSquirrel <gilescope@gmail.com>
      283c8daa
  23. Sep 17, 2021
    • Zeke Mostov's avatar
      Implement `pallet-bags-list` and its interfaces with `pallet-staking` (#9507) · 669972a1
      Zeke Mostov authored
      
      * remove extra whitespace
      
      Co-authored-by: default avatarKian Paimani <5588131+kianenigma@users.noreply.github.com>
      
      * only emit rebag event on success
      
      * add doc explaining the term voter
      
      * revamp/simplify rebag test
      
      * ensure genesis accounts are placed into the correct nodes/bags
      
      * bond_extra implicitly rebags
      
      * types at top; doc public type
      
      * start sketching out adjustable thresholds
      
      * add integrity test for voter bag threshold requirements
      
      * get rid of BagIdx
      
      This reorganizes bag storage such that bags are always referred to
      by their upper threshold. This in turn means that adding and removing
      bags is cheaper; you only need to migrate certain voters, not all of them.
      
      * implement migration logic for when the threshold list changes
      
      * start sketching out threshold proc macros
      
      * further refine macro signatures
      
      * WIP: implement make_ratio macro
      
      * start rethinking the process of producing threshold lists
      
      The macro approach seems to be a non-starter; that only really works
      if we're throwing around numeric literals everywhere, and that's just
      not nice in this case.
      
      Instead, let's write helper functions and make it really easy to
      generate the tables in separate, permanent files, which humans
      can then edit.
      
      * write helper functions to emit voter bags module
      
      * WIP: demo generating voter bags for a realistic runtime
      
      This isn't yet done, becuase it seems to take a Very Long Time to run,
      and it really shouldn't. Need to look into that.
      
      Still, it's a lot closer than it was this morning.
      
      * rm unnecessary arg_enum
      
      * fix voter bags math
      
      Turns out that when you're working in exponential space, you need
      to divide, not subtract, in order to keep the math working properly.
      
      Also neaten up the output a little bit to make it easier to read.
      
      * add computed voter bags thresholds to node
      
      * fixup some docs
      
      * iter from large bags to small, fulfuilling the contract
      
      * make tests compile
      
      * add VoterBagThresholds to some configs
      
      * ensure that iteration covers all voters even with implied final bag
      
      * use sp_std::boxed::Box;
      
      * fix unused import
      
      * add some more voter bags tests
      
      * file_header.txt
      
      * integrity test to ensure min bag exceeds existential weight
      
      * add more debug assertions about node list length
      
      * rm unused imports
      
      * Kian enters
      
      * Update frame/election-provider-support/src/onchain.rs
      
      Co-authored-by: default avatarZeke Mostov <32168567+emostov@users.noreply.github.com>
      
      * Suggestions for #9081 (Store voters in unsorted bags) (#9328)
      
      * Add some debug asserts to node::get and remove_node
      
      * Improve the debug asserts in remove_node
      
      * improve debug asserts
      
      * Space
      
      * Remove bad assertions
      
      * Tests: WIP take_works
      
      * Take test
      
      * Doc comment
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarKian Paimani <5588131+kianenigma@users.noreply.github.com>
      
      * Test storage is cleaned up;
      
      * formatting
      
      * Switch to simpler thresholds
      
      * Update the storage cleanup test
      
      * Remove hardcoded values from benchmark to make it more robust
      
      * Fix tests to acces bags properly
      
      * Sanity check WIP; tests failing
      
      * Update sanity checks to be more correct
      
      * Improve storage cleanup tests
      
      * WIP remote_ext_tests
      
      * Some notes on next steps
      
      * Remove some stuff that was for remote-ext tests
      
      * Some more cleanup to reduce diff
      
      * More :clean:
      
      * Mo cleanin
      
      * small fix
      
      * A lot of changes from kian
      
      Co-authored-by: default avatarKian Paimani <5588131+kianenigma@users.noreply.github.com>
      Co-authored-by: default avatarkianenigma <kian@parity.io>
      
      * merge fallout
      
      * Run cargo +nightly fmt
      
      * Fix a bunch of stuff, remove not needed runtime arg of make-bags
      
      * add logs
      
      * Glue the new staking bags to the election snapshot (#9415)
      
      * Glue the new staking bags to the election snapshot
      
      * add CheckedRem (#9412)
      
      * add CheckedRem
      
      * fix
      
      * Run fmt
      
      * Test comment
      
      Co-authored-by: default avatarXiliang Chen <xlchen1291@gmail.com>
      Co-authored-by: default avataremostov <32168567+emostov@users.noreply.github.com>
      
      * Update node runtime with VoterSnapshotPerBlock
      
      * Unit test for pallet-staking unsorted bags feature (targets #9081) (#9422)
      
      * impl notional_bag_for_works
      
      * Add tests: insert_as_works & insert_works
      
      * Impl test: remove_works
      
      * Trivial cleaning
      
      * Add test: update_position_for_works
      
      * Write out edge case; probably can delete later
      
      * Add test: bags::get_works
      
      * Add test: remove_node_happy_path_works
      
      * Add test: remove_node_bad_paths_documented
      
      * WIP: voting_data_works
      
      * done
      
      * Improve test voting_data_works
      
      * Add comment
      
      * Fill out test basic_setup_works
      
      * Update: iteration_is_semi_sorted
      
      * Improve remove_works
      
      * Update update_position_for_works; create set_ledger_and_free_balance
      
      * Improve get_works
      
      * Improve storage clean up checks in remove test
      
      * Test: impl rebag_works + insert_and_remove_works
      
      * forgot file -  Test: impl rebag_works + insert_and_remove_works
      
      * Small tweak
      
      * Update voter_bags test to reflect unused bags are removed
      
      * Unbond & Rebond: do_rebag
      
      * Prevent infinite loops with duplicate tail insert
      
      * Check iter.count on voter list in pre-migrate
      
      * undo strang fmt comment stuff
      
      * Add in todo
      
      Co-authored-by: default avatarkianenigma <kian@parity.io>
      
      * Try prepare for master merge
      
      * Reduce diff
      
      * Add comment for test to add
      
      * Add in code TODO for update_position efficiency updates
      
      * Initial impl compiles
      
      * impl StakingVoterListStub
      
      * Sample impl<T: Config> VoterListProvider<T> for VoterList<T>
      
      * impl VoterListProvider for voter-bags
      
      * WIP integrate pallet-voter-bags to staking mock
      
      * the trait `pallet_staking::pallet::pallet::Config` is not implemented for `mock::Test`
      
      * random
      
      * pushing my stuff
      
      * Mock working
      
      * WIP voter list tests
      
      * Add bag insert, remove tests
      
      * Add test for bag insert and remove
      
      * Add remaining tests for VoterList
      
      * Add tests for node
      
      * Add rebag works
      
      * Add rebag extrinsic tests
      
      * Rename to bags-list and name the list .. list!
      
      * Rename VoterBagThresholds => BagThresholds
      
      * Add test count_works
      
      * Test on_update_works
      
      * test sanity check
      
      * a round of test fixes
      
      * push a lot of changes
      
      * my last changes
      
      * all bags-list test work; fmt
      
      * Beautify some tests
      
      * Doc comment for bags-list
      
      * Add insert warnings
      
      * Setup initial benchmark
      
      * Wire up WeightInfo
      
      * is_terminal wip; everything broken!
      
      * Is terminal working
      
      * add TODOs for remove_node
      
      * clean up remoe_node
      
      * Fix all staking tests
      
      * retire VoterBagFor
      
      * commit
      
      * bring in stashed changes
      
      * save
      
      * bench pipeline works now, but I can't run stuff
      
      * sabe
      
      * benchmarks now run, but we have a failure
      
      * WIP: Wire up make_bags
      
      * bags-thresholds compiles
      
      * Fix most build issues
      
      * This will fix all the tests
      
      * move bag thresholds to bags-list
      
      * Move bag-thresholds bin to within pallet-bags
      
      * Remove some unnescary TODOs
      
      * Impl tets wrong_rebag_is_noop
      
      * assert remove is a noop with bad data
      
      * Assert integrity test panics
      
      * Return an error when inserting duplicates
      
      * Update to handle error in staking pallet when inserting to list
      
      * Test contains and on_insert error
      
      * Test re-nominate does not mess up list or count
      
      * Everything builds and works, only the benchmark...
      
      * fuck yeah benchmarks
      
      * more cleanup, more hardening.
      
      * use the bags list again
      
      * fix benhc
      
      * Some questions and changs for List::migration
      
      * Fix migration removed_bags and new_bags usage
      
      * Some trivial aesthetic changes
      
      * Some more trivial changes
      
      * tiny changes/
      
      * mega rename
      
      * fix all tests and ci build
      
      * nit
      
      * Test and fix migration
      
      * nit
      
      * fmt
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * fmt
      
      * remove unused
      
      * make a few things pub
      
      * make node also pub.. for remote-ext test
      
      * Fix all tests again
      
      * Force bag changes in relevant benchmarks (targets #9507) (#9529)
      
      * force rebag for unbond, rebond, and bond_extra
      
      * nit
      
      * Improve utils
      
      * fmt
      
      * nits
      
      * Move generate_bags to its own pallet
      
      * Get runtime-benchmarks feature setup with prepare_on_update_benchmark
      
      * Withdraw unbonded kill working
      
      * Nominate bench working
      
      * some cleanup
      
      * WIP
      
      * update to check head pre & post conditions
      
      * Add some post condition verification stuff for on_remove
      
      * Update nominate
      
      * fmt
      
      * Improvements
      
      * Fix build
      
      * fix build with polkadot companion
      
      * Update frame/bags-list/src/list/tests.rs
      
      Co-authored-by: default avatarKian Paimani <5588131+kianenigma@users.noreply.github.com>
      
      * move generate-bag from frame to utils
      
      * wip
      
      * refactor WIP
      
      * WIP save
      
      * Refactor working
      
      * some variable renaming
      
      * WIP: prepare to remove head checks
      
      * Finish MvP refactor
      
      * Some cleanup
      
      * Soem more cleanup
      
      * save
      
      * fix a lot of stuff
      
      * Update client/db/src/bench.rs
      
      Co-authored-by: default avatarShawn Tabrizi <shawntabrizi@gmail.com>
      
      * Apply suggestions from code review
      
      * Apply suggestions from code review
      
      * Fix some issues that came from trying to merge comments on github
      
      * some small changes
      
      * simplify it
      
      Co-authored-by: default avatarKian Paimani <5588131+kianenigma@users.noreply.github.com>
      Co-authored-by: default avatarkianenigma <kian@parity.io>
      Co-authored-by: default avatarShawn Tabrizi <shawntabrizi@gmail.com>
      
      * Build works
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarGuillaume Thiolliere <gui.thiolliere@gmail.com>
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarGuillaume Thiolliere <gui.thiolliere@gmail.com>
      
      * Remove commented out debug assert
      
      * Remove some unused deps and some unused benchmarking stuff
      
      * Fix stakings ElectionDataProvider clear
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Improving staking pallet-bags-list migration
      
      * fix build and some comments;
      
      * comment
      
      * Reduce visibility in bags list components
      
      * make node.bag_upper only accesible to benchmarks
      
      * Address some feedback; comments updates
      
      * use nominator map comment
      
      * fix vec capacity debug assert
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarGuillaume Thiolliere <gui.thiolliere@gmail.com>
      
      * clarify VoterSnapshotPerBlock
      
      * Reduce diff on create_validators by wrapping with_seed
      
      * Some small improvements to staking benches
      
      * Soem comment updates
      
      * fix vec capacity debug assert ... for real this time
      
      * Reduce ListBags viz
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Remove supports_eq_unordered & Support eq_unordered
      
      * Update utils/frame/generate-bags/src/lib.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <gui.thiolliere@gmail.com>
      
      * Make total-issuance & minimium-balance CLI args; Dont use emptry ext
      
      * Improve docs for generate bags CLI args
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarKian Paimani <5588131+kianenigma@users.noreply.github.com>
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarKian Paimani <5588131+kianenigma@users.noreply.github.com>
      
      * Don't use default bags weight in node runtime
      
      * Feature gating sanity_check not working
      
      * Feature gate sanity check by creating duplicate fns
      
      * Fix line wrapping
      
      * Document VoteWeightProvider
      
      * Make bags ext-builder not a module
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarKian Paimani <5588131+kianenigma@users.noreply.github.com>
      
      * use pallet_bags_list instead of crate in mock
      
      * Make get_bags test helper fn live in List
      
      * use remove_from_storage_unchecked for node removal
      
      * Remove count of ids removed in remove_many
      
      * Add node sanity check, improve list sanity check
      
      * Do a list sanity check after on_update
      
      * List::migrate: clean up debug assert, exit early when no change in thresholds
      
      * Improve public doc comments for pallet_bags_list::list::List
      
      * Improve public doc comments for pallet_bags_list::list::List
      
      * Update generate bags docs
      
      * Fix grammar in bags-list benchmark
      
      * Add benchmark case for `rebag` extrinsic
      
      * Add count parameter to List::clear; WIP adding MaxEncodedLen to list'
      
      * MaxEncodeLen + generate_storage_info not working for Bag or Node
      
      * Get MaxEncodeLen derive to work
      
      * Try to correctly feature gate SortedListProvider::clear
      
      * Use u32::MAX, not u32::max_value
      
      * Get up to nominators_quota noms
      
      * SortedListProvider::clear takes an Option
      
      * Eplicitly ignore SortedListProvider return value
      
      * Fix doc comment
      
      * Update node-runtime voter snapshot per block
      
      * Add test get_max_len_voters_even_if_some_nominators_are_slashed
      
      * Add test only_iterates_max_2_times_nominators_quota
      
      * Fix generate bags cargo.toml
      
      * use sp_std vec
      
      * Remove v8 migration hooks from pallet-staking
      
      * Update npos trait
      
      * Try respect line width
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Update frame/bags-list/src/benchmarks.rs
      
      * Unwrap try-runtime error; remove sortedlistprovider pre upgrade len  check
      
      * trigger ci
      
      * restore
      
      * trigger ci
      
      * restore
      
      * trigger ci
      
      * revert
      
      * trigger ci
      
      * revert
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>
      Co-authored-by: default avatarKian Paimani <5588131+kianenigma@users.noreply.github.com>
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <peter.r.goodspeedniklaus@gmail.com>
      Co-authored-by: default avatarkianenigma <kian@parity.io>
      Co-authored-by: default avatarXiliang Chen <xlchen1291@gmail.com>
      Co-authored-by: default avatarParity Benchmarking Bot <admin@parity.io>
      Co-authored-by: default avatarShawn Tabrizi <shawntabrizi@gmail.com>
      Co-authored-by: default avatarGuillaume Thiolliere <gui.thiolliere@gmail.com>
      669972a1
  24. Sep 15, 2021
    • Andrew Jones's avatar
      Enrich metadata with type information (#8615) · 49b6dfd2
      Andrew Jones authored
      
      * Cargo.lock after merge
      
      * Restore scale-info feature
      
      * Fully qualify TypeInfo derive
      
      * Skip PendingSwap T
      
      * Add missing skip_type_params attr
      
      * metadata docs features
      
      * Reduce pallet event attribute to struct
      
      * Cargo.lock
      
      * Update frame/balances/src/tests_composite.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <gui.thiolliere@gmail.com>
      
      * Line widths check
      
      * Cargo.lock
      
      * Add scale-info/std
      
      * Update frame/system/src/lib.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <gui.thiolliere@gmail.com>
      
      * Use `skip_type_params` to remove `TypeInfo` requirements on checks
      
      * Revert "Remove unused Call metadata stuff"
      
      This reverts commit 41311f85
      
      * Skip BalanceSwapAction type parameter
      
      * Remove unused event metadata macro
      
      * Update frame-metadata
      
      * Update primitives/npos-elections/compact/src/codec.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <gui.thiolliere@gmail.com>
      
      * Manual TypeInfo for Header
      
      * Remove TypeInfo requirement for consts in BoundedVec etc.
      
      * Another TypeInfo bound removed
      
      * review: fix indentation
      
      * TypeInfo impls for Identity types
      
      * Add some todos to add custom TypeInfo impls
      
      * Update frame/support/procedural/src/pallet/expand/pallet_struct.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <gui.thiolliere@gmail.com>
      
      * Add some todos to add custom TypeInfo impls
      
      * Add a test for manual Data TypeInfo impl
      
      * Add custom TypeInfo impl for Vote
      
      * Era custom TypeInfo crimes
      
      * Revert finality-grandpa version to 0.14.z
      
      * review: renamed module to pallet_constants_metadata
      
      * New line at end of file
      
      * Add missing scale-info/std
      
      * Update frame/support/src/storage/types/mod.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <gui.thiolliere@gmail.com>
      
      * Remove StorageEntryType::Map unused flag
      
      * Add missing scale-info dependency after merge
      
      * SignedExtension::AdditionalSigned metadata
      
      * Update frame-metadata, use abbreviated docs and args fields
      
      * Update frame/example/Cargo.toml
      
      Co-authored-by: default avatarKeith Yeung <kungfukeith11@gmail.com>
      
      * Add scale_info/std and remove unused scale-info dependency
      
      * Remove scale-info dependency
      
      * Remove treasury pallet::metadata
      
      * Remove redundant Event test
      
      * Add back scale-info as dev dependency
      
      * fix error metadata when no error defined in decl_module
      
      * Add Module3 to tests
      
      * Fix metadata test
      
      * Add docs feature to frame-support test
      
      * WIP fixing pallet metadata test
      
      * Remove redundant FunctionMetadata, FunctionArgumentMetadata as per https://github.com/paritytech/frame-metadata/pull/20
      
      * Use main branch of frame-metadata
      
      * Use patch of scale-info for latest changes
      
      * Use latest patched scale-info
      
      * Manual TypeInfo for DigestItem
      
      * Manual TypeInfo for DigestItem
      
      * Update scale-info
      
      * Skip __Ignore variants for Error, depends on https://github.com/paritytech/scale-info/pull/117
      
      * Named fields for FRAME v2 pallet Call variants
      
      * Named fields for FRAME v1 pallet Call variants
      
      * Add missing scale-info dependency
      
      * WIP expand benchmark call variant
      
      * fix benchmark with new function
      
      create a new function for each variant of a pallet call.
      This function is called by benchmarking macro in order not to break call
      creation with unnamed argument
      
      * fix tests
      
      * more fix
      
      * Fix staking tests
      
      * Fix offchain workers calls
      
      * Cherry pick rustfmt.toml from master
      
      * cargo +nightly-2021-06-22 fmt --all
      
      * Update to new call variant structs
      
      * More call variant struct updates
      
      * Remove unused import
      
      * More call variant structs
      
      * More call variant structs
      
      * Even more call variant structs
      
      * Mooar variant structs
      
      * Evermore variant structs
      
      * Call variant structs ad infinitum
      
      * Fmt
      
      * More call variants
      
      * Last call variant
      
      * Call variants all done?
      
      * Fix SS58Prefix type
      
      * Potential workaround for BitFlags<IdentityFields> TypeInfo
      
      * Enable docs capturing for Call, Event, and Error types
      
      * Fix IdentityFields TypeInfo
      
      * Remove metadata-docs feature
      
      * Add capture_docs = true for legacy Call, Event and Error types
      
      * Fmt
      
      * Fix metadata test type
      
      * Update benchmarks with call struct variants
      
      * Fmt
      
      * More test fixes
      
      * Fmt
      
      * Fix benches
      
      * Use latest capture_docs attr
      
      * Latest scale_info
      
      * Fmt
      
      * review: change &Vec to &[]
      
      * Remove pallet metadata attr
      
      * review: remove commented out test code
      
      * review: skip_type_params trailing comma suggestion
      
      * Update to scale-info 0.10.0
      
      * Update construct_runtime ui tests, different because of metadata TypeInfo impls
      
      * Add some TypeInfo derives for UI tests
      
      * Update storage ensure span ui stderrs
      
      * Update call argument bound ui tests
      
      Possibly changed because change from tuple to struct variants?
      
      * Add scale-info dev dependency
      
      * Update to latest finality-grandpa release
      
      * review: missing newline
      
      * review: missing scale-info/std
      
      * review: remove duplicate scale-info/std
      
      * review: remove fully qualified TypeInfo
      
      * review: add missing scale-info/std
      
      * review: remove unnecessary imports.
      
      * Fmt
      
      * Use crates.io RC version of frame-metadata
      
      * Remove scale-info/std because it is a dev dependency
      
      * Add missing scale_info dev-dependency for test
      
      * Delete empty metadata folder
      
      * Fix sp_std import
      
      * review: improve manual UncheckedExtrinsic TypeInfo impl
      
      * review: use full scale-info for dev-dependency
      
      * Remove DefaultByteGetter impl
      
      * review: derive TypeInfo for generic header
      
      * Fmt
      
      * Update primitives/runtime/src/generic/unchecked_extrinsic.rs
      
      Co-authored-by: default avatarKeith Yeung <kungfukeith11@gmail.com>
      
      * Update primitives/runtime/src/generic/unchecked_extrinsic.rs
      
      Co-authored-by: default avatarKeith Yeung <kungfukeith11@gmail.com>
      
      * Update bin/node/executor/Cargo.toml
      
      Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
      
      * Update frame/identity/src/types.rs
      
      Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
      
      * Update frame/support/src/dispatch.rs
      
      Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
      
      * Remove redundant derive
      
      * Simplify scale-info dependency
      
      * Strip underscore prefix from call variant struct names
      
      * Another underscore field
      
      * More underscore fields
      
      * Another underscore field
      
      * Update to frame-metadata 14.0.0-rc.2 with combined StorageEntryType::Map
      
      * Fmt
      
      * Revert weights formatting
      
      * Fix up some tests
      
      * Fix up some tests for StorageEntryTypeMetadata
      
      * scale-info dev dependency
      
      * Fix test error
      
      * Add missing TypeInfo derives
      
      * Add back missing scale-info dependency
      
      * Add back missing scale-info dependency
      
      * Fix npos compact impls
      
      * Cargo.lock
      
      * Fmt
      
      * Fix errors
      
      * Fmt
      
      * Fix renamed raw_solution field
      
      * Fix error
      
      * Fmt
      
      * Fix some benchmarks
      
      * Fmt
      
      * Stray R
      
      * Fix
      
      * Add missing TypeInfos
      
      * ui test fix
      
      * Fix line widths
      
      * Revert "ui test fix"
      
      This reverts commit 2d15ec058a216e3f92d713f1174603a2bb1eac65.
      
      * Upgrade to scale-info 0.11.0
      
      * Revert "Upgrade to scale-info 0.11.0"
      
      This reverts commit 047bb179085a0059c36cd20ab405f55cf0867e28.
      
      * Add Runtime type
      
      * Update to scale-info 0.12
      
      * Update to scale-info 1.0
      
      * Update frame-metadata to version 14.0.0
      
      * Patch finality-grandpa until release available
      
      * Fix metadata tests
      
      * Fix metadata tests
      
      * Fmt
      
      * Remove patched finality-grandpa
      
      * Fix tests, use scale_info imports
      
      * Fix pallet tests
      
      * Add BlockNumber TypeInfo bound
      
      * ui test fix
      
      * Cargo.lock
      
      * Remove pallet metadata
      
      * Cargo.lock
      
      * Add missing scale-info dependency
      
      * Remove pallet event metadata
      
      * Fix error
      
      * Fix collective errors
      
      * Semicolol
      
      * Fmt
      
      * Remove another metadata attribute
      
      * Add new variant to custom digest TypeInfo
      
      * Fmt
      
      * Cargo.lock from master
      
      * Remove comma lol
      
      * Fix example call error
      
      * Fix example call error properly
      
      Co-authored-by: default avatarGuillaume Thiolliere <gui.thiolliere@gmail.com>
      Co-authored-by: default avatarKeith Yeung <kungfukeith11@gmail.com>
      Co-authored-by: default avatarShawn Tabrizi <shawntabrizi@gmail.com>
      Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
      49b6dfd2
  25. Sep 04, 2021
  26. Aug 24, 2021
  27. Aug 17, 2021
    • David's avatar
      Remove substrate-in-the-browser (#9541) · 2de7e51c
      David authored
      * Comment out browser stuff
      
      * Remove browser stuff
      
      * Remove more wasm transport code
      
      * Remove ExtTransport and rework how telemetry initialises.
      
      * Change (most) wasm-timer using code to use std::time
      
      * Rename CI-job
      
      * Aura does not compile for wasm
      
      * Remove testing in the browser on CI
      
      * Update README
      
      * Leave `StreamSink` be
      
      * fmt
      2de7e51c
  28. Aug 16, 2021
    • Trevor Arjeski's avatar
      RUSTSEC-2021-0076 bump libsecp256k1 (#9391) · d9f02296
      Trevor Arjeski authored
      
      * RUSTSEC-2021-0076 bump libsecp256k1
      
      libsecp256k1 allows overflowing signatures
      https://rustsec.org/advisories/RUSTSEC-2021-0076
      
      Changes were made to conform to libsecp256k1 version differences.
      
      Closes #9356
      
      * parse_standard_slice() -> parse_overflowing_slice()
      
      * Added v2 host function for ecdsa_verify
      
      * Add feature tag over helpers
      
      * Added ecdsa_verify v2 to test runner
      
      * PR feedback
      
      - Spaces -> tabs
      - renamed two helper functions
      
      * Fixed imports after rebasing
      
      * Bump rest of libsecp256k1 (and libp2p)
      
      libp2p also uses libsecp256k1 so it is required to be bumped too, along
      with all the version difference changes.
      
      * Add version2 for ecdsa pubkey recovery
      
      * libp2p rebase master fixes
      
      * Fix test panic when non Behaviour event is returned
      
      * Update bin/node/browser-testing/Cargo.toml
      
      * Update primitives/core/src/ecdsa.rs
      
      * Update primitives/core/src/ecdsa.rs
      
      * Update Cargo.lock
      
      Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
      d9f02296
  29. Aug 13, 2021
  30. Aug 11, 2021
  31. Aug 02, 2021
  32. Jul 08, 2021
    • Seun Lanlege's avatar
      sc-transcation-pool refactor (#9228) · 2ae9d367
      Seun Lanlege authored
      * Use TransactionPool trait
      
      * sc-transaction-pool-primitives
      
      * sc-transaction-pool-api
      
      * TP
      
      * bye sc_transaction_graph
      
      * fix line widths
      
      * fix import errors
      
      * fix import errors
      
      * fix import errors :face_palm_tone4:‍♂️
      
      * fix import errors :face_palm_tone4:‍♂️:face_palm_tone4:‍♂️:face_palm_tone4:‍♂️
      
      * remove sp-keyring
      2ae9d367
  33. Jul 05, 2021
    • Igor Matuszewski's avatar
      Remove in-tree `max-encoded-len` and use the new SCALE codec crate instead (#9163) · eb6d651f
      Igor Matuszewski authored
      
      * Update impl-codec to use new upstream MaxEncodedLen trait
      
      * Adapt crates to use the updated codec crate for `MaxEncodedLen`
      
      * Remove max-encoded-len crate altogether
      
      * Fix test compilation in `pallet-proxy`
      
      * reorganize import (#9186)
      
      * Fix remaining `MaxEncodedLen` imports
      
      * Fix remaining old usages of max-encoded-len crate
      
      * Fix UI test
      
      * Manually depend on new impl-codec to fix Polkadot companion build
      
      * Use newly released primitive-types v0.9.1 that has new codec impls
      
      * Make sure codec deps are up-to-date in crates that use them
      
      Co-authored-by: default avatarGuillaume Thiolliere <gui.thiolliere@gmail.com>
      eb6d651f
  34. Jun 30, 2021
    • Squirrel's avatar
      Move client only primitives to another dir (#9220) · d7804c09
      Squirrel authored
      * Move alloc primitive (not used in /pallets)
      
      * Move to alternative location as not shared
      
      * moved crates to different dir
      
      * ren sp_chain_spec to sc_chain_spec_primatives
      
      * merged sc-chain-spec and moved allocation up one.
      
      * no no_std
      
      * nudge
      
      * Bump CI
      d7804c09
  35. Jun 04, 2021
  36. Jun 01, 2021
  37. May 28, 2021
    • Shawn Tabrizi's avatar
      Simple `MaxBoundedLen` Implementations (#8793) · 444d4e20
      Shawn Tabrizi authored
      
      * implement max_values + storages info
      
      * some formatting + doc
      
      * sudo sanity check
      
      * timestamp
      
      * assets (not working)
      
      * fix assets
      
      * impl for proxy
      
      * update balances
      
      * rename StoragesInfo -> PalletStorageInfo
      
      * merge both StorageInfoTrait and PalletStorageInfo
      
      I think it is more future proof. In the future some storage could make
      use of multiple prefix. Like one to store how much value has been
      inserted, etc...
      
      * Update frame/support/procedural/src/storage/parse.rs
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>
      
      * Update frame/support/procedural/src/storage/storage_struct.rs
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>
      
      * Fix max_size using hasher information
      
      hasher now expose `max_len` which allows to computes their maximum len.
      For hasher without concatenation, it is the size of the hash part,
      for hasher with concatenation, it is the size of the hash part + max
      encoded len of the key.
      
      * fix tests
      
      * fix ui tests
      
      * Move `MaxBoundedLen` into its own crate (#8814)
      
      * move MaxEncodedLen into its own crate
      
      * remove MaxEncodedLen impl from frame-support
      
      * add to assets and balances
      
      * try more fixes
      
      * fix compile
      
      Co-authored-by: default avatarShawn Tabrizi <shawntabrizi@gmail.com>
      
      * nits
      
      * fix compile
      
      * line width
      
      * fix max-values-macro merge
      
      * Add some derive, needed for test and other purpose
      
      * use weak bounded vec in some cases
      
      * Update lib.rs
      
      * move max-encoded-len crate
      
      * fix
      
      * remove app crypto for now
      
      * width
      
      * Revert "remove app crypto for now"
      
      This reverts commit 73623e9933d50648e0e7fe90b6171a8e45d7f5a2.
      
      * unused variable
      
      * more unused variables
      
      * more fixes
      
      * Add #[max_encoded_len_crate(...)] helper attribute
      
      The purpose of this attribute is to reduce the surface area of
      max_encoded_len changes. Crates deriving `MaxEncodedLen` do not
      need to add it to `Cargo.toml`; they can instead just do
      
      ```rust
      \#[derive(Encode, MaxEncodedLen)]
      \#[max_encoded_len_crate(frame_support::max_encoded_len)]
      struct Example;
      ```
      
      * fix a ui test
      
      * use #[max_encoded_len_crate(...)] helper in app_crypto
      
      * remove max_encoded_len import where not necessary
      
      * update lockfile
      
      * fix ui test
      
      * ui
      
      * newline
      
      * fix merge
      
      * try fix ui again
      
      * Update max-encoded-len/derive/src/lib.rs
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>
      
      * extract generate_crate_access_2018
      
      * Update lib.rs
      
      * compiler isnt smart enough
      
      Co-authored-by: default avatarthiolliere <gui.thiolliere@gmail.com>
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <peter.r.goodspeedniklaus@gmail.com>
      444d4e20
  38. May 12, 2021
    • Sergey Pepyakin's avatar
      Embed runtime version as a custom section (#8688) · 0849bcce
      Sergey Pepyakin authored
      
      * emit a custom section from impl_runtime_apis!
      
      This change emits a custom section from the impl_runtime_apis! proc macro.
      
      Each implemented API will result to emitting a link section `runtime_apis`.
      During linking all sections with this name will be concatenated and
      placed into the final wasm binary under the same name.
      
      * Introduce `runtime_version` proc macro
      
      This macro takes an existing `RuntimeVersion` const declaration, parses
      it and emits the version information in form of a linking section.
      Ultimately such a linking section will result into a custom wasm
      section.
      
      * Parse custom wasm section for runtime version
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarDavid <dvdplm@gmail.com>
      
      * Fix sc-executor integration tests
      
      * Nits
      
      Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
      
      * Refactor apis section deserialization
      
      * Fix version decoding
      
      * Reuse uncompressed value for CallInWasm
      
      * Log on decompression error
      
      * Simplify if
      
      * Reexport proc-macro from sp_version
      
      * Merge ReadRuntimeVersionExt
      
      * Export `read_embedded_version`
      
      * Fix test
      
      * Simplify searching for custom section
      
      Co-authored-by: default avatarDavid <dvdplm@gmail.com>
      Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
      0849bcce
  39. Apr 07, 2021