Skip to content
  1. Aug 18, 2023
    • Liam Aharon's avatar
      migration: unlock/unreserve Gov v1 balances and remove kvs (#7314) · bd8228e0
      Liam Aharon authored
      * restore old gov configs
      
      * migrate old gov v1 storage
      
      * exclude the Call enum for gov v1 pallets
      
      * update substrate
      
      * update tips pallet
      
      * update chain_spec
      
      * fix migrations tuple
      
      * oliver comments
      
      * format comment
      
      * ".git/.scripts/commands/fmt/fmt.sh"
      
      * comments
      
      * polkadot migrations
      
      * fix cargo.lock
      
      * fix compilation
      
      * use democracy standalone migration
      
      * re-remove gov v1 pallets from kusama
      
      * remove unnecessary feature
      
      * fix unlock configs
      
      * use substrate master
      
      * reset cargo.lock
      
      * cargo update -p sp-io
      
      * remove from chainspec
      
      * remove polkadot gov v1 pallets
      
      * clean up chain spec
      
      * cargo fmt
      
      * remove old gov import
      
      ---------
      
      Co-authored-by: command-bot <>
      bd8228e0
  2. Aug 17, 2023
    • eskimor's avatar
      Parathreads Feature Branch (#6969) · eaf057c5
      eskimor authored
      
      
      * First baby steps
      
      * Split scheduler into several modules
      
      * Towards a more modular approach for scheduling
      
      * move free_cores; IntoInterator -> BTreeMap
      
      * Move clear()
      
      * Move more functions out of scheduler
      
      * Change weight composition
      
      * More abstraction
      
      * Further refactor
      
      * clippy
      
      * fmt
      
      * fix test-runtime
      
      * Add parathreads pallet to construct_runtime!
      
      * Make all runtimes use (Parachains, Parathreads) scheduling
      
      * Delete commented out code
      
      * Remove parathreads scheduler from westend, rococo, and kusama
      
      * fix rococo, westend, and kusama config
      
      * Revert "fix rococo, westend, and kusama config"
      
      This reverts commit 59e4de380d5c7d17eaaba5e2c2b81405de3465e3.
      
      * Revert "Remove parathreads scheduler from westend, rococo, and kusama"
      
      This reverts commit 4c44255296083ac5670560790ed77104917890a4.
      
      * Remove CoreIndex from free_cores
      
      * Remove unnecessary struct for parathreads
      
      * parathreads provider take 1
      
      * Comment out parathread tests
      
      * Pop into lookahead
      
      * fmt
      
      * Fill lookahead with two entries for parachains
      
      * fmt
      
      * Current stage
      
      * Towards ab parathreads
      
      * no AB use
      
      * Make tests typecheck
      
      * quick hack to set scheduling lookahead to 1
      
      * Fix scheduler tests
      
      * fix paras_inherent tests
      
      * misc
      
      * Update more of a test
      
      * cfg(test)
      
      * some cleanup
      
      * Undo paras_inherent changes
      
      * Adjust paras inherent tests
      
      * Undo changes to v2 primitives
      
      * Undo v2 mod changes to tests
      
      * minor
      
      * Remove parathreads assigner and pallet
      
      * minor
      
      * minor
      
      * more cleanup
      
      * fmt
      
      * minor
      
      * minor
      
      * minor
      
      * Remove on_new_session from assignment provider
      
      * Make adder collator integration test pass
      
      * disable failing unit tests
      
      * minor
      
      * minor
      
      * re-enable one unit test
      
      * minor
      
      * handle retries, add concluded para to pop interface
      
      * comment out unused code
      
      * Remove core_para from interface
      
      * Remove first claimqueue element on clear if None instead removing all Nones
      
      * Move claimqueue get out of loop
      
      * Use VecDeque instead of Ved in ClaimQueue
      
      * Make occupied() AB ready(?)
      
      * handle freed disputed in clear_and_fill_claimqueue
      
      * clear_and_fill_claimqueue returns scheduled Vec
      
      * Rename and minor refactor
      
      * return position of assignment taken from claimqueue
      
      * minor
      
      * Fix session boundary parachains number change + extended test
      
      * Fix runtimes
      
      * Fix polkadot runtime
      
      * Remove polkadot pallet from benchmarks
      
      * fix test runtime
      
      * Add storage migration
      
      * Minor refactor
      
      * Minor
      
      * migratin typechecks
      
      * Add migration to runtimes
      
      * Towards modular scheduling II (#6568)
      
      * Add post migration check
      
      * pebkac
      
      * Disable migrations but mine
      
      * Revert "Disable migrations but mine"
      
      This reverts commit 4fa5c5a370c199944a7e0926f50b08626bfbad4c.
      
      * Move scheduler migration
      
      * Revert "Move scheduler migration"
      
      This reverts commit a16b1659a907950bae048a9f7010f2aa76e02b6d.
      
      * Fix migration
      
      * cleanup
      
      * Don't lose retries value anymore
      
      * comment out test function
      
      * Remove retries value from Assignment again
      
      * minor
      
      * Make collator for parathreads optional
      
      * data type refactor
      
      * update scheduler tests
      
      * Change test function cfg
      
      * comment out test function
      
      * Try cfg(test) only
      
      * fix cfg flags
      
      * Add get_max_retries function to provider interface (#7047)
      
      * Fix merge commit
      
      * pebkac
      
      * fix merge
      
      * update cargo.lock
      
      * fix merge
      
      * fix merge
      
      * Use btreemap instead of vec, fix scheduler calls.
      
      * Use imported `ScheduledCore`
      
      * Remove unused import in inclusion tests
      
      * Use keys() instead of mapping over a BTreeMap
      
      * Fix migrations for parachains scheduler
      
      * Use BlockNumberFor<T> everywhere in scheduler
      
      * Add on demand assignment provider pallet (#7110)
      
      * Address some PR comments
      
      * minor
      
      * more cleanup
      
      * find_map and timeout availability fixes
      
      * Change default scheduling_lookahead to 1
      
      * Add on demand assignment provider pallet
      
      * Move test-runtime to new assignment provider
      
      * Run cargo format on scheduler tests
      
      * minor
      
      * Mutate cores in single loop
      
      * timeout predicate simplification
      
      * claimqueue desired size fix
      
      * Replace expect by ok_or
      
      * More improvements
      
      * Fix push back order and next_up_on_timeout
      
      * minor
      
      * session change docs
      
      * Add pre_new_session call to hand pre session updates
      
      * Remove sc_network dependency and PeerId from unnecessary data structures
      
      * Remove unnecessary peer_ids
      
      * Add OnDemandOrdering proxy (#7156)
      
      * Add OnDemandBidding proxy
      
      * Fix names
      
      * OnDemandAssigner for rococo only
      
      * Check PeerId in collator protocol before fetching collation
      
      * On occupied, remove non occupied cores from the claimqueue front and refill
      
      * Add missing docs
      
      * Comment out unused field
      
      * fix ScheduledCore in tests
      
      * Fix the fix
      
      * pebkac
      
      * fmt
      
      * Fix occupied dropping
      
      * Remove double import
      
      * ScheduledCore fixes
      
      * Readd sc-network dep
      
      * pebkac
      
      * OpaquePeerId -> PeerId in can_collate interface
      
      * Cargo.lock update for interface change
      
      * Remove checks not needed anymore?
      
      * Drop occupied core on session change if it would time out after the new session
      
      * Add on demand assignment provider pallet
      
      * Move test-runtime to new assignment provider
      
      * Run cargo format on scheduler tests
      
      * Add OnDemandOrdering proxy (#7156)
      
      * Add OnDemandBidding proxy
      
      * Fix names
      
      * OnDemandAssigner for rococo only
      
      * Remove unneeded config values
      
      * Update comments
      
      * Use and_then for queue position
      
      * Return the max size of the spot queue on error
      
      * Add comments to add_parathread_entry
      
      * Add module comments
      
      * Add log for when can_collate fails
      
      * Change assigner queue type to `Assignment`
      
      * Update assignment provider tests
      
      * More logs
      
      * Remove unused keyring import
      
      * disable can_collate
      
      * comment out can_collate
      
      * Can collate first checks set if empty
      
      * Move can_collate call to collation advertisement
      
      * Fix backing test
      
      * map to loop
      
      * Remove obsolete check
      
      * Move invalid collation test from backing to collator-protocol
      
      * fix unused imports
      
      * fix test
      
      * fix Debug derivation
      
      * Increase time limit on zombienet predicates
      
      * Increase zombienet timeout
      
      * Minor
      
      * Address some PR comments
      
      * Address PR comments
      
      * Comment out failing assert due to on-demand assigner missing
      
      * remove collator_restrictions info from backing
      
      * Move can_collate to ActiveParas
      
      * minor
      
      * minor
      
      * Update weight information for on demand config
      
      * Add ttl to parasentry
      
      * Fix tests missing parasentry ttl
      
      * Adjust scheduler tests to use ttl default values
      
      * Use match instead of if let for ttl drop
      
      * Use RuntimeDebug trait for `ParasEntry` fields
      
      * Add comments to on demand assignment pallet
      
      * Fix spot traffic calculation
      
      * Revert runtimedebug changes to primitives
      
      * Remove runtimedebug derivation from `ParasEntry`
      
      * Mention affinity in pallet level docs
      
      * Use RuntimeDebug trait for ParasEntry child types
      
      * Remove collator restrictions
      
      * Fix primitive versioning and other merge issues
      
      * Fix tests post merge
      
      * Fix node side tests
      
      * Edit parascheduler migration for clarity
      
      * Move parascheduler migration up to next release
      
      * Remove vestiges from merge
      
      * Fix tests
      
      * Refactor ttl handling
      
      * Remove unused things from scheduler tests
      
      * Move on demand assigner to own directory
      
      * Update documentation
      
      * Remove unused sc-network dependency in primitives
      
      Was used for collator restrictions
      
      * Remove unused import
      
      * Reenable scheduler test
      
      * Remove unused storage value
      
      * Enable timeout predicate test and fix fn
      
      Turns out that the issue with the compiler is fixed and we can now
      use impl Trait in the manner used here.
      
      * Remove unused imports
      
      * Add benchmarking entry for perbill in config
      
      * Correct typo
      
      * Address review comments
      
      * Log out errors when calculating spot traffic.
      
      * Change parascheduler's log target name
      
      * Update scheduler_common documentation
      
      * Use mutate for affinity fns, add tests
      
      * Add another on demand affinity test
      
      * Unify parathreads and parachains in HostConfig (take 2) (#7452)
      
      * Unify parathreads and parachains in HostConfig
      
      * Fixed missed occurences
      
      * Remove commented out lines
      
      * `HostConfiguration v7`
      
      * Fix version check
      
      * Add `MigrateToV7` to `Unreleased`
      
      * fmt
      
      * fmt
      
      * Fix compilation errors after the rebase
      
      * Update runtime/parachains/src/scheduler/tests.rs
      
      Co-authored-by: default avatarAnton Vilhelm Ásgeirsson <[email protected]>
      
      * Update runtime/parachains/src/scheduler/tests.rs
      
      Co-authored-by: default avatarAnton Vilhelm Ásgeirsson <[email protected]>
      
      * fmt
      
      * Fix migration test
      
      * Fix tests
      
      * Remove unneeded assert from tests
      
      * parathread_cores -> on_demand_cores; parathread_retries -> on_demand_retries
      
      * Fix a compilation error in tests
      
      * Remove unused `use`
      
      * update colander image version
      
      ---------
      
      Co-authored-by: default avataralexgparity <[email protected]>
      Co-authored-by: default avatarAnton Vilhelm Ásgeirsson <[email protected]>
      Co-authored-by: default avatarJavier Viola <[email protected]>
      
      * Fix branch after merge with master
      
      * Refactor out duplicate checks into a helper fn
      
      * Fix tests post merge
      
      * Rename add_parathread_assignment, add test
      
      * Update docs
      
      * Remove unused on_finalize function
      
      * Add weight info to on demand pallet
      
      * Update runtime/parachains/src/configuration.rs
      
      Co-authored-by: default avatarTsvetomir Dimitrov <[email protected]>
      
      * Update runtime/parachains/src/scheduler_common/mod.rs
      
      Co-authored-by: default avatarTsvetomir Dimitrov <[email protected]>
      
      * Update runtime/parachains/src/assigner_on_demand/mod.rs
      
      Co-authored-by: default avatarTsvetomir Dimitrov <[email protected]>
      
      * Add benchmarking to on demand pallet
      
      * Make place_order test check for success
      
      * Add on demand benchmarks
      
      * Add local test weights to rococo runtime
      
      * Modify TTL drop behaviour to not skip claims
      
      Previous behaviour would jump a new claim from the assignment provider
      ahead in the claimqueue, assuming lookahead is larger than 1.
      
      * Refactor ttl test to test claimqueue order
      
      * Disable place_order ext. when no on_demand cores
      
      * Use default genesis config for benchmark tests
      
      * Refactor config builder param
      
      * Move lifecycle test from scheduler to on demand
      
      * Remove unneeded lifecycle test
      
      Paras module via the parachain assignment provider doesn't provide
      new assignments if a parachain loses it's lease. The on demand
      assignment provider doesn't provide an assignment that is not a
      parathread.
      
      * Re enable validator shuffle test
      
      * More realistic weights for place_order
      
      * Remove redundant import
      
      * Fix backwards compatibility (hopefully)
      
      * ".git/.scripts/commands/bench/bench.sh" --subcommand=runtime --runtime=rococo --target_dir=polkadot --pallet=runtime_parachains::assigner_on_demand
      
      * Fix tests.
      
      * Fix off-by-one.
      
      * Re enable claimqueue fills test
      
      * Re enable schedule_rotates_groups test
      
      * Fix fill_claimqueue_fills test
      
      * Re enable next_up_on_timeout test, move fn
      
      * Do not pop from assignment provider when retrying
      
      * Fix tests missing collator in scheduledcore
      
      * Add comment about timeout predicate.
      
      * Rename parasentry retries to availability timeouts
      
      * Re enable schedule_schedules... test
      
      * Refactor prune retried test to new scheduler
      
      * Have all scheduler tests use genesis_cfg fn
      
      * Update docs
      
      * Update copyright notices on new files
      
      * Rename is_parachain_core to is_bulk_core
      
      * Remove erroneous TODO
      
      * Simplify import
      
      * ".git/.scripts/commands/bench/bench.sh" --subcommand=runtime --runtime=rococo --target_dir=polkadot --pallet=runtime_parachains::configuration
      
      * Revert AdvertiseCollation order shuffle
      
      * Refactor place_order into keepalive and allowdeath
      
      * Revert rename of hrmp max inbound channels
      
      parachain encompasses both on demand and slot auction / bulk.
      
      * Restore availability_timeout_predicate function
      
      * Clean up leftover comments
      
      * Update runtime/parachains/src/scheduler/tests.rs
      
      Co-authored-by: default avatarTsvetomir Dimitrov <[email protected]>
      
      * ".git/.scripts/commands/bench/bench.sh" --subcommand=runtime --runtime=westend --target_dir=polkadot --pallet=runtime_parachains::configuration
      
      ---------
      
      Co-authored-by: default avataralexgparity <[email protected]>
      Co-authored-by: default avataralexgparity <[email protected]>
      Co-authored-by: default avatarTsvetomir Dimitrov <[email protected]>
      Co-authored-by: default avatarJavier Viola <[email protected]>
      Co-authored-by: default avatareskimor <[email protected]>
      Co-authored-by: command-bot <>
      
      * On Demand - update weights and small nits (#7605)
      
      * Remove collator restriction test in inclusion
      
      On demand parachains won't have collator restrictions implemented in
      this way but will instead use a preferred collator registered to a
      `ParaId` in `paras_registrar`.
      
      * Remove redundant config guard for test fns
      
      * Update weights
      
      * Update WeightInfo for on_demand assigner
      
      * Unify assignment provider parameters into one call (#7606)
      
      * Combine assignmentprovider params into one fn call
      
      * Move scheduler_common to a module under scheduler
      
      * Fix ttl handling in benchmark builder
      
      * Run cargo format
      
      * Remove obsolete test.
      
      * Small improvement.
      
      * Use same migration pattern as config module
      
      * Remove old TODO
      
      * Change log target name for assigner on demand
      
      * Fix migration
      
      * Fix clippy warnings
      
      * Add HostConfiguration storage migration to V8
      
      * Add `MigrateToV8` to unreleased migrations for all runtimes
      
      * Fix storage version check for config v8
      
      * Set `StorageVersion` to 8 in `MigrateToV8`
      
      * Remove dups.
      
      * Update primitives/src/v5/mod.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      ---------
      
      Co-authored-by: default avataralexgparity <[email protected]>
      Co-authored-by: default avataralexgparity <[email protected]>
      Co-authored-by: default avatarantonva <[email protected]>
      Co-authored-by: default avatarTsvetomir Dimitrov <[email protected]>
      Co-authored-by: default avatarAnton Vilhelm Ásgeirsson <[email protected]>
      Co-authored-by: default avatarJavier Viola <[email protected]>
      Co-authored-by: default avatareskimor <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      eaf057c5
    • Bastian Köcher's avatar
      Companion for Substrate#14612 (#7536) · 26b5f259
      Bastian Köcher authored
      * Companion for reworking the storage transaction cache
      
      * Cargo lock
      
      * Fixes
      
      * update lockfile for {"substrate"}
      
      ---------
      
      Co-authored-by: parity-processbot <>
      26b5f259
  3. Aug 16, 2023
  4. Aug 15, 2023
    • Adrian Catangiu's avatar
      Revert "companion for 14754: cli: move no-beefy flag to sc-cli (#7600)" (#7613) · 022a3b97
      Adrian Catangiu authored
      * Revert "companion for 14754: cli: move no-beefy flag to sc-cli (#7600)"
      
      This reverts commit 26adab4f.
      
      * update lockfile for {"substrate"}
      
      * fix merge damage
      
      ---------
      
      Co-authored-by: parity-processbot <>
      022a3b97
    • alexd10s's avatar
      Change the Config of the MaxRococoNum Slot from a Constant to a Storage function (#7217) · bf785881
      alexd10s authored
      
      
      * set MaxPermanentSlots and MaxTemporarySlots with a extrinsic instead of a constant
      
      * delete the  MaxPermanentSlots and MaxTemporarySlots constants from config on  Rococo and Westend
      
      * migration code for assigned slots
      
      * remove getters
      
      * little refactor
      
      * set values in the GenesisConfig
      
      * refactor in the migration, adding it in the rococo runtime
      
      * refactor: fmt
      
      * Minor fix
      
      * pre_upgrade check
      
      * add migration to mod v1
      
      * Logs following Substrate#12873
      
      * fix: current storage version set to 1
      
      * use enact when try-runtime
      
      * Vec seems to be missing
      
      * feature gate import
      
      * fix as per #13993
      
      * address comments
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * address  comments
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * benchmarking for assign_perm_parachain_slot extrinsic
      
      * benchmark all the extrinsics of the pallet
      
      * cargo fmt for assigned slots
      
      * migration added for westend
      
      * licence in benchmarking file
      
      * BuildGenesisConfig
      
      * assigned_slots default in genesis
      
      * cargo fmt
      
      * assigned_slots fix tests config
      
      * cargo fmt
      
      * fix benchmarking compile error
      
      * fix benchmarking imports
      
      * benchmark worst case scenario for validation code and head data
      
      * add assigned_slots in frame_benchmarking on Rococo and Westend
      
      * modify values for para_id in benchmarking
      
      * delete the assigned_slots in westend frame_benchmarking
      
      * fix benchmarkings and add it to westend
      
      * cargo fmt
      
      * ".git/.scripts/commands/bench/bench.sh" --subcommand=runtime --runtime=rococo --target_dir=polkadot --pallet=runtime_common::assigned_slots
      
      * ".git/.scripts/commands/bench/bench.sh" --subcommand=runtime --runtime=westend --target_dir=polkadot --pallet=runtime_common::assigned_slots
      
      * use generated weights in assigned_slots pallet
      
      * small changes in set_max_permanent_slots and set_max_temporary_slots
      
      * revert last commit
      
      * address some comments
      
      * wrap migration with VersionCheckedMigrateToV1
      
      * add experimental feature in pallet, and assers in post_upgrade migration
      
      * clean warnings
      
      * clean unnecesary experimental flag
      
      * small typo in comments
      
      * cargo fmt
      
      * small comments fixes
      
      ---------
      
      Co-authored-by: default avataral3mart <[email protected]>
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      Co-authored-by: command-bot <>
      bf785881
    • Bastian Köcher's avatar
      Remove superflous parameter `overseer_enable_anyways` and make parachain node... · cf3271fe
      Bastian Köcher authored
      Remove superflous parameter `overseer_enable_anyways` and make parachain node type more explicit (#7617)
      
      * Remove superflous parameter `overseer_enable_anyways`
      
      We don't need this flag, as we don't need the overseer enabled when the
      node isn't a collator or validator.
      
      * Rename `IsCollator` to `IsParachainNode`
      
      `IsParachainNode` is more expressive and also encapsulates the state of
      the parachain node being a full node. Some functionality like the
      overseer needs to run always when the node runs alongside a parachain
      node. The parachain node needs the overseer to e.g. recover PoVs. Other
      things like candidate validation or pvf checking are only required for
      when the node is running as validator.
      
      * FMT
      
      * Fix CI
      cf3271fe
  5. Aug 14, 2023
  6. Aug 11, 2023
  7. Aug 04, 2023
  8. Aug 02, 2023
    • drskalman's avatar
      Companion for Substrate#14373 (#7572) · 2bbc7a73
      drskalman authored
      
      
      * rename BEEFY `crypto` →`ecdsa_crypto`
      
      * - bump up `BeefyApi` to version 3
      - deal with `PeerId` error.
      
      * update BEEFY dependency names for `fake-runtime` and `chain_spec`
      revert Cargo.toml
      
      * cargo fmt
      
      * Use master Cargo.lock
      
      * update lockfile for {"substrate"}
      
      ---------
      
      Co-authored-by: default avatarDavide Galassi <[email protected]>
      Co-authored-by: parity-processbot <>
      2bbc7a73
  9. Aug 01, 2023
    • Marcin S.'s avatar
      PVF: Fix external workers being required for non-collator full nodes (#7566) · f226cd5a
      Marcin S. authored
      * PVF: Fix external workers being required for non-collator full nodes
      
      * Fix
      
      * Make check more precise
      
      > This might as well be if role.is_authority() as there aren't really any nodes
      > that are both authorities and collators. But if there were a node that is an
      > authority and a collator, it'd probably want to validate candidates (in its
      > role as an authority).
      
      * Just seeing if this fixes zombienet CI...
      f226cd5a
  10. Jul 31, 2023
    • Marcin S.'s avatar
      98.6% OF DEVELOPERS CANNOT REVIEW THIS PR! [read more...] (#7337) · 85b06f18
      Marcin S. authored
      
      
      * [WIP] PVF: Split out worker binaries
      
      * Address compilation problems and re-design a bit
      
      * Reorganize once more, fix tests
      
      * Reformat with new nightly to make `cargo fmt` test happy
      
      * Address `clippy` warnings
      
      * Add temporary trace to debug zombienet tests
      
      * Fix zombienet node upgrade test
      
      * Fix malus and its CI
      
      * Fix building worker binaries with malus
      
      * More fixes for malus
      
      * Remove unneeded cli subcommands
      
      * Support placing auxiliary binaries to `/usr/libexec`
      
      * Fix spelling
      
      * Spelling
      
      Co-authored-by: default avatarMarcin S. <[email protected]>
      
      * Implement review comments (mostly nits)
      
      * Fix worker node version flag
      
      * Rework getting the worker paths
      
      * Address a couple of review comments
      
      * Minor restructuring
      
      * Fix CI error
      
      * Add tests for worker binaries detection
      
      * Improve tests; try to fix CI
      
      * Move workers module into separate file
      
      * Try to fix failing test and workers not printing latest version
      
      - Tests were not finding the worker binaries
      - Workers were not being rebuilt when the version changed
      - Made some errors easier to read
      
      * Make a bunch of fixes
      
      * Rebuild nodes on version change
      
      * Fix more issues
      
      * Fix tests
      
      * Pass node version from node into dependencies to avoid recompiles
      
      - [X] get version in CLI
      - [X] pass it in to service
      - [X] pass version along to PVF
      - [X] remove rerun from service
      - [X] add rerun to CLI
      
      - [X] don’t rerun pvf/worker’s (these should be built by nodes which have rerun enabled)
      
      * Some more improvements for smoother tests
      
      - [X] Fix tests
      - [X] Make puppet workers pass None for version and remove rerun
      - [X] Make test collators self-contained
      
      * Add back rerun to PVF workers
      
      * Move worker binaries into files in cli crate
      
      As a final optimization I've separated out each worker binary from its own crate
      into the CLI crate. Before, the worker bin shared a crate with the worker lib,
      so when the binaries got recompiled so did the libs and everything transitively
      depending on the libs. This commit fixes this regression that was causing
      recompiles after every commit.
      
      * Fix bug (was passing worker version for node version)
      
      * Move workers out of cli into root src/bin/ dir
      
      - [X] Pass in node version from top-level (polkadot)
      - [X] Add build.rs with rerun-git-head to root dir
      
      * Add some sanity checks for workers to dockerfiles
      
      * Update malus
      
        + [X] Make it self-contained
        + [X] Undo multiple binary changes
      
      * Try to fix clippy errors
      
      * Address `cargo run` issue
      
      - [X] Add default-run for polkadot
      - [X] Add note about installation to error
      
      * Update readme (installation instructions)
      
      * Allow disabling external workers for local/testing setups
      
        + [X] cli flag to enable single-binary mode
        + [X] Add message to error
      
      * Revert unnecessary Cargo.lock changes
      
      * Remove unnecessary build scripts from collators
      
      * Add back missing malus commands (should fix failing ZN job)
      
      * Some minor fixes
      
      * Update Cargo.lock
      
      * Fix some build errors
      
      * Undo self-contained binaries; cli flag to disable version check
      
        + [X] Remove --dont-run-external-workers
        + [X] Add --disable-worker-version-check
        + [X] Remove PVF subcommands
        + [X] Redo malus changes
      
      * Try to fix failing job and add some docs for local tests
      
      ---------
      
      Co-authored-by: default avatarDmitry Sinyavin <[email protected]>
      Co-authored-by: default avatars0me0ne-unkn0wn <[email protected]>
      Co-authored-by: parity-processbot <>
      85b06f18
  11. Jul 25, 2023
  12. Jul 19, 2023
    • Francisco Aguirre's avatar
      Change Fixed to WeightInfoBounds for Polkadot (#7077) · cc9f8129
      Francisco Aguirre authored
      
      
      * Add polkadot XCM benchmarks
      
      * Add temp
      
      * ".git/.scripts/commands/bench/bench.sh" xcm polkadot pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench/bench.sh" xcm polkadot pallet_xcm_benchmarks::generic
      
      * Add weights to XCM on Polkadot
      
      * Make CI fail on old files
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Update template
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Add reserve_asset_deposited benchmark
      
      * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::generic
      
      * Update weights
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Change initiate_reserve_deposit in runtime weights
      
      * Update weights
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Remove trusted reserves from runtimes
      
      * Fix pallet-xcm-benchmarks mock
      
      * Fix test
      
      * Change pallet xcm weigher in kusama
      
      * Fix
      
      * Remove merge conflict artifact
      
      * Remove initiate_reserve_withdraw from generic benchmarks
      
      * Add missing implementation to XCM benchmark
      
      * Fix failing karura test
      
      * Remove dbg!
      
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      
      * Fix fmt
      
      * Revert "Fix fmt"
      
      This reverts commit 676f2d8db07d7427750c79f95494d4988d06fda5.
      
      * Fix fmt
      
      * Remove duplicated template code
      
      * Add back part of the template
      
      * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible
      
      * Don't skip reserve asset deposited benchmark
      
      * Remove call to non-generated benchmark yet
      
      * Underscore unused parameter
      
      * Skip not supported benchmarks and hardcode value
      
      * Remove ReserveAssetDeposited benchmark
      
      * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible
      
      * Add back ReserveAssetDeposited
      
      * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible
      
      * Use default benchmark for ReserveAssetDeposited
      
      * Add missing parameter
      
      * Revert reserve asset deposited benchmark
      
      * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm kusama pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm westend pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench/bench.sh" xcm rococo pallet_xcm_benchmarks::fungible
      
      * Add 'real' benchmarks
      
      * Add TrustedReserve to actual XcmConfig
      
      * Add TrustedReserve to actual XcmConfig (fix)
      
      * Whitelist from benchmarking XCM storage keys read each block (#6871)
      
      * Whitelist from benchmarking XCM storage keys read each block
      
      * ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm
      
      * ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm
      
      * ".git/.scripts/commands/bench/bench.sh" runtime westend pallet_xcm
      
      * ".git/.scripts/commands/bench/bench.sh" runtime rococo pallet_xcm
      
      * Remove XcmPallet SupportedVersion from the benchmark whitelist
      
      * ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm
      
      * ".git/.scripts/commands/bench/bench.sh" runtime kusama pallet_xcm
      
      * ".git/.scripts/commands/bench/bench.sh" runtime westend pallet_xcm
      
      * ".git/.scripts/commands/bench/bench.sh" runtime rococo pallet_xcm
      
      * WIP
      
      * Add necessary traits, remove unnecessary whitelisted keys
      
      * Fix tests
      
      * Remove unused file
      
      * Remove unused import
      
      ---------
      
      Co-authored-by: command-bot <>
      
      * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench/bench.sh" xcm rococo pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench/bench.sh" xcm westend pallet_xcm_benchmarks::fungible
      
      * Fix spellchecker issues
      
      * Remove unused migration code
      
      ---------
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      Co-authored-by: command-bot <>
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      cc9f8129
  13. Jul 18, 2023
    • Michal Kucharczyk's avatar
      `chain-spec`: `polkadot_staging_testnet` config removed (#7509) · b15a5697
      Michal Kucharczyk authored
      * chain-spec: polkadot_staging_testnet config removed
      
      The config has empty initial authority test. It is unusable.
      
      ```
      $ polkadot export-blocks --chain polkadot-staging --from=0 --to=0
      ...
      Thread 'main' panicked at 'Empty validator set for session 0 in genesis block!',
      /home/miszka/.cargo/git/checkouts/substrate-7e08433d4c370a21/c446786/frame/session/src/lib.rs:463
      ```
      
      * warning fix
      b15a5697
    • André Silva's avatar
      companion for substrate#14423 (#7484) · 9f760192
      André Silva authored
      * companion for substrate#14423
      
      * update lockfile for {"substrate"}
      
      * update lockfile for {"substrate"}
      
      ---------
      
      Co-authored-by: parity-processbot <>
      9f760192
  14. Jul 12, 2023
  15. Jul 11, 2023
  16. Jul 05, 2023
  17. Jul 04, 2023
    • Bastian Köcher's avatar
      Do not depend on native runtimes for `RuntimeApi` (#7451) · e53d15aa
      Bastian Köcher authored
      * Implement runtime apis for fake runtime
      
      These runtime api implementations are only used to make the compiler
      think that we have implemented all required runtime apis. They will not
      be called as we switch the executor to `WasmExecutor`. In the near
      future we will not require these fake implementations anymore after
      Substrate has shifted away from this compile time requirement.
      
      This brings us the advantage that the `polkadot-service` doesn't need to
      depend on the runtimes for getting the `RuntimeApi` type.
      
      It also removes around 1min of build time on my machine ;)
      
      * Fix warning
      
      * FMT
      
      * ".git/.scripts/commands/fmt/fmt.sh"
      
      * Use more descriptive id
      
      * Fix warnings
      
      * Adapt path
      
      * Fix 🙈
      
      ---------
      
      Co-authored-by: command-bot <>
      e53d15aa
  18. Jun 21, 2023
  19. Jun 16, 2023
  20. Jun 11, 2023
  21. May 31, 2023
  22. May 30, 2023
    • Tsvetomir Dimitrov's avatar
      `RollingSessionWindow` cleanup (#7204) · eb1ed63b
      Tsvetomir Dimitrov authored
      
      
      * Replace `RollingSessionWindow` with `RuntimeInfo` - initial commit
      
      * Fix tests in import
      
      * Fix the rest of the tests
      
      * Remove dead code
      
      * Fix todos
      
      * Simplify session caching
      
      * Comments for `SessionInfoProvider`
      
      * Separate `SessionInfoProvider` from `State`
      
      * `cache_session_info_for_head` becomes freestanding function
      
      * Remove unneeded `mut` usage
      
      * fn session_info -> fn get_session_info() to avoid name clashes. The function also tries to initialize `SessionInfoProvider`
      
      * Fix SessionInfo retrieval
      
      * Code cleanup
      
      * Don't wrap `SessionInfoProvider` in an `Option`
      
      * Remove `earliest_session()`
      
      * Remove pre-caching -> wip
      
      * Fix some tests and code cleanup
      
      * Fix all tests
      
      * Fixes in tests
      
      * Fix comments, variable names and small style changes
      
      * Fix a warning
      
      * impl From<SessionWindowSize> for NonZeroUsize
      
      * Fix logging for `get_session_info` - remove redundant logs and decrease log level to DEBUG
      
      * Code review feedback
      
      * Storage migration removing `COL_SESSION_WINDOW_DATA` from parachains db
      
      * Remove `col_session_data` usages
      
      * Storage migration clearing columns w/o removing them
      
      * Remove session data column usages from `approval-voting` and `dispute-coordinator` tests
      
      * Add some test cases from `RollingSessionWindow` to `dispute-coordinator` tests
      
      * Fix formatting in initialized.rs
      
      * Fix a corner case in `SessionInfo` caching for `dispute-coordinator`
      
      * Remove `RollingSessionWindow` ;(
      
      * Revert "Fix formatting in initialized.rs"
      
      This reverts commit 0f94664ec9f3a7e3737a30291195990e1e7065fc.
      
      * v2 to v3 migration drops `COL_DISPUTE_COORDINATOR_DATA` instead of clearing it
      
      * Fix `NUM_COLUMNS` in `approval-voting`
      
      * Use `columns::v3::NUM_COLUMNS` when opening db
      
      * Update node/service/src/parachains_db/upgrade.rs
      
      Co-authored-by: default avatarAndrei Sandu <[email protected]>
      
      * Don't write in `COL_DISPUTE_COORDINATOR_DATA` for `test_rocksdb_migrate_2_to_3`
      
      * Fix `NUM+COLUMNS` in approval_voting
      
      * Fix formatting
      
      * Fix columns usage
      
      * Clarification comments about the different db versions
      
      ---------
      
      Co-authored-by: default avatarAndrei Sandu <[email protected]>
      eb1ed63b
  23. May 26, 2023
    • Adrian Catangiu's avatar
      cli: enable BEEFY by default on test networks (#7293) · 035b2486
      Adrian Catangiu authored
      
      
      We consider BEEFY mature enough to run by default on all nodes
      for test networks (Rococo/Wococo/Versi).
      
      Right now, most nodes are not running it since it's opt-in using
      --beefy flag. Switch to an opt-out model for test networks.
      
      Replace --beefy flag from CLI with --no-beefy and have BEEFY
      client start by default on test networks.
      
      Signed-off-by: default avataracatangiu <[email protected]>
      035b2486
  24. May 19, 2023
  25. May 15, 2023
  26. May 12, 2023
  27. May 11, 2023
  28. May 10, 2023
  29. May 05, 2023