1. Aug 20, 2021
  2. Aug 19, 2021
  3. Aug 16, 2021
  4. Aug 13, 2021
  5. Aug 08, 2021
  6. Aug 07, 2021
  7. Aug 06, 2021
  8. Aug 05, 2021
  9. Aug 04, 2021
    • Lldenaurois's avatar
      node/approval-voting: Continue to migrate tests to subsystem tests (#3471) · 86f14eed
      Lldenaurois authored
      * node/approval-voting: Continue to migrate tests to subsystem tests
      
      * node/approval-voting: Continue to implement subsystem tests.
      
      * Add more tests
      
      * node/approval-voting: Add more tests
      
      * node/approval-voting: Difficuly determining the proper test scenario for threshold tests
      
      * node/approval-voting: Introduce should_trigger_assignment tests
      
      * node/approval-voting: Finalize threshold tests
      
      * node/approval-voting: Address Feedback and add comments
      
      * node/approval-voting: Tidy up approval tests
      
      * Tidy up tests
      
      * Fix rustfmt
      86f14eed
  10. Aug 02, 2021
  11. Jul 27, 2021
  12. Jul 26, 2021
    • Bernhard Schuster's avatar
      integrate dispute finality (#3484) · 6519ba98
      Bernhard Schuster authored
      
      
      * finality_target adjustments
      
      * fn finality_target
      
      * partially address review comments
      
      * fixins
      
      * more rustic if condition
      
      * fix tests
      
      * fixins
      
      * Update node/core/approval-voting/src/lib.rs
      
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      
      * Update node/core/approval-voting/src/lib.rs
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * review comments part one
      
      * rename candidates -> block_descriptions
      
      * testing outline (incomplete, WIP)
      
      * test foo
      
      * split RelayChainSelection into RelayChainSelection{,WithFallback}, introduce HeaderProvider{,Provider}
      
      * make some stuff public (revert this soon™)
      
      * some test improvements
      
      * slips of pens
      
      * test fixins
      
      * add another trait abstraction
      
      * pending edge case tests + warnings fixes
      
      * more test cases
      
      * fin
      
      * chore fmt
      
      * fix cargo.lock
      
      * Undo obsolete changes
      
      * // comments
      
      * make mod pub(crate)
      
      * fix
      
      * minimize static bounds
      
      * resolve number() as before
      
      * fmt
      
      * post merge fix
      
      * address some nits
      
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      6519ba98
    • ordian's avatar
      enable disputes (#3478) · bd9b7438
      ordian authored
      
      
      * initial integration and migration code
      
      * fix tests
      
      * fix counting test
      
      * assume the current version on missing file
      
      * use SelectRelayChain
      
      * remove duplicate metric
      
      * Update node/service/src/lib.rs
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * remove ApprovalCheckingVotingRule
      
      * address my concern
      
      * never mode for StagnantCheckInterval
      
      * REVERTME: some logs
      
      * w00t
      
      * it's ugly but it works
      
      * Revert "REVERTME: some logs"
      
      This reverts commit e210505a2e83e31c381394924500b69277bb042e.
      
      * it's handle, not handler
      
      * fix a few typos
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      bd9b7438
  13. Jul 21, 2021
    • Lldenaurois's avatar
      Dispute coordinator - Recover disputes on startup (#3481) · 1858ff57
      Lldenaurois authored
      * node/dispute-coordinator: Introduce resume capability
      
      This commit introduces a resume capability for the
      dispute coordinator subsystem. Specifically, this will allow
      to recover data for disputes for which we have no local statements.
      
      * node/dispute-coordinator: Add resume function to TestState and modify Harness
      
      This commit modifies the TestHarness to return a TestState. We subsequently
      define a resume function on TestState that allows to interrupt the test and
      test specifically for behavior on startup of the subsystem.
      
      * node/dispute-coordinator: Implement resume functionality
      
      This commit implements the resume functionality for the subsystem.
      In addition, we will forward any DisputeParticipation::Participate
      message in order to ensure that disputes for which we do not have
      local statements may be recovered in due time.
      
      * Address Feedback
      
      * Modify to run handle_leaf on first import
      
      * Modify missing_local_statement logic
      
      * node/dispute-coordinator: Add simple test to ensure we adequately
      handle local_statements that are not missing.
      
      * Add missing keystore tests
      1858ff57
  14. Jul 19, 2021
  15. Jul 14, 2021
    • Denis_P's avatar
      WIP: CI: add spellcheck (#3421) · fc253e6e
      Denis_P authored
      
      
      * CI: add spellcheck
      
      * revert me
      
      * CI: explicit command for spellchecker
      
      * spellcheck: edit misspells
      
      * CI: run spellcheck on diff
      
      * spellcheck: edits
      
      * spellcheck: edit misspells
      
      * spellcheck: add rules
      
      * spellcheck: mv configs
      
      * spellcheck: more edits
      
      * spellcheck: chore
      
      * spellcheck: one more thing
      
      * spellcheck: and another one
      
      * spellcheck: seems like it doesn't get to an end
      
      * spellcheck: new words after rebase
      
      * spellcheck: new words appearing out of nowhere
      
      * chore
      
      * review edits
      
      * more review edits
      
      * more edits
      
      * wonky behavior
      
      * wonky behavior 2
      
      * wonky behavior 3
      
      * change git behavior
      
      * spellcheck: another bunch of new edits
      
      * spellcheck: new words are koming out of nowhere
      
      * CI: finding the master
      
      * CI: fetching master implicitly
      
      * CI: undebug
      
      * new errors
      
      * a bunch of new edits
      
      * and some more
      
      * Update node/core/approval-voting/src/approval_db/v1/mod.rs
      
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      
      * Update xcm/xcm-executor/src/assets.rs
      
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      
      * Suggestions from the code review
      
      * CI: scan only changed files
      
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      fc253e6e
  16. Jul 13, 2021
    • Lldenaurois's avatar
      Dispute coordinator overlay (#3462) · dc092778
      Lldenaurois authored
      * node/dispute-coordinator: Modify db to return SubsystemResult.
      
      In preparation of moving to the overlayed backend pattern, this commit
      moves the db to return SubsystemResult values.
      
      * node/dispute-coordinator: Add the Backend and OverlayedBackend.
      
      This commit adds the backend and overlayed backend structs to the
      dispute-coordinator subsystem.
      
      * node/dispute-coordinator: Implement backend and overlayed-backend.
      
      This commit finalizes the move from the previous transactional model
      to the common overlay pattern in subsystem persistency. This can be
      observed in the ApprovalVoting and ChainSelection subsystems.
      
      * Add module docs + license
      
      * Touchup merge
      dc092778
    • Lldenaurois's avatar
      Dispute Coordinator: Batch queries (#3459) · 2d66b8f2
      Lldenaurois authored
      * disputes: Allow batch queries in dispute-coordinator
      
      This commit moves to batch queries when responding to QueryCandidateVotes
      messages. This simplifies the code in the provisioner and dispute-coordinator
      by no longer requiring to make use of a FuturesOrdered when awaiting multiple
      quries. Instead, the provisioner need only request the batch itself.
      
      * node/approval-voting: Address Feedback to fail on query element missing.
      
      * Address feedback
      
      * Fix implementer's guide
      2d66b8f2
  17. Jul 12, 2021
  18. Jul 09, 2021
    • asynchronous rob's avatar
      Wire up candidate backing, approval-voting to disputes (#3348) · e5122227
      asynchronous rob authored
      * add a from_backing_statement to SignedDisputeStatement
      
      * inform dispute coordinator of all backing statements
      
      * add dispute coordinator message to backing tests
      
      * send positive dispute statement with every approval
      
      * issue disputes when encountering invalid candidates.
      
      * try to fix flaky test for CI (passed locally)
      
      * guide: keep track of concluded-positive disputes until pruned
      
      * guide: block implications
      
      * guide: new dispute inherent flow
      
      * mostly implement recency changes for dispute coordinator
      
      * add a clock to dispute coordinator
      
      * adjust DB tests
      
      * fix and add new dispute coordinator tests
      
      * provisioner: select disputes
      
      * import all validators' approvals
      
      * address nit: refactor backing statement submission
      
      * gracefully handle disconnected dispute coordinator
      
      * remove `review` comment
      
      * fix up old_tests
      
      * fix approval-voting compilation
      
      * fix backing compilation
      
      * use known-leaves in WaitForActivation
      
      * follow-up test fixing
      
      * add back allow(dead_code)
      e5122227
    • Bernhard Schuster's avatar
      thiserror annotations + spelling (#3452) · d76560fe
      Bernhard Schuster authored
      * remove duplicate thiserror annotations
      
      * chore: cargo spellcheck
      d76560fe
    • Robert Klotzner's avatar
      Dispute distribution implementation (#3282) · b5257b24
      Robert Klotzner authored
      * Dispute protocol.
      
      * Dispute distribution protocol.
      
      * Get network requests routed.
      
      * WIP: Basic dispute sender logic.
      
      * Basic validator determination logic.
      
      * WIP: Getting things to typecheck.
      
      * Slightly larger timeout.
      
      * More typechecking stuff.
      
      * Cleanup.
      
      * Finished most of the sending logic.
      
      * Handle active leaves updates
      
      - Cleanup dead disputes
      - Update sends for new sessions
      - Retry on errors
      
      * Pass sessions in already.
      
      * Startup dispute sending.
      
      * Provide incoming decoding facilities
      
      and use them in statement-distribution.
      
      * Relaxed runtime util requirements.
      
      We only need a `SubsystemSender` not a full `SubsystemContext`.
      
      * Better usability of incoming requests.
      
      Make it possible to consume stuff without clones.
      
      * Add basic receiver functionality.
      
      * Cleanup + fixes for sender.
      
      * One more sender fix.
      
      * Start receiver.
      
      * Make sure to send responses back.
      
      * WIP: Exposed authority discovery
      
      * Make tests pass.
      
      * Fully featured receiver.
      
      * Decrease cost of `NotAValidator`.
      
      * Make `RuntimeInfo` LRU cache size configurable.
      
      * Cache more sessions.
      
      * Fix collator protocol.
      
      * Disable metrics for now.
      
      * Make dispute-distribution a proper subsystem.
      
      * Fix naming.
      
      * Code style fixes.
      
      * Factored out 4x copied mock function.
      
      * WIP: Tests.
      
      * Whitespace cleanup.
      
      * Accessor functions.
      
      * More testing.
      
      * More Debug instances.
      
      * Fix busy loop.
      
      * Working tests.
      
      * More tests.
      
      * Cleanup.
      
      * Fix build.
      
      * Basic receiving test.
      
      * Non validator message gets dropped.
      
      * More receiving tests.
      
      * Test nested and subsequent imports.
      
      * Fix spaces.
      
      * Better formatted imports.
      
      * Import cleanup.
      
      * Metrics.
      
      * Message -> MuxedMessage
      
      * Message -> MuxedMessage
      
      * More review remarks.
      
      * Add missing metrics.rs.
      
      * Fix flaky test.
      
      * Dispute coordinator - deliver confirmations.
      
      * Send out `DisputeMessage` on issue local statement.
      
      * Unwire dispute distribution.
      
      * Review remarks.
      
      * Review remarks.
      
      * Better docs.
      b5257b24
  19. Jul 08, 2021
    • Bernhard Schuster's avatar
    • Lldenaurois's avatar
      Approval voting full subsystem tests (#3391) · 2510bfc5
      Lldenaurois authored
      * node/approval-voting: Introduce Backend trait and Overlaybackend
      
      This commit introduces a Backend trait and attempts to move away
      from the Action model via an OverlayBackend as in the ChainSelection
      subsystem.
      
      * node/approval-voting: Add WriteOps for StoredBlockRange and BlocksAtHeight
      
      * node/approval-voting: Add load_all_blocks to overlay
      
      * node/approval-voting: Get all module tests to pass.
      
      This commit modifies all tests to ensure tests are passing.
      
      * node/approval-voting: Address oversights in the previous commit
      
      This commit addresses some oversights in the prior commit.
      
      1. Inner errors in backend.write were swallowed
      2. One-off write functions removed to avoid useless abstraction
      3. Touch-ups in general
      
      * node/approval-voting: Move from TestDB to dyn KeyValueDB
      
      This commit removes the TestDB from tests.rs and replaces it with
      an in-memory kvdb.
      
      * node/approval-voting: Address feedback
      
      * node/approval-voting: Add license to ops.rs
      
      * node/approval-voting: Address second-pass feedback
      
      * Add TODO
      
      * node/approval-voting: Bump spec_version
      
      * node/approval-voting: Address final comments.
      
      * node/approval-voting: Introduce framework for full subsystem tests
      
      * node/approval-voting: Introduce basic tests to attempt to provide
      coverage via full subsystem tests
      
      * node/approval-voting: Introduce Chainbuilder
      2510bfc5
    • Lldenaurois's avatar
      Approval voting overlay db (#3366) · 7313e485
      Lldenaurois authored
      * node/approval-voting: Introduce Backend trait and Overlaybackend
      
      This commit introduces a Backend trait and attempts to move away
      from the Action model via an OverlayBackend as in the ChainSelection
      subsystem.
      
      * node/approval-voting: Add WriteOps for StoredBlockRange and BlocksAtHeight
      
      * node/approval-voting: Add load_all_blocks to overlay
      
      * node/approval-voting: Get all module tests to pass.
      
      This commit modifies all tests to ensure tests are passing.
      
      * node/approval-voting: Address oversights in the previous commit
      
      This commit addresses some oversights in the prior commit.
      
      1. Inner errors in backend.write were swallowed
      2. One-off write functions removed to avoid useless abstraction
      3. Touch-ups in general
      
      * node/approval-voting: Move from TestDB to dyn KeyValueDB
      
      This commit removes the TestDB from tests.rs and replaces it with
      an in-memory kvdb.
      
      * node/approval-voting: Address feedback
      
      * node/approval-voting: Add license to ops.rs
      
      * node/approval-voting: Address second-pass feedback
      
      * Add TODO
      
      * node/approval-voting: Bump spec_version
      
      * node/approval-voting: Address final comments.
      7313e485
  20. Jul 07, 2021
  21. Jul 06, 2021
    • asynchronous rob's avatar
      Chain Selection: Follow-ups (#3328) · f69c1751
      asynchronous rob authored
      
      
      * DB skeleton
      
      * key formats
      
      * lexicographic test
      
      * custom types for DB
      
      * implement backend for db-v1
      
      * remove VoidBackend and integrate with real DbBackend
      
      * detect stagnant blocks on in interval
      
      * fix tests
      
      * add tests for stagnant
      
      * send ChainSelectionMessage::Approved
      
      * tests for DB backend
      
      * unused import
      
      * upgrade kvdb-memorydb
      
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      f69c1751
  22. Jul 05, 2021
  23. Jul 02, 2021