- Apr 20, 2023
-
-
Marcin S. authored
* PVF: Don't dispute on missing artifact A dispute should never be raised if the local cache doesn't provide a certain artifact. You can not dispute based on this reason, as it is a local hardware issue and not related to the candidate to check. Design: Currently we assume that if we prepared an artifact, it remains there on-disk until we prune it, i.e. we never check again if it's still there. We can change it so that instead of artifact-not-found triggering a dispute, we retry once (like we do for AmbiguousWorkerDeath, except we don't dispute if it still doesn't work). And when enqueuing an execute job, we check for the artifact on-disk, and start preparation if not found. Changes: - [x] Integration test (should fail without the following changes) - [x] Check if artifact exists when executing, prepare if not - [x] Return an internal error when file is missing - [x] Retry once on internal errors - [x] Document design (update impl guide) * Add some context to wasm error message (it is quite long) * Fix impl guide * Add check for missing/inaccessible file * Add comment referencing Substrate issue * Add test for retrying internal errors --------- Co-authored-by: parity-processbot <>
-
- Apr 19, 2023
-
-
Marcin S. authored
* pvf: Update docs for PVF artifacts * pvf: Clarify doc re. node start-up
-
Davide Galassi authored
* Companion for substrate #13889 * Remove leftover * Remove removed dependency * Remove sp-consensus-vrf from lock * Revert "Remove sp-consensus-vrf from lock" This reverts commit 2269ca1e32df89272e8fd4544292204db387f436. * Fix after substrate modifications * Fix tests to use new VRF Signature type * Don't rely of Deref trait * Fix test * Further code simplification * Reuse garbage_vrf_signature * update lockfile for {"substrate"} --------- Co-authored-by: parity-processbot <>
-
- Apr 17, 2023
-
-
dependabot[bot] authored
Bumps [hex-literal](https://github.com/RustCrypto/utils) from 0.3.4 to 0.4.1. - [Release notes](https://github.com/RustCrypto/utils/releases) - [Commits](https://github.com/RustCrypto/utils/compare/hex-literal-v0.3.4...hex-literal-v0.4.1 ) --- updated-dependencies: - dependency-name: hex-literal dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
Koute authored
-
- Apr 11, 2023
-
-
Mira Ressel authored
* Simplify &(ref foo, _) tuple pattern matches * Drop unneccessary .clone() calls * Replace .position(cond).is_some() by .any(cond) * Drop unneccessary lifetime specs
-
- Apr 08, 2023
-
-
s0me0ne-unkn0wn authored
* Happy New Year! * Remove year entierly Co-authored-by: Oliver Tale-Yazdi <[email protected]> * Remove years from copyright notice in the entire repo --------- Co-authored-by: Oliver Tale-Yazdi <[email protected]>
-
- Apr 07, 2023
-
-
Tsvetomir Dimitrov authored
Onchain scraper in `dispute-coordinator` will scrape `SCRAPED_FINALIZED_BLOCKS_COUNT` blocks before finality (#7013) * Onchain scraper in `dispute-coordinator` will scrape `SCRAPED_FINALIZED_BLOCKS_COUNT` blocks before finality The purpose is to make the availability of a `CandidateReceipt` for finalized candidates more likely. For details see: https://github.com/paritytech/polkadot/issues/7009 * Fix off by one error * Replace `SCRAPED_FINALIZED_BLOCKS_COUNT` with `DISPUTE_CANDIDATE_LIFETIME_AFTER_FINALIZATION`
-
Marcin S. authored
* Move version check to `worker_event_loop` * More minor refactors - More consistent use of `format_invalid` and `format_internal`. - Fix a doc error. - Fix some poorly-named local variables.
-
- Apr 05, 2023
-
-
s0me0ne-unkn0wn authored
-
- Apr 04, 2023
-
-
s0me0ne-unkn0wn authored
* Companion for paritytech/substrate#13811 * Add comment * update lockfile for {"substrate"} * Update Substrate Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Fix pallet weight warnings Signed-off-by: Oliver Tale-Yazdi <[email protected]> --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: parity-processbot <> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
-
Bastian Köcher authored
* Substrate companion: Remove deprecated batch verification * update lockfile for {"substrate"} --------- Co-authored-by: parity-processbot <>
-
- Mar 31, 2023
-
-
Mattia L.V. Bradascio authored
* Pass the PerLeafSpan as mutable reference to handle_new_head function * cargo +nightly fmt --all * Add mock span for test * cargo +nightly fmt --all * add new-blocks-hashes to span * ref span in match statement, set span to disabled if not passed * remove second match clause, make handle_new_head_span mutable * cargo +nightly fmt --all * improve tag on error and warning * add imported blocks and info span * cargo +nightly fmt --all * Improve error for imported_blocks_and_info trace * format tags on get_header_span * add lost-to-finality tag * add missing bracket * - Add bitfield child span - Add block db insertion span * - fix update-bitfield span tag * - Fix type conversion to u64 - Add missing argument * - Cargo fmt * - Test add_follows_from * - Revert as relationship between spans not working correctly * - use drop to test if parent-child relationship can be re-established * - remove bitfield span, check if parent-child relationship can be reestablished * - Remove dangling bitfield span which is not used, to see if parent-child relationship can be re-established * Another dangling bitfield span * cargo fmt * - add imported blocks and info span - add candidate span per candidate * add tags before moving block_header to push scope * - Add db-insertion span * cargo fmt * fix types * * Pass mutable reference to span in handle_new_head * Change get-header-span tags in handle_new_head * Create cache-session-info span in handle_new_head * Create optional argument in determine_new_blocks * Pass mutable reference to handle_new_head_span in determine_new_blocks in handle_new_head function * Add candidate-hash, candidate-number, lost-to-finality tags to candidate_span in handle_new_head function * Manually drop db_insertion_span and remove superfluous tags to it, only keeping approved-bitfields tag * Add ApprovalVoting stage in jaeger * * Pass mutable reference to jaeger::Span in stead of PerLeafSpan * Add block-import span * *Pass optional_span (optional argument) to determine_new_blocks util function * * Add num-candidates int tag to block_import_span * * Add head tag to cache_session_span * * Create PerLeafSpan in handle_from_overseer (this is required to establish parent-child relationship between approval-voting span, and leaf-activated root span) * * Add candidate-import-span as child of block-import-span * Add candidate-hash and num-approval tags to candidate-import-span * * Fix num-candidate tag to bitvec-len tag in candidate-import-span * *Fix imported_blocKs_and_info span to create new-block-span as not dealing with candidates * Consider the future::select! block * Use HashMap<Hash, jaeger::PerLeafSpan> * Remove Stage 9 * Add missing spans * cargo +nightly fmt --all * Remove optional span argument for determine_new_blocks * * Remove no-longer needed default PerLeafSpan implementation * Remove no-longer necessary mock span given re-factoring of handle_new_head() no longer neeing mutable span * Split validation-result and request-data (availability and validation code) spans into two by dropping request_validation_data_spans * Remove drop statements for cache_session_info_span * * Remove unnecessary span * Remove another excessively spammy span * Add missing spans from State in import tests * Use functional approach to get spans * - Add functional approach for the approval-voting span - Add doc on block_numbers given labelling ambiguity - Add span pruning logic - Use .add_para_id on validation_result_span * Replace for hash_set in hash_set_iter with map closure * cargo +nightly fmt --all * Change from unconsumed `map` to `.for_each` * cargo +nightly fmt --all * Refactor add_para_id to validation_result_span * cargo +nightly fmt --all * Remove duplicate tag * Add missing tag to handle-approved-ancestor span * Refactor span pruning to only invoke retain once * Typo in span name * - Replace unwrap_or with unwrap_or_else due to lazy evaluation of trace-identifier in polkadot_node_jaeger - Remove some redundant spans * Add approval-distribution spans * - Add unwrap_or_else on note-approved-in-chain-selection - Use child_with_trace_id to add traceID string tag on span (note this does not change the traceID, but just adds a tag) * cargo +nightly fmt --all * - Add traceID tags were necessary in approval-voting and availability-distribution - Always use block-hash tag in stead of relay-parent tag in approval-distribution * Remove schedule-wakeup span as it will duplicate spans on existing wakeups (which should be a no-op) * Remove a couple of warnings related to mutability * Fix failing tests in availability distribution * Add traceID tag to launch-approval and validation-result * Reshuffle the validation and validation result spans to where more appropriate and add block-hash tag * - Add tranche and should-trigger tag to process-wakeup span - Add candidate-hash and traceID to check-and-import-approval span * cargo fmt * - Adjustments after PR comments * Move span pruning after other pruning logic * Remove DerefMut - no longer needed * Relabel request-chunk spans * - Fix typo in span label - Add docs for drops * Add new approval-voting span pruning logic * Undo removal of ! * cargo fmt
-
- Mar 30, 2023
-
-
Bradley Olson authored
* First pass adding logs * fmt * Adjustments * Get rid of extra timers for running participations * fmt * Handling timer discards more elegantly
-
s0me0ne-unkn0wn authored
-
- Mar 29, 2023
-
-
s0me0ne-unkn0wn authored
* Check spawned worker version vs node version before PVF preparation * Address discussions * Propagate errors and shutdown preparation and execution pipelines properly * Add logs; Fix execution worker checks * Revert "Propagate errors and shutdown preparation and execution pipelines properly" This reverts commit b96cc3160ff58db5ff001d8ca0bfea9bd4bdd0f2. * Don't try to shut down; report the condition and exit worker * Get rid of `VersionMismatch` preparation error * Merge master * Add docs; Fix tests * Update Cargo.lock * Kill again, but only the main node process * Move unsafe code to a common safe function * Fix libc dependency error on MacOS * pvf spawning: Add some logging, add a small integration test * Minor fixes * Restart CI --------- Co-authored-by: Marcin S <[email protected]>
-
- Mar 24, 2023
-
-
Davide Galassi authored
* Companion for #13683 * Wraps trait is not required * update lockfile for {"substrate"} --------- Co-authored-by: parity-processbot <>
-
- Mar 23, 2023
-
-
Tsvetomir Dimitrov authored
-
Bastian Köcher authored
This ensures that both subsystems exit when the Overseer has exited because of some error.
-
- Mar 21, 2023
-
-
Bradley Olson authored
* Added participation and queue sizes metrics * First draft of all metric code * Tests pass * Changed Metrics to field on participation + queues * fmt * Improving naming * Refactor, placing timer in ParticipationRequest * fmt * Final cleanup * Revert "Final cleanup" This reverts commit 02e5608df64b2e0f7810905e4508673b2037d351. * Changing metric names * Implementing Eq only for unit tests * fmt * Removing Clone trait from ParticipationRequest * fmt * Moved clone functionality to tests helper * fmt * Fixing dropped timers on repeat requests * Keep older best effort timers * Removing comment redundency and explaining better * Updating queue() to use single mem read * fmt
-
- Mar 20, 2023
-
-
Mira Ressel authored
-
Vsevolod Stakhov authored
This reverts commit 5565bb9d.
-
- Mar 17, 2023
-
-
Davide Galassi authored
* Remove not required async calls * Fixed missing renaming * make_keystore can be sync * More fixes * Trivial nitpicks * Cherry pick test fix from master * Fixes after master merge * update lockfile for {"substrate"} --------- Co-authored-by: parity-processbot <>
-
Davide Galassi authored
-
- Mar 16, 2023
-
-
Bradley Olson authored
* First pass adding logs * fmt * Adjustments
-
Bradley Olson authored
* Added participation and queue sizes metrics * First draft of all metric code * Tests pass * Changed Metrics to field on participation + queues * fmt * Improving naming * Refactor, placing timer in ParticipationRequest * fmt * Final cleanup * Revert "Final cleanup" This reverts commit 02e5608df64b2e0f7810905e4508673b2037d351. * Changing metric names * Implementing Eq only for unit tests * fmt * Removing Clone trait from ParticipationRequest * fmt * Moved clone functionality to tests helper
-
- Mar 15, 2023
-
-
s0me0ne-unkn0wn authored
-
Marcin S. authored
* PVF: Document that preparation cannot lead to disputes * Add warning for deterministic errors * Fix warning
-
- Mar 14, 2023
-
-
Vsevolod Stakhov authored
* Test the recent orchestra changes * Update orchestra and metered-channel
-
- Mar 11, 2023
-
-
Bradley Olson authored
* Added participation and queue sizes metrics * First draft of all metric code * Tests pass * Changed Metrics to field on participation + queues * fmt * Improving naming * Refactor, placing timer in ParticipationRequest * fmt * Final cleanup * Revert "Final cleanup" This reverts commit 02e5608df64b2e0f7810905e4508673b2037d351. * Changing metric names * Implementing Eq only for unit tests * fmt
-
- Mar 08, 2023
-
-
s0me0ne-unkn0wn authored
* Move PVF timeouts to executor environment parameters * Typo Co-authored-by: Marcin S. <[email protected]> * Fix comments * Change handle_import_statements to FatalResult (#6820) * Changing dispute db errors to fatal * fmt * Change node-key for bootnodes (#6772) * Additional tracing in `provisioner`, `vote_selection` and `dispute-coordinator` (#6775) * Additional tracing in `provisioner`, `vote_selection` * Add `fetched_onchain_disputes` metric to provisioner * Some tracelines in dispute-coordinator TODO: cherry pick this in the initial branch!!! * Remove spammy logs * Remove some trace lines * Rename and fix things * Fix comments * Typo * Minor fixes * Add codec indexes; Remove macro --------- Co-authored-by: Marcin S. <[email protected]> Co-authored-by: Bradley Olson <[email protected]> Co-authored-by: Petr Mensik <[email protected]> Co-authored-by: Tsvetomir Dimitrov <[email protected]>
-
- Mar 06, 2023
-
-
Tsvetomir Dimitrov authored
* Additional tracing in `provisioner`, `vote_selection` * Add `fetched_onchain_disputes` metric to provisioner * Some tracelines in dispute-coordinator TODO: cherry pick this in the initial branch!!! * Remove spammy logs * Remove some trace lines
-
- Mar 04, 2023
-
-
Bradley Olson authored
* Changing dispute db errors to fatal * fmt
-
- Mar 02, 2023
-
-
eskimor authored
Co-authored-by: eskimor <[email protected]>
-
- Feb 24, 2023
-
-
Bradley Olson authored
* Initial pass * fmt * Lock changes * Implementers guide edit * Reasoning changes * typo Co-authored-by: Marcin S. <[email protected]> * Revert "Lock changes" This reverts commit 3131a5245c6349743789270e6d1ad7842dc4c9df. * Getting rid of cargo.lock changes * Argumentation update * fmt --------- Co-authored-by: Marcin S. <[email protected]>
-
Bastian Köcher authored
* Companion for Substrate#12520 https://github.com/paritytech/substrate/pull/12520 * Fix * update lockfile for {"substrate"} --------- Co-authored-by: parity-processbot <>
-
- Feb 20, 2023
-
-
s0me0ne-unkn0wn authored
-
s0me0ne-unkn0wn authored
-
- Feb 16, 2023
-
-
Tsvetomir Dimitrov authored
-
Bastian Köcher authored
* Change `MaxMemorySize` to `MaxMemoryPages` We should set the max memory for the executor in pages (64KiB) and not in bytes. The wasm memory is always a multiple of a page and we should use the same terminology. * FMT * Fix warning
-