Skip to content
  1. Dec 06, 2022
  3. Dec 05, 2022
  5. Dec 04, 2022
    • Bastian Köcher's avatar
      frame-executive: Reject invalid inherents in the executive (#12365) · 1943e25c
      Bastian Köcher authored 
      

* frame-executive: Reject invalid inherents in the executive

We already had support for making a block fail if an inherent returned, but it was part of the
signed extension `CheckWeight`. Rejecting blocks with invalid inherents should happen on the
`frame-executive` level without requiring any special signed extension. This is crucial to prevent
any kind of spamming of the network that could may happen with blocks that include failing inherents.

* FMT

* Update frame/executive/src/lib.rs

Co-authored-by: default avatarKeith Yeung <[email protected]>

* Update primitives/runtime/src/transaction_validity.rs

Co-authored-by: default avatarKeith Yeung <[email protected]>

Co-authored-by: parity-processbot <>
Co-authored-by: default avatarKeith Yeung <[email protected]>
      1943e25c
  7. Dec 03, 2022
  9. Dec 02, 2022
  11. Dec 01, 2022
  13. Nov 30, 2022
  15. Nov 29, 2022
  17. Nov 28, 2022
    • joe petrowski's avatar
      Remove Default, HasCompact, and TypeInfo trait bounds on AssetId (#12740) · d56214c2
      joe petrowski authored 
      * Remove Default, HasCompact, and TypeInfo trait bounds on AssetId

* don't use default in benchmarking

* add helper trait

* add helper to assets tx payment test

* docs fixes

* i'm confused

* aha, cargo

* move affected dispatchable calls into new indices

* Helper -> BenchmarkHelper

* benchmark use of helper

* actually, don't break every call interface

* use into on AssetIdParameter

* Remove From from AssetIdParameter and use it in BenchmarkHelper

* include from

Co-authored-by: parity-processbot <>
      d56214c2
  19. Nov 27, 2022
  21. Nov 25, 2022
  23. Nov 24, 2022
    • Alexander Theißen's avatar
      contracts: Replace `sp-sandbox` and `wasmi-validation` by newest wasmi (#12501) · 08657f14
      Alexander Theißen authored 
      

* Replace sp-sandbox and wasmi-validation by just wasmi

* ".git/.scripts/bench-bot.sh" pallet dev pallet_contracts

* Re-check original code on re-instrumentation

* Fix clippy

* ".git/.scripts/bench-bot.sh" pallet dev pallet_contracts

* Apply suggestions from code review

Co-authored-by: default avatarRobin Freyler <[email protected]>

* Replace wasmi by ::wasmi

* Bump wasmi to 0.20

* Add explanation for `unreachable`

* Change proof

* Fixup master merge

* ".git/.scripts/bench-bot.sh" pallet dev pallet_contracts

* Fixup naming inconsistencies introduced by reentrancy PR

* Fix `scan_imports` docs

* Apply suggestions from code review

Co-authored-by: default avatarSasha Gryaznov <[email protected]>

* Fixup suggestions

* Remove unnecessary &mut

* Fix test

* ".git/.scripts/bench-bot.sh" pallet dev pallet_contracts

* Fix benchmark merge fail

* ".git/.scripts/bench-bot.sh" pallet dev pallet_contracts

* Fix docs as suggested by code review

* Improve docs for `CodeRejected`

* Apply suggestions from code review

Co-authored-by: default avatarSasha Gryaznov <[email protected]>

* Fix logic bug when setting `deterministic_only`

* Don't panic when module fails to compile

* Apply suggestions from code review

Co-authored-by: default avatarRobin Freyler <[email protected]>

Co-authored-by: command-bot <>
Co-authored-by: default avatarRobin Freyler <[email protected]>
Co-authored-by: default avatarSasha Gryaznov <[email protected]>
      08657f14
  25. Nov 23, 2022
  27. Nov 21, 2022
    • Roman Useinov's avatar
      [Fix] Get target count from TargetList instead of storage (#12748) · 4cb24da8
      Roman Useinov authored 
      Co-authored-by: parity-processbot <>
      4cb24da8
    • Adrian Catangiu's avatar
      client/beefy: persist voter state (#12712) · 3e7a2778
      Adrian Catangiu authored 
      

* client/beefy: prepare worker for persisting state

* client/beefy: persist voter state

* client/beefy: initialize persistent state

* client/beefy: try to vote from the very beginning

Now that voter is initialized from persistent state, it makes
sense that it can attempt voting right away. This also helps
the genesis case when we consider block `One` as mandatory.

* client/beefy: add tests for voter state db
* client/beefy: persist voter state as soon as initialized
* client/beefy: make sure min-block-delta is at least 1
* client/beefy: persist state after voting

Persist state after handling self vote to avoid double voting in case
of voter restarts.

* client/beefy: persist state after handling mandatory block vote

For mandatory blocks we want to make sure we're not losing votes
in case of crashes or restarts, since voter will not make further
progress without finalizing them.

* frame/beefy: use GENESIS_AUTHORITY_SET_ID on pallet genesis

* client/beefy: initialize voter at either genesis or last finalized
To guarantee unbroken chain of mandatory blocks justifications, voter
will always resume from either last BEEFY-justified block or
`pallet-beefy` genesis, whichever is more recent.

Initialization walks back the chain from latest GRANDPA finalized
block looking for one of the above. Along the way, it also records
and enqueues for processing any BEEFY mandatory blocks that have
been already GRANDPA finalized but not BEEFY finalized.

* client/beefy: decouple voter init from aux db state load
* client/beefy: fix voter init tests
* remove debug prints
* gadget future must be type ()
* fix init from last justification

Signed-off-by: default avatarAdrian Catangiu <[email protected]>
      3e7a2778
  29. Nov 18, 2022
    • Fredrik Simonsson's avatar
      Update template to remove clippy warnings (#12670) · 69c64416
      Fredrik Simonsson authored 
      * Update template to remove clippy warnings

* ".git/.scripts/bench-bot.sh" pallet dev pallet_lottery

* Update templates from child project

This should remove clippy warnings on generated files

* Update after review

* Update frame-weight-template.hbs

Commit suggestion

* ".git/.scripts/bench-bot.sh" pallet dev pallet_lottery

* Rerun linter on linked project

Updates from child project

* ".git/.scripts/bench-bot.sh" pallet dev pallet_lottery

Co-authored-by: command-bot <>
      69c64416
  31. Nov 17, 2022
  33. Nov 16, 2022
  35. Nov 15, 2022
    • Niklas Adolfsson's avatar
      release `sp-core 7.0.0` and `sp-runtime 7.0.0` (#12599) · 2b8af8cb
      Niklas Adolfsson authored 
      * chore(release): sp-core v7.0.0

* chore(release): sp-runtime v7.0.0

* fix bad merge
      2b8af8cb
    • Anthony Alaribe's avatar
      Assets Pallet: reintroduce fungibles::Destroy trait (#12708) · 880f6c9d
      Anthony Alaribe authored 
      * update docs formatting

* reintroduce the destroy trait

* copy changes from original PR

* remove witness

* Trigger CI

* Trigger CI
      880f6c9d
    • Artemka374's avatar
      `seal_reentrant_count` returns contract reentrant count (#12695) · 103ea38f
      Artemka374 authored 
      * Add logic, test, broken benchmark

* account_entrance_count

* Addressing comments

* Address @agryaznov

's comments

* Add test for account_entrance_count, fix ci

* Cargo fmt

* Fix tests

* Fix tests

* Remove delegated call from test, address comments

* Minor fixes and indentation in wat files

* Update test for account_entrance_count

* Update reentrant_count_call test

* Delegate call test

* Cargo +nightly fmt

* Address comments

* Update reentrant_count_works test

* Apply weights diff

* Add fixture descriptions

* Update comments as suggested

* Update reentrant_count_call test to use seal_address

* add missing code

* cargo fmt

* account_entrance_count -> account_reentrance_count

* fix tests

* fmt

* normalize signatures

Co-authored-by: default avataryarikbratashchuk <[email protected]>
      103ea38f
    • Anthony Alaribe's avatar
      Asset Pallet: Support repeated destroys to safely destroy large assets (#12310) · 679d2dcd
      Anthony Alaribe authored 
      

* Support repeated destroys to safely destroy large assets

* require freezing accounts before destroying

* support only deleting asset as final stage when there's no assets left

* pre: introduce the RemoveKeyLimit config parameter

* debug_ensure empty account in the right if block

* update to having separate max values for accounts and approvals

* add tests and use RemoveKeyLimit constant

* add useful comments to the extrinsics, and calculate returned weight

* add benchmarking for start_destroy and finish destroy

* push failing benchmark logic

* add benchmark tests for new functions

* update weights via local benchmarks

* remove extra weight file

* Update frame/assets/src/lib.rs

Co-authored-by: default avatarjoe petrowski <[email protected]>

* Update frame/assets/src/types.rs

Co-authored-by: default avatarjoe petrowski <[email protected]>

* Update frame/assets/src/lib.rs

Co-authored-by: default avatarjoe petrowski <[email protected]>

* effect some changes from codereview

* use NotFrozen error

* remove origin checks, as anyone can complete destruction after owner has begun the process; Add live check for other extrinsics

* fix comments about Origin behaviour

* add AssetStatus docs

* modularize logic to allow calling logic in on_idle and on_initialize hooks

* introduce simple migration for assets details

* reintroduce logging in the migrations

* move deposit_Event out of the mutate block

* Update frame/assets/src/functions.rs

Co-authored-by: default avatarMuharem Ismailov <[email protected]>

* Update frame/assets/src/migration.rs

Co-authored-by: default avatarMuharem Ismailov <[email protected]>

* move AssetNotLive checkout out of the mutate blocks

* rename RemoveKeysLimit to RemoveItemsLimit

* update docs

* fix event name in benchmark

* fix cargo fmt.

* fix lint in benchmarking

* Empty commit to trigger CI

* Update frame/assets/src/lib.rs

Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>

* Update frame/assets/src/lib.rs

Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>

* Update frame/assets/src/functions.rs

Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>

* Update frame/assets/src/functions.rs

Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>

* Update frame/assets/src/functions.rs

Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>

* Update frame/assets/src/lib.rs

Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>

* Update frame/assets/src/functions.rs

Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>

* effect change suggested during code review

* move limit to a single location

* Update frame/assets/src/functions.rs

Co-authored-by: default avatarjoe petrowski <[email protected]>

* rename events

* fix weight typo, using rocksdb instead of T::DbWeight. Pending generating weights

* switch to using dead_account.len()

* rename event in the benchmarks

* empty to retrigger CI

* trigger CI to check cumulus dependency

* trigger CI for dependent cumulus

* Update frame/assets/src/migration.rs

Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>

* move is-frozen to the assetStatus enum (#12547)

* add pre and post migration hooks

* update do_transfer logic to add new assert for more correct error messages

* trigger CI

* switch checking AssetStatus from checking Destroying state to checking live state

* fix error type in tests from Frozen to AssetNotLive

* trigger CI

* change ensure check for fn reducible_balance()

* change the error type to Error:<T,I>::IncorrectStatus to be clearer

* Trigger CI

Co-authored-by: default avatarjoe petrowski <[email protected]>
Co-authored-by: parity-processbot <>
Co-authored-by: default avatarMuharem Ismailov <[email protected]>
Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      679d2dcd