- Dec 09, 2024
-
-
Doordashcon authored
Adds NoOp implementation for the `Polling` trait and updates benchmarks in `pallet-ranked-collective`. --------- Co-authored-by:
Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> (cherry picked from commit 9f603b1a)
-
- Dec 05, 2024
- Dec 04, 2024
-
-
Alexandru Vasile authored
Backport for: https://github.com/paritytech/polkadot-sdk/pull/6742 cc @paritytech/sdk-node Signed-off-by:
Alexandru Vasile <alexandru.vasile@parity.io>
-
Alexandru Vasile authored
Backports: https://github.com/paritytech/polkadot-sdk/pull/6483 Builds on top of the backport: https://github.com/paritytech/polkadot-sdk/pull/6709 cc @paritytech/subxt-team Signed-off-by:
Alexandru Vasile <alexandru.vasile@parity.io> Co-authored-by:
James Wilson <james@jsdw.me>
-
Egor_P authored
Backport #6748 into `stable2412`
-
Egor_P authored
Backport #6734 into `stable2412`
-
- Dec 03, 2024
-
-
Alexandru Vasile authored
Backport for: https://github.com/paritytech/polkadot-sdk/pull/5997 cc @paritytech/subxt-team Signed-off-by:
Alexandru Vasile <alexandru.vasile@parity.io> Co-authored-by:
James Wilson <james@jsdw.me>
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #6562 into `stable2412` from re-gius. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by:
Giuseppe Re <giuseppe.re@parity.io> Co-authored-by:
GitHub Action <action@github.com> Co-authored-by:
Egor_P <egor@parity.io>
-
Niklas Adolfsson authored
Co-authored-by:
Tarek Mohamed Abdalla <tarekkma@gmail.com> Co-authored-by:
Egor_P <egor@parity.io>
-
- Nov 28, 2024
-
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #6684 into `stable2412` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by:
Branislav Kontur <bkontur@gmail.com>
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #6677 into `stable2412` from lexnv. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by:
Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
-
- Nov 27, 2024
-
-
Alexandru Vasile authored
This PR is a backport for: - https://github.com/paritytech/polkadot-sdk/pull/5732 cc @paritytech/subxt-team --------- Signed-off-by:
Alexandru Vasile <alexandru.vasile@parity.io> Co-authored-by:
Egor_P <egor@parity.io>
-
paritytech-cmd-bot-polkadot-sdk[bot] authored
Backport #6603 into `stable2412` from lexnv. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by:
Alexandru Vasile <60601340+lexnv@users.noreply.github.com> Co-authored-by:
Egor_P <egor@parity.io>
-
Egor_P authored
Backport #6640 into the `stable2412` from master
-
Branislav Kontur authored
This PR contains backports of: - https://github.com/paritytech/polkadot-sdk/pull/6465 - https://github.com/paritytech/polkadot-sdk/pull/6536 - https://github.com/paritytech/polkadot-sdk/pull/6579 - https://github.com/paritytech/polkadot-sdk/pull/6645 (when those were merged, bot didn't create backport PRs to stable2412) --------- Co-authored-by:
GitHub Action <action@github.com>
-
- Nov 25, 2024
-
-
Egor_P authored
# Description This PR adds the required changes to release `polkadot`, `polkadot-parachain` and `polkadot-omni-node` binaries built on Apple Sillicon macos. ## Integration This addresses requests from the community for such binaries: #802, and they should be part of the Github release page. ## Review Notes Test on paritytech-stg solely focused on macos binaries: https://github.com/paritytech-stg/polkadot-sdk/actions/runs/11824692766/job/32946793308, except the steps related to `pgpkms` (which need AWS credentials, missing from paritytech-stg). The binary names don't have a `darwin-arm` identifier, and conflict with the existing x86_64-linux binaries. I haven't tested building everything on `paritytech-stg` because the x86_64-linux builds run on `unbutu-latest-m` which isn't enabled on `pairtytech-stg` (and I haven't asked CI team to enable one), so testing how to go around naming conflicts should be covered next. ### TODO - [x] Test the workflow start to end (especially the last bits related to uploading the binaries on S3 and ensuring the previous binaries and the new ones coexist harmoniously on S3/action artifacts storage without naming conflicts) @EgorPopelyaev - [x] Publish the arm binaries on the Github release page - to clarify what's needed @iulianbarbu . Current practice is to manually publish the binaries built via `release-build-rc.yml` workflow, taken from S3. Would be great to have the binaries there in the first place before working on automating this, but I would also do it in a follow up PR. ### Follow ups - [ ] unify the binaries building under `release-30_publish_release_draft.yml` maybe? - [ ] automate binary artifacts upload to S3 in `release-30_publish_release_draft.yml` Signed-off-by:
Iulian Barbu <iulian.barbu@parity.io> Co-authored-by:
Iulian Barbu <14218860+iulianbarbu@users.noreply.github.com>
-
- Nov 20, 2024
-
-
EgorPopelyaev authored
-
EgorPopelyaev authored
-
- Nov 19, 2024
-
-
EgorPopelyaev authored
-
georgepisaltu authored
This PR is a backport of #6418. For context, `TransactionExtension`, introduced in #3685, is part of the `stable2412` release, and this PR brings important fixes and quality of life improvements. Doing the backport now allows us to not break the interface later. Opened against #6473 as the changes in the original PR were made on top of the changes in this backport. --------- Signed-off-by:
georgepisaltu <george.pisaltu@parity.io> Co-authored-by:
Guillaume Thiolliere <gui.thiolliere@gmail.com> Co-authored-by:
GitHub Action <action@github.com>
-
Alexandru Vasile authored
This PR updates the litep2p version on stable2412. The litep2p requires a user opt-in / non-default backend, and changes should not affect testing / stable libp2p versions. For more details see PR: - https://github.com/paritytech/polkadot-sdk/pull/6484 --------- Signed-off-by:
Alexandru Vasile <alexandru.vasile@parity.io>
-
Niklas Adolfsson authored
Co-authored-by:
GitHub Action <action@github.com>
-
thiolliere authored
add transaction source in the transaction extension API. Transaction extension is introduced in stable2412 so better not to break again later.
-
Francisco Aguirre authored
Backporting the new V5 `ExecuteWithOrigin` instruction to stable2412 --------- Signed-off-by:
Adrian Catangiu <adrian@parity.io> Co-authored-by:
Adrian Catangiu <adrian@parity.io> Co-authored-by:
Andrii <ndk@parity.io> Co-authored-by:
Branislav Kontur <bkontur@gmail.com> Co-authored-by:
Joseph Zhao <65984904+programskillforverification@users.noreply.github.com> Co-authored-by:
Nazar Mokrynskyi <nazar@mokrynskyi.com> Co-authored-by:
Bastian Köcher <git@kchr.de> Co-authored-by:
Shawn Tabrizi <shawntabrizi@gmail.com>
-
- Nov 07, 2024
-
-
ParityReleases authored
-
ParityReleases authored
-
ParityReleases authored
-
Xavier Lau authored
Part of: - #6202. --------- Co-authored-by:
Giuseppe Re <giuseppe.re@parity.io> Co-authored-by:
GitHub Action <action@github.com>
-
Alin Dima authored
Fixes https://github.com/paritytech/polkadot-sdk/issues/6172
-
Andrei Eres authored
# Description Implemented benchmarks for Notifications and RequestResponse protocols with libp2p implementation. These benchmarks allow us to monitor regressions and implement fixes before they are observed in real chain. In the future, they can be used for targeted optimizations of litep2p compared to libp2p. Part of https://github.com/paritytech/polkadot-sdk/issues/5220 Next steps: - Add benchmarks for litep2p implementation - Optimize load to get better results - Add benchmarks to CI to catch regressions ## Integration Benchmarks don't affect downstream projects. --------- Co-authored-by:
alvicsam <alvicsam@gmail.com> Co-authored-by:
GitHub Action <action@github.com>
-
Alexandre R. Baldé authored
# Description E2E tests to Polkadot/Kusama's people chains (in https://github.com/open-web3-stack/polkadot-ecosystem-tests/pull/63) revealed that 2 of the identity pallet's extrinsics did not emit events in case of success: * `pallet_identity::rename_sub`, and * `pallet_identity::set_subs` This PR fixes that. ## Integration Other than 2 extrinsics emiting an event when previously they did not, no other behavior in pallets/extrinsics was modified, so no integration is needed. ## Review Notes N/A
-
Michal Kucharczyk authored
This PR changes the behavior of `json_patch::merge` function which no longer removes any keys from the base JSON object. fixes: #6306 --------- Co-authored-by:
GitHub Action <action@github.com>
-
Egor_P authored
This PR has small addition to the db package version. As `cargodeb` takes the version from the `*.toml` file, this PR adds an extra flag to the `cargodeb` command so that the version of the deb package matches the `polkadot` node version.
-
Andrei Eres authored
Fixes https://github.com/paritytech/polkadot-sdk/issues/5530 This PR introduces the removal of backing jobs that have been back pressured for longer than `allowedAncestryLen`, as these candidates are no longer viable. It is reasonable to expect a result for a backing job execution within `allowedAncestryLen` blocks. Therefore, we set the job TTL as a relay block number and synchronize the validation host by sending activated leaves. --------- Co-authored-by:
Andrei Sandu <54316454+sandreim@users.noreply.github.com> Co-authored-by:
Branislav Kontur <bkontur@gmail.com>
-
Alexandru Vasile authored
This PR ensures that external addresses with different PeerIDs are not propagated to the higher layer of the network code. While at it, this ensures that libp2p only adds the `/p2p/peerid` part to the discovered address if it does not contain it already. This is a followup from: - https://github.com/paritytech/polkadot-sdk/pull/6298 cc @paritytech/networking --------- Signed-off-by:
Alexandru Vasile <alexandru.vasile@parity.io> Co-authored-by:
Dmitry Markin <dmitry@markin.tech>
-
Ankan authored
fixes https://github.com/paritytech/polkadot-sdk/issues/5966 --------- Co-authored-by:
Guillaume Thiolliere <gui.thiolliere@gmail.com>
-
Nazar Mokrynskyi authored
# Description This is a continuation of https://github.com/paritytech/polkadot-sdk/pull/5666 that finally fixes https://github.com/paritytech/polkadot-sdk/issues/5333. This should allow developers to create custom syncing strategies or even the whole syncing engine if they so desire. It also moved syncing engine creation and addition of corresponding protocol outside `build_network_advanced` method, which is something Bastian expressed as desired in https://github.com/paritytech/polkadot-sdk/issues/5#issuecomment-1700816458 Here I replaced strategy-specific types and methods in `SyncingStrategy` trait with generic ones. Specifically `SyncingAction` is now used by all strategies instead of strategy-specific types with conversions. `StrategyKey` was an enum with a fixed set of options and now replaced with an opaque type that strategies create privately and send to upper layers as an opaque type. Requests and responses are now handled in a generic way regardless of the strategy, which reduced and simplified strategy API. `PolkadotSyncingStrategy` now lives in its dedicated module (had to edit .gitignore for this) like other strategies. `build_network_advanced` takes generic `SyncingService` as an argument alongside with a few other low-level types (that can probably be extracted in the future as well) without any notion of specifics of the way syncing is actually done. All the protocol and tasks are created outside and not a part of the network anymore. It still adds a bunch of protocols like for light client and some others that should eventually be restructured making `build_network_advanced` just building generic network and not application-specific protocols handling. ## Integration Just like https://github.com/paritytech/polkadot-sdk/pull/5666 introduced `build_polkadot_syncing_strategy`, this PR introduces `build_default_block_downloader`, but for convenience and to avoid typical boilerplate a simpler high-level function `build_default_syncing_engine` is added that will take care of creating typical block downloader, syncing strategy and syncing engine, which is what most users will be using going forward. `build_network` towards the end of the PR was renamed to `build_network_advanced` and `build_network`'s API was reverted to pre-https://github.com/paritytech/polkadot-sdk/pull/5666, so most users will not see much of a difference during upgrade unless they opt-in to use new API. ## Review Notes For `StrategyKey` I was thinking about using something like private type and then storing `TypeId` inside instead of a static string in it, let me know if that would preferred. The biggest change happened to requests that different strategies make and how their responses are handled. The most annoying thing here is that block response decoding, in contrast to all other responses, is dependent on request. This meant request had to be sent throughout the system. While originally `Response` was `Vec<u8>`, I didn't want to re-encode/decode request and response just to fit into that API, so I ended up with `Box<dyn Any + Send>`. This allows responses to be truly generic and each strategy will know how to downcast it back to the concrete type when handling the response. Import queue refactoring was needed to move `SyncingEngine` construction out of `build_network` that awkwardly implemented for `SyncingService`, but due to `&mut self` wasn't usable on `Arc<SyncingService>` for no good reason. `Arc<SyncingService>` itself is of course useless, but refactoring to replace it with just `SyncingService` was unfortunately rejected in https://github.com/paritytech/polkadot-sdk/pull/5454 As usual I recommend to review this PR as a series of commits instead of as the final diff, it'll make more sense that way. # Checklist * [x] My PR includes a detailed description as outlined in the "Description" and its two subsections above. * [x] My PR follows the [labeling requirements]( https://github.com/paritytech/polkadot-sdk/blob/master/docs/contributor/CONTRIBUTING.md#Process ) of this project (at minimum one label for `T` required) * External contributors: ask maintainers to put the right label on your PR. * [x] I have made corresponding changes to the documentation (if applicable)
-
Alexandru Vasile authored
This PR fixes the `0002-validators-warp-sync` zombienet test by matching for a specific error case. The following PR introduced a new error for validators that don't have public addresses available for publishing in the DHT: - https://github.com/paritytech/polkadot-sdk/pull/6298 The log line was moved from `eprintln!("Warning: ...` in sc-cli to the authority discovery where it is printed properly as an error. cc @paritytech/sdk-node Signed-off-by:
Alexandru Vasile <alexandru.vasile@parity.io>
-
Alin Dima authored
https://github.com/paritytech/polkadot-sdk/issues/6343
-