Skip to content
  1. Oct 15, 2020
    • Jon Häggblad's avatar
      babe: make secondary slot randomness available on-chain (#7053) · a297e447
      Jon Häggblad authored
      
      
      * babe: make secondary slot randomness available on-chain
      
      * babe: extract out vrf_output function
      
      * babe: add missing comment
      
      * babe: fix incorrectly storing primary randomness
      
      * babe: add test for onchain author vrf
      
      * babe: fix reviewer nits
      
      * runtime: bump spec_version
      
      * babe: remove outer Option for AuthorVrfRandomness
      
      * babe: fix reviewer nits on doc strings
      
      * babe: move make_vrf_output to mock.rs
      
      * babe: cleanup docs
      
      * babe: kill ephemeral entry instead of take
      
      * babe: use type alias for maybe randomness
      
      Co-authored-by: default avatarAndré Silva <[email protected]>
      a297e447
  2. Oct 14, 2020
  3. Oct 12, 2020
  4. Oct 09, 2020
  5. Oct 08, 2020
    • Rakan Alhneiti's avatar
      Async keystore + Authority-Discovery async/await (#7000) · 3aa4bfac
      Rakan Alhneiti authored
      
      
      * Asyncify sign_with
      
      * Asyncify generate/get keys
      
      * Complete BareCryptoStore asyncification
      
      * Cleanup
      
      * Rebase
      
      * Add Proxy
      
      * Inject keystore proxy into extensions
      
      * Implement some methods
      
      * Await on send
      
      * Cleanup
      
      * Send result over the oneshot channel sender
      
      * Process one future at a time
      
      * Fix cargo stuff
      
      * Asyncify sr25519_vrf_sign
      
      * Cherry-pick and fix changes
      
      * Introduce SyncCryptoStore
      
      * SQUASH ME WITH THE first commit
      
      * Implement into SyncCryptoStore
      
      * Implement BareCryptoStore for KeystoreProxyAdapter
      
      * authority-discovery
      
      * AURA
      
      * BABE
      
      * finality-grandpa
      
      * offchain-workers
      
      * benchmarking-cli
      
      * sp_io
      
      * test-utils
      
      * application-crypto
      
      * Extensions and RPC
      
      * Client Service
      
      * bin
      
      * Update cargo.lock
      
      * Implement BareCryptoStore on proxy directly
      
      * Simplify proxy setup
      
      * Fix authority-discover
      
      * Pass async keystore to authority-discovery
      
      * Fix tests
      
      * Use async keystore in authority-discovery
      
      * Rename BareCryptoStore to CryptoStore
      
      * WIP
      
      * Remote mutable borrow in CryptoStore trait
      
      * Implement Keystore with backends
      
      * Remove Proxy implementation
      
      * Fix service builder and keystore user-crates
      
      * Fix tests
      
      * Rework authority-discovery after refactoring
      
      * futures::select!
      
      * Fix multiple mut borrows in authority-discovery
      
      * Merge fixes
      
      * Require sync
      
      * Restore Cargo.lock
      
      * PR feedback - round 1
      
      * Remove Keystore and use LocalKeystore directly
      
      Also renamed KeystoreParams to KeystoreContainer
      
      * Join
      
      * Remove sync requirement
      
      * Fix keystore tests
      
      * Fix tests
      
      * client/authority-discovery: Remove event stream dynamic dispatching
      
      With authority-discovery moving from a poll based future to an `async`
      future Rust has difficulties propagating the `Sync` trade through the
      generated state machine.
      
      Instead of using dynamic dispatching, use a trait parameter to specify
      the DHT event stream.
      
      * Make it compile
      
      * Fix submit_transaction
      
      * Fix block_on issue
      
      * Use await in async context
      
      * Fix manual seal keystore
      
      * Fix authoring_blocks test
      
      * fix aura authoring_blocks
      
      * Try to fix tests for auth-discovery
      
      * client/authority-discovery: Fix lookup_throttling test
      
      * client/authority-discovery: Fix triggers_dht_get_query test
      
      * Fix epoch_authorship_works
      
      * client/authority-discovery: Remove timing assumption in unit test
      
      * client/authority-discovery: Revert changes to termination test
      
      * PR feedback
      
      * Remove deadcode and mark test code
      
      * Fix test_sync
      
      * Use the correct keyring type
      
      * Return when from_service stream is closed
      
      * Convert SyncCryptoStore to a trait
      
      * Fix line width
      
      * Fix line width - take 2
      
      * Remove unused import
      
      * Fix keystore instantiation
      
      * PR feedback
      
      * Remove KeystoreContainer
      
      * Revert "Remove KeystoreContainer"
      
      This reverts commit ea4a37c7d74f9772b93d974e05e4498af6192730.
      
      * Take a ref of keystore
      
      * Move keystore to dev-dependencies
      
      * Address some PR feedback
      
      * Missed one
      
      * Pass keystore reference - take 2
      
      * client/finality-grandpa: Use `Arc<dyn CryptoStore>` instead of SyncXXX
      
      Instead of using `SyncCryptoStorePtr` within `client/finality-grandpa`,
      which is a type alias for `Arc<dyn SyncCryptoStore>`, use `Arc<dyn
      CryptoStore>`. Benefits are:
      
      1. No additional mental overhead of a `SyncCryptoStorePtr`.
      
      2. Ability for new code to use the asynchronous methods of `CryptoStore`
      instead of the synchronous `SyncCryptoStore` methods within
      `client/finality-granpa` without the need for larger refactorings.
      
      Note: This commit uses `Arc<dyn CryptoStore>` instead of
      `CryptoStorePtr`, as I find the type signature more descriptive. This is
      subjective and in no way required.
      
      * Remove SyncCryptoStorePtr
      
      * Remove KeystoreContainer & SyncCryptoStorePtr
      
      * PR feedback
      
      * *: Use CryptoStorePtr whereever possible
      
      * *: Define SyncCryptoStore as a pure extension trait of CryptoStore
      
      * Follow up to SyncCryptoStore extension trait
      
      * Adjust docs for SyncCryptoStore as Ben suggested
      
      * Cleanup unnecessary requirements
      
      * sp-keystore
      
      * Use async_std::task::block_on in keystore
      
      * Fix block_on std requirement
      
      * Update primitives/keystore/src/lib.rs
      
      Co-authored-by: default avatarMax Inden <[email protected]>
      
      * Fix wasm build
      
      * Remove unused var
      
      * Fix wasm compilation - take 2
      
      * Revert async-std in keystore
      
      * Fix indent
      
      * Fix version and copyright
      
      * Cleanup feature = "std"
      
      * Auth Discovery: Ignore if from_service is cloed
      
      * Max's suggestion
      
      * Revert async-std usage for block_on
      
      * Address PR feedback
      
      * Fix example offchain worker build
      
      * Address PR feedback
      
      * Update Cargo.lock
      
      * Move unused methods to test helper functions
      
      * Restore accidentally deleted cargo.lock files
      
      * Fix unused imports
      
      Co-authored-by: default avatarMax Inden <[email protected]>
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      3aa4bfac
    • Alexander Theißen's avatar
      seal: Add automated weights for contract API calls (#7017) · 443725f0
      Alexander Theißen authored
      
      
      * seal: Add capability to put uninstrumented code (for benchmarks)
      
      Benchmarks should only measure the overhead of the API calls itself.
      For that reason we want to run them without instrumentation.
      
      * seal: Cap the the data length for deposited events
      
      Data used in events has storage implications for archive nodes.
      Those need to keep the events in storage forever. For that reason
      we want to limit the amount of storage that can be used inside events.
      
      * seal: Fix error reporting in the case out of bound sandbox access
      
      * seal: Refactor existing benchmarks
      
      * seal: Convert benchmark file to tabs
      
      * seal: Add benchmarks for functions called by contracts
      
      * seal: Create a default schedule from benchmark generated WeightInfo
      
      * seal: Make use of WeightInfo in extrinsic weight annotations
      
      * seal: Replace the old schedule by the benchmark generated one
      
      * Review: Fix copy paste typo in schedule construction
      
      * Review: Fix stale docs
      
      * Fix whitespace errors
      
      Co-authored-by: default avatarSergei Shulepov <[email protected]>
      
      * Review: Use checked_div in order to be more defensive
      
      * Review: Rename no_charge to already_charged
      
      * Review: Whitelist caller of extrinsics
      
      * Review: Remove trailing whitespace
      
      * Review: Remove confusing "self::" syntax
      
      * Review: Add docs for the benchmark prepration submodule
      
      * Review: Move code generation functions to own module
      
      * Review: Refactor and document benchmark helper functions
      
      * Remove additional empty line
      
      * Added missing comment on caller_funding
      
      * Update frame/contracts/src/benchmarking/code.rs
      
      Co-authored-by: default avatarSergei Shulepov <[email protected]>
      
      * Fix missing sp_std::prelude import in code.rs
      
      * cargo run --release --features runtime-benchmarks --manifest-path bin/node/cli/Cargo.toml -- benchmark --chain dev --steps 50 --repeat 20 --extrinsic * --execution=wasm --wasm-execution=compiled --output ./bin/node/runtime/src/weights --header ./HEADER --pallet pallet_contracts --heap-pages 4096
      
      * Use weights from the benchmark machine for the substrate node
      
      * Remove prefixes from Schedule members
      
      * Data lengths in the WeightInfo Trait are specified in kilobytes
      
      * Rename ApiWeights to HostFunctionWeights
      
      Co-authored-by: default avatarSergei Shulepov <[email protected]>
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      443725f0
    • Kian Paimani's avatar
      Refactor CurrencyToVote (#6896) · ba229c62
      Kian Paimani authored
      
      
      * Refactor CurrencyToVote to avoid calls to total_issuance.
      
      * Update frame/support/src/traits.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Some grumbles
      
      * Fix last grumbles.
      
      * Fix comment
      
      * Final fix
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      ba229c62
  6. Oct 07, 2020
  7. Oct 06, 2020
    • Bastian Köcher's avatar
      Rework `InspectState` (#7271) · 89e06d26
      Bastian Köcher authored
      Reworks `InspectState` in two ways:
      - Renames `inspect_with` to `inspect_state` to reflect the trait name.
      - Make `inspect_state` return the result of the closure
      89e06d26
  8. Oct 02, 2020
  9. Oct 01, 2020
  10. Sep 30, 2020
  11. Sep 28, 2020
  12. Sep 24, 2020
  13. Sep 23, 2020
  14. Sep 22, 2020
  15. Sep 21, 2020
  16. Sep 18, 2020
    • Jon Häggblad's avatar
      grandpa-rpc: use FinalityProofProvider to check finality for rpc (#6215) · 8a0ac4c4
      Jon Häggblad authored
      * grandpa-rpc: use FinalityProofProvider to check finality for rpc
      
      * grandpa-rpc: minor tidy
      
      * grandpa-rpc: remove dyn FinalityProofProvider
      
      * grandpa-rpc: remove unused dependencies
      
      * node: move finality_proof_provider setup
      
      * grandpa-rpc: print error reported by finality_proof_provider
      
      * grandpa-rpc: add note about unnecessary encode/decode
      
      * grandpa-rpc: dont encode/decode and use correct hash
      
      * grandpa-rpc: set_id is optional
      
      * grandpa-rpc: create test for prove_finality
      
      * grandpa-rpc: set visibility back to how it was
      
      * grandpa-rpc: remove unused dependency
      
      * grandpa-rpc: minor tidy
      
      * grandpa: doc strings
      
      * grandpa-rpc: rename to prove_finality
      
      * grandpa-rpc: use current set id if none is provided
      
      * grandpa-rpc: remove unnecessary check in test
      
      * node: group finality_proof_provider in rpc_setup
      
      * grandpa: make prove_finality concrete in FinalityProofProvider
      
      * grandpa-rpc: wrap finality output in struct and store as Bytes
      
      * grandpa-rpc: exhaustive error codes and wrap
      
      * grandpa-rpc: let prove_finality take a range instead of a starting point
      
      * grandpa-rpc: fix test for changed API
      
      * grandpa-rpc: fix line length
      
      * grandpa: fix reviewer nits
      
      * node/rpc: fix reviewer comments
      8a0ac4c4
    • Shawn Tabrizi's avatar
      WeightInfo for Scheduler (#7138) · 743cf754
      Shawn Tabrizi authored
      * initial scheduler stuff
      
      * integrate weightinfo
      
      * Update pallet_scheduler.rs
      743cf754
    • Xiliang Chen's avatar
      Bounties (#5715) · 67e1dad9
      Xiliang Chen authored
      
      
      * add some compact annotation
      
      * implement bounties for treasury
      
      * fix test build
      
      * remove some duplicated code
      
      * fix build
      
      * add tests
      
      * fix build
      
      * fix tests
      
      * rename
      
      * merge deposit byte fee
      
      * add comments
      
      * refactor storage
      
      * support sub bounty
      
      * emit BountyBecameActive when sub bounty is created
      
      * able to contribute bounty
      
      * allow curator to cancel bounty
      
      * remove bounty contribution
      
      * implement bounty expiry
      
      * Able to extend bounty
      
      * fix build and update tests
      
      * create sub bounty test
      
      * add more tests
      
      * add benchmarks for bounties
      
      * fix build
      
      * line width
      
      * fix benchmarking test
      
      * update trait
      
      * fix typo
      
      * Update lib.rs
      
      Missing documentation on Bounties added on this change. Please check the definitions of `propose_bounty` and `create_bounty`.
      
      * update docs
      
      * add MaximumSubBountyDepth
      
      * put BountyValueMinimum into storage
      
      * rework bount depth
      
      * split on_initialize benchmarks
      
      * remove components from constant functions
      
      * Update weight integration into treasury
      
      * Update reject proposal read/writes
      
      * fix weight calculation
      
      * Ignore weights with 0 factor
      
      * Remove 0 multipliers
      
      * add some docs
      
      * allow unused for generated code
      
      * line width
      
      * allow RejectOrigin to cancel a pending payout bounty
      
      * require BountyValueMinimum > ED
      
      * make BountyValueMinimum configurable by chain spec
      
      * remove sub-bounty features
      
      * update curator
      
      * accept curator
      
      * unassign and cancel
      
      * fix tests
      
      * new tests
      
      * Update lib.rs
      
      - Include on `Assign_curator`, `accept_curator` and `unassign_curator` on Bounties Protocol Section 
      - Include curator fee and curator deposit definitions on Terminology
      - Update intro.
      
      * fix test
      
      * update extend_bounty_expiry
      
      * fix benchmarking
      
      * add new benchmarking code
      
      * add docs
      
      * fix tests
      
      * Update benchmarking.rs
      
      * Make BountyValueMinimum a trait config instead of stroage value
      
      * fix runtime build
      
      * Update weights
      
      * Update default_weights.rs
      
      * update weights
      
      * update
      
      * update comments
      
      * unreserve curator fee
      
      * update tests
      
      * update benchmarks
      
      * fix curator deposit handling
      
      * trigger CI
      
      * fix benchmarking
      
      * use append instead of mutate push
      
      * additional noop tests
      
      * improve fee hanlding. update event docs
      
      * RejectOrigin to unassign
      
      * update bounty cancel logic
      
      * use Zero::zero() over 0.into()
      
      * fix tests
      
      * fix benchmarks
      
      * proposed fixes to bounties
      
      * fix tests
      
      * fix benchmarks
      
      * update weightinfo
      
      * use closure
      
      * fix compile
      
      * update weights
      
      Co-authored-by: default avatarRRTTI <[email protected]>
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      67e1dad9
    • Shawn Tabrizi's avatar
      Pallet Indices (#7137) · a3080f27
      Shawn Tabrizi authored
      a3080f27
    • Benjamin Kampmann's avatar
      Tracing for wasm with bridging to native (#6916) · a9c73113
      Benjamin Kampmann authored
      
      
      * implement events handling, implement parent_id for spans & events
      
      * add events to sp_io::storage
      
      * update test
      
      * add tests
      
      * adjust limit
      
      * let tracing crate handle parent_ids
      
      * re-enable current-id tracking
      
      * add test for threads with CurrentSpan
      
      * fix log level
      
      * remove redundant check for non wasm traces
      
      * remove duplicate definition in test
      
      * Adding conditional events API
      
      * prefer explicit parent_id over current,
      
      enhance test
      
      * limit changes to client::tracing event implementation
      
      * remove From impl due to fallback required on parent_id
      
      * make tracing codecable
      
      * replace with global tracing
      
      * new tracing interface
      
      * impl TracingSubscriber in client
      
      * implement access to global TracingSubscriber from primitives
      
      * span for wasm
      
      * increment towards Wasm Tracing Subscriber implementation
      
      * increment, remove sp-tracing from runtime-interface
      
      * increment, it compiles
      
      * attained original functionality with new mechanism
      
      * implement remaining TracingSubscriber functions
      
      * remove spans from decl_module
      
      * add handling for encoded values
      
      * Revert "replace with global tracing"
      
      This reverts commit 8824a60deea54d9b437407a21c8ceaf6a1902ee5.
      
      * Wasm Side Tracing
      
      * tracing on wasm
      
      * enable tracing wasm on node-runtime
      
      * export all the macros in std
      
      * tracing subscriber on wasm-side only
      
      * pass spans and events over and record them
      
      * reactivate previous code and  cleanup
      
      * further cleaning up
      
      * extend the span macros, activate through executive
      
      * tracking the actual extrinsic, too
      
      * style
      
      * fixing tests
      
      * spaces -> tabs
      
      * attempting to reactivate params
      
      * activate our tests in CI
      
      * some passing
      
      * tests passing
      
      * with core lazy
      
      * global tracer for wasm side with pass over
      
      * fixing metadata referencing
      
      * remove const_fn feature requirement
      
      * reenable dispatch traces
      
      * reset client tracing
      
      * further cleaning up
      
      * fixing runtime-test
      
      * move tracing-build setup into runtime-test
      
      * Merge DebugWriter from tracing and frame-support, move to sp-std
      
      * remove dangling fixme
      
      * Docs for tracing primitives
      
      * cleaning up a bit more
      
      * Wasm interface docs
      
      * optimise docs.rs setup
      
      * adding tracing flags to uncomment
      
      * remove brace
      
      * fixing imports
      
      * fixing broken syntax
      
      * add required modules
      
      * nicer formatting
      
      * better target management
      
      * adding low level storage tracing events into frame
      
      * add custom Debug impl for WasmMetadata
      
      * cloning profiler
      
      * adding info about cloning profiler
      
      * using in-scope for within calls
      
      * proper time tracing, cleaning up println
      
      * allow to disable tracing on runtime_interface-macro
      
      * disable tracing for wasm-tracing-interface
      
      * simplify wasm-tracing-api
      
      * update client to new interface
      
      * fixing docs and tests for sp-tracing
      
      * update integration tests
      
      * re-activating enter_span
      
      * dropping FIXME, it's documented
      
      * fix formatting
      
      * fix formatting
      
      * fix imports
      
      * more debug info
      
      * inform wasm about it being disabled by returning 1
      
      * only one tracer, but enabled multi-all support
      
      * make trait pub again for tests
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarNiklas Adolfsson <[email protected]>
      
      * fixing wasm doc tests for proper usage
      
      * remove unnecessary import
      
      * fixing formatting
      
      * minor style fixes
      
      * downgrading wabt
      
      * update error message for UI
      
      * Fix interface test
      
      * next attempt to fix macros
      
      * geee
      
      * revert tracing on hashed for future PR
      
      * remove local macros, use originals
      
      * we are able to convert to static items
      
      * implement more WasmValue types
      
      * adding support to convert str, debug and encoded values
      
      * more minor fixes
      
      * revert unsafe 'static making
      
      * fix indentation
      
      * remove commented lines
      
      * bump all them tracing versions
      
      * cleaning up docs and info
      
      * document new flag
      
      * the new layered system handles span cloning better
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarDavid <[email protected]>
      
      Co-authored-by: default avatarMatt Rutherford <[email protected]>
      Co-authored-by: default avatarNiklas Adolfsson <[email protected]>
      Co-authored-by: default avatarDavid <[email protected]>
      a9c73113
  17. Sep 17, 2020
    • Shawn Tabrizi's avatar
      WeightInfo for Identity Pallet (#7107) · f089cb42
      Shawn Tabrizi authored
      * update benchmarks
      
      * add automated weights
      
      * Update benchmarking.rs
      
      * use underscores for file out
      
      * update some weights
      
      * more weights
      
      * finish weights
      
      * add basic verification to benchmarks
      
      * patch benchmarks
      
      * Update benchmarking.rs
      
      * final weights
      
      * update for new type
      
      * add weightinfo to node
      f089cb42
    • Kian Paimani's avatar
      14df4749
    • Shawn Tabrizi's avatar
      WeightInfo for ImOnline (#7128) · 1ba05216
      Shawn Tabrizi authored
      * Add WeightInfo, not final weights
      
      * benchmark machine weights
      1ba05216
    • Wei Tang's avatar
      Use tracing-based subscriber logging (#6825) · 9fdd4672
      Wei Tang authored
      
      
      * init_logger: switch from log-based to tracing-based and add compatibility layer
      
      * Move tracing profiling subscriber related config realization
      
      * sp-tracing: change profiling to be a layer instead of a subscriber
      
      * Enable profiling layer in cli
      
      * Change all test env_logger init to sp_tracing::try_init_simple
      
      * Remove all local env_logger dependency
      
      * Add missing tracing-subscriber dependency
      
      * frame-sudo: fix tests
      
      * frame-support: fix tests
      
      * Fix frame/pallet and executor tests
      
      * Fix the remaining tests
      
      * Use subscriber's try_init as recommended by @davidbarsky
      
      * Be explict that the tracing-log feature is needed
      
      * Set subscriber writer to stderr
      
      * Shorter line width
      
      * Update cargo lock tracing version
      
      * Fix sc_tracing crate compile
      
      * Fix sc_authority_discovery crate test
      
      * unremove default-features
      
      * Leave enabled to default true
      
      * Warn if global default cannot be set
      
      * Fix unused import
      
      * Remove unused PROXY_TARGET
      
      * Change all reference from rc5 to rc6
      
      * Change all reference of rc2 to rc6
      
      * Fix styling
      
      * Fix typo
      
      * make logger init error'ing
      
      * re-fixing the test issue
      
      Co-authored-by: default avatarBenjamin Kampmann <[email protected]>
      9fdd4672
    • Shawn Tabrizi's avatar
      ab97e949
  18. Sep 16, 2020
    • Shawn Tabrizi's avatar
      WeightInfo for Vesting Pallet (#7103) · 9aa8698c
      Shawn Tabrizi authored
      * WeightInfo for Vesting Pallet
      
      * clean up weight docs
      
      * Update lib.rs
      
      * try to pipe max locks
      
      * Update for new type
      
      * add warning when locks > MaxLocks
      
      * Update lib.rs
      
      * fix compile
      
      * remove aliasing, fix trait def
      
      * Update
      9aa8698c
  19. Sep 14, 2020
  20. Sep 11, 2020