Skip to content
  1. Jun 13, 2022
  2. Jun 07, 2022
  3. Jun 06, 2022
  4. Jun 01, 2022
    • Gavin Wood's avatar
      Helper macro for `Morph` impls (#11570) · 838dbcbe
      Gavin Wood authored
      * Helper macro for Morph impls
      
      * No need to deprecate for now
      
      * Improved macro
      
      * Doc tests
      
      * Grumbles
      838dbcbe
    • Gavin Wood's avatar
      d6ea0e42
    • Gavin Wood's avatar
      Ranked Collective pallet (#11548) · 5595f102
      Gavin Wood authored
      * Ranked Collective pallet
      
      * Fixes
      
      * benchmarks
      
      * Weights
      
      * Allow class voting in rank
      Use bare ayes for calculating support.
      Allow only promotion/demotion by one rank only.
      Allow removal of member with rank zero only.
      Use new Tally API
      
      * Index by rank, still O(1).
      
      * Custom vote weights
      
      * Formatting
      
      * Update frame/ranked-collective/src/lib.rs
      
      * Broken :(
      
      * origin guard; cleanup uses new API
      
      * Formatting
      
      * Promote/demote by rank
      
      * Formatting
      
      * Use new API
      
      * Remove code in another PR
      
      * Remove code in another PR
      
      * Formatting
      
      * Remove code in another PR
      
      * Docs
      
      * Docs
      
      * Bump
      
      * Fixes
      
      * Formatting
      
      * Fixes
      5595f102
  5. May 31, 2022
  6. May 29, 2022
    • Gavin Wood's avatar
      Safe and sane multi-item storage removal (#11490) · ecbd65fb
      Gavin Wood authored
      * Fix overlay prefix removal result
      
      * Second part of the overlay prefix removal fix.
      
      * Report only items deleted from storage in clear_prefix
      
      * Fix kill_prefix
      
      * Formatting
      
      * Remove unused code
      
      * Fixes
      
      * Fixes
      
      * Introduce clear_prefix host function v3
      
      * Formatting
      
      * Use v2 for now
      
      * Fixes
      
      * Formatting
      
      * Docs
      
      * Child prefix removal should also hide v3 for now
      
      * Fixes
      
      * Fixes
      
      * Formatting
      
      * Fixes
      
      * apply_to_keys_whle takes start_at
      
      * apply_to_keys_whle takes start_at
      
      * apply_to_keys_whle takes start_at
      
      * Cursor API; force limits
      
      * Use unsafe deprecated functions
      
      * Formatting
      
      * Fixes
      
      * Grumbles
      
      * Fixes
      
      * Docs
      
      * Some nitpicks 🙈
      
      
      
      * Update primitives/externalities/src/lib.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Formatting
      
      * Fixes
      
      * cargo fmt
      
      * Fixes
      
      * Update primitives/io/src/lib.rs
      
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      
      * Formatting
      
      * Fixes
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      ecbd65fb
  7. May 26, 2022
    • Shawn Tabrizi's avatar
      Storage Layer for All FRAME Extrinsics (#11431) · 8e7adaf2
      Shawn Tabrizi authored
      
      
      * add new trait
      
      * implement DispatchableWithStorageLayer
      
      * at least one transactional
      
      * all dispatch is at least transactional
      
      * storage_layer api
      
      * add test
      
      * storage layer tests
      
      * deprecate transactional tag
      
      * i guess no reason to deprecate
      
      * remove transactional from batch_all
      
      * update tests
      
      * extend trait
      
      * cargo run --quiet --profile=production --features runtime-benchmarks --manifest-path bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --profile=production --features runtime-benchmarks --manifest-path bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --profile=production --features runtime-benchmarks --manifest-path bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * fix copy paste name
      
      * cargo run --quiet --profile=production --features runtime-benchmarks --manifest-path bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_utility --extrinsic=* --execution=wasm --wasm-execution=compiled --output=./frame/utility/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Create run_all_benchmarks.sh
      
      * uncomment build
      
      * update number of steps and repeats
      
      * add skip build
      
      * Update run_all_benchmarks.sh
      
      * Update run_all_benchmarks.sh
      
      * new benchmarks
      
      * Update frame/support/src/traits/dispatch.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/support/src/traits/dispatch.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/support/test/tests/storage_layers.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/support/test/tests/storage_layers.rs
      
      * weights
      
      * Update dispatch.rs
      
      * doc link
      
      * decl_macro support
      
      Co-authored-by: default avatarParity Bot <[email protected]>
      Co-authored-by: default avatarKian Paimani <[email protected]>
      8e7adaf2
  8. May 25, 2022
  9. May 24, 2022
  10. May 23, 2022
  11. May 17, 2022
  12. May 16, 2022
    • Jegor Sidorenko's avatar
      Use 'Items' and 'Collections' in uniques pallet (#11389) · ed7d1e7a
      Jegor Sidorenko authored
      
      
      * Rename class to collection
      
      * Use "assets collection" instead of "asset collection"
      
      * Rename 'instance' to 'asset'
      
      * Change "asset `collection`" to "`collection`"
      
      * A bit more clean up
      
      * Rename Asset to Item
      
      * Add a storage hack
      
      * Typos
      
      * fix compile
      
      * fmt
      
      * Fix
      
      * cargo run --quiet --profile=production  --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_uniques --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/uniques/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Update frame/uniques/src/lib.rs
      
      * cargo run --quiet --profile=production  --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_uniques --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/uniques/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Change 'items collection' to 'collection'
      
      * Apply suggestions
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarParity Bot <[email protected]>
      ed7d1e7a
    • Dmitriy Shabanov's avatar
      serde::{Serialize, Deserialize} for BoundedVec (#11314) · 9d6a4c4d
      Dmitriy Shabanov authored
      * serde::{Serialize, Deserialize} for BoundedVec
      
      * Apply suggestions from code review
      
      * FMT
      
      * 🤦
      
      
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      9d6a4c4d
  13. May 12, 2022
  14. May 06, 2022
  15. May 02, 2022
  16. Apr 30, 2022
  17. Apr 28, 2022
    • Joshua W's avatar
      Dependency Injection Trait Locker for Uniques Pallet (#11025) · 21341f35
      Joshua W authored
      
      
      * Create a dependency injection trait named Locker that can be implemented downstream to enable locking of an asset. Use case defined in RMRK substrate pallet PR76
      
      * Formatting
      
      * Change impl Locker function name to is_locked
      
      * Remove unused import
      
      * Add docstring header
      
      * Remove impl_locker file and add Locker trait to frame_support::traits
      
      * Expose Locker from frame_support::traits::misc
      
      * Formatting
      
      * Move to tokens folder
      
      * Move to tokens folder
      
      * Format and remove Locker from misc traits
      
      * Punctuation
      
      * Update frame/support/src/traits/tokens/misc.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarGiles Cope <[email protected]>
      21341f35
  18. Apr 27, 2022
    • Zeke Mostov's avatar
      Nomination Pools (#10694) · 247f33dc
      Zeke Mostov authored
      
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Add admin roles and make some calls permissionless
      
      * Destroy pool in withdraw unbonded
      
      * Add docs on pool admin
      
      * Fixup tests
      
      * Test unbond_other permissionless scenarios
      
      * Test withdraw unbonded permissionless
      
      * Test only can join open pools
      
      * Move unsafe set state to mock
      
      * Test: nominate_works
      
      * Add bounds: MinJoinBond, MinCreateBond, MaxPools
      
      * Test MinCreateBond, MinJoinBond, MaxPools
      
      * Add post checks to tests
      
      * Remove some TODOs
      
      * Setup weight infrastructure
      
      * Benchmark claim_payout
      
      * Benchmark create
      
      * Benchmark nominate
      
      * Benchmark join
      
      * Benchmark unbond_other
      
      * Refactor join benchmark to use scenario setup
      
      * Clean up and address warnings
      
      * Basic withdraw unbonded benchmarks
      
      * Refactor nominate benchmark
      
      * Refactor claim payout
      
      * Add feature sp-staking/runtime-benchmarks
      
      * Get node runtime to compile
      
      * Get node to run
      
      * Make claim_payout bench work with node
      
      * Make pool_withdraw_unbonded bench work with node
      
      * Make withdraw_unbonded_other work with node runtime'
      
      * Make create benchmark work with node
      
      * Make nominate benchmark work with node runtime
      
      * WiP new benchmark crate
      
      * Implement initial mock for benchmarks
      
      * Establish benchmark setup logic
      
      * Get claim payout and nominate benchmarks working
      
      * Remove pool bench utils; make struct fields pub insteaad
      
      * Get more benchmarks to work; trim interface trait
      
      * Some more top level docs
      
      * Finish tranistion benchmarks to crate
      
      * Hook up benchmark pallet to node runtime
      
      * Get benches to work with node runtime
      
      * cargo run --quiet --profile=production  --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_nomination_pools --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/nomination-pools/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Benchmark withdraw_unbonded_other_kill
      
      * Delete old benchmarking files
      
      * Refunds for withdraw_unbonded
      
      * Remove some TODOs
      
      * 'Don't return an option for the current_era'
      
      * Streamline extrinsic docs
      
      * small docs tweaks
      
      * Refactor ledger::slash
      
      * Add on_slash impl for nomination pools
      
      * slash refactor wip
      
      * WIP slash working
      
      * DRY Ledger::stash
      
      * Fix slash saturation
      
      * Remove unused param from slash
      
      * Docs and warnings
      
      * Test ledger::slash
      
      * save progress
      
      * Introduce counter for delegators
      
      * Add tests for max delegator errors
      
      * Reproducible account ids
      
      * Adapt tests to new account id format
      
      * Simplify create_accounts api
      
      * Fix staking tests
      
      * Save PerBill slash impl before removing
      
      * Rever ledger slash test
      
      * Get node runtime to work
      
      * Organize sub pools by unbond era, not curren era
      
      * staking: Proportional ledger slashing
      
      * Some comment cleanup
      
      * Add more test post checks
      
      * Update frame/staking/src/pallet/mod.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Tests: account for storing unbond era
      
      * Improve docs for staking interface
      
      * Add events Created, Destroyed
      
      * withdraw_unbonded: Remove useless withdraw dust check
      
      * Test: withdraw_unbonded_other_handles_faulty_sub_pool_accounting
      
      * Add extrinsics: set_state_other, set_metadata
      
      * Test: set_state_other_works
      
      * Test: set_metadata_works
      
      * Add benchmarks for set_state_other, set_metadata
      
      * Fix benchmarks
      
      * Add weight info for new extrinsics
      
      * Some feedback
      
      * duo feedback
      
      * Incorporate some more feedback
      
      * integrate more kian feedback
      
      * integrate more kian feedback
      
      * More improvements
      
      * Add destroying_mul
      
      * Make do_reward_payout take refs
      
      * Remove some TODOs
      
      * Add test for saturating
      
      * feedback
      
      * Fix join test
      
      * use `inner` for nested types in nomination pools (#11030)
      
      * Use nested inner type for pool
      
      * make tests and benchmarks work
      
      * remove feat
      
      * all tests work now
      
      * fix node-runtime
      
      * nomination-pools: update benches for new account format (#11033)
      
      * Update benches to new account format
      
      * More sensible seeds
      
      * bring back rward account sanity check
      
      * Comment
      
      * Add extrinsic set_configs (#11038)
      
      * Better sanity checks for nomination pools  (#11042)
      
      * new sanity checks, few other changes
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * nomination-pools: Fix state event regression + benches (#11045)
      
      * new sanity checks, few other changes
      
      * Fix benches, improve sanity check
      
      * Remove useless clear storage in benchmarking
      
      * Set state
      
      * Save
      
      * Doc
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarkianenigma <[email protected]>
      
      * FMT
      
      * Try fill in all staking configs
      
      * Fix build
      
      * More changes to nomination pools (#11050)
      
      * new sanity checks, few other changes
      
      * some last touches as a whole
      
      * Apply suggestions from code review
      
      * Remove redundant event
      
      * Improve unbond_other error handling
      
      * Remove comment
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      Co-authored-by: default avataremostov <[email protected]>
      
      * Remove sanity module and some TODOs
      
      * round of feedback and imp from kian
      
      * Add TODO for ED QoL at reward pool creation
      
      * Make sure reward pool never gets dusted
      
      * Improve error type
      
      * demonstrate per_thing usage
      
      * Update sanity check & fix create_works
      
      * Improve test ext pool creation & fix some more tests
      
      * Try revert
      
      * Revert "Try revert"
      
      This reverts commit c044c94730e1a370eecd8f5b2c4f632835913063.
      
      * Revert "Improve test ext pool creation & fix some more tests"
      
      This reverts commit 1e862a64a7423479260c6e5ad1bd4c8c95651f3a.
      
      * Revert "Update sanity check & fix create_works"
      
      This reverts commit 568a7b727687e4d585e2796afc638df97b83c632.
      
      Roll back reward account funding
      
      * Revert "Improve error type"
      
      This reverts commit 4b993ee601a037e7a44e4a49bbfd60cf45b38b78.
      
      * Revert "Make sure reward pool never gets dusted"
      
      This reverts commit e7a3eb45bdfd156d3f6d94d194e988032ebbc593.
      
      revert
      
      * Update some tests
      
      * FMT
      
      * Test that era offset works correctly
      
      * Update mocks
      
      * Remove unnescary docs
      
      * Doc updates
      
      * Update calculate_delegator_payout_works_with_a_pool_of_1
      
      * Fix test: claim_payout_works
      
      * do_reward_payout_correctly_sets_pool_state_to_destroying
      
      * Remove test do_reward_payout_errors_correctly
      
      * Fix test: do_reward_payout_works
      
      * Fix test: create_errors_correctly
      
      * Fix test: create works
      
      * Fix test: unbond_other_of_3_works
      
      * Ensure that ED is transferred into reward pool upon creation
      
      * WIP pool lifecycle test
      
      * Fix benchmarks
      
      * Add sanity check for ED + reward pools
      
      * `bond_extra` for nomination pools (#11100)
      
      * bond_extra for nomination pools
      
      * Update frame/nomination-pools/src/lib.rs
      
      * Update frame/nomination-pools/src/lib.rs
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * add benchmarks
      
      * remove the min logic of bond_extra
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * FMT
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * make it compile end to end
      
      * Update some type viz
      
      * Update kick terminology
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      * Cache bonded account when creating pool
      
      * Add bond extra weight stuff
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update docs for pool withdraw unbonded
      
      * Update docs for unbond
      
      * Improve Doc
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Update frame/nomination-pools/Cargo.toml
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Improve Docs
      
      * Some docs improvements
      
      * fmt
      
      * Remove unlock_era
      
      * Fix accidental frame-support regression
      
      * Fix issue with transactions in tests
      
      * Fix doc links
      
      * Make sure result in test is used
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Fix can toggle state
      
      * Account for new_funds in ok to be open
      
      * Update docs: ok_to_withdraw_unbonded_other_with
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Remove some staking comments
      
      * Rename SubPoolsWithEra to UnbondingPoolsWithEra
      
      * Use validators length for benchmarks
      
      * Use metadata length for benchmarks
      
      * Remove debug assert eq
      
      * docs
      
      * Fix test: withdraw_unbonded_other_errors_correctly
      
      * Fix check for having enough balance to create the pool
      
      * Bond event for pool creation
      
      * Ok to be open
      
      * FMT
      
      * Remove _other postfix
      
      * Update frame/staking/src/lib.rs
      
      * Adjust tests to account for only remove when < ED
      
      * Remove stale TODOs
      
      * Remove dupe test
      
      * Fix build
      
      * Make sure to convert to u256 so we don't saturate
      
      * Refund depositor with reward pool fee
      
      * FMT
      
      * Remove reachable defensive
      
      * Use compact encoding for relevant extrinsics
      
      * Remove unnescary make_free_be for cleaning reward account
      
      * Add not to maintainers for reward account accounting
      
      * Remove note to maintainers from public doc
      
      * Make sure all configs have currency balance
      
      * Avoid saturation in balance_to_unbond
      
      * Partial Unbonding for Nomination Pools (#11212)
      
      * first draft of partial unbonding for pools
      
      * remove option
      
      * Add some more tests and fix issues
      
      * Fix all tests
      
      * simplify some tests
      
      * Update frame/nomination-pools/src/mock.rs
      
      * remove clone
      
      * rename to delegator_unbonding_eras
      
      * Update frame/nomination-pools/src/tests.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Update frame/nomination-pools/src/tests.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Update frame/nomination-pools/src/tests.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * remove pub
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * undo
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * leftovers
      
      * fix invariant
      
      * Fix the depositor assumption
      
      * round of self-review
      
      * little bit more cleanup
      
      * Update frame/nomination-pools/src/mock.rs
      
      * Apply suggestions from code review
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Fix interpretation of MinCreateBond
      
      * controvesial refactor
      
      * rename
      
      * make everything build
      
      * add TODO about killing the reward account
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      * last self-review
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Update Cargo.lock
      
      * Rename Delegator to PoolMember
      
      * fmt
      
      * Get runtime to build with runtime-benchmarks feature
      
      * Update Cargo.lock
      
      * Fix asserts to work in more scenarios
      
      * gte not gt
      
      * cargo run --quiet --profile=production  --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_nomination_pools --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/nomination-pools/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Update frame/staking/src/mock.rs
      
      * Update frame/nomination-pools/src/lib.rs
      
      * Update frame/staking/src/slashing.rs
      
      * Apply suggestions from code review
      
      * fmt
      
      * Fix some tests
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      Co-authored-by: default avatarParity Bot <[email protected]>
      Co-authored-by: default avatarkianenigma <[email protected]>
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      247f33dc
  19. Apr 25, 2022
    • Bastian Köcher's avatar
      pallet-asset: Fix transfer of a large amount of an asset (#11241) · 2541efdb
      Bastian Köcher authored
      
      
      * pallet-asset: Fix transfer of a large amount of an asset
      
      Before this pr transferring a large amount of an asset would check that transferring the asset would
      not overflow the supply of the asset. However, it doesn't make sense to check for asset supply
      overflow when we just transfer from one account to another account and don't increase the supply in
      any way. It also required to extend the `can_deposit` method of `fungible` and `fungibles` with a
      `mint` parameter. If this parameter is set to `true`, it means we want to mint the amount of an
      asset before transferring it into an account. For `can_withdraw` we don't need to add an extra
      parameter, because withdrawing should never be able to underflow the supply. If that would happen,
      it would mean that somewhere the supply wasn't increased while increasing the balance of an account.
      
      * Update frame/assets/src/functions.rs
      
      * Update frame/assets/src/functions.rs
      
      * Update frame/assets/src/functions.rs
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * FMT
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      2541efdb
    • Nazar Mokrynskyi's avatar
  20. Apr 16, 2022
  21. Apr 11, 2022
  22. Apr 07, 2022
  23. Apr 04, 2022
    • Bastian Köcher's avatar
      transactional: Fix some nitpicks (#11163) · 9090c01e
      Bastian Köcher authored
      * transactional: Fix some nitpicks
      
      This fixes some nitpicks related to the transactional storage stuff from me. As everything was
      merged too fast, here are some nitpicks from me. First, the entire functionality is moved into its
      own file to have a clear separation. Secondly I changed the `set_transactional_level` to not take
      `Layer` by reference. Besides that I have added some docs etc.
      
      * Add some comment
      
      * Move tests
      
      * 🤦
      9090c01e
    • Alexander Theißen's avatar
      Revert "Replace storage access by atomics" (#11156) · b8dbe46b
      Alexander Theißen authored
      This reverts commit a69b8eb4a28f365a4a4b2fc295a693ec4d3d3cd5.
      b8dbe46b
  24. Apr 03, 2022
  25. Apr 02, 2022
  26. Mar 31, 2022
  27. Mar 27, 2022
  28. Mar 24, 2022
    • Keith Yeung's avatar
      Allow pallet error enum variants to contain fields (#10242) · 208be869
      Keith Yeung authored
      
      
      * Allow pallet errors to contain at most one field
      
      * Update docs on pallet::error
      
      * Reword documentation
      
      * cargo fmt
      
      * Introduce CompactPalletError trait and require #[pallet::error] fields to implement them
      
      * cargo fmt
      
      * Do not assume tuple variants
      
      * Add CompactPalletError derive macro
      
      * Check for error type compactness in construct_runtime
      
      * cargo fmt
      
      * Derive CompactPalletError instead of implementing it directly during macro expansion
      
      * Implement CompactPalletError on OptionBool instead of Option<bool>
      
      * Check for type idents instead of variant ident
      
      * Add doc comments for ErrorCompactnessTest
      
      * Add an trait implementation of ErrorCompactnessTest for ()
      
      * Convert the error field of DispatchError to a 4-element byte array
      
      * Add static check for pallet error size
      
      * Rename to MAX_PALLET_ERROR_ENCODED_SIZE
      
      * Remove ErrorCompactnessTest trait
      
      * Remove check_compactness
      
      * Return only the most significant byte when constructing a custom InvalidTransaction
      
      * Rename CompactPalletError to PalletError
      
      * Use counter to generate unique idents for assert macros
      
      * Make declarative pallet macros compile with pallet error size checks
      
      * Remove unused doc comment
      
      * Try and fix build errors
      
      * Fix build errors
      
      * Add macro_use for some test modules
      
      * Test fix
      
      * Fix compilation errors
      
      * Remove unneeded #[macro_use]
      
      * Resolve import ambiguity
      
      * Make path to pallet Error enum more specific
      
      * Fix test expectation
      
      * Disambiguate imports
      
      * Fix test expectations
      
      * Revert appending pallet module name to path
      
      * Rename bags_list::list::Error to BagError
      
      * Fixes
      
      * Fixes
      
      * Fixes
      
      * Fix test expectations
      
      * Fix test expectation
      
      * Add more implementations for PalletError
      
      * Lift the 1-field requirement for nested pallet errors
      
      * Fix UI test expectation
      
      * Remove PalletError impl for OptionBool
      
      * Use saturating operations
      
      * cargo fmt
      
      * Delete obsolete test
      
      * Fix test expectation
      
      * Try and use assert macro in const context
      
      * Pull out the pallet error size check macro
      
      * Fix UI test for const assertion
      
      * cargo fmt
      
      * Apply clippy suggestion
      
      * Fix doc comment
      
      * Docs for create_tt_return_macro
      
      * Ensure TryInto is imported in earlier Rust editions
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Fix up comments and names
      
      * Implement PalletError for Never
      
      * cargo fmt
      
      * Don't compile example code
      
      * Bump API version for block builder
      
      * Factor in codec attributes while derving PalletError
      
      * Rename module and fix unit test
      
      * Add missing attribute
      
      * Check API version and convert ApplyExtrinsicResult accordingly
      
      * Rename BagError to ListError
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Use codec crate re-exported from frame support
      
      * Add links to types mentioned in doc comments
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * cargo fmt
      
      * cargo fmt
      
      * Re-add attribute for hidden docs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: default avatarKian Paimani <[email protected]>
      208be869