- Nov 29, 2022
-
-
Marcin S. authored
-
- Nov 28, 2022
-
-
Andrei Sandu authored
* RollingSession: add fn contains Signed-off-by:
Andrei Sandu <[email protected]> * handle_import_statements fix ancient dispute check Signed-off-by:
Andrei Sandu <[email protected]> * work with earliest session instead of latest Signed-off-by:
Andrei Sandu <[email protected]> * update comment Signed-off-by:
Andrei Sandu <[email protected]> Signed-off-by:
Andrei Sandu <[email protected]>
-
Marcin S. authored
-
Mattia L.V. Bradascio authored
* Add buckets below 5ms * Add more specific histogram buckets * Add more specific buckets * cargo fmt
-
- Nov 23, 2022
-
-
Marcin S. authored
* Add PVF module documentation TODO (once the PRs land): - [ ] Document executor parametrization. - [ ] Document CPU time measurement of timeouts. * Update node/core/pvf/src/lib.rs Co-authored-by:
Andrei Sandu <[email protected]> * Clarify meaning of PVF acronym * Move PVF doc to implementer's guide * Clean up implementer's guide a bit * Add page for PVF types * pvf: Better separation between crate docs and implementer's guide * ci: Add "prevalidating" to the dictionary * ig: Remove types/chain.md The types contained therein did not exist and the file was not referenced anywhere. Co-authored-by:
Andrei Sandu <[email protected]>
-
- Nov 17, 2022
-
-
Tsvetomir Dimitrov authored
* Change best effort queue behaviour in `dispute-coordinator` Use the same type of queue (`BTreeMap<CandidateComparator, ParticipationRequest>`) for best effort and priority in `dispute-coordinator`. Rework `CandidateComparator` to handle unavailable parent block numbers. Best effort queue will order disputes the same way as priority does - by parent's block height. Disputes on candidates for which the parent's block number can't be obtained will be treated with the lowest priority. * Fix tests: Handle `ChainApiMessage::BlockNumber` in `handle_sync_queries` * Some tests are deadlocking on sending messages via overseer so change `SingleItemSink`to `mpsc::Sender` with a buffer of 1 * Fix a race in test after adding a buffered queue for overseer messages * Fix the rest of the tests * Guide update - best-effort queue * Guide update: clarification about spam votes * Fix tests in `availability-distribution` * Update comments * Add `make_buffered_subsystem_context` in `subsystem-test-helpers` * Code review feedback * Code review feedback * Code review feedback * Don't add best effort candidate if it is already in priority queue * Remove an old comment * Fix insert in best_effort
-
- Nov 16, 2022
-
-
Tsvetomir Dimitrov authored
* Fix typos * Filter unconfirmed disputes in provisioner - random_selection * Rework dispute coordinator to return `DisputeStatus` with `ActiveDisputes` message. * Rework the random_selection implementation of `select_disptues` in `provisioner` to return only confirmed disputes. * Filter unconfirmed disputes in provisioner - prioritized_selection * Add test for unconfirmed disputes handling * Fix `dispute-distribution` tests
-
- Nov 15, 2022
-
-
Marcin S. authored
Was seeing these warnings when running `cargo check --all`: ``` warning: for loop over an `Option`. This is more readably written as an `if let` statement --> node/core/approval-voting/src/lib.rs:1147:21 | 1147 | for activated in update.activated { | ^^^^^^^^^^^^^^^^ | = note: `#[warn(for_loops_over_fallibles)]` on by default help: to check pattern in a loop use `while let` | 1147 | while let Some(activated) = update.activated { | ~~~~~~~~~~~~~~~ ~~~ help: consider using `if let` to clear intent | 1147 | if let Some(activated) = update.activated { | ~~~~~~~~~~~~ ~~~ ``` My guess is that `activated` used to be a SmallVec or similar, as is `deactivated`. It was changed to an `Option`, the `for` still compiled (it's technically correct, just weird), and the compiler didn't catch it until now.
-
- Nov 14, 2022
-
-
eskimor authored
* Only report concluded if there is an actual dispute. Hence no "non"-disputes will be added to disputes anymore. * Fix redundant check. * Test for no onesided disputes. Co-authored-by:
eskimor <[email protected]>
-
- Nov 12, 2022
-
-
ordian authored
* approval-voting: remove a redundant check * candidate-validation: remove unreachable check
-
- Nov 11, 2022
-
-
Tsvetomir Dimitrov authored
* Scraper processes CandidateBacked events * Change definition of best-effort * Fix `dispute-coordinator` tests * Unit test for dispute filtering * Clarification comment * Add tests * Fix logic If a dispute is not backed, not included and not confirmed we don't participate but we do import votes. * Add metrics for refrained participations * Revert "Add tests" This reverts commit 7b8391a087922ced942cde9cd2b50ff3f633efc0. * Revert "Unit test for dispute filtering" This reverts commit 92ba5fe678214ab360306313a33c781338e600a0. * fix dispute-coordinator tests * Fix scraping * new tests * Small fixes in guide * Apply suggestions from code review Co-authored-by:
Andrei Sandu <[email protected]> * Fix some comments and remove a pointless test * Code review feedback * Clarification comment in tests * Some tests * Reference counted `CandidateHash` in scraper * Proper handling for Backed and Included candidates in scraper Backed candidates which are not included should be kept for a predetermined window of finalized blocks. E.g. if a candidate is backed but not included in block 2, and the window size is 2, the same candidate should be cleaned after block 4 is finalized. Add reference counting for candidates in scraper. A candidate can be added on multiple block heights so we have to make sure we don't clean it prematurely from the scraper. Add tests. * Update comments in tests * Guide update * Fix cleanup logic for `backed_candidates_by_block_number` * Simplify cleanup * Make spellcheck happy * Update tests * Extract candidate backing logic in separate struct * Code review feedback * Treat backed and included candidates in the same fashion * Update some comments * Small improvements in test * spell check * Fix some more comments * clean -> prune * Code review feedback * Reword comment * spelling Co-authored-by:
Andrei Sandu <[email protected]>
-
- Nov 08, 2022
-
-
Marcin S. authored
* Fix a couple of typos * Retry failed PVF execution PVF execution that fails due to AmbiguousWorkerDeath should be retried once. This should reduce the occurrence of failures due to transient conditions. Closes #6195 * Address a couple of nits * Write tests; refactor (add `validate_candidate_with_retry`) * Update node/core/candidate-validation/src/lib.rs Co-authored-by:
Andronik <[email protected]> Co-authored-by:
eskimor <[email protected]> Co-authored-by:
Andronik <[email protected]>
-
Andrei Sandu authored
* Impl dynamic window size. Keep sessions for unfinalized chain Signed-off-by:
Andrei Sandu <[email protected]> * feedback Signed-off-by:
Andrei Sandu <[email protected]> * Stretch also in contructor plus tests Signed-off-by:
Andrei Sandu <[email protected]> * review feedback Signed-off-by:
Andrei Sandu <[email protected]> * fix approval-voting tests Signed-off-by:
Andrei Sandu <[email protected]> * grunting: dispute coordinator tests Signed-off-by:
Andrei Sandu <[email protected]> * add session window column Signed-off-by:
Andrei Sandu <[email protected]> * integrate approval vote and fix tests Signed-off-by:
Andrei Sandu <[email protected]> * fix rolling session tests Signed-off-by:
Andrei Sandu <[email protected]> * Small refactor Signed-off-by:
Andrei Sandu <[email protected]> * WIP, tests failing Signed-off-by:
Andrei Sandu <[email protected]> * Fix approval voting tests Signed-off-by:
Andrei Sandu <[email protected]> * fix dispute-coordinator tests Signed-off-by:
Andrei Sandu <[email protected]> * remove uneeded param Signed-off-by:
Andrei Sandu <[email protected]> * fmt Signed-off-by:
Andrei Sandu <[email protected]> * fix loose ends Signed-off-by:
Andrei Sandu <[email protected]> * allow failure and tests for it Signed-off-by:
Andrei Sandu <[email protected]> * fix comment Signed-off-by:
Andrei Sandu <[email protected]> * comment fix Signed-off-by:
Andrei Sandu <[email protected]> * style fix Signed-off-by:
Andrei Sandu <[email protected]> * new col doesn't need to be ordered Signed-off-by:
Andrei Sandu <[email protected]> * fmt and spellcheck Signed-off-by:
Andrei Sandu <[email protected]> * db persist tests Signed-off-by:
Andrei Sandu <[email protected]> * Add v2 config and cols Signed-off-by:
Andrei Sandu <[email protected]> * DB upgrade WIP Signed-off-by:
Andrei Sandu <[email protected]> * Fix comments Signed-off-by:
Andrei Sandu <[email protected]> * add todo Signed-off-by:
Andrei Sandu <[email protected]> * update to parity-db to "0.4.2" Signed-off-by:
Andrei Sandu <[email protected]> * migration complete Signed-off-by:
Andrei Sandu <[email protected]> * One session window size Signed-off-by:
Andrei Sandu <[email protected]> * fix merge damage Signed-off-by:
Andrei Sandu <[email protected]> * fix build errors Signed-off-by:
Andrei Sandu <[email protected]> * fmt Signed-off-by:
Andrei Sandu <[email protected]> * comment fix Signed-off-by:
Andrei Sandu <[email protected]> * fix build Signed-off-by:
Andrei Sandu <[email protected]> * make error more explicit Signed-off-by:
Andrei Sandu <[email protected]> * add comment Signed-off-by:
Andrei Sandu <[email protected]> * refactor conflict merge Signed-off-by:
Andrei Sandu <[email protected]> * rename col_data Signed-off-by:
Andrei Sandu <[email protected]> * add doc comment Signed-off-by:
Andrei Sandu <[email protected]> * fix build Signed-off-by:
Andrei Sandu <[email protected]> * migration: move all cols to v2 Signed-off-by:
Andrei Sandu <[email protected]> Signed-off-by:
Andrei Sandu <[email protected]>
-
Marcin S. authored
-
- Nov 07, 2022
-
-
Alexander Samusev authored
* Pipeline with ci image with rust 1.65 * fix a warning * return production image Co-authored-by:
Andronik <[email protected]>
-
- Nov 01, 2022
-
-
Marcin S. authored
* Rename timeout consts and timeout parameter; bump leniency * Update implementor's guide with info about PVFs * Make glossary a bit easier to read * Add a note to LENIENT_PREPARATION_TIMEOUT * Remove PVF-specific section from glossary * Fix some typos
-
- Oct 31, 2022
-
-
Andrei Sandu authored
* Add approval voting db sanity check Signed-off-by:
Andrei Sandu <[email protected]> * add newline back Signed-off-by:
Andrei Sandu <[email protected]> * no need for overlay to read Signed-off-by:
Andrei Sandu <[email protected]> Signed-off-by:
Andrei Sandu <[email protected]>
-
- Oct 26, 2022
-
-
Marcin S. authored
* Log exit status code for workers * Make log for execute job conclusion match prepare job conclusion Trace log for conclusion of prepare job: ```rs gum::debug!( target: LOG_TARGET, validation_code_hash = ?artifact_id.code_hash, ?worker, ?rip, "prepare worker concluded", ); ``` Co-authored-by: parity-processbot <>
-
- Oct 22, 2022
-
-
Boluwatife Bakre authored
* Fix for issue #2403 * Nightly fmt * Quick documentation fixes * Default Implementation * iter() function integrated * Implemented iter functionalities * Fmt * small change * updates node-network * updates in dispute-coordinator * Updates * benchmarking fix * minor fix * test fixes in runtime api * Update primitives/src/v2/mod.rs Co-authored-by:
Andronik <[email protected]> * Update primitives/src/v2/mod.rs Co-authored-by:
Andronik <[email protected]> * Update primitives/src/v2/mod.rs Co-authored-by:
Andronik <[email protected]> * Update primitives/src/v2/mod.rs Co-authored-by:
Andronik <[email protected]> * Update primitives/src/v2/mod.rs Co-authored-by:
Andronik <[email protected]> * Removal of [index], shorting of FromIterator, Renaming of GroupValidators to ValidatorGroups * Removal of ops import * documentation fixes for spell check * implementation of generic type * Refactoring * Test and documentation fixes * minor test fix * minor test fix * minor test fix * Update node/network/statement-distribution/src/lib.rs Co-authored-by:
Andronik <[email protected]> * Update primitives/src/v2/mod.rs Co-authored-by:
Andronik <[email protected]> * Update primitives/src/v2/mod.rs Co-authored-by:
Andronik <[email protected]> * removed IterMut * Update node/core/dispute-coordinator/src/import.rs Co-authored-by:
Andronik <[email protected]> * Update node/core/dispute-coordinator/src/initialized.rs Co-authored-by:
Andronik <[email protected]> * Update primitives/src/v2/mod.rs Co-authored-by:
Andronik <[email protected]> * fmt * IterMut * documentation update Co-authored-by:
Andronik <[email protected]> * minor adjustments and new TypeIndex trait * spelling fix * TypeIndex fix Co-authored-by:
Andronik <[email protected]>
-
Mara Broda authored
* Bump spec_version to 9310 * bump transaction_version (0.9.31) (#6171) * Bump transaction_version for polkadot * Bump transaction_version for kusama * Bump transaction_version for rococo * Bump transaction_version for westend * Bump transaction_version for polkadot * Bump transaction_version for kusama * Bump transaction_version for rococo * Bump transaction_version for westend * Bump crate versions (0.9.31)
-
- Oct 13, 2022
-
-
Marcin S. authored
* Add some documentation * Add `compilation_timeout` parameter for PVF preparation job * Update buckets in prometheus metrics * Update prepare/queue tests * Update pvf-prechecking overview in implementer docs * Fix some CI checks
-
- Oct 05, 2022
-
-
ordian authored
* toml changes * REVERTME: patch * adapt parachains db interface * fix Cargo.toml patch after master rebase * fix av-store * fix chain-selection * fix parachains-db? * Revert "fix Cargo.toml patch after master rebase" This reverts commit 3afcbf033c86027b3f2b909d83ec703591bdd287. * Revert "REVERTME: patch" This reverts commit 464b717cf4142d3d09c3d77b83700b632d8c5f54. * Use `Ok` imported from prelude Co-authored-by:
Bastian Köcher <[email protected]> * update lockfile for {"substrate"} * Revert "update lockfile for {"substrate"}" This reverts commit fdc623de226f7645741b86c4b1a7d030fed2172d. * cargo update -p sp-io Co-authored-by:
Bastian Köcher <[email protected]> Co-authored-by: parity-processbot <>
-
- Oct 04, 2022
-
-
dependabot[bot] authored
* Bump lru from 0.7.8 to 0.8.0 Bumps [lru](https://github.com/jeromefroe/lru-rs) from 0.7.8 to 0.8.0. - [Release notes](https://github.com/jeromefroe/lru-rs/releases) - [Changelog](https://github.com/jeromefroe/lru-rs/blob/master/CHANGELOG.md) - [Commits](https://github.com/jeromefroe/lru-rs/compare/0.7.8...0.8.0 ) --- updated-dependencies: - dependency-name: lru dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by:
dependabot[bot] <[email protected]> * Change `LruCache` paramerter to `NonZeroUsize` * Change type of `session_cache_lru_size` to `NonZeroUsize` * Add expects instead of unwrap Co-authored-by:
Bastian Köcher <[email protected]> * Use match to get rid of expects Signed-off-by:
dependabot[bot] <[email protected]> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by:
Sebastian Kunert <[email protected]> Co-authored-by:
Bastian Köcher <[email protected]>
-
Andrei Sandu authored
* Impl dynamic window size. Keep sessions for unfinalized chain Signed-off-by:
Andrei Sandu <[email protected]> * feedback Signed-off-by:
Andrei Sandu <[email protected]> * Stretch also in contructor plus tests Signed-off-by:
Andrei Sandu <[email protected]> * review feedback Signed-off-by:
Andrei Sandu <[email protected]> * fix approval-voting tests Signed-off-by:
Andrei Sandu <[email protected]> * grunting: dispute coordinator tests Signed-off-by:
Andrei Sandu <[email protected]> Signed-off-by:
Andrei Sandu <[email protected]>
-
Robert Klotzner authored
* Use active_leaves for synchronization. Otherwise on reverts the syncrhonization of create inherent would not work. * Add some trace logs.
-
- Sep 30, 2022
-
-
Andrei Sandu authored
Signed-off-by:
Andrei Sandu <[email protected]> Signed-off-by:
Andrei Sandu <[email protected]>
-
- Sep 29, 2022
-
-
Robert Klotzner authored
This can happen under heavy load - no value in warning here. Scenario this happens: - New slot - We get asked about what fork to build on - We start building (create inherent gets called) - We learn about a better fork (but Babe does not care as it already has a fork) - 6 seconds passed - New slot - Babe asks about what for to build on - we answer with the best block we learned about 6 seconds ago (slightly after we got asked the last time) - We start building (on that old block) - Milliseconds later we learn about a new block (the one from the slot we are actually in now) - We kick the old leaf -> create inherent fails Full discussion: https://github.com/paritytech/substrate/issues/12375
-
- Sep 27, 2022
-
-
ordian authored
* make spellcheck green again * remove the comment * Fix a comment in `provisioner` Co-authored-by:
Tsvetomir Dimitrov <[email protected]>
-
- Sep 19, 2022
-
-
Tsvetomir Dimitrov authored
* Add `DisputeState` to `DisputeCoordinatorMessage::RecentDisputes` The new signature of the message is: ``` RecentDisputes(oneshot::Sender<Vec<(SessionIndex, CandidateHash, DisputeStatus)>>), ``` As part of the change also add `DispiteStatus` to `polkadot_node_primitives`. * Move dummy_signature() in primitives/test-helpers * Enable staging runtime api on Rococo * Implementation * Move disputes to separate module * Vote prioritisation * Duplicates handling * Double vote handling * Unit tests * Logs and metrics * Code review feedback * Fix ACTIVE/INACTIVE separation and update partition names * Add `fn dispute_is_inactive` to node primitives and refactor `fn get_active_with_status()` logic * Keep the 'old' logic if the staging api is not enabled * Fix some comments in tests * Add warning message if there are any inactive_unknown_onchain disputes * Add file headers and remove `use super::*;` usage outside tests * Adding doc comments * Fix test methods names * Fix staging api usage * Fix `get_disputes` runtime function implementation * Fix compilation error * Fix arithmetic operations in tests * Use smaller test data * Rename `RuntimeApiRequest::StagingDisputes` to `RuntimeApiRequest::Disputes` * Remove `staging-client` feature flag * fmt * Remove `vstaging` feature flag * Some comments regarding the staging api * Rename dispute selection modules in provisioner with_staging_api -> prioritized_selection without_staging_api -> random_selection * Comments for staging api * Comments * Additional logging * Code review feedback process_selected_disputes -> into_multi_dispute_statement_set typo In trait VoteType: vote_value -> is_valid * Code review feedback * Fix metrics * get_disputes -> disputes * Get time only once during partitioning * Fix partitioning * Comments * Reduce the number of hardcoded api versions * Code review feedback * Unused import * Comments * More precise log messages * Code review feedback * Code review feedback * Code review feedback - remove `trait VoteType` * Code review feedback * Trace log for DisputeCoordinatorMessage::QueryCandidateVotes counter in vote_selection
-
- Sep 15, 2022
-
-
ordian authored
-
- Sep 14, 2022
-
-
Nisheeth Barthwal authored
-
- Sep 09, 2022
-
-
Mara Broda authored
* Bump transaction_version for westend * Bump transaction_version for rococo * Bump transaction_version for kusama * Bump transaction_version for polkadot * Bump spec_version to 9290 * Bump crate versions
-
- Sep 06, 2022
-
-
Davide Galassi authored
* Read babe config parameters from runtime * Trigger pipeline * Trigger pipeline (after PR title change) * update lockfile for {"substrate"} Co-authored-by: parity-processbot <>
-
- Sep 05, 2022
-
-
Tsvetomir Dimitrov authored
-
- Sep 02, 2022
-
-
ordian authored
-
- Sep 01, 2022
-
-
Robert Klotzner authored
* Don't store available data on disputes If there are lots of disputes, this leads to blowing up disk space on validators. Rob luckily remembered that we do store the full availability in participation. The argument in the code does not make too much sense with the current implementation, as no validator will ever request anything else from us, than the one piece we are meant to posess. * Fix warnings. * Fix compile warnings * Remove redundant field. Co-authored-by:
Vsevolod Stakhov <[email protected]>
-
- Aug 30, 2022
-
-
ordian authored
-
- Aug 29, 2022
-
-
Tsvetomir Dimitrov authored
-
Mara Broda authored
* Bump crate versions * Bump spec_version to 9280 for kusama * Bump spec_version to 9280 for polkadot * Bump spec_version to 9280 for rococo * Bump spec_version to 9280 for westend * update Cargo.lock Co-authored-by: parity-processbot <>
-
- Aug 24, 2022
-
-
dependabot[bot] authored
Bumps [async-trait](https://github.com/dtolnay/async-trait) from 0.1.56 to 0.1.57. - [Release notes](https://github.com/dtolnay/async-trait/releases) - [Commits](https://github.com/dtolnay/async-trait/compare/0.1.56...0.1.57 ) --- updated-dependencies: - dependency-name: async-trait dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by:
dependabot[bot] <[email protected]> Signed-off-by:
dependabot[bot] <[email protected]> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-