Skip to content
  1. Nov 24, 2022
  3. Nov 23, 2022
    • eskimor's avatar
      Rate limit improvements (#6315) · 7ba08473
      eskimor authored 
      

* We actually don't need to rate limit redundant requests.

Those redundant requests should not actually happen, but still.

* Add some logging.

* Also log message when the receiving side hit the rate limit.

* Update node/network/dispute-distribution/src/sender/mod.rs

Co-authored-by: default avatarAlexandru Vasile <[email protected]>

Co-authored-by: default avatareskimor <[email protected]>
Co-authored-by: default avatarAlexandru Vasile <[email protected]>
      7ba08473
    • Marcin S.'s avatar
      Add PVF module documentation (#6293) · 1dec2433
      Marcin S. authored 
      

* Add PVF module documentation

TODO (once the PRs land):

- [ ] Document executor parametrization.

- [ ] Document CPU time measurement of timeouts.

* Update node/core/pvf/src/lib.rs

Co-authored-by: default avatarAndrei Sandu <[email protected]>

* Clarify meaning of PVF acronym

* Move PVF doc to implementer's guide

* Clean up implementer's guide a bit

* Add page for PVF types

* pvf: Better separation between crate docs and implementer's guide

* ci: Add "prevalidating" to the dictionary

* ig: Remove types/chain.md

The types contained therein did not exist and the file was not referenced
anywhere.

Co-authored-by: default avatarAndrei Sandu <[email protected]>
      1dec2433
  5. Nov 22, 2022
  7. Nov 21, 2022
  9. Nov 20, 2022
  11. Nov 18, 2022
  13. Nov 17, 2022
    • Alexander Samusev's avatar
      [ci] fix build implementers guide (#6306) · d19484e9
      Alexander Samusev authored 
      * [ci] fix build implementers guide

* add comment

* rm git fetch from publish-docs
      d19484e9
    • Tsvetomir Dimitrov's avatar
      Change best effort queue behaviour in `dispute-coordinator` (#6275) · ccad411e
      Tsvetomir Dimitrov authored 
      * Change best effort queue behaviour in `dispute-coordinator`

Use the same type of queue (`BTreeMap<CandidateComparator,
ParticipationRequest>`) for best effort and priority in
`dispute-coordinator`.

Rework `CandidateComparator` to handle unavailable parent
block numbers.

Best effort queue will order disputes the same way as priority does - by
parent's block height. Disputes on candidates for which the parent's
block number can't be obtained will be treated with the lowest priority.

* Fix tests: Handle `ChainApiMessage::BlockNumber` in `handle_sync_queries`

* Some tests are deadlocking on sending messages via overseer so change `SingleItemSink`to `mpsc::Sender` with a buffer of 1

* Fix a race in test after adding a buffered queue for overseer messages

* Fix the rest of the tests

* Guide update - best-effort queue

* Guide update: clarification about spam votes

* Fix tests in `availability-distribution`

* Update comments

* Add `make_buffered_subsystem_context` in `subsystem-test-helpers`

* Code review feedback

* Code review feedback

* Code review feedback

* Don't add best effort candidate if it is already in priority queue

* Remove an old comment

* Fix insert in best_effort
      ccad411e
    • Andrei Sandu's avatar
      Dedup subsystem name (#6305) · ad41e56e
      Andrei Sandu authored 
      

Signed-off-by: default avatarAndrei Sandu <[email protected]>

Signed-off-by: default avatarAndrei Sandu <[email protected]>
      ad41e56e
    • Kutsal Kaan Bilgin's avatar
      Add Helikon boot nodes for Polkadot, Kusama and Westend. (#6240) · 0c9187a0
      Kutsal Kaan Bilgin authored
      0c9187a0
  15. Nov 16, 2022
    • Tsvetomir Dimitrov's avatar
      Provisioner should ignore unconfirmed disputes (#6294) · a0f4287d
      Tsvetomir Dimitrov authored 
      * Fix typos

* Filter unconfirmed disputes in provisioner -  random_selection

* Rework dispute coordinator to return `DisputeStatus` with
`ActiveDisputes` message.
* Rework the random_selection implementation of `select_disptues` in
  `provisioner` to return only confirmed disputes.

* Filter unconfirmed disputes in provisioner - prioritized_selection

* Add test for unconfirmed disputes handling

* Fix `dispute-distribution` tests
      a0f4287d
    • Alexander Samusev's avatar
      [ci] Improve pipeline stopper (#6300) · 40221806
      Alexander Samusev authored 
      * [ci] Improve pipeline stopper

* break test-linux-stable

* fix test-linux-stable
      40221806
  17. Nov 15, 2022
    • Niklas Adolfsson's avatar
      companion for #12599 (#6290) · 4b9f3aa8
      Niklas Adolfsson authored 
      * companion for #12599

* update Cargo.lock

* use cargo path instead of diener

* update lockfile for {"substrate"}

Co-authored-by: parity-processbot <>
      4b9f3aa8
    • Marcin S.'s avatar
      Fixes "for loop over an `Option`" warnings (#6291) · d53513ff
      Marcin S. authored 
      Was seeing these warnings when running `cargo check --all`:

```
warning: for loop over an `Option`. This is more readably written as an `if let` statement
    --> node/core/approval-voting/src/lib.rs:1147:21
     |
1147 |             for activated in update.activated {
     |                              ^^^^^^^^^^^^^^^^
     |
     = note: `#[warn(for_loops_over_fallibles)]` on by default
help: to check pattern in a loop use `while let`
     |
1147 |             while let Some(activated) = update.activated {
     |             ~~~~~~~~~~~~~~~         ~~~
help: consider using `if let` to clear intent
     |
1147 |             if let Some(activated) = update.activated {
     |             ~~~~~~~~~~~~         ~~~
```

My guess is that `activated` used to be a SmallVec or similar, as is
`deactivated`. It was changed to an `Option`, the `for` still compiled (it's
technically correct, just weird), and the compiler didn't catch it until now.
      d53513ff
    • eskimor's avatar
      Revert special casing of Kusama for grandpa rounds. (#6217) · c606deb3
      eskimor authored 
      

Co-authored-by: default avatareskimor <[email protected]>
      c606deb3
  19. Nov 14, 2022
  21. Nov 13, 2022
  23. Nov 12, 2022
  25. Nov 11, 2022
    • Tsvetomir Dimitrov's avatar
      Update disputes prioritisation in `dispute-coordinator` (#6130) · ff09b18d
      Tsvetomir Dimitrov authored 
      

* Scraper processes CandidateBacked events

* Change definition of best-effort

* Fix `dispute-coordinator` tests

* Unit test for dispute filtering

* Clarification comment

* Add tests

* Fix logic

If a dispute is not backed, not included and not confirmed we
don't participate but we do import votes.

* Add metrics for refrained participations

* Revert "Add tests"

This reverts commit 7b8391a087922ced942cde9cd2b50ff3f633efc0.

* Revert "Unit test for dispute filtering"

This reverts commit 92ba5fe678214ab360306313a33c781338e600a0.

* fix dispute-coordinator tests

* Fix scraping

* new tests

* Small fixes in guide

* Apply suggestions from code review

Co-authored-by: default avatarAndrei Sandu <[email protected]>

* Fix some comments and remove a pointless test

* Code review feedback

* Clarification comment in tests

* Some tests

* Reference counted `CandidateHash` in scraper

* Proper handling for Backed and Included candidates in scraper

Backed candidates which are not included should be kept for a
predetermined window of finalized blocks. E.g. if a candidate is backed
but not included in block 2, and the window size is 2, the same
candidate should be cleaned after block 4 is finalized.

Add reference counting for candidates in scraper. A candidate can be
added on multiple block heights so we have to make sure we don't clean
it prematurely from the scraper.

Add tests.

* Update comments in tests

* Guide update

* Fix cleanup logic for `backed_candidates_by_block_number`

* Simplify cleanup

* Make spellcheck happy

* Update tests

* Extract candidate backing logic in separate struct

* Code review feedback

* Treat  backed and included candidates in the same fashion

* Update some comments

* Small improvements in test

* spell check

* Fix some more comments

* clean -> prune

* Code review feedback

* Reword comment

* spelling

Co-authored-by: default avatarAndrei Sandu <[email protected]>
      ff09b18d
    • Bradley Olson's avatar
      Brad implementers guide revisions 2 (#6239) · 0cea4eed
      Bradley Olson authored 
      * Add disputes subsystems fix

* Updated dispute approval vote import reasoning

* Improved wording of my changes

* Resolving issues brought up in comments
      0cea4eed
    • cheme's avatar
      State trie migration rococo runtime changes. (#6127) · 79d9ea4f
      cheme authored 
      * add state-trie-migration (warn key need to be changed)

* rococo root

* restore master benchs (weights from substrate are used).

* use ord_parameter macro.

* do not upgrade runtime version yet

* apply review changes

* to test ci

* Revert "to test ci"

This reverts commit 5df6c5c74c5d172f254579cbb76caeb44af80ec2.

* test ci

* Revert "test ci"

This reverts commit 0747761644ba566f9756e195e5304758370dc52c.

Co-authored-by: parity-processbot <>
      79d9ea4f
  27. Nov 10, 2022
  29. Nov 09, 2022
  31. Nov 08, 2022
  33. Nov 07, 2022