Skip to content
Snippets Groups Projects
  1. Sep 13, 2024
  2. Sep 12, 2024
  3. Sep 11, 2024
  4. Sep 10, 2024
    • Maksym H's avatar
      Add prdoc command to /cmd (#5661) · f0e420a0
      Maksym H authored
      Fixes https://github.com/paritytech/polkadot-sdk/issues/5647
      
      - [x]  create new command (reusing original py module)
      - [x]  add unit-test cases (just the fact of proxy)
      - [x]  update docs
    • Alexandru Vasile's avatar
      litep2p: Update network backend to v0.7.0 (#5609) · 12eeb5df
      Alexandru Vasile authored
      
      This release introduces several new features, improvements, and fixes to
      the litep2p library. Key updates include enhanced error handling,
      configurable connection limits, and a new API for managing public
      addresses.
      
      For a detailed set of changes, see [litep2p
      changelog](https://github.com/paritytech/litep2p/blob/master/CHANGELOG.md#070---2024-09-05).
      
      This PR makes use of:
      - connection limits to optimize network throughput
      - better errors that are propagated to substrate metrics 
      - public addresses API to report healthy addresses to the Identify
      protocol
      
      ### Warp sync time improvement
      
      Measuring warp sync time is a bit inaccurate since the network is not
      deterministic and we might end up using faster peers (peers with more
      resources to handle our requests). However, I did not see warp sync
      times of 16 minutes, instead, they are roughly stabilized between 8 and
      10 minutes.
      
      For measuring warp-sync time, I've used
      [sub-trige-logs](https://github.com/lexnv/sub-triage-logs/?tab=readme-ov-file#warp-time)
      
      ### Litep2p
      
      Phase | Time
       -|-
      Warp  | 426.999999919s
      State | 99.000000555s
      Total | 526.000000474s
      
      ### Libp2p
      
      Phase | Time
       -|-
      Warp  | 731.999999837s
      State | 71.000000882s
      Total | 803.000000719s
      
      Closes: https://github.com/paritytech/polkadot-sdk/issues/4986
      
      
      ### Low peer count
      
      After exposing the `litep2p::public_addresses` interface, we can report
      to litep2p confirmed external addresses. This should mitigate or at
      least improve: https://github.com/paritytech/polkadot-sdk/issues/4925.
      Will keep the issue around to confirm this.
      
      
      ### Improved metrics
      
      We are one step closer to exposing similar metrics as libp2p:
      https://github.com/paritytech/polkadot-sdk/issues/4681.
      
      cc @paritytech/networking 
      
      ### Next Steps
      - [x] Use public address interface to confirm addresses to identify
      protocol
      
      ---------
      
      Signed-off-by: default avatarAlexandru Vasile <alexandru.vasile@parity.io>
    • Liu-Cheng Xu's avatar
      Introduce `RpcParams` in sc-cli (#5601) · 278d1bf7
      Liu-Cheng Xu authored
      
      This PR is a pure refactoring by consolidating all the RPC related
      parameters into a dedicated `RpcParams` struct, allowing us at subcoin
      to build a custom run cmd without the need to duplicate code.
      
      ---------
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      Co-authored-by: default avatarNiklas Adolfsson <niklasadolfsson1@gmail.com>
    • Nazar Mokrynskyi's avatar
      Syncing strategy refactoring (#5469) · 1f1f20a8
      Nazar Mokrynskyi authored
      This is a step towards
      https://github.com/paritytech/polkadot-sdk/issues/5333
      
      The commits with code moving (but no other changes) and actual changes
      are separated for easier review.
      
      Essentially this results in `SyncingStrategy` trait replacing struct
      (which is renamed to `PolkadotSyncingStrategy`, open for better name
      suggestions). Technically it is already possible to replace
      `PolkadotSyncingStrategy<B, Client>` with `Box<dyn SyncingStrategy<B>`
      in syncing engine, but I decided to postpone such change until we
      actually have an ability to customize it. It should also be possible to
      swap `PolkadotSyncingStrategy` with just `ChainSync` that only supports
      regular full sync from genesis (it also implements `SyncingStrategy`
      trait).
      
      While extracted trait still has a lot of non-generic stuff in it like
      exposed knowledge of warp sync and `StrategyKey` with hardcoded set of
      options, I believe this is a step in the right direction and will
      address those in upcoming PRs.
      
      With https://github.com/paritytech/polkadot-sdk/pull/5431 that landed
      earlier warp sync configuration is more straightforward, but there are
      still numerous things interleaved that will take some time to abstract
      away nicely and expose in network config for developers. For now this is
      an internal change even though data structures are technically public
      and require major version bump.
    • Oliver Tale-Yazdi's avatar
      [Bot] Use correct token in backport bot (#5654) · d887804b
      Oliver Tale-Yazdi authored
      
      The backport bot does currently not trigger the CI when opening a MR,
      like here: https://github.com/paritytech/polkadot-sdk/pull/5651
      Devs need to push an empty commit manually. Now using a token that will
      also trigger the CI.
      
      ---------
      
      Signed-off-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
    • Alexander Samusev's avatar
      [WIP][ci] GHA improvements (#5653) · 9079f36b
      Alexander Samusev authored
      Changes in PR: 
      - enables `Check Cargo Check Runtimes` (it was accidentally disabled)
      - reorder jobs in test-misc to make it faster
      - add `quick-benchmarks-omni` to `check-frame-omni-bencher` (the
      workflow is currently disabled)
    • Liu-Cheng Xu's avatar
      Fix edge case where state sync is not triggered (#5635) · 8236718e
      Liu-Cheng Xu authored
      This PR addresses an issue where state sync may fail to start if the
      conditions required for its initiation are not met when a finalized
      block notification is received. `pending_state_sync_attempt` is
      introduced to trigger the state sync later when the conditions are
      satisfied.
      
      This issue was spotted when I worked on #5406, specifically,
      `queue_blocks` was not empty when the finalized block notification was
      received, and then the state sync was stalled. cc @dmitry-markin
      
      
      
      ---------
      
      Co-authored-by: default avatarDmitry Markin <dmitry@markin.tech>
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
    • dependabot[bot]'s avatar
      Bump the ci_dependencies group with 2 updates (#5637) · 7c90f51d
      dependabot[bot] authored
      Bumps the ci_dependencies group with 2 updates:
      [actions/checkout](https://github.com/actions/checkout) and
      [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request).
      
      Updates `actions/checkout` from 2 to 4
      <details>
      <summary>Release notes</summary>
      <p><em>Sourced from <a
      href="https://github.com/actions/checkout/releases">actions/checkout's
      releases</a>.</em></p>
      <blockquote>
      <h2>v4.0.0</h2>
      <h2>What's Changed</h2>
      <ul>
      <li>Update default runtime to node20 by <a
      href="https://github.com/takost"><code>@​takost</code></a> in <a
      href="https://redirect.github.com/actions/checkout/pull/1436">actions/checkout#1436</a></li>
      <li>Support fetching without the --progress option by <a
      href="https://github.com/simonbaird"><code>@​simonbaird</code></a> in <a
      href="https://redirect.github.com/actions/checkout/pull/1067">actions/checkout#1067</a></li>
      <li>Release 4.0.0 by <a
      href="https://github.com/takost"><code>@​takost</code></a> in <a
      href="https://redirect.github.com/actions/checkout/pull/1447">actions/checkout#1447</a></li>
      </ul>
      <h2>New Contributors</h2>
      <ul>
      <li><a href="https://github.com/takost"><code>@​takost</code></a> made
      their first contribution in <a
      href="https://redirect.github.com/actions/checkout/pull/1436">actions/checkout#1436</a></li>
      <li><a
      href="https://github.com/simonbaird"><code>@​simonbaird</code></a> made
      their first contribution in <a
      href="https://redirect.github.com/actions/checkout/pull/1067">actions/checkout#1067</a></li>
      </ul>
      <p><strong>Full Changelog</strong>: <a
      href="https://github.com/actions/checkout/compare/v3...v4.0.0">https://github.com/actions/checkout/compare/v3...v4.0.0</a></p>
      <h2>v3.6.0</h2>
      <h2>What's Changed</h2>
      <ul>
      <li>Mark test scripts with Bash'isms to be run via Bash by <a
      href="https://github.com/dscho"><code>@​dscho</code></a> in <a
      href="https://redirect.github.com/actions/checkout/pull/1377">actions/checkout#1377</a></li>
      <li>Add option to fetch tags even if fetch-depth &gt; 0 by <a
      href="https://github.com/RobertWieczoreck"><code>@​RobertWieczoreck</code></a>
      in <a
      href="https://redirect.github.com/actions/checkout/pull/579">actions/checkout#579</a></li>
      <li>Release 3.6.0 by <a
      href="https://github.com/luketomlinson"><code>@​luketomlinson</code></a>
      in <a
      href="https://redirect.github.com/actions/checkout/pull/1437">actions/checkout#1437</a></li>
      </ul>
      <h2>New Contributors</h2>
      <ul>
      <li><a
      href="https://github.com/RobertWieczoreck"><code>@​RobertWieczoreck</code></a>
      made their first contribution in <a
      href="https://redirect.github.com/actions/checkout/pull/579">actions/checkout#579</a></li>
      <li><a
      href="https://github.com/luketomlinson"><code>@​luketomlinson</code></a>
      made their first contribution in <a
      href="https://redirect.github.com/actions/checkout/pull/1437">actions/checkout#1437</a></li>
      </ul>
      <p><strong>Full Changelog</strong>: <a
      href="https://github.com/actions/checkout/compare/v3.5.3...v3.6.0">https://github.com/actions/checkout/compare/v3.5.3...v3.6.0</a></p>
      <h2>v3.5.3</h2>
      <h2>What's Changed</h2>
      <ul>
      <li>Fix: Checkout Issue in self hosted runner due to faulty submodule
      check-ins by <a
      href="https://github.com/megamanics"><code>@​megamanics</code></a> in <a
      href="https://redirect.github.com/actions/checkout/pull/1196">actions/checkout#1196</a></li>
      <li>Fix typos found by codespell by <a
      href="https://github.com/DimitriPapadopoulos"><code>@​DimitriPapadopoulos</code></a>
      in <a
      href="https://redirect.github.com/actions/checkout/pull/1287">actions/checkout#1287</a></li>
      <li>Add support for sparse checkouts by <a
      href="https://github.com/dscho"><code>@​dscho</code></a> and <a
      href="https://github.com/dfdez"><code>@​dfdez</code></a> in <a
      href="https://redirect.github.com/actions/checkout/pull/1369">actions/checkout#1369</a></li>
      <li>Release v3.5.3 by <a
      href="https://github.com/TingluoHuang"><code>@​TingluoHuang</code></a>
      in <a
      href="https://redirect.github.com/actions/checkout/pull/1376">actions/checkout#1376</a></li>
      </ul>
      <h2>New Contributors</h2>
      <ul>
      <li><a
      href="https://github.com/megamanics"><code>@​megamanics</code></a> made
      their first contribution in <a
      href="https://redirect.github.com/actions/checkout/pull/1196">actions/checkout#1196</a></li>
      <li><a
      href="https://github.com/DimitriPapadopoulos"><code>@​DimitriPapadopoulos</code></a>
      made their first contribution in <a
      href="https://redirect.github.com/actions/checkout/pull/1287">actions/checkout#1287</a></li>
      <li><a href="https://github.com/dfdez"><code>@​dfdez</code></a> made
      their first contribution in <a
      href="https://redirect.github.com/actions/checkout/pull/1369">actions/checkout#1369</a></li>
      </ul>
      <p><strong>Full Changelog</strong>: <a
      href="https://github.com/actions/checkout/compare/v3...v3.5.3">https://github.com/actions/checkout/compare/v3...v3.5.3</a></p>
      <h2>v3.5.2</h2>
      <h2>What's Changed</h2>
      <ul>
      <li>Fix: Use correct API url / endpoint in GHES by <a
      href="https://github.com/fhammerl"><code>@​fhammerl</code></a> in <a
      href="https://redirect.github.com/actions/checkout/pull/1289">actions/checkout#1289</a>
      based on <a
      href="https://redirect.github.com/actions/checkout/issues/1286">#1286</a>
      by <a href="https://github.com/1newsr"><code>@​1newsr</code></a></li>
      </ul>
      <p><strong>Full Changelog</strong>: <a
      href="https://github.com/actions/checkout/compare/v3.5.1...v3.5.2">https://github.com/actions/checkout/compare/v3.5.1...v3.5.2</a></p>
      <h2>v3.5.1</h2>
      <h2>What's Changed</h2>
      <ul>
      <li>Improve checkout performance on Windows runners by upgrading
      <code>@​actions/github</code> dependency by <a
      href="https://github.com/BrettDong"><code>@​BrettDong</code></a> in <a
      href="https://redirect.github.com/actions/checkout/pull/1246">actions/checkout#1246</a></li>
      </ul>
      <h2>New Contributors</h2>
      <ul>
      <li><a href="https://github.com/BrettDong"><code>@​BrettDong</code></a>
      made their first contribution in <a
      href="https://redirect.github.com/actions/checkout/pull/1246">actions/checkout#1246</a></li>
      </ul>
      <!-- raw HTML omitted -->
      </blockquote>
      <p>... (truncated)</p>
      </details>
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/actions/checkout/commit/692973e3d937129bcbf40652eb9f2f61becf3332"><code>692973e</code></a>
      Prepare 4.1.7 release (<a
      href="https://redirect.github.com/actions/checkout/issues/1775">#1775</a>)</li>
      <li><a
      href="https://github.com/actions/checkout/commit/6ccd57f4c5d15bdc2fef309bd9fb6cc9db2ef1c6"><code>6ccd57f</code></a>
      Pin actions/checkout's own workflows to a known, good, stable version.
      (<a
      href="https://redirect.github.com/actions/checkout/issues/1776">#1776</a>)</li>
      <li><a
      href="https://github.com/actions/checkout/commit/b17fe1e4d59a9d1d95a7aead5e6fcd13e50939a5"><code>b17fe1e</code></a>
      Handle hidden refs (<a
      href="https://redirect.github.com/actions/checkout/issues/1774">#1774</a>)</li>
      <li><a
      href="https://github.com/actions/checkout/commit/b80ff79f1755d06ba70441c368a6fe801f5f3a62"><code>b80ff79</code></a>
      Bump actions/checkout from 3 to 4 (<a
      href="https://redirect.github.com/actions/checkout/issues/1697">#1697</a>)</li>
      <li><a
      href="https://github.com/actions/checkout/commit/b1ec3021b8fa02164da82ca1557d017d83b0e179"><code>b1ec302</code></a>
      Bump the minor-npm-dependencies group across 1 directory with 4 updates
      (<a
      href="https://redirect.github.com/actions/checkout/issues/1739">#1739</a>)</li>
      <li><a
      href="https://github.com/actions/checkout/commit/a5ac7e51b41094c92402da3b24376905380afc29"><code>a5ac7e5</code></a>
      Update for 4.1.6 release (<a
      href="https://redirect.github.com/actions/checkout/issues/1733">#1733</a>)</li>
      <li><a
      href="https://github.com/actions/checkout/commit/24ed1a352802348c9e4e8d13de9177fb95b537ba"><code>24ed1a3</code></a>
      Check platform for extension (<a
      href="https://redirect.github.com/actions/checkout/issues/1732">#1732</a>)</li>
      <li><a
      href="https://github.com/actions/checkout/commit/44c2b7a8a4ea60a981eaca3cf939b5f4305c123b"><code>44c2b7a</code></a>
      README: Suggest <code>user.email</code> to be
      `41898282+github-actions[bot]<a
      href="https://github.com/users"><code>@​users</code></a>.norepl...</li>
      <li><a
      href="https://github.com/actions/checkout/commit/8459bc0c7e3759cdf591f513d9f141a95fef0a8f"><code>8459bc0</code></a>
      Bump actions/upload-artifact from 2 to 4 (<a
      href="https://redirect.github.com/actions/checkout/issues/1695">#1695</a>)</li>
      <li><a
      href="https://github.com/actions/checkout/commit/3f603f6d5e9f40714f97b2f017aa0df2a443192a"><code>3f603f6</code></a>
      Bump actions/setup-node from 1 to 4 (<a
      href="https://redirect.github.com/actions/checkout/issues/1696">#1696</a>)</li>
      <li>Additional commits viewable in <a
      href="https://github.com/actions/checkout/compare/v2...v4">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      Updates `peter-evans/create-pull-request` from 6.1.0 to 7.0.1
      <details>
      <summary>Release notes</summary>
      <p><em>Sourced from <a
      href="https://github.com/peter-evans/create-pull-request/releases">peter-evans/create-pull-request's
      releases</a>.</em></p>
      <blockquote>
      <h2>Create Pull Request v7.0.1</h2>
      <p>:gear:️ Fixes <a
      href="https://redirect.github.com/peter-evans/create-pull-request/issues/3311">an
      issue</a> affecting one particular use case where the action fails on
      <code>diff --stat</code> with <code>fatal: ambiguous
      argument</code>.</p>
      <h2>What's Changed</h2>
      <ul>
      <li>build(deps): bump peter-evans/create-pull-request from 6 to 7 by <a
      href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
      href="https://redirect.github.com/peter-evans/create-pull-request/pull/3283">peter-evans/create-pull-request#3283</a></li>
      <li>build(deps-dev): bump <code>@​types/node</code> from 18.19.46 to
      18.19.48 by <a
      href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
      href="https://redirect.github.com/peter-evans/create-pull-request/pull/3288">peter-evans/create-pull-request#3288</a></li>
      <li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
      7.17.0 to 7.18.0 by <a
      href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
      href="https://redirect.github.com/peter-evans/create-pull-request/pull/3289">peter-evans/create-pull-request#3289</a></li>
      <li>build(deps-dev): bump eslint-plugin-import from 2.29.1 to 2.30.0 by
      <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
      <a
      href="https://redirect.github.com/peter-evans/create-pull-request/pull/3290">peter-evans/create-pull-request#3290</a></li>
      <li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
      from 7.17.0 to 7.18.0 by <a
      href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
      href="https://redirect.github.com/peter-evans/create-pull-request/pull/3291">peter-evans/create-pull-request#3291</a></li>
      <li>fix: handle ambiguous argument failure on diff stat by <a
      href="https://github.com/peter-evans"><code>@​peter-evans</code></a> in
      <a
      href="https://redirect.github.com/peter-evans/create-pull-request/pull/3312">peter-evans/create-pull-request#3312</a></li>
      </ul>
      <p><strong>Full Changelog</strong>: <a
      href="https://github.com/peter-evans/create-pull-request/compare/v7.0.0...v7.0.1">https://github.com/peter-evans/create-pull-request/compare/v7.0.0...v7.0.1</a></p>
      <h2>Create Pull Request v7.0.0</h2>
      <p>:sparkles:
      
       Now supports commit signing with bot-generated tokens! See
      &quot;What's new&quot; below. :writing_hand::robot:</p>
      <h3>Behaviour changes</h3>
      <ul>
      <li>Action input <code>git-token</code> has been renamed
      <code>branch-token</code>, to be more clear about its purpose. The
      <code>branch-token</code> is the token that the action will use to
      create and update the branch.</li>
      <li>The action now handles requests that have been rate-limited by
      GitHub. Requests hitting a primary rate limit will retry twice, for a
      total of three attempts. Requests hitting a secondary rate limit will
      not be retried.</li>
      <li>The <code>pull-request-operation</code> output now returns
      <code>none</code> when no operation was executed.</li>
      <li>Removed deprecated output environment variable
      <code>PULL_REQUEST_NUMBER</code>. Please use the
      <code>pull-request-number</code> action output instead.</li>
      </ul>
      <h3>What's new</h3>
      <ul>
      <li>The action can now sign commits as <code>github-actions[bot]</code>
      when using <code>GITHUB_TOKEN</code>, or your own bot when using <a
      href="https://github.com/peter-evans/create-pull-request/blob/HEAD/docs/concepts-guidelines.md#authenticating-with-github-app-generated-tokens">GitHub
      App tokens</a>. See <a
      href="https://github.com/peter-evans/create-pull-request/blob/HEAD/docs/concepts-guidelines.md#commit-signature-verification-for-bots">commit
      signing</a> for details.</li>
      <li>Action input <code>draft</code> now accepts a new value
      <code>always-true</code>. This will set the pull request to draft status
      when the pull request is updated, as well as on creation.</li>
      <li>A new action input <code>maintainer-can-modify</code> indicates
      whether <a
      href="https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork">maintainers
      can modify</a> the pull request. The default is <code>true</code>, which
      retains the existing behaviour of the action.</li>
      <li>A new output <code>pull-request-commits-verified</code> returns
      <code>true</code> or <code>false</code>, indicating whether GitHub
      considers the signature of the branch's commits to be verified.</li>
      </ul>
      <h2>What's Changed</h2>
      <ul>
      <li>build(deps-dev): bump <code>@​types/node</code> from 18.19.36 to
      18.19.39 by <a
      href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
      href="https://redirect.github.com/peter-evans/create-pull-request/pull/3000">peter-evans/create-pull-request#3000</a></li>
      <li>build(deps-dev): bump ts-jest from 29.1.5 to 29.2.0 by <a
      href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
      href="https://redirect.github.com/peter-evans/create-pull-request/pull/3008">peter-evans/create-pull-request#3008</a></li>
      <li>build(deps-dev): bump prettier from 3.3.2 to 3.3.3 by <a
      href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
      href="https://redirect.github.com/peter-evans/create-pull-request/pull/3018">peter-evans/create-pull-request#3018</a></li>
      <li>build(deps-dev): bump ts-jest from 29.2.0 to 29.2.2 by <a
      href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
      href="https://redirect.github.com/peter-evans/create-pull-request/pull/3019">peter-evans/create-pull-request#3019</a></li>
      <li>build(deps-dev): bump eslint-plugin-prettier from 5.1.3 to 5.2.1 by
      <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
      <a
      href="https://redirect.github.com/peter-evans/create-pull-request/pull/3035">peter-evans/create-pull-request#3035</a></li>
      <li>build(deps-dev): bump <code>@​types/node</code> from 18.19.39 to
      18.19.41 by <a
      href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
      href="https://redirect.github.com/peter-evans/create-pull-request/pull/3037">peter-evans/create-pull-request#3037</a></li>
      <li>build(deps): bump undici from 6.19.2 to 6.19.4 by <a
      href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
      href="https://redirect.github.com/peter-evans/create-pull-request/pull/3036">peter-evans/create-pull-request#3036</a></li>
      <li>build(deps-dev): bump ts-jest from 29.2.2 to 29.2.3 by <a
      href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
      href="https://redirect.github.com/peter-evans/create-pull-request/pull/3038">peter-evans/create-pull-request#3038</a></li>
      <li>build(deps-dev): bump <code>@​types/node</code> from 18.19.41 to
      18.19.42 by <a
      href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
      href="https://redirect.github.com/peter-evans/create-pull-request/pull/3070">peter-evans/create-pull-request#3070</a></li>
      <li>build(deps): bump undici from 6.19.4 to 6.19.5 by <a
      href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
      href="https://redirect.github.com/peter-evans/create-pull-request/pull/3086">peter-evans/create-pull-request#3086</a></li>
      <li>build(deps-dev): bump <code>@​types/node</code> from 18.19.42 to
      18.19.43 by <a
      href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
      href="https://redirect.github.com/peter-evans/create-pull-request/pull/3087">peter-evans/create-pull-request#3087</a></li>
      <li>build(deps-dev): bump ts-jest from 29.2.3 to 29.2.4 by <a
      href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
      href="https://redirect.github.com/peter-evans/create-pull-request/pull/3088">peter-evans/create-pull-request#3088</a></li>
      <li>build(deps): bump undici from 6.19.5 to 6.19.7 by <a
      href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
      href="https://redirect.github.com/peter-evans/create-pull-request/pull/3145">peter-evans/create-pull-request#3145</a></li>
      <li>build(deps-dev): bump <code>@​types/node</code> from 18.19.43 to
      18.19.44 by <a
      href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
      href="https://redirect.github.com/peter-evans/create-pull-request/pull/3144">peter-evans/create-pull-request#3144</a></li>
      <li>Update distribution by <a
      href="https://github.com/actions-bot"><code>@​actions-bot</code></a> in
      <a
      href="https://redirect.github.com/peter-evans/create-pull-request/pull/3154">peter-evans/create-pull-request#3154</a></li>
      <li>build(deps): bump undici from 6.19.7 to 6.19.8 by <a
      href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
      href="https://redirect.github.com/peter-evans/create-pull-request/pull/3213">peter-evans/create-pull-request#3213</a></li>
      <li>build(deps-dev): bump <code>@​types/node</code> from 18.19.44 to
      18.19.45 by <a
      href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
      href="https://redirect.github.com/peter-evans/create-pull-request/pull/3214">peter-evans/create-pull-request#3214</a></li>
      <li>Update distribution by <a
      href="https://github.com/actions-bot"><code>@​actions-bot</code></a> in
      <a
      href="https://redirect.github.com/peter-evans/create-pull-request/pull/3221">peter-evans/create-pull-request#3221</a></li>
      </ul>
      <!-- raw HTML omitted -->
      </blockquote>
      <p>... (truncated)</p>
      </details>
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/peter-evans/create-pull-request/commit/8867c4aba1b742c39f8d0ba35429c2dfa4b6cb20"><code>8867c4a</code></a>
      fix: handle ambiguous argument failure on diff stat (<a
      href="https://redirect.github.com/peter-evans/create-pull-request/issues/3312">#3312</a>)</li>
      <li><a
      href="https://github.com/peter-evans/create-pull-request/commit/6073f5434ba635ff2f4390cddac0059ab04d9409"><code>6073f54</code></a>
      build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code> (<a
      href="https://redirect.github.com/peter-evans/create-pull-request/issues/3291">#3291</a>)</li>
      <li><a
      href="https://github.com/peter-evans/create-pull-request/commit/6d01b5601c7aca7ad0eb2f8532106269ac38b584"><code>6d01b56</code></a>
      build(deps-dev): bump eslint-plugin-import from 2.29.1 to 2.30.0 (<a
      href="https://redirect.github.com/peter-evans/create-pull-request/issues/3290">#3290</a>)</li>
      <li><a
      href="https://github.com/peter-evans/create-pull-request/commit/25cf8451c34bbbcbb3ef973b252eb91ec1ad8be9"><code>25cf845</code></a>
      build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
      7.17.0 to 7.18.0 (<a
      href="https://redirect.github.com/peter-evans/create-pull-request/issues/3289">#3289</a>)</li>
      <li><a
      href="https://github.com/peter-evans/create-pull-request/commit/d87b980a0ebf44e8ed8ef733b28171c81ca501af"><code>d87b980</code></a>
      build(deps-dev): bump <code>@​types/node</code> from 18.19.46 to
      18.19.48 (<a
      href="https://redirect.github.com/peter-evans/create-pull-request/issues/3288">#3288</a>)</li>
      <li><a
      href="https://github.com/peter-evans/create-pull-request/commit/119d131ea9fd0db1802246d0098211de13a26406"><code>119d131</code></a>
      build(deps): bump peter-evans/create-pull-request from 6 to 7 (<a
      href="https://redirect.github.com/peter-evans/create-pull-request/issues/3283">#3283</a>)</li>
      <li><a
      href="https://github.com/peter-evans/create-pull-request/commit/73e6230af4af8faaeddac4d3f16e25f8a2bd8e4b"><code>73e6230</code></a>
      docs: update readme</li>
      <li><a
      href="https://github.com/peter-evans/create-pull-request/commit/c0348e860fc89e6cc1f5b623f7b1140d6ee9a2d5"><code>c0348e8</code></a>
      ci: add v7 to workflow</li>
      <li><a
      href="https://github.com/peter-evans/create-pull-request/commit/4320041ed380b20e97d388d56a7fb4f9b8c20e79"><code>4320041</code></a>
      feat: signed commits (v7) (<a
      href="https://redirect.github.com/peter-evans/create-pull-request/issues/3057">#3057</a>)</li>
      <li><a
      href="https://github.com/peter-evans/create-pull-request/commit/0c2a66fe4af462aa0761939bd32efbdd46592737"><code>0c2a66f</code></a>
      build(deps-dev): bump ts-jest from 29.2.4 to 29.2.5 (<a
      href="https://redirect.github.com/peter-evans/create-pull-request/issues/3256">#3256</a>)</li>
      <li>Additional commits viewable in <a
      href="https://github.com/peter-evans/create-pull-request/compare/c5a7806660adbe173f04e3e038b0ccdcd758773c...8867c4aba1b742c39f8d0ba35429c2dfa4b6cb20">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      
      Dependabot will resolve any conflicts with this PR as long as you don't
      alter it yourself. You can also trigger a rebase manually by commenting
      `@dependabot rebase`.
      
      [//]: # (dependabot-automerge-start)
      [//]: # (dependabot-automerge-end)
      
      ---
      
      <details>
      <summary>Dependabot commands and options</summary>
      <br />
      
      You can trigger Dependabot actions by commenting on this PR:
      - `@dependabot rebase` will rebase this PR
      - `@dependabot recreate` will recreate this PR, overwriting any edits
      that have been made to it
      - `@dependabot merge` will merge this PR after your CI passes on it
      - `@dependabot squash and merge` will squash and merge this PR after
      your CI passes on it
      - `@dependabot cancel merge` will cancel a previously requested merge
      and block automerging
      - `@dependabot reopen` will reopen this PR if it is closed
      - `@dependabot close` will close this PR and stop Dependabot recreating
      it. You can achieve the same result by closing it manually
      - `@dependabot show <dependency name> ignore conditions` will show all
      of the ignore conditions of the specified dependency
      - `@dependabot ignore <dependency name> major version` will close this
      group update PR and stop Dependabot creating any more for the specific
      dependency's major version (unless you unignore this specific
      dependency's major version or upgrade to it yourself)
      - `@dependabot ignore <dependency name> minor version` will close this
      group update PR and stop Dependabot creating any more for the specific
      dependency's minor version (unless you unignore this specific
      dependency's minor version or upgrade to it yourself)
      - `@dependabot ignore <dependency name>` will close this group update PR
      and stop Dependabot creating any more for the specific dependency
      (unless you unignore this specific dependency or upgrade to it yourself)
      - `@dependabot unignore <dependency name>` will remove all of the ignore
      conditions of the specified dependency
      - `@dependabot unignore <dependency name> <ignore condition>` will
      remove the ignore condition of the specified dependency and ignore
      conditions
      
      
      </details>
      
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    • Vedhavyas Singareddi's avatar
      Update `RuntimeVerison` type and use `system_version` to derive extrinsics... · 9930d213
      Vedhavyas Singareddi authored
      Update `RuntimeVerison` type and use `system_version` to derive extrinsics root `StateVersion` instead of `V0` (#4257)
      
      This PR 
      - Renames `RuntimeVersion::state_version` to `system_version`
      - Uses `Runtime::system_version` to derive extrinsics root
      `StateVersion` instead of default `StateVersion::V0`
      
      This PR should not be breaking any existing chains so long as they use
      same `RuntimeVersion::state_version` for `Runtime::system_version`
      
      Using `RuntimeVersion::system_version = 2` will make the extrinsics root
      to use `StateVersion::V1` instead of `V0`
      
      RFC for this change - https://github.com/polkadot-fellows/RFCs/pull/42
      
      ---------
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      Co-authored-by: default avatarKoute <koute@users.noreply.github.com>
      Co-authored-by: default avatarNazar Mokrynskyi <nazar@mokrynskyi.com>
  5. Sep 09, 2024
    • thiolliere's avatar
      frame pallet macro: fix span for error on wrong returned type. (#5580) · aec2b105
      thiolliere authored
      
      Explicitly give the types in some generated code so that the error shows
      up good when user code is wrong.
      
      ---------
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
    • PG Herveou's avatar
      [pallet-revive] move event topics in event's body (#5640) · f3f377f5
      PG Herveou authored
      Fix https://github.com/paritytech/polkadot-sdk/issues/5629
    • Oliver Tale-Yazdi's avatar
      Install prdoc from Parity fork (#5625) · d2e962fc
      Oliver Tale-Yazdi authored
      
      Prdoc is now published as a Parity fork under the
      [`parity-prdoc`](https://crates.io/crates/parity-prdoc) crate after the
      directions diverged from the ideas of the original creator (discussions
      [here](https://github.com/paritytech/prdoc/pull/40) and
      [here](https://github.com/paritytech/prdoc/issues/36)).
      Now updating the install instructions here.
      
      ---------
      
      Signed-off-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
    • Oliver Tale-Yazdi's avatar
      [Bot] Revive prdoc bot (#5648) · 2d4e89f0
      Oliver Tale-Yazdi authored
      
      Prdoc bot was deleted in
      https://github.com/paritytech/polkadot-sdk/pull/5457 just after being
      added in https://github.com/paritytech/polkadot-sdk/pull/5331 without
      replacement.
      Now bringing it back until it is integrated into the new command
      structure.
      
      Formatting is now also fixed, such that the title is always first and
      the description renders correctly.
      
      ---------
      
      Signed-off-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
    • Nazar Mokrynskyi's avatar
      Allow to disable gap creation during block import (#5343) · 030cb4a7
      Nazar Mokrynskyi authored
      
      This feature is helpful for us with custom sync protocol that is similar
      to Warp sync except we do not ever sync the gap and don't want it to
      exist in the first place (see
      https://github.com/paritytech/polkadot-sdk/issues/5333 and its
      references for motivation).
      
      Otherwise we had to resort to this:
      https://github.com/autonomys/polkadot-sdk/commit/d5375125ca7c59fcc1ac72dc1b2ac251cbc80323
      
      ---------
      
      Co-authored-by: default avatarDavide Galassi <davxy@datawok.net>
    • Bastian Köcher's avatar
      pallet-utility: Improve weight annotations (#5644) · f4eb4177
      Bastian Köcher authored
      
      Prevent allocations when calculating the weights.
      
      ---------
      
      Signed-off-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
      Co-authored-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
    • Nick Vikeras's avatar
      Plumb RPC listener up to caller (#5038) · c72f9ab5
      Nick Vikeras authored
      
      # Description
      
      This PR allows the RPC server's socket address to be returned when
      initializing the server. This allows the library consumer to easily
      programmatically determine which port the RPC server is listening on. My
      use case for this is automated testing. I'd like to be able to simply
      specify that the server bind to port '0' and then test against whatever
      port the OS assigns dynamically. I will have many RPC servers running in
      parallel across many tests within a single process, and I don't want to
      have to deal with port conflicts.
      
      ## Integration
      
      Integration is straightforward. My main concern is that I am making
      non-backwards-compatible changes to public library functions. Let me
      know if I should leave backwards-compatible wrappers in place for
      any/all of the public functions that were modified.
      
      ## Review Notes
      The rationale for making the new listen_addresses field on the
      RpcHandlers struct a ```[MultiAddr]``` rather than ```SocketAddr``` is
      because I wanted it to be transport-agnostic as well as capable of
      supporting multiple listening addresses in case that is ever required by
      the RPC server in the future.
      
      # Checklist
      
      * [x] My PR includes a detailed description as outlined in the
      "Description" and its two subsections above.
      * [ ] My PR follows the [labeling requirements](CONTRIBUTING.md#Process)
      of this project (at minimum one label for `T`
        required)
      * External contributors: ask maintainers to put the right label on your
      PR.
      * [x] I have made corresponding changes to the documentation (if
      applicable)
      * [ ] I have added tests that prove my fix is effective or that my
      feature works (if applicable)
      
      1. I didn't understand what the 'T' label meant. Am I supposed to open a
      github Issue for my PR?
      2. I didn't see an easy way to add tests since the functions I am
      modifying are not directly called by any tests.
      
      ---------
      
      Co-authored-by: default avatarNiklas Adolfsson <niklasadolfsson1@gmail.com>
    • Oliver Tale-Yazdi's avatar
      [CI] Remove duplicate jobs (#5602) · a3eda0a1
      Oliver Tale-Yazdi authored
      All of these things are already tested in Github Actions:
      https://github.com/paritytech/polkadot-sdk/blob/b3c2a25b
      
      /.github/workflows/checks-quick.yml#L50
      
      Q: the `job-starter` seems to be used by tests, so am keeping it, but
      not sure how useful it is.
      
      ---------
      
      Co-authored-by: default avatarAlexander Samusev <41779041+alvicsam@users.noreply.github.com>
      Co-authored-by: default avataralvicsam <alvicsam@gmail.com>
    • dependabot[bot]'s avatar
      Bump proc-macro2 from 1.0.82 to 1.0.86 (#5638) · f5783cc6
      dependabot[bot] authored
      
      Bumps [proc-macro2](https://github.com/dtolnay/proc-macro2) from 1.0.82
      to 1.0.86.
      <details>
      <summary>Release notes</summary>
      <p><em>Sourced from <a
      href="https://github.com/dtolnay/proc-macro2/releases">proc-macro2's
      releases</a>.</em></p>
      <blockquote>
      <h2>1.0.86</h2>
      <ul>
      <li>Documentation improvements</li>
      </ul>
      <h2>1.0.85</h2>
      <ul>
      <li>Mark some tests as only for 64-bit targets (<a
      href="https://redirect.github.com/dtolnay/proc-macro2/issues/463">#463</a>)</li>
      </ul>
      <h2>1.0.84</h2>
      <ul>
      <li>Documentation improvements (<a
      href="https://redirect.github.com/dtolnay/proc-macro2/issues/455">#455</a>,
      thanks <a
      href="https://github.com/CensoredUsername"><code>@​CensoredUsername</code></a>)</li>
      </ul>
      <h2>1.0.83</h2>
      <ul>
      <li>Optimize the representation of <code>Ident</code> (<a
      href="https://redirect.github.com/dtolnay/proc-macro2/issues/462">#462</a>)</li>
      </ul>
      </blockquote>
      </details>
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/dtolnay/proc-macro2/commit/aa9476b27932ae1b1b50bbfe0530b3b261fc1b72"><code>aa9476b</code></a>
      Release 1.0.86</li>
      <li><a
      href="https://github.com/dtolnay/proc-macro2/commit/19613587b70633e8bd383dd2fc29856d2d080f45"><code>1961358</code></a>
      Merge pull request <a
      href="https://redirect.github.com/dtolnay/proc-macro2/issues/466">#466</a>
      from dtolnay/buildrs</li>
      <li><a
      href="https://github.com/dtolnay/proc-macro2/commit/e1bd2cc29da09be421555bb0e1156c5e2b87df5d"><code>e1bd2cc</code></a>
      Bring build script comments up to date</li>
      <li><a
      href="https://github.com/dtolnay/proc-macro2/commit/5b271279521e11ac6eada5435e5a8d87f46d3619"><code>5b27127</code></a>
      Merge pull request <a
      href="https://redirect.github.com/dtolnay/proc-macro2/issues/465">#465</a>
      from dtolnay/ignorereason</li>
      <li><a
      href="https://github.com/dtolnay/proc-macro2/commit/0da4629757024ac6dac1680ba3be44bac24af809"><code>0da4629</code></a>
      Fill in ignore reasons in all #[ignore] attributes</li>
      <li><a
      href="https://github.com/dtolnay/proc-macro2/commit/5ee1cabadb40abe12abe27e3b34de8fc6f60bc0a"><code>5ee1cab</code></a>
      Release 1.0.85</li>
      <li><a
      href="https://github.com/dtolnay/proc-macro2/commit/aa64c2007390a33d4edbc07aa3e576848ae3d653"><code>aa64c20</code></a>
      Merge pull request <a
      href="https://redirect.github.com/dtolnay/proc-macro2/issues/464">#464</a>
      from dtolnay/testsize</li>
      <li><a
      href="https://github.com/dtolnay/proc-macro2/commit/bc9f4d938058be43d38f921f34f48b94a25278b7"><code>bc9f4d9</code></a>
      Ignore size tests on non-64bit target</li>
      <li><a
      href="https://github.com/dtolnay/proc-macro2/commit/1160ec3c7d723e115c5acf2b4e9f00c2c049e84a"><code>1160ec3</code></a>
      Make size tests #[ignore] in cfg(randomize_layout)</li>
      <li><a
      href="https://github.com/dtolnay/proc-macro2/commit/33c95785826bbd1fa353c48989dfc5a7ca62f54c"><code>33c9578</code></a>
      Release 1.0.84</li>
      <li>Additional commits viewable in <a
      href="https://github.com/dtolnay/proc-macro2/compare/1.0.82...1.0.86">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      
      [![Dependabot compatibility
      score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=proc-macro2&package-manager=cargo&previous-version=1.0.82&new-version=1.0.86)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
      
      Dependabot will resolve any conflicts with this PR as long as you don't
      alter it yourself. You can also trigger a rebase manually by commenting
      `@dependabot rebase`.
      
      [//]: # (dependabot-automerge-start)
      [//]: # (dependabot-automerge-end)
      
      ---
      
      <details>
      <summary>Dependabot commands and options</summary>
      <br />
      
      You can trigger Dependabot actions by commenting on this PR:
      - `@dependabot rebase` will rebase this PR
      - `@dependabot recreate` will recreate this PR, overwriting any edits
      that have been made to it
      - `@dependabot merge` will merge this PR after your CI passes on it
      - `@dependabot squash and merge` will squash and merge this PR after
      your CI passes on it
      - `@dependabot cancel merge` will cancel a previously requested merge
      and block automerging
      - `@dependabot reopen` will reopen this PR if it is closed
      - `@dependabot close` will close this PR and stop Dependabot recreating
      it. You can achieve the same result by closing it manually
      - `@dependabot show <dependency name> ignore conditions` will show all
      of the ignore conditions of the specified dependency
      - `@dependabot ignore this major version` will close this PR and stop
      Dependabot creating any more for this major version (unless you reopen
      the PR or upgrade to it yourself)
      - `@dependabot ignore this minor version` will close this PR and stop
      Dependabot creating any more for this minor version (unless you reopen
      the PR or upgrade to it yourself)
      - `@dependabot ignore this dependency` will close this PR and stop
      Dependabot creating any more for this dependency (unless you reopen the
      PR or upgrade to it yourself)
      
      
      </details>
      
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    • dependabot[bot]'s avatar
      Bump lazy_static from 1.4.0 to 1.5.0 (#5639) · def35b92
      dependabot[bot] authored
      
      Bumps [lazy_static](https://github.com/rust-lang-nursery/lazy-static.rs)
      from 1.4.0 to 1.5.0.
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/rust-lang-nursery/lazy-static.rs/commit/be7c1c43f264699f956b70ce8e29941bd1e61bde"><code>be7c1c4</code></a>
      point readme version to 1.5.0</li>
      <li><a
      href="https://github.com/rust-lang-nursery/lazy-static.rs/commit/8971a27dac57dbef72dd6abb9a55bca795ed58de"><code>8971a27</code></a>
      update readme build badge</li>
      <li><a
      href="https://github.com/rust-lang-nursery/lazy-static.rs/commit/15691ec43162cb50ba02bf39adac38f113688e77"><code>15691ec</code></a>
      Modernize lazy-static infra (<a
      href="https://redirect.github.com/rust-lang-nursery/lazy-static.rs/issues/219">#219</a>)</li>
      <li><a
      href="https://github.com/rust-lang-nursery/lazy-static.rs/commit/2660041abcd4112854d1f6ebff35d421cc24263a"><code>2660041</code></a>
      Merge pull request <a
      href="https://redirect.github.com/rust-lang-nursery/lazy-static.rs/issues/206">#206</a>
      from TheBotlyNoob/master</li>
      <li><a
      href="https://github.com/rust-lang-nursery/lazy-static.rs/commit/6ace970cabd2bda121745d8b12539c93ba2878fd"><code>6ace970</code></a>
      Merge pull request <a
      href="https://redirect.github.com/rust-lang-nursery/lazy-static.rs/issues/216">#216</a>
      from frewsxcv/patch-1</li>
      <li><a
      href="https://github.com/rust-lang-nursery/lazy-static.rs/commit/a2031053df502518e44fec72712db8f927c6ee5c"><code>a203105</code></a>
      Update README.md</li>
      <li><a
      href="https://github.com/rust-lang-nursery/lazy-static.rs/commit/cfd89ac7fcbc3fb8ee5ee20b374b2b1dfb357198"><code>cfd89ac</code></a>
      Update README.md</li>
      <li><a
      href="https://github.com/rust-lang-nursery/lazy-static.rs/commit/fc8e466b94cc9c5f38d6002d3cc865f19a9ca004"><code>fc8e466</code></a>
      Update README.md</li>
      <li><a
      href="https://github.com/rust-lang-nursery/lazy-static.rs/commit/a8afb21bfd9dc53b51111bd1d9f19c2275fc97fe"><code>a8afb21</code></a>
      Update README.md</li>
      <li><a
      href="https://github.com/rust-lang-nursery/lazy-static.rs/commit/41fa23457d65b5c4688a42228734fd8479214a83"><code>41fa234</code></a>
      Update README to indicate how to replace with
      <code>std::sync::OnceLock</code></li>
      <li>Additional commits viewable in <a
      href="https://github.com/rust-lang-nursery/lazy-static.rs/compare/1.4.0...1.5.0">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      
      [![Dependabot compatibility
      score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=lazy_static&package-manager=cargo&previous-version=1.4.0&new-version=1.5.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
      
      Dependabot will resolve any conflicts with this PR as long as you don't
      alter it yourself. You can also trigger a rebase manually by commenting
      `@dependabot rebase`.
      
      [//]: # (dependabot-automerge-start)
      [//]: # (dependabot-automerge-end)
      
      ---
      
      <details>
      <summary>Dependabot commands and options</summary>
      <br />
      
      You can trigger Dependabot actions by commenting on this PR:
      - `@dependabot rebase` will rebase this PR
      - `@dependabot recreate` will recreate this PR, overwriting any edits
      that have been made to it
      - `@dependabot merge` will merge this PR after your CI passes on it
      - `@dependabot squash and merge` will squash and merge this PR after
      your CI passes on it
      - `@dependabot cancel merge` will cancel a previously requested merge
      and block automerging
      - `@dependabot reopen` will reopen this PR if it is closed
      - `@dependabot close` will close this PR and stop Dependabot recreating
      it. You can achieve the same result by closing it manually
      - `@dependabot show <dependency name> ignore conditions` will show all
      of the ignore conditions of the specified dependency
      - `@dependabot ignore this major version` will close this PR and stop
      Dependabot creating any more for this major version (unless you reopen
      the PR or upgrade to it yourself)
      - `@dependabot ignore this minor version` will close this PR and stop
      Dependabot creating any more for this minor version (unless you reopen
      the PR or upgrade to it yourself)
      - `@dependabot ignore this dependency` will close this PR and stop
      Dependabot creating any more for this dependency (unless you reopen the
      PR or upgrade to it yourself)
      
      
      </details>
      
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    • dependabot[bot]'s avatar
      Bump the known_good_semver group with 3 updates (#5636) · 083f5273
      dependabot[bot] authored
      
      Bumps the known_good_semver group with 3 updates:
      [serde](https://github.com/serde-rs/serde),
      [serde_derive](https://github.com/serde-rs/serde) and
      [serde_json](https://github.com/serde-rs/json).
      
      Updates `serde` from 1.0.209 to 1.0.210
      <details>
      <summary>Release notes</summary>
      <p><em>Sourced from <a
      href="https://github.com/serde-rs/serde/releases">serde's
      releases</a>.</em></p>
      <blockquote>
      <h2>v1.0.210</h2>
      <ul>
      <li>Support serializing and deserializing <code>IpAddr</code> and
      <code>SocketAddr</code> in no-std mode on Rust 1.77+ (<a
      href="https://redirect.github.com/serde-rs/serde/issues/2816">#2816</a>,
      thanks <a
      href="https://github.com/MathiasKoch"><code>@​MathiasKoch</code></a>)</li>
      <li>Make <code>serde::ser::StdError</code> and
      <code>serde::de::StdError</code> equivalent to
      <code>core::error::Error</code> on Rust 1.81+ (<a
      href="https://redirect.github.com/serde-rs/serde/issues/2818">#2818</a>)</li>
      </ul>
      </blockquote>
      </details>
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/serde-rs/serde/commit/89c4b02bf32ceae5b17d89f93a452ccc195ca038"><code>89c4b02</code></a>
      Release 1.0.210</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/eeb8e44cda15f929796cd72241b0311e0bd04e67"><code>eeb8e44</code></a>
      Merge pull request <a
      href="https://redirect.github.com/serde-rs/serde/issues/2818">#2818</a>
      from dtolnay/coreerror</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/785c2d9605ee73cc172dfd421228c1dccca984c9"><code>785c2d9</code></a>
      Stabilize no-std StdError trait</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/d549f048e10bcb5e677afaf7b99d0ed3604b113b"><code>d549f04</code></a>
      Reformat parse_ip_impl definition and calls</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/4c0dd63011434905265e2710bb9186e09e4f8ec2"><code>4c0dd63</code></a>
      Delete attr support from core::net deserialization macros</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/26fb1341651c4e0ae4d58c675db3ca2a0d6e12c2"><code>26fb134</code></a>
      Relocate cfg attrs out of parse_ip_impl and parse_socket_impl</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/07e614b52b5ab3387d86d3198e5f52cd1f5ff3cb"><code>07e614b</code></a>
      Merge pull request <a
      href="https://redirect.github.com/serde-rs/serde/issues/2817">#2817</a>
      from dtolnay/corenet</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/b1f899fbe81f070803d9f7ca6e5d1cc3f19c9ea2"><code>b1f899f</code></a>
      Delete doc(cfg) attribute from impls that are supported in no-std</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/b4f860e62767828beb3ef91721b6c56a31f9baad"><code>b4f860e</code></a>
      Merge pull request <a
      href="https://redirect.github.com/serde-rs/serde/issues/2816">#2816</a>
      from MathiasKoch/chore/core-net</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/d940fe1b4934f097b0333dcb87bec5ee308d39cd"><code>d940fe1</code></a>
      Reuse existing Buf wrapper as replacement for std::io::Write</li>
      <li>Additional commits viewable in <a
      href="https://github.com/serde-rs/serde/compare/v1.0.209...v1.0.210">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      Updates `serde_derive` from 1.0.209 to 1.0.210
      <details>
      <summary>Release notes</summary>
      <p><em>Sourced from <a
      href="https://github.com/serde-rs/serde/releases">serde_derive's
      releases</a>.</em></p>
      <blockquote>
      <h2>v1.0.210</h2>
      <ul>
      <li>Support serializing and deserializing <code>IpAddr</code> and
      <code>SocketAddr</code> in no-std mode on Rust 1.77+ (<a
      href="https://redirect.github.com/serde-rs/serde/issues/2816">#2816</a>,
      thanks <a
      href="https://github.com/MathiasKoch"><code>@​MathiasKoch</code></a>)</li>
      <li>Make <code>serde::ser::StdError</code> and
      <code>serde::de::StdError</code> equivalent to
      <code>core::error::Error</code> on Rust 1.81+ (<a
      href="https://redirect.github.com/serde-rs/serde/issues/2818">#2818</a>)</li>
      </ul>
      </blockquote>
      </details>
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/serde-rs/serde/commit/89c4b02bf32ceae5b17d89f93a452ccc195ca038"><code>89c4b02</code></a>
      Release 1.0.210</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/eeb8e44cda15f929796cd72241b0311e0bd04e67"><code>eeb8e44</code></a>
      Merge pull request <a
      href="https://redirect.github.com/serde-rs/serde/issues/2818">#2818</a>
      from dtolnay/coreerror</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/785c2d9605ee73cc172dfd421228c1dccca984c9"><code>785c2d9</code></a>
      Stabilize no-std StdError trait</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/d549f048e10bcb5e677afaf7b99d0ed3604b113b"><code>d549f04</code></a>
      Reformat parse_ip_impl definition and calls</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/4c0dd63011434905265e2710bb9186e09e4f8ec2"><code>4c0dd63</code></a>
      Delete attr support from core::net deserialization macros</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/26fb1341651c4e0ae4d58c675db3ca2a0d6e12c2"><code>26fb134</code></a>
      Relocate cfg attrs out of parse_ip_impl and parse_socket_impl</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/07e614b52b5ab3387d86d3198e5f52cd1f5ff3cb"><code>07e614b</code></a>
      Merge pull request <a
      href="https://redirect.github.com/serde-rs/serde/issues/2817">#2817</a>
      from dtolnay/corenet</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/b1f899fbe81f070803d9f7ca6e5d1cc3f19c9ea2"><code>b1f899f</code></a>
      Delete doc(cfg) attribute from impls that are supported in no-std</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/b4f860e62767828beb3ef91721b6c56a31f9baad"><code>b4f860e</code></a>
      Merge pull request <a
      href="https://redirect.github.com/serde-rs/serde/issues/2816">#2816</a>
      from MathiasKoch/chore/core-net</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/d940fe1b4934f097b0333dcb87bec5ee308d39cd"><code>d940fe1</code></a>
      Reuse existing Buf wrapper as replacement for std::io::Write</li>
      <li>Additional commits viewable in <a
      href="https://github.com/serde-rs/serde/compare/v1.0.209...v1.0.210">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      Updates `serde_json` from 1.0.127 to 1.0.128
      <details>
      <summary>Release notes</summary>
      <p><em>Sourced from <a
      href="https://github.com/serde-rs/json/releases">serde_json's
      releases</a>.</em></p>
      <blockquote>
      <h2>1.0.128</h2>
      <ul>
      <li>Support serializing maps containing 128-bit integer keys to
      serde_json::Value (<a
      href="https://redirect.github.com/serde-rs/json/issues/1188">#1188</a>,
      thanks <a
      href="https://github.com/Mrreadiness"><code>@​Mrreadiness</code></a>)</li>
      </ul>
      </blockquote>
      </details>
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/serde-rs/json/commit/d96b1d9b643b49a0bb92a8cf280daf6aa08f37cc"><code>d96b1d9</code></a>
      Release 1.0.128</li>
      <li><a
      href="https://github.com/serde-rs/json/commit/599228d5dc52a0f1595fe4bd901821f70d0317a5"><code>599228d</code></a>
      Merge pull request <a
      href="https://redirect.github.com/serde-rs/json/issues/1188">#1188</a>
      from Mrreadiness/feat/add-hashmap-key-128-serializer</li>
      <li><a
      href="https://github.com/serde-rs/json/commit/5416cee6c5ad355907f6e9d5f6039b994c69f768"><code>5416cee</code></a>
      feat: add support for 128 bit HashMap key serialization</li>
      <li><a
      href="https://github.com/serde-rs/json/commit/27a4ca9d7a62394fe8f0103f3d91de59f055a4c4"><code>27a4ca9</code></a>
      Upload CI Cargo.lock for reproducing failures</li>
      <li>See full diff in <a
      href="https://github.com/serde-rs/json/compare/1.0.127...1.0.128">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      
      Dependabot will resolve any conflicts with this PR as long as you don't
      alter it yourself. You can also trigger a rebase manually by commenting
      `@dependabot rebase`.
      
      [//]: # (dependabot-automerge-start)
      [//]: # (dependabot-automerge-end)
      
      ---
      
      <details>
      <summary>Dependabot commands and options</summary>
      <br />
      
      You can trigger Dependabot actions by commenting on this PR:
      - `@dependabot rebase` will rebase this PR
      - `@dependabot recreate` will recreate this PR, overwriting any edits
      that have been made to it
      - `@dependabot merge` will merge this PR after your CI passes on it
      - `@dependabot squash and merge` will squash and merge this PR after
      your CI passes on it
      - `@dependabot cancel merge` will cancel a previously requested merge
      and block automerging
      - `@dependabot reopen` will reopen this PR if it is closed
      - `@dependabot close` will close this PR and stop Dependabot recreating
      it. You can achieve the same result by closing it manually
      - `@dependabot show <dependency name> ignore conditions` will show all
      of the ignore conditions of the specified dependency
      - `@dependabot ignore <dependency name> major version` will close this
      group update PR and stop Dependabot creating any more for the specific
      dependency's major version (unless you unignore this specific
      dependency's major version or upgrade to it yourself)
      - `@dependabot ignore <dependency name> minor version` will close this
      group update PR and stop Dependabot creating any more for the specific
      dependency's minor version (unless you unignore this specific
      dependency's minor version or upgrade to it yourself)
      - `@dependabot ignore <dependency name>` will close this group update PR
      and stop Dependabot creating any more for the specific dependency
      (unless you unignore this specific dependency or upgrade to it yourself)
      - `@dependabot unignore <dependency name>` will remove all of the ignore
      conditions of the specified dependency
      - `@dependabot unignore <dependency name> <ignore condition>` will
      remove the ignore condition of the specified dependency and ignore
      conditions
      
      
      </details>
      
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
  6. Sep 08, 2024
    • PG Herveou's avatar
      [pallet-revive] update generic runtime types (#5608) · 868a36bd
      PG Herveou authored
      
      fix #5574
      
      - Use U256 instead of BalanceOf<T> and MomentOf<T> in Ext trait
      - Enforce H256 for T::Hash
      
      The Ext trait still depends on the associated type `T: Config`, we can
      look into refactoring it even more later but even in the current state
      it should not influence how the data is encoded / decoded between the
      contract and the host
      ```
      fn caller(&self) -> Origin<Self::T>;
      -> only use to extract the address of the caller 
      
      fn account_id(&self) -> &AccountIdOf<Self::T>;
       -> only used to expose the address or access the account_id internally   
      
      fn gas_meter(&self) -> &GasMeter<Self::T>;
      fn gas_meter_mut(&mut self) -> &mut GasMeter<Self::T>;
       -> encoding does not depend on T
      
      fn call_runtime(&self, call: <Self::T as Config>::RuntimeCall) -> DispatchResultWithPostInfo;
      -> Substrate specific, just an opaque blob of bytes from the contract's perspective
      
      fn contract_info(&mut self) -> &mut ContractInfo<Self::T>;
      fn transient_storage(&mut self) -> &mut TransientStorage<Self::T>;
      -> gated by #[cfg(any(test, feature = "runtime-benchmarks"))]
      ```
      
      ---------
      
      Co-authored-by: default avatarAlexander Theißen <alex.theissen@me.com>
  7. Sep 07, 2024
    • José Molina Colmenero's avatar
      Add debugging info for `StorageWeightReclaim` (#5594) · 016421ac
      José Molina Colmenero authored
      
      When inspecting the logs we often encounter the following message:
      
      `Benchmarked storage weight smaller than consumed storage weight.
      benchmarked: {benchmarked_weight} consumed: {consumed_weight} unspent:
      {unspent}`
      
      However, it is very hard to guess which call is causing the issue.
      
      With the changes proposed in this PR, information about the call is
      provided so that we can easily identify the source of the problem
      without further delay, and this way work more efficiently in solving the
      issue.
      
      ---------
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
    • clangenb's avatar
      Fix occasional `alloc` not found error in `format_runtime_string!` (#5632) · 96fecc3c
      clangenb authored
      The macro hygiene for the `format_runtime_string!` macro was broken
      since https://github.com/paritytech/polkadot-sdk/pull/5010, which
      resulted in the following build error under certain circumstances:
      
      ```console
        error[E0433]: failed to resolve: use of undeclared crate or module `alloc`
            --> /home/clang/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-benchmarking-36.0.0/src/v1.rs:1738:2
             |
        1738 | /     sp_runtime::format_runtime_string!(
        1739 | |         "\n* Pallet: {}\n\
        1740 | |         * Benchmark: {}\n\
        1741 | |         * Components: {:?}\n\
        ...    |
        1750 | |         error_message,
        1751 | |     )
             | |_____^ use of undeclared crate or module `alloc`
             |
             = note: this error originates in the macro `sp_runtime::format_runtime_string` (in Nightly builds, run with -Z macro-backtrace for more info)
      
        For more information about this error, try `rustc --explain E0433`.
      ```
      
      This bug has been known already, but hasn't been fixed so far, see
      https://github.com/paritytech/polkadot-sdk/issues/5213 and
      https://substrate.stackexchange.com/questions/11786/use-of-undeclared-crate-or-module-alloc-when-upgrade-to-v1-13-0.
      
      I have made a mini rust crate that can reproduce the bug, and it also
      shows that this PR will fix the issue:
      https://github.com/clangenb/sp-runtime-string-test.
  8. Sep 06, 2024