Skip to content
  1. Jun 08, 2020
    • Bastian Köcher's avatar
      Fix transaction pruning in tx-pool (#6276) · 663cd09b
      Bastian Köcher authored
      The `tree_route` generated by the import notification is only from the
      old best block to the new best parent. This means, it does not contain
      the new best block in `enacted()`. We need to prune the transactions of
      the new best block "manually" to fix this bug.
      
      Besides that, this pr also changed the `id` parameter of the `NewBlock`
      chain event to `hash`. The hash of a block is unique in contrast to the
      block number. (Block id can either be number or hash)
      663cd09b
  2. Jun 05, 2020
  3. Jun 04, 2020
    • André Silva's avatar
      8f5a52fe
    • Hernando Castano's avatar
      Use Subscription Manager from `jsonrpc-pubsub` (#6208) · ea1eb4e5
      Hernando Castano authored
      * Bump jsonrpc pubsub, core, http, and ws
      
      Right now these are the packages which _need_ to be updated
      so I can just the latest `jsonrpc-pubsub` code. Once a release
      it cut upstream the rest of the dependencies should be updated
      as well.
      
      * Use jsonrpc-pubsub's SubscriptionManager
      
      This places sc-rpc-api::Subscriptions
      
      * Bump jsonrpc-core outside of sc-rpc-*
      
      * Update client/rpc tests
      
      Right now one of the `author` tests is failing, I
      need to think a bit about how best to fix it.
      
      * Remove Subscriptions manager
      
      There's no need for this implementation since we're
      using the one from `jsonrpc-pubsub` now
      
      * Fix author RPC test
      
      This test used to check for a numerial subscription ID,
      whereas now it uses a string based ID which is the default
      provided by `jsonrpc-pubsub`'s subscription manager.
      
      * Remove unused NumericIdProvider
      
      * Add missing bracket
      
      Removed one too many with that last one, lol
      
      * Bump `jsonrpc` to v14.2
      
      There's an exception though. `jsonrpc-derive` cannot be bumped
      past v14.0.5 just yet since it has a dependency on `quote` pinned
      to v1.0.1. This means that at the moment it won't build on Substrate
      since it's using v1.0.3.
      
      * Track `jsonrpc-derive` master branch
      
      * Bump `quote` version to v1.0.6
      
      * Bump `jsonrpc-derive` to v14.2.1
      
      This includes support for `quote` v1.0.6
      ea1eb4e5
  4. Jun 01, 2020
  5. May 29, 2020
  6. May 26, 2020
  7. May 25, 2020
  8. May 21, 2020
    • André Silva's avatar
      babe: treat epoch_authorship RPC method as unsafe (#6069) · 0ddd5cc2
      André Silva authored
      * service: pass DenyUnsafe to rpc extensions
      
      * node: add DenyUnsafe to rpc full node dependencies
      
      * client: fix whitespace in rpc policy file
      
      * babe: treat epochAuthorship rpc method as unsafe
      
      * babe: add test for unsafe rpc method
      
      * babe: rename babe rpc handler
      
      * service: traitify rpc extension builder
      
      * service: make the rpc extensions builder api non-breaking
      
      * service: revert changes from light node rpc extensions builder
      
      * node: remove unnecessary type in service creation
      
      * service: cleanup with_rpc_extensions implementation
      
      * service: add missing docs to RpcExtensionBuilder
      0ddd5cc2
  9. May 20, 2020
  10. May 18, 2020
  11. May 16, 2020
  12. May 15, 2020
  13. May 12, 2020
  14. May 11, 2020
    • Jon Häggblad's avatar
      Don't repeatedly lookup keys in `babe_epochAuthorship` rpc function (#5962) · 66931028
      Jon Häggblad authored
      * babe: don't repeatedly lookup keys in authorship rpc function
      
      Expose a new function `claim_slot_using_keypars` in Babe so that the `babe_epochAuthorship` can
      lookup authorship for all slots in the epoch without repeatedly looking up keys in the keystore.
      
      Time to run the `babe_epochAuthorship` RPC call goes from 7s to 25ms on a local dev chain on my
      machine.
      
      * babe: pass reference to slice instead of ref to Vec
      
      * babe: fix bunch of clippy warnings
      66931028
  15. May 08, 2020
  16. May 05, 2020
  17. May 04, 2020
    • Wei Tang's avatar
      Correct BABE randomness by calculating InOut bytes directly in pallet (#5876) · a00a4ca5
      Wei Tang authored
      
      
      * vrf: remove Raw* types
      
      * babe: remove Raw* types
      
      * pallet-babe: switch representation of RawVRFOutput to Randomness
      
      * pallet-babe: calculate inout within the pallet
      
      * Remove make_transcript duplication
      
      * Bump spec version
      
      * Fix frame tests
      
      * and_then -> map
      
      * Always enable u64_backend
      
      * Fix nostd compile
      
      * fix import: should not use std
      
      * Remove unused definition of RawVRFOutput
      
      * Remove unused import of RuntimeDebug
      
      Co-authored-by: default avatarGavin Wood <[email protected]>
      a00a4ca5
    • Bastian Köcher's avatar
      Expose that `BasicQueue` expects blocking spawn (#5860) · 9c5536e0
      Bastian Köcher authored
      * Expose that `BasicQueue` expects blocking spawn
      
      Up to now `BasicQueue` expected a closure that to spawn a `Future`.
      This was expected to be a closure that spawns a blocking future.
      However, this wasn't documented anywhere. This pr introduces a new trait
      `SpawnBlocking` that exposes this requirement to the outside.
      
      * Feedback
      9c5536e0
  18. Apr 30, 2020
  19. Apr 29, 2020
  20. Apr 28, 2020
    • André Silva's avatar
      29c127a0
    • Web3 Philosopher's avatar
      Move sc-client into sc-service (#5502) · 4fa5941f
      Web3 Philosopher authored
      * Drop client from sc-network and sc-client-db, move LongestChain to sc-client-api
      
      * move leaves, cht, in_mem to sc-client-api, drop client from sc-finality-grandpa
      
      * drop sc-service from sc-rpc
      
      * drop sc-service from sc-consensus-aura
      
      * drop sc-client from manual-seal and babe
      
      * drop sc-client from utils/frame/rpc/system and utils/frame/benchmarking-cli
      
      * drop sc-client from bin/node and bin/node-template
      
      * drop sc-client
      
      * fix tests
      
      * remove check -p sc-client from gitlab.yml
      
      * fix warnings
      
      * fixes ui test
      
      * fix light client tests
      
      * adds associated Client type to AbstractService
      
      * adds UsageProvider to Client
      
      * fixed ui test, again
      
      * tried and failed to get node-cli to compile for wasm
      
      * thanks to tomaka for helping me get node-cli to compile for wasmm
      
      * ui test pls pas 🙏🏾
      
      
      
      * all tests passing 🪄
      
      * no_run documentation code
      
      * rm -f documentation code
      
      * ClientProvider
      
      * fix mega trait
      
      * move LongestChain to sc-consensus, use adds minimal bounds to AbstractService::Client
      
      * adds license to sc-consensus
      
      Co-authored-by: default avatarBenjamin Kampmann <[email protected]>
      4fa5941f
    • Wei Tang's avatar
      Versioned NextConfigDescriptor for BABE (#5789) · 7784bdef
      Wei Tang authored
      7784bdef
  21. Apr 25, 2020
  22. Apr 24, 2020
    • André Silva's avatar
      babe: remove error fallback from threshold calculation (#5764) · 3793fbf9
      André Silva authored
      * babe: remove error fallbacks from threshold calculation
      
      * babe: fix indent
      
      * babe: fix domain
      
      * babe: fix compilation
      
      * babe: improve expect
      
      * babe: add one more note about p's limit
      3793fbf9
    • Wei Tang's avatar
      babe: secondary blocks with VRF (#5501) · 969720c2
      Wei Tang authored
      
      
      * babe: secondary blocks with VRF
      
      * Fix node runtime compile
      
      * Fix test-utils runtime interface
      
      * Fix babe tests
      
      * typo: v == 2
      
      * babe: support online configuration upgrades
      
      * Fix rpc tests
      
      * Fix runtime version tests
      
      * Switch to use NextConfigDescriptor instead of changing runtime interface
      
      * Fix tests
      
      * epoch-changes: map function that allows converting with different epoch types
      
      * Add migration script for the epoch config change
      
      * Fix docs for PrimaryAndSecondaryVRFSlots
      
      * Add docs of `SecondaryVRF` in babe crate
      
      * babe-primitives: Secondary -> SecondaryPlain
      
      * babe-client: Secondary -> SecondaryPlain
      
      * Fix migration tests
      
      * test-utils-runtime: Secondary -> SecondaryPlain
      
      * Fix missing name change in test-utils-runtime
      
      * Fix migration: Epoch should be EpochV0
      
      * Update client/consensus/babe/src/lib.rs
      
      Co-Authored-By: default avatarAndré Silva <[email protected]>
      
      * Fix new epochChanges version
      
      * Fix babe-primitives naming changes
      
      * Fix merge issues in babe-client
      
      Co-authored-by: default avatarAndré Silva <[email protected]>
      Co-authored-by: default avatarAndré Silva <[email protected]>
      969720c2
    • Wei Tang's avatar
      babe: support online configuration upgrades (#5514) · 770cc24c
      Wei Tang authored
      
      
      * babe: support online configuration upgrades
      
      * Switch to use NextConfigDescriptor instead of changing runtime interface
      
      * Fix tests
      
      * epoch-changes: map function that allows converting with different epoch types
      
      * Add migration script for the epoch config change
      
      * Fix migration tests
      
      * Fix migration: Epoch should be EpochV0
      
      * Update client/consensus/babe/src/lib.rs
      
      Co-Authored-By: default avatarAndré Silva <[email protected]>
      
      * Fix new epochChanges version
      
      * Fix unused imports
      
      Co-authored-by: default avatarAndré Silva <[email protected]>
      770cc24c
  23. Apr 23, 2020
  24. Apr 17, 2020
  25. Apr 15, 2020