Fix transaction pruning in tx-pool (#6276)
The `tree_route` generated by the import notification is only from the old best block to the new best parent. This means, it does not contain the new best block in `enacted()`. We need to prune the transactions of the new best block "manually" to fix this bug. Besides that, this pr also changed the `id` parameter of the `NewBlock` chain event to `hash`. The hash of a block is unique in contrast to the block number. (Block id can either be number or hash)
Showing
- substrate/Cargo.lock 2 additions, 0 deletionssubstrate/Cargo.lock
- substrate/bin/node/cli/src/service.rs 1 addition, 1 deletionsubstrate/bin/node/cli/src/service.rs
- substrate/client/api/src/client.rs 20 additions, 1 deletionsubstrate/client/api/src/client.rs
- substrate/client/basic-authorship/src/basic_authorship.rs 11 additions, 9 deletionssubstrate/client/basic-authorship/src/basic_authorship.rs
- substrate/client/consensus/manual-seal/src/lib.rs 3 additions, 2 deletionssubstrate/client/consensus/manual-seal/src/lib.rs
- substrate/client/service/src/builder.rs 3 additions, 8 deletionssubstrate/client/service/src/builder.rs
- substrate/client/service/src/client/client.rs 1 addition, 1 deletionsubstrate/client/service/src/client/client.rs
- substrate/client/transaction-pool/Cargo.toml 2 additions, 0 deletionssubstrate/client/transaction-pool/Cargo.toml
- substrate/client/transaction-pool/src/lib.rs 9 additions, 5 deletionssubstrate/client/transaction-pool/src/lib.rs
- substrate/client/transaction-pool/src/testing/pool.rs 79 additions, 51 deletionssubstrate/client/transaction-pool/src/testing/pool.rs
- substrate/primitives/transaction-pool/src/pool.rs 3 additions, 3 deletionssubstrate/primitives/transaction-pool/src/pool.rs
Please register or sign in to comment