- Jul 22, 2024
-
-
Andrei Eres authored
Closes https://github.com/paritytech/polkadot-sdk/issues/4324 - On every active leaf candidate-validation subsystem checks if the node is the next session authority. - If it is, it fetches backed candidates and prepares unknown PVFs. - We limit number of PVFs per block to not overload subsystem.
-
Lulu authored
-
s0me0ne-unkn0wn authored
Closes #3425 --------- Co-authored-by:
antonva <anton.asgeirsson@parity.io> Co-authored-by: command-bot <>
-
gupnik authored
This PR fixes the documentation for FRAME Macros when pointed from `polkadot_sdk_docs` crate. This is achieved by referring to the examples in the `procedural` crate, embedded via `docify`. --------- Co-authored-by:
Kian Paimani <5588131+kianenigma@users.noreply.github.com>
-
Alexandru Vasile authored
This PR improves the metrics reported by litep2p on request-response errors. Discovered while investigating: - https://github.com/paritytech/polkadot-sdk/issues/4985 We are experiencing many requests that are `Refused` by litep2p in comparison with libp2p. The metric roughly approximates the sum of other reasons from libp2p. This PR aims to provide more insights. ``` {__name__="substrate_sub_libp2p_requests_out_failure_total", chain="ksmcc3", instance="localhost:9615", job="substrate_node", protocol="/b0a8d493285c2df73290dfb7e61f870f17b41801197a149ca93654499ea3dafe/sync/2", reason="Remote has closed the substream before answering, thereby signaling that it considers the request as valid, but refused to answer it."} Last *: 3365 Min: 3363 Max: 3365 Mean: 3365 {__name__="substrate_sub_libp2p_requests_out_failure_total", chain="ksmcc3", instance="localhost:9615", job="substrate_node", protocol="/b0a8d493285c2df73290dfb7e61f870f17b41801197a149ca93654499ea3dafe/beefy/justifications/1", reason="Remote has closed the substream before answering, thereby signaling that it considers the request as valid, but refused to answer it."} Last *: 3461 Min: 3461 Max: 3461 Mean: 3461 ``` Part of: - https://github.com/paritytech/polkadot-sdk/issues/4681 cc @paritytech/networking --------- Signed-off-by:
Alexandru Vasile <alexandru.vasile@parity.io>
-
- Jul 20, 2024
-
-
dependabot[bot] authored
Bumps [assert_cmd](https://github.com/assert-rs/assert_cmd) from 2.0.12 to 2.0.14. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/assert-rs/assert_cmd/blob/master/CHANGELOG.md">assert_cmd's changelog</a>.</em></p> <blockquote> <h2>[2.0.14] - 2024-02-19</h2> <h3>Compatibility</h3> <ul> <li>MSRV is now 1.73.0</li> </ul> <h3>Features</h3> <ul> <li>Run using the cargo target runner</li> </ul> <h2>[2.0.13] - 2024-01-12</h2> <h3>Internal</h3> <ul> <li>Dependency update</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/assert-rs/assert_cmd/commit/9ebfc0b140847e926374a8cd0ad235ba93f119f9"><code>9ebfc0b</code></a> chore: Release assert_cmd version 2.0.14</li> <li><a href="https://github.com/assert-rs/assert_cmd/commit/025c5f6dcb1ca3b0dfc24983e48aab123d093895"><code>025c5f6</code></a> docs: Update changelog</li> <li><a href="https://github.com/assert-rs/assert_cmd/commit/82b99c139882bdbc3d613094fb0eea944b05419c"><code>82b99c1</code></a> Merge pull request <a href="https://redirect.github.com/assert-rs/assert_cmd/issues/193">#193</a> from glehmann/cross</li> <li><a href="https://github.com/assert-rs/assert_cmd/commit/b3a290ce81873bb266457c6ea7f6d94124ba8ed5"><code>b3a290c</code></a> feat: add cargo runner support in order to work with cross</li> <li><a href="https://github.com/assert-rs/assert_cmd/commit/132db496f6e89454e33b13269b4bb9d42324ce7d"><code>132db49</code></a> Merge pull request <a href="https://redirect.github.com/assert-rs/assert_cmd/issues/194">#194</a> from assert-rs/renovate/rust-1.x</li> <li><a href="https://github.com/assert-rs/assert_cmd/commit/f1308abaf458e22511548bc7f3ddecc2bde579ed"><code>f1308ab</code></a> chore(deps): update msrv to v1.73</li> <li><a href="https://github.com/assert-rs/assert_cmd/commit/9b0f20acd4868a00544b5e28a0fcbcad6689afdf"><code>9b0f20a</code></a> Merge pull request <a href="https://redirect.github.com/assert-rs/assert_cmd/issues/192">#192</a> from assert-rs/renovate/rust-1.x</li> <li><a href="https://github.com/assert-rs/assert_cmd/commit/07f4cdee717ea3b6f96ac7eb1eaeb4ed2253d6af"><code>07f4cde</code></a> chore(deps): update msrv to v1.72</li> <li><a href="https://github.com/assert-rs/assert_cmd/commit/19da72b81c789f9c06817b99c1ecebfe7083dbfb"><code>19da72b</code></a> chore: Release assert_cmd version 2.0.13</li> <li><a href="https://github.com/assert-rs/assert_cmd/commit/db5ee325aafffb5b8e042cda1cc946e36079302a"><code>db5ee32</code></a> docs: Update changelog</li> <li>Additional commits viewable in <a href="https://github.com/assert-rs/assert_cmd/compare/v2.0.12...v2.0.14">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by:
dependabot[bot] <support@github.com> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
dependabot[bot] authored
Bumps [libc](https://github.com/rust-lang/libc) from 0.2.153 to 0.2.155. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/rust-lang/libc/releases">libc's releases</a>.</em></p> <blockquote> <h2>0.2.155</h2> <h2>What's Changed</h2> <ul> <li>Add <code>SYS_lseek</code> and <code>SYS_mmap</code> for aarch64 Android by <a href="https://github.com/lberrymage"><code>@lberrymage</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3632">rust-lang/libc#3632</a></li> <li>Correct the value of FAN_MARK_IGNORE by <a href="https://github.com/severen"><code>@severen</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3622">rust-lang/libc#3622</a></li> <li>Update FreeBSD 13 CI image by <a href="https://github.com/JohnTitor"><code>@JohnTitor</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3671">rust-lang/libc#3671</a></li> <li>android: add FUTEX_LOCK_PI2 by <a href="https://github.com/rtzoeller"><code>@rtzoeller</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3635">rust-lang/libc#3635</a></li> <li>Fix out-of-bounds pointer arithmetic in CMSG_NXTHDR by <a href="https://github.com/purplesyringa"><code>@purplesyringa</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3676">rust-lang/libc#3676</a></li> <li>Revert "Support posix_spawn on Android" by <a href="https://github.com/JohnTitor"><code>@JohnTitor</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3678">rust-lang/libc#3678</a></li> <li>Unlock ci: fix wrong cfg emscripten by <a href="https://github.com/tesuji"><code>@tesuji</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3684">rust-lang/libc#3684</a></li> <li>redox: correct EPOLL constants by <a href="https://github.com/jackpot51"><code>@jackpot51</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3686">rust-lang/libc#3686</a></li> <li>[0.2] Revert "Upgrade Docker images to Ubuntu 23.10" on sparc64 by <a href="https://github.com/cuviper"><code>@cuviper</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3708">rust-lang/libc#3708</a></li> <li>Re-add <code>posix_spawn{_file_actions_t,attr_t}</code> on Android by <a href="https://github.com/tesuji"><code>@tesuji</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3690">rust-lang/libc#3690</a></li> <li>Update version to <code>0.2.155</code> by <a href="https://github.com/madsmtm"><code>@madsmtm</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3682">rust-lang/libc#3682</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/lberrymage"><code>@lberrymage</code></a> made their first contribution in <a href="https://redirect.github.com/rust-lang/libc/pull/3632">rust-lang/libc#3632</a></li> <li><a href="https://github.com/purplesyringa"><code>@purplesyringa</code></a> made their first contribution in <a href="https://redirect.github.com/rust-lang/libc/pull/3676">rust-lang/libc#3676</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/rust-lang/libc/compare/0.2.154...0.2.155">https://github.com/rust-lang/libc/compare/0.2.154...0.2.155</a></p> <h2>0.2.154</h2> <h2>What's Changed</h2> <ul> <li>Fix CI on v0.2 by <a href="https://github.com/JohnTitor"><code>@JohnTitor</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3589">rust-lang/libc#3589</a></li> <li>[Backport <a href="https://redirect.github.com/rust-lang/libc/issues/3547">#3547</a>] Add ioctl FS_IOC_{G,S}{ETVERSION,ETFLAGS} for CSKY by <a href="https://github.com/Dirreke"><code>@Dirreke</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3572">rust-lang/libc#3572</a></li> <li>Add Linux riscv64 HWCAP defines (libc-0.2) by <a href="https://github.com/Xeonacid"><code>@Xeonacid</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3580">rust-lang/libc#3580</a></li> <li>Add missing MIPS R6 FS_IOC_* definitions by <a href="https://github.com/chenx97"><code>@chenx97</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3591">rust-lang/libc#3591</a></li> <li>Support posix_spawn on Android by <a href="https://github.com/pcc"><code>@pcc</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3602">rust-lang/libc#3602</a></li> <li>[0.2] Fix libc-tests for loongarch64 by <a href="https://github.com/heiher"><code>@heiher</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3607">rust-lang/libc#3607</a></li> <li>visionOS Support by <a href="https://github.com/agg23"><code>@agg23</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3568">rust-lang/libc#3568</a></li> <li>[0.2] linux/musl: Add support for LoongArch64 by <a href="https://github.com/heiher"><code>@heiher</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3606">rust-lang/libc#3606</a></li> <li>v0.2: Fix c_char on AIX by <a href="https://github.com/taiki-e"><code>@taiki-e</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3662">rust-lang/libc#3662</a></li> <li>solarish adding SO_EXCLBIND constant. by <a href="https://github.com/devnexen"><code>@devnexen</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3651">rust-lang/libc#3651</a></li> <li>[0.2] Add SIG constants to espidf by <a href="https://github.com/Tevz-Beskovnik"><code>@Tevz-Beskovnik</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3658">rust-lang/libc#3658</a></li> <li>add all android sysconf constants by <a href="https://github.com/fkm3"><code>@fkm3</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3656">rust-lang/libc#3656</a></li> <li>feat: more _PC_XXX constants for apple targets by <a href="https://github.com/SteveLauC"><code>@SteveLauC</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3649">rust-lang/libc#3649</a></li> <li>feat: O_EXEC/O_SEARCH for apple platforms by <a href="https://github.com/SteveLauC"><code>@SteveLauC</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3668">rust-lang/libc#3668</a></li> <li>[0.2] Add constant AT_MINSIGSTKSZ by <a href="https://github.com/ur4t"><code>@ur4t</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3637">rust-lang/libc#3637</a></li> <li>Haiku: synchronize with post R1-beta 4 changes in libc by <a href="https://github.com/nielx"><code>@nielx</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3638">rust-lang/libc#3638</a></li> <li>adding getentropy/getrandom to dragonflybsd. by <a href="https://github.com/devnexen"><code>@devnexen</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3618">rust-lang/libc#3618</a></li> <li>Move strftime, strftime_l, strptime to linux_like by <a href="https://github.com/pcc"><code>@pcc</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3600">rust-lang/libc#3600</a></li> <li>update crate version to 0.2.154 by <a href="https://github.com/Dirreke"><code>@Dirreke</code></a> in <a href="https://redirect.github.com/rust-lang/libc/pull/3573">rust-lang/libc#3573</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/pcc"><code>@pcc</code></a> made their first contribution in <a href="https://redirect.github.com/rust-lang/libc/pull/3602">rust-lang/libc#3602</a></li> <li><a href="https://github.com/agg23"><code>@agg23</code></a> made their first contribution in <a href="https://redirect.github.com/rust-lang/libc/pull/3568">rust-lang/libc#3568</a></li> <li><a href="https://github.com/Tevz-Beskovnik"><code>@Tevz-Beskovnik</code></a> made their first contribution in <a href="https://redirect.github.com/rust-lang/libc/pull/3658">rust-lang/libc#3658</a></li> <li><a href="https://github.com/ur4t"><code>@ur4t</code></a> made their first contribution in <a href="https://redirect.github.com/rust-lang/libc/pull/3637">rust-lang/libc#3637</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/rust-lang/libc/compare/0.2.153...0.2.154">https://github.com/rust-lang/libc/compare/0.2.153...0.2.154</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rust-lang/libc/commit/7df63bd7f61bf3408344673cf0ba08e7ff0df134"><code>7df63bd</code></a> Merge pull request <a href="https://redirect.github.com/rust-lang/libc/issues/3682">#3682</a> from madsmtm/new-version</li> <li><a href="https://github.com/rust-lang/libc/commit/0bbb5cda65be451d6ca9bf9a425a4edc3d580772"><code>0bbb5cd</code></a> Merge pull request <a href="https://redirect.github.com/rust-lang/libc/issues/3690">#3690</a> from tesuji/android-posix-spawn</li> <li><a href="https://github.com/rust-lang/libc/commit/15c74a4faba398a579a3a551f77cf790d5abf1f8"><code>15c74a4</code></a> Update version to 0.2.155</li> <li><a href="https://github.com/rust-lang/libc/commit/664947bdb087711c6e42596d081eacf5ba30dadd"><code>664947b</code></a> Merge pull request <a href="https://redirect.github.com/rust-lang/libc/issues/3708">#3708</a> from cuviper/ci-sparc64-0.2</li> <li><a href="https://github.com/rust-lang/libc/commit/61331df06f425934fa43a506e25217f49a039a7c"><code>61331df</code></a> Also skip <code>MFD_EXEC</code> and <code>MFD_NOEXEC_SEAL</code> on sparc64</li> <li><a href="https://github.com/rust-lang/libc/commit/73d2004d3e8ed9c15d46fd4e69b5f3f7dbbe86c7"><code>73d2004</code></a> Skip <code>SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV</code> on sparc64</li> <li><a href="https://github.com/rust-lang/libc/commit/80535f34aafbf089f201dfb217d659e36a18671a"><code>80535f3</code></a> Revert "Upgrade Docker images to Ubuntu 23.10" on sparc64</li> <li><a href="https://github.com/rust-lang/libc/commit/b2b2fd71f4cb866c2d3e4579a50a70aa460aab8e"><code>b2b2fd7</code></a> Readd posix_spawn{_file_actions_t,attr_t} on Android</li> <li><a href="https://github.com/rust-lang/libc/commit/76462771b6f8a6889ba6becadb53418df5515370"><code>7646277</code></a> Merge pull request <a href="https://redirect.github.com/rust-lang/libc/issues/3686">#3686</a> from redox-os/redox-epoll-0.2</li> <li><a href="https://github.com/rust-lang/libc/commit/5eff703b923d3e1b042e91bc67409cca961f3976"><code>5eff703</code></a> redox: correct EPOLL constants</li> <li>Additional commits viewable in <a href="https://github.com/rust-lang/libc/compare/0.2.153...0.2.155">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by:
dependabot[bot] <support@github.com> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
Alexandru Vasile authored
This PR increments the beefy metric wrt no peers to query justification from. The metric is incremented when we submit a request to a known peer, however that peer failed to provide a valid response, and there are no further peers to query. While at it, add a few extra details to identify the number of active peers and cached peers, together with the request error Part of: - https://github.com/paritytech/polkadot-sdk/issues/4985 - https://github.com/paritytech/polkadot-sdk/issues/4925 --------- Signed-off-by:
Alexandru Vasile <alexandru.vasile@parity.io>
-
Javyer authored
Added how the users can use [`gh cli`](https://cli.github.com/) instead of the dropdown if they want to keep the old commands. I also added the missing documentation of `sync`.
-
- Jul 19, 2024
-
-
Parth Mittal authored
# Description Previously, in the `Currency` impl, the implementation of `pallet_balances` was not emitting any instances of `Issued` and `Rescinded` events, even though the `Fungible` equivalent was. This PR adds the `Issued` and `Rescinded` events in appropriate places in `impl_currency` along with tests. Closes #4028 polkadot address: 5GsLutpKjbzsbTphebs9Uy4YK6gTN47MAaz6njPktidjR5cp --------- Co-authored-by:
Bastian Köcher <git@kchr.de> Co-authored-by:
Bastian Köcher <info@kchr.de>
-
Bastian Köcher authored
This pull requests adds a new CLI flag to `polkadot-parachains` `--export-pov-to-path`. This CLI flag will instruct the node to export any `PoV` that it build locally to export to the given folder. Then these `PoV` files can be validated using the introduced `cumulus-pov-validator`. The combination of export and validation can be used for debugging parachain validation issues that may happen on the relay chain.
-
Ankan authored
## Changes - `fn update_payee` is renamed to `fn set_payee` in the trait `StakingInterface` since there is also a call `Staking::update_payee` which does something different, ie used for migrating deprecated `Controller` accounts. - `set_payee` does not re-dispatch, only mutates ledger. - Fix rustdocs for `NominationPools::join`. - Add an implementation note about why we cannot allow existing stakers to join/bond_extra into the pool.
-
ordian authored
Short-term addresses https://github.com/paritytech/polkadot-sdk/issues/4737. - [x] Resolve benchmarking I've digged into benchmarking mentioned https://github.com/paritytech/polkadot-sdk/issues/4737#issuecomment-2155084660, but it seemed to me that this code is different proof/path. @acatangiu could you confirm? (btw, in this [bench](https://github.com/paritytech/polkadot-sdk/blob/b65313e8 /bridges/modules/parachains/src/benchmarking.rs#L57), where do you actually set the `fn parachains()` to a reasonable number? i've only seen 1) - [ ] Communicate to Snowfork team: This seems to be the relevant code: https://github.com/Snowfork/snowbridge/blob/1e18e010331777042aa7e8fff3c118094af856ba/relayer/cmd/parachain_head_proof.go#L95-L120 - [x] Is it preferred to iter() in some random order as suggested in https://github.com/paritytech/polkadot-sdk/issues/4737#issuecomment-2155084660 or take lowest para ids instead as implemented here currently? - [x] PRDoc ## Updating Polkadot and Kusama runtimes: New weights need to be generated (`pallet_mmr`) and configs updated similar to Rococo/Westend: ```patch diff --git a/polkadot/runtime/rococo/src/lib.rs b/polkadot/runtime/rococo/src/lib.rs index 5adffbd7422..c7da339b981 100644 --- a/polkadot/runtime/rococo/src/lib.rs +++ b/polkadot/runtime/rococo/src/lib.rs @@ -1307,9 +1307,11 @@ impl pallet_mmr::Config for Runtime { const INDEXING_PREFIX: &'static [u8] = mmr::INDEXING_PREFIX; type Hashing = Keccak256; type OnNewRoot = pallet_beefy_mmr::DepositBeefyDigest<Runtime>; - type WeightInfo = (); type LeafData = pallet_beefy_mmr::Pallet<Runtime>; type BlockHashProvider = pallet_mmr::DefaultBlockHashProvider<Runtime>; + type WeightInfo = weights::pallet_mmr::WeightInfo<Runtime>; + #[cfg(feature = "runtime-benchmarks")] + type BenchmarkHelper = parachains_paras::benchmarking::mmr_setup::MmrSetup<Runtime>; } parameter_types! { @@ -1319,13 +1321,8 @@ parameter_types! { pub struct ParaHeadsRootProvider; impl BeefyDataProvider<H256> for ParaHeadsRootProvider { fn extra_data() -> H256 { - let mut para_heads: Vec<(u32, Vec<u8>)> = parachains_paras::Parachains::<Runtime>::get() - .into_iter() - .filter_map(|id| { - parachains_paras::Heads::<Runtime>::get(&id).map(|head| (id.into(), head.0)) - }) - .collect(); - para_heads.sort(); + let para_heads: Vec<(u32, Vec<u8>)> = + parachains_paras::Pallet::<Runtime>::sorted_para_heads(); binary_merkle_tree::merkle_root::<mmr::Hashing, _>( para_heads.into_iter().map(|pair| pair.encode()), ) @@ -1746,6 +1743,7 @@ mod benches { [pallet_identity, Identity] [pallet_indices, Indices] [pallet_message_queue, MessageQueue] + [pallet_mmr, Mmr] [pallet_multisig, Multisig] [pallet_parameters, Parameters] [pallet_preimage, Preimage] ``` --------- Co-authored-by:
Adrian Catangiu <adrian@parity.io>
-
Joseph Zhao authored
# Issue [Backport integration tests for claim assets to the polkadot-sdk from polkadot-fellows repo #4892](https://github.com/paritytech/polkadot-sdk/issues/4892) # Description For the first time to contribute this project, I just finished part and make sure everything is ok. - [x] backport [claim_assets test case](https://github.com/polkadot-fellows/runtimes/blob/main/integration-tests/emulated/tests/assets/asset-hub-kusama/src/tests/claim_assets.rs) to the polkadot-sdk testnet integration tests - [x] backport macro [test_chain_can_claim_assets](https://github.com/polkadot-fellows/runtimes/blob/main/integration-tests/emulated/helpers/src/lib.rs#L218) from fellows repo - [ ] when merged to polkadot-sdk and released, make sure that it is propagated to the fellows repo: https://github.com/polkadot-fellows/runtimes/issues/363 - [x] backport and align other macros/test-cases from https://github.com/polkadot-fellows/runtimes/blob/8ec28f96eeb30fbba30d29006d75e1a3fa1cea1c/integration-tests/emulated/helpers/src/lib.rs#L31-L33 --------- Co-authored-by:
Zihan Zhao <josephzhao@Zihans-MacBook-Pro-3.local> Co-authored-by: command-bot <> Co-authored-by:
Adrian Catangiu <adrian@parity.io> Co-authored-by:
Francisco Aguirre <franciscoaguirreperez@gmail.com>
-
Oliver Tale-Yazdi authored
Require to specify a `bump` for every modified crate. --------- Signed-off-by:
Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
-
Özgün Özerk authored
Fixes #4960 Configuring `FeeManager` enforces the boundary `Into<[u8; 32]>` for the `AccountId` type. Here is how it works currently: Configuration: ```rust type FeeManager = XcmFeeManagerFromComponents< IsChildSystemParachain<primitives::Id>, XcmFeeToAccount<Self::AssetTransactor, AccountId, TreasuryAccount>, >; ``` `XcmToFeeAccount` struct: ```rust /// A `HandleFee` implementation that simply deposits the fees into a specific on-chain /// `ReceiverAccount`. /// /// It reuses the `AssetTransactor` configured on the XCM executor to deposit fee assets. If /// the `AssetTransactor` returns an error while calling `deposit_asset`, then a warning will be /// logged and the fee burned. pub struct XcmFeeToAccount<AssetTransactor, AccountId, ReceiverAccount>( PhantomData<(AssetTransactor, AccountId, ReceiverAccount)>, ); impl< AssetTransactor: TransactAsset, AccountId: Clone + Into<[u8; 32]>, ReceiverAccount: Get<AccountId>, > HandleFee for XcmFeeToAccount<AssetTransactor, AccountId, ReceiverAccount> { fn handle_fee(fee: Assets, context: Option<&XcmContext>, _reason: FeeReason) -> Assets { deposit_or_burn_fee::<AssetTransactor, _>(fee, context, ReceiverAccount::get()); Assets::new() } } ``` `deposit_or_burn_fee()` function: ```rust /// Try to deposit the given fee in the specified account. /// Burns the fee in case of a failure. pub fn deposit_or_burn_fee<AssetTransactor: TransactAsset, AccountId: Clone + Into<[u8; 32]>>( fee: Assets, context: Option<&XcmContext>, receiver: AccountId, ) { let dest = AccountId32 { network: None, id: receiver.into() }.into(); for asset in fee.into_inner() { if let Err(e) = AssetTransactor::deposit_asset(&asset, &dest, context) { log::trace!( target: "xcm::fees", "`AssetTransactor::deposit_asset` returned error: {:?}. Burning fee: {:?}. \ They might be burned.", e, asset, ); } } } ``` --- In order to use **another** `AccountId` type (for example, 20 byte addresses for compatibility with Ethereum or Bitcoin), one has to duplicate the code as the following (roughly changing every `32` to `20`): ```rust /// A `HandleFee` implementation that simply deposits the fees into a specific on-chain /// `ReceiverAccount`. /// /// It reuses the `AssetTransactor` configured on the XCM executor to deposit fee assets. If /// the `AssetTransactor` returns an error while calling `deposit_asset`, then a warning will be /// logged and the fee burned. pub struct XcmFeeToAccount<AssetTransactor, AccountId, ReceiverAccount>( PhantomData<(AssetTransactor, AccountId, ReceiverAccount)>, ); impl< AssetTransactor: TransactAsset, AccountId: Clone + Into<[u8; 20]>, ReceiverAccount: Get<AccountId>, > HandleFee for XcmFeeToAccount<AssetTransactor, AccountId, ReceiverAccount> { fn handle_fee(fee: XcmAssets, context: Option<&XcmContext>, _reason: FeeReason) -> XcmAssets { deposit_or_burn_fee::<AssetTransactor, _>(fee, context, ReceiverAccount::get()); XcmAssets::new() } } pub fn deposit_or_burn_fee<AssetTransactor: TransactAsset, AccountId: Clone + Into<[u8; 20]>>( fee: XcmAssets, context: Option<&XcmContext>, receiver: AccountId, ) { let dest = AccountKey20 { network: None, key: receiver.into() }.into(); for asset in fee.into_inner() { if let Err(e) = AssetTransactor::deposit_asset(&asset, &dest, context) { log::trace!( target: "xcm::fees", "`AssetTransactor::deposit_asset` returned error: {:?}. Burning fee: {:?}. \ They might be burned.", e, asset, ); } } } ``` --- This results in code duplication, which can be avoided simply by relaxing the trait enforced by `XcmFeeToAccount`. In this PR, I propose to introduce a new trait called `IntoLocation` to be able to express both `Into<[u8; 32]>` and `Into<[u8; 20]>` should be accepted (and every other `AccountId` type as long as they implement this trait). Currently, `deposit_or_burn_fee()` function converts the `receiver: AccountId` to a location. I think converting an account to `Location` should not be the responsibility of `deposit_or_burn_fee()` function. This trait also decouples the conversion of `AccountId` to `Location`, from `deposit_or_burn_fee()` function. And exposes `IntoLocation` trait. Thus, allowing everyone to come up with their `AccountId` type and make it compatible for configuring `FeeManager`. --- Note 1: if there is a better file/location to put `IntoLocation`, I'm all ears Note 2: making `deposit_or_burn_fee` or `XcmToFeeAccount` generic was not possible from what I understood, due to Rust currently do not support a way to express the generic should implement either `trait A` or `trait B` (since the compiler cannot guarantee they won't overlap). In this case, they are `Into<[u8; 32]>` and `Into<[u8; 20]>`. See [this](https://github.com/rust-lang/rust/issues/20400) and [this](https://github.com/rust-lang/rfcs/pull/1672#issuecomment-262152934). Note 3: I should also submit a PR to `frontier` that implements `IntoLocation` for `AccountId20` if this PR gets accepted. ### Summary this new trait: - decouples the conversion of `AccountId` to `Location`, from `deposit_or_burn_fee()` function - makes `XcmFeeToAccount` accept every possible `AccountId` type as long as they they implement `IntoLocation` - backwards compatible - keeps the API simple and clean while making it less restrictive @franciscoaguirre and @gupnik are already aware of the issue, so tagging them here for visibility. --------- Co-authored-by:
Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by:
Branislav Kontur <bkontur@gmail.com> Co-authored-by:
Adrian Catangiu <adrian@parity.io> Co-authored-by: command-bot <>
-
dependabot[bot] authored
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.0.1 to 4.0.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/setup-node/releases">actions/setup-node's releases</a>.</em></p> <blockquote> <h2>v4.0.3</h2> <h2>What's Changed</h2> <h3>Bug fixes:</h3> <ul> <li>Fix macos latest check failures by <a href="https://github.com/HarithaVattikuti"><code>@HarithaVattikuti</code></a> in <a href="https://redirect.github.com/actions/setup-node/pull/1041">actions/setup-node#1041</a></li> </ul> <h3>Documentation changes:</h3> <ul> <li>Documentation update to update default Node version to 20 by <a href="https://github.com/bengreeley"><code>@bengreeley</code></a> in <a href="https://redirect.github.com/actions/setup-node/pull/949">actions/setup-node#949</a></li> </ul> <h3>Dependency updates:</h3> <ul> <li>Bump undici from 5.26.5 to 5.28.3 by <a href="https://github.com/dependabot"><code>@...
-
- Jul 18, 2024
-
-
Juan Ignacio Rios authored
v3 PalletInfo had the fields public, but not v4. Any reason why? I need the PalletInfo fields public so I can read the values and do some logic based on that at Polimec @franciscoaguirre If this could be backported would be highly appreciated
--------- Co-authored-by:Adrian Catangiu <adrian@parity.io> Co-authored-by:
Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
-
dependabot[bot] authored
Bumps [enumn](https://github.com/dtolnay/enumn) from 0.1.12 to 0.1.13. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dtolnay/enumn/releases">enumn's releases</a>.</em></p> <blockquote> <h2>0.1.13</h2> <ul> <li>Update proc-macro2 to fix caching issue when using a rustc-wrapper such as sccache</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dtolnay/enumn/commit/de964e3ce0463f01dabb94c168d507254facfb86"><code>de964e3</code></a> Release 0.1.13</li> <li><a href="https://github.com/dtolnay/enumn/commit/52dcafcb2ee193be8839dc0f96bfa0e151888645"><code>52dcafc</code></a> Pull in proc-macro2 sccache fix</li> <li><a href="https://github.com/dtolnay/enumn/commit/ba2e288a83c5e62d1e29b993523ccf0528043ab0"><code>ba2e288</code></a> Test docs.rs documentation build in CI</li> <li><a href="https://github.com/dtolnay/enumn/commit/6f5a37e5a9dcdb75987552b44d7ebdbd7f0a2a93"><code>6f5a37e</code></a> Update actions/checkout@v3 -> v4</li> <li>See full diff in <a href="https://github.com/dtolnay/enumn/compare/0.1.12...0.1.13">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by:
dependabot[bot] <support@github.com> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
Nazar Mokrynskyi authored
Due to `LruMap` usage it is not actually possible to leverage read feature of `RwLock`, hence change to `Mutex` that is faster
-
Bastian Köcher authored
Closes: https://github.com/paritytech/polkadot-sdk/issues/3192
-
dependabot[bot] authored
Bumps the known_good_semver group with 8 updates: | Package | From | To | | --- | --- | --- | | [clap](https://github.com/clap-rs/clap) | `4.5.3` | `4.5.9` | | [log](https://github.com/rust-lang/log) | `0.4.21` | `0.4.22` | | [paste](https://github.com/dtolnay/paste) | `1.0.14` | `1.0.15` | | [quote](https://github.com/dtolnay/quote) | `1.0.35` | `1.0.36` | | [serde](https://github.com/serde-rs/serde) | `1.0.197` | `1.0.204` | | [serde_derive](https://github.com/serde-rs/serde) | `1.0.197` | `1.0.204` | | [serde_json](https://github.com/serde-rs/json) | `1.0.114` | `1.0.120` | | [serde_yaml](https://github.com/dtolnay/serde-yaml) | `0.9.33` | `0.9.34+deprecated` | Updates `clap` from 4.5.3 to 4.5.9 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/clap-rs/clap/releases">clap's releases</a>.</em></p> <blockquote> <h2>v4.5.9</h2> <h2>[4.5.9] - 2024-07-09</h2> <h3>Fixes</h3> <ul> <li><em>(error)</em> When defining a custom help flag, be sure to suggest it like we do the built-in one</li> </ul> <h2>v4.5.8</h2> <h2>[4.5.8] - 2024-06-28</h2> <h3>Fixes</h3> <ul> <li>Reduce extra flushes</li> </ul> <h2>v4.5.7</h2> <h2>[4.5.7] - 2024-06-10</h2> <h3>Fixes</h3> <ul> <li>Clean up error message when too few arguments for <code>num_args</code></li> </ul> <h2>v4.5.6</h2> <h2>[4.5.6] - 2024-06-06</h2> <h2>v4.5.4</h2> <h2>[4.5.4] - 2024-03-25</h2> <h3>Fixes</h3> <ul> <li><em>(derive)</em> Allow non-literal <code>#[arg(id)]</code> attributes again</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/clap-rs/clap/blob/master/CHANGELOG.md">clap's changelog</a>.</em></p> <blockquote> <h2>[4.5.9] - 2024-07-09</h2> <h3>Fixes</h3> <ul> <li><em>(error)</em> When defining a custom help flag, be sure to suggest it like we do the built-in one</li> </ul> <h2>[4.5.8] - 2024-06-28</h2> <h3>Fixes</h3> <ul> <li>Reduce extra flushes</li> </ul> <h2>[4.5.7] - 2024-06-10</h2> <h3>Fixes</h3> <ul> <li>Clean up error message when too few arguments for <code>num_args</code></li> </ul> <h2>[4.5.6] - 2024-06-06</h2> <h2>[4.5.5] - 2024-06-06</h2> <h3>Fixes</h3> <ul> <li>Allow <code>exclusive</code> to override <code>required_unless_present</code>, <code>required_unless_present_any</code>, <code>required_unless_present_all</code></li> </ul> <h2>[4.5.4] - 2024-03-25</h2> <h3>Fixes</h3> <ul> <li><em>(derive)</em> Allow non-literal <code>#[arg(id)]</code> attributes again</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/clap-rs/clap/commit/43e73682835653ac48f32cc786514553d697c693"><code>43e7368</code></a> chore: Release</li> <li><a href="https://github.com/clap-rs/clap/commit/f00dafa690479e562ef22c3ed82f17726213ee32"><code>f00dafa</code></a> docs: Update changelog</li> <li><a href="https://github.com/clap-rs/clap/commit/da1093a4f4cd1abba7de0b86f39319ab86913420"><code>da1093a</code></a> Merge pull request <a href="https://redirect.github.com/clap-rs/clap/issues/5574">#5574</a> from zanieb/zb/try-help-custom</li> <li><a href="https://github.com/clap-rs/clap/commit/2eb842cc3bc1fb5f04156efa816003ef803d5254"><code>2eb842c</code></a> feat: Show user defined help flags in hints</li> <li><a href="https://github.com/clap-rs/clap/commit/b24deb101f7e12660b8b19d6b3979df87ffe065d"><code>b24deb1</code></a> test: Add coverage for help flag hints</li> <li><a href="https://github.com/clap-rs/clap/commit/866d7d14d33a3ef1f010222f004815b5cd8c15ef"><code>866d7d1</code></a> chore(deps): Update compatible (dev) (<a href="https://redirect.github.com/clap-rs/clap/issues/5560">#5560</a>)</li> <li><a href="https://github.com/clap-rs/clap/commit/d14bbc95317eb87a115f56c455bdab6ba19342ff"><code>d14bbc9</code></a> Merge pull request <a href="https://redirect.github.com/clap-rs/clap/issues/5567">#5567</a> from epage/c</li> <li><a href="https://github.com/clap-rs/clap/commit/5448020b188899601d641a2684833073aba0a669"><code>5448020</code></a> fix: Install shells for CI</li> <li><a href="https://github.com/clap-rs/clap/commit/1c5a625ad0303e2407c8ab83ea7d37795e69a3a5"><code>1c5a625</code></a> fix: Fix wrong <code>cfg(linux)</code></li> <li><a href="https://github.com/clap-rs/clap/commit/2d2d1f498731d2ab70e8f15fed3765a856d52732"><code>2d2d1f4</code></a> chore: Bump completest</li> <li>Additional commits viewable in <a href="https://github.com/clap-rs/clap/compare/clap_complete-v4.5.3...v4.5.9">compare view</a></li> </ul> </details> <br /> Updates `log` from 0.4.21 to 0.4.22 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/rust-lang/log/blob/master/CHANGELOG.md">log's changelog</a>.</em></p> <blockquote> <h2>[0.4.22] - 2024-06-27</h2> <h2>What's Changed</h2> <ul> <li>Add some clarifications to the library docs by <a href="https://github.com/KodrAus"><code>@KodrAus</code></a> in <a href="https://redirect.github.com/rust-lang/log/pull/620">rust-lang/log#620</a></li> <li>Add links to <code>colog</code> crate by <a href="https://github.com/chrivers"><code>@chrivers</code></a> in <a href="https://redirect.github.com/rust-lang/log/pull/621">rust-lang/log#621</a></li> <li>adding line_number test + updating some testing infrastructure by <a href="https://github.com/DIvkov575"><code>@DIvkov575</code></a> in <a href="https://redirect.github.com/rust-lang/log/pull/619">rust-lang/log#619</a></li> <li>Clarify the actual set of functions that can race in _racy variants by <a href="https://github.com/KodrAus"><code>@KodrAus</code></a> in <a href="https://redirect.github.com/rust-lang/log/pull/623">rust-lang/log#623</a></li> <li>Replace deprecated std::sync::atomic::spin_loop_hint() by <a href="https://github.com/Catamantaloedis"><code>@Catamantaloedis</code></a> in <a href="https://redirect.github.com/rust-lang/log/pull/625">rust-lang/log#625</a></li> <li>Check usage of max_level features by <a href="https://github.com/Thomasdezeeuw"><code>@Thomasdezeeuw</code></a> in <a href="https://redirect.github.com/rust-lang/log/pull/627">rust-lang/log#627</a></li> <li>Remove unneeded import by <a href="https://github.com/Thomasdezeeuw"><code>@Thomasdezeeuw</code></a> in <a href="https://redirect.github.com/rust-lang/log/pull/628">rust-lang/log#628</a></li> <li>Loosen orderings for logger initialization in <a href="https://redirect.github.com/rust-lang/log/pull/632">rust-lang/log#632</a>. Originally by <a href="https://github.com/pwoolcoc"><code>@pwoolcoc</code></a> in <a href="https://redirect.github.com/rust-lang/log/pull/599">rust-lang/log#599</a></li> <li>Use Location::caller() for file and line info in <a href="https://redirect.github.com/rust-lang/log/pull/633">rust-lang/log#633</a>. Originally by <a href="https://github.com/Cassy343"><code>@Cassy343</code></a> in <a href="https://redirect.github.com/rust-lang/log/pull/520">rust-lang/log#520</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/chrivers"><code>@chrivers</code></a> made their first contribution in <a href="https://redirect.github.com/rust-lang/log/pull/621">rust-lang/log#621</a></li> <li><a href="https://github.com/DIvkov575"><code>@DIvkov575</code></a> made their first contribution in <a href="https://redirect.github.com/rust-lang/log/pull/619">rust-lang/log#619</a></li> <li><a href="https://github.com/Catamantaloedis"><code>@Catamantaloedis</code></a> made their first contribution in <a href="https://redirect.github.com/rust-lang/log/pull/625">rust-lang/log#625</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/rust-lang/log/compare/0.4.21...0.4.22">https://github.com/rust-lang/log/compare/0.4.21...0.4.22</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rust-lang/log/commit/d5ba2cfee9b3b4ca1fcad911b7f59dc79eeee022"><code>d5ba2cf</code></a> Merge pull request <a href="https://redirect.github.com/rust-lang/log/issues/634">#634</a> from rust-lang/cargo/0.4.22</li> <li><a href="https://github.com/rust-lang/log/commit/d1a8306aadb88d56b74c73cdce4ef0153fb549cb"><code>d1a8306</code></a> prepare for 0.4.22 release</li> <li><a href="https://github.com/rust-lang/log/commit/46894ef229483bbabd30a806c474417fc034559c"><code>46894ef</code></a> Merge pull request <a href="https://redirect.github.com/rust-lang/log/issues/633">#633</a> from rust-lang/feat/panic-info</li> <li><a href="https://github.com/rust-lang/log/commit/e0d389c9cadd91363f2fec52bd30f9585168a89f"><code>e0d389c</code></a> Merge pull request <a href="https://redirect.github.com/rust-lang/log/issues/632">#632</a> from rust-lang/feat/loosen-atomics</li> <li><a href="https://github.com/rust-lang/log/commit/c9e5e13e9b02ec80e784c6fe4deacdc8f3194fca"><code>c9e5e13</code></a> use Location::caller() for file and line info</li> <li><a href="https://github.com/rust-lang/log/commit/507b672660288f0223edb6353d34f8733fa0a2f4"><code>507b672</code></a> loosen orderings for logger initialization</li> <li><a href="https://github.com/rust-lang/log/commit/c879b011a8ac662545adf9484d9a668ebcf9b814"><code>c879b01</code></a> Merge pull request <a href="https://redirect.github.com/rust-lang/log/issues/628">#628</a> from Thomasdezeeuw/fix-warnings</li> <li><a href="https://github.com/rust-lang/log/commit/405fdb4d9f847c93c0133469ea808f09320714ba"><code>405fdb4</code></a> Merge pull request <a href="https://redirect.github.com/rust-lang/log/issues/627">#627</a> from Thomasdezeeuw/check-features</li> <li><a href="https://github.com/rust-lang/log/commit/1307ade1122549badf2b8fdd10c11e519eaa029a"><code>1307ade</code></a> Remove unneeded import</li> <li><a href="https://github.com/rust-lang/log/commit/710560ecb7035a6baf1fd9d97d7f09d0cc075006"><code>710560e</code></a> Don't use --all-features in CI</li> <li>Additional commits viewable in <a href="https://github.com/rust-lang/log/compare/0.4.21...0.4.22">compare view</a></li> </ul> </details> <br /> Updates `paste` from 1.0.14 to 1.0.15 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dtolnay/paste/releases">paste's releases</a>.</em></p> <blockquote> <h2>1.0.15</h2> <ul> <li>Resolve unexpected_cfgs warning (<a href="https://redirect.github.com/dtolnay/paste/issues/102">#102</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dtolnay/paste/commit/a2c7e27875277450ed28147623ba5218dd23e732"><code>a2c7e27</code></a> Release 1.0.15</li> <li><a href="https://github.com/dtolnay/paste/commit/1d23098227a01de542ea52db13dc1314eca13f00"><code>1d23098</code></a> Merge pull request <a href="https://redirect.github.com/dtolnay/paste/issues/102">#102</a> from dtolnay/checkcfg</li> <li><a href="https://github.com/dtolnay/paste/commit/1edfaae644d0b27e96c26cdc4d51e9fe3f51c12d"><code>1edfaae</code></a> Resolve unexpected_cfgs warning</li> <li><a href="https://github.com/dtolnay/paste/commit/cc6803dd049b9943c1e49b2220ff37a94711577c"><code>cc6803d</code></a> Explicitly install a Rust toolchain for cargo-outdated job</li> <li><a href="https://github.com/dtolnay/paste/commit/d39fb86d2d588bf63572886db340bc16c6cc6904"><code>d39fb86</code></a> Ignore dead code lint in tests</li> <li><a href="https://github.com/dtolnay/paste/commit/14872adf2b72140902ed6425a90517333ccc1a44"><code>14872ad</code></a> Work around empty_docs clippy lint in test</li> <li><a href="https://github.com/dtolnay/paste/commit/ed844dc6fe755bcee881bd93cdff5a77038aa49b"><code>ed844dc</code></a> Work around dead_code warning in test</li> <li><a href="https://github.com/dtolnay/paste/commit/0a4161b1318e01845cb32790b3bdadd618608361"><code>0a4161b</code></a> Add cargo.toml metadata to link to crate documentation</li> <li><a href="https://github.com/dtolnay/paste/commit/5a2bce19a1f100bf62824c9e3ff03879c916cdce"><code>5a2bce1</code></a> Test docs.rs documentation build in CI</li> <li><a href="https://github.com/dtolnay/paste/commit/d7e0be15a74c99b303e9993365f41f3440551b8f"><code>d7e0be1</code></a> Update actions/checkout@v3 -> v4</li> <li>Additional commits viewable in <a href="https://github.com/dtolnay/paste/compare/1.0.14...1.0.15">compare view</a></li> </ul> </details> <br /> Updates `quote` from 1.0.35 to 1.0.36 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dtolnay/quote/releases">quote's releases</a>.</em></p> <blockquote> <h2>1.0.36</h2> <ul> <li>Documentation improvements</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dtolnay/quote/commit/5d4880c4255b5c7f5ea0a9ac3cf9f985c418a1e7"><code>5d4880c</code></a> Release 1.0.36</li> <li><a href="https://github.com/dtolnay/quote/commit/1dd7ce794ff69a922f6b0e1b5d3a4929e1218258"><code>1dd7ce7</code></a> Merge pull request <a href="https://redirect.github.com/dtolnay/quote/issues/273">#273</a> from dtolnay/doc</li> <li><a href="https://github.com/dtolnay/quote/commit/0bc5d12f9be1bd39314b925aa786663e18f9a489"><code>0bc5d12</code></a> Apply doc comment to cfg(not(doc)) macros too</li> <li><a href="https://github.com/dtolnay/quote/commit/c295f5cca24108693724d8fb6f35da1faa81b78b"><code>c295f5c</code></a> Revert "Temporarily disable miri on doctests"</li> <li><a href="https://github.com/dtolnay/quote/commit/435bd1b917e98413310c5260787fbcee3c3d01ca"><code>435bd1b</code></a> Update ui test suite to nightly-2024-03-31</li> <li><a href="https://github.com/dtolnay/quote/commit/cc3847d3469a8e82a587fbf1608adc04b56c581a"><code>cc3847d</code></a> Explicitly install a Rust toolchain for cargo-outdated job</li> <li><a href="https://github.com/dtolnay/quote/commit/6259d49d0d35030c3dea792e85f23af52bb7994d"><code>6259d49</code></a> Temporarily disable miri on doctests</li> <li><a href="https://github.com/dtolnay/quote/commit/bdb4b594076d78127b99a3da768e369499e324de"><code>bdb4b59</code></a> Update ui test suite to nightly-2024-02-08</li> <li><a href="https://github.com/dtolnay/quote/commit/c2aeca9c00b12b6f87e2e7cb545c160e6b4aa18f"><code>c2aeca9</code></a> Update ui test suite to nightly-2024-01-31</li> <li><a href="https://github.com/dtolnay/quote/commit/376a0611f3acf91a424aae58104b587530361900"><code>376a061</code></a> Merge pull request <a href="https://redirect.github.com/dtolnay/quote/issues/270">#270</a> from dtolnay/bench</li> <li>Additional commits viewable in <a href="https://github.com/dtolnay/quote/compare/1.0.35...1.0.36">compare view</a></li> </ul> </details> <br /> Updates `serde` from 1.0.197 to 1.0.204 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/serde/releases">serde's releases</a>.</em></p> <blockquote> <h2>v1.0.204</h2> <ul> <li>Apply #[diagnostic::on_unimplemented] attribute on Rust 1.78+ to suggest adding serde derive or enabling a "serde" feature flag in dependencies (<a href="https://redirect.github.com/serde-rs/serde/issues/2767">#2767</a>, thanks <a href="https://github.com/weiznich"><code>@weiznich</code></a>)</li> </ul> <h2>v1.0.203</h2> <ul> <li>Documentation improvements (<a href="https://redirect.github.com/serde-rs/serde/issues/2747">#2747</a>)</li> </ul> <h2>v1.0.202</h2> <ul> <li>Provide public access to RenameAllRules in serde_derive_internals (<a href="https://redirect.github.com/serde-rs/serde/issues/2743">#2743</a>)</li> </ul> <h2>v1.0.201</h2> <ul> <li>Resolve unexpected_cfgs warning (<a href="https://redirect.github.com/serde-rs/serde/issues/2737">#2737</a>)</li> </ul> <h2>v1.0.200</h2> <ul> <li>Fix formatting of "invalid type" and "invalid value" deserialization error messages containing NaN or infinite floats (<a href="https://redirect.github.com/serde-rs/serde/issues/2733">#2733</a>, thanks <a href="https://github.com/jamessan"><code>@jamessan</code></a>)</li> </ul> <h2>v1.0.199</h2> <ul> <li>Fix ambiguous associated item when <code>forward_to_deserialize_any!</code> is used on an enum with <code>Error</code> variant (<a href="https://redirect.github.com/serde-rs/serde/issues/2732">#2732</a>, thanks <a href="https://github.com/aatifsyed"><code>@aatifsyed</code></a>)</li> </ul> <h2>v1.0.198</h2> <ul> <li>Support serializing and deserializing <code>Saturating<T></code> (<a href="https://redirect.github.com/serde-rs/serde/issues/2709">#2709</a>, thanks <a href="https://github.com/jbethune"><code>@jbethune</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/serde-rs/serde/commit/18dcae0a77632fb4767a420c550cb41991f750b8"><code>18dcae0</code></a> Release 1.0.204</li> <li><a href="https://github.com/serde-rs/serde/commit/58c307f9cc28a19d73a0e2869f6addf9a8a329f9"><code>58c307f</code></a> Alphabetize list of rustc-check-cfg</li> <li><a href="https://github.com/serde-rs/serde/commit/8cc4809414a83de0d41eac38ecfa1040e088b61e"><code>8cc4809</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2769">#2769</a> from dtolnay/onunimpl</li> <li><a href="https://github.com/serde-rs/serde/commit/1179158defc5351467cbd2c340b7e1498391bce4"><code>1179158</code></a> Update ui test with diagnostic::on_unimplemented from PR 2767</li> <li><a href="https://github.com/serde-rs/serde/commit/91aa40e749620f31bf7db01c772e672f023136b5"><code>91aa40e</code></a> Add ui test of unsatisfied serde trait bound</li> <li><a href="https://github.com/serde-rs/serde/commit/595019e979ebed5452b550bf901abcab2cf4e945"><code>595019e</code></a> Cut test_suite from workspace members in old toolchain CI jobs</li> <li><a href="https://github.com/serde-rs/serde/commit/b0d7917f88978eda264f8fbac13b46ece35f5348"><code>b0d7917</code></a> Pull in trybuild 'following types implement trait' fix</li> <li><a href="https://github.com/serde-rs/serde/commit/8e6637a1e44c30dffd37322a7107d434cd751722"><code>8e6637a</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2767">#2767</a> from weiznich/feature/diagnostic_on_unimplemented</li> <li><a href="https://github.com/serde-rs/serde/commit/694fe0595358aa0857120a99041d99975b1a8a70"><code>694fe05</code></a> Use the <code>#[diagnostic::on_unimplemented]</code> attribute when possible</li> <li><a href="https://github.com/serde-rs/serde/commit/f3dfd2a2375d9caf15a18ec657dde51a32caf6ed"><code>f3dfd2a</code></a> Suppress dead code warning in test of unit struct remote derive</li> <li>Additional commits viewable in <a href="https://github.com/serde-rs/serde/compare/v1.0.197...v1.0.204">compare view</a></li> </ul> </details> <br /> Updates `serde_derive` from 1.0.197 to 1.0.204 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/serde/releases">serde_derive's releases</a>.</em></p> <blockquote> <h2>v1.0.204</h2> <ul> <li>Apply #[diagnostic::on_unimplemented] attribute on Rust 1.78+ to suggest adding serde derive or enabling a "serde" feature flag in dependencies (<a href="https://redirect.github.com/serde-rs/serde/issues/2767">#2767</a>, thanks <a href="https://github.com/weiznich"><code>@weiznich</code></a>)</li> </ul> <h2>v1.0.203</h2> <ul> <li>Documentation improvements (<a href="https://redirect.github.com/serde-rs/serde/issues/2747">#2747</a>)</li> </ul> <h2>v1.0.202</h2> <ul> <li>Provide public access to RenameAllRules in serde_derive_internals (<a href="https://redirect.github.com/serde-rs/serde/issues/2743">#2743</a>)</li> </ul> <h2>v1.0.201</h2> <ul> <li>Resolve unexpected_cfgs warning (<a href="https://redirect.github.com/serde-rs/serde/issues/2737">#2737</a>)</li> </ul> <h2>v1.0.200</h2> <ul> <li>Fix formatting of "invalid type" and "invalid value" deserialization error messages containing NaN or infinite floats (<a href="https://redirect.github.com/serde-rs/serde/issues/2733">#2733</a>, thanks <a href="https://github.com/jamessan"><code>@jamessan</code></a>)</li> </ul> <h2>v1.0.199</h2> <ul> <li>Fix ambiguous associated item when <code>forward_to_deserialize_any!</code> is used on an enum with <code>Error</code> variant (<a href="https://redirect.github.com/serde-rs/serde/issues/2732">#2732</a>, thanks <a href="https://github.com/aatifsyed"><code>@aatifsyed</code></a>)</li> </ul> <h2>v1.0.198</h2> <ul> <li>Support serializing and deserializing <code>Saturating<T></code> (<a href="https://redirect.github.com/serde-rs/serde/issues/2709">#2709</a>, thanks <a href="https://github.com/jbethune"><code>@jbethune</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/serde-rs/serde/commit/18dcae0a77632fb4767a420c550cb41991f750b8"><code>18dcae0</code></a> Release 1.0.204</li> <li><a href="https://github.com/serde-rs/serde/commit/58c307f9cc28a19d73a0e2869f6addf9a8a329f9"><code>58c307f</code></a> Alphabetize list of rustc-check-cfg</li> <li><a href="https://github.com/serde-rs/serde/commit/8cc4809414a83de0d41eac38ecfa1040e088b61e"><code>8cc4809</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2769">#2769</a> from dtolnay/onunimpl</li> <li><a href="https://github.com/serde-rs/serde/commit/1179158defc5351467cbd2c340b7e1498391bce4"><code>1179158</code></a> Update ui test with diagnostic::on_unimplemented from PR 2767</li> <li><a href="https://github.com/serde-rs/serde/commit/91aa40e749620f31bf7db01c772e672f023136b5"><code>91aa40e</code></a> Add ui test of unsatisfied serde trait bound</li> <li><a href="https://github.com/serde-rs/serde/commit/595019e979ebed5452b550bf901abcab2cf4e945"><code>595019e</code></a> Cut test_suite from workspace members in old toolchain CI jobs</li> <li><a href="https://github.com/serde-rs/serde/commit/b0d7917f88978eda264f8fbac13b46ece35f5348"><code>b0d7917</code></a> Pull in trybuild 'following types implement trait' fix</li> <li><a href="https://github.com/serde-rs/serde/commit/8e6637a1e44c30dffd37322a7107d434cd751722"><code>8e6637a</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2767">#2767</a> from weiznich/feature/diagnostic_on_unimplemented</li> <li><a href="https://github.com/serde-rs/serde/commit/694fe0595358aa0857120a99041d99975b1a8a70"><code>694fe05</code></a> Use the <code>#[diagnostic::on_unimplemented]</code> attribute when possible</li> <li><a href="https://github.com/serde-rs/serde/commit/f3dfd2a2375d9caf15a18ec657dde51a32caf6ed"><code>f3dfd2a</code></a> Suppress dead code warning in test of unit struct remote derive</li> <li>Additional commits viewable in <a href="https://github.com/serde-rs/serde/compare/v1.0.197...v1.0.204">compare view</a></li> </ul> </details> <br /> Updates `serde_json` from 1.0.114 to 1.0.120 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/json/releases">serde_json's releases</a>.</em></p> <blockquote> <h2>v1.0.120</h2> <ul> <li>Correctly specify required version of <code>indexmap</code> dependency (<a href="https://redirect.github.com/serde-rs/json/issues/1152">#1152</a>, thanks <a href="https://github.com/cforycki"><code>@cforycki</code></a>)</li> </ul> <h2>v1.0.119</h2> <ul> <li>Add <code>serde_json::Map::shift_insert</code> (<a href="https://redirect.github.com/serde-rs/json/issues/1149">#1149</a>, thanks <a href="https://github.com/joshka"><code>@joshka</code></a>)</li> </ul> <h2>v1.0.118</h2> <ul> <li>Implement Hash for serde_json::Value (<a href="https://redirect.github.com/serde-rs/json/issues/1127">#1127</a>, thanks <a href="https://github.com/edwardycl"><code>@edwardycl</code></a>)</li> </ul> <h2>v1.0.117</h2> <ul> <li>Resolve unexpected_cfgs warning (<a href="https://redirect.github.com/serde-rs/json/issues/1130">#1130</a>)</li> </ul> <h2>v1.0.116</h2> <ul> <li>Make module structure comprehensible to static analysis (<a href="https://redirect.github.com/serde-rs/json/issues/1124">#1124</a>, thanks <a href="https://github.com/mleonhard"><code>@mleonhard</code></a>)</li> </ul> <h2>v1.0.115</h2> <ul> <li>Documentation improvements</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/serde-rs/json/commit/bcedc3d96bcc33184f16d63eab397295e2193350"><code>bcedc3d</code></a> Release 1.0.120</li> <li><a href="https://github.com/serde-rs/json/commit/962c0fbbecc7dc8559cfeb019c2611737512f937"><code>962c0fb</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1152">#1152</a> from cforycki/fix/index-map-minimal-version</li> <li><a href="https://github.com/serde-rs/json/commit/3480feda7b572d33992544061a8e0fbf8610a803"><code>3480fed</code></a> fix: indexmap minimal version with Map::shift_insert()</li> <li><a href="https://github.com/serde-rs/json/commit/b48b9a3a0c09952579e98c8940fe0d1ee4aae588"><code>b48b9a3</code></a> Release 1.0.119</li> <li><a href="https://github.com/serde-rs/json/commit/8878cd7c042a5f94ae4ee9889cbcbd12cc5ce334"><code>8878cd7</code></a> Make shift_insert available for inlining like other Map methods</li> <li><a href="https://github.com/serde-rs/json/commit/352b7abf007cf3b9b063b01e0b1e8f6af62a4e39"><code>352b7ab</code></a> Document the cfg required for Map::shift_insert to exist</li> <li><a href="https://github.com/serde-rs/json/commit/c17e63f6eff6cb40594beb1bddd4562c4cc81442"><code>c17e63f</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1149">#1149</a> from joshka/master</li> <li><a href="https://github.com/serde-rs/json/commit/309ef6b8870e47622a283061cbda3f5514bfaf0d"><code>309ef6b</code></a> Add Map::shift_insert()</li> <li><a href="https://github.com/serde-rs/json/commit/a9e089a2ce245bc223b56fbb6c525e2fe7b1f0ef"><code>a9e089a</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1146">#1146</a> from haouvw/master</li> <li><a href="https://github.com/serde-rs/json/commit/a83fe96ae2a202925f1caa7abc51991f321d7c22"><code>a83fe96</code></a> chore: remove repeat words</li> <li>Additional commits viewable in <a href="https://github.com/serde-rs/json/compare/v1.0.114...v1.0.120">compare view</a></li> </ul> </details> <br /> Updates `serde_yaml` from 0.9.33 to 0.9.34+deprecated <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dtolnay/serde-yaml/releases">serde_yaml's releases</a>.</em></p> <blockquote> <h2>0.9.34</h2> <p>As of this release, I am not planning to publish further versions of <code>serde_yaml</code> as none of my projects have been using YAML for a long time, so I have archived the GitHub repo and marked the crate deprecated in the version number. An official replacement isn't designated for those who still need to work with YAML, but <a href="https://crates.io/search?q=yaml&sort=relevance">https://crates.io/search?q=yaml&sort=relevance</a> and <a href="https://crates.io/keywords/yaml">https://crates.io/keywords/yaml</a> has a number of reasonable-looking options available.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dtolnay/serde-yaml/commit/2009506d33767dfc88e979d6bc0d53d09f941c94"><code>2009506</code></a> Release 0.9.34</li> <li><a href="https://github.com/dtolnay/serde-yaml/commit/3ba8462f7d3b603d832e0daeb6cfc7168a673d7a"><code>3ba8462</code></a> Add unmaintained note</li> <li><a href="https://github.com/dtolnay/serde-yaml/commit/77236b0d50f6fb670fefe8146aba02f1eab211f3"><code>77236b0</code></a> Ignore dead code lint in tests</li> <li>See full diff in <a href="https://github.com/dtolnay/serde-yaml/compare/0.9.33...0.9.34">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by:
dependabot[bot] <support@github.com> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
Przemek Rzad authored
There are slight changes required, after https://github.com/paritytech/polkadot-sdk/pull/4716. In order to follow the convention in the templates, we need to specify the internal template dependencies (runtime and a pallet) in the main `Cargo.toml`. Additionally, there are now dependencies with `path` in the main `Cargo.toml`, so we add a step with `psvm` to change those references to crate versions.
-
Jun Jiang authored
The rustc warns ``` The package `wasm-bindgen v0.2.87` currently triggers the following future incompatibility lints: > warning: older versions of the `wasm-bindgen` crate will be incompatible with future versions of Rust; please update to `wasm-bindgen` v0.2.88 > | > = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! > = note: for more information, see issue #71871 <https://github.com/rust-lang/rust/issues/71871> > ```
-
- Jul 17, 2024
-
-
Tom authored
Update the stake.plus bootnode addresses --------- Co-authored-by:
Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
-
Maksym H authored
Add cargo +nightly fmt
-
hrls authored
We want to add linter to the entire node based on a template. Just like `cargo clippy -- --deny missing_docs`. And we have the error (pasted at the end). The dummy crate is used to test whether the WASM toolchain is installed and working as expected. And for some reason this dummy crate included as a target for the linter. I added an attribute to pass the check. ``` note: To improve backtraces for build dependencies, set the CARGO_PROFILE_DEV_BUILD_OVERRIDE_DEBUG=true environment variable to enable debug information generation. Caused by: process didn't exit successfully: `/Users/hrls/src/atleta/target/debug/build/atleta-runtime-b15153eff20cbe96/build-script-build` (exit status: 1) --- stderr Rust WASM target for toolchain stable-aarch64-apple-darwin is not properly installed; please install it! Further error information: ------------------------------------------------------------ Compiling dummy-crate v1.0.0 (/var/folders/h1/_5gdnk8901n959lc28fwx8400000gn/T/.tmpUQCLaV) error: missing documentation for the crate --> src/main.rs:1:1 | 1 | fn main() {} | ^^^^^^^^^^^^ | = note: requested on the command line with `-D missing-docs` error: could not compile `dummy-crate` (bin "dummy-crate") due to 1 previous error ------------------------------------------------------------ ``` Co-authored-by:
Bastian Köcher <git@kchr.de>
-
Bastian Köcher authored
-
s0me0ne-unkn0wn authored
Closes #4951 (hopefully) @alvicsam can you please check if it passes in the new environment?
-
Alexandru Vasile authored
This release includes: https://github.com/libp2p/rust-libp2p/pull/5482 Which fixes substrate node crashing with libp2p trace: ``` 0: sp_panic_handler::set::{{closure}} 1: std::panicking::rust_panic_with_hook 2: std::panicking::begin_panic::{{closure}} 3: std::sys_common::backtrace::__rust_end_short_backtrace 4: std::panicking::begin_panic 5: <quicksink::SinkImpl<S,F,T,A,E> as futures_sink::Sink<A>>::poll_ready 6: <rw_stream_sink::RwStreamSink<S> as futures_io::if_std::AsyncWrite>::poll_write 7: <libp2p_noise::io::framed::NoiseFramed<T,S> as futures_sink::Sink<&alloc::vec::Vec<u8>>>::poll_ready 8: <libp2p_noise::io::Output<T> as futures_io::if_std::AsyncWrite>::poll_write 9: <yamux::frame::io::Io<T> as futures_sink::Sink<yamux::frame::Frame<()>>>::poll_ready 10: yamux::connection::Connection<T>::poll_next_inbound 11: <libp2p_yamux::Muxer<C> as libp2p_core::muxing::StreamMuxer>::poll 12: <libp2p_core::muxing::boxed::Wrap<T> as libp2p_core::muxing::StreamMuxer>::poll 13: <libp2p_core::muxing::boxed::Wrap<T> as libp2p_core::muxing::StreamMuxer>::poll 14: libp2p_swarm::connection::pool::task::new_for_established_connection::{{closure}} 15: <sc_service::task_manager::prometheus_future::PrometheusFuture<T> as core::future::future::Future>::poll 16: <futures_util::future::select::Select<A,B> as core::future::future::Future>::poll 17: <tracing_futures::Instrumented<T> as core::future::future::Future>::poll 18: std::panicking::try 19: tokio::runtime::task::harness::Harness<T,S>::poll 20: tokio::runtime::scheduler::multi_thread::worker::Context::run_task 21: tokio::runtime::scheduler::multi_thread::worker::Context::run 22: tokio::runtime::context::set_scheduler 23: tokio::runtime::context::runtime::enter_runtime 24: tokio::runtime::scheduler::multi_thread::worker::run 25: tokio::runtime::task::core::Core<T,S>::poll 26: tokio::runtime::task::harness::Harness<T,S>::poll 27: std::sys_common::backtrace::__rust_begin_short_backtrace 28: core::ops::function::FnOnce::call_once{{vtable.shim}} 29: std::sys::pal::unix::thread::Thread::new::thread_start 30: <unknown> 31: <unknown> Thread 'tokio-runtime-worker' panicked at 'SinkImpl::poll_ready called after error.', /home/ubuntu/.cargo/registry/src/index.crates.io-6f17d22bba15001f/quicksink-0.1.2/src/lib.rs:158 ``` Closes: https://github.com/paritytech/polkadot-sdk/issues/4934 --------- Signed-off-by:
Alexandru Vasile <alexandru.vasile@parity.io>
-
Sebastian Kunert authored
After the merge of #4922 we saw failing zombienet tests with the following error: ``` 2024-07-09 10:30:09 Error applying finality to block (0xb9e1d3d9cb2047fe61667e28a0963e0634a7b29781895bc9ca40c898027b4c09, 56685): UnknownBlock: Header was not found in the database: 0x0000000000000000000000000000000000000000000000000000000000000000 2024-07-09 10:30:09 GRANDPA voter error: could not complete a round on disk: UnknownBlock: Header was not found in the database: 0x0000000000000000000000000000000000000000000000000000000000000000 ``` [Example](https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6662262) The crashing situation is warp-sync related. After warp syncing, it can happen that there are gaps in block ancestry where we don't have the header. At the same time, the genesis hash is in the set of leaves. In `displaced_leaves_after_finalizing` we then iterate from the finalized block backwards until we hit an unknown block, crashing the node. This PR makes the detection of displaced branches resilient against unknown block in the finalized block chain. cc @nazar-pc (github won't let me request a review from you) --------- Co-authored-by:
Bastian Köcher <git@kchr.de> Co-authored-by: command-bot <>
-
Egor_P authored
This PR contains adjustments of the node release pipelines so that it will be possible to use those to trigger release actions based on the `stable` branch. Previously the whole pipeline of the flows from [creation of the `rc-tag`](https://github.com/paritytech/polkadot-sdk/blob/master/.github/workflows/release-10_rc-automation.yml) (v1.15.0-rc1, v1.15.0-rc2, etc) till [the release draft creation](https://github.com/paritytech/polkadot-sdk/blob/master/.github/workflows/release-30_publish_release_draft.yml) was triggered on push to the node release branch. As we had the node release branch and the crates release branch separately, it worked fine. From now on, as we are switching to the one branch approach, for the first iteration I would like to keep things simple to see how the new release process will work with both parts (crates and node) made from one branch. Changes made: - The first step in the pipeline (rc-tag creation) will be triggered manually instead of the push to the branch - The tag version will be set manually from the input instead of to be taken from the branch name - Docker image will be additionally tagged as `stable` Closes: https://github.com/paritytech/release-engineering/issues/214
-
Alin Dima authored
Resolves https://github.com/paritytech/polkadot-sdk/issues/4468 Gives instructions on how to enable elastic scaling MVP to parachain teams. Still a draft because it depends on further changes we make to the slot-based collator: https://github.com/paritytech/polkadot-sdk/pull/4097 Parachains cannot use this yet because the collator was not released and no relay chain network has been configured for elastic scaling yet
-
- Jul 16, 2024
-
-
Andrei Eres authored
Closes https://github.com/paritytech/polkadot-sdk/issues/577 ### Changed - `orchestra` updated to 0.4.0 - `PeerViewChange` sent with high priority and should be processed first in a queue. - To count them in tests added tracker to TestSender and TestOverseer. It acts more like a smoke test though. ### Testing on Versi The changes were tested on Versi with two objectives: 1. Make sure the node functionality does not change. 2. See how the changes affect performance. Test setup: - 2.5 hours for each case - 100 validators - 50 parachains - validatorsPerCore = 2 - neededApprovals = 100 - nDelayTranches = 89 - relayVrfModuloSamples = 50 During the test period, all nodes ran without any crashes, which satisfies the first objective. To estimate the change in performance we used ToF charts. The graphs show that there are no spikes in the top as before. This proves that our hypothesis is correct. ### Normalized charts with ToF  [Before](https://grafana.teleport.parity.io/goto/ZoR53ClSg?orgId=1)  [After](https://grafana.teleport.parity.io/goto/6ux5qC_IR?orgId=1) ### Conclusion The prioritization of subsystem messages reduces the ToF of the networking subsystem, which helps faster propagation of gossip messages.
-
Alexander Samusev authored
cc https://github.com/paritytech/ci_cd/issues/939
-
Andrei Eres authored
A baseline for the statement-distribution regression test was set only in the beginning and now we see that the actual values a bit lower. <img width="1001" alt="image" src="https://github.com/user-attachments/assets/40b06eec-e38f-43ad-b437-89eca502aa66"> [Source](https://paritytech.github.io/polkadot-sdk/bench/statement-distribution-regression-bench)
-
Sebastian Miasojed authored
Introduce transient storage, which behaves identically to regular storage but is kept only in memory and discarded after every transaction. This functionality is similar to the `TSTORE` and `TLOAD` operations used in Ethereum. The following new host functions have been introduced: `get_transient_storage` `set_transient_storage` `take_transient_storage` `clear_transient_storage` `contains_transient_storage` Note: These functions are declared as `unstable` and thus are not activated. --------- Co-authored-by: command-bot <> Co-authored-by:
PG Herveou <pgherveou@gmail.com> Co-authored-by:
Alexander Theißen <alex.theissen@me.com>
-
Alexandru Gheorghe authored
This is part of the work to further optimize the approval subsystems, if you want to understand the full context start with reading https://github.com/paritytech/polkadot-sdk/pull/4849#issue-2364261568, however that's not necessary, as this change is self-contained and nodes would benefit from it regardless of subsequent changes landing or not. While testing with 1000 validators I found out that the logic for determining the validators an assignment should be gossiped to is taking a lot of time, because it always iterated through all the peers, to determine which are X and Y neighbours and to which we should randomly gossip(4 samples). This could be actually optimised, so we don't have to iterate through all peers for each new assignment, by fetching the list of X and Y peer ids from the topology first and then stopping the loop once we took the 4 random samples. With this improvements we reduce the total CPU time spent in approval-distribution with 15% on networks with 500 validators and 20% on networks with 1000 validators. ## Test coverage: `propagates_assignments_along_unshared_dimension` and `propagates_locally_generated_assignment_to_both_dimensions` cover already logic and they passed, confirm that there is no breaking change. Additionally, the approval voting benchmark measure the traffic sent to other peers, so I confirmed that for various network size there is no difference in the size of the traffic sent to other peers. --------- Signed-off-by:
Alexandru Gheorghe <alexandru.gheorghe@parity.io>
-
Parth Mittal authored
As per #3326, removes usage of the `pallet::getter` macro from the `session` pallet. The syntax `StorageItem::<T, I>::get()` should be used instead. Also, adds public functions for compatibility. NOTE: The `./historical` directory has not been modified. cc @muraca polkadot address: 5GsLutpKjbzsbTphebs9Uy4YK6gTN47MAaz6njPktidjR5cp --------- Co-authored-by:
Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by:
Bastian Köcher <git@kchr.de>
-
Javyer authored
This will ensure that malicious code can not access other parts of the project. Co-authored-by:
Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by:
Bastian Köcher <git@kchr.de>
-