Skip to content
  1. Nov 15, 2023
    • Alexander Samusev's avatar
      [CI] Prepare CI for Merge Queues (#2308) · 5b0622bc
      Alexander Samusev authored 
      PR prepares CI to the GitHub Merge Queues. All github actions that were
running in PR adjusted so they can run in the merge queues. Zombienet
jobs will do nothing during PRs but they will run during merge queues.

Jobs that will be skipped during PR:
 - all zombienet jobs
 - all publish docker jobs

Jobs that will be skipped during merge queue:
 - check-labels
 - check-prdoc
 - pr-custom-review
 - review trigger

cc https://github.com/paritytech/ci_cd/issues/862
      5b0622bc
  3. Nov 14, 2023
  5. Nov 13, 2023
    • Javyer's avatar
      review-bot: trigger only on review approvals (#2289) · 8d263790
      Javyer authored 
      Moved the review event of review-bot to only be triggered in approvals.

Because we only update the required reviews when someone approves, this
will stop the bot from immediately requesting a new review when someone
comments or request changes as they should have been already notified in
the first batch.
      8d263790
    • Lulu's avatar
      Add CI to claim crates (#2299) · c7bd8804
      Lulu authored
      c7bd8804
  7. Nov 08, 2023
  9. Nov 03, 2023
  11. Nov 01, 2023
  13. Oct 31, 2023
  15. Oct 27, 2023
  17. Oct 24, 2023
  19. Oct 19, 2023
  21. Oct 18, 2023
  23. Oct 16, 2023
  25. Oct 04, 2023
  27. Sep 29, 2023
  29. Sep 28, 2023
    • Mira Ressel's avatar
      fix(review-bot): pull secrets from `master` environment (#1745) · 7ca0d65f
      Mira Ressel authored
      7ca0d65f
    • Javyer's avatar
      Added `review-bot` to fine tune review requirements (#1673) · 4384c613
      Javyer authored 
      Created a Github Action that uses the [Review-Bot
app](https://github.com/paritytech/review-bot) to require more fine
tuned requirements to review pull requests before allowing the PR to be
merged.

This uses
[`pull_request_target`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target)
for the event, not `pull_request`. This is a security measure so that an
attacker doesn’t have access to the secrets.

All the rules have been copied from the original
`.github/pr-custom-review.yml` file.

I want to clarify, this particular commit is **not intended to replace
PRCR yet**.

# Advantages it brings over `PRCR`

Most of the features available in `PRCR` have been duplicated and
enhanced. For a complete detailed write up, please see:
- paritytech/pr-custom-review#114 -> Proposal for the rewrite
- [Review Bot
Documentation](https://github.com/paritytech/review-bot/blob/main/README.md)

The most important features are:
- `include` and `exclude` fields now accept an array, making it easier
to read the regular expressions.
- Ability to skip a rule
- We can set that PRs coming from a particular user or team will cause
the rule to be skipped.
- This is used in the `Audit rule`, which was requested by
@the-right-joyce.
  - This resolves paritytech/pr-custom-review#136
- Ability to request fellows instead of teams
- As requested in polkadot-fellows/runtimes#7, this bot has the ability
to request fellows by rank instead of users.
- We currently have polkadot-fellows/runtimes#31 which is using that
feature.

Aside from all the rules available in `PRCR` I have added a particular
rule to lock the review-bot files and require a review from the
`locks-review` team, the @paritytech/ci team and the
@paritytech/opstooling team to ensure that the file has been written
correctly.

## Next steps

The next steps will consist on paritytech/review-bot#53, once this issue
has been resolved, and `review-bot` has worked without any issues on
this repository for a while, we will upgrade it to be able to fully
replace `PRCR`.
      4384c613
  31. Sep 25, 2023
  33. Sep 18, 2023
  35. Sep 13, 2023
  37. Sep 11, 2023
  39. Sep 08, 2023
  41. Sep 07, 2023