Skip to content
  1. Jul 22, 2023
    • jserrat's avatar
      add tests to worker common thread (#7372) · 3f8c3454
      jserrat authored
      
      
      * add tests to worker common thread
      
      * fix formatting
      
      * move worker commons unit test from integration tests to worker file and do some improvements
      
      * fix import on it/worker_common
      
      * move worker commons unit test to test module
      
      * cargo fmt
      
      * move cpu_time_monitor_loop to test outside of thread module
      
      * change worker thread unit test to use assert_eq
      
      * fix formatting
      
      * adding new methods to WaitOucome, fix pvf worker unit test
      
      * fix formatting
      
      * remove is_finished and is_timeout methods from WaitOutcome
      
      * fix wait_for_threads_with_timeout_returns_outcome test
      
      * ".git/.scripts/commands/fmt/fmt.sh"
      
      * add common worker cond_notify_on_done_should_update_wait_outcome_when_panic test
      
      ---------
      
      Co-authored-by: default avatarMarcin S <[email protected]>
      Co-authored-by: command-bot <>
      3f8c3454
  2. Jul 21, 2023
  3. Jul 20, 2023
  4. Jul 19, 2023
    • Francisco Aguirre's avatar
      Change Fixed to WeightInfoBounds for Polkadot (#7077) · cc9f8129
      Francisco Aguirre authored
      
      
      * Add polkadot XCM benchmarks
      
      * Add temp
      
      * ".git/.scripts/commands/bench/bench.sh" xcm polkadot pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench/bench.sh" xcm polkadot pallet_xcm_benchmarks::generic
      
      * Add weights to XCM on Polkadot
      
      * Make CI fail on old files
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Update template
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Add reserve_asset_deposited benchmark
      
      * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::generic
      
      * Update weights
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Change initiate_reserve_deposit in runtime weights
      
      * Update weights
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Remove trusted reserves from runtimes
      
      * Fix pallet-xcm-benchmarks mock
      
      * Fix test
      
      * Change pallet xcm weigher in kusama
      
      * Fix
      
      * Remove merge conflict artifact
      
      * Remove initiate_reserve_withdraw from generic benchmarks
      
      * Add missing implementation to XCM benchmark
      
      * Fix failing karura test
      
      * Remove dbg!
      
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      
      * Fix fmt
      
      * Revert "Fix fmt"
      
      This reverts commit 676f2d8db07d7427750c79f95494d4988d06fda5.
      
      * Fix fmt
      
      * Remove duplicated template code
      
      * Add back part of the template
      
      * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible
      
      * Don't skip reserve asset deposited benchmark
      
      * Remove call to non-generated benchmark yet
      
      * Underscore unused parameter
      
      * Skip not supported benchmarks and hardcode value
      
      * Remove ReserveAssetDeposited benchmark
      
      * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible
      
      * Add back ReserveAssetDeposited
      
      * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible
      
      * Use default benchmark for ReserveAssetDeposited
      
      * Add missing parameter
      
      * Revert reserve asset deposited benchmark
      
      * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm kusama pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm westend pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench/bench.sh" xcm rococo pallet_xcm_benchmarks::fungible
      
      * Add 'real' benchmarks
      
      * Add TrustedReserve to actual XcmConfig
      
      * Add TrustedReserve to actual XcmConfig (fix)
      
      * Whitelist from benchmarking XCM storage keys read each block (#6871)
      
      * Whitelist from benchmarking XCM storage keys read each block
      
      * ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm
      
      * ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm
      
      * ".git/.scripts/commands/bench/bench.sh" runtime westend pallet_xcm
      
      * ".git/.scripts/commands/bench/bench.sh" runtime rococo pallet_xcm
      
      * Remove XcmPallet SupportedVersion from the benchmark whitelist
      
      * ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm
      
      * ".git/.scripts/commands/bench/bench.sh" runtime kusama pallet_xcm
      
      * ".git/.scripts/commands/bench/bench.sh" runtime westend pallet_xcm
      
      * ".git/.scripts/commands/bench/bench.sh" runtime rococo pallet_xcm
      
      * WIP
      
      * Add necessary traits, remove unnecessary whitelisted keys
      
      * Fix tests
      
      * Remove unused file
      
      * Remove unused import
      
      ---------
      
      Co-authored-by: command-bot <>
      
      * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench/bench.sh" xcm rococo pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench/bench.sh" xcm westend pallet_xcm_benchmarks::fungible
      
      * Fix spellchecker issues
      
      * Remove unused migration code
      
      ---------
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      Co-authored-by: command-bot <>
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      cc9f8129
  5. Jul 18, 2023
    • Michal Kucharczyk's avatar
      `chain-spec`: `polkadot_staging_testnet` config removed (#7509) · b15a5697
      Michal Kucharczyk authored
      * chain-spec: polkadot_staging_testnet config removed
      
      The config has empty initial authority test. It is unusable.
      
      ```
      $ polkadot export-blocks --chain polkadot-staging --from=0 --to=0
      ...
      Thread 'main' panicked at 'Empty validator set for session 0 in genesis block!',
      /home/miszka/.cargo/git/checkouts/substrate-7e08433d4c370a21/c446786/frame/session/src/lib.rs:463
      ```
      
      * warning fix
      b15a5697
    • André Silva's avatar
      companion for substrate#14423 (#7484) · 9f760192
      André Silva authored
      * companion for substrate#14423
      
      * update lockfile for {"substrate"}
      
      * update lockfile for {"substrate"}
      
      ---------
      
      Co-authored-by: parity-processbot <>
      9f760192
  6. Jul 17, 2023
    • Andrei Eres's avatar
      Alert on frequent network errors (#7410) · 174f23d1
      Andrei Eres authored
      * Introduce is_frequent util
      
      * Add dirty warn_if_frequent! implementation
      
      * Add freq
      
      * Fix order in condition
      
      * Update
      
      * Update docs
      
      * Fix
      
      * Remove old impl
      
      * Fix errors
      
      * Add wif to av-distr
      
      * Add wif to col prot
      
      * Rename
      
      * Add wif to state-distr
      
      * Address review comments
      
      * Change Freq implementation
      
      * Remove the zero division check
      
      * Make rate explicit
      
      * Fix typo
      
      * Update rate constant
      
      * Introduce explicit rates
      
      * Update docs
      
      * Split errors freq
      
      * Downgrade coarsetime
      174f23d1
  7. Jul 12, 2023
  8. Jul 11, 2023
    • Bastian Köcher's avatar
      Companion for removal of execution strategies (#7443) · 0ff60f7d
      Bastian Köcher authored
      * Companion for removal of execution strategies
      
      https://github.com/paritytech/substrate/pull/14387
      
      * Fix some tests
      
      * 🤦
      
      * Adapt to latest changes
      
      * Start supporting the offchain transaction pool
      
      * Fix tests
      
      * FMT
      
      * Remove patches
      
      * Update Substrate
      
      * update lockfile for {"substrate"}
      
      * Fix parachain upgrade smoke test
      
      * Fix test
      
      * Rewrite all tests to use `MockSubstemClient`
      
      ---------
      
      Co-authored-by: parity-processbot <>
      0ff60f7d
  9. Jul 07, 2023
  10. Jul 06, 2023
  11. Jul 05, 2023
    • Marcin S.'s avatar
      PVF: add landlock sandboxing (#7303) · 2b9c4f82
      Marcin S. authored
      
      
      * Begin adding landlock + test
      
      * Move PVF implementer's guide section to own page, document security
      
      * Implement test
      
      * Add some docs
      
      * Do some cleanup
      
      * Fix typo
      
      * Warn on host startup if landlock is not supported
      
      * Clarify docs a bit
      
      * Minor improvements
      
      * Add some docs about determinism
      
      * Address review comments (mainly add warning on landlock error)
      
      * Update node/core/pvf/src/host.rs
      
      Co-authored-by: default avatarAndrei Sandu <[email protected]>
      
      * Update node/core/pvf/src/host.rs
      
      Co-authored-by: default avatarAndrei Sandu <[email protected]>
      
      * Fix unused fn
      
      * Update ABI docs to reflect latest discussions
      
      * Remove outdated notes
      
      * Try to trigger new test-linux-oldkernel-stable job
      
      Job introduced in https://github.com/paritytech/polkadot/pull/7371.
      
      ---------
      
      Co-authored-by: default avatarAndrei Sandu <[email protected]>
      2b9c4f82
    • Bastian Köcher's avatar
      Companion for Substrate#14511 (#7459) · a40417da
      Bastian Köcher authored
      * Companion for Substrate#14511
      
      https://github.com/paritytech/substrate/pull/14511
      
      * Make benchmarking build without any native runtime
      
      * Fix warning
      
      * update lockfile for {"substrate"}
      
      ---------
      
      Co-authored-by: parity-processbot <>
      a40417da
  12. Jul 04, 2023
  13. Jun 29, 2023
  14. Jun 23, 2023
  15. Jun 22, 2023
  16. Jun 21, 2023
  17. Jun 16, 2023
    • juangirini's avatar
      Companion for Soft deprecate GenesisConfig (#7288) · ced77b3d
      juangirini authored
      * update genesis config
      
      * fix wrong RuntimeGenesisConfig name
      
      * update lockfile for {"substrate"}
      
      ---------
      
      Co-authored-by: parity-processbot <>
      ced77b3d
    • Mira Ressel's avatar
      docs: update references to NetworkConfiguration::extra_sets (#7386) · e7560710
      Mira Ressel authored
      * docs: update references to NetworkConfiguration::extra_sets
      
      Since paritytech/substrate#14080, this struct field no longer exists,
      now the `add_notification_protocol()` function of
      `sc_network::config::FullNetworkConfiguration` is used.
      
      Also neuter the doc links for now; rustdoc can't resolve them
      (presumably because sc_network::config isn't in scope, though weirdly
      enough even spelling the link out as
      ``[`FullNetworkConfiguration`](struct@sc_network::config::FullNetworkConfiguration)``
      doesn't work?). Normally this wouldn't be an issue and rustdoc would
      just not generate links, but rust 1.70 has a bug that completely crashes
      rustdoc in this case.
      e7560710
    • Aaro Altonen's avatar
      Wait peers to connect before doing anything else (#7375) · 134655ee
      Aaro Altonen authored
      There is a race condition in `NetworkBridgeRx` between registering
      incoming peers and handling overseer signals. While the peer connection
      was sent to `NetworkBridgeRx` first, sometimes the peer would be added to
      `validation/collation_peers` with enough delay that the bridge handled
      an overseer signal that was meant do send notifications to the registered
      peer and as the peer was not present in the bridge, the notification was
      never sent and the test would hang.
      
      When peers are registered to `NetworkBridgeRx` using `connect_peer()`,
      wait until they show up in `shared.validation/collation_peers` before
      doing anything else.
      
      Co-authored-by: parity-processbot <>
      134655ee
  18. Jun 15, 2023
    • Andrei Eres's avatar
      Delay reputation updates (#7214) · 0a1bc654
      Andrei Eres authored
      
      
      * Add futures-timer
      
      * Make cost_or_benefit public
      
      * Update ReportPeer message format
      
      * Add delay to reputation updates (dirtywork)
      
      * Update ReputationAggregator
      
      * Update tests
      
      * Fix flucky tests
      
      * Move reputation to state
      
      * Use the main loop for handling reputation sendings
      
      * Update
      
      * Move reputation to utils
      
      * Update reputation sending
      
      * Fix arguments order
      
      * Update state
      
      * Remove new from state
      
      * Add constant
      
      * Add failing test for delay
      
      * Change mocking approach
      
      * Fix type errors
      
      * Fix comments
      
      * Add message handling to select
      
      * Fix bitfields-distribution tests
      
      * Add docs to reputation aggregator
      
      * Replace .into_base_rep
      
      * Use one REPUTATION_CHANGE_INTERVAL by default
      
      * Add reputation change to statement-distribution
      
      * Update polkadot-availability-bitfield-distribution
      
      * Update futures selecting in subsystems
      
      * Update reputation adding
      
      * Send malicious changes right away without adding to state
      
      * Add reputation to StatementDistributionSubsystem
      
      * Handle reputation in statement distribution
      
      * Add delay test for polkadot-statement-distribution
      
      * Fix collator-protocol tests before applying reputation delay
      
      * Remove into_base_rep
      
      * Add reputation to State
      
      * Fix failed tests
      
      * Add reputation delay
      
      * Update tests
      
      * Add batched network message for peer reporting
      
      * Update approval-distribution tests
      
      * Update bitfield-distribution tests
      
      * Update statement-distribution tests
      
      * Update collator-protocol tests
      
      * Remove levels in matching
      
      * Address clippy errors
      
      * Fix overseer test
      
      * Add a metric for original count of rep changes
      
      * Update Reputation
      
      * Revert "Add a metric for original count of rep changes"
      
      This reverts commit 6c9b0c1ec34491d16e562bdcba8db6b9dcf484db.
      
      * Update node/subsystem-util/src/reputation.rs
      
      Co-authored-by: default avatarVsevolod Stakhov <[email protected]>
      
      * Remove redundant vec
      
      ---------
      
      Co-authored-by: default avatarVsevolod Stakhov <[email protected]>
      0a1bc654
  19. Jun 14, 2023
    • Andrei Sandu's avatar
      adjust buckets (#7368) · edfbbc8c
      Andrei Sandu authored
      
      
      Signed-off-by: default avatarAndrei Sandu <[email protected]>
      edfbbc8c
    • eskimor's avatar
      Unify code paths of create_inherent and enter (#7137) · 596a9ccd
      eskimor authored
      
      
      * Remove redundant enter call.
      
      * Remove optionality in dispute signature checking
      
      * Make enter_inner and create_inherent the same.
      
      * Remove redundant metric.
      
      * Unification: enter and create_inherent.
      
      * Remove `enter_inner` function.
      
      * Remove dead code.
      
      * Remove redundant import.
      
      * Remove dead code in disputes.
      
      * ".git/.scripts/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras_inherent
      
      * ".git/.scripts/commands/bench/bench.sh" runtime kusama runtime_parachains::paras_inherent
      
      * ".git/.scripts/commands/bench/bench.sh" runtime westend runtime_parachains::paras_inherent
      
      * Merge fix.
      
      * Fix tests.
      
      * Remove obsolete comment.
      
      * ".git/.scripts/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras_inherent
      
      * ".git/.scripts/commands/bench/bench.sh" runtime westend runtime_parachains::paras_inherent
      
      * ".git/.scripts/commands/bench/bench.sh" runtime kusama runtime_parachains::paras_inherent
      
      * Review remarks, fixes.
      
      * Guide updates.
      
      * Fmt.
      
      * ".git/.scripts/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras_inherent
      
      ---------
      
      Co-authored-by: default avatareskimor <[email protected]>
      Co-authored-by: command-bot <>
      596a9ccd
  20. Jun 12, 2023
  21. Jun 11, 2023
  22. Jun 08, 2023
  23. Jun 06, 2023
  24. Jun 05, 2023
    • ordian's avatar
      dispute-coordinator: past session dispute slashing (#6811) · 01a19b45
      ordian authored
      
      
      * runtime/vstaging: unapplied_slashes runtime API
      
      * runtime/vstaging: key_ownership_proof runtime API
      
      * runtime/ParachainHost: submit_report_dispute_lost
      
      * fix key_ownership_proof API
      
      * runtime: submit_report_dispute_lost runtime API
      
      * nits
      
      * Update node/subsystem-types/src/messages.rs
      
      Co-authored-by: default avatarMarcin S. <[email protected]>
      
      * revert unrelated fmt changes
      
      * dispute-coordinator: past session dispute slashing
      
      * encapsule runtime api call for submitting report
      
      * prettify: extract into a function
      
      * do not exit on runtime api error
      
      * fix tests
      
      * try initial zombienet test
      
      * try something
      
      * fix a typo
      
      * try cumulus-based collator
      
      * fix clippy
      
      * build polkadot-debug images with fast-runtime enabled
      
      * wip
      
      * runtime/inclusion: fix availability_threshold
      
      * fix wip
      
      * fix wip II
      
      * revert native provider
      
      * propagate tx submission error
      
      * DEBUG: sync=trace
      
      * print key ownership proof len
      
      * panic repro
      
      * log validator index in panic message
      
      * post merge fixes
      
      * replace debug assertion with a log
      
      * fix compilation
      
      * Let's log the dispatch info in validate block.
      
      * fix double encoding
      
      * Revert "Let's log the dispatch info in validate block."
      
      This reverts commit a70fbc51b464d7f4355dbada5e16cd83cf71eab4.
      
      * Revert "Let's log the dispatch info in validate block."
      
      This reverts commit a70fbc51b464d7f4355dbada5e16cd83cf71eab4.
      
      * fix compilation
      
      * update to latest zombienet and fix test
      
      * lower finality lag to 11
      
      * bump zombienet again
      
      * add a workaround, but still does not work
      
      * Update .gitlab-ci.yml
      
      bump zombienet.
      
      * add a comment and search logs on all nodes
      
      ---------
      
      Co-authored-by: default avatarMarcin S. <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: default avatarJavier Viola <[email protected]>
      01a19b45
  25. Jun 02, 2023
    • Marcin S.'s avatar
      PVF: Instantiate wasm in pre-checking (#7246) · 5bbb87c4
      Marcin S. authored
      * PVF: Instantiate wasm in pre-checking
      
      * Move `runtime_construction_check` to prepare thread, use bytes
      
      * [minor] Update comment
      
      * Fix compile error
      
      * Update Cargo.lock
      
      * Update docs
      
      * Add some missing docs!
      5bbb87c4
  26. May 31, 2023
  27. May 30, 2023
    • Tsvetomir Dimitrov's avatar
      `RollingSessionWindow` cleanup (#7204) · eb1ed63b
      Tsvetomir Dimitrov authored
      
      
      * Replace `RollingSessionWindow` with `RuntimeInfo` - initial commit
      
      * Fix tests in import
      
      * Fix the rest of the tests
      
      * Remove dead code
      
      * Fix todos
      
      * Simplify session caching
      
      * Comments for `SessionInfoProvider`
      
      * Separate `SessionInfoProvider` from `State`
      
      * `cache_session_info_for_head` becomes freestanding function
      
      * Remove unneeded `mut` usage
      
      * fn session_info -> fn get_session_info() to avoid name clashes. The function also tries to initialize `SessionInfoProvider`
      
      * Fix SessionInfo retrieval
      
      * Code cleanup
      
      * Don't wrap `SessionInfoProvider` in an `Option`
      
      * Remove `earliest_session()`
      
      * Remove pre-caching -> wip
      
      * Fix some tests and code cleanup
      
      * Fix all tests
      
      * Fixes in tests
      
      * Fix comments, variable names and small style changes
      
      * Fix a warning
      
      * impl From<SessionWindowSize> for NonZeroUsize
      
      * Fix logging for `get_session_info` - remove redundant logs and decrease log level to DEBUG
      
      * Code review feedback
      
      * Storage migration removing `COL_SESSION_WINDOW_DATA` from parachains db
      
      * Remove `col_session_data` usages
      
      * Storage migration clearing columns w/o removing them
      
      * Remove session data column usages from `approval-voting` and `dispute-coordinator` tests
      
      * Add some test cases from `RollingSessionWindow` to `dispute-coordinator` tests
      
      * Fix formatting in initialized.rs
      
      * Fix a corner case in `SessionInfo` caching for `dispute-coordinator`
      
      * Remove `RollingSessionWindow` ;(
      
      * Revert "Fix formatting in initialized.rs"
      
      This reverts commit 0f94664ec9f3a7e3737a30291195990e1e7065fc.
      
      * v2 to v3 migration drops `COL_DISPUTE_COORDINATOR_DATA` instead of clearing it
      
      * Fix `NUM_COLUMNS` in `approval-voting`
      
      * Use `columns::v3::NUM_COLUMNS` when opening db
      
      * Update node/service/src/parachains_db/upgrade.rs
      
      Co-authored-by: default avatarAndrei Sandu <[email protected]>
      
      * Don't write in `COL_DISPUTE_COORDINATOR_DATA` for `test_rocksdb_migrate_2_to_3`
      
      * Fix `NUM+COLUMNS` in approval_voting
      
      * Fix formatting
      
      * Fix columns usage
      
      * Clarification comments about the different db versions
      
      ---------
      
      Co-authored-by: default avatarAndrei Sandu <[email protected]>
      eb1ed63b
  28. May 29, 2023
  29. May 26, 2023