Skip to content
  1. Dec 01, 2021
  3. Nov 30, 2021
    • Sergey Pepyakin's avatar
      pvf-precheck: Candidate Validation Changes (#4409) · 8f75230e
      Sergey Pepyakin authored 
      

* pvf-precheck: Candidate Validation Changes

Co-authored-by: default avatarChris Sosnin <[email protected]>

* Rename `MockValidationBackend` and specialize it

* Add pre-check tests

Co-authored-by: default avatarChris Sosnin <[email protected]>
      8f75230e
    • Enoch Chejieh's avatar
      Update system event variants (#4339) · 27d001db
      Enoch Chejieh authored 
      

* chore: update system event variants

* chore: update system event variants

* chore: modified event variants

* Update Substrate

Co-authored-by: default avatarBastian Köcher <[email protected]>
      27d001db
    • dependabot[bot]'s avatar
      Bump clap from 2.33.3 to 2.34.0 (#4414) · 0cca1d04
      dependabot[bot] authored 
      

Bumps [clap](https://github.com/clap-rs/clap) from 2.33.3 to 2.34.0.
- [Release notes](https://github.com/clap-rs/clap/releases)
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md)
- [Commits](https://github.com/clap-rs/clap/commits)

---
updated-dependencies:
- dependency-name: clap
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: default avatardependabot[bot] <[email protected]>

Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      0cca1d04
    • Robert Klotzner's avatar
      Double time we give spawned tasks. (#4415) · ce27250c
      Robert Klotzner authored 
      * Double time we give spawned tasks.

* Increase time even more, for better robustness.
      ce27250c
    • zjb0807's avatar
      Companion for #10324 - update frame-benchmarking/runtime-benchmarks (#4387) · a7843702
      zjb0807 authored 
      

* update frame-benchmarking/runtime-benchmarks

* Update Substrate

Co-authored-by: default avatarBastian Köcher <[email protected]>
      a7843702
    • Lldenaurois's avatar
      Revert "remove provisioner checks (#4254)" (#4375) · 22431214
      Lldenaurois authored 
      * Revert "remove provisioner checks (#4254)"

This reverts commit d5d916a9.

* Remove TODO in implementer's guide
      22431214
    • Chevdor's avatar
      Pin changelogerator to the latest compatible version for the current flow (#4392) · 6af739a8
      Chevdor authored
      6af739a8
    • Sergey Pepyakin's avatar
      pvf-precheck: Add `PvfCheckStatement` to polkadot-primitives (#4406) · 5e5aa668
      Sergey Pepyakin authored 
      * pvf-precheck: Add `sign` in subsystem-util

Right now, most of operations that sign stuff in polkadot protocol are
handled by a very convenient tool - `Signed`. However `Signed` assumes
that whatever is signed is anchored to some `parent_hash` which works
for most cases, but does not work for others.

One instance of such a case is pre-checking (#3211). There validators
submit signed votes on-chain. A vote is valid for the entire session. If
we were to use `Signed` we would have to root a vote in some block of
that session and during vote verification check that this block is
indeed within the session. This is especially annoying since we agreed
to use unsigned extrinsics to submit votes and we need to make the
unsigned extrinsic validation as slim as possible.

(FWIW, the definition of a pre-checking vote can be seen in the next
diff in the stack)

That's the reason why we opted-out from using `Signed` for pre-checking
and decided to go with the manual signing approach. Almost every piece
of machinery is in place except for signing which is presented in this
PR.

* pvf-precheck: Add `PvfCheckStatement` to polkadot-primitives

This is an insubstantial PR that just unlocks PRs down the line. This PR
is a part of #3211.

Regarding the `PvfCheckStatement` struct itself: this is a structure
that will be used to convert from/into the binary representation and
ultimately will be used to sign and submit votes onto chain.
      5e5aa668
    • Sergey Pepyakin's avatar
      pvf-precheck: Add `sign` in subsystem-util (#4407) · 9f778ccf
      Sergey Pepyakin authored 
      Right now, most of operations that sign stuff in polkadot protocol are
handled by a very convenient tool - `Signed`. However `Signed` assumes
that whatever is signed is anchored to some `parent_hash` which works
for most cases, but does not work for others.

One instance of such a case is pre-checking (#3211). There validators
submit signed votes on-chain. A vote is valid for the entire session. If
we were to use `Signed` we would have to root a vote in some block of
that session and during vote verification check that this block is
indeed within the session. This is especially annoying since we agreed
to use unsigned extrinsics to submit votes and we need to make the
unsigned extrinsic validation as slim as possible.

(FWIW, the definition of a pre-checking vote can be seen in the next
diff in the stack)

That's the reason why we opted-out from using `Signed` for pre-checking
and decided to go with the manual signing approach. Almost every piece
of machinery is in place except for signing which is presented in this
PR.
      9f778ccf
    • Bernhard Schuster's avatar
      make chain selection typed and more explicit in naming and logging (#4345) · 13f0e5d7
      Bernhard Schuster authored 
      * minor: assure conditions match

This simplifies visual integrity checks that an overseer is connected
when it has to be.

* fix: avoid printing a misleading log in case of the disabled disputes feature

* chore: comments

* add expressive types for the selection algorithm
      13f0e5d7
  5. Nov 29, 2021
  7. Nov 28, 2021
  9. Nov 27, 2021
  11. Nov 26, 2021
    • Sergey Pepyakin's avatar
      Do not log PVF prunning every hour (#4372) · f6b42151
      Sergey Pepyakin authored 
      This lowers the level of the PVF pruning.

Closes https://github.com/paritytech/polkadot/issues/4361
      f6b42151
    • Sergey Pepyakin's avatar
      Impose new restrictions on paras init and cleanup (#4360) · bce0e5ac
      Sergey Pepyakin authored 
      * Impose new restrictions on paras init and cleanup

For upcoming PVF pre-checking feature we will need to impose a couple of
new restrictions for:

- `schedule_para_initialize`.
- `schedule_para_cleanup`.

Specifically, for the former we do not want to allow registration of
wasm blob that is empty, i.e. 0 bytes. While that currently already
does not make a lot of sense, it allows us to simplify the PVF
pre-checking logic: if this PR is deployed before the following changes
for PVF prechecking then we can be sure that no paras onboarding have to
have to go through the PVF pre-checking. In case, we deploy it
altogether this property will allow us to distingush paras that came in
before PVF pre-checking.

For `schedule_para_cleanup` we do not want to allow offboarding of paras
that are undergoing the upgrade process. While this is not a harsh
restriction this change allows us to avoid making the PVF prechecking
more complicated than it has to be.

* Add a test for schedule_para_initialize

* Link to `ParaLifecycle::is_stable` in docs.

* `schedule_para_{init,cleanup}` docs

Now they link to their original declarations in the pallet for more
details.
      bce0e5ac
    • sandreim's avatar
      Fix Provisioner dispute metrics naming (#4374) · e4e22f40
      sandreim authored 
      

* update dispute metric names

Signed-off-by: default avatarAndrei Sandu <[email protected]>

* update

Signed-off-by: default avatarAndrei Sandu <[email protected]>
      e4e22f40
    • Keith Yeung's avatar
      Update W3F URL links (#4376) · bbde75e8
      Keith Yeung authored
      bbde75e8
  13. Nov 25, 2021
  15. Nov 24, 2021
  17. Nov 23, 2021
    • Zeke Mostov's avatar
      Inherent filtering follow up (#4305) · 90e12734
      Zeke Mostov authored 
      

* Add feature more feature gating for benchmarking + tests

* New line

* cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_paras_inherent.rs

* cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_paras_inherent.rs

* Do not assume we use max validators per core

* Use kusama weights for rococo (hopefully temp)

* cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_paras_inherent.rs

* Add more validity votes when neccesary

* Some fixes for the last commit

* Restore westend weights

* cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_paras_inherent.rs

* Revert bad westend weights write

* Make sure to update val idx before skipping

* Fix validity vote range to max at group size'

* Temp setup for rococo

* cargo run --quiet --release --features runtime-benchmarks -- benchmark --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtime/rococo/src/weights/runtime_parachains_paras_inherent.rs --header=./file_header.txt

* Augment generated Rococo weights

* Make it compile

* Revert range for enter_backed_candidates_variable

* Delete runtime/kusama/src/weights/runtime_paras_paras_inherent.rs

Co-authored-by: default avatarParity Bot <[email protected]>
      90e12734