1. Dec 24, 2021
    • cheme's avatar
      Inner hashing of value in state trie (runtime versioning). (#9732) · 4c651637
      cheme authored
      
      
      * starting
      
      * Updated from other branch.
      
      * setting flag
      
      * flag in storage struct
      
      * fix flagging to access and insert.
      
      * added todo to fix
      
      * also missing serialize meta to storage proof
      
      * extract meta.
      
      * Isolate old trie layout.
      
      * failing test that requires storing in meta when old hash scheme is used.
      
      * old hash compatibility
      
      * Db migrate.
      
      * runing tests with both states when interesting.
      
      * fix chain spec test with serde default.
      
      * export state (missing trie function).
      
      * Pending using new branch, lacking genericity on layout resolution.
      
      * extract and set global meta
      
      * Update to branch 4
      
      * fix iterator with root flag (no longer insert node).
      
      * fix trie root hashing of root
      
      * complete basic backend.
      
      * Remove old_hash meta from proof that do not use inner_hashing.
      
      * fix trie test for empty (force layout on empty deltas).
      
      * Root update fix.
      
      * debug on meta
      
      * Use trie key iteration that do not include value in proofs.
      
      * switch default test ext to use inner hash.
      
      * small integration test, and fix tx cache mgmt in ext.
      test  failing
      
      * Proof scenario at state-machine level.
      
      * trace for db upgrade
      
      * try different param
      
      * act more like iter_from.
      
      * Bigger batches.
      
      * Update trie dependency.
      
      * drafting codec changes and refact
      
      * before removing unused branch no value alt hashing.
      more work todo rename all flag var to alt_hash, and remove extrinsic
      replace by storage query at every storage_root call.
      
      * alt hashing only for branch with value.
      
      * fix trie tests
      
      * Hash of value include the encoded size.
      
      * removing fields(broken)
      
      * fix trie_stream to also include value length in inner hash.
      
      * triedbmut only using alt type if inner hashing.
      
      * trie_stream to also only use alt hashing type when actually alt hashing.
      
      * Refactor meta state, logic should work with change of trie treshold.
      
      * Remove NoMeta variant.
      
      * Remove state_hashed trigger specific functions.
      
      * pending switching to using threshold, new storage root api does not
      make much sense.
      
      * refactoring to use state from backend (not possible payload changes).
      
      * Applying from previous state
      
      * Remove default from storage, genesis need a special build.
      
      * rem empty space
      
      * Catch problem: when using triedb with default: we should not revert
      nodes: otherwhise thing as trie codec cannot decode-encode without
      changing state.
      
      * fix compilation
      
      * Right logic to avoid switch on reencode when default layout.
      
      * Clean up some todos
      
      * remove trie meta from root upstream
      
      * update upstream and fix benches.
      
      * split some long lines.
      
      * UPdate trie crate to work with new design.
      
      * Finish update to refactored upstream.
      
      * update to latest triedb changes.
      
      * Clean up.
      
      * fix executor test.
      
      * rust fmt from master.
      
      * rust format.
      
      * rustfmt
      
      * fix
      
      * start host function driven versioning
      
      * update state-machine part
      
      * still need access to state version from runtime
      
      * state hash in mem: wrong
      
      * direction likely correct, but passing call to code exec for genesis
      init seem awkward.
      
      * state version serialize in runtime, wrong approach, just initialize it
      with no threshold for core api < 4 seems more proper.
      
      * stateversion from runtime version (core api >= 4).
      
      * update trie, fix tests
      
      * unused import
      
      * clean some TODOs
      
      * Require RuntimeVersionOf for executor
      
      * use RuntimeVersionOf to resolve genesis state version.
      
      * update runtime version test
      
      * fix state-machine tests
      
      * TODO
      
      * Use runtime version from storage wasm with fast sync.
      
      * rustfmt
      
      * fmt
      
      * fix test
      
      * revert useless changes.
      
      * clean some unused changes
      
      * fmt
      
      * removing useless trait function.
      
      * remove remaining reference to state_hash
      
      * fix some imports
      
      * Follow chain state version management.
      
      * trie update, fix and constant threshold for trie layouts.
      
      * update deps
      
      * Update to latest trie pr changes.
      
      * fix benches
      
      * Verify proof requires right layout.
      
      * update trie_root
      
      * Update trie deps to  latest
      
      * Update to latest trie versioning
      
      * Removing patch
      
      * update lock
      
      * extrinsic for sc-service-test using layout v0.
      
      * Adding RuntimeVersionOf to CallExecutor works.
      
      * fmt
      
      * error when resolving version and no wasm in storage.
      
      * use existing utils to instantiate runtime code.
      
      * Patch to delay runtime switch.
      
      * Revert "Patch to delay runtime switch."
      
      This reverts commit 67e55fee468f1a0cda853f5362b22e0d775786da.
      
      * useless closure
      
      * remove remaining state_hash variables.
      
      * Remove outdated comment
      
      * useless inner hash
      
      * fmt
      
      * fmt and opt-in feature to apply state change.
      
      * feature gate core version, use new test feature for node and test node
      
      * Use a 'State' api version instead of Core one.
      
      * fix merge of test function
      
      * use blake macro.
      
      * Fix state api (require declaring the api in runtime).
      
      * Opt out feature, fix macro for io to select a given version
      instead of latest.
      
      * run test nodes on new state.
      
      * fix
      
      * Apply review change (docs and error).
      
      * fmt
      
      * use explicit runtime_interface in doc test
      
      * fix ui test
      
      * fix doc test
      
      * fmt
      
      * use default for path and specname when resolving version.
      
      * small review related changes.
      
      * doc value size requirement.
      
      * rename old_state feature
      
      * Remove macro changes
      
      * feature rename
      
      * state version as host function parameter
      
      * remove flag for client api
      
      * fix tests
      
      * switch storage chain proof to V1
      
      * host functions, pass by state version enum
      
      * use WrappedRuntimeCode
      
      * start
      
      * state_version in runtime version
      
      * rust fmt
      
      * Update storage proof of max size.
      
      * fix runtime version rpc test
      
      * right intent of convert from compat
      
      * fix doc test
      
      * fix doc test
      
      * split proof
      
      * decode without replay, and remove some reexports.
      
      * Decode with compatibility by default.
      
      * switch state_version to u8. And remove RuntimeVersionBasis.
      
      * test
      
      * use api when reading embedded version
      
      * fix decode with apis
      
      * extract core version instead
      
      * test fix
      
      * unused import
      
      * review changes.
      
      Co-authored-by: default avatarkianenigma <[email protected]>
      4c651637
  2. Dec 21, 2021
  3. Dec 16, 2021
    • dharjeezy's avatar
      Replace parameter_types with ConstU32 &c. (#10402) · 1b0be8ae
      dharjeezy authored
      
      
      * remove parameter types and use const type
      
      * remove parameter types and use const type
      
      * Delete {
      
      * Delete count,
      
      * refractor for beefy, benchmarking, child bounties, and collective pallets
      
      * refractor for pallet contracts
      
      * refractor for elections
      
      * refractor for more pallets
      
      * fix CI issues
      
      * fix CI issues
      
      * fix CI issues
      
      * fix CI issues
      
      * remove warning to fix CI issue
      
      * remove warning to fix CI issue
      refractor for pallet preimage
      
      * remove warning to fix CI issue
      refractor for pallet proxy
      
      * remove warning to fix CI issue
      refractor for pallet recovery
      refractor for pallet randomness-collective-flip
      
      * remove warning to fix CI issue
      refractor for pallet scored-pool
      refractor for pallet scheduler
      refractor for pallet session
      
      * remove warning to fix CI issue
      refractor for pallet society, support, system, timestamp, tips
      
      * remove warning to fix CI issue
      refractor for pallet transaction_payment, transaction_storage, treasury, uniques, utility
      
      * remove warning to fix CI issue
      
      * cargo +nightly fmt
      
      * CI fix
      
      * more param refractor on beefy-mmr
      
      * refractor for beefy
      
      * Update frame/babe/src/mock.rs
      
      * Update frame/babe/src/mock.rs
      
      * Update frame/bounties/src/tests.rs
      
      * Update frame/tips/src/tests.rs
      
      * Delete mock.rs
      
      * Update frame/examples/basic/src/tests.rs
      
      * Apply suggestions from code review
      
      * Update frame/im-online/src/mock.rs
      
      * Update frame/im-online/src/mock.rs
      
      * Update frame/offences/benchmarking/src/mock.rs
      
      * Update frame/session/benchmarking/src/mock.rs
      
      * Update frame/support/test/tests/pallet_compatibility.rs
      
      * Update frame/support/test/tests/pallet_compatibility_instance.rs
      
      * Update frame/treasury/src/tests.rs
      
      * Update test-utils/runtime/src/lib.rs
      
      * some cleanup
      
      * fmt
      
      * remove unused
      
      Co-authored-by: default avatarDamilare <[email protected]>
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      1b0be8ae
  4. Dec 13, 2021
  5. Dec 11, 2021
    • Gavin Wood's avatar
      Preimage registrar and Scheduler integration (#10356) · 5e50e0bc
      Gavin Wood authored
      
      
      * initial idea
      
      * more
      
      * fix compile
      
      * add clear and request logic
      
      * improve some docs
      
      * Add and implement trait
      
      * continuing to improve
      
      * refcount type
      
      * infallible system preimage upload
      
      * fmt
      
      * fix requests
      
      * Make it simple
      
      * Make it simple
      
      * Formatting
      
      * Initial draft
      
      * request when scheduled
      
      * Docs
      
      * Scheduler good
      
      * Scheduler good
      
      * Scheduler tests working
      
      * Add new files
      
      * Missing stuff
      
      * Repotting, add weights.
      
      * Add some tests to preimage pallet
      
      * More tests
      
      * Fix benchmarks
      
      * preimage benchmarks
      
      * All preimage benchmarks
      
      * Tidy cargo
      
      * Update weights.rs
      
      * Allow hash provision in benchmarks
      
      * Initial work on new benchmarks for Scheduler
      
      * Tests working, refactor looks good
      
      * Tests for new Scheduler functionality
      
      * Use real weight, make tests work with runtimes without Preimage
      
      * Rename
      
      * Update benchmarks
      
      * Formatting
      
      * Formatting
      
      * Fix weird formatting
      
      * Update frame/preimage/src/lib.rs
      
      * Fix try-runtime build
      
      * Fixes
      
      * Fixes
      
      * Update frame/support/src/traits/tokens/currency.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/support/src/traits/tokens/currency/reservable.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/support/src/traits/tokens/imbalance.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/preimage/src/mock.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Update frame/scheduler/src/lib.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Update frame/preimage/src/lib.rs
      
      * Fixes
      
      * Fixes
      
      * Formatting
      
      * Fixes
      
      * Fixes
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_scheduler --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/scheduler/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_preimage --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/preimage/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarKian Paimani <[email protected]>
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      Co-authored-by: default avatarParity Bot <[email protected]>
      5e50e0bc
  6. Dec 09, 2021
  7. Dec 07, 2021
    • Ayevbeosa Iyamu's avatar
      Used CountedStorageMap in pallet-staking (#10233) · 56fb1cfb
      Ayevbeosa Iyamu authored
      
      
      * Removed counters and used CountedStorageMap instead.
      
      * Little refactoring
      
      * Update frame/staking/src/migrations.rs
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * Removed redundant code to update counter for validator & nominator.
      
      * Removed redundant code to update counter for validator & nominator.
      
      * Removed unreachable code to inject the hashed prefix for nominator & validator.
      
      * Removed redundant check for nominator & validator count.
      
      * Generated `fn prefix_hash` for `CountedStorageMap`.
      
      * Applied changes from `cargo fmt`
      
      * Possible correct implementation of migration code
      
      * Implemented fn module_prefix, storage_prefix and prefix_hash.
      
      * Removed counted_map.rs
      
      * Renamed `fn storage_prefix` to `storage_counter_prefix`.
      
      * Update frame/support/src/storage/types/counted_map.rs
      
      * Update frame/bags-list/remote-tests/src/snapshot.rs
      
      * Update frame/support/src/storage/types/counted_map.rs
      
      * Fixed errors.
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      56fb1cfb
  8. Dec 03, 2021
  9. Dec 01, 2021
  10. Nov 24, 2021
  11. Nov 22, 2021
  12. Nov 12, 2021
  13. Nov 10, 2021
  14. Nov 09, 2021
  15. Nov 07, 2021
  16. Nov 04, 2021
  17. Nov 02, 2021
    • cheme's avatar
      Hashing proc macro utils (#9875) · 471e9cfb
      cheme authored
      
      
      * hashing macro
      
      * fmt
      
      * use in easy place, and fix blake sizes
      
      * fix
      
      * Fixes, docs.
      Allow ident as input.
      
      * fix doc tests
      
      * update error in test (nmapkey and key are same type).
      
      * hashing crates under sp_core
      
      * Doc updates and format.
      
      * use all existing hashing functions.
      
      * return array of u8
      
      * Update primitives/core/hashing/proc-macro/src/impls.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * ToTokeen for an array of u8
      
      * fix
      
      * re
      
      * Improve impls
      
      * complete doc tests
      
      * fmt
      
      * fix doctest format
      
      * fix ui test (nmap key type alias)
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      471e9cfb
  18. Oct 31, 2021
    • thiolliere's avatar
      Automatic pallet parts in construct_runtime (#9681) · 4292e18e
      thiolliere authored
      
      
      * implement automatic parts
      
      * ui tests
      
      * rename
      
      * remove unnecessary exclude
      
      * better doc
      
      * better doc
      
      * fix genesis config
      
      * fix UI tests
      
      * fix UI test
      
      * Revert "fix UI test"
      
      This reverts commit a910351c0b24cfe42195cfd97d83a416640e3259.
      
      * implemented used_parts
      
      * Update frame/support/procedural/src/construct_runtime/mod.rs
      
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      
      * doc + fmt
      
      * Update frame/support/procedural/src/construct_runtime/parse.rs
      
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      
      * add doc in the macro
      
      * remove yet some more parts
      
      * fix ui test
      
      * more determnistic error message + fix ui tests
      
      * fix ui test
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      
      * do refactor + fix ui tests
      
      * fmt
      
      * fix test
      
      * fix test
      
      * fix ui test
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      
      * refactor
      
      * remove even more part in node-runtime
      
      * fix test
      
      * Add flow chart for the construct_runtime! execution flow
      
      * Fix typo
      
      * Ignore snippets that don't contain code
      
      * Refactor some code in expand_after
      
      * Rename expand_after to match_and_insert
      
      * cargo fmt
      
      * Fix rename
      
      * Remove frame_support argument to construct_runtime_parts
      
      * Make use of tt-call to simplify intermediate expansions
      
      * cargo fmt
      
      * Update match_and_insert documentation
      
      * Reset cursor to 0 when no matching patterns are found
      
      * Reorder struct fields on MatchAndInsertDef
      
      * Add test for dependency renames and fix frame-support import
      
      * Add more doc comments
      
      * Update frame/support/test/compile_pass/src/lib.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      4292e18e
  19. Oct 29, 2021
    • Bastian Köcher's avatar
      pallet-scheduler: Introduce `OriginPrivilegeCmp` (#10078) · 95b8fd61
      Bastian Köcher authored
      
      
      * pallet-scheduler: Introduce `OriginPrivilegeCmp`
      
      When a scheduled task should be canceled, the origin that tries to
      cancel the task is compared to the origin the task should be executed
      with. Before this pr this check only allowed that both origins are
      equal. However, this is problematic as this means that for example a
      council origin it needs to be have the same amount of yes votes to
      cancel the scheduled task. While a council origin with more yes votes
      should be able to cancel this task. This happened recently on Kusama and
      lead to a failed cancelation of a scheduled task. With this pr the two
      origins are compared and the cancelling origin needs to have greater or
      equal privileges as the origin that scheduled the task. What a greater,
      equal or less privilege is, can be configured in the runtime.
      
      For simplicity, a `EqualPrivilegeOnly` implementation is provided that
      only checks if two origins are equal. So, this mimics the old behaviour.
      
      * FMT
      
      * fix import
      
      * Small optimizations
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      95b8fd61
  20. Oct 25, 2021
    • Bastian Köcher's avatar
      pallet-multisig: Improve opaque call handling (#10060) · 6cfb0c7e
      Bastian Köcher authored
      * pallet-multisig: Improve opaque call handling
      
      Before the opaque call was just a type redefinition of `Vec<u8>`. With metadata v14 that was
      breaking external tools, as they stopped looking at the type name. To improve the situation the
      `WrapperKeepOpaque` type is introduced that communicates to the outside the correct type info.
      
      * Cleanup
      
      * Fix benchmarks
      
      * FMT
      6cfb0c7e
  21. Oct 21, 2021
    • Gavin Wood's avatar
      Allow pallet's info to be enumerated (#10053) · 1dc753eb
      Gavin Wood authored
      * Allow pallet's info to be enumerated
      
      * Fixes
      
      * Formatting
      
      * Flat tuple for getting all pallet instances
      
      * Renaming and fixing reversedness
      
      * Formatting
      
      * Fixes
      
      * Back to nesting
      
      * Back to nestingx
      
      * Revert executive lib
      
      * Reversions
      
      * Reversions
      
      * Fixes
      
      * Fixes
      
      * Formatting
      
      * Fixes
      
      * Spelling
      
      * Comments
      1dc753eb
  22. Oct 18, 2021
  23. Oct 13, 2021
  24. Oct 09, 2021
  25. Oct 07, 2021
  26. Oct 06, 2021
  27. Oct 04, 2021
  28. Oct 03, 2021
  29. Oct 02, 2021
  30. Sep 30, 2021
  31. Sep 29, 2021
  32. Sep 28, 2021
    • Keith Yeung's avatar
      Extend PalletInfoAccess with module_name and crate_version method (#9690) · 7b65b049
      Keith Yeung authored
      
      
      * Record pallet indices in CallMetadata
      
      * Resurrect PalletVersion infrastructure and rename as CrateVersion
      
      * cargo fmt
      
      * Add missing runtime generics to pallet struct
      
      * Fix path to instance
      
      * Fix test
      
      * Fix UI test expectations
      
      * Fix UI test expectations
      
      * Move crate_version function to PalletInfoAccess
      
      * Update UI test expectations
      
      * Add crate_name method to PalletInfo
      
      * Convert path to module name instead of exposing crate name
      
      * cargo fmt
      
      * Keep the double colons when constructing the module name
      
      * Remove unused import
      
      * Update UI test expectations
      
      * Update frame/support/src/traits/metadata.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Update UI test expectations
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      7b65b049
  33. Sep 27, 2021
  34. Sep 26, 2021
  35. Sep 25, 2021
  36. Sep 24, 2021
    • Bastian Köcher's avatar
      Prepare UI tests for rust 1.55 (#9637) · 62187b59
      Bastian Köcher authored
      
      
      * Prepare UI tests for rust 1.54
      
      * Delete wrong_page.stderr
      
      * CI: run with a staging CI image
      
      * Revert "CI: run with a staging CI image"
      
      This reverts commit 66f5b00d14b50fd9d8fbf773f7e884f380697591.
      
      * CI: debug, again
      
      * LOG_TARGET is only used in std
      
      * Remove unnecessary unsafe
      
      * Fixes
      
      * Use correct rustc locally
      
      * FMT
      
      * Compile with benchmarking
      
      * Review feedback
      
      * Some ui tests
      
      * I know...
      
      * Fix wasm tests
      
      Co-authored-by: default avatarDenis P <[email protected]>
      Co-authored-by: default avatarthiolliere <[email protected]>
      62187b59