Skip to content
  1. Mar 21, 2020
  2. Mar 20, 2020
  3. Mar 19, 2020
  4. Mar 18, 2020
    • Chevdor's avatar
      Add more generated utils to the image (#5305) · 86410de2
      Chevdor authored
      86410de2
    • Max Inden's avatar
      client/network-gossip/src/bridge: Finish when network event stream closes (#5282) · 9201f8ab
      Max Inden authored
      * client/network-gossip/src/bridge: Finish when network even stream closes
      
      Previously within `<GossipEngine as Future>::poll` one would poll the
      `network_event_stream` ignoring all messages other than
      `Poll::Ready(Some())`. Ignoring `Poll::Ready(None)` leads to a panic on
      the next poll of the stream, gien that it is not fused.
      
      By design `network_event_stream` does not close unless an unbounded send
      into it fails, or the `NetworkWorker` gets shut down.
      
      > The stream never ends (unless the `NetworkWorker` gets shut down).
      > (client/network/src/service.rs)
      
      An `unbounded_send` to fail on an unbounded channel is unlikely. The
      `NetworkWorker` shutting down is not unlikely. In such case the
      `GossipEngine` should shut down as well.
      
      With this patch a `<GossipEngine as Future>` finishes on
      `Poll::Ready(None)` returned from `network_event_stream`.
      
      * client/finality-grandpa/communication: Error on gossip engine finished
      
      Have `<NetworkBridge as Future>::poll` return `Poll::Ready(Err)` instead
      of `Poll::Ready(Ok)` to be consistent with the handling of the neighbor
      packet worker stream and the gossip validator report stream. Both `Err`
      as well as `Ok` shut down the `NetworkBridge` as well as the
      `VoterWorker`.
      
      * client/network-gossip/src/bridge: Add regression test
      
      * client/network-gossip: Move substrate test client to dev dependencies
      
      * client/network-gossip: Remove TODO
      
      Addressed in a follow up pull request.
      
      * client/network-gossip/bridge: Put match on newline after loop
      
      * client/finality-grandpa/src/observer: Fix regression test
      
      Make sure the event stream sender side is not dropped till the end.
      9201f8ab
    • Benjamin Kampmann's avatar
      alpha.4 release fixes (#5303) · becbe0a3
      Benjamin Kampmann authored
      * Adding missing metadata for benchmark-pallet
      
      * Missed to bump a few
      
      * release on roling tag
      
      * Wasm executors were missed
      becbe0a3
    • Benjamin Kampmann's avatar
      Releasing 2.0.0-alpha.4 (#5279) · 25e25a83
      Benjamin Kampmann authored
      
      
      * Version bump
      
      * Split generate_changelog.sh into separate script
      
      Can be run in the format `generate_changelog.sh $previous_version $version`.
      
      * remove early exit from publish_draft_release.sh
      
      * adding changelog
      
      * ci: change last_github_release to also find pre-releases
      
      Co-authored-by: default avatarMartin Pugh <[email protected]>
      25e25a83
    • ddorgan's avatar
      Fork flaming fir 6 (#5251) · d02868a0
      ddorgan authored
      d02868a0
    • Nikolay Volf's avatar
      1164910e
    • Toralf Wittner's avatar
      sc-network: Return on Poll::Pending. (#5295) · 89b93d9d
      Toralf Wittner authored
      If polling encounters a `Poll::Pending` we need to return it instead of
      continuing the loop which may turn it into a blocking operation, causing
      problems with executors.
      89b93d9d
    • Max Inden's avatar
      Revert "Substrate Dashboard example (#5284)" (#5293) · 733d4868
      Max Inden authored
      This reverts commit 082b6643.
      733d4868
    • gabriel klawitter's avatar
      14c76cea
    • lwshang's avatar
      Print non-output messages to stderr in subkey (#5286) · 648c8cb8
      lwshang authored
      
      
      * Print non-output messages to stderr in subkey
      
      * Update bin/utils/subkey/src/main.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      648c8cb8
    • derfredy's avatar
      Substrate Dashboard example (#5284) · 082b6643
      derfredy authored
      082b6643
  5. Mar 17, 2020