- Aug 02, 2023
-
-
drskalman authored
* Merged BEEFY primitives with generic signature and keyset commitment support from old pull to current code * - Add bls-experimental feature to application-crypto and beefy primitives - Fix remaining crypto -> ecdsa_crypto - code build but not tests * Make beefy primitive tests compile * move bls related beefy primitives code and test behind bls-experimental flag * Make BEEFY clients complies with BEEFY API depending on AuthorityId * - Rename `BeefyAuthoritySet.root` → `BeefyAuthoritySet.keyset_commitment`. - Remove apk proof keyset_commitment from `BeefyAuthoritySet`. - Fix failing signed commitment and signature to witness test. - Make client compatible with BeefyAPI generic on AuthorityId. - `crypto` → `ecdsa_crypto` in BEEFY client and frame. * Commit Cargo lock remove ark-serialize from BEEFY primitives * Use Codec instead of Encode + Decode in primitives/consensus/beefy/src/lib.rs Co-authored-by:
Davide Galassi <[email protected]> * - Make `BeefyApi` generic over Signature type. - Make new `BeeyApi` functinos also generic over AuthorityId and Signature * Unmake BeefyAPI generic over Signature. Recover Signature type from AuthId. * - dont use hex or hex-literal use array-bytes instead in beefy primitives and bls crypto. - CamelCase ECDSA and BLS everywhere. * Move the definition of BEEFY key type from `primitives/beefy` to `crypto.rs` according to new convention. * - Add bls377_generate_new to `sp-io` and `application_crypto::bls`. - Add `bls-experimental` to `sp-io` Does not compile because PassByCodec can not derive PassBy using customly implemented PassByIner. * Implement PassBy for `bls::Public` manually * fix Beefy `KEY_TYPE` in `frame/beefy` tests to come from `sp-core::key_types` enum * specify both generic for `hex2array_unchecked` in `sp-core/bls.rs` * Rename `crypto`→`ecdsa_crypto` in `primitives/consensus/beefy/src/test_utils.rs` docs * remove commented-out code in `primitives/consensus/beefy/src/commitment.rs` Co-authored-by:
André Silva <[email protected]> * Fix Cargo.toml * Trigger CI with cumulus companion * Trigger CI after polkadot companion change --------- Co-authored-by:
-
Dmitry Markin authored
* Move bootnodes from individual `SetConfig`s to `PeersetConfig` * Move `SetId` & `SetConfig` from `peerset` to `protocol_controller` * Remove unused `DropReason` * Move `Message` & `IncomingIndex` from `peerset` to `protocol_controller` * Restore running fuzz test * Get rid of `Peerset` in `fuzz` test * Spawn runners instead of manual polling in `fuzz` test * Migrate `Protocol` from `Peerset` to `PeerStore` & `ProtocolController` * Migrate `NetworkService` from `Peerset` to `PeerStore` & `ProtocolController` * Migrate `Notifications` from `Peerset` to `ProtocolController`s * Migrate `Notifications` tests from `Peerset` to `ProtocolController` * Fix compilation of `NetworkService` & `Protocol` * Fix borrowing issues in `Notifications` * Migrate `RequestResponse`from `Peerset` to `PeerStore` * rustfmt * Migrate request-response tests from `Peerset` to `PeerStore` * Migrate `reconnect_after_disconnect` test to `PeerStore` & `ProtocolController` * Fix `Notifications` tests * Remove `Peerset` completely * Fix bug with counting sync peers in `Protocol` * Eliminate indirect calls to `PeerStore` via `Protocol` * Eliminate indirect calls to `ProtocolController` via `Protocol` * Handle `Err` outcome from `remove_peers_from_reserved_set` * Add note about disconnecting sync peers in `Protocol` * minor: remove unneeded `clone()` * minor: extra comma removed * minor: use `Stream` API of `from_protocol_controllers` channel * minor: remove TODO * minor: replace `.map().flatten()` with `.flat_map()` * minor: update `ProtocolController` docs * rustfmt * Apply suggestions from code review Co-authored-by:
Aaro Altonen <[email protected]> * Extract `MockPeerStore` to `mock.rs` * Move `PeerStore` initialization to `build_network` * minor: remove unused import * minor: clarify error message * Convert `syncs_header_only_forks` test into single-threaded --------- Co-authored-by:
-
juangirini authored* bound `Balance` to `FixedPointOperand` * ".git/.scripts/commands/fmt/fmt.sh" * clean up code * Apply suggestions from code review Co-authored-by:
Gavin Wood <[email protected]> * wip * add blanket `FixedPointOperand` impl * update nis CurrencyBalance * remove CheckedNeg bound --------- Co-authored-by: command-bot <> Co-authored-by:
-
- Aug 01, 2023
-
-
Oliver Tale-Yazdi authored* Fix std, runtime-benchmarks and try-runtime features zepter lint propagate-feature --feature try-runtime --left-side-feature-missing=ignore --workspace --fix --feature-enables-dep="try-runtime:frame-try-runtime" zepter lint propagate-feature --feature runtime-benchmarks --left-side-feature-missing=ignore --workspace --fix --feature-enables-dep="runtime-benchmarks:frame-benchmarking" zepter lint propagate-feature --feature std --left-side-feature-missing=ignore --workspace --fix Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * Add propagate feature CI check Signed-off-by:
Bastian Köcher <[email protected]> * More review fixes Signed-off-by:
-
Sacha Lansky authored
* fix missing docs warnings * fmt * Update frame/glutton/src/lib.rs Co-authored-by:
-
Sacha Lansky authored
* add docs about call indices and hashers * fix mention of call indices * ".git/.scripts/commands/fmt/fmt.sh" --------- Co-authored-by:command-bot <[email protected]>
-
Alin Dima authored
* network: optimize listen_address update procedure * network: optimize external_addr update procedure * replace on_swarm_event with add/remove
-
Liam Aharon authored
* cargo run docs * typo
-
Liam Aharon authored
-
- Jul 31, 2023
-
-
Oliver Tale-Yazdi authored
* Remove V1 pallet syntax Signed-off-by:
-
PG Herveou authored
* Add version check * fix format * simplify * restructure imports * add version check * Fix benchmarking * Rename migrations -> BenchMigrations * doc * add more docs * fix format string * Update frame/contracts/build.rs * fix * add cargo:rerun-if-changed --------- Co-authored-by: parity-processbot <>
-
Anton authored
refs https://github.com/paritytech/substrate/pull/14429#discussion_r1272061153
-
Alexandru Vasile authored
* chainHead/events: Remove network config Signed-off-by:
Alexandru Vasile <[email protected]> * chainHead/events: Add events for operations Signed-off-by:
-
- Jul 30, 2023
-
-
Sergej Sakac authored
* Try-state for Referenda pallet * fix & more tests * checking more stuff * remove log * two more tests * Update frame/referenda/src/lib.rs Co-authored-by:
Muharem Ismailov <[email protected]> * fixes * new check * merge fixes * fix warning * remove check * Update frame/referenda/src/lib.rs Co-authored-by:
Gonçalo Pestana <[email protected]> * separate into multiple functions * clean up * unnecessary return value specified * fix * Update frame/referenda/src/lib.rs * fmt * remove import * fmt * fix CI * Update frame/referenda/src/lib.rs Co-authored-by:
Liam Aharon <[email protected]> * last fixes * :P * fmt --------- Co-authored-by:
-
- Jul 29, 2023
-
-
Oliver Tale-Yazdi authored
* Rename file Signed-off-by:
-
Sacha Lansky authored
* fix missing docs warning * fmt * add #![deny(missing_docs)]
-
Lulu authored
Fixes publish from failing.
-
- Jul 28, 2023
-
-
Chevdor authored
* WIP * Fix usage of the s3krit/walking-tag-action action * Fix notification jobs * Fix notification content --------- Co-authored-by: parity-processbot <>
-
PG Herveou authored
* Contracts Rollback StorageMap hashing migration * misc v13
-
Nate Armstrong authored
* Update reservable docs to reflect actual ed Update reservable documentation to reflect the actual behavior of small reserved balances. Looking into `frame/balances/src/impl_currency.rs` shows that accounts are not reaped even if the reserved balance is very small. * ".git/.scripts/commands/fmt/fmt.sh" --------- Co-authored-by: command-bot <>
-
- Jul 27, 2023
-
-
Oliver Tale-Yazdi authored
* Export HandleMessage Signed-off-by:
-
Liam Aharon authored
* poc: check polkadot runtime upgrade * typo * try nested extends * add checks for other networks * .test-refs-no-trigger-prs-only * Update scripts/ci/gitlab/pipeline/build.yml Co-authored-by:
Alexander Samusev <[email protected]> * Update scripts/ci/gitlab/pipeline/build.yml Co-authored-by:
-
Davide Galassi authored* Relax Send/Sync requirements for not instanced generic Pair * Remove leftover * Apply review suggestion Co-authored-by:
Sebastian Kunert <[email protected]> * Further cleanup * Trigger CI --------- Co-authored-by:
-
- Jul 26, 2023
-
-
Muharem Ismailov authored
* asset-rate rename asset_id to asset_kind * asset-rate pallet benchmarks asset kind factory * rename to SEED * fixes * Update frame/asset-rate/src/benchmarking.rs Co-authored-by:
joe petrowski <[email protected]> * sp-core optional dep * sp-core included for benchmarks * sp-core to dev dep * sp-core add dep prefix --------- Co-authored-by:
-
PG Herveou authored
* wip * fixes * rm comment * join fns * clippy * Fix limits * reduce diff * fix * fix * fix typo * refactor store to use self * refactor run to take self by value * pass tests * rm comment * fixes * fix typo * rm * fix fmt * clippy * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts * Update frame/contracts/src/lib.rs Co-authored-by:
Sasha Gryaznov <[email protected]> * Update frame/contracts/src/wasm/mod.rs Co-authored-by:
Alexander Theißen <[email protected]> * PR review pass CodeInfo and update docstring https://github.com/paritytech/substrate/pull/14079/files#r1257522327 * PR review add code_info to the executable https://github.com/paritytech/substrate/pull/14079/files#r1263309049 * rename info -> contract_info * Update frame/contracts/src/exec.rs Co-authored-by:
Juan <[email protected]> --------- Co-authored-by: command-bot <> Co-authored-by:
-
Cyrill Leutwiler authored
A subtle bug in the bool predicate for checking against chain extension imports prevents importing the non-prefixed version even if chain extension are enabled are enabled (#14642) Signed-off-by:Cyrill Leutwiler <[email protected]>
-
- Jul 25, 2023
-
-
Marijn Schouten authored
* change HashFor to HashingFor * fmt * ".git/.scripts/commands/fmt/fmt.sh" --------- Co-authored-by: command-bot <>
-
Alexandru Vasile authored
* chainHead: Iterate over key,values and key,hashes Signed-off-by:
-
Anton authored
* update libp2p to 0.52.0 * proto name now must implement `AsRef<str>` * update libp2p version everywhere * ToSwarm, FromBehaviour, ToBehaviour also LocalProtocolsChange and RemoteProtocolsChange * new NetworkBehaviour invariants * replace `Vec<u8>` with `StreamProtocol` * rename ConnectionHandlerEvent::Custom to NotifyBehaviour * remove DialError & ListenError invariants also fix pending_events * use connection_limits::Behaviour See https://github.com/libp2p/rust-libp2p/pull/3885 * impl `void::Void` for `BehaviourOut` also use `Behaviour::with_codec` * KademliaHandler no longer public * fix StreamProtocol construction * update libp2p-identify to 0.2.0 * remove non-existing methods from PollParameters rename ConnectionHandlerUpgrErr to StreamUpgradeError * `P2p` now contains `PeerId`, not `Multihash` * use multihash-codetable crate * update Cargo.lock * reformat text * comment out tests for now * remove `.into()` from P2p * confirm observed addr manually See https://github.com/libp2p/rust-libp2p/blob/master/protocols/identify/CHANGELOG.md#0430 * remove SwarmEvent::Banned since we're not using `ban_peer_id`, this can be safely removed. we may want to introduce `libp2p::allow_block_list` module in the future. * fix imports * replace `libp2p` with smaller deps in network-gossip * bring back tests * finish rewriting tests * uncomment handler tests * Revert "uncomment handler tests" This reverts commit 720a06815887f4e10767c62b58864a7ec3a48e50. * add a fixme * update Cargo.lock * remove extra From * make void uninhabited * fix discovery test * use autonat protocols confirming external addresses manually is unsafe in open networks * fix SyncNotificationsClogged invariant * only set server mode manually in tests doubt that we need to set it on node since we're adding public addresses * address @dmitry-markin comments * remove autonat * removed unused var * fix EOL * update smallvec and sha2 in attempt to compile polkadot * bump k256 in attempt to build cumulus --------- Co-authored-by: parity-processbot <>
-
Just van Stam authored
* Use Incrementable from frame_support::traits * Chore * make incremental fallible and new nfts function for custom collection ids * fmt * fix benchmark tests nfts * add test * fmt * add safety comment to CollectionId * fmt * add comments to Incrementable * line wrapping * rewrap comments * address feedback * fmt * change unwrap for expect --------- Co-authored-by:Jegor Sidorenko <[email protected]> Co-authored-by: parity-processbot <>
-
- Jul 24, 2023
-
-
Sam Johnson authored
* upgrade to macro_magic 0.4.2 * also change in Cargo.toml
-
Gonçalo Pestana authored
Co-authored-by: parity-processbot <>
-
Michal Kucharczyk authored* test-runtime: GenesisBuilder runtime API impl + tests This PR provides implementation of `GenesisBuilder` API for `substrate-test-runtime`, can be considered as reference imiplementation for other runtimes. The `GenesisBuilder` implementation is gated by `gensis-config` feature. Tested scenarios: - default `GenesisConfig` to JSON blob, - deserialization of `GenesisConfig` from custom JSON, and storing its keys into the Storage (genesis storage creation). - creation of genesis storage using partial JSON definition, - checking if invalid/renamed JSON files causes the runtime to panic, * missing file added * client: GenesisBuilder helper added * feature renamed: genesis-config -> genesis-builder * Update Cargo.toml * Update Cargo.toml * Update Cargo.toml * Update Cargo.toml * redundant function removed * genesis builder helper: introduced RuntimeGenesisBuild * test-runtime: get rid of unused T * redundant bound removed * helper: use GenesisBuild again * tests adjusted for on_genesis * test-runtime: support for BuildGenesisConfig * helper: BuildGenesisConfig support * Update client/genesis-builder/src/lib.rs Co-authored-by:
-
Sacha Lansky authored
* Fix clippy::doc_markdown warnings * Remove accidental commit of script * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_uniques * Some more backticks Signed-off-by:
-
Sacha Lansky authored
* Fix clippy::missing_docs_in_private_items * Fix clippy::missing_docs_in_private_items --------- Co-authored-by: parity-processbot <>
-
Gonçalo Pestana authored
Co-authored-by: parity-processbot <>
-
Aaro Altonen authored
* Accept only `--in-peers` many inbound full nodes in `SyncingEngine` Due to full and light nodes being stored in the same set, it's possible that `SyncingEngine` accepts more than `--in-peers` many inbound full nodes which leaves some of its outbound slots unoccupied. `ProtocolController` still tries to occupy these slots by opening outbound substreams. As these substreams are accepted by the remote peer, the connection is relayed to `SyncingEngine` which rejects the node because it's already full. This in turn results in the substream being inactive and the peer getting evicted. Fixing this properly would require relocating the light peer slot allocation away from `ProtocolController` or alternatively moving entire the substream validation there, both of which are epic refactorings and not necessarily in line with other goals. As a temporary measure, verify in `SyncingEngine` that it doesn't accept more than the specified amount of inbound full peers. * Fix tests * Apply review comments
-
- Jul 23, 2023
-
-
Kian Paimani authored
-
- Jul 21, 2023
-
-
Bastian Köcher authored
* Do some cleanups Found them while looking over the code. * More * Fix
-
Gautham authored
This annoying!
-
