Skip to content
  1. Oct 03, 2022
  3. Oct 02, 2022
  5. Oct 01, 2022
  7. Sep 30, 2022
  9. Sep 29, 2022
    • Robert Klotzner's avatar
      Demote warning (#6080) · 260f70e3
      Robert Klotzner authored 
      This can happen under heavy load - no value in warning here.

Scenario this happens:

- New slot
- We get asked about what fork to build on
- We start building (create inherent gets called)
- We learn about a better fork (but Babe does not care as it already has a fork)
- 6 seconds passed - New slot
- Babe asks about what for to build on - we answer with the best block we learned about 6 seconds ago (slightly after we got asked the last time)
- We start building (on that old block)
- Milliseconds later we learn about a new block (the one from the slot we are actually in now)
- We kick the old leaf -> create inherent fails

Full discussion: https://github.com/paritytech/substrate/issues/12375
      260f70e3
    • Robert Klotzner's avatar
      Validate chunks from disk in availability-recovery (#6078) · 548b4c6c
      Robert Klotzner authored 
      * Don't use corrupted chunks from disk.

Otherwise we would be going to dispute the candidate and get slashed.

* Add tests
      548b4c6c
    • Nikos Kontakis's avatar
      Rename zombienet extension (#6073) · 39e55ffd
      Nikos Kontakis authored 
      * Rename extension files and respective entries from '.feature' to '.zndsl'

* Rename zombienet extension for 0001-dispute-valid-block test
      39e55ffd
  11. Sep 28, 2022
    • Kian Paimani's avatar
      add fast-unstsake pallet to all runtimes (#6050) · 9196f32b
      Kian Paimani authored 
      

* add fast-unstsake pallet to all runtimes

* ".git/.scripts/fmt.sh" 1

* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_fast_unstake

* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_fast_unstake

* fix up all the weight stuff

* update substrate

* update mistake in kusama

* add stub file

* Update runtime/polkadot/src/lib.rs

Co-authored-by: default avatarNitwit <[email protected]>

* Update runtime/westend/src/lib.rs

Co-authored-by: default avatarNitwit <[email protected]>

* cargo update -p sp-io

* add signed extension as well

* Revert "add signed extension as well"

This reverts commit deb936fe5a9a13a62d02757045b1dfa40dccb190.

* cargo update -p sp-io

* ".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_fast_unstake

* ".git/.scripts/bench-bot.sh" runtime polkadot-dev pallet_fast_unstake

* update sub

* integrate latest substrate changes

* ".git/.scripts/fmt.sh" 1

* ".git/.scripts/bench-bot.sh" runtime westend-dev pallet_fast_unstake

Co-authored-by: command-bot <>
Co-authored-by: default avatarNitwit <[email protected]>
      9196f32b
  13. Sep 27, 2022
  15. Sep 26, 2022
  17. Sep 23, 2022
  19. Sep 22, 2022
  21. Sep 21, 2022
    • Ankan's avatar
      [Companion] Get rid of HistoryDepth storage (#5996) · 8d8616d6
      Ankan authored 
      

* remove history depth from storage and add it as config for pallet staking

* add migration to v11 for staking pallet

* revert local substrate dependency patch

* remove history depth from storage and add it as config for pallet staking

* add migration to v11 for staking pallet

* revert local substrate dependency patch

* update substrate dependencies

* update cargo lock

* update to latest substrate

* revert all changes to Cargo.lock

* cargo update -p sp-io

* mark migration job as failable

Co-authored-by: default avatarkianenigma <[email protected]>
      8d8616d6
  23. Sep 20, 2022
    • Sergej Sakac's avatar
      Rename Origin (#6020) · 937c4e76
      Sergej Sakac authored 
      

* Rename Origin

* fmt

* fixes

* more fixes

* fix

* more fixing

* small fixes

* last touches

* update lockfile for {"substrate"}

Co-authored-by: default avatarShawn Tabrizi <[email protected]>
Co-authored-by: parity-processbot <>
      937c4e76
    • Javier Viola's avatar
      [Zombienet] add upgrade test (#5970) · 8d8bd995
      Javier Viola authored 
      * add upgrade test

* fix node names

* changes from feedback

* rename bash script

* fix upgrade node test

* upgrade node test, use env

* bump zombienet version and fix upgrade test

* bump zombienet version

* bump zombienet

* fix raw link for binary

* adjust within time
      8d8bd995
    • ordian's avatar
      runtime/disputes: slashing (#5535) · 18c077a8
      ordian authored 
      

* disputes: runtime part of slashing

* disputes: reward winners

* disputes/slashing: validate_unsigned impl

* fmt

* disputes/slashing: report_dispute_lost_unsigned

* disputes/slashing: separate winners from losers and report winners

* disputes/slashing: refactoring

* impl HandleReports

* enable on Wenstend

* fmt

* add slashing pallet to the mock and test runtimes

* fix a bug in report_dispute_lost_unsigned

* fmt

* disputes: remove new_participants from summary

* disputes: remove punish_inconclusive

* impl SlashingHandler for Pallet for type-safety

* do not impl slashing::Config on mainnets yet

* teach spellcheck deduplication

* simplify interfaces and resolve some TODOs

* resolve some more TODOs

* minor typos

* move slashing into a folder

* remove unnecessary clone

* fix validator_set_count calculation

* introduce ValidatorSetCount

* store ValidatorSetCount

* fmt

* add the benchmark

* fmt

* unflatten slashing

* post-rebase fixes

* remove winners eagerly

* use real slashing weights for westend

* remove bench test suite

* zombinet: modify disputes test to check for an offence report

* zombinet: add a timeout

* add slashing pallet to Rococo

* zombienet: revert back to rococo-local

* fmt

* remove TODOs

* revert some accidental changes

* slashing is submodule of disputes

* Change the log target

Co-authored-by: default avatarKian Paimani <[email protected]>

* wrap comments with rustfmt, more docs, constants

* use Defensive trait

* cargo update -p sp-io

* merge offence types, remove rewards for now

* cargo update -p sp-io

* benchmark fixes

* fmt

* unused var

* fix block_author impl

* ressurect RewardValidators trait

* remove outdated comment

* more module docs

* introduce BenchmarkingConfig

* typo fix

* teach spellcheck unapplied

* use Weight::new()

* fix mocking rewards

* use RefTimeWeight

* ".git/.scripts/bench-bot.sh" runtime westend-dev runtime_parachains::disputes::slashing

* refactor maybe_identify_validators

* no more ticket in disguise

* remove outdated comments

* lower against valid to 0.1%

* bump zombienet version for debug

* use from_perthousand

* post-merge fixes

* another day, another Weight changes

* Revert "bump zombienet version for debug"

This reverts commit 0d9978711f8ec9a746a5e1c45e8ffbe7c75e7b5c.

* do not reward block authors

* fix outdated comment

* use Pays from frame_support::dispatch::Pays

* add timeout to is up

Co-authored-by: default avatarKian Paimani <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: default avatarJavier Viola <[email protected]>
Co-authored-by: default avatarJavier Viola <[email protected]>
      18c077a8
    • Alexander Samusev's avatar
      [ci] Revert cancel-pipeline job (#6028) · b6ed41a4
      Alexander Samusev authored 
      * [WIP][ci] Revert cancel-pipeline job

* fail test-linux-stable

* fix test-linux-stable
      b6ed41a4
  25. Sep 19, 2022
    • Tsvetomir Dimitrov's avatar
      Improved dispute votes import in provisioner (#5567) · 6ae9720c
      Tsvetomir Dimitrov authored 
      * Add `DisputeState` to `DisputeCoordinatorMessage::RecentDisputes`

The new signature of the message is:
```
RecentDisputes(oneshot::Sender<Vec<(SessionIndex, CandidateHash, DisputeStatus)>>),
```

As part of the change also add `DispiteStatus` to
`polkadot_node_primitives`.

* Move dummy_signature() in primitives/test-helpers

* Enable staging runtime api on Rococo

* Implementation

* Move disputes to separate module
* Vote prioritisation
* Duplicates handling
* Double vote handling
* Unit tests
* Logs and metrics
* Code review feedback
* Fix ACTIVE/INACTIVE separation and update partition names
* Add `fn dispute_is_inactive` to node primitives and refactor `fn get_active_with_status()` logic
* Keep the 'old' logic if the staging api is not enabled
* Fix some comments in tests
* Add warning message if there are any inactive_unknown_onchain disputes
* Add file headers and remove `use super::*;` usage outside tests
* Adding doc comments
* Fix test methods names

* Fix staging api usage

* Fix `get_disputes` runtime function implementation

* Fix compilation error

* Fix arithmetic operations in tests

* Use smaller test data

* Rename `RuntimeApiRequest::StagingDisputes` to `RuntimeApiRequest::Disputes`

* Remove `staging-client` feature flag

* fmt

* Remove `vstaging` feature flag

* Some comments regarding the staging api

* Rename dispute selection modules in provisioner
with_staging_api -> prioritized_selection
without_staging_api -> random_selection

* Comments for staging api

* Comments

* Additional logging

* Code review feedback

process_selected_disputes -> into_multi_dispute_statement_set
typo
In trait VoteType: vote_value -> is_valid

* Code review feedback

* Fix metrics

* get_disputes -> disputes

* Get time only once during partitioning

* Fix partitioning

* Comments

* Reduce the number of hardcoded api versions

* Code review feedback

* Unused import

* Comments

* More precise log messages

* Code review feedback

* Code review feedback

* Code review feedback - remove `trait VoteType`

* Code review feedback

* Trace log for DisputeCoordinatorMessage::QueryCandidateVotes counter in vote_selection
      6ae9720c
    • ordian's avatar
      gossip-support: disconnect when we're no longer in other's reserved set (#6024) · bbb71352
      ordian authored 
      * gossip-support: disconnect when we're no longer in the reserved set

* fmt
      bbb71352
    • Oliver Tale-Yazdi's avatar
      Use correct file header for 'benchmark overhead' (#5984) · 4a3ce875
      Oliver Tale-Yazdi authored 
      

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
Co-authored-by: parity-processbot <>
      4a3ce875
  27. Sep 18, 2022
  29. Sep 15, 2022
  31. Sep 14, 2022
  33. Sep 13, 2022