Skip to content
  1. Nov 28, 2021
  2. Nov 18, 2021
  3. Oct 06, 2021
  4. Oct 01, 2021
    • ucover's avatar
      Test each benchmark case in own #[test] (#9860) · f8ce1864
      ucover authored
      
      
      * Generate one #[test] fn per bench case.
      
      * Update benchmark macro syntax in frame pallets.
      
      * Explain new benchmark macro syntax in example pallet.
      
      * support with and without a semicolon
      
      * update pallets to use individual tests
      
      * migrate staking too
      
      * migrate more pallets
      
      * fix up democracy and use individual tests
      
      * Fix comment
      
      * Put println message in panic
      
      * Remove `another_set_dummy` from doc
      
      `another_set_dummy` is not present in the benchmarking.rs (anymore).
      
      * Update doc for benchmarks macro
      
      * Update doc for impl_benchmark_test_suite macro
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      f8ce1864
  5. Sep 26, 2021
  6. Sep 17, 2021
    • Zeke Mostov's avatar
      Implement `pallet-bags-list` and its interfaces with `pallet-staking` (#9507) · 669972a1
      Zeke Mostov authored
      
      
      * remove extra whitespace
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * only emit rebag event on success
      
      * add doc explaining the term voter
      
      * revamp/simplify rebag test
      
      * ensure genesis accounts are placed into the correct nodes/bags
      
      * bond_extra implicitly rebags
      
      * types at top; doc public type
      
      * start sketching out adjustable thresholds
      
      * add integrity test for voter bag threshold requirements
      
      * get rid of BagIdx
      
      This reorganizes bag storage such that bags are always referred to
      by their upper threshold. This in turn means that adding and removing
      bags is cheaper; you only need to migrate certain voters, not all of them.
      
      * implement migration logic for when the threshold list changes
      
      * start sketching out threshold proc macros
      
      * further refine macro signatures
      
      * WIP: implement make_ratio macro
      
      * start rethinking the process of producing threshold lists
      
      The macro approach seems to be a non-starter; that only really works
      if we're throwing around numeric literals everywhere, and that's just
      not nice in this case.
      
      Instead, let's write helper functions and make it really easy to
      generate the tables in separate, permanent files, which humans
      can then edit.
      
      * write helper functions to emit voter bags module
      
      * WIP: demo generating voter bags for a realistic runtime
      
      This isn't yet done, becuase it seems to take a Very Long Time to run,
      and it really shouldn't. Need to look into that.
      
      Still, it's a lot closer than it was this morning.
      
      * rm unnecessary arg_enum
      
      * fix voter bags math
      
      Turns out that when you're working in exponential space, you need
      to divide, not subtract, in order to keep the math working properly.
      
      Also neaten up the output a little bit to make it easier to read.
      
      * add computed voter bags thresholds to node
      
      * fixup some docs
      
      * iter from large bags to small, fulfuilling the contract
      
      * make tests compile
      
      * add VoterBagThresholds to some configs
      
      * ensure that iteration covers all voters even with implied final bag
      
      * use sp_std::boxed::Box;
      
      * fix unused import
      
      * add some more voter bags tests
      
      * file_header.txt
      
      * integrity test to ensure min bag exceeds existential weight
      
      * add more debug assertions about node list length
      
      * rm unused imports
      
      * Kian enters
      
      * Update frame/election-provider-support/src/onchain.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Suggestions for #9081 (Store voters in unsorted bags) (#9328)
      
      * Add some debug asserts to node::get and remove_node
      
      * Improve the debug asserts in remove_node
      
      * improve debug asserts
      
      * Space
      
      * Remove bad assertions
      
      * Tests: WIP take_works
      
      * Take test
      
      * Doc comment
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Test storage is cleaned up;
      
      * formatting
      
      * Switch to simpler thresholds
      
      * Update the storage cleanup test
      
      * Remove hardcoded values from benchmark to make it more robust
      
      * Fix tests to acces bags properly
      
      * Sanity check WIP; tests failing
      
      * Update sanity checks to be more correct
      
      * Improve storage cleanup tests
      
      * WIP remote_ext_tests
      
      * Some notes on next steps
      
      * Remove some stuff that was for remote-ext tests
      
      * Some more cleanup to reduce diff
      
      * More :clean:
      
      * Mo cleanin
      
      * small fix
      
      * A lot of changes from kian
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      Co-authored-by: default avatarkianenigma <[email protected]>
      
      * merge fallout
      
      * Run cargo +nightly fmt
      
      * Fix a bunch of stuff, remove not needed runtime arg of make-bags
      
      * add logs
      
      * Glue the new staking bags to the election snapshot (#9415)
      
      * Glue the new staking bags to the election snapshot
      
      * add CheckedRem (#9412)
      
      * add CheckedRem
      
      * fix
      
      * Run fmt
      
      * Test comment
      
      Co-authored-by: default avatarXiliang Chen <[email protected]>
      Co-authored-by: default avataremostov <[email protected]>
      
      * Update node runtime with VoterSnapshotPerBlock
      
      * Unit test for pallet-staking unsorted bags feature (targets #9081) (#9422)
      
      * impl notional_bag_for_works
      
      * Add tests: insert_as_works & insert_works
      
      * Impl test: remove_works
      
      * Trivial cleaning
      
      * Add test: update_position_for_works
      
      * Write out edge case; probably can delete later
      
      * Add test: bags::get_works
      
      * Add test: remove_node_happy_path_works
      
      * Add test: remove_node_bad_paths_documented
      
      * WIP: voting_data_works
      
      * done
      
      * Improve test voting_data_works
      
      * Add comment
      
      * Fill out test basic_setup_works
      
      * Update: iteration_is_semi_sorted
      
      * Improve remove_works
      
      * Update update_position_for_works; create set_ledger_and_free_balance
      
      * Improve get_works
      
      * Improve storage clean up checks in remove test
      
      * Test: impl rebag_works + insert_and_remove_works
      
      * forgot file -  Test: impl rebag_works + insert_and_remove_works
      
      * Small tweak
      
      * Update voter_bags test to reflect unused bags are removed
      
      * Unbond & Rebond: do_rebag
      
      * Prevent infinite loops with duplicate tail insert
      
      * Check iter.count on voter list in pre-migrate
      
      * undo strang fmt comment stuff
      
      * Add in todo
      
      Co-authored-by: default avatarkianenigma <[email protected]>
      
      * Try prepare for master merge
      
      * Reduce diff
      
      * Add comment for test to add
      
      * Add in code TODO for update_position efficiency updates
      
      * Initial impl compiles
      
      * impl StakingVoterListStub
      
      * Sample impl<T: Config> VoterListProvider<T> for VoterList<T>
      
      * impl VoterListProvider for voter-bags
      
      * WIP integrate pallet-voter-bags to staking mock
      
      * the trait `pallet_staking::pallet::pallet::Config` is not implemented for `mock::Test`
      
      * random
      
      * pushing my stuff
      
      * Mock working
      
      * WIP voter list tests
      
      * Add bag insert, remove tests
      
      * Add test for bag insert and remove
      
      * Add remaining tests for VoterList
      
      * Add tests for node
      
      * Add rebag works
      
      * Add rebag extrinsic tests
      
      * Rename to bags-list and name the list .. list!
      
      * Rename VoterBagThresholds => BagThresholds
      
      * Add test count_works
      
      * Test on_update_works
      
      * test sanity check
      
      * a round of test fixes
      
      * push a lot of changes
      
      * my last changes
      
      * all bags-list test work; fmt
      
      * Beautify some tests
      
      * Doc comment for bags-list
      
      * Add insert warnings
      
      * Setup initial benchmark
      
      * Wire up WeightInfo
      
      * is_terminal wip; everything broken!
      
      * Is terminal working
      
      * add TODOs for remove_node
      
      * clean up remoe_node
      
      * Fix all staking tests
      
      * retire VoterBagFor
      
      * commit
      
      * bring in stashed changes
      
      * save
      
      * bench pipeline works now, but I can't run stuff
      
      * sabe
      
      * benchmarks now run, but we have a failure
      
      * WIP: Wire up make_bags
      
      * bags-thresholds compiles
      
      * Fix most build issues
      
      * This will fix all the tests
      
      * move bag thresholds to bags-list
      
      * Move bag-thresholds bin to within pallet-bags
      
      * Remove some unnescary TODOs
      
      * Impl tets wrong_rebag_is_noop
      
      * assert remove is a noop with bad data
      
      * Assert integrity test panics
      
      * Return an error when inserting duplicates
      
      * Update to handle error in staking pallet when inserting to list
      
      * Test contains and on_insert error
      
      * Test re-nominate does not mess up list or count
      
      * Everything builds and works, only the benchmark...
      
      * fuck yeah benchmarks
      
      * more cleanup, more hardening.
      
      * use the bags list again
      
      * fix benhc
      
      * Some questions and changs for List::migration
      
      * Fix migration removed_bags and new_bags usage
      
      * Some trivial aesthetic changes
      
      * Some more trivial changes
      
      * tiny changes/
      
      * mega rename
      
      * fix all tests and ci build
      
      * nit
      
      * Test and fix migration
      
      * nit
      
      * fmt
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * fmt
      
      * remove unused
      
      * make a few things pub
      
      * make node also pub.. for remote-ext test
      
      * Fix all tests again
      
      * Force bag changes in relevant benchmarks (targets #9507) (#9529)
      
      * force rebag for unbond, rebond, and bond_extra
      
      * nit
      
      * Improve utils
      
      * fmt
      
      * nits
      
      * Move generate_bags to its own pallet
      
      * Get runtime-benchmarks feature setup with prepare_on_update_benchmark
      
      * Withdraw unbonded kill working
      
      * Nominate bench working
      
      * some cleanup
      
      * WIP
      
      * update to check head pre & post conditions
      
      * Add some post condition verification stuff for on_remove
      
      * Update nominate
      
      * fmt
      
      * Improvements
      
      * Fix build
      
      * fix build with polkadot companion
      
      * Update frame/bags-list/src/list/tests.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * move generate-bag from frame to utils
      
      * wip
      
      * refactor WIP
      
      * WIP save
      
      * Refactor working
      
      * some variable renaming
      
      * WIP: prepare to remove head checks
      
      * Finish MvP refactor
      
      * Some cleanup
      
      * Soem more cleanup
      
      * save
      
      * fix a lot of stuff
      
      * Update client/db/src/bench.rs
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * Apply suggestions from code review
      
      * Apply suggestions from code review
      
      * Fix some issues that came from trying to merge comments on github
      
      * some small changes
      
      * simplify it
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      Co-authored-by: default avatarkianenigma <[email protected]>
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * Build works
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Remove commented out debug assert
      
      * Remove some unused deps and some unused benchmarking stuff
      
      * Fix stakings ElectionDataProvider clear
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Improving staking pallet-bags-list migration
      
      * fix build and some comments;
      
      * comment
      
      * Reduce visibility in bags list components
      
      * make node.bag_upper only accesible to benchmarks
      
      * Address some feedback; comments updates
      
      * use nominator map comment
      
      * fix vec capacity debug assert
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * clarify VoterSnapshotPerBlock
      
      * Reduce diff on create_validators by wrapping with_seed
      
      * Some small improvements to staking benches
      
      * Soem comment updates
      
      * fix vec capacity debug assert ... for real this time
      
      * Reduce ListBags viz
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Remove supports_eq_unordered & Support eq_unordered
      
      * Update utils/frame/generate-bags/src/lib.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Make total-issuance & minimium-balance CLI args; Dont use emptry ext
      
      * Improve docs for generate bags CLI args
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Don't use default bags weight in node runtime
      
      * Feature gating sanity_check not working
      
      * Feature gate sanity check by creating duplicate fns
      
      * Fix line wrapping
      
      * Document VoteWeightProvider
      
      * Make bags ext-builder not a module
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * use pallet_bags_list instead of crate in mock
      
      * Make get_bags test helper fn live in List
      
      * use remove_from_storage_unchecked for node removal
      
      * Remove count of ids removed in remove_many
      
      * Add node sanity check, improve list sanity check
      
      * Do a list sanity check after on_update
      
      * List::migrate: clean up debug assert, exit early when no change in thresholds
      
      * Improve public doc comments for pallet_bags_list::list::List
      
      * Improve public doc comments for pallet_bags_list::list::List
      
      * Update generate bags docs
      
      * Fix grammar in bags-list benchmark
      
      * Add benchmark case for `rebag` extrinsic
      
      * Add count parameter to List::clear; WIP adding MaxEncodedLen to list'
      
      * MaxEncodeLen + generate_storage_info not working for Bag or Node
      
      * Get MaxEncodeLen derive to work
      
      * Try to correctly feature gate SortedListProvider::clear
      
      * Use u32::MAX, not u32::max_value
      
      * Get up to nominators_quota noms
      
      * SortedListProvider::clear takes an Option
      
      * Eplicitly ignore SortedListProvider return value
      
      * Fix doc comment
      
      * Update node-runtime voter snapshot per block
      
      * Add test get_max_len_voters_even_if_some_nominators_are_slashed
      
      * Add test only_iterates_max_2_times_nominators_quota
      
      * Fix generate bags cargo.toml
      
      * use sp_std vec
      
      * Remove v8 migration hooks from pallet-staking
      
      * Update npos trait
      
      * Try respect line width
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Update frame/bags-list/src/benchmarks.rs
      
      * Unwrap try-runtime error; remove sortedlistprovider pre upgrade len  check
      
      * trigger ci
      
      * restore
      
      * trigger ci
      
      * restore
      
      * trigger ci
      
      * revert
      
      * trigger ci
      
      * revert
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      Co-authored-by: default avatarKian Paimani <[email protected]>
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      Co-authored-by: default avatarkianenigma <[email protected]>
      Co-authored-by: default avatarXiliang Chen <[email protected]>
      Co-authored-by: default avatarParity Benchmarking Bot <[email protected]>
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      669972a1
  7. Sep 15, 2021
    • Andrew Jones's avatar
      Enrich metadata with type information (#8615) · 49b6dfd2
      Andrew Jones authored
      
      
      * Cargo.lock after merge
      
      * Restore scale-info feature
      
      * Fully qualify TypeInfo derive
      
      * Skip PendingSwap T
      
      * Add missing skip_type_params attr
      
      * metadata docs features
      
      * Reduce pallet event attribute to struct
      
      * Cargo.lock
      
      * Update frame/balances/src/tests_composite.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Line widths check
      
      * Cargo.lock
      
      * Add scale-info/std
      
      * Update frame/system/src/lib.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Use `skip_type_params` to remove `TypeInfo` requirements on checks
      
      * Revert "Remove unused Call metadata stuff"
      
      This reverts commit 41311f85
      
      * Skip BalanceSwapAction type parameter
      
      * Remove unused event metadata macro
      
      * Update frame-metadata
      
      * Update primitives/npos-elections/compact/src/codec.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Manual TypeInfo for Header
      
      * Remove TypeInfo requirement for consts in BoundedVec etc.
      
      * Another TypeInfo bound removed
      
      * review: fix indentation
      
      * TypeInfo impls for Identity types
      
      * Add some todos to add custom TypeInfo impls
      
      * Update frame/support/procedural/src/pallet/expand/pallet_struct.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Add some todos to add custom TypeInfo impls
      
      * Add a test for manual Data TypeInfo impl
      
      * Add custom TypeInfo impl for Vote
      
      * Era custom TypeInfo crimes
      
      * Revert finality-grandpa version to 0.14.z
      
      * review: renamed module to pallet_constants_metadata
      
      * New line at end of file
      
      * Add missing scale-info/std
      
      * Update frame/support/src/storage/types/mod.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Remove StorageEntryType::Map unused flag
      
      * Add missing scale-info dependency after merge
      
      * SignedExtension::AdditionalSigned metadata
      
      * Update frame-metadata, use abbreviated docs and args fields
      
      * Update frame/example/Cargo.toml
      
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      
      * Add scale_info/std and remove unused scale-info dependency
      
      * Remove scale-info dependency
      
      * Remove treasury pallet::metadata
      
      * Remove redundant Event test
      
      * Add back scale-info as dev dependency
      
      * fix error metadata when no error defined in decl_module
      
      * Add Module3 to tests
      
      * Fix metadata test
      
      * Add docs feature to frame-support test
      
      * WIP fixing pallet metadata test
      
      * Remove redundant FunctionMetadata, FunctionArgumentMetadata as per https://github.com/paritytech/frame-metadata/pull/20
      
      * Use main branch of frame-metadata
      
      * Use patch of scale-info for latest changes
      
      * Use latest patched scale-info
      
      * Manual TypeInfo for DigestItem
      
      * Manual TypeInfo for DigestItem
      
      * Update scale-info
      
      * Skip __Ignore variants for Error, depends on https://github.com/paritytech/scale-info/pull/117
      
      * Named fields for FRAME v2 pallet Call variants
      
      * Named fields for FRAME v1 pallet Call variants
      
      * Add missing scale-info dependency
      
      * WIP expand benchmark call variant
      
      * fix benchmark with new function
      
      create a new function for each variant of a pallet call.
      This function is called by benchmarking macro in order not to break call
      creation with unnamed argument
      
      * fix tests
      
      * more fix
      
      * Fix staking tests
      
      * Fix offchain workers calls
      
      * Cherry pick rustfmt.toml from master
      
      * cargo +nightly-2021-06-22 fmt --all
      
      * Update to new call variant structs
      
      * More call variant struct updates
      
      * Remove unused import
      
      * More call variant structs
      
      * More call variant structs
      
      * Even more call variant structs
      
      * Mooar variant structs
      
      * Evermore variant structs
      
      * Call variant structs ad infinitum
      
      * Fmt
      
      * More call variants
      
      * Last call variant
      
      * Call variants all done?
      
      * Fix SS58Prefix type
      
      * Potential workaround for BitFlags<IdentityFields> TypeInfo
      
      * Enable docs capturing for Call, Event, and Error types
      
      * Fix IdentityFields TypeInfo
      
      * Remove metadata-docs feature
      
      * Add capture_docs = true for legacy Call, Event and Error types
      
      * Fmt
      
      * Fix metadata test type
      
      * Update benchmarks with call struct variants
      
      * Fmt
      
      * More test fixes
      
      * Fmt
      
      * Fix benches
      
      * Use latest capture_docs attr
      
      * Latest scale_info
      
      * Fmt
      
      * review: change &Vec to &[]
      
      * Remove pallet metadata attr
      
      * review: remove commented out test code
      
      * review: skip_type_params trailing comma suggestion
      
      * Update to scale-info 0.10.0
      
      * Update construct_runtime ui tests, different because of metadata TypeInfo impls
      
      * Add some TypeInfo derives for UI tests
      
      * Update storage ensure span ui stderrs
      
      * Update call argument bound ui tests
      
      Possibly changed because change from tuple to struct variants?
      
      * Add scale-info dev dependency
      
      * Update to latest finality-grandpa release
      
      * review: missing newline
      
      * review: missing scale-info/std
      
      * review: remove duplicate scale-info/std
      
      * review: remove fully qualified TypeInfo
      
      * review: add missing scale-info/std
      
      * review: remove unnecessary imports.
      
      * Fmt
      
      * Use crates.io RC version of frame-metadata
      
      * Remove scale-info/std because it is a dev dependency
      
      * Add missing scale_info dev-dependency for test
      
      * Delete empty metadata folder
      
      * Fix sp_std import
      
      * review: improve manual UncheckedExtrinsic TypeInfo impl
      
      * review: use full scale-info for dev-dependency
      
      * Remove DefaultByteGetter impl
      
      * review: derive TypeInfo for generic header
      
      * Fmt
      
      * Update primitives/runtime/src/generic/unchecked_extrinsic.rs
      
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      
      * Update primitives/runtime/src/generic/unchecked_extrinsic.rs
      
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      
      * Update bin/node/executor/Cargo.toml
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Update frame/identity/src/types.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Update frame/support/src/dispatch.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Remove redundant derive
      
      * Simplify scale-info dependency
      
      * Strip underscore prefix from call variant struct names
      
      * Another underscore field
      
      * More underscore fields
      
      * Another underscore field
      
      * Update to frame-metadata 14.0.0-rc.2 with combined StorageEntryType::Map
      
      * Fmt
      
      * Revert weights formatting
      
      * Fix up some tests
      
      * Fix up some tests for StorageEntryTypeMetadata
      
      * scale-info dev dependency
      
      * Fix test error
      
      * Add missing TypeInfo derives
      
      * Add back missing scale-info dependency
      
      * Add back missing scale-info dependency
      
      * Fix npos compact impls
      
      * Cargo.lock
      
      * Fmt
      
      * Fix errors
      
      * Fmt
      
      * Fix renamed raw_solution field
      
      * Fix error
      
      * Fmt
      
      * Fix some benchmarks
      
      * Fmt
      
      * Stray R
      
      * Fix
      
      * Add missing TypeInfos
      
      * ui test fix
      
      * Fix line widths
      
      * Revert "ui test fix"
      
      This reverts commit 2d15ec058a216e3f92d713f1174603a2bb1eac65.
      
      * Upgrade to scale-info 0.11.0
      
      * Revert "Upgrade to scale-info 0.11.0"
      
      This reverts commit 047bb179085a0059c36cd20ab405f55cf0867e28.
      
      * Add Runtime type
      
      * Update to scale-info 0.12
      
      * Update to scale-info 1.0
      
      * Update frame-metadata to version 14.0.0
      
      * Patch finality-grandpa until release available
      
      * Fix metadata tests
      
      * Fix metadata tests
      
      * Fmt
      
      * Remove patched finality-grandpa
      
      * Fix tests, use scale_info imports
      
      * Fix pallet tests
      
      * Add BlockNumber TypeInfo bound
      
      * ui test fix
      
      * Cargo.lock
      
      * Remove pallet metadata
      
      * Cargo.lock
      
      * Add missing scale-info dependency
      
      * Remove pallet event metadata
      
      * Fix error
      
      * Fix collective errors
      
      * Semicolol
      
      * Fmt
      
      * Remove another metadata attribute
      
      * Add new variant to custom digest TypeInfo
      
      * Fmt
      
      * Cargo.lock from master
      
      * Remove comma lol
      
      * Fix example call error
      
      * Fix example call error properly
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      49b6dfd2
  8. Aug 19, 2021
    • Kian Paimani's avatar
      remove the uselsss weight return type from election provider API (#9569) · 7a32c350
      Kian Paimani authored
      
      
      * remove the uselsss weight return type from election provider API
      
      * fix everything, should be ready for final benchmark
      
      * simplify on_init a bit furhter
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * remove unwraps
      
      * fmt
      
      * Update lock file
      
      * whitelist block weight
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * fix warning
      
      Co-authored-by: default avatarParity Benchmarking Bot <[email protected]>
      7a32c350
  9. Aug 07, 2021
  10. Jul 27, 2021
  11. Jul 24, 2021
  12. Jul 23, 2021
  13. Jul 22, 2021
  14. Jul 21, 2021
    • Bastian Köcher's avatar
      Run cargo fmt on the whole code base (#9394) · 7b56ab15
      Bastian Köcher authored
      * Run cargo fmt on the whole code base
      
      * Second run
      
      * Add CI check
      
      * Fix compilation
      
      * More unnecessary braces
      
      * Handle weights
      
      * Use --all
      
      * Use correct attributes...
      
      * Fix UI tests
      
      * AHHHHHHHHH
      
      * 🤦
      
      * Docs
      
      * Fix compilation
      
      * 🤷
      
      * Please stop
      
      * 🤦
      
       x 2
      
      * More
      
      * make rustfmt.toml consistent with polkadot
      
      Co-authored-by: default avatarAndré Silva <[email protected]>
      7b56ab15
  15. Jul 16, 2021
  16. Jul 09, 2021
    • Kian Paimani's avatar
      Make election benchmarks more *memory-aware* (#9286) · 3850a433
      Kian Paimani authored
      
      
      * Make benchmarks a bit better with mem
      
      * Make election benchmarks more *memory-aware*
      
      * Fix a few errors
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Manually fix the weights
      
      * Update lock file
      
      * remove dupe
      
      * Fix tests
      
      * cargo update pwasm
      
      Co-authored-by: default avatarParity Bot <[email protected]>
      3850a433
  17. Jul 07, 2021
  18. Jul 06, 2021
  19. Jul 05, 2021
  20. Jun 28, 2021
    • Shawn Tabrizi's avatar
      Improve Staking Limits (#9193) · 5cd04820
      Shawn Tabrizi authored
      * only allow `chill_other` near threshold.
      
      * improve test
      
      * skip limit check for existing validators / nominators
      
      * add `ChillThreshold`
      
      * rename to `set` for consistent api
      
      * more tests
      
      * fix some line width
      5cd04820
  21. Jun 16, 2021
  22. Jun 15, 2021
  23. Jun 14, 2021
  24. Jun 12, 2021
  25. Jun 08, 2021
    • Shawn Tabrizi's avatar
      Emit `Bonded` event when rebonding (#9040) · 28bfba14
      Shawn Tabrizi authored
      
      
      * Emit `Bonded` event when rebonding
      
      * fix borrow checker
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      Co-authored-by: default avatarParity Bot <[email protected]>
      28bfba14
  26. Jun 07, 2021
  27. May 03, 2021
    • Lohann Paterno Coutinho Ferreira's avatar
      Remove Offence delay (#8414) · ffca28ba
      Lohann Paterno Coutinho Ferreira authored
      
      
      * Removed can_report api from OnOffenceHandler
      
      * Removed DeferredOffences and create a storage migration
      
      * Removed missing comments
      
      * Mock set_deferred_offences and deferred_offences methods
      
      * OnOffenceHandler::on_offence always succeed
      
      * Fix benchmark tests
      
      * Fix runtime-benchmark cfg methods
      
      * Removed 'applied' attribute from Offence event
      
      * refactor deprecated deferred offences getter
      
      * Validate if offences are submited after on_runtime_upgrade
      
      * update changelog
      
      * Remove empty lines
      
      * Fix remove_deferred_storage weights
      
      * Remove Offence::on_runtime_upgrade benchmark
      
      * Revert CHANGELOG.md update
      
      * Deprecate DeferredOffenceOf type
      
      * Update copyright
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Add migration logs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Fix migration log
      
      * Remove unused import
      
      * Add migration tests
      
      * rustfmt
      
      * use generate_storage_alias! macro
      
      * Refactor should_resubmit_deferred_offences test
      
      * Replace spaces by tabs
      
      * Refactor should_resubmit_deferred_offences test
      
      * Removed WeightSoftLimit
      
      * Removed WeightSoftLimit from tests and mocks
      
      * Remove unused imports
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      ffca28ba
    • ferrell-code's avatar
      Upgrade authorship pallet to Frame-v2 (#8663) · e0f85464
      ferrell-code authored
      
      
      * first commit
      
      * get to compile
      
      * fix deprecated grandpa
      
      * formatting
      
      * module to pallet
      
      * add authorship pallet to mocks
      
      * Fix upgrade of storage.
      
      Co-authored-by: default avatarXiliang Chen <[email protected]>
      
      * trigger CI
      
      * put back doc
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      Co-authored-by: default avatarXiliang Chen <[email protected]>
      e0f85464
  28. Apr 23, 2021
  29. Apr 16, 2021
    • Bastian Köcher's avatar
      Remove `serde` requirement from FRAME macros (#8628) · c8136bd1
      Bastian Köcher authored
      
      
      * Remove `serde` requirement from FRAME macros
      
      Currently there is some implicit requirement on `serde` being present in
      the `Cargo.toml` of a pallet when `GenesisConfig` is used. This pr
      removes this requirement by using the serde attribute `serde(crate = "..")`.
      
      * build a unique reexport of serde in impl_opaque_keys, by abusing paste doc concatenation
      
      * Optimize
      
      Co-authored-by: default avatarthiolliere <[email protected]>
      c8136bd1
  30. Mar 30, 2021
  31. Mar 29, 2021
    • Kian Paimani's avatar
      Bring back the on_finalize weight of staking. (#8463) · 7b2cf33b
      Kian Paimani authored
      * Bring back the on_finalize weighg of stakin.
      
      * Better logs
      
      * Also make a few things pub
      
      * Fix build
      
      * Add assertions
      
      * Add test.
      
      * remove dbg
      
      * Update frame/election-provider-multi-phase/src/unsigned.rs
      
      * Update frame/staking/src/tests.rs
      
      * Fix
      
      * Fix
      
      * Update frame/election-provider-multi-phase/src/unsigned.rs
      7b2cf33b
  32. Mar 28, 2021
    • Zeke Mostov's avatar
      [pallet-staking] Refund unused weight for `payout_stakers` (#8458) · 2af0de50
      Zeke Mostov authored
      
      
      * [pallet-staking] Refund unused weight for `payout_stakers` 
      
      fixes #8428
      
      * Use periods in comments
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Address Shawn's Feedback
      
      * Assert monotomic weights && improve test note
      
      * Remove stray new line
      
      * debug_assert payout_count <= max
      
      * Only track payouts to nominators; not validators
      
      * Trivial comment update
      
      Co-authored-by: default avatarParity Benchmarking Bot <[email protected]>
      2af0de50
  33. Mar 25, 2021
    • Kian Paimani's avatar
      Make the number of nominations configurable (#8368) · f571023d
      Kian Paimani authored
      
      
      * Base features and traits.
      
      * pallet and unsigned phase
      
      * Undo bad formattings.
      
      * some formatting cleanup.
      
      * Small self-cleanup.
      
      * Make it all build
      
      * self-review
      
      * Some doc tests.
      
      * Some changes from other PR
      
      * Fix session test
      
      * Update Cargo.lock
      
      * Update frame/election-provider-multi-phase/src/lib.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Some review comments
      
      * Rename + make encode/decode
      
      * Do an assert as well, just in case.
      
      * Fix build
      
      * Update frame/election-provider-multi-phase/src/unsigned.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Las comment
      
      * fix staking fuzzer.
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Add one last layer of feasibility check as well.
      
      * Last fixes to benchmarks
      
      * Some more docs.
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Some nits
      
      * It all works
      
      * Some self cleanup
      
      * Update frame/staking/src/lib.rs
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      
      * remove most todos.
      
      * Round of self-review.
      
      * Fix migration
      
      * clean macro
      
      * Revert wrong merge
      
      * Make the number of nominations configurable
      
      * Self reivew
      
      * renmae.
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      Co-authored-by: default avatarParity Benchmarking Bot <[email protected]>
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      f571023d
  34. Mar 23, 2021
  35. Mar 20, 2021
    • Kian Paimani's avatar
      Decouple Staking and Election - Part 2.1: Unleash Multi Phase (#8113) · 0c696518
      Kian Paimani authored
      
      
      * Base features and traits.
      
      * pallet and unsigned phase
      
      * Undo bad formattings.
      
      * some formatting cleanup.
      
      * Small self-cleanup.
      
      * Make it all build
      
      * self-review
      
      * Some doc tests.
      
      * Some changes from other PR
      
      * Fix session test
      
      * Update Cargo.lock
      
      * Update frame/election-provider-multi-phase/src/lib.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Some review comments
      
      * Rename + make encode/decode
      
      * Do an assert as well, just in case.
      
      * Fix build
      
      * Update frame/election-provider-multi-phase/src/unsigned.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Las comment
      
      * fix staking fuzzer.
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Add one last layer of feasibility check as well.
      
      * Last fixes to benchmarks
      
      * Some more docs.
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Some nits
      
      * It all works
      
      * Some self cleanup
      
      * Update frame/staking/src/lib.rs
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      
      * remove most todos.
      
      * Round of self-review.
      
      * Fix migration
      
      * clean macro
      
      * Revert wrong merge
      
      * remove fuzzer stuff.
      
      * Self review
      
      * Update frame/staking/src/lib.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * review comments
      
      * add logs
      
      * Add tests to demonstrate the capacity of the snapshot.
      
      * Replace upgrade
      
      * Last touches
      
      * Fix benchmakrs
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * remove unused stuff
      
      * Fix tests.
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      Co-authored-by: default avatarParity Benchmarking Bot <[email protected]>
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      0c696518