- Nov 30, 2022
-
-
Marcin S. authored* Put in skeleton logic for CPU-time-preparation Still needed: - Flesh out logic - Refactor some spots - Tests * Continue filling in logic for prepare worker CPU time changes * Fix compiler errors * Update lenience factor * Fix some clippy lints for PVF module * Fix compilation errors * Address some review comments * Add logging * Add another log * Address some review comments; change Mutex to AtomicBool * Refactor handling response bytes * Add CPU clock timeout logic for execute jobs * Properly handle AtomicBool flag * Use `Ordering::Relaxed` * Refactor thread coordination logic * Fix bug * Add some timing information to execute tests * Add section about the mitigation to the IG * minor: Change more `Ordering`s to `Relaxed` * candidate-validation: Fix build errors
-
alexgparity authored
* Add clippy config and remove .cargo from gitignore * first fixes * Clippyfied * Add clippy CI job * comment out rusty-cachier * minor * fix ci * remove DAG from check-dependent-project * add DAG to clippy Co-authored-by:alvicsam <[email protected]>
-
Mara Broda authored
* westend: update transaction version * polkadot: update transaction version * kusama: update transaction version * Bump spec_version to 9330 * bump versions to 0.9.33
-
- Nov 29, 2022
-
-
Marcin S. authored
-
Serban Iorga authored
* Spawn MMR gadget when offchain indexing is enabled * companion PR code review changes: 1st iteration * Code review changes: 2nd iteration * update lockfile for {"substrate"} Co-authored-by:acatangiu <[email protected]> Co-authored-by: parity-processbot <>
-
- Nov 28, 2022
-
-
Andrei Sandu authored
* RollingSession: add fn contains Signed-off-by:
Andrei Sandu <[email protected]> * handle_import_statements fix ancient dispute check Signed-off-by:
-
Marcin S. authored
-
Mattia L.V. Bradascio authored
* Add buckets below 5ms * Add more specific histogram buckets * Add more specific buckets * cargo fmt
-
- Nov 26, 2022
-
-
Sebastian Kunert authored
* Add option ot add outbound_only configurations * Improve comment
-
- Nov 24, 2022
-
-
tugy authored
* add wss and update dns * fix wrong node id
-
- Nov 23, 2022
-
-
eskimor authored
* We actually don't need to rate limit redundant requests. Those redundant requests should not actually happen, but still. * Add some logging. * Also log message when the receiving side hit the rate limit. * Update node/network/dispute-distribution/src/sender/mod.rs Co-authored-by:
Alexandru Vasile <[email protected]> Co-authored-by:
eskimor <[email protected]> Co-authored-by:
-
Marcin S. authored
* Add PVF module documentation TODO (once the PRs land): - [ ] Document executor parametrization. - [ ] Document CPU time measurement of timeouts. * Update node/core/pvf/src/lib.rs Co-authored-by:
Andrei Sandu <[email protected]> * Clarify meaning of PVF acronym * Move PVF doc to implementer's guide * Clean up implementer's guide a bit * Add page for PVF types * pvf: Better separation between crate docs and implementer's guide * ci: Add "prevalidating" to the dictionary * ig: Remove types/chain.md The types contained therein did not exist and the file was not referenced anywhere. Co-authored-by:
-
- Nov 18, 2022
-
-
Koute authored
* Remove the `wasmtime` feature flag * Update `substrate` to the newest `master` * Update `substrate` to the newest `master`
-
- Nov 17, 2022
-
-
Tsvetomir Dimitrov authored
* Change best effort queue behaviour in `dispute-coordinator` Use the same type of queue (`BTreeMap<CandidateComparator, ParticipationRequest>`) for best effort and priority in `dispute-coordinator`. Rework `CandidateComparator` to handle unavailable parent block numbers. Best effort queue will order disputes the same way as priority does - by parent's block height. Disputes on candidates for which the parent's block number can't be obtained will be treated with the lowest priority. * Fix tests: Handle `ChainApiMessage::BlockNumber` in `handle_sync_queries` * Some tests are deadlocking on sending messages via overseer so change `SingleItemSink`to `mpsc::Sender` with a buffer of 1 * Fix a race in test after adding a buffered queue for overseer messages * Fix the rest of the tests * Guide update - best-effort queue * Guide update: clarification about spam votes * Fix tests in `availability-distribution` * Update comments * Add `make_buffered_subsystem_context` in `subsystem-test-helpers` * Code review feedback * Code review feedback * Code review feedback * Don't add best effort candidate if it is already in priority queue * Remove an old comment * Fix insert in best_effort
-
Andrei Sandu authored
Signed-off-by:
-
Kutsal Kaan Bilgin authored
-
- Nov 16, 2022
-
-
Tsvetomir Dimitrov authored
* Fix typos * Filter unconfirmed disputes in provisioner - random_selection * Rework dispute coordinator to return `DisputeStatus` with `ActiveDisputes` message. * Rework the random_selection implementation of `select_disptues` in `provisioner` to return only confirmed disputes. * Filter unconfirmed disputes in provisioner - prioritized_selection * Add test for unconfirmed disputes handling * Fix `dispute-distribution` tests
-
- Nov 15, 2022
-
-
Marcin S. authored
Was seeing these warnings when running `cargo check --all`: ``` warning: for loop over an `Option`. This is more readably written as an `if let` statement --> node/core/approval-voting/src/lib.rs:1147:21 | 1147 | for activated in update.activated { | ^^^^^^^^^^^^^^^^ | = note: `#[warn(for_loops_over_fallibles)]` on by default help: to check pattern in a loop use `while let` | 1147 | while let Some(activated) = update.activated { | ~~~~~~~~~~~~~~~ ~~~ help: consider using `if let` to clear intent | 1147 | if let Some(activated) = update.activated { | ~~~~~~~~~~~~ ~~~ ``` My guess is that `activated` used to be a SmallVec or similar, as is `deactivated`. It was changed to an `Option`, the `for` still compiled (it's technically correct, just weird), and the compiler didn't catch it until now. -
eskimor authored
Co-authored-by:
-
- Nov 14, 2022
-
-
eskimor authored
* Only report concluded if there is an actual dispute. Hence no "non"-disputes will be added to disputes anymore. * Fix redundant check. * Test for no onesided disputes. Co-authored-by:
-
- Nov 12, 2022
-
-
ordian authored
* approval-voting: remove a redundant check * candidate-validation: remove unreachable check
-
- Nov 11, 2022
-
-
Tsvetomir Dimitrov authored
* Scraper processes CandidateBacked events * Change definition of best-effort * Fix `dispute-coordinator` tests * Unit test for dispute filtering * Clarification comment * Add tests * Fix logic If a dispute is not backed, not included and not confirmed we don't participate but we do import votes. * Add metrics for refrained participations * Revert "Add tests" This reverts commit 7b8391a087922ced942cde9cd2b50ff3f633efc0. * Revert "Unit test for dispute filtering" This reverts commit 92ba5fe678214ab360306313a33c781338e600a0. * fix dispute-coordinator tests * Fix scraping * new tests * Small fixes in guide * Apply suggestions from code review Co-authored-by:
-
- Nov 08, 2022
-
-
Marcin S. authored
* Fix a couple of typos * Retry failed PVF execution PVF execution that fails due to AmbiguousWorkerDeath should be retried once. This should reduce the occurrence of failures due to transient conditions. Closes #6195 * Address a couple of nits * Write tests; refactor (add `validate_candidate_with_retry`) * Update node/core/candidate-validation/src/lib.rs Co-authored-by:
Andronik <[email protected]> Co-authored-by:
eskimor <[email protected]> Co-authored-by:
-
Andrei Sandu authored
* Impl dynamic window size. Keep sessions for unfinalized chain Signed-off-by:
-
Marcin S. authored
-
- Nov 07, 2022
-
-
Michal Kucharczyk authored* BlockId removal: &Hash to Hash It changes &Block::Hash argument to Block::Hash. This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292) * missing file corrected * update lockfile for {"substrate"} Co-authored-by: parity-processbot <> -
Alexander Samusev authored
* Pipeline with ci image with rust 1.65 * fix a warning * return production image Co-authored-by:
-
- Nov 04, 2022
-
-
Tom authored
* add stake.plus bootnodes * add stake.plus bootnodes for westend, kusama and polkadot Co-authored-by:senseless <[email protected]> Co-authored-by: parity-processbot <>
-
- Nov 03, 2022
-
-
Michal Kucharczyk authored
* BlockId removal: refactor: Backend::block_indexed_body It changes the arguments of `Backend::block_indexed_body` method from: `BlockId<Block>` to: `&Block::Hash` This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292) * update lockfile for {"substrate"} Co-authored-by: parity-processbot <>
-
- Nov 02, 2022
-
-
Michal Kucharczyk authored
* BlockId removal: refactor: Backend::justifications It changes the arguments of `Backend::justifications` method from: `BlockId<Block>` to: `&Block::Hash` This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292) * formatting * update lockfile for {"substrate"} Co-authored-by: parity-processbot <>
-
- Nov 01, 2022
-
-
alexgparity authored
* Replace parachain/parathread boolean by enum * Address PR comments * Update dependencies * ParaType -> ParaKind * Swap enum field order to avoid migration * Rename paratype field to parakind * Manual en-/decocing of Parakind * Manual TypeInfo for ParaKind * rename field back to parachain * minor * Update runtime/parachains/src/paras/mod.rs Co-authored-by:
-
Michal Kucharczyk authored
* BlockId removal: refactor: BlockBackend::block_body It changes the arguments of `BlockBackend::block_body` method from: `BlockId<Block>` to: `&Block::Hash` This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292) * update lockfile for {"substrate"} Co-authored-by: parity-processbot <> -
Marcin S. authored
* Rename timeout consts and timeout parameter; bump leniency * Update implementor's guide with info about PVFs * Make glossary a bit easier to read * Add a note to LENIENT_PREPARATION_TIMEOUT * Remove PVF-specific section from glossary * Fix some typos
-
- Oct 31, 2022
-
-
Andrei Sandu authored
* Add approval voting db sanity check Signed-off-by:
-
- Oct 26, 2022
-
-
Marcin S. authored
* Log exit status code for workers * Make log for execute job conclusion match prepare job conclusion Trace log for conclusion of prepare job: ```rs gum::debug!( target: LOG_TARGET, validation_code_hash = ?artifact_id.code_hash, ?worker, ?rip, "prepare worker concluded", ); ``` Co-authored-by: parity-processbot <>
-
- Oct 22, 2022
-
-
Boluwatife Bakre authored
* Fix for issue #2403 * Nightly fmt * Quick documentation fixes * Default Implementation * iter() function integrated * Implemented iter functionalities * Fmt * small change * updates node-network * updates in dispute-coordinator * Updates * benchmarking fix * minor fix * test fixes in runtime api * Update primitives/src/v2/mod.rs Co-authored-by:
-
Mara Broda authored
* Bump spec_version to 9310 * bump transaction_version (0.9.31) (#6171) * Bump transaction_version for polkadot * Bump transaction_version for kusama * Bump transaction_version for rococo * Bump transaction_version for westend * Bump transaction_version for polkadot * Bump transaction_version for kusama * Bump transaction_version for rococo * Bump transaction_version for westend * Bump crate versions (0.9.31)
-
- Oct 18, 2022
-
-
Michal Kucharczyk authored
* BlockId removal: refactor: StorageProvider It changes the arguments of `Backend::StorageProvider` trait from: block: `BlockId<Block>` to: hash: `&Block::Hash` * Update node/client/src/lib.rs Co-authored-by:
Bastian Köcher <[email protected]> * update lockfile for {"substrate"} Co-authored-by:
-
ordian authored
* availability-recovery: use `IfDisconnected::TryConnect` for chunks * fix tests
-
Sebastian Kunert authored
* Move clap to 4.0.9 * Remove "deprecated" feature flag * Convert to default_value_t * update lockfile for {"substrate"} * Add group(skip) to avoid naming conflict * More group(skip) Co-authored-by: parity-processbot <>
-
