Skip to content
  1. Jul 29, 2022
    • Adrian Catangiu's avatar
      Lean BEEFY to Full BEEFY - don't skip (older) mandatory blocks and import justifications (#11821) · 1c6867c6
      Adrian Catangiu authored 
      

* client/beefy: don't accept vote for older rounds

* client/beefy: clean up and reorg the worker struct

* client/beefy: first step towards Full BEEFY

The first step from Lean->Full BEEFY is to have the worker
enforce uninterrupted line of BEEFY finalized mandatory blocks.

There is one mandatory block per session (the first block in the
session). As such, votes processing and votes generation now
enforces that all mandatory blocks are finalized in strict
monotonically increasing sequence and no block 'N' will be worked
on if there is any GRANDPA finalized but BEEFY non-final mandatory
block 'M', where 'M < N'.

Implementation details:

- Introduced 'VoterOracle' to separate the voting decisions logic,
  and track new/pending sessions.

- New sessions get queued up with the worker operating either:
  1. up-to-date - all mandatory blocks leading up to current GRANDPA
     finalized: queue has ONE element, the 'current session' where
     `mandatory_done == true`,
  2. lagging behind GRANDPA: queue has [1, N] elements, where all
     `mandatory_done == false`.
     In this state, everytime a session gets its mandatory block
     BEEFY finalized, the session is popped off the queue,
     eventually getting to operating mode `1. up-to-date`.

- Votes get triaged and those that fall withing the `VoterOracle`
  allowed window get processed, the others get dropped if stale,
  or buffered for later processing (when they reach the window).

- Worker general code was also updated to fall in one of two roles:
  1. react to external events and change internal 'state',
  2. generate events/votes based on internal 'state'.

Signed-off-by: default avataracatangiu <[email protected]>

* client/beefy: sketch idea for block import and sync

Signed-off-by: default avataracatangiu <[email protected]>

* client/beefy: add BEEFY block import

* client/beefy: process justifications from block import

* client/beefy: add TODOs for sync protocol

* client/beefy: add more docs and comments

* client/beefy-rpc: fix RPC error

* client/beefy: verify justification validity on block import

* client/beefy: more tests

* client/beefy: small fixes

- first handle and note the self vote before gossiping it,
- don't shortcircuit on err when processing pending votes.

* client/beefy: remove invalid justifications at block import

* todo: beefy block import tests

* RFC: ideas for multiple justifications per block

* Revert "RFC: ideas for multiple justifications per block"

This reverts commit 8256fb07d3124db69daf252720b3c0208202624d.

* client/beefy: append justif to backend on block import

* client/beefy: groundwork for block import test

* client/beefy: groundwork2 for block import test

* client/beefy: groundwork3 for block import test

* client/beefy: add block import test

* client/beefy: add required trait bounds to block import builder

* remove client from beefy block import, backend gets the job done

Signed-off-by: default avataracatangiu <[email protected]>
      1c6867c6
    • Dmitry Markin's avatar
      Always allocate slots for reserved nodes (#11909) · 2d8cf7b0
      Dmitry Markin authored 
      * Always allocate slots for reserved nodes

* minor: replace no-slot peer counter with a set
      2d8cf7b0
    • Mak's avatar
      Integrate automatic update of substrate-node-template (#11931) · 135c5843
      Mak authored 
      

* Integrate automatic update of substrate-node-template

* Update scripts/ci/gitlab/pipeline/publish.yml

Co-authored-by: default avatarAlexander Samusev <[email protected]>

Co-authored-by: default avatarAlexander Samusev <[email protected]>
      135c5843
    • joe petrowski's avatar
      Require Alliance Initialisation Before Joining (#11917) · 3bb68baa
      joe petrowski authored 
      * require alliance initialisation before joining

* use noop

* make one definition of initialization

* rename event

* add todo comment

* update doc
      3bb68baa
    • yjh's avatar
      feat: add propose method for SimpleSlotWorker (#11692) · 6d2f5d6a
      yjh authored 
      * feat: add propose method for SimpleSlotWorker

* remove param slot

* improve code

* fmt
      6d2f5d6a
    • Bastian Köcher's avatar
      construct_runtime!: Support parsing `struct Runtime` (#11932) · 4b3aced8
      Bastian Köcher authored 
      * construct_runtime!: Support parsing `struct Runtime`

* FMT
      4b3aced8
    • Koute's avatar
      Prevent double allocation of the payload when calling `sp_io::storage::get` (#11523) · c4b607d4
      Koute authored 
      

* Expose allocation stats in `FreeingBumpHeapAllocator`

* Return allocation stats when calling into the runtime

* Bump `parity-scale-codec` to 3.1.3 (fork)

* Prevent double allocation of the payload when calling `sp_io::storage::get`

* Fix tests

* Remove unnecessary `mut`

* Enable the `bytes` feature for `parity-scale-codec` in `sp-runtime-interface`

* Update client/allocator/src/freeing_bump.rs

Co-authored-by: default avatarBastian Köcher <[email protected]>

* Bump `parity-scale-codec` to 3.1.3

* Fix some of the UI tests

Co-authored-by: default avatarBastian Köcher <[email protected]>
      c4b607d4
  3. Jul 28, 2022
  5. Jul 27, 2022
  7. Jul 26, 2022
  9. Jul 25, 2022
  11. Jul 24, 2022
  13. Jul 23, 2022
  15. Jul 22, 2022
  17. Jul 21, 2022
    • Robert Hambrock's avatar
      pallet-mmr: fix batch proof failures (#11840) · 05c71381
      Robert Hambrock authored 
      * pallet-mmr: extend batch proof verification test

covers all possible 2-leaf combinations now, including current
verification failures that batch proof item count limit is too low
sometimes.

* raise upper bound on proof item number

as described in
https://github.com/paritytech/substrate/issues/11753#issuecomment-1179838174

* test for powerset of leaves

* refactor batch proof verification test

* test all batch proofs for mmr sizes up to n=13

* limit mmr size to reduce batch proof test duration

* use saturating integer addition for proof check

* extract common chain building in batch proof tests

note: right now, since not killing old chain, it keeps growing by 7
blocks for every leaf selection (added after proof generation), hence
heavier to compute.

* only add blocks after a proof generation once

* increase batch proof testing range

* register offchain extensions only once

* fmt & remove unused util
      05c71381
    • Alexander Samusev's avatar
      [ci] Generate rustdocs without dependencies (#11885) · c3812f40
      Alexander Samusev authored
      c3812f40
    • Nazar Mokrynskyi's avatar
      Stop RPC servers on drop (#11679) · 8c323a20
      Nazar Mokrynskyi authored 
      * Stop RPC servers on drop

* Switch to existing wrappers that stop RPC servers

* Apply formatting
      8c323a20
    • Dmitry Markin's avatar
      Cleanup light client leftovers (#11865) · b7ecd1af
      Dmitry Markin authored 
      

* Remove --light cli option

* Cleanup light client leftovers

* Remove commented-out code and clean-up more light client leftovers

* Fix formatting with `cargo +nightly fmt`

* Remove FIXME regarding db directory structure

Co-authored-by: default avatarBastian Köcher <[email protected]>

Co-authored-by: default avatarBastian Köcher <[email protected]>
      b7ecd1af
  19. Jul 20, 2022
  21. Jul 19, 2022
  23. Jul 18, 2022
  25. Jul 17, 2022