Skip to content
  1. Mar 31, 2023
    • PG Herveou's avatar
      [Contracts] Overflowing bounded `DeletionQueue` allows DoS against contract termination (#13702) · 1bd5d2f7
      PG Herveou authored 
      

* [Contracts review] Overflowing bounded `DeletionQueue` allows DoS against contract termination

* wip

* wip

* wip

* wip

* wip

* fix doc

* wip

* PR review

* unbreak tests

* fixes

* update budget computation

* PR comment: use BlockWeights::get().max_block

* PR comment: Update queue_trie_for_deletion signature

* PR comment: update deletion budget docstring

* PR comment: impl Default with derive(DefaultNoBound)

* PR comment: Remove DeletedContract

* PR comment Add ring_buffer test

* remove missed comment

* misc comments

* contracts: add sr25519_recover

* Revert "contracts: add sr25519_recover"

This reverts commit d4600e00934b90e5882cf5288f36f98911b51722.

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts

* PR comments update print_schedule

* Update frame/contracts/src/benchmarking/mod.rs

* Update frame/contracts/src/storage.rs

* Update frame/contracts/src/storage.rs

* rm temporary fixes

* fix extra ;

* Update frame/contracts/src/storage.rs

Co-authored-by: default avatarjuangirini <[email protected]>

* Update frame/contracts/src/storage.rs

Co-authored-by: default avatarAlexander Theißen <[email protected]>

* Update frame/contracts/src/lib.rs

Co-authored-by: default avatarAlexander Theißen <[email protected]>

* Update frame/contracts/src/lib.rs

Co-authored-by: default avatarAlexander Theißen <[email protected]>

* Support stable rust for compiling the runtime (#13580)

* Support stable rust for compiling the runtime

This pull request brings support for compiling the runtime with stable Rust. This requires at least
rust 1.68.0 to work on stable. The code is written in a way that it is backwards compatible and
should automatically work when someone compiles with 1.68.0+ stable.

* We always support nightlies!

* 🤦



* Sort by version

* Review feedback

* Review feedback

* Fix version parsing

* Apply suggestions from code review

Co-authored-by: default avatarKoute <[email protected]>

---------

Co-authored-by: default avatarKoute <[email protected]>

* github PR commit fixes

* Revert "Support stable rust for compiling the runtime (#13580)"

This reverts commit 0b985aa5ad114a42003519b712d25a6acc40b0ad.

* Restore DeletionQueueMap

* fix namings

* PR comment

* move comments

* Update frame/contracts/src/storage.rs

* Update frame/contracts/src/storage.rs

* fixes

---------

Co-authored-by: command-bot <>
Co-authored-by: default avatarjuangirini <[email protected]>
Co-authored-by: default avatarAlexander Theißen <[email protected]>
Co-authored-by: default avatarBastian Köcher <[email protected]>
Co-authored-by: default avatarKoute <[email protected]>
      1bd5d2f7
  3. Mar 30, 2023
    • Javier Viola's avatar
      bump zombienet version (#13772) · 2f3a8b9e
      Javier Viola authored
      2f3a8b9e
    • Bastian Köcher's avatar
      sp-runtime-interface-test: Fix flaky test (#13770) · 5d5cc9a0
      Bastian Köcher authored
      5d5cc9a0
    • Kian Paimani's avatar
      Fix nomiantion pools doc render (#13748) · 95da8d7a
      Kian Paimani authored 
      Co-authored-by: parity-processbot <>
      95da8d7a
    • Adrian Catangiu's avatar
      BEEFY: gossip finality proofs (#13727) · 92c1229e
      Adrian Catangiu authored 
      * sc-consensus-beefy: add justifications to gossip protocol

* sc-consensus-beefy: voter gossips finality proofs

* sc-consensus-beefy: add finality proof gossip test

* sc-consensus-beefy: always gossip finality proof

Gossip finality proof in _both_ cases of reaching finality threshold
through votes:
1. threshold reached through self vote,
2. threshold reached through incoming vote.

* address comments
      92c1229e
    • Alexander Theißen's avatar
      Build wasm for mvp cpu (#13758) · 25a616ce
      Alexander Theißen authored
      25a616ce
    • Roman Useinov's avatar
      [Enhancement] Throw an error when there are too many pallets (#13763) · cc3152bc
      Roman Useinov authored 
      

* [Enhancement] Throw an error when there are too many pallets

* fix ui test

* fix PR comments

* Update frame/support/procedural/src/construct_runtime/mod.rs

Co-authored-by: default avatarBastian Köcher <[email protected]>

* Update frame/support/procedural/src/construct_runtime/mod.rs

Co-authored-by: default avatarBastian Köcher <[email protected]>

* ".git/.scripts/commands/fmt/fmt.sh"

---------

Co-authored-by: default avatarBastian Köcher <[email protected]>
Co-authored-by: command-bot <>
      cc3152bc
    • Aaro Altonen's avatar
      Attempt to relieve pressure on `mpsc_network_worker` (#13725) · 4240490d
      Aaro Altonen authored 
      * Attempt to relieve pressure on `mpsc_network_worker`

`SyncingEngine` interacting with `NetworkWorker` can put a lot of strain
on the channel if the number of inbound connections is high. This is
because `SyncingEngine` is notified of each inbound substream which it
then can either accept or reject and this causes a lot of message
exchange on the already busy channel.

Use a direct channel pair between `Protocol` and `SyncingEngine`
to exchange notification events. It is a temporary change to alleviate
the problems caused by syncing being an independent protocol and the
fix will be removed once `NotificationService` is implemented.

* Apply review comments

* fixes

* trigger ci

* Fix tests

Verify that both peers have a connection now that the validation goes
through `SyncingEngine`. Depending on how the tasks are scheduled,
one of them might not have the peer registered in `SyncingEngine` at which
point the test won't make any progress because block announcement received
from an unknown peer is discarded.

Move polling of `ChainSync` at the end of the function so that if a block
announcement causes a block request to be sent, that can be sent in the
same call to `SyncingEngine::poll()`.

---------

Co-authored-by: parity-processbot <>
      4240490d
    • Davide Galassi's avatar
      Application Crypto cleanup (#13746) · 7985495b
      Davide Galassi authored 
      

* Adjust application crypto docs

* Blanket implementation for 'RuntimeAppPublic' trait

* Blanket implementation for 'BoundToRuntimeAppPublic' for 'RuntimeAppPublic'

* Relax type bounds

* Docs fix

* restore MaybeHash

* Commit suggestion

Co-authored-by: default avatarAnton <[email protected]>

---------

Co-authored-by: default avatarAnton <[email protected]>
      7985495b
  5. Mar 29, 2023
  7. Mar 28, 2023
  9. Mar 27, 2023
  11. Mar 26, 2023
  13. Mar 25, 2023
  15. Mar 24, 2023