Skip to content
Snippets Groups Projects
Select Git revision
  • 7719
  • 7703
  • 7854
  • 7592
  • gh-readonly-queue/master/pr-7459-762f902397a585175a6dae26f021e52a20328138 protected
  • gh-readonly-queue/master/pr-5302-3a6c48943a60b30c41debc600d69ba384b3773b1 protected
  • master default protected
  • 7933
  • 7932
  • 7916
  • 7927
  • 7896
  • gh-readonly-queue/master/pr-7928-c7d7a3ef5e5d1f903bc1804835c344568e1ab7b9 protected
  • 7930
  • 7894
  • 7929
  • 7902
  • gh-readonly-queue/master/pr-7923-d5327157c882bb5482967fd703782b61da3db199 protected
  • 7867
  • gh-readonly-queue/master/pr-7924-363bd6bd5679594441499fce5916d3d47270865e protected
20 results
Search by author
  • Any Author
  • Aaro Altonen Aaro Altonen altonen
  • Administrator Administrator Admin0
  • Alexander Alexander alvicsam
  • Alexander Kalankhodzhaev Alexander Kalankhodzhaev kalaninja
  • Alexander Theißen Alexander Theißen athei
  • Alexandra Alexandra a13xndra
  • Alin Dima Alin Dima alindima
  • Andrew Jones Andrew Jones ascjones
  • André Silva André Silva andresilva
  • Anthony Lazam Anthony Lazam lazam
  • Anton Anton melekes
  • Anton Vilhelm Ásgeirsson Anton Vilhelm Ásgeirsson antonva
  • Arsham Teymouri Arsham Teymouri ArshamTeymouri
  • Artyom Bakhtin Artyom Bakhtin bakhtin
  • Bernardo A. Rodrigues Bernardo A. Rodrigues bernardoaraujor
  • Bradley Olson Bradley Olson BradleyOlson64
  • Branislav Kontur Branislav Kontur bkontur
  • Bulat Saifullin Bulat Saifullin BulatSaif
  • Chevdor Chevdor chevdor
  • Chris Kerr Chris Kerr piffle-rack
20 authors
  1. Nov 16, 2021
  3. Oct 14, 2021
  5. Oct 08, 2021
    • Bastian Köcher's avatar
      Disable log reloading by default (#9966) · f4b287c7
      Bastian Köcher authored 
      * Disable log reloading by default

This disables the log reloading that was enabled by default. The problem
is that the log reload implementation of `tracing` is using a lock to
make the layer replaceable. This lock needs to be locked every time we
need to check if a particular target is enabled (assuming the log level
is high enough). This kills the performance when for example
`sometarget=trace` logging is enabled.

* :face_palm:

* Remove unused parameter

* Fix test

* Fix
      f4b287c7
    • Bastian Köcher's avatar
      Use correct db path for parity-db (#9971) · d61d710b
      Bastian Köcher authored 
      This was overseen in: https://github.com/paritytech/substrate/pull/9500
      d61d710b
  7. Sep 12, 2021
    • Bastian Köcher's avatar
      Use tokio runtime handle instead of `TaskExecutor` abstraction (#9737) · c09d52ea
      Bastian Köcher authored 
      * Use tokio runtime handle instead of TaskExecutor abstraction

Before this pr we had the `TaskExecutor` abstraction which theoretically
allowed that any futures executor could have been used. However, this
was never tested and is currently not really required. Anyone running a
node currently only used tokio and nothing else (because this was hard
coded in CLI). So, this pr removes the `TaskExecutor` abstraction and
relies directly on the tokio runtime handle.

Besides this changes, this pr also makes sure that the http and ws rpc
server use the same tokio runtime. This fixes a panic that occurred when
you drop the rpc servers inside an async function (tokio doesn't like
that a tokio runtime is dropped in the async context of another tokio
runtime).

As we don't use any custom runtime in the http rpc server anymore, this
pr also removes the `rpc-http-threads` cli argument. If external parties
complain that there aren't enough threads for the rpc server, we could
bring support for increasing the thread count of the tokio runtime.

* FMT

* Fix try runtime

* Fix integration tests and some other optimizations

* Remove warnings
      c09d52ea
  9. Sep 07, 2021
    • Falco Hirschenberger's avatar
      Store the database in a role specific subdirectory (#9645) · 16144e74
      Falco Hirschenberger authored 
      * Store the database in a role specific subdirectory

This is a cleaned up version of #8658 fixing #6880

polkadot companion: paritytech/polkadot#2923

* Disable prometheus in tests

* Also change p2p port

* Fix migration logic

* Use different identification file for rocks and parity db

Add tests for paritydb migration
      16144e74
  11. Aug 17, 2021
    • David's avatar
      Remove substrate-in-the-browser (#9541) · 2de7e51c
      David authored 
      * Comment out browser stuff

* Remove browser stuff

* Remove more wasm transport code

* Remove ExtTransport and rework how telemetry initialises.

* Change (most) wasm-timer using code to use std::time

* Rename CI-job

* Aura does not compile for wasm

* Remove testing in the browser on CI

* Update README

* Leave `StreamSink` be

* fmt
      2de7e51c
  13. Aug 09, 2021
    • Marek Kotewicz's avatar
      DatabaseSource::Auto (#9500) · a2f75241
      Marek Kotewicz authored 
      * implement "auto" database backend in client/db, in progress, #9201

* move fn supports_ref_counting from DatabaseSource enum to Database trait to make it work correctly for all types of dbs

* update kvdb_rocksdb to 0.13 and use it's new config feature  to properly auto start existing database

* tests for auto database reopening

* introduce OpenDbError to cleanup opening database error handling and handle case when database is not enabled at the compile time

* cargo fmt strings again

* cargo fmt strings again

* rename DataSettingsSrc to fix test compilation

* fix the call to the new kvdb-rocksdb interdace in tests to fix compilation

* simplify OpenDbError and make it compile even when paritydb and rocksdb are disabled

* cargo fmt

* fix compilation without flag with-parity-db

* fix unused var compilation warning

* support different paths for rocksdb and paritydb in DatabaseSouce::Auto

* support "auto" database option in substrate cli

* enable Lz4 compression for ...
      a2f75241
  15. Jul 21, 2021
  17. Jun 17, 2021
  19. Jun 08, 2021
  21. Apr 14, 2021
  23. Mar 11, 2021
  25. Feb 17, 2021
    • Cecile Tonglet's avatar
      Fix telemetry span not entering properly attempt 3 (#8043) · 27274c42
      Cecile Tonglet authored 
      
* Fix tracing tests (#8022)

* Fix tracing tests

The tests were not working properly.

1. Some test was setting a global subscriber, this could lead to racy
conditions with other tests.

2. A logging test called `process::exit` which is completly wrong.

* Update client/tracing/src/lib.rs

Co-authored-by: default avatarDavid <dvdplm@gmail.com>

* Review comments

Co-authored-by: default avatarDavid <dvdplm@gmail.com>

* Fix tracing spans are not being forwarded to spawned task (#8009)

* Fix tracing spans are not being forwarded to spawned task

There is a bug that tracing spans are not forwarded to spawned task. The
problem was that only the telemetry span was forwarded. The solution to
this is to use the tracing provided `in_current_span` to capture the
current active span and pass the telemetry span explictely. We will now
always enter the span when the future is polled. This is essentially the
same strategy as tracing is doing with its `Instrumented`, but now
extended for our use case with having multiple spans active.

* More tests

* Proper test for telemetry and prefix span

* WIP

* Fix test (need to create & enter the span at the same time)

* WIP

* Remove telemtry_span from sc_service config

* CLEANUP

* Update comment

* Incorrect indent

* More meaningful name

* Dedent

* Naming XD

* Attempt to make a more complete test

* lint

* Missing licenses

* Remove user data

* CLEANUP

* Apply suggestions from code review

Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>

* CLEANUP

* Apply suggestion

* Update bin/node/cli/tests/telemetry.rs

Co-authored-by: default avatarDavid <dvdplm@gmail.com>

* Wrapping lines

Co-authored-by: default avatarBastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: default avatarDavid <dvdplm@gmail.com>
      27274c42
  27. Feb 15, 2021
  29. Jan 29, 2021
  31. Jan 20, 2021
  33. Jan 14, 2021
  35. Jan 04, 2021
    • Bastian Köcher's avatar
      Happy new year (#7814) · e3e651f7
      Bastian Köcher authored 
      * Happy new year

Updates the copyright years and fixes wrong license headers.

* Fix the template

* Split HEADER into HEADER-APACHE & HEADER-GPL
      e3e651f7
  37. Dec 29, 2020
  39. Dec 28, 2020
    • Bastian Köcher's avatar
      Fix base-path handling in `key insert` (#7775) · 05ae24d9
      Bastian Köcher authored 
      This fixes the handling of base-path when using `key insert`. Before
the base-path wasn't setup correctly, as done when starting a node. This
resulted in putting the keys into the wrong directory. This pr fixes
this by creating the correct base-path/config dir for the keystore.
Besides that it also removes the insert command from `subkey` as it
doesn't make that much sense. If requested, we could bring it back later.
      05ae24d9
  41. Dec 10, 2020
  43. Dec 09, 2020
    • Benjamin Kampmann's avatar
      Expand remote keystore interface to allow for hybrid mode (#7628) · 5ce8c333
      Benjamin Kampmann authored 
      * update to latest master

* updates on docs, license, meta

* hide ssrs behind feature flag

* implement remaining functions on the server

* sign server line length fix

* fix tests

* fixup in-memory-keystore

* adding failsafe

* skipping ecdsa test for now

* remote keystore param

* remote sign urls made available

* integrating keystore remotes features

* don't forget the dependency

* remove old cruft

* reset local keystore

* applying suggestions

* Switch to single remote, minor grumbles

* minor grumbles, docs
      5ce8c333
  45. Dec 03, 2020
  47. Oct 26, 2020
  49. Sep 17, 2020
    • Wei Tang's avatar
      Use tracing-based subscriber logging (#6825) · 9fdd4672
      Wei Tang authored 
      
* init_logger: switch from log-based to tracing-based and add compatibility layer

* Move tracing profiling subscriber related config realization

* sp-tracing: change profiling to be a layer instead of a subscriber

* Enable profiling layer in cli

* Change all test env_logger init to sp_tracing::try_init_simple

* Remove all local env_logger dependency

* Add missing tracing-subscriber dependency

* frame-sudo: fix tests

* frame-support: fix tests

* Fix frame/pallet and executor tests

* Fix the remaining tests

* Use subscriber's try_init as recommended by @davidbarsky

* Be explict that the tracing-log feature is needed

* Set subscriber writer to stderr

* Shorter line width

* Update cargo lock tracing version

* Fix sc_tracing crate compile

* Fix sc_authority_discovery crate test

* unremove default-features

* Leave enabled to default true

* Warn if global default cannot be set

* Fix unused import

* Remove unused PROXY_TARGET

* Change all reference from rc5 to rc6

* Change all reference of rc2 to rc6

* Fix styling

* Fix typo

* make logger init error'ing

* re-fixing the test issue

Co-authored-by: default avatarBenjamin Kampmann <ben@parity.io>
      9fdd4672
  51. Sep 11, 2020
  53. Aug 31, 2020
    • Max Inden's avatar
      client/cli/src/config: Warn on low file descriptor limit (#6956) · 875daa31
      Max Inden authored 
      * client/cli/src/config: Warn on low file descriptor limit

Substrate sets the soft file descriptor limit to the hard limit at
startup. In the case of the latter being low already (< 10_000) a
Substrate node under high demand might run into issues e.g. when opening
up new TCP connections or persisting data to the database.

With this commit a warn message is printed to stderr.

* client/cli/Cargo.toml: Update to fdlimit 0.2.0
      875daa31
  55. Aug 19, 2020
    • Bastian Köcher's avatar
      Combine default values used at initialization in a trait (#6857) · 7bf838f2
      Bastian Köcher authored 
      This moves default values used in the Substrate code base when
initializing a service into a common trait. Currently this trait only
contains listen ports, but this could be extended in the future.
Essentially this will make overriding these values much easier for
Cumulus, where we have 2 nodes running in one binary.
      7bf838f2
  57. Jul 21, 2020
  59. Jul 10, 2020
  61. Jul 09, 2020
  63. Jul 08, 2020
  65. Jul 02, 2020
    • pscott's avatar
      Update SubstrateCli to return String (#6550) · 540ae1c1
      pscott authored 
      
* Update SubstrateCli to return String

* Add default implementation for executable_name()

* Use display instead of PathBuf

* Get file_name in default impl of executable_name

* Remove String::from and use .into()

* Use default impl for executable_name()

* Use .as_str() and remove useless .to_string()

* Update only sp-io when running companion build

* Remove unneeded update of sp-io in CI

Co-authored-by: default avatarCecile Tonglet <cecile@parity.io>
      540ae1c1
  67. Jun 26, 2020
  69. Jun 23, 2020
  71. Jun 16, 2020
    • Demi Obenour's avatar
      Add IPC support (#6348) · e2f5e4bd
      Demi Obenour authored 
      This is useful for both security and performance reasons. IPC is faster
than TCP, and it is subject to OS access controls.
      e2f5e4bd
  73. Jun 12, 2020
    • André Silva's avatar
      client: use appropriate ExecutionContext for initial sync / regular import (#6180) · 2b59d57c
      André Silva authored 
      * client: use appropriate ExecutionContext for sync/import

* client: remove dead code

* client: ExecutionContext: distinguish between own and foreign imports

* client: fix cli parameter doc

* Revert "client: ExecutionContext: distinguish between own and foreign imports"

This reverts commit 0fac11520704c364a82432c5b927e987ba043cdb.

* primitives: add docs for ExecutionContext

* cli: execution strategy docs

* cli: use different execution context for importing block on validator

* cli: remove defaults from execution context flags
      2b59d57c