RPC to allow setting the log filter (#7474)
* Add filter reload handle * add RPC, move logging module from cli to tracing * remove dup fn * working example * Update client/rpc-api/src/system/mod.rs Co-authored-by:Pierre Krieger <pierre.krieger1708@gmail.com> * Prefer "set" to "reload" * Re-enable the commented out features of the logger * Remove duplicate code * cleanup * unneeded lvar * Bump to latest patch release * Add new CLI option to disable log filter reloading, Move profiling CLI options to SharedParams * Apply suggestions from code review Co-authored-by:
Bastian Köcher <bkchr@users.noreply.github.com> * Applied suggestions from reviews * Fix calls to init_logger() * Handle errors when parsing logging directives * Deny `system_setLogFilter` RPC by default * One more time * Don't ignore parse errors for log directives set via CLI or RPC * Improve docs * Apply suggestions from code review Co-authored-by:
Bastian Köcher <bkchr@users.noreply.github.com> * Update client/cli/src/config.rs Co-authored-by:
Bastian Köcher <bkchr@users.noreply.github.com> * fix merge errors * include default directives with system_setLogFilter RPC, implement system_rawSetLogFilter RPC to exclude defaults * docs etc... * update test * refactor: rename fn * Add a test for system_set_log_filter – NOTE: the code should likely change to return an error when bad directives are passed * Update client/cli/src/lib.rs Co-authored-by:
Bastian Köcher <bkchr@users.noreply.github.com> * Address review grumbles * Add doc note on panicking behaviour * print all invalid directives before panic * change RPCs to: addLogFilter and resetLogFilter * make CLI log directives default * add comments * restore previous behaviour to panic when hard-coded directives are invalid * change/refactor directive parsing * fix line width * add test for log filter reloading * Apply suggestions from code review Co-authored-by:
Bastian Köcher <bkchr@users.noreply.github.com> * finish up suggestions from code review * improve test * change expect message * change fn name * Apply suggestions from code review Co-authored-by:
Bastian Köcher <bkchr@users.noreply.github.com> * Apply suggestions from code review Co-authored-by:
Bastian Köcher <bkchr@users.noreply.github.com> * add docs, remove unused fn * propagate Err on invalid log directive * Update tracing-subscriber version * Improve docs for `disable_log_reloading` CLI param Co-authored-by:
Matt <mattrutherford@users.noreply.github.com> Co-authored-by:
David <dvdplm@gmail.com> Co-authored-by:
Pierre Krieger <pierre.krieger1708@gmail.com> Co-authored-by:
Bastian Köcher <bkchr@users.noreply.github.com>
parent
f717a204
Showing
- substrate/Cargo.lock 7 additions, 1 deletionsubstrate/Cargo.lock
- substrate/client/cli/Cargo.toml 2 additions, 3 deletionssubstrate/client/cli/Cargo.toml
- substrate/client/cli/src/config.rs 17 additions, 11 deletionssubstrate/client/cli/src/config.rs
- substrate/client/cli/src/lib.rs 69 additions, 41 deletionssubstrate/client/cli/src/lib.rs
- substrate/client/cli/src/params/import_params.rs 1 addition, 24 deletionssubstrate/client/cli/src/params/import_params.rs
- substrate/client/cli/src/params/shared_params.rs 38 additions, 0 deletionssubstrate/client/cli/src/params/shared_params.rs
- substrate/client/executor/Cargo.toml 1 addition, 1 deletionsubstrate/client/executor/Cargo.toml
- substrate/client/rpc-api/src/system/mod.rs 14 additions, 0 deletionssubstrate/client/rpc-api/src/system/mod.rs
- substrate/client/rpc/Cargo.toml 2 additions, 0 deletionssubstrate/client/rpc/Cargo.toml
- substrate/client/rpc/src/system/mod.rs 11 additions, 0 deletionssubstrate/client/rpc/src/system/mod.rs
- substrate/client/rpc/src/system/tests.rs 82 additions, 1 deletionsubstrate/client/rpc/src/system/tests.rs
- substrate/client/service/src/config.rs 2 additions, 0 deletionssubstrate/client/service/src/config.rs
- substrate/client/service/test/src/lib.rs 1 addition, 0 deletionssubstrate/client/service/test/src/lib.rs
- substrate/client/tracing/Cargo.toml 6 additions, 1 deletionsubstrate/client/tracing/Cargo.toml
- substrate/client/tracing/src/lib.rs 103 additions, 6 deletionssubstrate/client/tracing/src/lib.rs
- substrate/client/tracing/src/logging.rs 7 additions, 7 deletionssubstrate/client/tracing/src/logging.rs
- substrate/primitives/tracing/Cargo.toml 1 addition, 1 deletionsubstrate/primitives/tracing/Cargo.toml
- substrate/utils/browser/src/lib.rs 1 addition, 0 deletionssubstrate/utils/browser/src/lib.rs
Please register or sign in to comment