Skip to content
  1. Apr 06, 2023
    • Liam Aharon's avatar
      Fix `try-runtime follow-chain`, try-runtime upgrade tuple tests, cli test utils (#13794) · 0b3444c5
      Liam Aharon authored 
      

* new test for try-runtime tuple stuff

* fix

* remove development comment

* formatting

* remove todo comment

* follow-chain working test

* refactor common cli testing utils

* fix comment

* revert Cargo.lock changes

* update Cargo.lock

* improve doc comment

* fix error typo

* update Cargo.lock

* feature gate try-runtime test

* build_substrate cli test util

* feature gate follow_chain tests

* move fn start_node to test-utils

* improve test pkg name

* use tokio Child and Command

* remove redundant import

* fix ci

* fix ci

* don't leave hanging processes

* improved child process cleanup

* use existing KillChildOnDrop

* remove redundant comment

* Update test-utils/cli/src/lib.rs

Co-authored-by: default avatarKoute <[email protected]>

---------

Co-authored-by: default avatarkianenigma <[email protected]>
Co-authored-by: default avatarKoute <[email protected]>
      0b3444c5
    • Keith Yeung's avatar
      Add HoldReason to the NIS pallet (#13823) · 38f3b053
      Keith Yeung authored 
      * Add HoldReason to the NIS pallet

* Rename composable_enum to composite_enum

* Add encoding test

* Add more doc comments
      38f3b053
  3. Apr 05, 2023
  5. Apr 04, 2023
  7. Mar 30, 2023
  9. Mar 22, 2023
  11. Mar 21, 2023
  13. Mar 20, 2023
  15. Mar 18, 2023
    • Gavin Wood's avatar
      Deprecate `Currency`; introduce holds and freezing into `fungible` traits (#12951) · 5d81f23f
      Gavin Wood authored 
      

* First reworking of fungibles API

* New API and docs

* More fungible::* API improvements

* New ref-counting logic for old API

* Missing files

* Fixes

* Use the new transfer logic

* Use fungibles for the dispatchables

* Use shelve/restore names

* Locking works with total balance.

* repotting and removal

* Separate Holds from Reserves

* Introduce freezes

* Missing files

* Tests for freezing

* Fix hold+freeze combo

* More tests

* Fee-free dispatchable for upgrading accounts

* Benchmarks and a few fixes

* Another test

* Docs and refactor to avoid blanket impls

* Repot

* Fit out ItemOf fully

* Add events to Balanced traits

* Introduced events into Hold traits

* Fix Assets pallet tests

* Assets benchmarks pass

* Missing files and fixes

* Fixes

* Fixes

* Benchmarks fixes

* Fix balance benchmarks

* Formatting

* Expose fungible sub modules

* Move NIS to fungible API

* Fix broken impl and add test

* Fix tests

* API for `transfer_and_hold`

* Use composite APIs

* Formatting

* Upgraded event

* Fixes

* Fixes

* Fixes

* Fixes

* Repot tests and some fixed

* Fix some bits

* Fix dust tests

* Rename `set_balance`

- `Balances::set_balance` becomes `Balances::force_set_balance`
- `Unbalanced::set_balance` becomes `Unbalances::write_balance`

* becomes

* Move dust handling to fungibles API

* Formatting

* Fixes and more refactoring

* Fixes

* Fixes

* Fixes

* Fixes

* Fixes

* Fixes

* Fixes

* Fixes

* Fixes

* Use reducible_balance for better correctness on fees

* Reducing hold to zero should remove entry.

* Add test

* Docs

* Update frame/support/src/traits/tokens/fungibles/hold.rs

Co-authored-by: default avatarMuharem Ismailov <[email protected]>

* Update frame/support/src/traits/tokens/fungibles/regular.rs

Co-authored-by: default avatarMuharem Ismailov <[email protected]>

* Update frame/support/src/traits/tokens/fungible/hold.rs

Co-authored-by: default avatarMuharem Ismailov <[email protected]>

* Update frame/support/src/traits/tokens/fungible/regular.rs

Co-authored-by: default avatarMuharem Ismailov <[email protected]>

* Docs

* Docs

* Docs

* Fix NIS benchmarks

* Doc comment

* Remove post_mutation

* Fix some tests

* Fix some grumbles

* Enumify bool args to fungible(s) functions

* Fix up assets and balances

* Formatting

* Fix contracts

* Fix tests & benchmarks build

* Typify minted boolean arg

* Typify on_hold boolean arg; renames

* Fix numerous tests

* Fix dependency issue

* Privatize dangerous API mutate_account

* Fix contracts (@alext - please check this commit)

* Remove println

* Fix tests for contracts

* Fix broken rename

* Fix broken rename

* Fix broken rename

* Docs

* Update frame/support/src/traits/tokens/fungible/hold.rs

Co-authored-by: default avatarAnthony Alaribe <[email protected]>

* remove from_ref_time

* Update frame/executive/src/lib.rs

Co-authored-by: default avatarAnthony Alaribe <[email protected]>

* Update frame/executive/src/lib.rs

Co-authored-by: default avatarAnthony Alaribe <[email protected]>

* Reenable test

* Update frame/support/src/traits/tokens/fungibles/hold.rs

Co-authored-by: default avatarAnthony Alaribe <[email protected]>

* Update frame/support/src/traits/tokens/fungible/hold.rs

Co-authored-by: default avatarAnthony Alaribe <[email protected]>

* Update frame/support/src/traits/tokens/fungible/hold.rs

Co-authored-by: default avatarAnthony Alaribe <[email protected]>

* Update frame/support/src/traits/tokens/fungible/hold.rs

Co-authored-by: default avatarAnthony Alaribe <[email protected]>

* Update frame/support/src/traits/tokens/currency.rs

Co-authored-by: default avatarAnthony Alaribe <[email protected]>

* Update frame/lottery/src/tests.rs

Co-authored-by: default avatarAnthony Alaribe <[email protected]>

* Update frame/support/src/traits/tokens/fungible/mod.rs

Co-authored-by: default avatarAnthony Alaribe <[email protected]>

* Update frame/support/src/traits/tokens/fungible/regular.rs

Co-authored-by: default avatarAnthony Alaribe <[email protected]>

* Update frame/support/src/traits/tokens/fungibles/freeze.rs

Co-authored-by: default avatarAnthony Alaribe <[email protected]>

* Update frame/support/src/traits/tokens/fungible/regular.rs

Co-authored-by: default avatarAnthony Alaribe <[email protected]>

* Update frame/support/src/traits/tokens/fungibles/hold.rs

Co-authored-by: default avatarAnthony Alaribe <[email protected]>

* Update frame/support/src/traits/tokens/fungibles/hold.rs

Co-authored-by: default avatarAnthony Alaribe <[email protected]>

* Update frame/support/src/traits/tokens/fungibles/hold.rs

Co-authored-by: default avatarAnthony Alaribe <[email protected]>

* Rename UnwantedRemoval to UnwantedAccountRemoval

* Docs

* Formatting

* Update frame/balances/src/lib.rs

Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>

* Update primitives/runtime/src/lib.rs

Co-authored-by: default avatarKeith Yeung <[email protected]>

* handle_raw_dust oes nothing

* Formatting

* Fixes

* Grumble

* Fixes

* Add test

* Add test

* Tests for reducible_balance

* Fixes

* Fix Salary

* Fixes

* Disable broken test

* Disable nicely

* Fixes

* Fixes

* Fixes

* Rename some events

* Fix nomination pools breakage

* Add compatibility stub for transfer tx

* Reinstate a safely compatible version of Balances set_balance

* Fixes

* Grumble

* Update frame/nis/src/lib.rs

Co-authored-by: default avatarKian Paimani <[email protected]>

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_balances

* disable flakey tests

* Update frame/balances/src/lib.rs

Co-authored-by: default avatarKian Paimani <[email protected]>

* Grumbles

* Grumble

---------

Co-authored-by: default avatarMuharem Ismailov <[email protected]>
Co-authored-by: default avatarAlexander Theißen <[email protected]>
Co-authored-by: default avatarAnthony Alaribe <[email protected]>
Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
Co-authored-by: default avatarKeith Yeung <[email protected]>
Co-authored-by: default avatarKian Paimani <[email protected]>
Co-authored-by: command-bot <>
      5d81f23f
  17. Mar 16, 2023
  19. Mar 15, 2023
  21. Mar 13, 2023
    • Alexandru Vasile's avatar
      Metadata V15: Expose pallet documentation (#13452) · 4cbf855e
      Alexandru Vasile authored 
      

* frame/proc: Helpers to parse pallet documentation attributes

Signed-off-by: default avatarAlexandru Vasile <[email protected]>

* frame/proc: Expand pallet with runtime metadata documentation

Signed-off-by: default avatarAlexandru Vasile <[email protected]>

* frame/dispatch: Implement doc function getter for dispatch

Signed-off-by: default avatarAlexandru Vasile <[email protected]>

* frame/tests: Check exposed runtime metadata documentation

Signed-off-by: default avatarAlexandru Vasile <[email protected]>

* frame/tests: Add UI tests for `pallet_doc` attribute

Signed-off-by: default avatarAlexandru Vasile <[email protected]>

* frame/proc: Document pallet_doc attribute

Signed-off-by: default avatarAlexandru Vasile <[email protected]>

* frame/support: Use `derive_syn_parse`

Signed-off-by: default avatarAlexandru Vasile <[email protected]>

* Update frame/support/procedural/src/lib.rs

Co-authored-by: default avatarNiklas Adolfsson <[email protected]>

* frame/support: Improve documentation

Signed-off-by: default avatarAlexandru Vasile <[email protected]>

---------

Signed-off-by: default avatarAlexandru Vasile <[email protected]>
Co-authored-by: parity-processbot <>
Co-authored-by: default avatarNiklas Adolfsson <[email protected]>
      4cbf855e
    • Vivek Pandya's avatar
      Remove use of trait Store from all pallets and deprecate it. (#13535) · 2009821c
      Vivek Pandya authored 
      * Remove use of trait Store from staking pallet

* Remove use of trait Store from bounties pallet

* Remove use of trait Store from collective pallet

* Remove use of trait Store from babe pallet

* Remove use of trait Store from assets pallet

* Remove use of trait Store from grandpa pallet

* Remove use of trait Store from balances pallet

* Remove use of trait Store from authorship pallet

* Remove use of trait Store from authority-discovery pallet

* Remove use of trait Store from atomic-swap pallet

* Remove use of trait Store from sudo pallet

* Remove use of trait Store from scheduler pallet

* Remove use of trait Store from scored-pool pallet

* Remove use of trait Store from society pallet

* Remove use of trait Store from lottery pallet

* Remove use of trait Store from executive pallet

* Remove use of trait Store from democracy pallet

* Remove use of trait Store from elections-phragmen pallet

* Remove use of trait Store from indices pallet

* Remove use of trait Store from identity pallet

* Remove use of trait Store from multisig pallet

* Remove use of trait Store from merkle-mountain-range pallet

* Remove use of trait Store from im-online pallet

* Remove use of trait Store from membership pallet

* Remove use of trait Store from nicks pallet

* Remove use of trait Store from session pallet

* Remove use of trait Store from transaction-payment pallet

* Remove use of trait Store from utility pallet

* Remove use of trait Store from child-bounties pallet

* Remove use of trait Store from nis pallet

* Remove use of trait Store from nfts pallet

* Remove use of trait Store from conviction-voting pallet

* Remove use of trait Store from treasury pallet

* Remove use of trait Store from vesting pallet

* Remove use of trait Store from preimage pallet

* Remove use of trait Store from uniques pallet

* Remove use of trait Store from ranked-collective pallet

* Remove use of trait Store from beefy-mmr pallet

* Remove use of trait Store from referenda pallet

* Remove use of trait Store from whitelist pallet

* Remove use of trait Store from alliance pallet

* Remove use of trait Store from nomination-pools pallet

* Remove use of trait Store from state-trie-migration pallet

* Remove use of trait Store from message-queue pallet

* Remove use of trait Store from root-offences pallet

* Remove use of trait Store from root-testing pallet

* Remove use of trait Store from timestamps pallet

* Remove use of trait Store from system pallet

* Remove use of trait Store from offences pallet

* Remove use of trait Store from recovery pallet

* Remove use of trait Store from node-authorization pallet

* Remove use of trait Store from proxy pallet

* Remove use of trait Store from benchmarking pallet

* Remove use of trait Store from bags-list pallet

* Add deprecated warning in store_trait

* Change warning message

* Run cargo fmt

* Fix warning and update tests

* Remove unnecessary allow deprecated

* Remove use of trait Store

* Fix mismatch in expected output

* Minor update to warning message for deprecation of generate_store with Store trait attribute

* Fixes as per review comments

* Fixes as per review suggestions

* Remove use of Store trait from core-fellowship pallet

* Fix type in store_trait.rs

* Fixes as pre review comment
      2009821c
  23. Mar 10, 2023
  25. Mar 09, 2023
  27. Mar 07, 2023
    • afm's avatar
      Pub enum runtime to pub struct runtime (#13250) · d86a3263
      afm authored 
      

* pub enum Runtime -> pub struct Runtime

* changing some more

* fmt

* updating *.stderr files

* re-run trybuild after rust update

* keep a test file for `pub enum Runtime`

* Delete construct_runtime_2.rs

* ".git/.scripts/commands/fmt/fmt.sh"

---------

Co-authored-by: default avatarBastian Köcher <[email protected]>
Co-authored-by: parity-processbot <>
      d86a3263
  29. Mar 03, 2023
  31. Mar 02, 2023
  33. Feb 28, 2023
  35. Feb 27, 2023
    • Bastian Köcher's avatar
      `pallet-treasury`: Ensure we respect `max_amount` for spend across batch calls (#13468) · 6aa4127a
      Bastian Köcher authored 
      * `pallet-treasury`: Ensure we respect `max_amount` for spend across batch calls

When calling `spend` the origin defines the `max_amount` of tokens it is allowed to spend. The
problem is that someone can send a `batch(spend, spend)` to circumvent this restriction as we don't
check across different calls that the `max_amount` is respected. This pull request fixes this
behavior by introducing a so-called dispatch context. This dispatch context is created once per
outer most `dispatch` call. For more information see the docs in this pr. The treasury then uses
this dispatch context to attach information about already spent funds per `max_amount` (we assume
that each origin has a different `max_amount` configured). So, a `batch(spend, spend)` is now
checked to stay inside the allowed spending bounds.

Fixes: https://github.com/paritytech/substrate/issues/13167

* Import `Box` for wasm

* FMT
      6aa4127a
  37. Feb 25, 2023
  39. Feb 23, 2023
  41. Feb 22, 2023
    • Sam Johnson's avatar
      generation of real benchmark functions for benchmarking v2 (#13224) · 55ff791d
      Sam Johnson authored 
      

* function generation with _name working, need to modify signature

* WIP

* support custom BenchmarkResult<T> type

* full support for BenchmarkResult<T> on benchmark function defs

* support () return type for benchmark function defs that don't use ?

* uncomment

* fix where clause handling

* fix benchmark function call bodies

* proper parsing of return type

* add UI tests for bad return type

* fix detection of missing last_stmt with defined return type

* UI tests covering missing last_stmt

* properly detect and complain about empty benchmark function defs

* fix missing Comma in Result<T, BenchmarkError> parsing + test

* add additional UI test

* allow complex path for BenchmarkResult and BenchmarkError in fn defs

* add UI tests covering complex path for BenchmarkResult, BenchmarkError

* retain doc comments and attributes

* also add attributes to struct

* add docs for benchmark function definition support

* fix imports on benchmark example

* fix issue with unused variables in extrinsic call fn def

* fix up docs

* remove support for v2::BenchmarkResult because it was confusing

* fix typo

* remove ability to use custom T for Result<T, BenchmarkError> in v2

* use missing call error instead of empty_fn()

* remove unneeded match statement

* Add a proper QED

Co-authored-by: default avatarKeith Yeung <[email protected]>

* fix other QED

Co-authored-by: default avatarKeith Yeung <[email protected]>

* cargo fmt

* add an explicit error for non TypePath as return type

* tweak error warning and add a UI test for non TypePath return

* remove comment

* add docs about T and I generic params

* improve docs referring to section "below"

* pull out return type checking logic into its own function

* pull out params parsing into its own function

* pull out call_def parsing into its own function

* add doc comment for missing_call()

* replace spaces with tabs

* add a result-based example to the benchmarking examples

---------

Co-authored-by: default avatarKeith Yeung <[email protected]>
      55ff791d
  43. Feb 21, 2023
  45. Feb 13, 2023
  47. Feb 09, 2023
  49. Feb 08, 2023
  51. Feb 02, 2023
  53. Feb 01, 2023
  55. Jan 27, 2023