Skip to content
Snippets Groups Projects
  1. May 28, 2024
    • Przemek Rzad's avatar
      Remove workspace lints from templates (#4598) · 09f07d54
      Przemek Rzad authored
      This detaches the templates from monorepo's workspace lints, so the
      lints for the templates can evolve separately as needed.
      
      Currently the templates [re-use the monorepo's
      lints](https://github.com/paritytech/polkadot-sdk-minimal-template/blob/bd8afe66ec566d61f36b0e3d731145741a9e9e19/Cargo.toml#L16-L43)
      which looks weird.
      
      cc @Kianenigma @gupnik
  2. May 27, 2024
    • Michal Kucharczyk's avatar
      `sc-chain-spec`: deprecated code removed (#4410) · 2d3a6932
      Michal Kucharczyk authored
      This PR removes deprecated code:
      - The `RuntimeGenesisConfig` generic type parameter in
      `GenericChainSpec` struct.
      - `ChainSpec::from_genesis` method allowing to create chain-spec using
      closure providing runtime genesis struct
      - `GenesisSource::Factory` variant together with no longer needed
      `GenesisSource`'s generic parameter `G` (which was intended to be a
      runtime genesis struct).
      
      
      https://github.com/paritytech/polkadot-sdk/blob/17b56fae/substrate/client/chain-spec/src/chain_spec.rs#L559-L563
    • Andrei Eres's avatar
      [subsystem-benchmarks] Add statement-distribution benchmarks (#3863) · a7097681
      Andrei Eres authored
      Fixes https://github.com/paritytech/polkadot-sdk/issues/3748
      
      Adds a subsystem benchmark for statements-distribution subsystem.
      
      Results in CI (reference hw):
      ```
      $ cargo bench -p polkadot-statement-distribution --bench statement-distribution-regression-bench --features subsystem-benchmarks
      
      [Sent to peers] standart_deviation 0.07%
      [Received from peers] standart_deviation 0.00%
      [statement-distribution] standart_deviation 0.97%
      [test-environment] standart_deviation 1.03%
      
      Network usage, KiB                     total   per block
      Received from peers                1088.0000    108.8000
      Sent to peers                      1238.1800    123.8180
      
      CPU usage, seconds                     total   per block
      statement-distribution                0.3897      0.0390
      test-environment                      0.4715      0.0472
      ```
    • Sebastian Kunert's avatar
      check-weight: Disable total pov size check for mandatory extrinsics (#4571) · 70dd67a5
      Sebastian Kunert authored
      So in some pallets we like
      [here](https://github.com/paritytech/polkadot-sdk/blob/5dc522d0/substrate/frame/session/src/lib.rs#L556)
      we use `max_block` as return value for `on_initialize` (ideally we would
      not).
      
      This means the block is already full when we try to apply the inherents,
      which lead to the error seen in #4559 because we are unable to include
      the required inherents. This was not erroring before #4326 because we
      were running into this branch:
      
      https://github.com/paritytech/polkadot-sdk/blob/e4b89cc5/substrate/frame/system/src/extensions/check_weight.rs#L222-L224
      
      The inherents are of `DispatchClass::Mandatory` and therefore have a
      `reserved` value of `None` in all runtimes I have inspected. So they
      will always pass the normal check.
      
      So in this PR I adjust the `check_combined_proof_size` to return an
      early `Ok(())` for mandatory extrinsics.
      
      If we agree on this PR I will backport it to the 1.12.0 branch.
      
      closes #4559
      
      ---------
      
      Co-authored-by: command-bot <>
    • Michal Kucharczyk's avatar
      chain-spec-builder: help updated (#4597) · 16887b6f
      Michal Kucharczyk authored
      Added some clarification on output file.
    • Alexandru Vasile's avatar
      network: Update litep2p to v0.5.0 (#4570) · ce3e9b7c
      Alexandru Vasile authored
      
      ## [0.5.0] - 2023-05-24
      
      This is a small patch release that makes the `FindNode` command a bit
      more robst:
      
      - The `FindNode` command now retains the K (replication factor) best
      results.
      - The `FindNode` command has been updated to handle errors and
      unexpected states without panicking.
      
      ### Changed
      
      - kad: Refactor FindNode query, keep K best results and add tests
      ([#114](https://github.com/paritytech/litep2p/pull/114))
      
      ---------
      
      Signed-off-by: default avatarAlexandru Vasile <alexandru.vasile@parity.io>
    • Sebastian Kunert's avatar
      Make markdown lint CI job pass (#4593) · 23529827
      Sebastian Kunert authored
      Was constantly failing, so here a fix.
    • Przemek Rzad's avatar
      Add release version to commits and branch names of template synchronization job (#4353) · e0edb062
      Przemek Rzad authored
      Just to have some information what is the release number that was used
      to push a particular commit or PR in the templates repositories.
    • omahs's avatar
      chore: fix typos (#4590) · 89b67bc6
      omahs authored
      chore: fix typos
    • Svyatoslav Nikolsky's avatar
      Bridge: add subcommand to relay messages delivery confirmation (#4453) · 0a752afa
      Svyatoslav Nikolsky authored
      related to
      https://github.com/paritytech/parity-bridges-common/issues/2962
      on top of #4383
      
      Example:
      ```sh
      RUST_LOG=runtime=trace,rpc=trace,bridge=trace \
              ./target/release/substrate-relay relay-messages-delivery-confirmation bridge-hub-rococo-to-bridge-hub-westend \
              --source-host localhost \
              --source-port 8943 \
              --source-version-mode Auto \
              --source-signer //Eve \
              --source-transactions-mortality 4 \
              --target-host localhost \
              --target-port 8945 \
              --target-version-mode Auto \
              --lane 00000002 \
              --at-target-block 49
      ```
    • Svyatoslav Nikolsky's avatar
      Bridge: check submit_finality_proof limits before submission (#4549) · f6cca7ee
      Svyatoslav Nikolsky authored
      closes https://github.com/paritytech/parity-bridges-common/issues/2982
      closes https://github.com/paritytech/parity-bridges-common/issues/2730
      
      The main change is in the
      bridges/relays/lib-substrate-relay/src/finality/target.rs, changes in
      other files are just moving the code
      
      ~I haven't been able to run zn tests locally - don't know why, but it
      keeps failing for me locally with: `
      Error running script:
      /home/svyatonik/dev/polkadot-sdk/bridges/testing/framework/js-helpers/wait-hrmp-channel-opened.js
      Error: Timeout(300), "custom-js
      /home/svyatonik/dev/polkadot-sdk/bridges/testing/framework/js-helpers/wait-hrmp-channel-opened.js
      within 300 secs" didn't complete on time.`~ The issue was an obsolete
      `polkadot-js-api` binary - did `yarn global upgrade` and it is ok now
    • Francisco Aguirre's avatar
      Deprecate XCMv2 (#4131) · 9201f9ab
      Francisco Aguirre authored
      
      Marked XCMv2 as deprecated now that we have XCMv4.
      It will be removed sometime around June 2024.
      
      ---------
      
      Co-authored-by: default avatarBranislav Kontur <bkontur@gmail.com>
  3. May 24, 2024
    • Branislav Kontur's avatar
    • Andrei Sandu's avatar
      availability-recovery: bump chunk fetch threshold to 1MB for Polkadot and 4MB... · f469fbfb
      Andrei Sandu authored
      availability-recovery: bump chunk fetch threshold to 1MB for Polkadot and 4MB for Kusama + testnets (#4399)
      
      Doing this change ensures that we minimize the CPU usage we spend in
      reed-solomon by only doing the re-encoding into chunks if PoV size is
      less than 4MB (which means all PoVs right now)
       
      Based on susbystem benchmark results we concluded that it is safe to
      bump this number higher. At worst case scenario the network pressure for
      a backing group of 5 is around 25% of the network bandwidth in hw specs.
      
      Assuming 6s block times (max_candidate_depth 3) and needed_approvals 30
      the amount of bandwidth usage of a backing group used would hover above
      `30 * 4 * 3 = 360MB` per relay chain block. Given a backing group of 5
      that gives 72MB per block per validator -> 12 MB/s.
      
      <details>
      <summary>Reality check on Kusama PoV sizes (click for chart)</summary>
      <br>
      <img width="697" alt="Screenshot 2024-05-07 at 14 30 38"
      src="https://github.com/paritytech/polkadot-sdk/assets/54316454/bfed32d4-8623-48b0-9ec0-8b95dd2a9d8c">
      </details>
      
      ---------
      
      Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>
    • Oliver Tale-Yazdi's avatar
      Polkadot-SDK Umbrella Crate (#3935) · 1c7a1a58
      Oliver Tale-Yazdi authored
      # Umbrella Crate
      
      The Polkadot-SDK "umbrella" is a crate that re-exports all other
      published crates. This makes it
      possible to have a very small `Cargo.toml` file that only has one
      dependency, the umbrella
      crate. This helps with selecting the right combination of crate
      versions, since otherwise 3rd
      party tools are needed to select a compatible set of versions.
      
      ## Features
      
      The umbrella crate supports no-std builds and can therefore be used in
      the runtime and node.
      There are two main features: `runtime` and `node`. The `runtime` feature
      enables all `no-std`
      crates, while the `node` feature enables all `std` crates. It should be
      used like any other
      crate in the repo, with `default-features = false`.
      
      For more fine-grained control, additionally, each crate can be enabled
      selectively. The umbrella
      exposes one feature per dependency. For example, if you only want to use
      the `frame-support`
      crate, you can enable the `frame-support` feature.
      
      The umbrella exposes a few more g...
    • Oliver Tale-Yazdi's avatar
      Remove litep2p git dependency (#4560) · 49bd6a6e
      Oliver Tale-Yazdi authored
      @serban300
      
       could you please do the same for the MMR crate? Am not sure
      what commit was released since there are no release tags in the repo.
      
      ---------
      
      Signed-off-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
    • Branislav Kontur's avatar
      Attempt to avoid specifying `BlockHashCount` for different... · ef144b1a
      Branislav Kontur authored
      Attempt to avoid specifying `BlockHashCount` for different `mocking::{MockBlock, MockBlockU32, MockBlockU128}` (#4543)
      
      While doing some migration/rebase I came in to the situation, where I
      needed to change `mocking::MockBlock` to `mocking::MockBlockU32`:
      ```
      #[derive_impl(frame_system::config_preludes::TestDefaultConfig)]
      impl frame_system::Config for TestRuntime {
      	type Block = frame_system::mocking::MockBlockU32<TestRuntime>;
      	type AccountData = pallet_balances::AccountData<ThisChainBalance>;
      }
      ```
      But actual `TestDefaultConfig` for `frame_system` is using `ConstU64`
      for `type BlockHashCount = frame_support::traits::ConstU64<10>;`
      [here](https://github.com/paritytech/polkadot-sdk/blob/master/substrate/frame/system/src/lib.rs#L303).
      Because of this, it force me to specify and add override for `type
      BlockHashCount = ConstU32<10>`.
      
      This PR tries to fix this with `TestBlockHashCount` implementation for
      `TestDefaultConfig` which supports `u32`, `u64` and `u128` as a
      `BlockNumber`.
      
      ### How to simulate error
      Just by removing `type BlockHashCount = ConstU32<250>;`
      [here](https://github.com/paritytech/polkadot-sdk/blob/master/substrate/frame/multisig/src/tests.rs#L44)
      ```
      :~/parity/olkadot-sdk$ cargo test -p pallet-multisig
         Compiling pallet-multisig v28.0.0 (/home/bparity/parity/aaa/polkadot-sdk/substrate/frame/multisig)
      error[E0277]: the trait bound `ConstU64<10>: frame_support::traits::Get<u32>` is not satisfied
         --> substrate/frame/multisig/src/tests.rs:41:1
          |
      41  | #[derive_impl(frame_system::config_preludes::TestDefaultConfig)]
          | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `frame_support::traits::Get<u32>` is not implemented for `ConstU64<10>`
          |
          = help: the following other types implement trait `frame_support::traits::Get<T>`:
                    <ConstU64<T> as frame_support::traits::Get<u64>>
                    <ConstU64<T> as frame_support::traits::Get<std::option::Option<u64>>>
      note: required by a bound in `frame_system::Config::BlockHashCount`
         --> /home/bparity/parity/aaa/polkadot-sdk/substrate/frame/system/src/lib.rs:535:24
          |
      535 |         type BlockHashCount: Get<BlockNumberFor<Self>>;
          |                              ^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `Config::BlockHashCount`
          = note: this error originates in the attribute macro `derive_impl` which comes from the expansion of the macro `frame_support::macro_magic::forward_tokens_verbatim` (in Nightly builds, run with -Z macro-backtrace for more info)
      
      For more information about this error, try `rustc --explain E0277`.
      error: could not compile `pallet-multisig` (lib test) due to 1 previous error 
      ```
      
      
      
      
      ## For reviewers:
      
      (If there is a better solution, please let me know!)
      
      The first commit contains actual attempt to fix the problem:
      https://github.com/paritytech/polkadot-sdk/commit/3c5499e5
      
      .
      The second commit is just removal of `BlockHashCount` from all other
      places where not needed by default.
      
      Closes: https://github.com/paritytech/polkadot-sdk/issues/1657
      
      ---------
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
    • Serban Iorga's avatar
      Use polkadot-ckb-merkle-mountain-range dependency (#4562) · 700d5910
      Serban Iorga authored
      We need to use the `polkadot-ckb-merkle-mountain-range` dependency
      published on `crates.io` in order to unblock the release of the
      `sp-mmr-primitives` crate
  4. May 23, 2024
    • Francisco Aguirre's avatar
      Mention new XCM docs in sdk docs (#4558) · 48d4f654
      Francisco Aguirre authored
      The XCM docs were pretty much moved to the new rust docs format in
      https://github.com/paritytech/polkadot-sdk/pull/2633, with the addition
      of the XCM cookbook, which I plan to add more examples to shortly.
      
      These docs were not mentioned in the polkadot-sdk rust docs, this PR
      just mentions them there, so people can actually find them.
    • Serban Iorga's avatar
      Define `OpaqueValue` (#4550) · 03bbc17e
      Serban Iorga authored
      
      Define `OpaqueValue` and use it instead of
      `grandpa::OpaqueKeyOwnershipProof` and `beefy:OpaqueKeyOwnershipProof`
      
      Related to
      https://github.com/paritytech/polkadot-sdk/pull/4522#discussion_r1608278279
      
      We'll need to introduce a runtime API method that calls the
      `report_fork_voting_unsigned()` extrinsic. This method will need to
      receive the ancestry proof as a paramater. I'm still not sure, but there
      is a chance that we'll send the ancestry proof as an opaque type.
      
      So let's introduce this `OpaqueValue`. We can already use it to replace
      `grandpa::OpaqueKeyOwnershipProof` and `beefy:OpaqueKeyOwnershipProof`
      and maybe we'll need it for the ancestry proof as well.
      
      ---------
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
    • PG Herveou's avatar
      Contracts: Rework host fn benchmarks (#4233) · 493ba5e2
      PG Herveou authored
      
      fix https://github.com/paritytech/polkadot-sdk/issues/4163
      
      This PR does the following:
      Update to pallet-contracts-proc-macro: 
      - Parse #[cfg] so we can add a dummy noop host function for benchmark.
      - Generate BenchEnv::<host_fn> so we can call host functions directly in
      the benchmark.
      - Add the weight of the noop host function before calling the host
      function itself
      
      Update benchmarks:
      - Update all host function benchmark, a host function benchmark now
      simply call the host function, instead of invoking the function n times
      from within a contract.
      - Refactor RuntimeCosts & Schedule, for most host functions, we can now
      use the generated weight function directly instead of computing the diff
      with the cost! macro
      
      ```rust
      // Before
      #[benchmark(pov_mode = Measured)]
      fn seal_input(r: Linear<0, API_BENCHMARK_RUNS>) {
          let code = WasmModule::<T>::from(ModuleDefinition {
              memory: Some(ImportedMemory::max::<T>()),
              imported_functions: vec![ImportedFunction {
                  module: "seal0",
                  name: "seal_input",
                  params: vec![ValueType::I32, ValueType::I32],
                  return_type: None,
              }],
              data_segments: vec![DataSegment { offset: 0, value: 0u32.to_le_bytes().to_vec() }],
              call_body: Some(body::repeated(
                  r,
                  &[
                      Instruction::I32Const(4), // ptr where to store output
                      Instruction::I32Const(0), // ptr to length
                      Instruction::Call(0),
                  ],
              )),
              ..Default::default()
          });
      
          call_builder!(func, code);
      
          let res;
          #[block]
          {
              res = func.call();
          }
          assert_eq!(res.did_revert(), false);
      }
      ```
      
      ```rust
      // After
      fn seal_input(n: Linear<0, { code::max_pages::<T>() * 64 * 1024 - 4 }>) {
          let mut setup = CallSetup::<T>::default();
          let (mut ext, _) = setup.ext();
          let mut runtime = crate::wasm::Runtime::new(&mut ext, vec![42u8; n as usize]);
          let mut memory = memory!(n.to_le_bytes(), vec![0u8; n as usize],);
          let result;
          #[block]
          {
              result = BenchEnv::seal0_input(&mut runtime, &mut memory, 4, 0)
          }
          assert_ok!(result);
          assert_eq!(&memory[4..], &vec![42u8; n as usize]);
      }
      ``` 
      
      [Weights
      compare](https://weights.tasty.limo/compare?unit=weight&ignore_errors=true&threshold=10&method=asymptotic&repo=polkadot-sdk&old=master&new=pg%2Frework-host-benchs&path_pattern=substrate%2Fframe%2Fcontracts%2Fsrc%2Fweights.rs%2Cpolkadot%2Fruntime%2F*%2Fsrc%2Fweights%2F**%2F*.rs%2Cpolkadot%2Fbridges%2Fmodules%2F*%2Fsrc%2Fweights.rs%2Ccumulus%2F**%2Fweights%2F*.rs%2Ccumulus%2F**%2Fweights%2Fxcm%2F*.rs%2Ccumulus%2F**%2Fsrc%2Fweights.rs)
      
      ---------
      
      Co-authored-by: command-bot <>
      Co-authored-by: default avatarAlexander Theißen <alex.theissen@me.com>
    • Branislav Kontur's avatar
      Fix bridges grandpa benchmarks (#2577) (#4548) · a823d18f
      Branislav Kontur authored
      
      Cherry-picked fix from upcoming
      https://github.com/paritytech/polkadot-sdk/pull/4494
      
      ---------
      
      Co-authored-by: default avatarSvyatoslav Nikolsky <svyatonik@gmail.com>
      Co-authored-by: command-bot <>
    • Kian Paimani's avatar
      Fix README.md Logo URL (#4546) · fd161917
      Kian Paimani authored
      This one also works and it is easier.
  5. May 22, 2024
  6. May 21, 2024
    • Javier Viola's avatar
      chore: bump zombienet version (#4535) · ec46106c
      Javier Viola authored
      This version includes the latest release of pjs/api
      (https://github.com/polkadot-js/api/releases/tag/v11.1.1).
      Thx!
    • Dmitry Markin's avatar
      Replace `Multiaddr` & related types with substrate-specific types (#4198) · d05786ff
      Dmitry Markin authored
      This PR introduces custom types / substrate wrappers for `Multiaddr`,
      `multiaddr::Protocol`, `Multihash`, `ed25519::*` and supplementary types
      like errors and iterators.
      
      This is needed to unblock `libp2p` upgrade PR
      https://github.com/paritytech/polkadot-sdk/pull/1631 after
      https://github.com/paritytech/polkadot-sdk/pull/2944 was merged.
      `libp2p` and `litep2p` currently depend on different versions of
      `multiaddr` crate, and introduction of this "common ground" types is
      needed to support independent version upgrades of `multiaddr` and
      dependent crates in `libp2p` & `litep2p`.
      
      While being just convenient to not tie versions of `libp2p` & `litep2p`
      dependencies together, it's currently not even possible to keep `libp2p`
      & `litep2p` dependencies updated to the same versions as `multiaddr` in
      `libp2p` depends on `libp2p-identity` that we can't include as a
      dependency of `litep2p`, which has it's own `PeerId` type. In the
      future, to keep things updated on `litep2p` side, we will likely need to
      fork `multiaddr` and make it use `litep2p` `PeerId` as a payload of
      `/p2p/...` protocol.
      
      With these changes, common code in substrate uses these custom types,
      and `litep2p` & `libp2p` backends use corresponding libraries types.
    • Svyatoslav Nikolsky's avatar
      Bridge: added force_set_pallet_state call to pallet-bridge-grandpa (#4465) · e0e1f2d6
      Svyatoslav Nikolsky authored
      closes https://github.com/paritytech/parity-bridges-common/issues/2963
      
      See issue above for rationale
      I've been thinking about adding similar calls to other pallets, but:
      - for parachains pallet I haven't been able to think of a case when we
      will need that given how long referendum takes. I.e. if storage proof
      format changes and we want to unstuck the bridge, it'll take a large a
      few weeks to sync a single parachain header, then another weeks for
      another and etc.
      - for messages pallet I've made the similar call initially, but it just
      changes a storage key (`OutboundLanes` and/or `InboundLanes`), so
      there's no any logic here and it may be simply done using
      `system.set_storage`.
      
      ---------
      
      Co-authored-by: command-bot <>
    • Svyatoslav Nikolsky's avatar
      Fixed RPC subscriptions leak when subscription stream is finished (#4533) · d54feeb1
      Svyatoslav Nikolsky authored
      closes https://github.com/paritytech/parity-bridges-common/issues/3000
      
      Recently we've changed our bridge configuration for Rococo <> Westend
      and our new relayer has started to submit transactions every ~ `30`
      seconds. Eventually, it switches itself into limbo state, where it can't
      submit more transactions - all `author_submitAndWatchExtrinsic` calls
      are failing with the following error: `ERROR bridge Failed to send
      transaction to BridgeHubRococo node: Call(ErrorObject { code:
      ServerError(-32006), message: "Too many subscriptions on the
      connection", data: Some(RawValue("Exceeded max limit of 1024")) })`.
      
      Some links for those who want to explore:
      - server side (node) has a strict limit on a number of active
      subscriptions. It fails to open a new subscription if this limit is hit:
      https://github.com/paritytech/jsonrpsee/blob/a4533966b997e83632509ad97eea010fc7c3efc0/server/src/middleware/rpc/layer/rpc_service.rs#L122-L132.
      The limit is set to `1024` by default;
      - internally this limit is a semaphore with `limit` permits:
      https://github.com/paritytech/jsonrpsee/blob/a4533966b997e83632509ad97eea010fc7c3efc0/core/src/server/subscription.rs#L461-L485;
      - semaphore permit is acquired in the first link;
      - the permit is "returned" when the `SubscriptionSink` is dropped:
      https://github.com/paritytech/jsonrpsee/blob/a4533966b997e83632509ad97eea010fc7c3efc0/core/src/server/subscription.rs#L310-L325;
      - the `SubscriptionSink` is dropped when [this `polkadot-sdk`
      function](https://github.com/paritytech/polkadot-sdk/blob/278486f9/substrate/client/rpc/src/utils.rs#L58-L94)
      returns. In other words - when the connection is closed, the stream is
      finished or internal subscription buffer limit is hit;
      - the subscription has the internal buffer, so sending an item contains
      of two steps: [reading an item from the underlying
      stream](https://github.com/paritytech/polkadot-sdk/blob/278486f9/substrate/client/rpc/src/utils.rs#L125-L141)
      and [sending it over the
      connection](https://github.com/paritytech/polkadot-sdk/blob/278486f9/substrate/client/rpc/src/utils.rs#L111-L116);
      - when the underlying stream is finished, the `inner_pipe_from_stream`
      wants to ensure that all items are sent to the subscriber. So it: [waits
      until the current send operation
      completes](https://github.com/paritytech/polkadot-sdk/blob/278486f9/substrate/client/rpc/src/utils.rs#L146-L148)
      and then [send all remaining items from the internal
      buffer](https://github.com/paritytech/polkadot-sdk/blob/278486f9/substrate/client/rpc/src/utils.rs#L150-L155).
      Once it is done, the function returns, the `SubscriptionSink` is
      dropped, semaphore permit is dropped and we are ready to accept new
      subscriptions;
      - unfortunately, the code just calls the `pending_fut.await.is_err()` to
      ensure that [the current send operation
      completes](https://github.com/paritytech/polkadot-sdk/blob/278486f9/substrate/client/rpc/src/utils.rs#L146-L148).
      But if there are no current send operation (which is normal), then the
      `pending_fut` is set to terminated future and the `await` never
      completes. Hence, no return from the function, no drop of
      `SubscriptionSink`, no drop of semaphore permit, no new subscriptions
      allowed (once number of susbcriptions hits the limit.
      
      I've illustrated the issue with small test - you may ensure that if e.g.
      the stream is initially empty, the
      `subscription_is_dropped_when_stream_is_empty` will hang because
      `pipe_from_stream` never exits.
    • Branislav Kontur's avatar
    • Alin Dima's avatar
      Remove the prospective-parachains subsystem from collators (#4471) · 278486f9
      Alin Dima authored
      Implements https://github.com/paritytech/polkadot-sdk/issues/4429
      
      Collators only need to maintain the implicit view for the paraid they
      are collating on.
      In this case, bypass prospective-parachains entirely. It's still useful
      to use the GetMinimumRelayParents message from prospective-parachains
      for validators, because the data is already present there.
      
      This enables us to entirely remove the subsystem from collators, which
      consumed resources needlessly
      
      Aims to resolve https://github.com/paritytech/polkadot-sdk/issues/4167 
      
      TODO:
      - [x] fix unit tests
  7. May 20, 2024
  8. May 19, 2024