Skip to content
Snippets Groups Projects
Unverified Commit e6bd9205 authored by Alexandru Gheorghe's avatar Alexandru Gheorghe Committed by GitHub
Browse files

Fix 0007-dispute-freshly-finalized.zndsl failing (#3893)

Test started failing after
https://github.com/paritytech/polkadot-sdk/commit/66051adb


which enabled approval coalescing, that was expected to happen because
the test required an polkadot_parachain_approval_checking_finality_lag
of 0, which can't happen with max_approval_coalesce_count greater than 1
because we always delay the approval for no_show_duration_ticks/2 in
case we can coalesce it with other approvals.


So relax a bit the restrictions, since we don't actually care that the
lags are 0, but the fact the finalities are progressing and are not
stuck.

Signed-off-by: default avatarAlexandru Gheorghe <alexandru.gheorghe@parity.io>
parent b772cb57
No related merge requests found
Pipeline #461005 failed with stages
in 50 minutes and 26 seconds
......@@ -21,9 +21,9 @@ honest: reports polkadot_parachain_candidate_dispute_concluded{validity="valid"}
honest: reports polkadot_parachain_candidate_dispute_concluded{validity="invalid"} is 0 within 100 seconds
# Check lag - approval
honest: reports polkadot_parachain_approval_checking_finality_lag is 0
honest: reports polkadot_parachain_approval_checking_finality_lag is lower than 2
# Check lag - dispute conclusion
honest: reports polkadot_parachain_disputes_finality_lag is 0
honest: reports polkadot_parachain_disputes_finality_lag is lower than 2
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment