cumulus: bump PARENT_SEARCH_DEPTH and add test for 12-core elastic scaling (#6983)
On top of https://github.com/paritytech/polkadot-sdk/pull/6757 Fixes https://github.com/paritytech/polkadot-sdk/issues/6858 by bumping the `PARENT_SEARCH_DEPTH` constant to a larger value (30) and adds a zombienet-sdk test that exercises the 12-core scenario. This is a node-side limit that restricts the number of allowed pending availability candidates when choosing the parent parablock during authoring. This limit is rather redundant, as the parachain runtime already restricts the unincluded segment length to the configured value in the [FixedVelocityConsensusHook](https://github.com/paritytech/polkadot-sdk/blob/88d900af /cumulus/pallets/aura-ext/src/consensus_hook.rs#L35) (which ideally should be equal to this `PARENT_SEARCH_DEPTH`). For 12 cores, a value of 24 should be enough, but I bumped it to 30 to have some extra buffer. There are two other potential ways of fixing this: - remove this constant altogether, as the parachain runtime already makes those guarantees. Chose not to do this, as it can't hurt to have an extra safeguard - set this value to be equal to the uninlcuded segment size. This value however is not exposed to the node-side and would require a new runtime API, which seems overkill for a redundant check. --------- Co-authored-by:Javier Viola <javier@parity.io>
parent
b30aa319
Showing
- .gitlab/pipeline/zombienet/polkadot.yml 17 additions, 0 deletions.gitlab/pipeline/zombienet/polkadot.yml
- cumulus/client/consensus/aura/src/collators/mod.rs 4 additions, 3 deletionscumulus/client/consensus/aura/src/collators/mod.rs
- cumulus/test/runtime/Cargo.toml 1 addition, 0 deletionscumulus/test/runtime/Cargo.toml
- cumulus/test/runtime/build.rs 8 additions, 0 deletionscumulus/test/runtime/build.rs
- cumulus/test/runtime/src/lib.rs 16 additions, 12 deletionscumulus/test/runtime/src/lib.rs
- cumulus/test/service/src/chain_spec.rs 10 additions, 0 deletionscumulus/test/service/src/chain_spec.rs
- cumulus/test/service/src/cli.rs 6 additions, 0 deletionscumulus/test/service/src/cli.rs
- polkadot/zombienet-sdk-tests/tests/elastic_scaling/mod.rs 1 addition, 0 deletionspolkadot/zombienet-sdk-tests/tests/elastic_scaling/mod.rs
- polkadot/zombienet-sdk-tests/tests/elastic_scaling/slot_based_12cores.rs 129 additions, 0 deletions...net-sdk-tests/tests/elastic_scaling/slot_based_12cores.rs
- prdoc/pr_6983.prdoc 17 additions, 0 deletionsprdoc/pr_6983.prdoc
Please register or sign in to comment